flk 0.6.3

A CLI tool for managing flake.nix devShell environments
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
//! # Package Section Parser
//!
//! Parser for the `packages = [ ... ];` section in profile files.
//!
//! This module provides functionality to parse, add, and remove packages
//! from profile files while preserving formatting and comments.
//!
//! ## Supported Syntax
//!
//! ```nix
//! packages = [
//!   pkgs.ripgrep
//!   pkgs.rust-bin.stable.latest.default  # From rust-overlay
//!   pkgs."openssl@3.6.0"  # Version pinned
//!   (pkgs.rust-bin.stable.latest.default.override { extensions = [ "clippy" ]; })
//! ];
//! ```
//!
//! Entries that aren't bare `pkgs.<name>` (e.g. parenthesized expressions
//! containing nested lists/attrsets) are recognized via balanced-bracket
//! scanning and recorded best-effort by extracting the first `pkgs.<path>`
//! reference inside them.

use crate::flake::interfaces::profiles::Package;
use crate::flake::parsers::utils::{
    byte_offset, detect_indentation, multiws, opt_attribute_version, opt_inline_comment,
    pkgs_suffix, ws,
};
use anyhow::{Context, Result};
use nom::Parser;
use nom::{
    bytes::complete::tag,
    character::complete::{char, line_ending},
    combinator::opt,
    sequence::delimited,
    IResult,
};

/// A parsed package entry with position information.
#[derive(Debug, Clone)]
pub struct PackageEntry {
    /// Package name (without `pkgs.` prefix)
    pub name: String,
    /// Optional version if pinned
    pub version: Option<String>,
    /// Optional inline comment
    pub _comment: Option<String>,
    /// Byte position where this entry starts
    pub start_pos: usize,
    /// Byte position where this entry ends
    pub end_pos: usize,
}

/// Parsed packages section with editing support.
#[derive(Debug)]
pub struct PackagesSection {
    /// All package entries in the section
    pub entries: Vec<PackageEntry>,
    /// Detected indentation for consistent formatting
    pub indentation: String,
    /// Byte position of the list start bracket
    pub _list_start: usize,
    /// Byte position of the list end bracket
    pub list_end: usize,
    /// Byte position where the section starts
    pub _section_start: usize,
    /// Byte position where the section ends
    pub _section_end: usize,
}

/// Parse "with pkgs;" prefix (optional)
fn with_pkgs(input: &str) -> IResult<&str, Option<&str>> {
    opt(delimited(ws, tag("with pkgs;"), ws)).parse(input)
}

/// Parse a single package entry with optional comment
fn package_entry<'a>(
    input: &'a str,
    base_offset: usize,
    original_input: &'a str,
) -> IResult<&'a str, PackageEntry> {
    let start_pos = base_offset + byte_offset(original_input, input);

    let (remaining, _) = multiws(input)?;
    let (remaining, name) = pkgs_suffix(remaining)?;
    let (remaining, version) = opt_attribute_version(remaining)?;
    // Consume the closing quote of `pkgs."name@version"` if present —
    // pkgs_suffix only matched up to the `@` of the name.
    let (remaining, _) = opt(char('"')).parse(remaining)?;
    let (remaining, comment) = opt_inline_comment(remaining)?;
    let (remaining, _) = opt(line_ending).parse(remaining)?;

    let end_pos = base_offset + byte_offset(original_input, remaining);

    Ok((
        remaining,
        PackageEntry {
            name: name.to_string(),
            version: version.map(|v| v.to_string()),
            _comment: comment.map(|c| c.trim().to_string()),
            start_pos,
            end_pos,
        },
    ))
}

/// Parse the full packages section with nom
fn parse_packages(input: &str, base_offset: usize) -> IResult<&str, Vec<PackageEntry>> {
    let original_input = input; // Store original for offset calculations

    let (input, _) = ws(input)?;
    let (input, _) = with_pkgs(input)?;
    let (input, _) = ws(input)?;
    let (input, _) = char('[')(input)?;

    // Parse all package entries
    let mut entries = Vec::new();
    let mut remaining = input;

    loop {
        // Skip whitespace
        let (rest, _) = multiws(remaining)?;

        // Check for closing bracket
        if rest.starts_with(']') {
            remaining = rest;
            break;
        }

        // Try to parse package entry
        match package_entry(rest, base_offset, original_input) {
            Ok((rest, entry)) => {
                entries.push(entry);
                remaining = rest;
            }
            Err(_) => {
                // Not a simple `pkgs.X` entry — could be a parenthesized
                // expression like `(pkgs.X.override { ... })` or a bare
                // identifier from a `let` binding. Skip over a balanced
                // expression so nested `]`/`}`/`)` don't terminate the list.
                let value_start = base_offset + byte_offset(original_input, rest);
                let after = skip_value(rest);
                let value_end = base_offset + byte_offset(original_input, after);
                let value_str = &rest[..value_end - value_start];

                if let Some(name) = try_extract_pkgs_path(value_str) {
                    entries.push(PackageEntry {
                        name,
                        version: None,
                        _comment: None,
                        start_pos: value_start,
                        end_pos: value_end,
                    });
                }

                if std::ptr::eq(after.as_ptr(), rest.as_ptr()) {
                    // No progress — bail to avoid infinite loop.
                    break;
                }
                remaining = after;
            }
        }
    }

    let (input, _) = char(']')(remaining)?;
    let (input, _) = ws(input)?;
    let (input, _) = char(';')(input)?;

    Ok((input, entries))
}

/// Skip past one Nix value expression, tracking nesting of `()`/`[]`/`{}`
/// and ignoring brackets inside strings and comments. Returns the remaining
/// input after the value.
fn skip_value(input: &str) -> &str {
    let bytes = input.as_bytes();
    let mut i = 0;
    let mut depth: usize = 0;
    let mut entered = false;

    while i < bytes.len() {
        let c = bytes[i];

        if c == b'#' {
            while i < bytes.len() && bytes[i] != b'\n' {
                i += 1;
            }
            continue;
        }
        if c == b'\'' && i + 1 < bytes.len() && bytes[i + 1] == b'\'' {
            i += 2;
            while i + 1 < bytes.len() && !(bytes[i] == b'\'' && bytes[i + 1] == b'\'') {
                i += 1;
            }
            i = (i + 2).min(bytes.len());
            entered = true;
            if depth == 0 {
                return &input[i..];
            }
            continue;
        }
        if c == b'"' {
            i += 1;
            while i < bytes.len() && bytes[i] != b'"' {
                if bytes[i] == b'\\' && i + 1 < bytes.len() {
                    i += 2;
                } else {
                    i += 1;
                }
            }
            if i < bytes.len() {
                i += 1;
            }
            entered = true;
            if depth == 0 {
                return &input[i..];
            }
            continue;
        }
        match c {
            b'(' | b'[' | b'{' => {
                depth += 1;
                entered = true;
                i += 1;
            }
            b')' | b'}' => {
                depth = depth.saturating_sub(1);
                i += 1;
                if depth == 0 {
                    return &input[i..];
                }
            }
            b']' => {
                if depth == 0 {
                    return &input[i..]; // outer list close — let caller handle
                }
                depth -= 1;
                i += 1;
                if depth == 0 {
                    return &input[i..];
                }
            }
            b' ' | b'\t' | b'\n' | b'\r' if depth == 0 => {
                if entered {
                    return &input[i..];
                }
                i += 1;
            }
            _ => {
                entered = true;
                i += 1;
            }
        }
    }
    &input[i..]
}

/// Best-effort extraction of a `pkgs.<path>` reference from inside a complex
/// expression, used to give parenthesized entries like
/// `(pkgs.rust-bin.stable.latest.default.override { ... })` a recognizable name.
fn try_extract_pkgs_path(value: &str) -> Option<String> {
    let pos = value.find("pkgs.")?;
    pkgs_suffix(&value[pos..])
        .ok()
        .map(|(_, name)| name.to_string())
}

/// Parse the packages section from profile file content.
///
/// # Arguments
///
/// * `content` - The full profile file content
///
/// # Returns
///
/// A `PackagesSection` containing all parsed entries with position information.
///
/// # Errors
///
/// Returns an error if the `packages =` section cannot be found or parsed.
pub fn parse_packages_section(content: &str) -> Result<PackagesSection> {
    let section_start = content
        .find("packages =")
        .context("Could not find 'packages ='")?;

    let parse_from = section_start + "packages =".len();
    let to_parse = &content[parse_from..];

    match parse_packages(to_parse, parse_from) {
        Ok((remaining, entries)) => {
            let list_start = content[parse_from..]
                .find('[')
                .context("Could not find '['")?
                + parse_from
                + 1;

            let section_end = parse_from + byte_offset(to_parse, remaining);

            let list_end = content[list_start..section_end]
                .rfind(']')
                .context("Could not find ']'")?
                + list_start;

            let list_content = &content[list_start..list_end];
            let indentation = detect_indentation(list_content);

            Ok(PackagesSection {
                entries,
                indentation,
                _list_start: list_start,
                list_end,
                _section_start: section_start,
                _section_end: section_end,
            })
        }
        Err(e) => Err(anyhow::anyhow!("Failed to parse packages section: {:?}", e)),
    }
}

impl PackagesSection {
    /// Convert parsed entries to a list of [`Package`] structs.
    pub fn to_packages(&self) -> Vec<Package> {
        self.entries
            .iter()
            .map(|e| Package::new(e.name.clone()))
            .collect()
    }

    /// Add a package to the section, returning the modified file content.
    ///
    /// If the package already exists, returns the original content unchanged.
    ///
    /// # Arguments
    ///
    /// * `original_content` - The full file content
    /// * `name` - Package name to add (with or without `pkgs.` prefix)
    /// * `comment` - Optional inline comment
    pub fn add_package(&self, original_content: &str, name: &str, comment: Option<&str>) -> String {
        // Check if exists
        if self.entries.iter().any(|e| e.name == name) {
            return original_content.to_string();
        }

        let new_entry = if let Some(cmt) = comment {
            format!("{}{} # {}\n", self.indentation, name, cmt)
        } else {
            format!("{}{}\n", self.indentation, name)
        };

        let insertion_point = original_content[..self.list_end]
            .rfind('\n')
            .map(|pos| pos + 1)
            .unwrap_or(self.list_end);

        let mut result = String::new();
        result.push_str(&original_content[..insertion_point]);
        result.push_str(&new_entry);
        result.push_str(&original_content[insertion_point..]);

        result
    }

    /// Remove a package from the section, returning the modified file content.
    ///
    /// # Arguments
    ///
    /// * `original_content` - The full file content
    /// * `name` - Package name to remove
    ///
    /// # Errors
    ///
    /// Returns an error if the package is not found.
    pub fn remove_package(&self, original_content: &str, name: &str) -> Result<String> {
        let entry = self
            .entries
            .iter()
            .find(|e| e.name == name)
            .context(format!("Package '{}' not found", name))?;

        let start_line = original_content[..entry.start_pos]
            .rfind('\n')
            .map(|pos| pos + 1)
            .unwrap_or(0);

        let before = &original_content[..start_line];
        let after = &original_content[entry.end_pos + 1..];

        let after = after.strip_prefix('\n').unwrap_or(after);

        Ok(format!("{}{}", before, after))
    }

    /// Check whether a package with the given name already exists in the section.
    pub fn package_exists(&self, name: &str) -> bool {
        self.entries
            .iter()
            .any(|e| e.name == name || e.name == format!("pkgs.{}", name))
    }
}

/// Extract package information from `nix search` output.
///
/// Used by the search command to parse nix search results into
/// a list of packages.
pub fn extract_packages_from_output(output: &str) -> Result<Vec<Package>> {
    Ok(output
        .lines()
        .skip(1)
        .filter_map(|line| {
            let parts: Vec<&str> = line.split_whitespace().collect();
            if parts.len() >= 4 {
                Some(Package {
                    name: parts[0].to_string(),
                    version: Some(parts[1].to_string()),
                })
            } else {
                None
            }
        })
        .collect())
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_parse_packages() {
        let content = r#"{
  packages = [
    pkgs.rust-bin.stable.latest.default  # From rust-overlay
    pkgs.rust-analyzer
    pkgs.pkg-config
  ];
}"#;

        let section = parse_packages_section(content).unwrap();
        println!("{:#?}", section);
        assert_eq!(section.entries.len(), 3);
        assert_eq!(section.entries[0].name, "rust-bin.stable.latest.default");
        assert_eq!(
            section.entries[0]._comment,
            Some("From rust-overlay".to_string())
        );
        assert_eq!(section.entries[1].name, "rust-analyzer");
    }

    #[test]
    fn test_add_package() {
        let content = r#"{
  packages = [
    pkgs.rust-analyzer
  ];
}"#;

        let section = parse_packages_section(content).unwrap();
        let new_content = section.add_package(content, "cargo-watch", Some("For watching"));

        assert!(new_content.contains("cargo-watch # For watching"));
    }

    #[test]
    fn test_remove_package() {
        let content = r#"{
  packages = [
    pkgs.rust-analyzer
    pkgs.cargo-watch
  ];
}"#;

        let section = parse_packages_section(content).unwrap();
        let new_content = section.remove_package(content, "cargo-watch").unwrap();

        assert!(!new_content.contains("cargo-watch"));
        assert!(new_content.contains("rust-analyzer"));
    }

    #[test]
    fn test_add_package_with_version() {
        let content = r#"{
  packages = [
    pkgs.rust-analyzer
  ];
}"#;

        let section = parse_packages_section(content).unwrap();
        let new_content = section.add_package(
            content,
            "pkgs.\"versioned_pkg@1.0.0\"",
            Some("For versions"),
        );
        println!("{}", new_content);

        assert!(new_content.contains("pkgs.\"versioned_pkg@1.0.0\" # For versions"));
    }

    #[test]
    fn test_remove_package_with_version() {
        let content = r#"{
  packages = [
    pkgs.rust-analyzer
    pkgs."cargo-watch@2.0.0"
  ];
}"#;

        let section = parse_packages_section(content).unwrap();
        let new_content = section.remove_package(content, "cargo-watch").unwrap();

        assert!(!new_content.contains("cargo-watch"));
        assert!(new_content.contains("rust-analyzer"));
    }

    #[test]
    fn test_parse_packages_with_parenthesized_override() {
        // Reproduces the rust profile shape that previously broke the parser:
        // an `(pkgs.X.override { extensions = [...]; })` entry whose nested
        // `]` made the loop exit before reaching the rest of the list.
        let content = r#"{pkgs, ...}: {
  packages = [
    (pkgs.rust-bin.stable.latest.default.override {
      extensions = [
        "clippy"
        "llvm-tools-preview"
        "rust-src"
        "rust-analyzer"
      ];
    })
    pkgs.pkg-config
    pkgs.openssl
    pkgs.cargo-watch
    pkgs.cargo-edit
    pkgs.cargo-dist
    pkgs.release-plz
    pkgs.cargo-llvm-cov
  ];
}"#;
        let section = parse_packages_section(content).unwrap();
        let names: Vec<&str> = section.entries.iter().map(|e| e.name.as_str()).collect();
        assert_eq!(
            names,
            vec![
                "rust-bin.stable.latest.default.override",
                "pkg-config",
                "openssl",
                "cargo-watch",
                "cargo-edit",
                "cargo-dist",
                "release-plz",
                "cargo-llvm-cov",
            ]
        );
    }

    #[test]
    fn test_parse_packages_with_let_bound_identifier() {
        // Bare identifiers (from a let binding above) should be skipped without
        // breaking detection of subsequent `pkgs.X` entries.
        let content = r#"{pkgs, ...}: let
  rustToolchain = pkgs.rust-bin.stable.latest.default;
in {
  packages = [
    rustToolchain
    pkgs.pkg-config
  ];
}"#;
        let section = parse_packages_section(content).unwrap();
        let names: Vec<&str> = section.entries.iter().map(|e| e.name.as_str()).collect();
        assert_eq!(names, vec!["pkg-config"]);
    }

    #[test]
    fn test_extract_packages_from_output_skips_header_and_invalid_lines() {
        let output = r#"Name Version Description
ripgrep 14.1.0 x86_64-linux Fast grep
invalid line
fd 9.0.0 x86_64-linux Fast find
"#;

        let packages = extract_packages_from_output(output).unwrap();

        assert_eq!(packages.len(), 2);
        assert_eq!(packages[0].name, "ripgrep");
        assert_eq!(packages[0].version.as_deref(), Some("14.1.0"));
        assert_eq!(packages[1].name, "fd");
        assert_eq!(packages[1].version.as_deref(), Some("9.0.0"));
    }
}