fli 1.2.2

The commander.js like CLI Parser for rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
use crate::command::FliCommand;
use crate::option_parser::{CommandChain, InputArgsParser, Value, ValueTypes};

// Helper function to create a basic command with options
fn create_test_command() -> FliCommand {
    let mut cmd = FliCommand::new("test", "Test command");

    // Add various option types
    cmd.add_option(
        "verbose",
        "Verbose output",
        "-v",
        "--verbose",
        ValueTypes::OptionalSingle(Some(Value::Bool(false))),
    );
    cmd.add_option(
        "quiet",
        "Quiet mode",
        "-q",
        "--quiet",
        ValueTypes::OptionalSingle(Some(Value::Bool(false))),
    );
    cmd.add_option(
        "output",
        "Output file",
        "-o",
        "--output",
        ValueTypes::RequiredSingle(Value::Str(String::new())),
    );
    cmd.add_option(
        "count",
        "Number of items",
        "-n",
        "--count",
        ValueTypes::OptionalSingle(Some(Value::Int(10))),
    );
    cmd.add_option(
        "files",
        "Input files",
        "-f",
        "--files",
        ValueTypes::RequiredMultiple(vec![], None),
    );

    cmd
}

// Helper function to create a command with subcommands
fn create_command_with_subcommands() -> FliCommand {
    let mut root = FliCommand::new("app", "Main app");
    root.add_option(
        "verbose",
        "Verbose",
        "-v",
        "--verbose",
        ValueTypes::OptionalSingle(Some(Value::Bool(false))),
    );

    root.subcommand("start", "Start service").add_option(
        "port",
        "Port",
        "-p",
        "--port",
        ValueTypes::OptionalSingle(Some(Value::Int(8080))),
    );

    root.subcommand("stop", "Stop service").add_option(
        "force",
        "Force stop",
        "-f",
        "--force",
        ValueTypes::OptionalSingle(Some(Value::Bool(false))),
    );

    root
}

// ============================================================================
// Basic Parsing Tests
// ============================================================================

#[test]
fn test_empty_args() {
    let args: Vec<String> = vec![];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    let result = parser.prepare(&mut cmd);
    assert!(result.is_ok());

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 0);
}

#[test]
fn test_single_flag_option() {
    let args = vec!["-v".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 1);

    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "-v");
            assert!(matches!(
                value,
                ValueTypes::OptionalSingle(Some(Value::Bool(true)))
            ));
        }
        _ => panic!("Expected Option variant"),
    }
}

#[test]
fn test_option_not_passed_results_in_empty_chain() {
    // When options with ValueTypes::OptionalSingle(Some(Value::Bool(false))) are NOT passed, they don't appear in chain
    let args = vec![]; // No -v flag passed
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    // Chain should be empty since no arguments were provided
    assert_eq!(
        chain.len(),
        0,
        "Expected empty chain when no options are passed"
    );
}

#[test]
fn test_long_flag_option() {
    let args = vec!["--verbose".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 1);

    match &chain[0] {
        CommandChain::Option(flag, _) => {
            assert_eq!(flag, "--verbose");
        }
        _ => panic!("Expected Option variant"),
    }
}

#[test]
fn test_option_with_value() {
    let args = vec!["-o".to_string(), "output.txt".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 1);

    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "-o");
            match value {
                ValueTypes::RequiredSingle(Value::Str(s)) => {
                    assert_eq!(s, "output.txt");
                }
                _ => panic!("Expected RequiredSingle(Str)"),
            }
        }
        _ => panic!("Expected Option variant"),
    }
}

#[test]
fn test_long_option_with_value() {
    let args = vec!["--output".to_string(), "result.txt".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "--output");
            match value {
                ValueTypes::RequiredSingle(Value::Str(s)) => {
                    assert_eq!(s, "result.txt");
                }
                _ => panic!("Expected string value"),
            }
        }
        _ => panic!("Expected Option variant"),
    }
}

#[test]
fn test_multiple_flags() {
    let args = vec!["-v".to_string(), "-q".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 2);

    match &chain[0] {
        CommandChain::Option(flag, _) => assert_eq!(flag, "-v"),
        _ => panic!("Expected first option to be -v"),
    }

    match &chain[1] {
        CommandChain::Option(flag, _) => assert_eq!(flag, "-q"),
        _ => panic!("Expected second option to be -q"),
    }
}

#[test]
fn test_positional_arguments() {
    let args = vec!["file1.txt".to_string(), "file2.txt".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();
    cmd.set_expected_positional_args(2); // Tell parser to expect 2 arguments

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 2);

    match &chain[0] {
        CommandChain::Argument(arg) => assert_eq!(arg, "file1.txt"),
        _ => panic!("Expected Argument variant, got {:?}", chain[0]),
    }

    match &chain[1] {
        CommandChain::Argument(arg) => assert_eq!(arg, "file2.txt"),
        _ => panic!("Expected Argument variant, got {:?}", chain[1]),
    }
} // ============================================================================
  // Mixed Options and Arguments Tests
  // ============================================================================

#[test]
fn test_flags_before_arguments() {
    // Note: Parser state machine doesn't allow transitioning from InOption to InArgument
    // Use -- separator or ensure arguments come in valid states
    let args = vec![
        "-v".to_string(),
        "--".to_string(), // Breaking state allows transition to InArgument
        "file1.txt".to_string(),
        "file2.txt".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-v), Argument(file1.txt), Argument(file2.txt)]
    let has_verbose = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-v"));
    assert!(has_verbose, "Expected -v option in chain");

    let has_file1 = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "file1.txt"));
    assert!(has_file1, "Expected file1.txt argument in chain");

    let has_file2 = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "file2.txt"));
    assert!(has_file2, "Expected file2.txt argument in chain");
}

#[test]
fn test_option_with_value_and_arguments() {
    // Use -- separator to allow arguments after option with value
    let args = vec![
        "-o".to_string(),
        "output.txt".to_string(),
        "--".to_string(),
        "input.txt".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-o, output.txt), Argument(input.txt)]
    let has_output_option = chain.iter().any(|item| match item {
        CommandChain::Option(flag, value) => {
            if flag == "-o" {
                matches!(value, ValueTypes::RequiredSingle(Value::Str(s)) if s == "output.txt")
            } else {
                false
            }
        }
        _ => false,
    });
    assert!(
        has_output_option,
        "Expected -o option with output.txt value"
    );

    let has_input_arg = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "input.txt"));
    assert!(has_input_arg, "Expected input.txt argument");
}

#[test]
fn test_multiple_options_with_values() {
    let args = vec![
        "-o".to_string(),
        "out.txt".to_string(),
        "-n".to_string(),
        "5".to_string(),
        "-v".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-o, out.txt), Option(-n, 5), Option(-v)]
    assert_eq!(chain.len(), 3);
}

#[test]
fn test_double_dash_separator() {
    let args = vec![
        "-v".to_string(),
        "--".to_string(),
        "-o".to_string(),
        "file.txt".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-v), Argument(-o), Argument(file.txt)]
    // After --, everything should be treated as arguments
    assert!(chain.len() >= 2);

    match &chain[0] {
        CommandChain::Option(flag, _) => assert_eq!(flag, "-v"),
        _ => panic!("Expected first to be an option"),
    }

    // After --, -o should be treated as argument, not option
    let has_argument_o = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "-o"));
    assert!(
        has_argument_o,
        "Expected -o to be treated as argument after --"
    );
}

// ============================================================================
// Subcommand Tests
// ============================================================================

#[test]
fn test_subcommand_parsing() {
    let args = vec!["start".to_string()];
    let mut parser = InputArgsParser::new("app".to_string(), args);
    let mut cmd = create_command_with_subcommands();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [SubCommand(start)]
    assert_eq!(chain.len(), 1);

    match &chain[0] {
        CommandChain::SubCommand(name) => assert_eq!(name, "start"),
        _ => panic!("Expected SubCommand variant"),
    }
}

#[test]
fn test_subcommand_with_options() {
    let args = vec!["start".to_string(), "-p".to_string(), "3000".to_string()];
    let mut parser = InputArgsParser::new("app".to_string(), args);
    let mut cmd = create_command_with_subcommands();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [SubCommand(start), Option(-p, 3000)]
    assert!(chain.len() >= 1);

    match &chain[0] {
        CommandChain::SubCommand(name) => assert_eq!(name, "start"),
        _ => panic!("Expected SubCommand"),
    }
}

#[test]
fn test_root_option_before_subcommand() {
    let args = vec!["-v".to_string(), "start".to_string()];
    let mut parser = InputArgsParser::new("app".to_string(), args);
    let mut cmd = create_command_with_subcommands();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-v), SubCommand(start)]
    assert_eq!(chain.len(), 2);

    match &chain[0] {
        CommandChain::Option(flag, _) => assert_eq!(flag, "-v"),
        _ => panic!("Expected Option first"),
    }

    match &chain[1] {
        CommandChain::SubCommand(name) => assert_eq!(name, "start"),
        _ => panic!("Expected SubCommand second"),
    }
}

// ============================================================================
// Complex Scenarios
// ============================================================================

#[test]
fn test_complex_command_chain() {
    // Use proper separator to allow mixing options and arguments
    let args = vec![
        "-v".to_string(),
        "-o".to_string(),
        "output.txt".to_string(),
        "--".to_string(), // Separator to switch to arguments
        "file1.txt".to_string(),
        "file2.txt".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Expected: [Option(-v), Option(-o, output.txt), Argument(file1.txt),
    //            Argument(file2.txt)]

    // Verify structure
    let has_verbose = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-v"));
    assert!(has_verbose, "Expected -v option");

    let has_output = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-o"));
    assert!(has_output, "Expected -o option");

    let has_file1 = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "file1.txt"));
    assert!(has_file1, "Expected file1.txt argument");

    let has_file2 = chain
        .iter()
        .any(|item| matches!(item, CommandChain::Argument(arg) if arg == "file2.txt"));
    assert!(has_file2, "Expected file2.txt argument");
}

#[test]
fn test_help_flag_as_preserved_option() {
    let args = vec!["--help".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Help flag should appear in chain (might be IsPreservedOption or Option)
    assert!(chain.len() >= 1);

    let has_help = chain.iter().any(|item| match item {
        CommandChain::IsPreservedOption(flag) => flag == "--help",
        CommandChain::Option(flag, _) => flag == "--help",
        _ => false,
    });
    assert!(has_help);
}

#[test]
fn test_numeric_option_parsing() {
    let args = vec!["--count".to_string(), "42".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "--count");
            match value {
                ValueTypes::OptionalSingle(Some(Value::Int(n))) => {
                    assert_eq!(*n, 42);
                }
                _ => panic!("Expected OptionalSingle(Int(42))"),
            }
        }
        _ => panic!("Expected Option variant"),
    }
}

#[test]
fn test_multiple_value_option() {
    let args = vec![
        "-f".to_string(),
        "file1.txt".to_string(),
        "file2.txt".to_string(),
        "file3.txt".to_string(),
    ];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let chain = parser.get_parsed_commands_chain();

    // Should have at least one option for -f
    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "-f");
            match value {
                ValueTypes::RequiredMultiple(_, _) => {
                    // Successfully parsed as multiple values
                }
                _ => panic!("Expected RequiredMultiple"),
            }
        }
        _ => panic!("Expected Option variant"),
    }
}

// ============================================================================
// Edge Cases and Error Scenarios
// ============================================================================

#[test]
fn test_unknown_option() {
    let args = vec!["-x".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    let result = parser.prepare(&mut cmd);

    // Unknown option should result in error or be treated as argument
    // depending on implementation
    assert!(result.is_ok() || result.is_err());
}

#[test]
fn test_missing_required_value() {
    let args = vec!["-o".to_string()]; // -o requires a value
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    let result = parser.prepare(&mut cmd);

    // Should either error or handle gracefully
    assert!(result.is_ok() || result.is_err());
}

#[test]
fn test_equals_syntax_long_option() {
    let args = vec!["--output=file.txt".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    let result = parser.prepare(&mut cmd);

    // Test if parser supports --option=value syntax
    if result.is_ok() {
        let chain = parser.get_parsed_commands_chain();
        // Verify parsing worked correctly
        assert!(chain.len() >= 1);
    }
}

#[test]
fn test_short_option_clustering() {
    // Some parsers support -vq instead of -v -q
    let args = vec!["-vq".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    let result = parser.prepare(&mut cmd);

    // Test if clustering is supported
    if result.is_ok() {
        let chain = parser.get_parsed_commands_chain();
        // Check if it was parsed as two options or handled differently
        assert!(chain.len() >= 1);
    }
}

// ============================================================================
// ValueTypes::OptionalSingle(Some(Value::Bool(false))) Design Flaw Tests
// ============================================================================

#[test]
fn test_flag_not_passed_but_option_exists() {
    // FIXED: This test now demonstrates that we CAN detect if a flag was passed
    // When -v is NOT passed, the value remains Bool(false)
    let args = vec![]; // NO -v flag
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    // The chain should be empty since no args were passed
    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 0, "Chain should be empty when no args passed");

    // Option exists in definition (expected)
    let option = cmd.get_option_parser().get_option_by_short_flag("-v");
    assert!(option.is_some(), "Option exists in definition");

    // The option's value is Bool(false) because it wasn't passed
    if let Some(opt) = option {
        assert!(
            matches!(
                opt.value,
                ValueTypes::OptionalSingle(Some(Value::Bool(false)))
            ),
            "Flag NOT passed: value should be Bool(false)"
        );
    }

    // FIXED: We CAN now distinguish:
    // 1. Flag was defined but not passed → Bool(false)
    // 2. Flag was defined and passed → Bool(true)
}

#[test]
fn test_flag_passed_option_exists() {
    // When -v IS passed, we should be able to detect it
    let args = vec!["-v".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    // The chain should contain the -v option
    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 1, "Chain should have -v option");

    match &chain[0] {
        CommandChain::Option(flag, value) => {
            assert_eq!(flag, "-v");
            // FLAG WAS PASSED: Should be Bool(true)
            assert!(matches!(
                value,
                ValueTypes::OptionalSingle(Some(Value::Bool(true)))
            ));
        }
        _ => panic!("Expected Option variant"),
    }

    // The option value in the parser should also be updated to true
    let option = cmd.get_option_parser().get_option_by_short_flag("-v");
    assert!(option.is_some(), "Option should exist");

    // FIXED: Now we CAN tell if the flag was passed!
    // Bool(true) = flag was passed
    // Bool(false) = flag was not passed
    if let Some(opt) = option {
        assert!(
            matches!(
                opt.value,
                ValueTypes::OptionalSingle(Some(Value::Bool(true)))
            ),
            "Flag was passed, value should be Bool(true)!"
        );
    }
}

#[test]
fn test_only_chain_can_distinguish_flag_usage() {
    // WORKAROUND: The only way to know if a flag was passed
    // is to check the command_chain, not the option parser

    // Case 1: Flag NOT passed
    let args1 = vec![];
    let mut parser1 = InputArgsParser::new("test".to_string(), args1);
    let mut cmd1 = create_test_command();
    parser1.prepare(&mut cmd1).unwrap();

    let chain1 = parser1.get_parsed_commands_chain();
    let has_v_in_chain1 = chain1
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-v"));
    assert!(
        !has_v_in_chain1,
        "Chain should NOT contain -v when not passed"
    );

    // Case 2: Flag IS passed
    let args2 = vec!["-v".to_string()];
    let mut parser2 = InputArgsParser::new("test".to_string(), args2);
    let mut cmd2 = create_test_command();
    parser2.prepare(&mut cmd2).unwrap();

    let chain2 = parser2.get_parsed_commands_chain();
    let has_v_in_chain2 = chain2
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-v"));
    assert!(has_v_in_chain2, "Chain SHOULD contain -v when passed");

    // CONCLUSION: Must check command_chain, not option parser
}

#[test]
fn test_valuetypes_none_design_question() {
    // FIXED: ValueTypes::None has been removed!
    //
    // NEW DESIGN: Use ValueTypes::OptionalSingle(Some(Value::Bool(false/true)))
    //    - Bool(false) = flag was NOT passed (default)
    //    - Bool(true) = flag WAS passed
    //
    // Benefits:
    // 1. Can check flag status by querying option parser directly
    // 2. No need to search command chain
    // 3. Clear semantics: true = on, false = off
    // 4. Type-safe and idiomatic Rust

    let args = vec![];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();
    parser.prepare(&mut cmd).unwrap();

    // NEW: Can now query cmd directly for "was -v used?"
    let option = cmd.get_option_parser().get_option_by_short_flag("-v");
    let was_v_used = if let Some(opt) = option {
        matches!(
            opt.value,
            ValueTypes::OptionalSingle(Some(Value::Bool(true)))
        )
    } else {
        false
    };

    assert!(!was_v_used, "Flag was not passed, value is Bool(false)");

    // Can also check via chain for consistency
    let was_v_in_chain = parser
        .get_parsed_commands_chain()
        .iter()
        .any(|item| matches!(item, CommandChain::Option(flag, _) if flag == "-v"));

    assert!(!was_v_in_chain, "Flag not in chain either");
}

// ============================================================================
// Parser State Tests
// ============================================================================

#[test]
fn test_parser_not_prepared() {
    let args = vec!["-v".to_string()];
    let parser = InputArgsParser::new("test".to_string(), args);

    // Parser should not have chain before prepare()
    let chain = parser.get_parsed_commands_chain();
    assert_eq!(chain.len(), 0);
}

#[test]
fn test_parser_prepared_multiple_times() {
    let args = vec!["-v".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    // First prepare
    parser.prepare(&mut cmd).unwrap();
    let chain1_len = parser.get_parsed_commands_chain().len();

    // Second prepare - should not duplicate
    let result = parser.prepare(&mut cmd);

    // Implementation may prevent re-preparation
    if result.is_ok() {
        let chain2_len = parser.get_parsed_commands_chain().len();
        // Chain should not grow from re-preparation
        assert_eq!(chain1_len, chain2_len);
    }
}

#[test]
fn test_get_command_chain_vs_parsed_chain() {
    // Use -- separator to allow arguments after options
    let args = vec!["-v".to_string(), "--".to_string(), "file.txt".to_string()];
    let mut parser = InputArgsParser::new("test".to_string(), args);
    let mut cmd = create_test_command();

    parser.prepare(&mut cmd).unwrap();

    let parsed_chain = parser.get_parsed_commands_chain();
    let command_chain = parser.get_command_chain();

    // Both should return the same chain
    assert_eq!(parsed_chain.len(), command_chain.len());
}