fips-core 0.4.2

Reusable FIPS mesh, endpoint, transport, and protocol library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
use super::*;
use super::candidate_policy::CandidateAddressPolicy;
use super::candidate_policy::validate_embedded_ice_candidates;
use crate::config::{
    MAX_WEBRTC_CONFIG_CANDIDATE_SOCKETS, MAX_WEBRTC_HOST_CANDIDATE_SOCKETS,
    MAX_WEBRTC_LOCAL_CANDIDATE_ROUTES, MAX_WEBRTC_REMOTE_CANDIDATE_LINES,
    MAX_WEBRTC_REMOTE_CANDIDATE_ROUTES, MAX_WEBRTC_SOCKETS_PER_STUN_SERVER,
    MAX_WEBRTC_STUN_SERVERS,
};
use ::webrtc::stun::fingerprint::FINGERPRINT;
use ::webrtc::stun::message::{BINDING_SUCCESS, Message};
use ::webrtc::stun::xoraddr::XorMappedAddress;
use ::webrtc::util::vnet::interface::Interface;
use ::webrtc::util::vnet::net::{Net, NetConfig};
use ::webrtc::util::vnet::router::{Router, RouterConfig};
use if_addrs::IfOperStatus;
use std::collections::HashSet;
use std::net::{IpAddr, SocketAddr};
use tokio::net::UdpSocket;

fn candidate_socket_routes(sdp: &str) -> HashSet<String> {
    sdp.lines()
        .filter_map(|line| line.trim().strip_prefix("a=candidate:"))
        .filter_map(|candidate| {
            let fields: Vec<_> = candidate.split_whitespace().collect();
            (fields.len() >= 8 && fields[1] == "1").then(|| {
                format!(
                    "{}|{}|{}|{}",
                    fields[2].to_ascii_lowercase(),
                    fields[4].to_ascii_lowercase(),
                    fields[5],
                    fields[7].to_ascii_lowercase()
                )
            })
        })
        .collect::<HashSet<_>>()
}

async fn gather_candidate_offer(
    api: &::webrtc::api::API,
    label: &str,
) -> (RTCPeerConnection, String) {
    let pc = api
        .new_peer_connection(RTCConfiguration::default())
        .await
        .expect("VNet peer connection");
    pc.create_data_channel(label, None)
        .await
        .expect("data channel");
    let offer = pc.create_offer(None).await.expect("offer");
    let mut gathering = pc.gathering_complete_promise().await;
    pc.set_local_description(offer)
        .await
        .expect("local description");
    wait_for_ice_gathering(Duration::from_secs(1), &mut gathering)
        .await
        .expect("VNet ICE gathering");
    let sdp = pc
        .local_description()
        .await
        .expect("complete local description")
        .sdp;
    (pc, sdp)
}

#[tokio::test]
async fn synthetic_many_address_vnet_gather_stays_within_host_socket_budget() {
    let static_ips: Vec<_> = (1..=24)
        .map(|index| format!("10.42.0.{index}"))
        .collect();
    let policy = CandidateAddressPolicy::from_test_snapshot(
        static_ips.iter().enumerate().map(|(index, ip)| {
            (
                format!("synthetic{index}"),
                ip.parse::<IpAddr>().expect("synthetic IP"),
                index % 3 == 0,
                index as u32 + 1,
            )
        }),
    );
    let vnet = Arc::new(Net::new(Some(NetConfig {
        static_ips: static_ips.clone(),
        ..NetConfig::default()
    })));
    let router = Arc::new(Mutex::new(
        Router::new(RouterConfig {
            cidr: "10.42.0.0/24".into(),
            ..RouterConfig::default()
        })
        .expect("VNet router"),
    ));
    let nic = vnet.get_nic().expect("VNet NIC");
    router
        .lock()
        .await
        .add_net(Arc::clone(&nic))
        .await
        .expect("attach VNet");
    nic.lock()
        .await
        .set_router(Arc::clone(&router))
        .await
        .expect("route VNet");
    router.lock().await.start().await.expect("start VNet router");
    let api = policy
        .build_api_with_vnet(Arc::clone(&vnet))
        .expect("budgeted VNet API");
    let (first_pc, first_sdp) = gather_candidate_offer(&api, "candidate-budget-first").await;
    let first_routes = candidate_socket_routes(&first_sdp);

    assert!(
        first_routes.len() <= MAX_WEBRTC_HOST_CANDIDATE_SOCKETS,
        "one peer connection gathered {} host candidate sockets; budget is {MAX_WEBRTC_HOST_CANDIDATE_SOCKETS}",
        first_routes.len()
    );
    assert_eq!(first_routes.len(), MAX_WEBRTC_HOST_CANDIDATE_SOCKETS);

    let changed_ip = static_ips.last().expect("changed address");
    let changed_policy = CandidateAddressPolicy::from_test_snapshot([(
        "changed-route".into(),
        changed_ip.parse().expect("changed IP"),
        true,
        100,
    )]);
    let changed_api = changed_policy
        .build_api_with_vnet(vnet)
        .expect("changed VNet API generation");
    let (changed_pc, changed_sdp) =
        gather_candidate_offer(&changed_api, "candidate-budget-changed").await;
    let changed_routes = candidate_socket_routes(&changed_sdp);
    assert_eq!(changed_routes.len(), 1);
    assert!(changed_routes.iter().any(|route| route.contains(changed_ip)));
    let first_after_change = first_pc
        .local_description()
        .await
        .expect("first generation remains active")
        .sdp;
    assert_eq!(candidate_socket_routes(&first_after_change), first_routes);

    changed_pc.close().await.expect("close changed VNet PC");
    first_pc.close().await.expect("close first VNet PC");
}

#[tokio::test]
async fn production_profile_gathers_selected_ipv4_ipv6_and_vpn_addresses() {
    let addresses: Vec<IpAddr> = [
        "192.0.2.44",
        "2001:db8:44::1",
        "10.44.0.1",
        "fd44::1",
    ]
    .into_iter()
    .map(|ip| ip.parse().expect("test IP"))
    .collect();
    let policy = CandidateAddressPolicy::from_test_snapshot([
        ("lan-v4".into(), addresses[0], false, 1),
        ("lan-v6".into(), addresses[1], false, 1),
        ("vpn-v4".into(), addresses[2], true, 2),
        ("vpn-v6".into(), addresses[3], true, 2),
    ]);
    let vnet = Arc::new(Net::new(Some(NetConfig::default())));
    let nic = vnet.get_nic().expect("VNet NIC");
    let ipnets: Vec<_> = addresses
        .iter()
        .map(|ip| {
            Interface::convert(SocketAddr::new(*ip, 0), None).expect("VNet interface address")
        })
        .collect();
    nic.lock()
        .await
        .add_addrs_to_interface("eth0", &ipnets)
        .await
        .expect("attach dual-stack VNet addresses");
    let api = policy
        .build_api_with_vnet(vnet)
        .expect("dual-stack VNet API");
    let (pc, sdp) = gather_candidate_offer(&api, "dual-stack-candidates").await;
    let routes = candidate_socket_routes(&sdp);

    assert_eq!(routes.len(), addresses.len());
    for address in addresses {
        assert!(
            routes.iter().any(|route| route.contains(&address.to_string())),
            "missing gathered route for {address}: {routes:?}"
        );
    }
    pc.close().await.expect("close dual-stack VNet PC");
}

#[tokio::test]
async fn production_profile_stun_gathering_survives_host_address_filtering() {
    let socket = UdpSocket::bind("127.0.0.1:0")
        .await
        .expect("local STUN socket");
    let server_addr = socket.local_addr().expect("local STUN address");
    let server = tokio::spawn(async move {
        let mut buffer = [0u8; 1500];
        let (length, source) = socket.recv_from(&mut buffer).await.expect("STUN request");
        let mut request = Message::new();
        request
            .unmarshal_binary(&buffer[..length])
            .expect("decode STUN request");
        let mut response = Message::new();
        response
            .build(&[
                Box::new(BINDING_SUCCESS),
                Box::new(request.transaction_id),
                Box::new(XorMappedAddress {
                    ip: source.ip(),
                    port: source.port(),
                }),
                Box::new(FINGERPRINT),
            ])
            .expect("build STUN response");
        socket
            .send_to(&response.raw, source)
            .await
            .expect("send STUN response");
    });
    let api = CandidateAddressPolicy::system()
        .build_api()
        .expect("production WebRTC API");
    let pc = api
        .new_peer_connection(RTCConfiguration {
            ice_servers: vec![RTCIceServer {
                urls: vec![format!("stun:{server_addr}")],
                ..Default::default()
            }],
            ..Default::default()
        })
        .await
        .expect("STUN peer connection");
    pc.create_data_channel("stun-filter", None)
        .await
        .expect("data channel");
    let offer = pc.create_offer(None).await.expect("offer");
    let mut gathering = pc.gathering_complete_promise().await;
    pc.set_local_description(offer)
        .await
        .expect("local description");
    wait_for_ice_gathering(Duration::from_secs(1), &mut gathering)
        .await
        .expect("STUN gathering");
    let sdp = pc.local_description().await.expect("STUN SDP").sdp;
    assert!(
        candidate_socket_routes(&sdp)
            .iter()
            .any(|route| route.ends_with("|srflx")),
        "server-reflexive route missing from {sdp}"
    );
    server.await.expect("STUN server task");
    pc.close().await.expect("close STUN PC");
}

#[tokio::test]
async fn configured_stun_urls_reach_peer_connection_configuration() {
    let urls = vec![
        "stun:192.0.2.1:3478".to_string(),
        "stun:192.0.2.2:3478".to_string(),
    ];
    let identity = crate::Identity::generate();
    let (packet_tx, _packet_rx) = crate::packet_channel(1);
    let transport = WebRtcTransport::new(
        TransportId::new(603),
        None,
        WebRtcConfig {
            max_connections: Some(1),
            stun_servers: Some(urls.clone()),
            ..WebRtcConfig::default()
        },
        packet_tx,
        &identity,
        &NostrDiscoveryConfig::default(),
    )
    .expect("WebRTC transport");
    let pc = transport
        .runtime()
        .new_peer_connection()
        .await
        .expect("peer connection");
    let configured: Vec<_> = pc
        .get_configuration()
        .await
        .ice_servers
        .into_iter()
        .flat_map(|server| server.urls)
        .collect();

    assert_eq!(configured, urls);
    pc.close().await.expect("close configured PC");
}

#[test]
fn transport_constructor_rejects_unsupported_or_invalid_ice_urls() {
    for url in ["turn:turn.example:3478", "stun:", "stun:stun.example:bad"] {
        let identity = crate::Identity::generate();
        let (packet_tx, _packet_rx) = crate::packet_channel(1);
        assert!(
            WebRtcTransport::new(
                TransportId::new(604),
                None,
                WebRtcConfig {
                    max_connections: Some(1),
                    stun_servers: Some(vec![url.into()]),
                    ..WebRtcConfig::default()
                },
                packet_tx,
                &identity,
                &NostrDiscoveryConfig::default(),
            )
            .is_err(),
            "unsupported or malformed ICE URL must fail during construction: {url}"
        );
    }
}

#[test]
fn synthetic_many_interface_selection_preserves_ip_families_and_p2p_routes() {
    let mut snapshot = Vec::new();
    for index in 1..=12u32 {
        snapshot.push((
            format!("lan{index}"),
            format!("192.0.2.{index}").parse().unwrap(),
            false,
            index,
        ));
        snapshot.push((
            format!("lan{index}"),
            format!("2001:db8::{index}").parse().unwrap(),
            false,
            index,
        ));
        snapshot.push((
            format!("vpn{index}"),
            format!("10.0.0.{index}").parse().unwrap(),
            true,
            100 + index,
        ));
        snapshot.push((
            format!("vpn{index}"),
            format!("fd00::{index}").parse().unwrap(),
            true,
            100 + index,
        ));
    }
    let selected = CandidateAddressPolicy::from_test_snapshot(snapshot)
        .selected_ips_for_test()
        .expect("candidate selection");
    assert_eq!(selected.len(), MAX_WEBRTC_HOST_CANDIDATE_SOCKETS);
    assert!(selected.iter().any(IpAddr::is_ipv4));
    assert!(selected.iter().any(IpAddr::is_ipv6));
    assert!(selected.iter().any(|ip| matches!(ip, IpAddr::V4(ip) if ip.is_private())));
    assert!(selected.iter().any(|ip| matches!(ip, IpAddr::V6(ip) if ip.segments()[0] & 0xfe00 == 0xfc00)));
}

#[test]
fn temporary_addresses_on_one_interface_do_not_multiply_sockets() {
    let mut snapshot = vec![(
        "uplink".to_string(),
        "192.0.2.10".parse().unwrap(),
        false,
        1,
    )];
    for index in 1..=12u32 {
        snapshot.push((
            "uplink".to_string(),
            format!("2001:db8::{index}").parse().unwrap(),
            false,
            1,
        ));
    }
    let selected = CandidateAddressPolicy::from_test_snapshot(snapshot)
        .selected_ips_for_test()
        .expect("candidate selection");
    assert_eq!(selected.len(), 2);
    assert!(selected.iter().any(IpAddr::is_ipv4));
    assert!(selected.iter().any(IpAddr::is_ipv6));
}

#[test]
fn unknown_oper_status_preserves_point_to_point_and_vpn_routes() {
    let selected = CandidateAddressPolicy::from_test_status_snapshot([
        (
            "vpn-unknown-v4".into(),
            "10.77.0.1".parse().unwrap(),
            true,
            40,
            IfOperStatus::Unknown,
        ),
        (
            "vpn-unknown-v6".into(),
            "fd77::1".parse().unwrap(),
            true,
            40,
            IfOperStatus::Unknown,
        ),
        (
            "vpn-explicitly-down".into(),
            "10.88.0.1".parse().unwrap(),
            true,
            41,
            IfOperStatus::Down,
        ),
    ])
    .selected_ips_for_test()
    .expect("candidate selection");

    assert_eq!(selected.len(), 2);
    assert!(selected.contains(&"10.77.0.1".parse().unwrap()));
    assert!(selected.contains(&"fd77::1".parse().unwrap()));
    assert!(!selected.contains(&"10.88.0.1".parse().unwrap()));
}

#[test]
fn known_up_routes_are_not_crowded_out_by_unknown_interfaces() {
    let mut snapshot = Vec::new();
    for index in 1..=8u32 {
        snapshot.push((
            format!("unknown-{index}"),
            format!("198.51.100.{index}").parse().unwrap(),
            false,
            index,
            IfOperStatus::Unknown,
        ));
    }
    snapshot.extend([
        (
            "known-up-lan-v4".into(),
            "192.168.77.9".parse().unwrap(),
            false,
            100,
            IfOperStatus::Up,
        ),
        (
            "known-up-lan-v6".into(),
            "2001:db8:77::9".parse().unwrap(),
            false,
            100,
            IfOperStatus::Up,
        ),
        (
            "unknown-vpn-v4".into(),
            "10.77.0.1".parse().unwrap(),
            true,
            101,
            IfOperStatus::Unknown,
        ),
        (
            "unknown-vpn-v6".into(),
            "fd77::1".parse().unwrap(),
            true,
            101,
            IfOperStatus::Unknown,
        ),
    ]);
    let selected = CandidateAddressPolicy::from_test_status_snapshot(snapshot)
        .selected_ips_for_test()
        .expect("candidate selection");

    assert_eq!(selected.len(), MAX_WEBRTC_HOST_CANDIDATE_SOCKETS);
    assert!(selected.contains(&"192.168.77.9".parse().unwrap()));
    assert!(selected.contains(&"2001:db8:77::9".parse().unwrap()));
    assert!(selected.contains(&"10.77.0.1".parse().unwrap()));
    assert!(selected.contains(&"fd77::1".parse().unwrap()));
}

#[test]
fn known_up_lans_fill_spare_slots_before_unknown_p2p_routes() {
    let mut snapshot = (1..=4u32)
        .map(|index| {
            (
                format!("lan-{index}"),
                format!("192.0.2.{index}").parse().unwrap(),
                false,
                index,
                IfOperStatus::Up,
            )
        })
        .collect::<Vec<_>>();
    for index in 1..=6u32 {
        snapshot.push((
            format!("vpn-v4-{index}"),
            format!("10.0.0.{index}").parse().unwrap(),
            true,
            100 + index,
            IfOperStatus::Unknown,
        ));
        snapshot.push((
            format!("vpn-v6-{index}"),
            format!("fd00::{index}").parse().unwrap(),
            true,
            200 + index,
            IfOperStatus::Unknown,
        ));
    }
    let selected = CandidateAddressPolicy::from_test_status_snapshot(snapshot)
        .selected_ips_for_test()
        .expect("candidate selection");

    assert_eq!(selected.len(), MAX_WEBRTC_HOST_CANDIDATE_SOCKETS);
    for index in 1..=4u32 {
        assert!(selected.contains(&format!("192.0.2.{index}").parse().unwrap()));
    }
}

#[test]
fn system_candidate_snapshot_is_bounded() {
    let selected = CandidateAddressPolicy::system()
        .selected_ips_for_test()
        .expect("system interfaces");
    assert!(selected.len() <= MAX_WEBRTC_HOST_CANDIDATE_SOCKETS);
    assert!(selected.iter().all(|ip| !ip.is_loopback()));
}

#[test]
fn remote_sdp_can_exceed_the_local_socket_route_budget() {
    let identity = crate::Identity::generate();
    let (packet_tx, _packet_rx) = crate::packet_channel(1);
    let transport = WebRtcTransport::new(
        TransportId::new(601),
        None,
        WebRtcConfig {
            stun_servers: Some(Vec::new()),
            ..WebRtcConfig::default()
        },
        packet_tx,
        &identity,
        &NostrDiscoveryConfig::default(),
    )
    .expect("WebRTC transport");
    let mut sdp = String::from("v=0\r\n");
    for index in 0..MAX_WEBRTC_LOCAL_CANDIDATE_ROUTES + 4 {
        sdp.push_str(&format!(
            "a=candidate:{index} 1 UDP 1 192.0.2.1 {} typ host\r\n",
            5_000 + index
        ));
    }
    assert!(
        validate_embedded_ice_candidates(&sdp, EmbeddedCandidateScope::Local).is_err(),
        "the same SDP exceeds the locally generated socket-route budget"
    );
    validate_embedded_ice_candidates(&sdp, EmbeddedCandidateScope::Remote)
        .expect("bounded remote SDP can describe more routes than this host binds");
    let now = now_ms();
    let signal = WebRtcSignal {
        version: crate::transport::link_negotiation::LINK_NEGOTIATION_VERSION,
        negotiation_id: "browser-sized-embedded-sdp".into(),
        link_type: "webrtc".into(),
        kind: LinkNegotiationKind::Offer,
        created_at_ms: now,
        expires_at_ms: now + 1_000,
        payload: WebRtcSignalPayload {
            sdp: Some(sdp),
            candidates: None,
        },
    };

    transport
        .runtime()
        .validate_signal(&signal)
        .expect("remote browser routes do not allocate matching local sockets");
    assert_eq!(transport.resource_snapshot().created_total, 0);
    assert_eq!(transport.mdns_resolver.snapshot().owner_count, 0);
}

#[test]
fn oversized_remote_sdp_is_rejected_at_signal_admission() {
    let identity = crate::Identity::generate();
    let (packet_tx, _packet_rx) = crate::packet_channel(1);
    let transport = WebRtcTransport::new(
        TransportId::new(605),
        None,
        WebRtcConfig {
            stun_servers: Some(Vec::new()),
            ..WebRtcConfig::default()
        },
        packet_tx,
        &identity,
        &NostrDiscoveryConfig::default(),
    )
    .expect("WebRTC transport");
    let mut sdp = String::from("v=0\r\n");
    for index in 0..=MAX_WEBRTC_REMOTE_CANDIDATE_ROUTES {
        sdp.push_str(&format!(
            "a=candidate:{index} 1 UDP 1 192.0.2.1 {} typ host\r\n",
            5_000 + index
        ));
    }
    let now = now_ms();
    let signal = WebRtcSignal {
        version: crate::transport::link_negotiation::LINK_NEGOTIATION_VERSION,
        negotiation_id: "oversized-remote-sdp".into(),
        link_type: "webrtc".into(),
        kind: LinkNegotiationKind::Offer,
        created_at_ms: now,
        expires_at_ms: now + 1_000,
        payload: WebRtcSignalPayload {
            sdp: Some(sdp),
            candidates: None,
        },
    };

    assert!(transport.runtime().validate_signal(&signal).is_err());
    assert_eq!(transport.resource_snapshot().created_total, 0);
    assert_eq!(transport.mdns_resolver.snapshot().owner_count, 0);
}

#[test]
fn embedded_candidate_budget_deduplicates_components_but_caps_raw_lines() {
    let twins = concat!(
        "v=0\r\n",
        "a=candidate:same 1 UDP 1 192.0.2.10 5000 typ host\r\n",
        "a=candidate:same 2 UDP 1 192.0.2.10 5000 typ host\r\n",
    );
    let count = validate_embedded_ice_candidates(twins, EmbeddedCandidateScope::Remote)
        .expect("component twins");
    assert_eq!(count.raw_lines, 2);
    assert_eq!(count.unique_routes, 1);

    let mut duplicates = String::from("v=0\r\n");
    for index in 0..=MAX_WEBRTC_REMOTE_CANDIDATE_LINES {
        duplicates.push_str(&format!(
            "a=candidate:{index} 1 UDP 1 192.0.2.10 5000 typ host\r\n"
        ));
    }
    assert!(
        validate_embedded_ice_candidates(&duplicates, EmbeddedCandidateScope::Remote).is_err()
    );
}

#[tokio::test]
async fn oversized_embedded_offer_never_starts_mdns_or_allocates_a_pc() {
    let local = crate::Identity::generate();
    let remote = crate::Identity::generate();
    let (packet_tx, _packet_rx) = crate::packet_channel(1);
    let transport = WebRtcTransport::new(
        TransportId::new(602),
        None,
        WebRtcConfig {
            accept_connections: Some(true),
            max_connections: Some(1),
            resolve_mdns_candidates: Some(true),
            stun_servers: Some(Vec::new()),
            ..WebRtcConfig::default()
        },
        packet_tx,
        &local,
        &NostrDiscoveryConfig::default(),
    )
    .expect("WebRTC transport");
    let mut sdp = String::from("v=0\r\n");
    for index in 0..=MAX_WEBRTC_REMOTE_CANDIDATE_ROUTES {
        sdp.push_str(&format!(
            "a=candidate:{index} 1 UDP 1 one-host.local {} typ host\r\n",
            5_000 + index
        ));
    }
    let now = now_ms();
    let remote_full = remote.pubkey_full().serialize();
    let incoming = IncomingSignal {
        signal: WebRtcSignal {
            version: crate::transport::link_negotiation::LINK_NEGOTIATION_VERSION,
            negotiation_id: "pre-mdns-budget".into(),
            link_type: "webrtc".into(),
            kind: LinkNegotiationKind::Offer,
            created_at_ms: now,
            expires_at_ms: now + 1_000,
            payload: WebRtcSignalPayload {
                sdp: Some(sdp),
                candidates: None,
            },
        },
        sender: PublicKey::from_slice(&remote_full[1..]).expect("remote Nostr key"),
        sender_full_hex: hex::encode(remote_full),
    };

    let result = transport.runtime().handle_incoming_signal(incoming).await;
    assert!(matches!(result, Err(TransportError::InvalidAddress(_))));
    assert_eq!(
        transport.mdns_resolver.snapshot(),
        mdns::MdnsResolverSnapshot {
            owner_count: 0,
            max_waiters: 1,
            active_waiters: 0,
            peak_waiters: 0,
        }
    );
    assert_eq!(transport.resource_snapshot().created_total, 0);
    assert!(transport.seen_sessions.lock().await.is_empty());
}

#[test]
fn default_connection_capacity_fits_the_reviewed_configured_socket_budget() {
    let worst_case_per_pc = MAX_WEBRTC_HOST_CANDIDATE_SOCKETS
        + MAX_WEBRTC_STUN_SERVERS * MAX_WEBRTC_SOCKETS_PER_STUN_SERVER;
    let configured = WebRtcConfig::default().max_connections();
    assert_eq!(MAX_WEBRTC_LOCAL_CANDIDATE_ROUTES, worst_case_per_pc);
    assert!(
        configured * worst_case_per_pc <= MAX_WEBRTC_CONFIG_CANDIDATE_SOCKETS,
        "default {configured} peer connections can allocate {} candidate sockets; configured budget is {MAX_WEBRTC_CONFIG_CANDIDATE_SOCKETS}",
        configured * worst_case_per_pc
    );
}

#[tokio::test]
async fn failure_diagnostic_tracks_candidates_and_data_channel_stage() {
    let api = build_webrtc_api().expect("WebRTC API");
    let resources = PhysicalResources::new(1);
    let peer = resources
        .reserve(&TransportAddr::from_string("diagnostic-peer"))
        .expect("physical reservation")
        .activate(
            api.new_peer_connection(RTCConfiguration::default())
                .await
                .expect("peer connection"),
        );
    peer.record_local_candidates(EmbeddedCandidateCount {
        raw_lines: 2,
        unique_routes: 1,
    });
    peer.record_remote_candidates(EmbeddedCandidateCount {
        raw_lines: 4,
        unique_routes: 3,
    });
    peer.record_data_channel_wired();
    peer.record_data_channel_open();

    let open = peer.failure_stage_diagnostic();
    assert!(open.contains("dataChannel=Open"));
    assert!(open.contains("localCandidatesRawUnique=2/1"));
    assert!(open.contains("remoteCandidatesRawUnique=4/3"));

    peer.record_data_channel_closed();
    assert!(
        peer.failure_stage_diagnostic()
            .contains("dataChannel=Closed")
    );
    close_peer_connection_bounded(peer).await;
    assert!(resources.wait_for_quiescence(Duration::from_secs(3)).await);
}

#[tokio::test]
async fn failure_diagnostic_captures_local_description_candidate_progress() {
    let policy = CandidateAddressPolicy::loopback_udp4();
    let api = policy.build_api().expect("loopback WebRTC API");
    let resources = PhysicalResources::new(1);
    let peer = resources
        .reserve(&TransportAddr::from_string("partial-diagnostic-peer"))
        .expect("physical reservation")
        .activate(
            api.new_peer_connection(RTCConfiguration::default())
                .await
                .expect("peer connection"),
        );
    peer.create_data_channel("partial-diagnostic", None)
        .await
        .expect("data channel");
    let offer = peer.create_offer(None).await.expect("offer");
    let mut gathering = peer.gathering_complete_promise().await;
    peer.set_local_description(offer)
        .await
        .expect("local description");
    wait_for_ice_gathering(Duration::from_secs(1), &mut gathering)
        .await
        .expect("loopback gathering");

    WebRtcRuntime::record_partial_local_candidate_diagnostic(&peer).await;
    let diagnostic = peer.failure_stage_diagnostic();
    assert!(
        diagnostic.contains("localCandidatesRawUnique=2/1"),
        "unexpected candidate diagnostic: {diagnostic}"
    );

    close_peer_connection_bounded(peer).await;
    assert!(resources.wait_for_quiescence(Duration::from_secs(3)).await);
}