use crate::error::FinError;
use crate::signals::{BarInput, Signal, SignalValue};
use rust_decimal::Decimal;
use std::collections::VecDeque;
pub struct BollingerB {
name: String,
period: usize,
multiplier: Decimal,
values: VecDeque<Decimal>,
}
impl BollingerB {
pub fn new(
name: impl Into<String>,
period: usize,
multiplier: impl Into<Decimal>,
) -> Result<Self, crate::error::FinError> {
if period == 0 {
return Err(crate::error::FinError::InvalidPeriod(period));
}
Ok(Self {
name: name.into(),
period,
multiplier: multiplier.into(),
values: VecDeque::with_capacity(period),
})
}
}
impl Signal for BollingerB {
fn name(&self) -> &str {
&self.name
}
fn update(&mut self, bar: &BarInput) -> Result<SignalValue, FinError> {
self.values.push_back(bar.close);
if self.values.len() > self.period {
self.values.pop_front();
}
if self.values.len() < self.period {
return Ok(SignalValue::Unavailable);
}
#[allow(clippy::cast_possible_truncation)]
let n = Decimal::from(self.period as u32);
let sum: Decimal = self.values.iter().copied().sum();
let mean = sum.checked_div(n).ok_or(FinError::ArithmeticOverflow)?;
let variance_sum: Decimal = self
.values
.iter()
.map(|v| {
let diff = *v - mean;
diff * diff
})
.sum();
let variance = variance_sum
.checked_div(n)
.ok_or(FinError::ArithmeticOverflow)?;
let std_dev = decimal_sqrt(variance)?;
let band_width = self.multiplier * std_dev;
let upper = mean + band_width;
let lower = mean - band_width;
let band_range = upper - lower;
if band_range == Decimal::ZERO {
return Ok(SignalValue::Scalar(
Decimal::ONE
.checked_div(Decimal::TWO)
.ok_or(FinError::ArithmeticOverflow)?,
));
}
let pct_b = (bar.close - lower)
.checked_div(band_range)
.ok_or(FinError::ArithmeticOverflow)?;
Ok(SignalValue::Scalar(pct_b))
}
fn is_ready(&self) -> bool {
self.values.len() >= self.period
}
fn period(&self) -> usize {
self.period
}
fn reset(&mut self) {
self.values.clear();
}
}
impl BollingerB {
pub fn bands(&self) -> Option<(Decimal, Decimal, Decimal)> {
if self.values.len() < self.period {
return None;
}
#[allow(clippy::cast_possible_truncation)]
let n = Decimal::from(self.period as u32);
let sum: Decimal = self.values.iter().copied().sum();
let mean = sum.checked_div(n)?;
let variance_sum: Decimal = self.values.iter().map(|v| { let d = *v - mean; d * d }).sum();
let variance = variance_sum.checked_div(n)?;
let std_dev = decimal_sqrt(variance).ok()?;
let band_width = self.multiplier * std_dev;
Some((mean + band_width, mean, mean - band_width))
}
}
fn decimal_sqrt(n: Decimal) -> Result<Decimal, FinError> {
if n == Decimal::ZERO {
return Ok(Decimal::ZERO);
}
if n < Decimal::ZERO {
return Err(FinError::ArithmeticOverflow);
}
let two = Decimal::TWO;
let mut x = n
.checked_div(two)
.ok_or(FinError::ArithmeticOverflow)?
.max(Decimal::ONE);
for _ in 0..20 {
let x_next = (x + n.checked_div(x).ok_or(FinError::ArithmeticOverflow)?)
.checked_div(two)
.ok_or(FinError::ArithmeticOverflow)?;
let diff = (x_next - x).abs();
x = x_next;
if diff < Decimal::new(1, 10) {
break;
}
}
Ok(x)
}
#[cfg(test)]
mod tests {
use super::*;
use crate::ohlcv::OhlcvBar;
use crate::signals::Signal;
use crate::types::{NanoTimestamp, Price, Quantity, Symbol};
use rust_decimal_macros::dec;
fn bar(close: &str) -> OhlcvBar {
let p = Price::new(close.parse().unwrap()).unwrap();
OhlcvBar {
symbol: Symbol::new("X").unwrap(),
open: p,
high: p,
low: p,
close: p,
volume: Quantity::zero(),
ts_open: NanoTimestamp::new(0),
ts_close: NanoTimestamp::new(1),
tick_count: 1,
}
}
#[test]
fn test_bollinger_period_0_fails() {
assert!(BollingerB::new("bb", 0, 2u32).is_err());
}
#[test]
fn test_bollinger_unavailable_before_period() {
let mut bb = BollingerB::new("bb3", 3, 2u32).unwrap();
assert_eq!(bb.update_bar(&bar("100")).unwrap(), SignalValue::Unavailable);
assert_eq!(bb.update_bar(&bar("100")).unwrap(), SignalValue::Unavailable);
assert!(!bb.is_ready());
}
#[test]
fn test_bollinger_constant_price_returns_half() {
let mut bb = BollingerB::new("bb3", 3, 2u32).unwrap();
bb.update_bar(&bar("100")).unwrap();
bb.update_bar(&bar("100")).unwrap();
let v = bb.update_bar(&bar("100")).unwrap();
assert_eq!(v, SignalValue::Scalar(dec!(0.5)));
assert!(bb.is_ready());
}
#[test]
fn test_bollinger_close_at_upper_band_returns_one() {
let mut bb = BollingerB::new("bb3", 3, 2u32).unwrap();
bb.update_bar(&bar("90")).unwrap();
bb.update_bar(&bar("100")).unwrap();
let v = bb.update_bar(&bar("110")).unwrap(); if let SignalValue::Scalar(pct_b) = v {
assert!(pct_b > dec!(0.5), "close above SMA should yield %B > 0.5, got {pct_b}");
} else {
panic!("expected Scalar");
}
}
#[test]
fn test_bollinger_reset_clears_state() {
let mut bb = BollingerB::new("bb3", 3, 2u32).unwrap();
for _ in 0..3 {
bb.update_bar(&bar("100")).unwrap();
}
assert!(bb.is_ready());
bb.reset();
assert!(!bb.is_ready());
assert_eq!(bb.update_bar(&bar("100")).unwrap(), SignalValue::Unavailable);
}
}