ferrotorch-gpu 0.4.6

CUDA GPU backend for ferrotorch
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
//! cuFFT-backed GPU 1-D FFT primitives. (#579)
//!
//! Each function is GPU-resident: takes `&CudaBuffer<T>`, returns
//! `CudaBuffer<T>`. The complex layout is the workspace convention —
//! interleaved `[re, im, re, im, ...]` in a real f32/f64 buffer — which
//! happens to match `cufftComplex` / `cufftDoubleComplex` byte-for-byte, so
//! we can hand cuFFT the same allocation without any reformat step.
//!
//! Plans are recreated per call; cuFFT's plan creation is light enough that
//! we don't bother caching today, and the lifetime story for cached plans
//! across multi-stream / multi-device usage is fiddly. Performance-critical
//! paths can lift planning out themselves.
//!
//! Inverse transforms apply `1/n` normalization in a follow-up kernel
//! launch, matching torch / numpy convention. cuFFT itself does not
//! normalize.

#![cfg(feature = "cuda")]

use std::ffi::c_int;

use cudarc::cufft::result as cufft_result;
use cudarc::cufft::sys as cufft_sys;
use cudarc::cufft::{CudaFft, FftDirection};
use cudarc::driver::DevicePtrMut;

use crate::buffer::CudaBuffer;
use crate::device::GpuDevice;
use crate::error::{GpuError, GpuResult};

fn check_n_batch(n: usize, batch: usize, op: &'static str) -> GpuResult<()> {
    if n == 0 {
        return Err(GpuError::ShapeMismatch {
            op,
            expected: vec![1],
            got: vec![0],
        });
    }
    if batch == 0 {
        return Err(GpuError::ShapeMismatch {
            op,
            expected: vec![1],
            got: vec![0],
        });
    }
    Ok(())
}

// ---------------------------------------------------------------------------
// Complex-to-complex (f32)
// ---------------------------------------------------------------------------

/// Forward (`inverse=false`) or inverse (`inverse=true`) 1-D complex-to-complex
/// FFT, batched. Layout: `[batch * n * 2]` interleaved `(re, im)` f32.
///
/// On `inverse=true`, the output is divided by `n` so that
/// `ifft(fft(x)) ≈ x` matches torch / numpy.
pub fn gpu_fft_c2c_f32(
    input: &CudaBuffer<f32>,
    batch: usize,
    n: usize,
    inverse: bool,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f32>> {
    check_n_batch(n, batch, "gpu_fft_c2c_f32")?;
    let total =
        batch
            .checked_mul(n)
            .and_then(|v| v.checked_mul(2))
            .ok_or(GpuError::ShapeMismatch {
                op: "gpu_fft_c2c_f32",
                expected: vec![batch, n, 2],
                got: vec![input.len()],
            })?;
    if input.len() != total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft_c2c_f32",
            expected: vec![batch, n, 2],
            got: vec![input.len()],
        });
    }

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n as i32,
        cufft_sys::cufftType::CUFFT_C2C,
        batch as i32,
        stream.clone(),
    )?;
    let mut out = crate::transfer::alloc_zeros_f32(total, device)?;

    // Clone input (cuFFT C2C is documented as writeable on `idata` —
    // pre-allocated copy keeps the input buffer pristine for the caller).
    let mut tmp = crate::transfer::alloc_zeros_f32(total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;

    let direction = if inverse {
        FftDirection::Inverse
    } else {
        FftDirection::Forward
    };
    // SAFETY:
    // - `cufft_result::exec_c2c` is the unsafe FFI shim around
    //   `cufftExecC2C` (NVIDIA cuFFT API:
    //   <https://docs.nvidia.com/cuda/cufft/index.html#function-cufftexecc2c>).
    //   The plan must match dtype / direction; pointers must be device-
    //   resident and sized as advertised.
    // - Plan: `plan` is a `CudaFft` created on line 84 with
    //   `CUFFT_C2C`, length `n`, batch `batch`, on this device's stream
    //   (line 88). The plan handle stays valid for the call (`plan` is
    //   owned by this stack frame and outlives the unsafe block).
    // - Buffer dtype: cuFFT's `cufftComplex` is byte-equivalent to a pair
    //   of f32 (re, im) per element; our interleaved `[batch*n*2]` f32
    //   buffer (validated against `total = batch*n*2` on line 75) is the
    //   identical bit layout. The cast `*mut f32 → *mut cufftComplex`
    //   reinterprets the same allocation.
    // - Lengths: `tmp` and `out` were each allocated as `total = batch*n*2`
    //   f32 elements (lines 90, 94). cuFFT reads `batch*n` complex samples
    //   from `idata` and writes `batch*n` to `odata` — exactly matching.
    // - Device pointers: `device_ptr_mut` on lines 103-104 yields raw
    //   `CUdeviceptr` plus `_isync` / `_osync` `SyncOnDrop` records held
    //   alive across the FFI call so the GPU work is recorded against
    //   `stream`.
    // - Aliasing: `tmp` and `out` are separately allocated buffers; cuFFT
    //   may overwrite `idata` (per the function rustdoc on line 92-93)
    //   but cannot alias `odata` because they are distinct allocations.
    // - Direction: `direction as c_int` is a defined-value enum cast
    //   (`FftDirection::Forward = -1`, `Inverse = +1`); cuFFT accepts
    //   exactly these values.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_c2c(
            plan.handle(),
            idata as *mut cufft_sys::cufftComplex,
            odata as *mut cufft_sys::cufftComplex,
            direction as c_int,
        )?;
    }

    if inverse {
        let scale = 1.0_f32 / n as f32;
        out = crate::kernels::gpu_scale(&out, scale, device)?;
    }
    Ok(out)
}

/// f64 variant of [`gpu_fft_c2c_f32`].
pub fn gpu_fft_c2c_f64(
    input: &CudaBuffer<f64>,
    batch: usize,
    n: usize,
    inverse: bool,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f64>> {
    check_n_batch(n, batch, "gpu_fft_c2c_f64")?;
    let total =
        batch
            .checked_mul(n)
            .and_then(|v| v.checked_mul(2))
            .ok_or(GpuError::ShapeMismatch {
                op: "gpu_fft_c2c_f64",
                expected: vec![batch, n, 2],
                got: vec![input.len()],
            })?;
    if input.len() != total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft_c2c_f64",
            expected: vec![batch, n, 2],
            got: vec![input.len()],
        });
    }

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n as i32,
        cufft_sys::cufftType::CUFFT_Z2Z,
        batch as i32,
        stream.clone(),
    )?;
    let mut out = crate::transfer::alloc_zeros_f64(total, device)?;
    let mut tmp = crate::transfer::alloc_zeros_f64(total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;

    let direction = if inverse {
        FftDirection::Inverse
    } else {
        FftDirection::Forward
    };
    // SAFETY:
    // - `cufft_result::exec_z2z` is the unsafe FFI shim around
    //   `cufftExecZ2Z` (NVIDIA cuFFT, double-precision complex C2C).
    // - Plan: created on line 147 with `CUFFT_Z2Z`, length `n`, batch
    //   `batch`, on this device's stream (line 151). Plan handle valid
    //   for the call duration.
    // - Buffer dtype: `cufftDoubleComplex` is byte-equivalent to a pair
    //   of f64 (re, im); our interleaved `[batch*n*2]` f64 buffer
    //   (validated against `total = batch*n*2` on line 138) reinterprets
    //   1:1.
    // - Lengths: `tmp` and `out` each `total = batch*n*2` f64 elements
    //   (lines 153, 154). cuFFT reads/writes `batch*n` Z2Z samples,
    //   matching the allocations exactly.
    // - Device pointers: `device_ptr_mut` lines 163-164 yield raw
    //   `CUdeviceptr` + `_isync` / `_osync` `SyncOnDrop` guards. The
    //   guards stay alive across the FFI call so the cuFFT work is
    //   ordered against `stream`.
    // - Aliasing: `tmp` and `out` are distinct allocations; cuFFT may
    //   overwrite `idata` but cannot alias `odata`.
    // - Direction: `FftDirection` enum cast to `c_int`; the only valid
    //   values (-1 Forward, +1 Inverse) are accepted by cuFFT.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_z2z(
            plan.handle(),
            idata as *mut cufft_sys::cufftDoubleComplex,
            odata as *mut cufft_sys::cufftDoubleComplex,
            direction as c_int,
        )?;
    }

    if inverse {
        let scale = 1.0_f64 / n as f64;
        out = crate::kernels::gpu_scale_f64(&out, scale, device)?;
    }
    Ok(out)
}

// ---------------------------------------------------------------------------
// 2-D complex-to-complex FFT (#634)
// ---------------------------------------------------------------------------
//
// Wraps `cufftPlan2d` for the unbatched 2-D case. Input/output layout:
// interleaved `[h, w, 2]` (re/im pairs), same convention as the existing
// 1-D ops. `inverse=true` divides by `h*w` to match torch / numpy.

/// 2-D forward (`inverse=false`) or inverse C2C FFT for f32.
/// Input layout: `[h, w, 2]` interleaved complex; output same shape.
pub fn gpu_fft2_c2c_f32(
    input: &CudaBuffer<f32>,
    h: usize,
    w: usize,
    inverse: bool,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f32>> {
    if h == 0 || w == 0 {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft2_c2c_f32",
            expected: vec![1, 1],
            got: vec![h, w],
        });
    }
    let total = h * w * 2;
    if input.len() != total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft2_c2c_f32",
            expected: vec![h, w, 2],
            got: vec![input.len()],
        });
    }

    let stream = device.stream();
    let plan = CudaFft::plan_2d(
        h as i32,
        w as i32,
        cufft_sys::cufftType::CUFFT_C2C,
        stream.clone(),
    )?;

    let mut tmp = crate::transfer::alloc_zeros_f32(total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f32(total, device)?;

    let direction = if inverse {
        FftDirection::Inverse
    } else {
        FftDirection::Forward
    };
    // SAFETY:
    // - `cufft_result::exec_c2c` is the unsafe FFI shim around
    //   `cufftExecC2C` (NVIDIA cuFFT, single-precision complex 2-D).
    // - Plan: created on line 246 with `CUFFT_C2C`, dimensions
    //   `[h, w]`, on this device's stream (line 251). The plan
    //   handle is valid for the call.
    // - Buffer dtype: `cufftComplex` is byte-equivalent to interleaved
    //   `(re, im)` f32 pairs; our `[h*w*2]` f32 buffer (validated
    //   against `total = h*w*2` on lines 204-211) reinterprets exactly.
    // - Lengths: `tmp` and `out` each `total = h*w*2` f32 elements
    //   (lines 253, 255 — both `alloc_zeros_f32(total, ...)`). cuFFT
    //   reads/writes exactly `h*w` complex samples.
    // - Device pointers: `device_ptr_mut` lines 263-264; `_isync` /
    //   `_osync` guards record completion on `stream` when dropped at
    //   block exit, ordering this exec against subsequent ops.
    // - Aliasing: `tmp` and `out` are distinct allocations; cuFFT may
    //   overwrite `idata` (cuFFT 2-D is also documented as
    //   in-place-capable, hence the `tmp` clone on line 254) but
    //   cannot alias `odata`.
    // - Direction: enum cast to `c_int`, valid values only.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_c2c(
            plan.handle(),
            idata as *mut cufft_sys::cufftComplex,
            odata as *mut cufft_sys::cufftComplex,
            direction as c_int,
        )?;
    }

    if inverse {
        let scale = 1.0_f32 / (h as f32 * w as f32);
        out = crate::kernels::gpu_scale(&out, scale, device)?;
    }
    Ok(out)
}

/// f64 variant of [`gpu_fft2_c2c_f32`].
pub fn gpu_fft2_c2c_f64(
    input: &CudaBuffer<f64>,
    h: usize,
    w: usize,
    inverse: bool,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f64>> {
    if h == 0 || w == 0 {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft2_c2c_f64",
            expected: vec![1, 1],
            got: vec![h, w],
        });
    }
    let total = h * w * 2;
    if input.len() != total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_fft2_c2c_f64",
            expected: vec![h, w, 2],
            got: vec![input.len()],
        });
    }

    let stream = device.stream();
    let plan = CudaFft::plan_2d(
        h as i32,
        w as i32,
        cufft_sys::cufftType::CUFFT_Z2Z,
        stream.clone(),
    )?;

    let mut tmp = crate::transfer::alloc_zeros_f64(total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f64(total, device)?;

    let direction = if inverse {
        FftDirection::Inverse
    } else {
        FftDirection::Forward
    };
    // SAFETY:
    // - `cufft_result::exec_z2z` is the unsafe FFI shim around
    //   `cufftExecZ2Z` (NVIDIA cuFFT, double-precision complex 2-D).
    // - Plan: created on line 305 with `CUFFT_Z2Z`, dimensions
    //   `[h, w]`, on this device's stream (line 309). The plan
    //   handle remains valid through the call.
    // - Buffer dtype: `cufftDoubleComplex` is byte-equivalent to
    //   interleaved `(re, im)` f64 pairs. Our `[h*w*2]` f64 buffer
    //   (validated against `total = h*w*2` on lines 263-270) matches
    //   exactly.
    // - Lengths: `tmp` and `out` each `total = h*w*2` f64 elements
    //   (lines 312, 314); cuFFT reads/writes `h*w` Z2Z samples.
    // - Device pointers: `device_ptr_mut` lines 322-323; `_isync` /
    //   `_osync` `SyncOnDrop` guards remain alive across the FFI call
    //   so completion events fire on `stream`.
    // - Aliasing: `tmp` and `out` are distinct allocations; `tmp` is
    //   the safe-to-overwrite clone (cuFFT in-place ambiguity).
    // - Direction: enum cast to `c_int`, only legal values produced.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_z2z(
            plan.handle(),
            idata as *mut cufft_sys::cufftDoubleComplex,
            odata as *mut cufft_sys::cufftDoubleComplex,
            direction as c_int,
        )?;
    }

    if inverse {
        let scale = 1.0_f64 / (h as f64 * w as f64);
        out = crate::kernels::gpu_scale_f64(&out, scale, device)?;
    }
    Ok(out)
}

// ---------------------------------------------------------------------------
// Real-to-complex (f32)
// ---------------------------------------------------------------------------

/// Forward 1-D real-to-complex FFT, batched. Reads `[batch * n]` real f32,
/// writes `[batch * (n/2 + 1) * 2]` interleaved complex f32.
pub fn gpu_rfft_r2c_f32(
    input: &CudaBuffer<f32>,
    batch: usize,
    n: usize,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f32>> {
    check_n_batch(n, batch, "gpu_rfft_r2c_f32")?;
    let in_total = batch.checked_mul(n).ok_or(GpuError::ShapeMismatch {
        op: "gpu_rfft_r2c_f32",
        expected: vec![batch, n],
        got: vec![input.len()],
    })?;
    if input.len() != in_total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_rfft_r2c_f32",
            expected: vec![batch, n],
            got: vec![input.len()],
        });
    }
    let half = n / 2 + 1;
    let out_total = batch * half * 2;

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n as i32,
        cufft_sys::cufftType::CUFFT_R2C,
        batch as i32,
        stream.clone(),
    )?;
    let mut tmp = crate::transfer::alloc_zeros_f32(in_total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f32(out_total, device)?;

    // SAFETY:
    // - `cufft_result::exec_r2c` is the unsafe FFI shim around
    //   `cufftExecR2C` (NVIDIA cuFFT, real-to-complex single precision).
    // - Plan: created with `CUFFT_R2C`, length `n`, batch `batch`, on
    //   this device's stream. Plan handle valid for the call.
    // - Input dtype: `cufftReal` is `float`, byte-equivalent to f32.
    //   `tmp` is a `[batch * n]` f32 buffer (allocation matches
    //   `in_total = batch*n` validated on the upstream guard).
    // - Output dtype: `cufftComplex` is interleaved `(re, im)` f32; our
    //   `[batch * (n/2 + 1) * 2]` f32 buffer (allocated as
    //   `out_total = batch * half * 2`) matches the cuFFT R2C output
    //   layout exactly (Hermitian-half representation).
    // - Lengths: cuFFT reads `batch*n` reals from `idata` and writes
    //   `batch*(n/2+1)` complex samples to `odata`. Our allocations
    //   match exactly.
    // - Device pointers: `device_ptr_mut` retrieves raw `CUdeviceptr`s
    //   plus `_isync` / `_osync` `SyncOnDrop` guards which order this
    //   exec against subsequent stream work when dropped at block exit.
    // - Aliasing: `tmp` and `out` are distinct allocations.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_r2c(
            plan.handle(),
            idata as *mut cufft_sys::cufftReal,
            odata as *mut cufft_sys::cufftComplex,
        )?;
    }
    Ok(out)
}

/// f64 variant of [`gpu_rfft_r2c_f32`].
pub fn gpu_rfft_r2c_f64(
    input: &CudaBuffer<f64>,
    batch: usize,
    n: usize,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f64>> {
    check_n_batch(n, batch, "gpu_rfft_r2c_f64")?;
    let in_total = batch.checked_mul(n).ok_or(GpuError::ShapeMismatch {
        op: "gpu_rfft_r2c_f64",
        expected: vec![batch, n],
        got: vec![input.len()],
    })?;
    if input.len() != in_total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_rfft_r2c_f64",
            expected: vec![batch, n],
            got: vec![input.len()],
        });
    }
    let half = n / 2 + 1;
    let out_total = batch * half * 2;

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n as i32,
        cufft_sys::cufftType::CUFFT_D2Z,
        batch as i32,
        stream.clone(),
    )?;
    let mut tmp = crate::transfer::alloc_zeros_f64(in_total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f64(out_total, device)?;

    // SAFETY:
    // - `cufft_result::exec_d2z` is the unsafe FFI shim around
    //   `cufftExecD2Z` (NVIDIA cuFFT, real-to-complex double precision).
    // - Plan: created with `CUFFT_D2Z`, length `n`, batch `batch`, on
    //   this device's stream. Plan handle valid for the call.
    // - Input dtype: `cufftDoubleReal` is `double`, byte-equivalent to
    //   f64. `tmp` is `[batch * n]` f64 (allocation matches
    //   `in_total = batch*n` validated upstream).
    // - Output dtype: `cufftDoubleComplex` is interleaved `(re, im)`
    //   f64 pairs. `out` is `[batch * (n/2 + 1) * 2]` f64 (allocated
    //   as `out_total = batch * half * 2`); cuFFT D2Z output layout
    //   matches exactly.
    // - Lengths: cuFFT reads `batch*n` reals, writes `batch*(n/2+1)`
    //   complex; allocations match.
    // - Device pointers: `device_ptr_mut` retrieves raw `CUdeviceptr`s
    //   plus `_isync` / `_osync` `SyncOnDrop` guards held alive across
    //   the FFI call, ordering this exec on `stream`.
    // - Aliasing: `tmp` and `out` distinct allocations.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_d2z(
            plan.handle(),
            idata as *mut cufft_sys::cufftDoubleReal,
            odata as *mut cufft_sys::cufftDoubleComplex,
        )?;
    }
    Ok(out)
}

// ---------------------------------------------------------------------------
// Complex-to-real (f32)
// ---------------------------------------------------------------------------

/// Inverse 1-D real FFT, batched. Reads `[batch * (n_out/2 + 1) * 2]`
/// interleaved complex f32, writes `[batch * n_out]` real f32, normalized
/// by `1/n_out` (matches torch convention).
pub fn gpu_irfft_c2r_f32(
    input: &CudaBuffer<f32>,
    batch: usize,
    n_out: usize,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f32>> {
    check_n_batch(n_out, batch, "gpu_irfft_c2r_f32")?;
    let half = n_out / 2 + 1;
    let in_total = batch
        .checked_mul(half)
        .and_then(|v| v.checked_mul(2))
        .ok_or(GpuError::ShapeMismatch {
            op: "gpu_irfft_c2r_f32",
            expected: vec![batch, half, 2],
            got: vec![input.len()],
        })?;
    if input.len() != in_total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_irfft_c2r_f32",
            expected: vec![batch, half, 2],
            got: vec![input.len()],
        });
    }
    let out_total = batch * n_out;

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n_out as i32,
        cufft_sys::cufftType::CUFFT_C2R,
        batch as i32,
        stream.clone(),
    )?;
    // C2R is documented as overwriting input on some architectures — clone.
    let mut tmp = crate::transfer::alloc_zeros_f32(in_total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f32(out_total, device)?;

    // SAFETY:
    // - `cufft_result::exec_c2r` is the unsafe FFI shim around
    //   `cufftExecC2R` (NVIDIA cuFFT, complex-to-real single precision).
    // - Plan: created with `CUFFT_C2R`, length `n_out`, batch `batch`,
    //   on this device's stream. Plan handle valid for the call.
    // - Input dtype: `cufftComplex` is interleaved `(re, im)` f32.
    //   `tmp` is `[batch * (n_out/2 + 1) * 2]` f32 (allocation matches
    //   `in_total = batch * half * 2`, validated upstream on lines
    //   419-432). cuFFT reads `batch*(n_out/2+1)` complex samples.
    // - Output dtype: `cufftReal` is `float`, byte-equivalent to f32;
    //   `out` is `[batch * n_out]` f32 (allocation matches
    //   `out_total = batch * n_out`). cuFFT writes exactly that many
    //   reals.
    // - Device pointers: `device_ptr_mut` lines 449-450; `_isync` /
    //   `_osync` `SyncOnDrop` guards record completion events on
    //   `stream` when dropped at block exit.
    // - Aliasing: `tmp` (cloned input on line 444) and `out` are
    //   distinct allocations; the clone is mandatory because cuFFT
    //   C2R is documented as potentially overwriting `idata` on some
    //   architectures (the function rustdoc on line 443 calls this
    //   out explicitly).
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_c2r(
            plan.handle(),
            idata as *mut cufft_sys::cufftComplex,
            odata as *mut cufft_sys::cufftReal,
        )?;
    }
    let scale = 1.0_f32 / n_out as f32;
    let normed = crate::kernels::gpu_scale(&out, scale, device)?;
    Ok(normed)
}

/// f64 variant of [`gpu_irfft_c2r_f32`].
pub fn gpu_irfft_c2r_f64(
    input: &CudaBuffer<f64>,
    batch: usize,
    n_out: usize,
    device: &GpuDevice,
) -> GpuResult<CudaBuffer<f64>> {
    check_n_batch(n_out, batch, "gpu_irfft_c2r_f64")?;
    let half = n_out / 2 + 1;
    let in_total = batch
        .checked_mul(half)
        .and_then(|v| v.checked_mul(2))
        .ok_or(GpuError::ShapeMismatch {
            op: "gpu_irfft_c2r_f64",
            expected: vec![batch, half, 2],
            got: vec![input.len()],
        })?;
    if input.len() != in_total {
        return Err(GpuError::ShapeMismatch {
            op: "gpu_irfft_c2r_f64",
            expected: vec![batch, half, 2],
            got: vec![input.len()],
        });
    }
    let out_total = batch * n_out;

    let stream = device.stream();
    let plan = CudaFft::plan_1d(
        n_out as i32,
        cufft_sys::cufftType::CUFFT_Z2D,
        batch as i32,
        stream.clone(),
    )?;
    let mut tmp = crate::transfer::alloc_zeros_f64(in_total, device)?;
    stream.memcpy_dtod(input.inner(), tmp.inner_mut())?;
    let mut out = crate::transfer::alloc_zeros_f64(out_total, device)?;

    // SAFETY:
    // - `cufft_result::exec_z2d` is the unsafe FFI shim around
    //   `cufftExecZ2D` (NVIDIA cuFFT, complex-to-real double precision).
    // - Plan: created with `CUFFT_Z2D`, length `n_out`, batch `batch`,
    //   on this device's stream. Plan handle valid for the call.
    // - Input dtype: `cufftDoubleComplex` is interleaved `(re, im)`
    //   f64 pairs. `tmp` is `[batch * (n_out/2 + 1) * 2]` f64 (matches
    //   `in_total = batch * half * 2`, validated upstream).
    // - Output dtype: `cufftDoubleReal` is `double`, byte-equivalent
    //   to f64; `out` is `[batch * n_out]` f64 (matches `out_total =
    //   batch * n_out`).
    // - Lengths: cuFFT reads `batch*(n_out/2+1)` complex samples from
    //   `idata` and writes `batch*n_out` reals to `odata`. Allocations
    //   match.
    // - Device pointers: `device_ptr_mut` retrieves raw `CUdeviceptr`
    //   plus `_isync` / `_osync` `SyncOnDrop` guards. The guards stay
    //   alive across the FFI call so completion events are recorded
    //   on `stream` before any subsequent op observes the buffers.
    // - Aliasing: `tmp` (cloned input) and `out` are distinct
    //   allocations; the clone protects against Z2D in-place
    //   overwrite ambiguity per the same caveat called out for the
    //   f32 variant on line 443.
    unsafe {
        let (idata, _isync) = tmp.inner_mut().device_ptr_mut(&stream);
        let (odata, _osync) = out.inner_mut().device_ptr_mut(&stream);
        cufft_result::exec_z2d(
            plan.handle(),
            idata as *mut cufft_sys::cufftDoubleComplex,
            odata as *mut cufft_sys::cufftDoubleReal,
        )?;
    }
    let scale = 1.0_f64 / n_out as f64;
    let normed = crate::kernels::gpu_scale_f64(&out, scale, device)?;
    Ok(normed)
}