ferro-projections 0.2.88

use std::collections::HashSet;

use schemars::JsonSchema;
use serde::{Deserialize, Serialize};

use crate::action::{ActionDef, GuardDef};
use crate::field::{infer_meaning, DataType, FieldDef, FieldMeaning, RenderHint};
use crate::intent::IntentHint;
use crate::relationship::{Cardinality, RelationshipDef};
use crate::state::{StateMachine, Warning};

/// Intermediate representation of a model for ServiceDef derivation.
///
/// Decouples ferro-projections from ORM-specific types. Callers populate
/// this from their own model parsing and pass it to `ServiceDef::from_model()`.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ModelMetadata {
    pub name: String,
    pub display_name: Option<String>,
    pub table: Option<String>,
    pub fields: Vec<FieldMetadata>,
}

/// Metadata for a single model field.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FieldMetadata {
    pub name: String,
    /// Raw Rust/SeaORM type string (e.g., `String`, `i32`, `Option<Uuid>`).
    pub column_type: String,
    pub is_primary_key: bool,
    pub is_nullable: bool,
}

/// Converts snake_case to Title Case ("order_item" -> "Order Item").
fn snake_to_title(s: &str) -> String {
    s.split('_')
        .map(|word| {
            let mut c = word.chars();
            match c.next() {
                None => String::new(),
                Some(first) => first.to_uppercase().collect::<String>() + c.as_str(),
            }
        })
        .collect::<Vec<_>>()
        .join(" ")
}

/// A service definition describing a domain entity and its fields.
///
/// Constructed via a builder API with method chaining:
///
/// ```
/// use ferro_projections::{ServiceDef, DataType, FieldMeaning};
///
/// let order = ServiceDef::new("order")
///     .display_name("Order")
///     .description("Manages customer orders")
///     .field("id", DataType::Integer, FieldMeaning::Identifier)
///     .field("total", DataType::Float, FieldMeaning::Money)
///     .optional_field("notes", DataType::String, FieldMeaning::FreeText);
/// ```
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, JsonSchema)]
pub struct ServiceDef {
    pub name: String,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub display_name: Option<String>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub description: Option<String>,
    pub fields: Vec<FieldDef>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub actions: Vec<ActionDef>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub guards: Vec<GuardDef>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub relationships: Vec<RelationshipDef>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub intent_hints: Vec<IntentHint>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub state_machine: Option<StateMachine>,
    /// Whether this projection is exposed as an MCP tool.
    /// Defaults to `false`. Only projections with `mcp_exposed: true`
    /// appear in a `tools/list` response.
    #[serde(default)]
    pub mcp_exposed: bool,
    /// FK column name used to scope reads to a tenant.
    /// Plain metadata read by ferro-mcp-server dispatch; no auth dependency here.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub tenant_column: Option<String>,
    /// Gate ability required to call this projection via MCP.
    /// Plain metadata read by the app's MCP handler; no auth dependency here.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub mcp_ability: Option<String>,
    /// Whether `create_<svc>` is derived for this projection (Track A).
    /// Enabling any CRUD write verb requires `mcp_write_ability` (see `validate`).
    #[serde(default)]
    pub creatable: bool,
    /// Whether `update_<svc>` (data-field patch) is derived for this projection.
    #[serde(default)]
    pub updatable: bool,
    /// Whether `delete_<svc>` (soft-delete, confirmation-gated) is derived.
    #[serde(default)]
    pub deletable: bool,
    /// Gate ability required to call the create/update/delete tools.
    /// Required when any of `creatable`/`updatable`/`deletable` is set.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub mcp_write_ability: Option<String>,
    /// Backing table name for derived CRUD dispatch (field→column binding).
    /// When `None`, the dispatch layer derives it from the service name.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub table: Option<String>,
    /// Soft-delete column name. When `None`, the dispatch layer defaults to `deleted_at`.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub soft_delete_column: Option<String>,
}

impl ServiceDef {
    /// Creates a new service definition with the given name.
    pub fn new(name: impl Into<String>) -> Self {
        Self {
            name: name.into(),
            display_name: None,
            description: None,
            fields: Vec::new(),
            actions: Vec::new(),
            guards: Vec::new(),
            relationships: Vec::new(),
            intent_hints: Vec::new(),
            state_machine: None,
            mcp_exposed: false,
            tenant_column: None,
            mcp_ability: None,
            creatable: false,
            updatable: false,
            deletable: false,
            mcp_write_ability: None,
            table: None,
            soft_delete_column: None,
        }
    }

    /// Sets the human-readable display name.
    pub fn display_name(mut self, name: impl Into<String>) -> Self {
        self.display_name = Some(name.into());
        self
    }

    /// Sets the service description.
    pub fn description(mut self, desc: impl Into<String>) -> Self {
        self.description = Some(desc.into());
        self
    }

    /// Marks this projection as MCP-exposed.
    pub fn mcp_exposed(mut self, exposed: bool) -> Self {
        self.mcp_exposed = exposed;
        self
    }

    /// Declares the FK column name used to scope reads to a tenant.
    /// Plain metadata read by ferro-mcp-server dispatch; no auth dependency here.
    pub fn tenant_column(mut self, col: impl Into<String>) -> Self {
        self.tenant_column = Some(col.into());
        self
    }

    /// Declares the Gate ability required to call this projection via MCP.
    /// Plain metadata read by the app's MCP handler; no auth dependency here.
    pub fn mcp_ability(mut self, ability: impl Into<String>) -> Self {
        self.mcp_ability = Some(ability.into());
        self
    }

    /// Enables derivation of `create_<svc>`. Requires `mcp_write_ability` (Track A).
    pub fn creatable(mut self, yes: bool) -> Self {
        self.creatable = yes;
        self
    }

    /// Enables derivation of `update_<svc>` (data-field patch). Requires `mcp_write_ability`.
    pub fn updatable(mut self, yes: bool) -> Self {
        self.updatable = yes;
        self
    }

    /// Enables derivation of `delete_<svc>` (soft-delete, confirmation-gated).
    /// Requires `mcp_write_ability`.
    pub fn deletable(mut self, yes: bool) -> Self {
        self.deletable = yes;
        self
    }

    /// Declares the Gate ability required to call create/update/delete tools.
    pub fn mcp_write_ability(mut self, ability: impl Into<String>) -> Self {
        self.mcp_write_ability = Some(ability.into());
        self
    }

    /// Declares the backing table for derived CRUD dispatch (field→column binding).
    pub fn table(mut self, table: impl Into<String>) -> Self {
        self.table = Some(table.into());
        self
    }

    /// Declares the soft-delete column (defaults to `deleted_at` when unset).
    pub fn soft_delete_column(mut self, col: impl Into<String>) -> Self {
        self.soft_delete_column = Some(col.into());
        self
    }

    /// Returns the backing table name: explicit `.table()` value or the
    /// default `format!("{}s", name.to_lowercase())`.
    ///
    /// Matches the inline derivation previously at dispatch.rs:123 — the default
    /// MUST stay byte-identical or existing projections query the wrong table.
    pub fn resolved_table(&self) -> String {
        self.table
            .clone()
            .unwrap_or_else(|| format!("{}s", self.name.to_lowercase()))
    }

    /// Returns the soft-delete column name: explicit `.soft_delete_column()` value
    /// or the default `"deleted_at"`.
    pub fn resolved_soft_delete_column(&self) -> &str {
        self.soft_delete_column.as_deref().unwrap_or("deleted_at")
    }

    /// Returns true if the field must be server-injected and never an agent input.
    ///
    /// Covers:
    /// - Identifier fields (primary key — set by DB auto-increment)
    /// - CreatedAt fields (set by DB DEFAULT current_timestamp)
    /// - The tenant column (injected from McpContext, never from agent payload)
    ///
    /// This is the schema-derivation boundary Phase 240 consumes to exclude these
    /// fields from derived write input schemas (T-239-01 mitigation substrate).
    pub fn is_server_injected_field(&self, field: &FieldDef) -> bool {
        matches!(
            field.meaning,
            FieldMeaning::Identifier | FieldMeaning::CreatedAt
        ) || self
            .tenant_column
            .as_deref()
            .map(|tc| tc == field.name)
            .unwrap_or(false)
    }

    /// Returns `true` if a field must be excluded from write input schemas
    /// (create and update). Composes [`Self::is_server_injected_field`] and adds
    /// UpdatedAt, Sensitive, and list-field exclusions.
    ///
    /// `exclude_sm_status`: callers pass `self.state_machine.is_some()`; when `true`,
    /// a `Status` field is also excluded because the StateMachine sets it server-side
    /// to the initial state.
    pub fn is_write_excluded_field(&self, field: &FieldDef, exclude_sm_status: bool) -> bool {
        // Gate A: server-injected — Identifier, CreatedAt, tenant column (Phase 239)
        if self.is_server_injected_field(field) {
            return true;
        }
        // Gate B: UpdatedAt — server-managed timestamp (D-05)
        if matches!(field.meaning, FieldMeaning::UpdatedAt) {
            return true;
        }
        // Gate C: Sensitive — never an agent write input (D-03)
        if matches!(field.meaning, FieldMeaning::Sensitive) {
            return true;
        }
        // Gate D: list fields — not useful as scalar write inputs (D-03)
        if field.is_list {
            return true;
        }
        // Gate E: Status under a StateMachine — set server-side (D-04/D-07)
        if exclude_sm_status && matches!(field.meaning, FieldMeaning::Status) {
            return true;
        }
        // Gate F: read-only field — declared non-writable (e.g. read_only_field for a
        // derived/computed value like an order total). Never an agent write input;
        // the `writable` flag is the single source of truth for write eligibility.
        if !field.writable {
            return true;
        }
        false
    }

    /// Adds a required read-write field.
    pub fn field(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: true,
            is_list: false,
            readable: true,
            writable: true,
            render_hint: None,
        });
        self
    }

    /// Adds a required read-write field carrying a non-visual [`RenderHint`].
    ///
    /// Use for `Url`/`ImageUrl` fields whose raw value has no useful text form:
    /// `RenderHint::AltText(s)` substitutes `s`, `RenderHint::Skip` omits the
    /// field from non-visual output. The visual renderer ignores the hint.
    pub fn field_with_hint(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
        hint: RenderHint,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: true,
            is_list: false,
            readable: true,
            writable: true,
            render_hint: Some(hint),
        });
        self
    }

    /// Adds an optional (nullable) read-write field.
    pub fn optional_field(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: false,
            is_list: false,
            readable: true,
            writable: true,
            render_hint: None,
        });
        self
    }

    /// Adds a required read-write list field.
    pub fn list_field(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: true,
            is_list: true,
            readable: true,
            writable: true,
            render_hint: None,
        });
        self
    }

    /// Adds a required read-only field (readable but not writable).
    ///
    /// For system-assigned or computed fields like id, created_at, or totals.
    pub fn read_only_field(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: true,
            is_list: false,
            readable: true,
            writable: false,
            render_hint: None,
        });
        self
    }

    /// Adds a required write-only field (writable but not readable).
    ///
    /// For sensitive inputs like passwords or API keys that should not be read back.
    pub fn write_only_field(
        mut self,
        name: impl Into<String>,
        data_type: DataType,
        meaning: FieldMeaning,
    ) -> Self {
        self.fields.push(FieldDef {
            name: name.into(),
            data_type,
            meaning,
            required: true,
            is_list: false,
            readable: false,
            writable: true,
            render_hint: None,
        });
        self
    }

    /// Adds an action definition to this service.
    pub fn action(mut self, action: ActionDef) -> Self {
        self.actions.push(action);
        self
    }

    /// Adds a guard definition to this service.
    pub fn guard(mut self, guard: GuardDef) -> Self {
        self.guards.push(guard);
        self
    }

    /// Adds a relationship definition to this service.
    pub fn relationship(mut self, rel: RelationshipDef) -> Self {
        self.relationships.push(rel);
        self
    }

    /// Adds a many-to-one relationship (this service belongs to target).
    pub fn belongs_to(self, name: impl Into<String>, target: impl Into<String>) -> Self {
        self.relationship(RelationshipDef::new(name, target, Cardinality::ManyToOne))
    }

    /// Adds a one-to-many relationship (this service has many of target).
    pub fn has_many(self, name: impl Into<String>, target: impl Into<String>) -> Self {
        self.relationship(RelationshipDef::new(name, target, Cardinality::OneToMany))
    }

    /// Adds a one-to-one relationship (this service has one of target).
    pub fn has_one(self, name: impl Into<String>, target: impl Into<String>) -> Self {
        self.relationship(RelationshipDef::new(name, target, Cardinality::OneToOne))
    }

    /// Adds a many-to-many relationship (this service belongs to many of target).
    pub fn belongs_to_many(self, name: impl Into<String>, target: impl Into<String>) -> Self {
        self.relationship(RelationshipDef::new(name, target, Cardinality::ManyToMany))
    }

    /// Adds an intent hint for overriding structural derivation.
    pub fn intent_hint(mut self, hint: IntentHint) -> Self {
        self.intent_hints.push(hint);
        self
    }

    /// Sets the state machine definition for this service.
    pub fn state_machine(mut self, machine: StateMachine) -> Self {
        self.state_machine = Some(machine);
        self
    }

    /// Derives a ServiceDef from model metadata.
    ///
    /// Infers `DataType` from column type strings and `FieldMeaning` from field names.
    /// System fields (`id`, `created_at`, `updated_at`, primary keys) are marked read-only.
    /// Actions, state machines, and relationships are not derived.
    pub fn from_model(meta: &ModelMetadata) -> Self {
        let display = meta
            .display_name
            .clone()
            .unwrap_or_else(|| snake_to_title(&meta.name));

        let mut def = Self::new(&meta.name).display_name(display);

        for field in &meta.fields {
            let data_type = DataType::from_column_type(&field.column_type);
            let meaning = infer_meaning(&field.name);

            let is_system = matches!(field.name.as_str(), "id" | "created_at" | "updated_at")
                || field.is_primary_key;

            def.fields.push(FieldDef {
                name: field.name.clone(),
                data_type,
                meaning,
                required: !field.is_nullable,
                is_list: false,
                readable: true,
                writable: !is_system,
                render_hint: None,
            });
        }

        def
    }

    /// Validates the service definition and returns warnings for potential issues.
    ///
    /// This is the single validation entry point that subsumes `StateMachine::validate()`.
    /// Guard names form a shared pool referenced from transitions and action preconditions.
    ///
    /// Returns `Err` for fatal issues (undefined guard references, unmatched triggers).
    /// Returns `Ok(warnings)` for structural concerns (unused guards, missing state machine).
    pub fn validate(&self) -> Result<Vec<Warning>, crate::Error> {
        let mut warnings = Vec::new();

        // 0. Track A: enabling any CRUD write verb requires a declared write ability.
        // Fail-fast at registration rather than silently denying at call time.
        if (self.creatable || self.updatable || self.deletable) && self.mcp_write_ability.is_none()
        {
            return Err(crate::Error::Validation(format!(
                "projection '{}' enables create/update/delete but declares no mcp_write_ability",
                self.name
            )));
        }

        // 1. Delegate to state machine validation if present
        if let Some(ref sm) = self.state_machine {
            warnings.extend(sm.validate()?);
        }

        // 2. Collect declared guard names
        let declared_guards: HashSet<&str> = self.guards.iter().map(|g| g.name.as_str()).collect();

        // 3. Check action preconditions reference declared guards
        for action in &self.actions {
            for precondition in &action.preconditions {
                if !declared_guards.contains(precondition.as_str()) {
                    return Err(crate::Error::Validation(format!(
                        "action '{}' references undefined guard '{}'",
                        action.name, precondition
                    )));
                }
            }
        }

        // 4. Check transition guards reference declared guards (if state machine exists)
        if let Some(ref sm) = self.state_machine {
            for transition in &sm.transitions {
                if let Some(ref guard) = transition.guard {
                    if !declared_guards.contains(guard.as_str()) {
                        return Err(crate::Error::Validation(format!(
                            "transition '{}' -> '{}' references undefined guard '{}'",
                            transition.from, transition.to, guard
                        )));
                    }
                }
            }
        }

        // 5. Check action transition_triggers match state machine event names
        if let Some(ref sm) = self.state_machine {
            let event_names: HashSet<&str> =
                sm.transitions.iter().map(|t| t.event.as_str()).collect();
            for action in &self.actions {
                if let Some(ref trigger) = action.transition_trigger {
                    if !event_names.contains(trigger.as_str()) {
                        return Err(crate::Error::Validation(format!(
                            "action '{}' has transition_trigger '{}' that does not match any state machine event",
                            action.name, trigger
                        )));
                    }
                }
            }
        }

        // 5b. Sync-by-construction gate: every transition-triggering action must
        // produce a TransitionPlan via the same derivation the runtime uses. This
        // round-trip guarantees `validate()` accepting an action implies the
        // derivation can build a plan for it — drift between the two is structurally
        // impossible (EXEC-04). Surfaces AmbiguousTransition at registration too.
        if self.state_machine.is_some() {
            for action in &self.actions {
                if action.transition_trigger.is_some() {
                    crate::executor::derive_transition_plan(self, &action.name)?;
                }
            }
        }

        // 6. Warn about declared guards never referenced
        let mut referenced_guards: HashSet<&str> = HashSet::new();
        for action in &self.actions {
            for precondition in &action.preconditions {
                referenced_guards.insert(precondition.as_str());
            }
        }
        if let Some(ref sm) = self.state_machine {
            for transition in &sm.transitions {
                if let Some(ref guard) = transition.guard {
                    referenced_guards.insert(guard.as_str());
                }
            }
        }
        for guard in &self.guards {
            if !referenced_guards.contains(guard.name.as_str()) {
                warnings.push(Warning::UnusedGuard(guard.name.clone()));
            }
        }

        // 7. Warn about actions with transition_trigger when no state machine exists
        if self.state_machine.is_none() {
            for action in &self.actions {
                if action.transition_trigger.is_some() {
                    warnings.push(Warning::TransitionTriggerWithoutStateMachine(
                        action.name.clone(),
                    ));
                }
            }
        }

        // 8. Warn about duplicate relationship names
        {
            let mut seen = HashSet::new();
            for rel in &self.relationships {
                if !seen.insert(rel.name.as_str()) {
                    warnings.push(Warning::DuplicateRelationship(rel.name.clone()));
                }
            }
        }

        // 9. Warn if ManyToMany relationship has foreign_key set
        for rel in &self.relationships {
            if rel.cardinality == Cardinality::ManyToMany && rel.foreign_key.is_some() {
                warnings.push(Warning::ManyToManyWithForeignKey {
                    relationship: rel.name.clone(),
                });
            }
        }

        // 10. Check for conflicting intent hints (same intent in both Primary and Exclude)
        {
            let mut primaries = HashSet::new();
            let mut excludes = HashSet::new();
            let mut primary_count = 0u32;

            for hint in &self.intent_hints {
                match hint {
                    IntentHint::Primary(intent) => {
                        primary_count += 1;
                        let serialized = serde_json::to_string(intent)
                            .unwrap_or_default()
                            .trim_matches('"')
                            .to_string();
                        primaries.insert(serialized);
                    }
                    IntentHint::Exclude(intent) => {
                        let serialized = serde_json::to_string(intent)
                            .unwrap_or_default()
                            .trim_matches('"')
                            .to_string();
                        excludes.insert(serialized);
                    }
                }
            }

            for intent_name in primaries.intersection(&excludes) {
                warnings.push(Warning::ConflictingIntentHints {
                    intent: intent_name.clone(),
                });
            }

            if primary_count > 1 {
                warnings.push(Warning::MultiplePrimaryIntentHints);
            }
        }

        Ok(warnings)
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn service_def_builder_chain() {
        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Manages customer orders")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .optional_field("notes", DataType::String, FieldMeaning::FreeText)
            .list_field("tags", DataType::String, FieldMeaning::Category);

        assert_eq!(service.name, "order");
        assert_eq!(service.display_name.as_deref(), Some("Order"));
        assert_eq!(
            service.description.as_deref(),
            Some("Manages customer orders")
        );
        assert_eq!(service.fields.len(), 5);

        // Required field
        assert!(service.fields[0].required);
        assert!(!service.fields[0].is_list);

        // Optional field
        assert!(!service.fields[3].required);
        assert!(!service.fields[3].is_list);

        // List field
        assert!(service.fields[4].required);
        assert!(service.fields[4].is_list);
    }

    #[test]
    fn service_def_minimal() {
        let service = ServiceDef::new("user");
        assert_eq!(service.name, "user");
        assert!(service.display_name.is_none());
        assert!(service.description.is_none());
        assert!(service.fields.is_empty());
    }

    #[test]
    fn service_def_serde_round_trip() {
        let service = ServiceDef::new("order")
            .display_name("Order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("total", DataType::Float, FieldMeaning::Money)
            .optional_field("notes", DataType::String, FieldMeaning::FreeText);

        let json = serde_json::to_string(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn service_def_json_omits_none_fields() {
        let service = ServiceDef::new("order");
        let json = serde_json::to_string(&service).unwrap();
        assert!(!json.contains("display_name"));
        assert!(!json.contains("description"));
    }

    #[test]
    fn service_def_multiple_fields() {
        let service = ServiceDef::new("product")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("name", DataType::String, FieldMeaning::EntityName)
            .field("price", DataType::Float, FieldMeaning::Money)
            .field("sku", DataType::String, FieldMeaning::Custom("sku".into()))
            .field("created_at", DataType::DateTime, FieldMeaning::CreatedAt);

        assert_eq!(service.fields.len(), 5);
        // Order preserved
        assert_eq!(service.fields[0].name, "id");
        assert_eq!(service.fields[1].name, "name");
        assert_eq!(service.fields[2].name, "price");
        assert_eq!(service.fields[3].name, "sku");
        assert_eq!(service.fields[4].name, "created_at");
    }

    #[test]
    fn field_with_hint_attaches_render_hint() {
        let service = ServiceDef::new("profile")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field_with_hint(
                "avatar",
                DataType::String,
                FieldMeaning::ImageUrl,
                RenderHint::AltText("User avatar".into()),
            );

        assert_eq!(service.fields[0].render_hint, None);
        assert_eq!(
            service.fields[1].render_hint,
            Some(RenderHint::AltText("User avatar".into()))
        );
        // Mirrors `.field()`: required, read-write, not a list.
        assert!(service.fields[1].required);
        assert!(service.fields[1].readable);
        assert!(service.fields[1].writable);
        assert!(!service.fields[1].is_list);
    }

    #[test]
    fn service_def_json_structure() {
        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Customer orders")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .optional_field("notes", DataType::String, FieldMeaning::FreeText);

        let json = serde_json::to_string(&service).unwrap();
        let value: serde_json::Value = serde_json::from_str(&json).unwrap();

        assert!(value.get("name").is_some());
        assert!(value.get("display_name").is_some());
        assert!(value.get("description").is_some());
        assert!(value.get("fields").is_some());

        let fields = value["fields"].as_array().unwrap();
        assert_eq!(fields.len(), 2);
    }

    #[test]
    fn order_service_example() {
        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Manages customer orders and fulfillment")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("customer_id", DataType::Integer, FieldMeaning::ForeignKey)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .field("email", DataType::String, FieldMeaning::Email)
            .field("notes", DataType::String, FieldMeaning::FreeText)
            .field("created_at", DataType::DateTime, FieldMeaning::CreatedAt)
            .field("updated_at", DataType::DateTime, FieldMeaning::UpdatedAt);

        assert_eq!(service.fields.len(), 8);
        assert_eq!(service.fields[2].meaning, FieldMeaning::Money);
        assert_eq!(service.fields[3].meaning, FieldMeaning::Status);

        // Serde round-trip
        let json = serde_json::to_string(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    // -- StateMachine integration tests --

    use crate::state::{StateDef, StateMachine, Transition};

    #[test]
    fn service_def_with_state_machine() {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("completed").final_state())
            .transition(Transition::new("draft", "complete", "completed"));

        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .state_machine(machine);

        assert!(service.state_machine.is_some());
        let sm = service.state_machine.as_ref().unwrap();
        assert_eq!(sm.states.len(), 2);
        assert_eq!(sm.transitions.len(), 1);
    }

    #[test]
    fn service_def_state_machine_serde_round_trip() {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft").display_name("Draft"))
            .state(
                StateDef::new("completed")
                    .display_name("Completed")
                    .final_state(),
            )
            .transition(
                Transition::new("draft", "complete", "completed")
                    .guard("is_valid")
                    .actions(vec!["notify"]),
            );

        let service = ServiceDef::new("order")
            .display_name("Order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("status", DataType::String, FieldMeaning::Status)
            .state_machine(machine);

        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn service_def_without_state_machine_json() {
        let service =
            ServiceDef::new("user").field("id", DataType::Integer, FieldMeaning::Identifier);

        let json = serde_json::to_string(&service).unwrap();
        assert!(!json.contains("state_machine"));
    }

    #[test]
    fn order_service_full_example() {
        let machine = StateMachine::new("order_lifecycle")
            .display_name("Order Lifecycle")
            .description("Tracks an order from creation to fulfillment")
            .initial("draft")
            .state(
                StateDef::new("draft")
                    .display_name("Draft")
                    .description("Order is being prepared"),
            )
            .state(
                StateDef::new("submitted")
                    .display_name("Submitted")
                    .on_enter(vec!["validate_inventory", "calculate_totals"]),
            )
            .state(
                StateDef::new("processing")
                    .display_name("Processing")
                    .on_enter(vec!["charge_payment", "reserve_inventory"]),
            )
            .state(
                StateDef::new("shipped")
                    .display_name("Shipped")
                    .on_enter(vec!["generate_tracking", "notify_customer"]),
            )
            .state(
                StateDef::new("delivered")
                    .display_name("Delivered")
                    .final_state(),
            )
            .state(
                StateDef::new("cancelled")
                    .display_name("Cancelled")
                    .final_state()
                    .on_enter(vec!["refund_payment", "release_inventory"]),
            )
            .transition(
                Transition::new("draft", "submit", "submitted")
                    .guard("has_items")
                    .description("Customer submits the order"),
            )
            .transition(
                Transition::new("submitted", "process", "processing")
                    .guard("payment_valid")
                    .actions(vec!["lock_prices"]),
            )
            .transition(
                Transition::new("processing", "ship", "shipped").guard("inventory_fulfilled"),
            )
            .transition(Transition::new("shipped", "deliver", "delivered"))
            .transition(Transition::new("draft", "cancel", "cancelled"))
            .transition(
                Transition::new("submitted", "cancel", "cancelled").guard("cancellation_allowed"),
            )
            .transition(
                Transition::new("processing", "cancel", "cancelled")
                    .guard("cancellation_allowed")
                    .actions(vec!["reverse_payment"]),
            );

        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Manages customer orders and fulfillment")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("customer_id", DataType::Integer, FieldMeaning::ForeignKey)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .field("email", DataType::String, FieldMeaning::Email)
            .field("notes", DataType::String, FieldMeaning::FreeText)
            .field("created_at", DataType::DateTime, FieldMeaning::CreatedAt)
            .field("updated_at", DataType::DateTime, FieldMeaning::UpdatedAt)
            .state_machine(machine);

        // Field assertions
        assert_eq!(service.fields.len(), 8);

        // State machine assertions
        let sm = service.state_machine.as_ref().unwrap();
        assert_eq!(sm.states.len(), 6);
        assert_eq!(sm.transitions.len(), 7);
        assert_eq!(sm.initial_state, "draft");

        // Validation passes cleanly
        let warnings = sm.validate().unwrap();
        assert!(warnings.is_empty());

        // Serde round-trip
        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn service_def_json_schema() {
        let schema = schemars::schema_for!(ServiceDef);
        let value = schema.to_value();
        let props = value
            .get("properties")
            .expect("ServiceDef schema must have properties");
        let obj = props.as_object().unwrap();
        assert!(obj.contains_key("name"), "missing 'name' property");
        assert!(obj.contains_key("fields"), "missing 'fields' property");
        assert!(
            obj.contains_key("state_machine"),
            "missing 'state_machine' property"
        );
    }

    // -- readable/writable builder tests --

    #[test]
    fn read_only_field_builder() {
        let service = ServiceDef::new("order")
            .read_only_field("id", DataType::Integer, FieldMeaning::Identifier)
            .read_only_field("created_at", DataType::DateTime, FieldMeaning::CreatedAt);

        assert_eq!(service.fields.len(), 2);
        for f in &service.fields {
            assert!(f.readable);
            assert!(!f.writable);
            assert!(f.required);
            assert!(!f.is_list);
        }
    }

    #[test]
    fn write_only_field_builder() {
        let service = ServiceDef::new("user").write_only_field(
            "password",
            DataType::String,
            FieldMeaning::Sensitive,
        );

        assert_eq!(service.fields.len(), 1);
        let f = &service.fields[0];
        assert!(!f.readable);
        assert!(f.writable);
        assert!(f.required);
        assert!(!f.is_list);
    }

    #[test]
    fn mixed_access_fields_serde_round_trip() {
        let service = ServiceDef::new("user")
            .read_only_field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("name", DataType::String, FieldMeaning::EntityName)
            .write_only_field("password", DataType::String, FieldMeaning::Sensitive)
            .read_only_field("created_at", DataType::DateTime, FieldMeaning::CreatedAt);

        let json = serde_json::to_string(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);

        // Verify access modes survived round-trip
        assert!(parsed.fields[0].readable);
        assert!(!parsed.fields[0].writable);
        assert!(parsed.fields[1].readable);
        assert!(parsed.fields[1].writable);
        assert!(!parsed.fields[2].readable);
        assert!(parsed.fields[2].writable);
        assert!(parsed.fields[3].readable);
        assert!(!parsed.fields[3].writable);
    }

    #[test]
    fn existing_field_builders_default_read_write() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .optional_field("notes", DataType::String, FieldMeaning::FreeText)
            .list_field("tags", DataType::String, FieldMeaning::Category);

        for f in &service.fields {
            assert!(f.readable, "field '{}' should be readable", f.name);
            assert!(f.writable, "field '{}' should be writable", f.name);
        }
    }

    // -- Phase 86-02 tests: actions/guards integration + validate() --

    use crate::action::{ActionDef, GuardDef, InputDef};
    use crate::state::Warning;

    #[test]
    fn service_def_with_actions_and_guards_builder() {
        let service = ServiceDef::new("order")
            .guard(GuardDef::new("has_items"))
            .guard(GuardDef::new("payment_valid"))
            .action(
                ActionDef::new("submit_order")
                    .precondition("has_items")
                    .precondition("payment_valid"),
            )
            .action(ActionDef::new("update_notes"));

        assert_eq!(service.guards.len(), 2);
        assert_eq!(service.actions.len(), 2);
        assert_eq!(service.actions[0].name, "submit_order");
        assert_eq!(service.actions[1].name, "update_notes");
    }

    #[test]
    fn service_def_serde_round_trip_with_actions_guards() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .guard(GuardDef::new("has_items").display_name("Has Items"))
            .action(
                ActionDef::new("submit")
                    .input(InputDef::new(
                        "order_id",
                        DataType::Integer,
                        FieldMeaning::Identifier,
                    ))
                    .precondition("has_items")
                    .effect("notify"),
            );

        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn service_def_json_omits_empty_actions_guards() {
        let service = ServiceDef::new("user");
        let json = serde_json::to_string(&service).unwrap();
        assert!(!json.contains("actions"));
        assert!(!json.contains("guards"));
    }

    #[test]
    fn validate_passes_valid_service() {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("submitted").final_state())
            .transition(Transition::new("draft", "submit", "submitted").guard("has_items"));

        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .guard(GuardDef::new("has_items"))
            .action(
                ActionDef::new("submit_order")
                    .precondition("has_items")
                    .transition_trigger("submit"),
            )
            .state_machine(machine);

        let warnings = service.validate().unwrap();
        assert!(warnings.is_empty());
    }

    #[test]
    fn validate_catches_undefined_action_precondition() {
        let service = ServiceDef::new("order")
            .guard(GuardDef::new("has_items"))
            .action(ActionDef::new("submit").precondition("nonexistent_guard"));

        let result = service.validate();
        assert!(result.is_err());
        let err = result.unwrap_err().to_string();
        assert!(err.contains("nonexistent_guard"));
        assert!(err.contains("submit"));
    }

    #[test]
    fn validate_catches_undefined_transition_guard() {
        let machine = StateMachine::new("lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("done").final_state())
            .transition(Transition::new("draft", "finish", "done").guard("undefined_guard"));

        let service = ServiceDef::new("order").state_machine(machine);

        let result = service.validate();
        assert!(result.is_err());
        let err = result.unwrap_err().to_string();
        assert!(err.contains("undefined_guard"));
    }

    #[test]
    fn validate_catches_unmatched_transition_trigger() {
        let machine = StateMachine::new("lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("done").final_state())
            .transition(Transition::new("draft", "finish", "done"));

        let service = ServiceDef::new("order")
            .action(ActionDef::new("submit").transition_trigger("nonexistent_event"))
            .state_machine(machine);

        let result = service.validate();
        assert!(result.is_err());
        let err = result.unwrap_err().to_string();
        assert!(err.contains("nonexistent_event"));
    }

    /// A well-formed order service mirroring the EXEC-01 reference fixture,
    /// used by the EXEC-04 sync-by-construction tests below.
    fn well_formed_order_service() -> ServiceDef {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("submitted"))
            .state(StateDef::new("approved"))
            .state(StateDef::new("cancelled").final_state())
            .state(StateDef::new("shipped"))
            .state(StateDef::new("delivered").final_state())
            .transition(Transition::new("draft", "submit", "submitted"))
            .transition(Transition::new("submitted", "approve", "approved").guard("is_manager"))
            .transition(Transition::new("approved", "ship", "shipped"))
            .transition(Transition::new("draft", "cancel", "cancelled"))
            .transition(Transition::new("submitted", "cancel", "cancelled"));

        ServiceDef::new("order")
            .guard(GuardDef::new("is_manager"))
            .state_machine(machine)
            .action(ActionDef::new("submit").transition_trigger("submit"))
            .action(
                ActionDef::new("approve")
                    .transition_trigger("approve")
                    .precondition("is_manager"),
            )
            .action(ActionDef::new("ship").transition_trigger("ship"))
            .action(ActionDef::new("cancel").transition_trigger("cancel"))
    }

    #[test]
    fn validate_rejects_undeclared_trigger() {
        let machine = StateMachine::new("lifecycle")
            .initial("draft")
            .state(StateDef::new("draft"))
            .state(StateDef::new("done").final_state())
            .transition(Transition::new("draft", "finish", "done"));

        let service = ServiceDef::new("order")
            .state_machine(machine)
            .action(ActionDef::new("submit").transition_trigger("typo_event"));

        let err = service.validate().unwrap_err();
        // Step 5 produces a Validation error naming the bad trigger; the
        // round-trip in step 5b is consistent with it (same fact).
        assert!(err.to_string().contains("typo_event"));
    }

    #[test]
    fn validate_accepts_well_formed_order_service() {
        let service = well_formed_order_service();
        assert!(service.validate().is_ok());
    }

    #[test]
    fn validate_round_trips_derivation() {
        let service = well_formed_order_service();
        // validate() accepts it...
        assert!(service.validate().is_ok());
        // ...and every transition-triggering action yields a plan, so the two
        // checks cannot diverge.
        for action in &service.actions {
            if action.transition_trigger.is_some() {
                assert!(
                    crate::executor::derive_transition_plan(&service, &action.name).is_ok(),
                    "derivation must succeed for action '{}'",
                    action.name
                );
            }
        }
    }

    #[test]
    fn validate_rejects_ambiguous_fan_out_at_registration() {
        // A fan-out event now fails registration (step 5b), not first call.
        let machine = StateMachine::new("lifecycle")
            .initial("a")
            .state(StateDef::new("a"))
            .state(StateDef::new("b"))
            .state(StateDef::new("c"))
            .state(StateDef::new("d"))
            .transition(Transition::new("a", "split", "b"))
            .transition(Transition::new("c", "split", "d"));

        let service = ServiceDef::new("order")
            .state_machine(machine)
            .action(ActionDef::new("split").transition_trigger("split"));

        let err = service.validate().unwrap_err();
        assert!(matches!(err, crate::Error::AmbiguousTransition { ref event } if event == "split"));
    }

    #[test]
    fn validate_warns_unused_guards() {
        let service = ServiceDef::new("order")
            .guard(GuardDef::new("used_guard"))
            .guard(GuardDef::new("unused_guard"))
            .action(ActionDef::new("submit").precondition("used_guard"));

        let warnings = service.validate().unwrap();
        assert_eq!(warnings.len(), 1);
        assert!(warnings.contains(&Warning::UnusedGuard("unused_guard".into())));
    }

    #[test]
    fn validate_warns_transition_trigger_without_state_machine() {
        let service =
            ServiceDef::new("order").action(ActionDef::new("submit").transition_trigger("submit"));

        let warnings = service.validate().unwrap();
        assert_eq!(warnings.len(), 1);
        assert!(
            warnings.contains(&Warning::TransitionTriggerWithoutStateMachine(
                "submit".into()
            ))
        );
    }

    #[test]
    fn validate_delegates_to_state_machine_validate() {
        // Missing initial state in states — state machine validation catches this
        let machine = StateMachine::new("lifecycle")
            .initial("nonexistent")
            .state(StateDef::new("a").final_state());

        let service = ServiceDef::new("order").state_machine(machine);

        let result = service.validate();
        assert!(result.is_err());
        let err = result.unwrap_err().to_string();
        assert!(err.contains("nonexistent"));
    }

    #[test]
    fn validate_without_state_machine_or_actions_passes_clean() {
        let service =
            ServiceDef::new("simple").field("id", DataType::Integer, FieldMeaning::Identifier);

        let warnings = service.validate().unwrap();
        assert!(warnings.is_empty());
    }

    #[test]
    fn full_order_service_with_guards_actions_validates_clean() {
        let machine = StateMachine::new("order_lifecycle")
            .display_name("Order Lifecycle")
            .initial("draft")
            .state(StateDef::new("draft").display_name("Draft"))
            .state(StateDef::new("submitted").display_name("Submitted"))
            .state(StateDef::new("processing").display_name("Processing"))
            .state(
                StateDef::new("shipped")
                    .display_name("Shipped")
                    .final_state(),
            )
            .state(
                StateDef::new("cancelled")
                    .display_name("Cancelled")
                    .final_state(),
            )
            .transition(Transition::new("draft", "submit", "submitted").guard("has_items"))
            .transition(
                Transition::new("submitted", "process", "processing").guard("payment_valid"),
            )
            .transition(
                Transition::new("processing", "ship", "shipped").guard("inventory_fulfilled"),
            )
            .transition(
                Transition::new("draft", "cancel", "cancelled").guard("cancellation_allowed"),
            )
            .transition(
                Transition::new("submitted", "cancel", "cancelled").guard("cancellation_allowed"),
            );

        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Full order management")
            .read_only_field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("customer_id", DataType::Integer, FieldMeaning::ForeignKey)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .read_only_field("created_at", DataType::DateTime, FieldMeaning::CreatedAt)
            .guard(GuardDef::new("has_items").display_name("Has Items"))
            .guard(GuardDef::new("payment_valid").display_name("Payment Valid"))
            .guard(GuardDef::new("inventory_fulfilled").display_name("Inventory Fulfilled"))
            .guard(GuardDef::new("cancellation_allowed").display_name("Cancellation Allowed"))
            .action(
                ActionDef::new("submit_order")
                    .display_name("Submit Order")
                    .input(InputDef::new(
                        "order_id",
                        DataType::Integer,
                        FieldMeaning::Identifier,
                    ))
                    .precondition("has_items")
                    .effect("notify_customer")
                    .transition_trigger("submit"),
            )
            .action(
                ActionDef::new("process_order")
                    .precondition("payment_valid")
                    .transition_trigger("process"),
            )
            .action(
                ActionDef::new("ship_order")
                    .precondition("inventory_fulfilled")
                    .transition_trigger("ship"),
            )
            .action(
                ActionDef::new("cancel_order")
                    .precondition("cancellation_allowed")
                    .effect("refund_payment")
                    .transition_trigger("cancel"),
            )
            .state_machine(machine);

        // Validate passes with no warnings
        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );

        // All pieces present
        assert_eq!(service.fields.len(), 5);
        assert_eq!(service.guards.len(), 4);
        assert_eq!(service.actions.len(), 4);
        assert!(service.state_machine.is_some());

        // Serde round-trip
        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn service_def_json_schema_includes_actions_guards() {
        let schema = schemars::schema_for!(ServiceDef);
        let value = schema.to_value();
        let props = value
            .get("properties")
            .expect("ServiceDef schema must have properties");
        let obj = props.as_object().unwrap();
        assert!(obj.contains_key("actions"), "missing 'actions' property");
        assert!(obj.contains_key("guards"), "missing 'guards' property");
    }

    // -- Phase 87-01 tests: relationships --

    use crate::relationship::{Cardinality, NavigationHint, RelationshipDef};

    #[test]
    fn service_def_with_relationships_builder() {
        let service = ServiceDef::new("order").relationship(
            RelationshipDef::new("customer", "customer", Cardinality::ManyToOne)
                .foreign_key("customer_id"),
        );

        assert_eq!(service.relationships.len(), 1);
        assert_eq!(service.relationships[0].name, "customer");
        assert_eq!(service.relationships[0].target, "customer");
        assert_eq!(service.relationships[0].cardinality, Cardinality::ManyToOne);
    }

    #[test]
    fn service_def_belongs_to_convenience() {
        let service = ServiceDef::new("order").belongs_to("customer", "customer");

        assert_eq!(service.relationships.len(), 1);
        let rel = &service.relationships[0];
        assert_eq!(rel.name, "customer");
        assert_eq!(rel.target, "customer");
        assert_eq!(rel.cardinality, Cardinality::ManyToOne);
        assert_eq!(rel.navigation, NavigationHint::Link);
    }

    #[test]
    fn service_def_has_many_convenience() {
        let service = ServiceDef::new("order").has_many("line_items", "order_line_item");

        assert_eq!(service.relationships.len(), 1);
        let rel = &service.relationships[0];
        assert_eq!(rel.name, "line_items");
        assert_eq!(rel.target, "order_line_item");
        assert_eq!(rel.cardinality, Cardinality::OneToMany);
        assert_eq!(rel.navigation, NavigationHint::Nested);
    }

    #[test]
    fn service_def_has_one_convenience() {
        let service = ServiceDef::new("user").has_one("profile", "user_profile");

        assert_eq!(service.relationships.len(), 1);
        let rel = &service.relationships[0];
        assert_eq!(rel.name, "profile");
        assert_eq!(rel.target, "user_profile");
        assert_eq!(rel.cardinality, Cardinality::OneToOne);
        assert_eq!(rel.navigation, NavigationHint::Inline);
    }

    #[test]
    fn service_def_belongs_to_many_convenience() {
        let service = ServiceDef::new("post").belongs_to_many("tags", "tag");

        assert_eq!(service.relationships.len(), 1);
        let rel = &service.relationships[0];
        assert_eq!(rel.name, "tags");
        assert_eq!(rel.target, "tag");
        assert_eq!(rel.cardinality, Cardinality::ManyToMany);
        assert_eq!(rel.navigation, NavigationHint::Nested);
    }

    #[test]
    fn service_def_json_omits_empty_relationships() {
        let service = ServiceDef::new("user");
        let json = serde_json::to_string(&service).unwrap();
        assert!(!json.contains("relationships"));
    }

    #[test]
    fn service_def_relationships_serde_round_trip() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .belongs_to("customer", "customer")
            .has_many("line_items", "order_line_item")
            .has_one("invoice", "invoice")
            .belongs_to_many("tags", "tag");

        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
        assert_eq!(parsed.relationships.len(), 4);
    }

    // -- Validation tests --

    #[test]
    fn validate_warns_duplicate_relationship_names() {
        let service = ServiceDef::new("order")
            .belongs_to("customer", "customer")
            .belongs_to("customer", "other_customer");

        let warnings = service.validate().unwrap();
        assert!(warnings.contains(&Warning::DuplicateRelationship("customer".into())));
    }

    #[test]
    fn validate_warns_many_to_many_with_foreign_key() {
        let service = ServiceDef::new("post").relationship(
            RelationshipDef::new("tags", "tag", Cardinality::ManyToMany).foreign_key("tag_id"),
        );

        let warnings = service.validate().unwrap();
        assert!(warnings.contains(&Warning::ManyToManyWithForeignKey {
            relationship: "tags".into()
        }));
    }

    #[test]
    fn validate_passes_with_valid_relationships() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .belongs_to("customer", "customer")
            .has_many("line_items", "order_line_item");

        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );
    }

    #[test]
    fn order_service_with_relationships_full_example() {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft").display_name("Draft"))
            .state(
                StateDef::new("submitted")
                    .display_name("Submitted")
                    .final_state(),
            )
            .transition(Transition::new("draft", "submit", "submitted").guard("has_items"));

        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Full order management with relationships")
            .read_only_field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("customer_id", DataType::Integer, FieldMeaning::ForeignKey)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .guard(GuardDef::new("has_items"))
            .action(
                ActionDef::new("submit_order")
                    .precondition("has_items")
                    .transition_trigger("submit"),
            )
            .belongs_to("customer", "customer")
            .has_many("line_items", "order_line_item")
            .has_one("invoice", "invoice")
            .state_machine(machine);

        // Validate passes with no warnings
        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );

        // All pieces present
        assert_eq!(service.fields.len(), 4);
        assert_eq!(service.guards.len(), 1);
        assert_eq!(service.actions.len(), 1);
        assert_eq!(service.relationships.len(), 3);
        assert!(service.state_machine.is_some());

        // Serde round-trip
        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    #[test]
    fn mcp_exposed_defaults_false_when_absent() {
        let json = r#"{"name":"order","fields":[]}"#;
        let parsed: ServiceDef = serde_json::from_str(json).unwrap();
        assert!(!parsed.mcp_exposed);
    }

    #[test]
    fn mcp_exposed_builder_sets_flag() {
        let s = ServiceDef::new("order").mcp_exposed(true);
        assert!(s.mcp_exposed);
    }

    #[test]
    fn tenant_and_ability_default_none_when_absent() {
        let json = r#"{"name":"order","fields":[]}"#;
        let parsed: ServiceDef = serde_json::from_str(json).unwrap();
        assert!(parsed.tenant_column.is_none());
        assert!(parsed.mcp_ability.is_none());
    }

    #[test]
    fn tenant_column_and_mcp_ability_builder_sets_values() {
        let s = ServiceDef::new("order")
            .tenant_column("tenant_id")
            .mcp_ability("view-orders");
        assert_eq!(s.tenant_column, Some("tenant_id".to_string()));
        assert_eq!(s.mcp_ability, Some("view-orders".to_string()));
    }

    #[test]
    fn tenant_column_and_mcp_ability_skip_serializing_when_none() {
        let s = ServiceDef::new("order").field(
            "id",
            crate::field::DataType::Integer,
            crate::field::FieldMeaning::Identifier,
        );
        let json = serde_json::to_string(&s).unwrap();
        assert!(
            !json.contains("tenant_column"),
            "tenant_column should be absent when None"
        );
        assert!(
            !json.contains("mcp_ability"),
            "mcp_ability should be absent when None"
        );
    }

    #[test]
    fn service_def_json_schema_includes_relationships() {
        let schema = schemars::schema_for!(ServiceDef);
        let value = schema.to_value();
        let props = value
            .get("properties")
            .expect("ServiceDef schema must have properties");
        let obj = props.as_object().unwrap();
        assert!(
            obj.contains_key("relationships"),
            "missing 'relationships' property"
        );
    }

    // -- Phase 88-01 tests: intent hints --

    use crate::intent::{Intent, IntentHint};

    #[test]
    fn service_def_new_has_empty_intent_hints() {
        let service = ServiceDef::new("order");
        assert!(service.intent_hints.is_empty());
    }

    #[test]
    fn service_def_intent_hint_builder() {
        let service = ServiceDef::new("order")
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Exclude(Intent::Process));

        assert_eq!(service.intent_hints.len(), 2);
        assert_eq!(service.intent_hints[0], IntentHint::Primary(Intent::Browse));
        assert_eq!(
            service.intent_hints[1],
            IntentHint::Exclude(Intent::Process)
        );
    }

    #[test]
    fn service_def_json_omits_empty_intent_hints() {
        let service = ServiceDef::new("user");
        let json = serde_json::to_string(&service).unwrap();
        assert!(!json.contains("intent_hints"));
    }

    #[test]
    fn service_def_intent_hints_serde_round_trip() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Exclude(Intent::Collect));

        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
        assert_eq!(parsed.intent_hints.len(), 2);
    }

    #[test]
    fn validate_passes_with_valid_intent_hints() {
        let service = ServiceDef::new("order")
            .field("id", DataType::Integer, FieldMeaning::Identifier)
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Exclude(Intent::Collect));

        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );
    }

    #[test]
    fn validate_warns_conflicting_intent_hints() {
        let service = ServiceDef::new("order")
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Exclude(Intent::Browse));

        let warnings = service.validate().unwrap();
        assert!(warnings.contains(&Warning::ConflictingIntentHints {
            intent: "browse".into()
        }));
    }

    #[test]
    fn validate_warns_multiple_primary_intent_hints() {
        let service = ServiceDef::new("order")
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Primary(Intent::Focus));

        let warnings = service.validate().unwrap();
        assert!(warnings.contains(&Warning::MultiplePrimaryIntentHints));
    }

    #[test]
    fn validate_warns_both_conflicting_and_multiple_primary() {
        let service = ServiceDef::new("order")
            .intent_hint(IntentHint::Primary(Intent::Browse))
            .intent_hint(IntentHint::Primary(Intent::Focus))
            .intent_hint(IntentHint::Exclude(Intent::Browse));

        let warnings = service.validate().unwrap();
        assert!(warnings.contains(&Warning::ConflictingIntentHints {
            intent: "browse".into()
        }));
        assert!(warnings.contains(&Warning::MultiplePrimaryIntentHints));
    }

    #[test]
    fn validate_no_warning_for_single_primary() {
        let service = ServiceDef::new("order").intent_hint(IntentHint::Primary(Intent::Browse));

        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );
    }

    #[test]
    fn service_def_json_schema_includes_intent_hints() {
        let schema = schemars::schema_for!(ServiceDef);
        let value = schema.to_value();
        let props = value
            .get("properties")
            .expect("ServiceDef schema must have properties");
        let obj = props.as_object().unwrap();
        assert!(
            obj.contains_key("intent_hints"),
            "missing 'intent_hints' property"
        );
    }

    // -- Phase 88-02 tests: full integration with intent hints --

    #[test]
    fn full_service_with_intent_hints() {
        let machine = StateMachine::new("order_lifecycle")
            .initial("draft")
            .state(StateDef::new("draft").display_name("Draft"))
            .state(
                StateDef::new("submitted")
                    .display_name("Submitted")
                    .on_enter(vec!["validate_inventory"]),
            )
            .state(
                StateDef::new("shipped")
                    .display_name("Shipped")
                    .final_state(),
            )
            .state(
                StateDef::new("cancelled")
                    .display_name("Cancelled")
                    .final_state(),
            )
            .transition(Transition::new("draft", "submit", "submitted").guard("has_items"))
            .transition(
                Transition::new("submitted", "ship", "shipped").guard("inventory_fulfilled"),
            )
            .transition(
                Transition::new("draft", "cancel", "cancelled").guard("cancellation_allowed"),
            )
            .transition(
                Transition::new("submitted", "cancel", "cancelled").guard("cancellation_allowed"),
            );

        let service = ServiceDef::new("order")
            .display_name("Order")
            .description("Full order management with all features including intent hints")
            .read_only_field("id", DataType::Integer, FieldMeaning::Identifier)
            .field("customer_id", DataType::Integer, FieldMeaning::ForeignKey)
            .field("total", DataType::Float, FieldMeaning::Money)
            .field("status", DataType::String, FieldMeaning::Status)
            .read_only_field("created_at", DataType::DateTime, FieldMeaning::CreatedAt)
            .guard(GuardDef::new("has_items"))
            .guard(GuardDef::new("inventory_fulfilled"))
            .guard(GuardDef::new("cancellation_allowed"))
            .action(
                ActionDef::new("submit_order")
                    .precondition("has_items")
                    .transition_trigger("submit"),
            )
            .action(
                ActionDef::new("ship_order")
                    .precondition("inventory_fulfilled")
                    .transition_trigger("ship"),
            )
            .action(
                ActionDef::new("cancel_order")
                    .precondition("cancellation_allowed")
                    .transition_trigger("cancel"),
            )
            .belongs_to("customer", "customer")
            .has_many("line_items", "order_line_item")
            .has_one("invoice", "invoice")
            .intent_hint(IntentHint::Primary(Intent::Process))
            .intent_hint(IntentHint::Exclude(Intent::Summarize))
            .state_machine(machine);

        // Validate passes with no warnings
        let warnings = service.validate().unwrap();
        assert!(
            warnings.is_empty(),
            "expected no warnings, got: {warnings:?}"
        );

        // All pieces present
        assert_eq!(service.fields.len(), 5);
        assert_eq!(service.guards.len(), 3);
        assert_eq!(service.actions.len(), 3);
        assert_eq!(service.relationships.len(), 3);
        assert_eq!(service.intent_hints.len(), 2);
        assert!(service.state_machine.is_some());

        // Intent hints correct
        assert_eq!(
            service.intent_hints[0],
            IntentHint::Primary(Intent::Process)
        );
        assert_eq!(
            service.intent_hints[1],
            IntentHint::Exclude(Intent::Summarize)
        );

        // Serde round-trip
        let json = serde_json::to_string_pretty(&service).unwrap();
        let parsed: ServiceDef = serde_json::from_str(&json).unwrap();
        assert_eq!(service, parsed);
    }

    fn order_meta() -> ModelMetadata {
        ModelMetadata {
            name: "order".to_string(),
            display_name: None,
            table: Some("orders".to_string()),
            fields: vec![
                FieldMetadata {
                    name: "id".into(),
                    column_type: "i32".into(),
                    is_primary_key: true,
                    is_nullable: false,
                },
                FieldMetadata {
                    name: "total".into(),
                    column_type: "f64".into(),
                    is_primary_key: false,
                    is_nullable: false,
                },
                FieldMetadata {
                    name: "status".into(),
                    column_type: "String".into(),
                    is_primary_key: false,
                    is_nullable: false,
                },
                FieldMetadata {
                    name: "notes".into(),
                    column_type: "Option<String>".into(),
                    is_primary_key: false,
                    is_nullable: true,
                },
                FieldMetadata {
                    name: "created_at".into(),
                    column_type: "DateTime<Utc>".into(),
                    is_primary_key: false,
                    is_nullable: false,
                },
            ],
        }
    }

    #[test]
    fn from_model_basic() {
        let meta = order_meta();
        let def = ServiceDef::from_model(&meta);
        assert_eq!(def.name, "order");
        assert_eq!(def.display_name.as_deref(), Some("Order"));
        assert_eq!(def.fields.len(), 5);
    }

    #[test]
    fn from_model_system_fields_read_only() {
        let meta = order_meta();
        let def = ServiceDef::from_model(&meta);
        let id = def.fields.iter().find(|f| f.name == "id").unwrap();
        assert!(!id.writable, "id must be read-only");
        let created_at = def.fields.iter().find(|f| f.name == "created_at").unwrap();
        assert!(!created_at.writable, "created_at must be read-only");
        let total = def.fields.iter().find(|f| f.name == "total").unwrap();
        assert!(total.writable, "total must be writable");
    }

    #[test]
    fn from_model_nullable_to_required() {
        let meta = order_meta();
        let def = ServiceDef::from_model(&meta);
        let notes = def.fields.iter().find(|f| f.name == "notes").unwrap();
        assert!(!notes.required, "nullable field must have required: false");
        let total = def.fields.iter().find(|f| f.name == "total").unwrap();
        assert!(
            total.required,
            "non-nullable field must have required: true"
        );
    }

    #[test]
    fn from_model_display_name_override() {
        let meta = ModelMetadata {
            name: "order".to_string(),
            display_name: Some("Custom Name".to_string()),
            table: None,
            fields: vec![],
        };
        let def = ServiceDef::from_model(&meta);
        assert_eq!(def.display_name.as_deref(), Some("Custom Name"));
    }

    #[test]
    fn from_model_snake_to_title() {
        let meta = ModelMetadata {
            name: "order_item".to_string(),
            display_name: None,
            table: None,
            fields: vec![],
        };
        let def = ServiceDef::from_model(&meta);
        assert_eq!(def.display_name.as_deref(), Some("Order Item"));
    }

    #[test]
    fn round_trip_model_to_intents() {
        use crate::derive::derive_intents;

        let meta = order_meta();
        let def = ServiceDef::from_model(&meta);
        let intents = derive_intents(&def);
        assert!(
            !intents.is_empty(),
            "derive_intents must produce at least one intent score"
        );
    }

    // ── Track A: CRUD data-surface declaration ──────────────────────────────

    #[test]
    fn crud_flags_default_false() {
        let def = ServiceDef::new("order");
        assert!(!def.creatable);
        assert!(!def.updatable);
        assert!(!def.deletable);
        assert!(def.mcp_write_ability.is_none());
        assert!(def.table.is_none());
        assert!(def.soft_delete_column.is_none());
    }

    #[test]
    fn crud_builders_set_flags() {
        let def = ServiceDef::new("order")
            .creatable(true)
            .updatable(true)
            .deletable(true);
        assert!(def.creatable);
        assert!(def.updatable);
        assert!(def.deletable);
    }

    #[test]
    fn write_surface_builders_set_fields() {
        let def = ServiceDef::new("order")
            .mcp_write_ability("manage-orders")
            .table("orders")
            .soft_delete_column("deleted_at");
        assert_eq!(def.mcp_write_ability.as_deref(), Some("manage-orders"));
        assert_eq!(def.table.as_deref(), Some("orders"));
        assert_eq!(def.soft_delete_column.as_deref(), Some("deleted_at"));
    }

    #[test]
    fn validate_rejects_creatable_without_write_ability() {
        let def = ServiceDef::new("order").creatable(true);
        let err = def.validate().unwrap_err();
        assert!(matches!(err, crate::Error::Validation(_)));
        assert!(
            err.to_string().contains("mcp_write_ability"),
            "error message must mention 'mcp_write_ability'; got: {err}"
        );
    }

    #[test]
    fn validate_rejects_updatable_without_write_ability() {
        let def = ServiceDef::new("order").updatable(true);
        let err = def.validate().unwrap_err();
        assert!(matches!(err, crate::Error::Validation(_)));
        assert!(
            err.to_string().contains("mcp_write_ability"),
            "error message must mention 'mcp_write_ability'; got: {err}"
        );
    }

    #[test]
    fn validate_rejects_deletable_without_write_ability() {
        let def = ServiceDef::new("order").deletable(true);
        let err = def.validate().unwrap_err();
        assert!(matches!(err, crate::Error::Validation(_)));
        assert!(
            err.to_string().contains("mcp_write_ability"),
            "error message must mention 'mcp_write_ability'; got: {err}"
        );
    }

    #[test]
    fn validate_accepts_crud_with_write_ability() {
        let def = ServiceDef::new("order")
            .creatable(true)
            .updatable(true)
            .deletable(true)
            .mcp_write_ability("manage-orders");
        assert!(def.validate().is_ok());
    }

    #[test]
    fn validate_allows_read_only_without_write_ability() {
        // A projection that enables no CRUD verb must not require a write ability.
        let def = ServiceDef::new("order");
        assert!(def.validate().is_ok());
    }

    #[test]
    fn serde_round_trip_includes_crud_surface() {
        let def = ServiceDef::new("order")
            .creatable(true)
            .updatable(true)
            .deletable(true)
            .mcp_write_ability("manage-orders")
            .table("orders")
            .soft_delete_column("deleted_at");
        let json = serde_json::to_string(&def).unwrap();
        let back: ServiceDef = serde_json::from_str(&json).unwrap();
        assert!(back.creatable && back.updatable && back.deletable);
        assert_eq!(back.mcp_write_ability.as_deref(), Some("manage-orders"));
        assert_eq!(back.table.as_deref(), Some("orders"));
        assert_eq!(back.soft_delete_column.as_deref(), Some("deleted_at"));
    }

    // ── Phase 239: resolver accessors ───────────────────────────────────────

    #[test]
    fn resolved_table_default() {
        assert_eq!(ServiceDef::new("order").resolved_table(), "orders");
    }

    #[test]
    fn resolved_table_default_lowercases() {
        assert_eq!(ServiceDef::new("Order").resolved_table(), "orders");
    }

    #[test]
    fn resolved_table_explicit_override() {
        assert_eq!(
            ServiceDef::new("order")
                .table("purchase_orders")
                .resolved_table(),
            "purchase_orders"
        );
    }

    #[test]
    fn resolved_soft_delete_column_default() {
        assert_eq!(
            ServiceDef::new("order").resolved_soft_delete_column(),
            "deleted_at"
        );
    }

    #[test]
    fn resolved_soft_delete_column_explicit_override() {
        assert_eq!(
            ServiceDef::new("order")
                .soft_delete_column("removed_at")
                .resolved_soft_delete_column(),
            "removed_at"
        );
    }

    // ── Phase 239: is_server_injected_field ─────────────────────────────────

    fn mk_field(name: &str, meaning: FieldMeaning) -> FieldDef {
        FieldDef {
            name: name.to_string(),
            data_type: DataType::String,
            meaning,
            required: false,
            is_list: false,
            readable: true,
            writable: true,
            render_hint: None,
        }
    }

    #[test]
    fn server_injected_identifier() {
        assert!(ServiceDef::new("order")
            .is_server_injected_field(&mk_field("id", FieldMeaning::Identifier)));
    }

    #[test]
    fn server_injected_created_at() {
        assert!(ServiceDef::new("order")
            .is_server_injected_field(&mk_field("created_at", FieldMeaning::CreatedAt)));
    }

    #[test]
    fn server_injected_tenant_column() {
        let svc = ServiceDef::new("order").tenant_column("tenant_id");
        assert!(svc.is_server_injected_field(&mk_field("tenant_id", FieldMeaning::ForeignKey)));
    }

    #[test]
    fn server_injected_false_for_regular_field() {
        let svc = ServiceDef::new("order").tenant_column("tenant_id");
        assert!(!svc.is_server_injected_field(&mk_field("customer_name", FieldMeaning::EntityName)));
    }

    // ── Phase 240: is_write_excluded_field ──────────────────────────────────

    fn mk_field_typed(name: &str, dt: DataType, meaning: FieldMeaning, is_list: bool) -> FieldDef {
        FieldDef {
            name: name.to_string(),
            data_type: dt,
            meaning,
            required: true,
            is_list,
            readable: true,
            writable: true,
            render_hint: None,
        }
    }

    #[test]
    fn is_write_excluded_field_gates() {
        use crate::state::{StateDef as SD, StateMachine as SM, Transition as TR};

        let minimal_sm = SM::new("lifecycle")
            .initial("a")
            .state(SD::new("a"))
            .state(SD::new("b").final_state())
            .transition(TR::new("a", "go", "b"));

        // Cases: (field_name, data_type, meaning, is_list, sm_present, expected_excluded)
        struct Case {
            name: &'static str,
            dt: DataType,
            meaning: FieldMeaning,
            is_list: bool,
            sm_present: bool,
            expected: bool,
        }

        let cases = [
            // Gate A — Identifier (server-injected)
            Case {
                name: "id",
                dt: DataType::Integer,
                meaning: FieldMeaning::Identifier,
                is_list: false,
                sm_present: false,
                expected: true,
            },
            // Gate A — CreatedAt (server-injected)
            Case {
                name: "created_at",
                dt: DataType::DateTime,
                meaning: FieldMeaning::CreatedAt,
                is_list: false,
                sm_present: false,
                expected: true,
            },
            // Gate A — tenant column (server-injected); tested via tenant_column() below
            // Gate B — UpdatedAt
            Case {
                name: "updated_at",
                dt: DataType::DateTime,
                meaning: FieldMeaning::UpdatedAt,
                is_list: false,
                sm_present: false,
                expected: true,
            },
            // Gate C — Sensitive
            Case {
                name: "password",
                dt: DataType::String,
                meaning: FieldMeaning::Sensitive,
                is_list: false,
                sm_present: false,
                expected: true,
            },
            // Gate D — list field (any meaning)
            Case {
                name: "tags",
                dt: DataType::String,
                meaning: FieldMeaning::Category,
                is_list: true,
                sm_present: false,
                expected: true,
            },
            // Gate E — Status excluded when SM present
            Case {
                name: "status",
                dt: DataType::String,
                meaning: FieldMeaning::Status,
                is_list: false,
                sm_present: true,
                expected: true,
            },
            // Gate E — Status NOT excluded when no SM
            Case {
                name: "status",
                dt: DataType::String,
                meaning: FieldMeaning::Status,
                is_list: false,
                sm_present: false,
                expected: false,
            },
            // Ordinary writable field — never excluded (both SM flags)
            Case {
                name: "notes",
                dt: DataType::String,
                meaning: FieldMeaning::FreeText,
                is_list: false,
                sm_present: false,
                expected: false,
            },
            Case {
                name: "notes",
                dt: DataType::String,
                meaning: FieldMeaning::FreeText,
                is_list: false,
                sm_present: true,
                expected: false,
            },
        ];

        for c in &cases {
            let field = mk_field_typed(c.name, c.dt, c.meaning.clone(), c.is_list);
            let svc = if c.sm_present {
                ServiceDef::new("order").state_machine(minimal_sm.clone())
            } else {
                ServiceDef::new("order")
            };
            let got = svc.is_write_excluded_field(&field, c.sm_present);
            assert_eq!(
                got, c.expected,
                "field '{}' (meaning={:?}, is_list={}, sm_present={}): expected excluded={}, got={}",
                c.name, c.meaning, c.is_list, c.sm_present, c.expected, got
            );
        }

        // Gate A — tenant column case (requires tenant_column set on service)
        let tenant_field =
            mk_field_typed("org_id", DataType::Integer, FieldMeaning::ForeignKey, false);
        let svc_with_tenant = ServiceDef::new("order").tenant_column("org_id");
        assert!(
            svc_with_tenant.is_write_excluded_field(&tenant_field, false),
            "tenant column must be write-excluded regardless of SM flag"
        );
    }

    /// Gate F: a field with `writable: false` must be excluded from write input schemas.
    ///
    /// Added for Phase 243.1 — derived/computed fields (like `order.total`) are
    /// declared via `.read_only_field()` and must never appear in create_/update_ inputs.
    #[test]
    fn is_write_excluded_field_excludes_read_only() {
        let svc = ServiceDef::new("order")
            .field("customer_name", DataType::String, FieldMeaning::EntityName)
            .read_only_field("total", DataType::Float, FieldMeaning::Money);

        let writable = &svc.fields[0];
        let read_only = &svc.fields[1];

        // Writable data field is NOT excluded.
        assert!(!svc.is_write_excluded_field(writable, false));
        // Read-only (writable: false) field IS excluded from write input.
        assert!(svc.is_write_excluded_field(read_only, false));
    }

    /// CRUD-07 boot-time test: validate() must reject any projection that enables a write
    /// verb without declaring mcp_write_ability. The rule ships at service.rs:502-510
    /// (commit 5cb17d60). This test pins the fail-fast guarantee against regression.
    #[test]
    fn validate_rejects_crud_verb_without_write_ability() {
        // creatable with no mcp_write_ability → Err
        let svc = ServiceDef::new("order")
            .mcp_exposed(true)
            .creatable(true)
            .field("id", DataType::Integer, FieldMeaning::Identifier);
        let err = svc.validate().unwrap_err();
        assert!(matches!(err, crate::Error::Validation(_)));
        assert!(err.to_string().contains("mcp_write_ability"));

        // updatable with no mcp_write_ability → Err
        let svc_u = ServiceDef::new("order")
            .mcp_exposed(true)
            .updatable(true)
            .field("id", DataType::Integer, FieldMeaning::Identifier);
        assert!(svc_u.validate().is_err());

        // deletable with no mcp_write_ability → Err
        let svc_d = ServiceDef::new("order")
            .mcp_exposed(true)
            .deletable(true)
            .field("id", DataType::Integer, FieldMeaning::Identifier);
        assert!(svc_d.validate().is_err());

        // With mcp_write_ability → Ok
        let svc_ok = ServiceDef::new("order")
            .mcp_exposed(true)
            .creatable(true)
            .mcp_write_ability("manage-orders")
            .field("id", DataType::Integer, FieldMeaning::Identifier);
        assert!(svc_ok.validate().is_ok());
    }
}