feff10 0.2.1

Rust wrapper for FEFF10 X-ray absorption spectroscopy calculations
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
use std::fs;
use std::path::{Path, PathBuf};
use std::sync::Mutex;
use std::time::{Duration, Instant};

use crate::config::{FeffConfig, StageIsolation};
use crate::error::{Error, PipelineError};
use crate::output::{FeffOutputs, FeffTable, PathsDat};
use crate::stage::Stage;

static FEFF_EXEC_LOCK: Mutex<()> = Mutex::new(());

/// Result from running a single stage.
#[derive(Debug)]
pub struct StageResult {
    pub stage: Stage,
    pub duration: Duration,
}

/// Result from running the full pipeline.
#[derive(Debug)]
pub struct PipelineResult {
    pub stages: Vec<StageResult>,
    pub work_dir: PathBuf,
}

impl PipelineResult {
    /// Discover all FEFF `*.dat` outputs in the work directory.
    pub fn outputs(&self) -> Result<FeffOutputs, Error> {
        FeffOutputs::discover(&self.work_dir)
    }

    /// Read `xmu.dat` from the work directory (permissive parsing).
    pub fn read_xmu(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file(self.work_dir.join("xmu.dat"))
    }

    /// Read `xmu.dat` from the work directory (strict parsing).
    pub fn read_xmu_strict(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file_strict(self.work_dir.join("xmu.dat"))
    }

    /// Read `chi.dat` from the work directory (permissive parsing).
    pub fn read_chi(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file(self.work_dir.join("chi.dat"))
    }

    /// Read `chi.dat` from the work directory (strict parsing).
    pub fn read_chi_strict(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file_strict(self.work_dir.join("chi.dat"))
    }

    /// Read `eels.dat` from the work directory (permissive parsing).
    pub fn read_eels(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file(self.work_dir.join("eels.dat"))
    }

    /// Read `eels.dat` from the work directory (strict parsing).
    pub fn read_eels_strict(&self) -> Result<FeffTable, Error> {
        FeffTable::from_file_strict(self.work_dir.join("eels.dat"))
    }

    /// Read `ldosNN.dat` from the work directory (permissive parsing).
    pub fn read_ldos(&self, index: u32) -> Result<FeffTable, Error> {
        FeffTable::from_file(self.work_dir.join(format!("ldos{index:02}.dat")))
    }

    /// Read `ldosNN.dat` from the work directory (strict parsing).
    pub fn read_ldos_strict(&self, index: u32) -> Result<FeffTable, Error> {
        FeffTable::from_file_strict(self.work_dir.join(format!("ldos{index:02}.dat")))
    }

    /// Read `paths.dat` from the work directory.
    pub fn read_paths(&self) -> Result<PathsDat, Error> {
        PathsDat::from_file(self.work_dir.join("paths.dat"))
    }
}

/// Progress information for a stage.
#[derive(Debug)]
pub enum StageProgress {
    Starting,
    Finished { duration: Duration },
}

/// Orchestrates FEFF executable pipeline.
pub struct FeffPipeline {
    config: FeffConfig,
}

impl FeffPipeline {
    pub fn new(config: FeffConfig) -> Self {
        Self { config }
    }

    /// Run the full pipeline.
    pub fn run(&self) -> Result<PipelineResult, Error> {
        self.run_with_progress(|_, _| {})
    }

    /// Run with a progress callback invoked before/after each stage.
    pub fn run_with_progress<F>(&self, mut callback: F) -> Result<PipelineResult, Error>
    where
        F: FnMut(Stage, StageProgress),
    {
        // Ensure working directory exists
        fs::create_dir_all(&self.config.work_dir)?;

        // Write feff.inp
        let inp_path = self.config.work_dir.join("feff.inp");
        let mut file = fs::File::create(&inp_path)?;
        self.config.input.write_to(&mut file)?;

        let mut stage_results = Vec::new();

        // Clear any stale .feff.error from a previous run
        let feff_error_path = self.config.work_dir.join(".feff.error");
        let _ = fs::remove_file(&feff_error_path);

        // Recover from poison so one failed run does not permanently disable FEFF execution.
        let _exec_lock = match FEFF_EXEC_LOCK.lock() {
            Ok(lock) => lock,
            Err(poisoned) => poisoned.into_inner(),
        };

        for &stage in &self.config.stages {
            callback(stage, StageProgress::Starting);

            let start = Instant::now();
            run_stage_isolated(
                stage,
                &self.config.work_dir,
                self.config.stage_timeout,
                self.config.stage_isolation,
            )?;
            let duration = start.elapsed();

            callback(stage, StageProgress::Finished { duration });

            // Check for FEFF error (written to .feff.error by the Fortran error module)
            let feff_error = fs::read_to_string(&feff_error_path)
                .ok()
                .and_then(|s| if s.trim().is_empty() { None } else { Some(s) });

            if feff_error.is_some() {
                return Err(Error::Pipeline(PipelineError {
                    stage: stage.executable_name().to_string(),
                    exit_code: None,
                    stderr: String::new(),
                    feff_error,
                }));
            }

            stage_results.push(StageResult { stage, duration });
        }

        Ok(PipelineResult {
            stages: stage_results,
            work_dir: self.config.work_dir.clone(),
        })
    }
}

/// Run a single FEFF stage in a forked child process (Unix) or in-process (Windows).
///
/// On Unix, each stage runs in its own process via `fork()` to isolate Fortran
/// module state, I/O unit state, and memory allocations — matching the original
/// FEFF behavior where each stage was a separate executable.
///
/// On Windows, the stage runs directly in-process since `fork()` is unavailable.
/// This means Fortran `stop` on error will terminate the host process, and global
/// state is not fully isolated between stages. In practice this is fine because
/// stages communicate via files and `stop` is only called on error paths.
#[cfg(unix)]
fn run_stage_isolated(
    stage: Stage,
    work_dir: &std::path::Path,
    timeout: Option<Duration>,
    isolation: StageIsolation,
) -> Result<(), Error> {
    match isolation {
        StageIsolation::Fork => run_stage_forked(stage, work_dir, timeout),
        StageIsolation::Worker => run_stage_worker(stage, work_dir, timeout),
        StageIsolation::InProcess => run_stage_in_process(stage, work_dir),
        StageIsolation::Auto => {
            if !fork_unsafe_host() {
                run_stage_forked(stage, work_dir, timeout)
            } else if crate::worker::installed() {
                run_stage_worker(stage, work_dir, timeout)
            } else {
                Err(Error::Pipeline(PipelineError {
                    stage: stage.executable_name().to_string(),
                    exit_code: None,
                    stderr: "this process is fork-unsafe (GUI host): call \
                             feff10::worker::init() at the top of main(), or run the \
                             pipeline from a separate process"
                        .to_string(),
                    feff_error: None,
                }))
            }
        }
    }
}

/// Re-exec the current executable as a single-stage worker (fork+exec).
/// The host must have called [`crate::worker::init`] in `main()`.
fn run_stage_worker(
    stage: Stage,
    work_dir: &std::path::Path,
    timeout: Option<Duration>,
) -> Result<(), Error> {
    let exe = std::env::current_exe()?;
    let mut child = std::process::Command::new(exe)
        .env(crate::worker::ENV_STAGE, stage.executable_name())
        .env(crate::worker::ENV_DIR, work_dir)
        .spawn()?;
    let start = Instant::now();
    loop {
        match child.try_wait()? {
            Some(status) => {
                if status.success() {
                    return Ok(());
                }
                return Err(Error::Pipeline(PipelineError {
                    stage: stage.executable_name().to_string(),
                    exit_code: status.code(),
                    stderr: format!("worker exited with {status}"),
                    feff_error: None,
                }));
            }
            None => {
                if let Some(t) = timeout
                    && start.elapsed() > t
                {
                    let _ = child.kill();
                    let _ = child.wait();
                    return Err(Error::Pipeline(PipelineError {
                        stage: stage.executable_name().to_string(),
                        exit_code: None,
                        stderr: format!("timed out after {}s", t.as_secs()),
                        feff_error: None,
                    }));
                }
                std::thread::sleep(Duration::from_millis(50));
            }
        }
    }
}

/// `fork()` without `exec()` is not viable in every process. On macOS, a
/// process that has initialized AppKit/Metal (any GUI app embedding this
/// library) holds Objective-C runtime and dispatch state that makes the
/// forked child abort before the Fortran stage can run. Detect that by
/// scanning the loaded images.
#[cfg(target_os = "macos")]
fn fork_unsafe_host() -> bool {
    unsafe extern "C" {
        fn _dyld_image_count() -> u32;
        fn _dyld_get_image_name(image_index: u32) -> *const std::os::raw::c_char;
    }
    unsafe {
        let count = _dyld_image_count();
        for i in 0..count {
            let name = _dyld_get_image_name(i);
            if name.is_null() {
                continue;
            }
            let name = std::ffi::CStr::from_ptr(name).to_bytes();
            for marker in [
                &b"AppKit.framework"[..],
                &b"Metal.framework"[..],
                &b"UIKit.framework"[..],
            ] {
                if name.windows(marker.len()).any(|w| w == marker) {
                    return true;
                }
            }
        }
    }
    false
}

#[cfg(all(unix, not(target_os = "macos")))]
fn fork_unsafe_host() -> bool {
    false
}

/// Run a stage on a dedicated big-stack thread in this process (the
/// Windows behavior, also used for fork-unsafe Unix hosts). Stage state is
/// not isolated and `stop` on Fortran error paths terminates the host, but
/// stages communicate via files so sequential runs behave like the forked
/// path in practice.
fn run_stage_in_process(stage: Stage, work_dir: &std::path::Path) -> Result<(), Error> {
    let _cwd_guard = CwdGuard::enter(work_dir)?;
    // FEFF stages assume the generous main-thread stack of a standalone
    // executable; give them one explicitly.
    let handle = std::thread::Builder::new()
        .name(format!("feff-{}", stage.executable_name()))
        .stack_size(64 * 1024 * 1024)
        .spawn(move || unsafe { stage.call_ffi() })
        .map_err(Error::Io)?;
    handle.join().map_err(|_| {
        Error::Pipeline(PipelineError {
            stage: stage.executable_name().to_string(),
            exit_code: None,
            stderr: "stage panicked".to_string(),
            feff_error: None,
        })
    })
}

#[cfg(unix)]
fn run_stage_forked(
    stage: Stage,
    work_dir: &std::path::Path,
    timeout: Option<Duration>,
) -> Result<(), Error> {
    let _cwd_guard = CwdGuard::enter(work_dir)?;

    let pid = unsafe { libc::fork() };

    match pid {
        -1 => Err(Error::Io(std::io::Error::last_os_error())),
        0 => {
            // ── Child process ──
            // Call the Fortran subroutine. If it returns normally, exit(0).
            // If the Fortran code calls `stop`, the process terminates directly.
            unsafe { stage.call_ffi() };
            unsafe { libc::_exit(0) };
        }
        child_pid => {
            if timeout.is_some() {
                wait_with_timeout(stage, child_pid, timeout)
            } else {
                wait_blocking(stage, child_pid)
            }
        }
    }
}

/// Blocking wait (original behavior, no polling overhead).
#[cfg(unix)]
fn wait_blocking(stage: Stage, child_pid: libc::pid_t) -> Result<(), Error> {
    let mut status: libc::c_int = 0;
    loop {
        let ret = unsafe { libc::waitpid(child_pid, &mut status, 0) };
        if ret == -1 {
            let err = std::io::Error::last_os_error();
            if err.raw_os_error() == Some(libc::EINTR) {
                continue;
            }
            return Err(Error::Io(err));
        }
        break;
    }
    check_child_status(stage, status)
}

/// Non-blocking wait with timeout via WNOHANG polling.
#[cfg(unix)]
fn wait_with_timeout(
    stage: Stage,
    child_pid: libc::pid_t,
    timeout: Option<Duration>,
) -> Result<(), Error> {
    let start = Instant::now();
    loop {
        let mut status: libc::c_int = 0;
        let ret = unsafe { libc::waitpid(child_pid, &mut status, libc::WNOHANG) };

        if ret == -1 {
            let err = std::io::Error::last_os_error();
            if err.raw_os_error() == Some(libc::EINTR) {
                continue;
            }
            return Err(Error::Io(err));
        }

        if ret == child_pid {
            return check_child_status(stage, status);
        }

        // ret == 0: child still running
        if let Some(t) = timeout
            && start.elapsed() > t
        {
            unsafe { libc::kill(child_pid, libc::SIGKILL) };
            unsafe { libc::waitpid(child_pid, std::ptr::null_mut(), 0) };
            return Err(Error::Pipeline(PipelineError {
                stage: stage.executable_name().to_string(),
                exit_code: None,
                stderr: format!("timed out after {}s", t.as_secs()),
                feff_error: None,
            }));
        }

        std::thread::sleep(Duration::from_millis(50));
    }
}

#[cfg(unix)]
fn check_child_status(stage: Stage, status: libc::c_int) -> Result<(), Error> {
    if libc::WIFEXITED(status) {
        let exit_code = libc::WEXITSTATUS(status);
        if exit_code == 0 {
            Ok(())
        } else {
            Err(Error::Pipeline(PipelineError {
                stage: stage.executable_name().to_string(),
                exit_code: Some(exit_code),
                stderr: String::new(),
                feff_error: None,
            }))
        }
    } else if libc::WIFSIGNALED(status) {
        let signal = libc::WTERMSIG(status);
        Err(Error::Pipeline(PipelineError {
            stage: stage.executable_name().to_string(),
            exit_code: None,
            stderr: format!("killed by signal {signal}"),
            feff_error: None,
        }))
    } else {
        Err(Error::Pipeline(PipelineError {
            stage: stage.executable_name().to_string(),
            exit_code: None,
            stderr: "unknown child status".to_string(),
            feff_error: None,
        }))
    }
}

#[cfg(not(unix))]
fn run_stage_isolated(
    stage: Stage,
    work_dir: &std::path::Path,
    timeout: Option<Duration>,
    isolation: StageIsolation,
) -> Result<(), Error> {
    match isolation {
        StageIsolation::Worker => run_stage_worker(stage, work_dir, timeout),
        // Worker processes also isolate Fortran module state between
        // stages; prefer them when the host installed the hook.
        StageIsolation::Auto if crate::worker::installed() => {
            run_stage_worker(stage, work_dir, timeout)
        }
        _ => run_stage_in_process(stage, work_dir),
    }
}

struct CwdGuard {
    old_dir: PathBuf,
}

impl CwdGuard {
    fn enter(dir: &Path) -> Result<Self, Error> {
        let old_dir = std::env::current_dir()?;
        std::env::set_current_dir(dir)?;
        Ok(Self { old_dir })
    }
}

impl Drop for CwdGuard {
    fn drop(&mut self) {
        let _ = std::env::set_current_dir(&self.old_dir);
    }
}

#[cfg(test)]
mod tests {
    use super::{CwdGuard, PipelineResult};

    #[test]
    fn cwd_guard_restores_previous_directory() {
        let original = std::env::current_dir().unwrap().canonicalize().unwrap();
        let tmp = tempfile::tempdir().unwrap();
        let tmp_canon = tmp.path().canonicalize().unwrap();

        {
            let _guard = CwdGuard::enter(tmp.path()).unwrap();
            let now = std::env::current_dir().unwrap().canonicalize().unwrap();
            assert_eq!(now, tmp_canon);
        }

        let restored = std::env::current_dir().unwrap().canonicalize().unwrap();
        assert_eq!(restored, original);
    }

    #[test]
    fn pipeline_result_reads_common_outputs() {
        let tmp = tempfile::tempdir().unwrap();
        std::fs::write(tmp.path().join("xmu.dat"), "# header\n1.0 2.0 3.0 4.0\n").unwrap();
        std::fs::write(
            tmp.path().join("paths.dat"),
            "PATH  Rmax= 5.5\n\
             1 1 1.0  index, nleg, degeneracy, r= 1.0\n\
             x y z ipot label rleg beta eta\n\
             0.0 0.0 0.0 0 'A' 1.0 180.0 0.0\n",
        )
        .unwrap();

        let result = PipelineResult {
            stages: vec![],
            work_dir: tmp.path().to_path_buf(),
        };

        let xmu = result.read_xmu().unwrap();
        assert_eq!(xmu.nrows(), 1);
        assert_eq!(xmu.ncols(), 4);

        let paths = result.read_paths().unwrap();
        assert_eq!(paths.len(), 1);

        let outputs = result.outputs().unwrap();
        assert!(outputs.file("xmu.dat").is_some());
        assert!(outputs.file("paths.dat").is_some());
    }
}