feagi-structures 0.0.38

The most core library, defines the basic data types used by FEAGI, as well as some processors to modify them
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
// Copyright 2025 Neuraville Inc.
// SPDX-License-Identifier: Apache-2.0

/*!
First-class genome classifier assembly.

Classifiers are stored under the top-level genome key `classifiers`, parallel
to `brain_regions`. A classifier is not a brain region and is not exportable
as a circuit. It records the assembly's properties, owned internals, and
referenced input areas so neuroembryogenesis and area/mapping edits stay
aligned.

Each field binding is one Classifier mapping: an interconnect area scanning
the shared kernel memory, with its own detection twin.
*/

use serde::{Deserialize, Serialize};
use std::collections::HashMap;

/// Morphology used for kernel → kernel-memory encode.
pub const CLASSIFIER_KERNEL_MORPHOLOGY: &str = "episodic_memory";
/// Morphology used for class → class-memory encode.
pub const CLASSIFIER_CLASS_MORPHOLOGY: &str = "episodic_memory";
/// Morphology used for kernel-memory → class-memory bind.
pub const CLASSIFIER_ASSOCIATIVE_MORPHOLOGY: &str = "associative_memory";
/// Morphology used for field → kernel-memory scan.
pub const CLASSIFIER_SCAN_MORPHOLOGY: &str = "episodic_scan";

/// Directed mapping owned by a classifier assembly.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct ClassifierMapping {
    pub src_area_id: String,
    pub dst_area_id: String,
    pub morphology_id: String,
}

/// One field area scanning this classifier, and the twin that shows its detections.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
pub struct ClassifierField {
    pub field_area_id: String,
    pub scan_twin_id: String,
}

/// How a classifier learns. Recall uses the same kernel geometry as training.
#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Default)]
#[serde(rename_all = "snake_case")]
pub enum ClassifierTrainingMode {
    /// One kernel sample and one class sample per burst.
    #[default]
    Kernel,
    /// Slide `kernel_size` across each mapped field and label it from the mask.
    Scanner,
}

impl ClassifierTrainingMode {
    /// Genome and API spelling.
    pub fn as_str(self) -> &'static str {
        match self {
            Self::Kernel => "kernel",
            Self::Scanner => "scanner",
        }
    }

    /// Parse a stored mode. Absent values are not accepted here.
    pub fn parse(value: &str) -> Result<Self, String> {
        match value {
            "kernel" => Ok(Self::Kernel),
            "scanner" => Ok(Self::Scanner),
            other => Err(format!(
                "training_mode must be \"kernel\" or \"scanner\", got \"{other}\""
            )),
        }
    }
}

/// First-class classifier record persisted in the genome.
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
pub struct Classifier {
    /// UUID string, genome map key.
    pub classifier_id: String,
    pub name: String,
    /// Region that contains this assembly. Classifiers are not regions.
    pub parent_region_id: String,
    pub coordinates_3d: [i32; 3],
    /// Kernel mode ingests one sample per burst. Scanner mode learns from field windows.
    /// Genomes saved before modes existed load as kernel mode.
    #[serde(default)]
    pub training_mode: ClassifierTrainingMode,
    /// Referenced inputs. Cleared when that area is deleted.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub kernel_area_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub class_area_id: Option<String>,
    /// Scanner-mode label volume. Width and height match each mapped field. Depth is the class count.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub mask_area_id: Option<String>,
    /// Scanner-mode kernel `[x, y, z]`. Z must equal each mapped field's depth.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub kernel_size: Option<[u32; 3]>,
    /// Field scans. Empty until Classifier mappings are drawn.
    #[serde(default)]
    pub fields: Vec<ClassifierField>,
    /// Owned internals. Deleting kernel or class memory deletes the classifier.
    pub kernel_memory_id: String,
    pub class_memory_id: String,
    /// Per-scanning-instance pain and pleasure on the associative mapping.
    /// Genomes saved before reward training existed stay off.
    #[serde(default)]
    pub reward_training: bool,
    /// Correct-answer area. Scanner mode matches each detection twin.
    /// Kernel mode matches the class area. Empty until the user selects one.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub answer_feedback_area_id: Option<String>,
    /// Hidden area whose firing is this classifier's pain signal.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub pain_area_id: Option<String>,
    /// Hidden area whose firing is this classifier's pleasure signal.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub pleasure_area_id: Option<String>,
    /// Bursts between a decision and the answer that grades it. Zero grades the same burst.
    #[serde(default)]
    pub answer_latency_bursts: u32,
    /// When set, pain and pleasure run only on bursts this area fires.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub learn_area_id: Option<String>,
    /// OPU that receives one surplus value per class channel.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub confidence_area_id: Option<String>,
    #[serde(default)]
    pub properties: HashMap<String, serde_json::Value>,
}

impl Classifier {
    /// Kernel memory and class memory. Deleting either deletes the assembly.
    pub fn assembly_core_ids(&self) -> Vec<String> {
        vec![self.kernel_memory_id.clone(), self.class_memory_id.clone()]
    }

    /// Owned internals deleted with the classifier, including every field twin.
    pub fn owned_area_ids(&self) -> Vec<String> {
        let mut owned = self.assembly_core_ids();
        for field in &self.fields {
            if !field.scan_twin_id.is_empty() {
                owned.push(field.scan_twin_id.clone());
            }
        }
        if let Some(pain_area_id) = &self.pain_area_id {
            if !pain_area_id.is_empty() {
                owned.push(pain_area_id.clone());
            }
        }
        if let Some(pleasure_area_id) = &self.pleasure_area_id {
            if !pleasure_area_id.is_empty() {
                owned.push(pleasure_area_id.clone());
            }
        }
        owned
    }

    /// Referenced input areas that may be cleared independently.
    pub fn input_area_ids(&self) -> Vec<String> {
        let mut inputs = Vec::new();
        if let Some(kernel) = &self.kernel_area_id {
            inputs.push(kernel.clone());
        }
        if let Some(class) = &self.class_area_id {
            inputs.push(class.clone());
        }
        if let Some(mask) = &self.mask_area_id {
            inputs.push(mask.clone());
        }
        for field in &self.fields {
            inputs.push(field.field_area_id.clone());
        }
        inputs
    }

    pub fn owns_assembly_core(&self, area_id: &str) -> bool {
        self.kernel_memory_id == area_id || self.class_memory_id == area_id
    }

    /// True when `area_id` is kernel memory, class memory, or one of the field twins.
    pub fn owns_area(&self, area_id: &str) -> bool {
        self.owns_assembly_core(area_id) || self.field_for_twin(area_id).is_some()
    }

    pub fn field_for_twin(&self, twin_id: &str) -> Option<&ClassifierField> {
        self.fields
            .iter()
            .find(|field| field.scan_twin_id == twin_id)
    }

    pub fn binding_for_field(&self, field_area_id: &str) -> Option<&ClassifierField> {
        self.fields
            .iter()
            .find(|field| field.field_area_id == field_area_id)
    }

    /// True when `area_id` is a referenced input of this classifier.
    pub fn references_input(&self, area_id: &str) -> bool {
        self.kernel_area_id.as_deref() == Some(area_id)
            || self.class_area_id.as_deref() == Some(area_id)
            || self.mask_area_id.as_deref() == Some(area_id)
            || self.binding_for_field(area_id).is_some()
    }

    /// Replace the training mode and its inputs. The other mode's slots are cleared.
    ///
    /// Returns true when long-term memory learned under the previous geometry must be dropped.
    pub fn apply_training_inputs(
        &mut self,
        mode: ClassifierTrainingMode,
        kernel_area_id: Option<String>,
        class_area_id: Option<String>,
        mask_area_id: Option<String>,
        kernel_size: Option<[u32; 3]>,
    ) -> Result<bool, String> {
        let previous_mode = self.training_mode;
        let previous_size = self.kernel_size;
        match mode {
            ClassifierTrainingMode::Kernel => {
                let kernel = kernel_area_id.ok_or_else(|| "kernel_area_id required".to_string())?;
                let class = class_area_id.ok_or_else(|| "class_area_id required".to_string())?;
                self.kernel_area_id = Some(required_area_id(kernel, "kernel_area_id")?);
                self.class_area_id = Some(required_area_id(class, "class_area_id")?);
                self.mask_area_id = None;
                self.kernel_size = None;
            }
            ClassifierTrainingMode::Scanner => {
                let mask = mask_area_id.ok_or_else(|| "mask_area_id required".to_string())?;
                let size = kernel_size.ok_or_else(|| "kernel_size required".to_string())?;
                validate_kernel_size(size)?;
                self.mask_area_id = Some(required_area_id(mask, "mask_area_id")?);
                self.kernel_size = Some(size);
                self.kernel_area_id = None;
                self.class_area_id = None;
            }
        }
        self.training_mode = mode;
        Ok(previous_mode != mode
            || (mode == ClassifierTrainingMode::Scanner && previous_size != self.kernel_size))
    }

    /// Apply classifier-level edit. Does not replace owned internals or field bindings.
    pub fn apply_assembly_update(
        &mut self,
        name: Option<String>,
        coordinates_3d: Option<[i32; 3]>,
        parent_region_id: Option<String>,
        kernel_area_id: Option<String>,
        class_area_id: Option<String>,
    ) -> Result<(), String> {
        if let Some(name) = name {
            let trimmed = name.trim();
            if trimmed.is_empty() {
                return Err("Classifier name cannot be blank".to_string());
            }
            self.name = trimmed.to_string();
        }
        if let Some(coordinates_3d) = coordinates_3d {
            self.coordinates_3d = coordinates_3d;
        }
        if let Some(parent_region_id) = parent_region_id {
            let trimmed = parent_region_id.trim();
            if trimmed.is_empty() {
                return Err("parent_region_id cannot be blank".to_string());
            }
            self.parent_region_id = trimmed.to_string();
        }
        if let Some(kernel_area_id) = kernel_area_id {
            self.kernel_area_id = Some(required_area_id(kernel_area_id, "kernel_area_id")?);
        }
        if let Some(class_area_id) = class_area_id {
            self.class_area_id = Some(required_area_id(class_area_id, "class_area_id")?);
        }
        Ok(())
    }

    /// Apply classifier-level metadata. Does not change owned internals or input slots.
    pub fn apply_metadata_update(
        &mut self,
        name: Option<String>,
        coordinates_3d: Option<[i32; 3]>,
    ) -> Result<(), String> {
        self.apply_assembly_update(name, coordinates_3d, None, None, None)
    }

    /// Mappings this classifier requires given its current inputs.
    pub fn required_mappings(&self) -> Vec<ClassifierMapping> {
        let mut mappings = Vec::new();
        if let Some(kernel) = &self.kernel_area_id {
            mappings.push(ClassifierMapping {
                src_area_id: kernel.clone(),
                dst_area_id: self.kernel_memory_id.clone(),
                morphology_id: CLASSIFIER_KERNEL_MORPHOLOGY.to_string(),
            });
        }
        if let Some(class) = &self.class_area_id {
            mappings.push(ClassifierMapping {
                src_area_id: class.clone(),
                dst_area_id: self.class_memory_id.clone(),
                morphology_id: CLASSIFIER_CLASS_MORPHOLOGY.to_string(),
            });
        }
        mappings.push(ClassifierMapping {
            src_area_id: self.kernel_memory_id.clone(),
            dst_area_id: self.class_memory_id.clone(),
            morphology_id: CLASSIFIER_ASSOCIATIVE_MORPHOLOGY.to_string(),
        });
        for field in &self.fields {
            mappings.push(ClassifierMapping {
                src_area_id: field.field_area_id.clone(),
                dst_area_id: self.kernel_memory_id.clone(),
                morphology_id: CLASSIFIER_SCAN_MORPHOLOGY.to_string(),
            });
        }
        mappings
    }

    /// Drop an input reference when that area is deleted.
    pub fn clear_input(&mut self, area_id: &str) {
        if self.kernel_area_id.as_deref() == Some(area_id) {
            self.kernel_area_id = None;
        }
        if self.class_area_id.as_deref() == Some(area_id) {
            self.class_area_id = None;
        }
        if self.mask_area_id.as_deref() == Some(area_id) {
            self.mask_area_id = None;
        }
        if self.answer_feedback_area_id.as_deref() == Some(area_id) {
            self.answer_feedback_area_id = None;
        }
        if self.learn_area_id.as_deref() == Some(area_id) {
            self.learn_area_id = None;
        }
        if self.confidence_area_id.as_deref() == Some(area_id) {
            self.confidence_area_id = None;
        }
        self.fields.retain(|field| field.field_area_id != area_id);
    }

    /// Remove one field binding. Returns the removed twin id.
    pub fn detach_field(&mut self, field_area_id: &str) -> Option<String> {
        let position = self
            .fields
            .iter()
            .position(|field| field.field_area_id == field_area_id)?;
        Some(self.fields.remove(position).scan_twin_id)
    }

    /// Remove the binding whose twin is `twin_id`. Returns the field area id.
    pub fn detach_twin(&mut self, twin_id: &str) -> Option<String> {
        let position = self
            .fields
            .iter()
            .position(|field| field.scan_twin_id == twin_id)?;
        Some(self.fields.remove(position).field_area_id)
    }

    pub fn attach_field(
        &mut self,
        field_area_id: String,
        scan_twin_id: String,
    ) -> Result<(), String> {
        let field_area_id = required_area_id(field_area_id, "field_area_id")?;
        let scan_twin_id = required_area_id(scan_twin_id, "scan_twin_id")?;
        if self.binding_for_field(&field_area_id).is_some() {
            return Err(format!(
                "field_area_id {field_area_id} is already mapped to this classifier"
            ));
        }
        self.fields.push(ClassifierField {
            field_area_id,
            scan_twin_id,
        });
        Ok(())
    }

    /// Bind or clear kernel/class inputs from a mapping change. Field scans are attached explicitly.
    pub fn apply_mapping_change(
        &mut self,
        src_area_id: &str,
        dst_area_id: &str,
        morphology_id: &str,
        removed: bool,
    ) -> bool {
        if dst_area_id == self.kernel_memory_id && morphology_id == CLASSIFIER_KERNEL_MORPHOLOGY {
            self.kernel_area_id = if removed {
                None
            } else {
                Some(src_area_id.to_string())
            };
            return true;
        }
        if dst_area_id == self.class_memory_id && morphology_id == CLASSIFIER_CLASS_MORPHOLOGY {
            self.class_area_id = if removed {
                None
            } else {
                Some(src_area_id.to_string())
            };
            return true;
        }
        false
    }
}

/// Every kernel axis must be at least one voxel.
pub fn validate_kernel_size(size: [u32; 3]) -> Result<(), String> {
    if size[0] == 0 || size[1] == 0 || size[2] == 0 {
        return Err("kernel_size axes must be greater than zero".to_string());
    }
    Ok(())
}

/// Scanner kernel Z matches the image depth, and the mask shares the image's width and height.
pub fn validate_scanner_field(
    kernel_size: [u32; 3],
    field: [u32; 3],
    mask: [u32; 3],
) -> Result<(), String> {
    validate_kernel_size(kernel_size)?;
    if field[0] == 0 || field[1] == 0 || field[2] == 0 {
        return Err("field dimensions must be greater than zero".to_string());
    }
    if mask[2] == 0 {
        return Err("mask depth must be greater than zero".to_string());
    }
    if kernel_size[0] > field[0] || kernel_size[1] > field[1] {
        return Err("kernel_size does not fit the field".to_string());
    }
    if kernel_size[2] != field[2] {
        return Err("kernel depth must equal the field depth".to_string());
    }
    if mask[0] != field[0] || mask[1] != field[1] {
        return Err("mask width and height must equal the field".to_string());
    }
    Ok(())
}

/// One class for the whole image: two axes are 1 and the remaining axis is the class count.
pub fn is_whole_image_class_shape(feedback: [u32; 3], class_count: u32) -> bool {
    if class_count == 0 {
        return false;
    }
    let ones = feedback.iter().filter(|axis| **axis == 1).count();
    let volume = u64::from(feedback[0])
        .saturating_mul(u64::from(feedback[1]))
        .saturating_mul(u64::from(feedback[2]));
    ones >= 2 && volume == u64::from(class_count)
}

/// Answer feedback must match the classifier output.
///
/// Kernel mode compares the class area. Scanner mode compares each detection
/// twin. With no twin yet, the mask width, height, and depth are that output.
pub fn validate_answer_feedback_shape(
    mode: ClassifierTrainingMode,
    feedback: [u32; 3],
    reference: [u32; 3],
    output_shapes: &[[u32; 3]],
) -> Result<(), String> {
    if feedback[0] == 0 || feedback[1] == 0 || feedback[2] == 0 {
        return Err("answer feedback dimensions must be greater than zero".to_string());
    }
    match mode {
        ClassifierTrainingMode::Kernel => {
            if feedback != reference {
                return Err("answer feedback dimensions must match the class area".to_string());
            }
        }
        ClassifierTrainingMode::Scanner => {
            let class_count = if output_shapes.is_empty() {
                reference[2]
            } else {
                output_shapes[0][2]
            };
            if is_whole_image_class_shape(feedback, class_count) {
                return Ok(());
            }
            let shapes = if output_shapes.is_empty() {
                std::slice::from_ref(&reference)
            } else {
                output_shapes
            };
            if shapes.iter().any(|shape| *shape != feedback) {
                return Err(
                    "answer feedback dimensions must match the detection output or a whole-image class"
                        .to_string(),
                );
            }
        }
    }
    Ok(())
}

fn required_area_id(area_id: String, field: &str) -> Result<String, String> {
    let trimmed = area_id.trim();
    if trimmed.is_empty() {
        return Err(format!("{field} cannot be blank"));
    }
    Ok(trimmed.to_string())
}

#[cfg(test)]
mod tests {
    use super::*;

    fn sample() -> Classifier {
        let mut classifier = Classifier {
            classifier_id: "clf-1".to_string(),
            name: "demo".to_string(),
            parent_region_id: "region".to_string(),
            coordinates_3d: [1, 2, 3],
            training_mode: ClassifierTrainingMode::Kernel,
            kernel_area_id: Some("kernel".to_string()),
            class_area_id: Some("class".to_string()),
            mask_area_id: None,
            kernel_size: None,
            fields: Vec::new(),
            kernel_memory_id: "kmem".to_string(),
            class_memory_id: "cmem".to_string(),
            reward_training: false,
            answer_feedback_area_id: None,
            pain_area_id: None,
            pleasure_area_id: None,
            answer_latency_bursts: 0,
            learn_area_id: None,
            confidence_area_id: None,
            properties: HashMap::new(),
        };
        classifier
            .attach_field("field".to_string(), "twin".to_string())
            .expect("first field");
        classifier
    }

    #[test]
    fn required_mappings_cover_shared_edges_and_each_field() {
        let mut classifier = sample();
        classifier
            .attach_field("field-b".to_string(), "twin-b".to_string())
            .expect("second field");
        let mappings = classifier.required_mappings();
        assert_eq!(mappings.len(), 5);
        assert!(mappings.iter().any(|m| {
            m.src_area_id == "field"
                && m.dst_area_id == "kmem"
                && m.morphology_id == CLASSIFIER_SCAN_MORPHOLOGY
        }));
        assert!(mappings.iter().any(|m| m.src_area_id == "field-b"));
    }

    #[test]
    fn deleting_one_field_keeps_the_other_eye() {
        let mut classifier = sample();
        classifier
            .attach_field("field-b".to_string(), "twin-b".to_string())
            .expect("second field");
        assert_eq!(classifier.detach_field("field"), Some("twin".to_string()));
        assert!(classifier.binding_for_field("field").is_none());
        assert_eq!(
            classifier
                .binding_for_field("field-b")
                .map(|f| f.scan_twin_id.as_str()),
            Some("twin-b")
        );
        assert!(classifier.owns_assembly_core("kmem"));
        assert!(!classifier.owns_area("twin"));
        assert!(classifier.owns_area("twin-b"));
    }

    #[test]
    fn duplicate_field_mapping_is_rejected() {
        let mut classifier = sample();
        let result = classifier.attach_field("field".to_string(), "other-twin".to_string());
        assert!(result.is_err());
        assert_eq!(classifier.fields.len(), 1);
    }

    #[test]
    fn metadata_update_renames_without_touching_areas() {
        let mut classifier = sample();
        classifier
            .apply_metadata_update(Some("  renamed  ".to_string()), Some([9, 8, 7]))
            .expect("valid metadata");
        assert_eq!(classifier.name, "renamed");
        assert_eq!(classifier.coordinates_3d, [9, 8, 7]);
        assert_eq!(classifier.kernel_memory_id, "kmem");
        assert_eq!(classifier.fields[0].scan_twin_id, "twin");
        assert_eq!(classifier.kernel_area_id.as_deref(), Some("kernel"));
    }

    #[test]
    fn assembly_update_retargets_kernel_and_class_only() {
        let mut classifier = sample();
        classifier
            .apply_assembly_update(
                None,
                None,
                Some("other-region".to_string()),
                Some("kernel2".to_string()),
                Some("class2".to_string()),
            )
            .expect("valid assembly update");
        assert_eq!(classifier.parent_region_id, "other-region");
        assert_eq!(classifier.kernel_area_id.as_deref(), Some("kernel2"));
        assert_eq!(classifier.class_area_id.as_deref(), Some("class2"));
        assert_eq!(classifier.fields[0].field_area_id, "field");
    }

    #[test]
    fn scanner_mode_clears_kernel_inputs_and_reports_geometry_change() {
        let mut classifier = sample();
        let changed = classifier
            .apply_training_inputs(
                ClassifierTrainingMode::Scanner,
                None,
                None,
                Some("mask".to_string()),
                Some([8, 8, 3]),
            )
            .expect("scanner inputs");
        assert!(changed);
        assert_eq!(classifier.training_mode, ClassifierTrainingMode::Scanner);
        assert!(classifier.kernel_area_id.is_none());
        assert!(classifier.class_area_id.is_none());
        assert_eq!(classifier.mask_area_id.as_deref(), Some("mask"));
        assert_eq!(classifier.kernel_size, Some([8, 8, 3]));
        assert!(classifier.references_input("mask"));
        let same = classifier
            .apply_training_inputs(
                ClassifierTrainingMode::Scanner,
                None,
                None,
                Some("mask".to_string()),
                Some([8, 8, 3]),
            )
            .expect("same scanner geometry");
        assert!(!same);
    }

    #[test]
    fn kernel_mode_clears_scanner_inputs() {
        let mut classifier = sample();
        classifier
            .apply_training_inputs(
                ClassifierTrainingMode::Scanner,
                None,
                None,
                Some("mask".to_string()),
                Some([2, 2, 1]),
            )
            .expect("scanner");
        classifier
            .apply_training_inputs(
                ClassifierTrainingMode::Kernel,
                Some("kernel".to_string()),
                Some("class".to_string()),
                None,
                None,
            )
            .expect("kernel");
        assert!(classifier.mask_area_id.is_none());
        assert!(classifier.kernel_size.is_none());
        assert_eq!(classifier.kernel_area_id.as_deref(), Some("kernel"));
    }

    #[test]
    fn answer_feedback_matches_class_area_or_detection_output() {
        assert!(validate_answer_feedback_shape(
            ClassifierTrainingMode::Kernel,
            [1, 1, 4],
            [1, 1, 4],
            &[],
        )
        .is_ok());
        assert!(validate_answer_feedback_shape(
            ClassifierTrainingMode::Kernel,
            [8, 8, 4],
            [1, 1, 4],
            &[],
        )
        .is_err());
        assert!(validate_answer_feedback_shape(
            ClassifierTrainingMode::Scanner,
            [16, 16, 4],
            [16, 16, 4],
            &[[16, 16, 4]],
        )
        .is_ok());
        assert!(validate_answer_feedback_shape(
            ClassifierTrainingMode::Scanner,
            [16, 16, 4],
            [16, 16, 4],
            &[[16, 16, 4], [8, 8, 4]],
        )
        .is_err());
        assert!(validate_answer_feedback_shape(
            ClassifierTrainingMode::Scanner,
            [10, 1, 1],
            [16, 16, 10],
            &[[16, 16, 10]],
        )
        .is_ok());
    }

    #[test]
    fn scanner_field_must_match_mask_and_kernel_depth() {
        assert!(validate_scanner_field([8, 8, 3], [256, 128, 3], [256, 128, 10]).is_ok());
        assert!(validate_scanner_field([8, 8, 1], [256, 128, 3], [256, 128, 10]).is_err());
        assert!(validate_scanner_field([8, 8, 3], [256, 128, 3], [200, 128, 10]).is_err());
    }
}