faultscope-core 0.2.12

Python-independent circuit, DEM, sampling, and decoder primitives for FaultScope
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
use std::collections::{HashMap, HashSet};
use std::fmt;
use std::mem;

use crate::dem_canonical::{canonical_id_order, parity_canonicalize, parity_support_len};
use crate::{DetectorErrorModel, NpError, NpResult};

#[derive(Debug, Clone, PartialEq)]
pub struct IndexedDemEdge {
    pub probability: f64,
    pub weight: f64,
    pub detectors: Vec<usize>,
    pub observables: Vec<usize>,
    pub original_edge_index: usize,
}

#[derive(Debug, Clone, PartialEq)]
pub struct IndexedDem {
    pub detector_ids: Vec<i64>,
    pub detector_coords: Vec<Vec<f64>>,
    pub observable_ids: Vec<i64>,
    pub edges: Vec<IndexedDemEdge>,
}

#[derive(Debug, Clone, PartialEq)]
pub struct GraphlikeEdge {
    pub detectors: Vec<usize>,
    pub fault_observables: Vec<usize>,
    pub probability: f64,
    pub dem_edge_index: usize,
}

/// One graphlike component used to decompose a canonical DEM edge for decoding.
///
/// Detector and observable values are model IDs, not compact problem indices.
/// All components that originate from the same canonical edge retain that
/// edge's probability and `dem_edge_index` in the compiled problem.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct GraphlikeDecompositionComponent {
    pub detectors: Vec<i64>,
    pub observables: Vec<i64>,
}

impl GraphlikeEdge {
    /// Return the canonical log-likelihood ratio derived from `probability`.
    pub fn weight(&self) -> f64 {
        log_likelihood_ratio(self.probability)
    }
}

pub const NATIVE_GRAPHLIKE_PROBLEM_ABI_VERSION: u32 = 1;
pub const NATIVE_GRAPHLIKE_PROBLEM_ABI_NAME: &str = "faultscope.native_graphlike_problem.v1";
pub const NATIVE_GRAPHLIKE_PROBLEM_CAPSULE_NAME: &str = "faultscope.native_graphlike_problem.v1";
pub const NATIVE_GRAPHLIKE_PROBLEM_CAPSULE_METHOD: &str =
    "__faultscope_native_graphlike_problem_capsule__";

/// Compact graphlike edge record shared through the versioned construction ABI.
///
/// Detector and observable indices use `u32` to keep the per-edge record small.
/// The owning problem validates all conversions before storing a record.
#[doc(hidden)]
#[repr(C)]
#[derive(Debug, Clone, Copy, PartialEq)]
pub struct FaultScopeNativeGraphlikeEdgeV1 {
    pub dem_edge_index: usize,
    pub probability: f64,
    /// Canonical log-likelihood ratio derived from `probability` by the core.
    pub weight: f64,
    pub fault_observable_offset: u32,
    pub fault_observable_count: u32,
    pub detector0: u32,
    pub detector1: u32,
    pub detector_count: u32,
    pub reserved: u32,
}

/// Borrowed descriptor exposed by the graphlike construction capsule.
///
/// All pointers remain valid only while the capsule that owns the problem is
/// alive. Consumers must validate `abi_version`, `struct_size`, and
/// `edge_struct_size` before dereferencing any data pointer.
#[doc(hidden)]
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct FaultScopeNativeGraphlikeProblemV1 {
    pub abi_version: u32,
    pub struct_size: usize,
    pub edge_struct_size: usize,
    pub detector_ids: *const i64,
    pub detector_count: usize,
    pub observable_ids: *const i64,
    pub observable_count: usize,
    pub edges: *const FaultScopeNativeGraphlikeEdgeV1,
    pub edge_count: usize,
    pub fault_observables: *const u32,
    pub fault_observable_count: usize,
}

/// Borrowed edge view over the compact graphlike representation.
#[derive(Clone, Copy)]
pub struct GraphlikeEdgeRef<'a> {
    edge: &'a FaultScopeNativeGraphlikeEdgeV1,
    fault_observables: &'a [u32],
}

impl GraphlikeEdgeRef<'_> {
    pub fn detector_count(&self) -> usize {
        self.edge.detector_count as usize
    }

    pub fn detectors(&self) -> impl ExactSizeIterator<Item = usize> + DoubleEndedIterator + '_ {
        [self.edge.detector0 as usize, self.edge.detector1 as usize]
            .into_iter()
            .take(self.detector_count())
    }

    pub fn fault_observables(
        &self,
    ) -> impl ExactSizeIterator<Item = usize> + DoubleEndedIterator + '_ {
        self.fault_observables.iter().map(|index| *index as usize)
    }

    pub fn probability(&self) -> f64 {
        self.edge.probability
    }

    pub fn weight(&self) -> f64 {
        self.edge.weight
    }

    pub fn dem_edge_index(&self) -> usize {
        self.edge.dem_edge_index
    }

    pub fn to_owned(self) -> GraphlikeEdge {
        GraphlikeEdge {
            detectors: self.detectors().collect(),
            fault_observables: self.fault_observables().collect(),
            probability: self.probability(),
            dem_edge_index: self.dem_edge_index(),
        }
    }
}

impl fmt::Debug for GraphlikeEdgeRef<'_> {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("GraphlikeEdgeRef")
            .field("dem_edge_index", &self.dem_edge_index())
            .field("detectors", &self.detectors().collect::<Vec<_>>())
            .field(
                "fault_observables",
                &self.fault_observables().collect::<Vec<_>>(),
            )
            .field("probability", &self.probability())
            .field("weight", &self.weight())
            .finish()
    }
}

#[derive(Debug, Clone, PartialEq)]
pub struct GraphlikeDecodingProblem {
    detector_ids: Vec<i64>,
    detector_coords: Vec<Vec<f64>>,
    observable_ids: Vec<i64>,
    edges: Vec<FaultScopeNativeGraphlikeEdgeV1>,
    fault_observables: Vec<u32>,
}

impl GraphlikeDecodingProblem {
    /// Build a validated compact problem from owned compatibility edge DTOs.
    pub fn new(
        detector_ids: Vec<i64>,
        detector_coords: Vec<Vec<f64>>,
        observable_ids: Vec<i64>,
        edges: Vec<GraphlikeEdge>,
    ) -> NpResult<Self> {
        let mut builder = GraphlikeProblemBuilder::new(
            detector_ids,
            detector_coords,
            observable_ids,
            edges.len(),
        )?;
        for mut edge in edges {
            parity_canonicalize(&mut edge.detectors);
            parity_canonicalize(&mut edge.fault_observables);
            builder.push_edge(
                &edge.detectors,
                &edge.fault_observables,
                edge.probability,
                edge.dem_edge_index,
            )?;
        }
        Ok(builder.build())
    }

    pub fn detector_ids(&self) -> &[i64] {
        &self.detector_ids
    }

    pub fn detector_coords(&self) -> &[Vec<f64>] {
        &self.detector_coords
    }

    pub fn observable_ids(&self) -> &[i64] {
        &self.observable_ids
    }

    pub fn edge_count(&self) -> usize {
        self.edges.len()
    }

    pub fn edge(&self, index: usize) -> Option<GraphlikeEdgeRef<'_>> {
        self.edges.get(index).map(|edge| self.edge_ref(edge))
    }

    pub fn iter_edges(
        &self,
    ) -> impl ExactSizeIterator<Item = GraphlikeEdgeRef<'_>> + DoubleEndedIterator + '_ {
        self.edges.iter().map(|edge| self.edge_ref(edge))
    }

    /// Return a zero-copy descriptor for a versioned native construction capsule.
    #[doc(hidden)]
    pub fn native_view(&self) -> FaultScopeNativeGraphlikeProblemV1 {
        FaultScopeNativeGraphlikeProblemV1 {
            abi_version: NATIVE_GRAPHLIKE_PROBLEM_ABI_VERSION,
            struct_size: mem::size_of::<FaultScopeNativeGraphlikeProblemV1>(),
            edge_struct_size: mem::size_of::<FaultScopeNativeGraphlikeEdgeV1>(),
            detector_ids: self.detector_ids.as_ptr(),
            detector_count: self.detector_ids.len(),
            observable_ids: self.observable_ids.as_ptr(),
            observable_count: self.observable_ids.len(),
            edges: self.edges.as_ptr(),
            edge_count: self.edges.len(),
            fault_observables: self.fault_observables.as_ptr(),
            fault_observable_count: self.fault_observables.len(),
        }
    }

    pub(crate) fn into_ids(self) -> (Vec<i64>, Vec<i64>) {
        (self.detector_ids, self.observable_ids)
    }

    fn edge_ref<'a>(&'a self, edge: &'a FaultScopeNativeGraphlikeEdgeV1) -> GraphlikeEdgeRef<'a> {
        let start = edge.fault_observable_offset as usize;
        let end = start + edge.fault_observable_count as usize;
        GraphlikeEdgeRef {
            edge,
            fault_observables: &self.fault_observables[start..end],
        }
    }
}

struct GraphlikeProblemBuilder {
    detector_ids: Vec<i64>,
    detector_coords: Vec<Vec<f64>>,
    observable_ids: Vec<i64>,
    edges: Vec<FaultScopeNativeGraphlikeEdgeV1>,
    fault_observables: Vec<u32>,
}

impl GraphlikeProblemBuilder {
    fn new(
        detector_ids: Vec<i64>,
        detector_coords: Vec<Vec<f64>>,
        observable_ids: Vec<i64>,
        edge_capacity: usize,
    ) -> NpResult<Self> {
        if detector_coords.len() != detector_ids.len() {
            return Err(NpError::new(format!(
                "graphlike detector coordinate count {} does not match detector count {}",
                detector_coords.len(),
                detector_ids.len()
            )));
        }
        ensure_unique_ids(&detector_ids, "graphlike detector ids must be unique")?;
        ensure_unique_ids(
            &observable_ids,
            "graphlike logical observable ids must be unique",
        )?;
        if u32::try_from(detector_ids.len()).is_err() {
            return Err(NpError::new(
                "graphlike detector count exceeds the native u32 index capacity",
            ));
        }
        if u32::try_from(observable_ids.len()).is_err() {
            return Err(NpError::new(
                "graphlike observable count exceeds the native u32 index capacity",
            ));
        }
        Ok(Self {
            detector_ids,
            detector_coords,
            observable_ids,
            edges: Vec::with_capacity(edge_capacity),
            fault_observables: Vec::with_capacity(edge_capacity),
        })
    }

    fn push_edge(
        &mut self,
        detectors: &[usize],
        fault_observables: &[usize],
        probability: f64,
        dem_edge_index: usize,
    ) -> NpResult<()> {
        validate_graphlike_probability(probability)?;
        let weight = log_likelihood_ratio(probability);
        if detectors.len() > 2 {
            return Err(NpError::new(format!(
                "graphlike decoder requires at most two detectors per edge; edge {dem_edge_index} has {}",
                detectors.len()
            )));
        }
        if detectors.is_empty() && !fault_observables.is_empty() {
            return Err(NpError::new(format!(
                "graphlike decoder cannot use undetectable logical edge {dem_edge_index}; observables={fault_observables:?}"
            )));
        }
        for detector in detectors {
            if *detector >= self.detector_ids.len() {
                return Err(NpError::new(format!(
                    "graphlike edge {dem_edge_index} references detector index {detector} but only {} detectors exist",
                    self.detector_ids.len()
                )));
            }
        }
        for observable in fault_observables {
            if *observable >= self.observable_ids.len() {
                return Err(NpError::new(format!(
                    "graphlike edge {dem_edge_index} references observable index {observable} but only {} observables exist",
                    self.observable_ids.len()
                )));
            }
        }

        let fault_observable_offset = u32::try_from(self.fault_observables.len())
            .map_err(|_| NpError::new("graphlike observable pool exceeds native u32 capacity"))?;
        let fault_observable_count = u32::try_from(fault_observables.len()).map_err(|_| {
            NpError::new(format!(
                "graphlike edge {dem_edge_index} observable support exceeds native u32 capacity"
            ))
        })?;
        let new_observable_count = self
            .fault_observables
            .len()
            .checked_add(fault_observables.len())
            .ok_or_else(|| NpError::new("graphlike observable pool length overflow"))?;
        if u32::try_from(new_observable_count).is_err() {
            return Err(NpError::new(
                "graphlike observable pool exceeds native u32 capacity",
            ));
        }
        self.fault_observables.extend(
            fault_observables
                .iter()
                .map(|index| u32::try_from(*index).expect("observable index capacity validated")),
        );

        self.edges.push(FaultScopeNativeGraphlikeEdgeV1 {
            dem_edge_index,
            probability,
            weight,
            fault_observable_offset,
            fault_observable_count,
            detector0: detectors
                .first()
                .map(|index| u32::try_from(*index).expect("detector index capacity validated"))
                .unwrap_or(0),
            detector1: detectors
                .get(1)
                .map(|index| u32::try_from(*index).expect("detector index capacity validated"))
                .unwrap_or(0),
            detector_count: detectors.len() as u32,
            reserved: 0,
        });
        Ok(())
    }

    fn build(self) -> GraphlikeDecodingProblem {
        GraphlikeDecodingProblem {
            detector_ids: self.detector_ids,
            detector_coords: self.detector_coords,
            observable_ids: self.observable_ids,
            edges: self.edges,
            fault_observables: self.fault_observables,
        }
    }
}

fn ensure_unique_ids(ids: &[i64], message: &'static str) -> NpResult<()> {
    let mut seen = HashSet::with_capacity(ids.len());
    if ids.iter().all(|id| seen.insert(*id)) {
        Ok(())
    } else {
        Err(NpError::new(message))
    }
}

fn validate_graphlike_probability(probability: f64) -> NpResult<()> {
    if !(0.0..=1.0).contains(&probability) {
        return Err(NpError::new(format!(
            "DEM edge probability must be in [0, 1], got {probability}"
        )));
    }
    Ok(())
}

#[derive(Clone, Copy)]
pub(crate) struct GraphlikeSourceEdge<'a> {
    pub probability: f64,
    pub detectors: &'a [i64],
    pub observables: &'a [i64],
    pub original_edge_index: usize,
}

pub(crate) fn compile_graphlike_problem_from_edge_views<'a, F, I>(
    detectors: &'a [crate::Detector],
    observables: &'a [crate::LogicalObservable],
    edge_count: usize,
    edges: F,
) -> NpResult<GraphlikeDecodingProblem>
where
    F: Fn() -> I,
    I: Iterator<Item = GraphlikeSourceEdge<'a>>,
{
    let declared_detector_ids = detectors
        .iter()
        .map(|detector| detector.id)
        .collect::<Vec<_>>();
    let detector_ids = canonical_id_order(
        &declared_detector_ids,
        edges().map(|edge| edge.detectors),
        "detector ids must be unique",
    )?;
    let detector_coords = stable_detector_coords_from_declarations(detectors, &detector_ids);
    let declared_observable_ids = observables
        .iter()
        .map(|observable| observable.id)
        .collect::<Vec<_>>();
    let observable_ids = canonical_id_order(
        &declared_observable_ids,
        edges().map(|edge| edge.observables),
        "logical observable ids must be unique",
    )?;
    let detector_index = id_index(&detector_ids);
    let observable_index = id_index(&observable_ids);
    let mut builder =
        GraphlikeProblemBuilder::new(detector_ids, detector_coords, observable_ids, edge_count)?;

    for edge in edges() {
        validate_graphlike_probability(edge.probability)?;
        let mut detector_indices = edge
            .detectors
            .iter()
            .map(|detector_id| {
                detector_index.get(detector_id).copied().ok_or_else(|| {
                    NpError::new(format!("unknown detector id {detector_id} in DEM edge"))
                })
            })
            .collect::<NpResult<Vec<_>>>()?;
        parity_canonicalize(&mut detector_indices);
        let mut observable_indices = edge
            .observables
            .iter()
            .map(|observable_id| {
                observable_index.get(observable_id).copied().ok_or_else(|| {
                    NpError::new(format!(
                        "unknown logical observable id {observable_id} in DEM edge"
                    ))
                })
            })
            .collect::<NpResult<Vec<_>>>()?;
        parity_canonicalize(&mut observable_indices);
        builder.push_edge(
            &detector_indices,
            &observable_indices,
            edge.probability,
            edge.original_edge_index,
        )?;
    }
    Ok(builder.build())
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct SparseBinaryMatrix {
    pub row_count: usize,
    pub col_count: usize,
    pub entries: Vec<(usize, usize)>,
}

#[derive(Debug, Clone, PartialEq)]
pub struct BinaryLinearDecodingProblem {
    pub detector_ids: Vec<i64>,
    pub detector_coords: Vec<Vec<f64>>,
    pub observable_ids: Vec<i64>,
    pub edge_count: usize,
    pub h: SparseBinaryMatrix,
    pub f: SparseBinaryMatrix,
    pub probabilities: Vec<f64>,
    pub log_likelihood_ratios: Vec<f64>,
    pub dem_edge_indices: Vec<usize>,
}

impl DetectorErrorModel {
    pub fn compile_indexed(&self) -> NpResult<IndexedDem> {
        let declared_detector_ids = self
            .detectors
            .iter()
            .map(|detector| detector.id)
            .collect::<Vec<_>>();
        let detector_ids = canonical_id_order(
            &declared_detector_ids,
            self.edges.iter().map(|edge| edge.detectors.as_slice()),
            "detector ids must be unique",
        )?;
        let detector_coords = stable_detector_coords(self, &detector_ids);
        let declared_observable_ids = self
            .observables
            .iter()
            .map(|observable| observable.id)
            .collect::<Vec<_>>();
        let observable_ids = canonical_id_order(
            &declared_observable_ids,
            self.edges.iter().map(|edge| edge.observables.as_slice()),
            "logical observable ids must be unique",
        )?;
        let detector_index = id_index(&detector_ids);
        let observable_index = id_index(&observable_ids);
        let mut edges = Vec::with_capacity(self.edges.len());

        for (edge_index, edge) in self.edges.iter().enumerate() {
            edge.validate()?;
            let mut detectors = edge
                .detectors
                .iter()
                .map(|detector_id| {
                    detector_index.get(detector_id).copied().ok_or_else(|| {
                        NpError::new(format!("unknown detector id {detector_id} in DEM edge"))
                    })
                })
                .collect::<NpResult<Vec<_>>>()?;
            parity_canonicalize(&mut detectors);
            let mut observables = edge
                .observables
                .iter()
                .map(|observable_id| {
                    observable_index.get(observable_id).copied().ok_or_else(|| {
                        NpError::new(format!(
                            "unknown logical observable id {observable_id} in DEM edge"
                        ))
                    })
                })
                .collect::<NpResult<Vec<_>>>()?;
            parity_canonicalize(&mut observables);
            edges.push(IndexedDemEdge {
                probability: edge.probability,
                weight: log_likelihood_ratio(edge.probability),
                detectors,
                observables,
                original_edge_index: edge_index,
            });
        }

        Ok(IndexedDem {
            detector_ids,
            detector_coords,
            observable_ids,
            edges,
        })
    }

    pub fn is_graphlike(&self) -> bool {
        self.edges.iter().all(|edge| {
            let detector_count = parity_support_len(&edge.detectors);
            detector_count <= 2
                && (detector_count != 0 || parity_support_len(&edge.observables) == 0)
        })
    }

    pub fn compile_graphlike_problem(&self) -> NpResult<GraphlikeDecodingProblem> {
        compile_graphlike_problem_from_edge_views(
            &self.detectors,
            &self.observables,
            self.edges.len(),
            || {
                self.edges
                    .iter()
                    .enumerate()
                    .map(|(edge_index, edge)| GraphlikeSourceEdge {
                        probability: edge.probability,
                        detectors: &edge.detectors,
                        observables: &edge.observables,
                        original_edge_index: edge_index,
                    })
            },
        )
    }

    /// Compile a graphlike decoder view using per-edge decomposition hints.
    ///
    /// The canonical DEM remains unchanged: every component inherits its
    /// parent edge's probability and original edge index. The decomposition is
    /// accepted only when the GF(2) XOR of its components exactly reproduces
    /// the canonical detector and observable support of the parent edge.
    pub fn compile_graphlike_problem_with_decomposition(
        &self,
        decomposition: &HashMap<usize, Vec<GraphlikeDecompositionComponent>>,
    ) -> NpResult<GraphlikeDecodingProblem> {
        for edge_index in decomposition.keys() {
            if *edge_index >= self.edges.len() {
                return Err(NpError::new(format!(
                    "graphlike decomposition references DEM edge index {edge_index} but only {} edges exist",
                    self.edges.len()
                )));
            }
        }

        let indexed = self.compile_indexed()?;
        let detector_index = id_index(&indexed.detector_ids);
        let observable_index = id_index(&indexed.observable_ids);
        let edge_capacity = indexed.edges.iter().try_fold(0usize, |total, edge| {
            total
                .checked_add(
                    decomposition
                        .get(&edge.original_edge_index)
                        .map_or(1, Vec::len),
                )
                .ok_or_else(|| NpError::new("graphlike decomposition edge count overflow"))
        })?;
        let mut builder = GraphlikeProblemBuilder::new(
            indexed.detector_ids.clone(),
            indexed.detector_coords.clone(),
            indexed.observable_ids.clone(),
            edge_capacity,
        )?;

        for edge in &indexed.edges {
            let Some(components) = decomposition.get(&edge.original_edge_index) else {
                builder.push_edge(
                    &edge.detectors,
                    &edge.observables,
                    edge.probability,
                    edge.original_edge_index,
                )?;
                continue;
            };
            if components.is_empty() {
                return Err(NpError::new(format!(
                    "graphlike decomposition for DEM edge {} must contain at least one component",
                    edge.original_edge_index
                )));
            }

            let mut compiled_components = Vec::with_capacity(components.len());
            let mut detector_xor = Vec::new();
            let mut observable_xor = Vec::new();
            for (component_index, component) in components.iter().enumerate() {
                let mut detectors = component
                    .detectors
                    .iter()
                    .map(|detector_id| {
                        detector_index.get(detector_id).copied().ok_or_else(|| {
                            NpError::new(format!(
                                "graphlike decomposition for DEM edge {} component {component_index} references unknown detector id {detector_id}",
                                edge.original_edge_index
                            ))
                        })
                    })
                    .collect::<NpResult<Vec<_>>>()?;
                parity_canonicalize(&mut detectors);
                let mut observables = component
                    .observables
                    .iter()
                    .map(|observable_id| {
                        observable_index.get(observable_id).copied().ok_or_else(|| {
                            NpError::new(format!(
                                "graphlike decomposition for DEM edge {} component {component_index} references unknown logical observable id {observable_id}",
                                edge.original_edge_index
                            ))
                        })
                    })
                    .collect::<NpResult<Vec<_>>>()?;
                parity_canonicalize(&mut observables);

                if detectors.is_empty() && observables.is_empty() {
                    return Err(NpError::new(format!(
                        "graphlike decomposition for DEM edge {} component {component_index} is empty after GF(2) parity reduction",
                        edge.original_edge_index
                    )));
                }
                if detectors.len() > 2 {
                    return Err(NpError::new(format!(
                        "graphlike decomposition for DEM edge {} component {component_index} has {} detectors after GF(2) parity reduction; expected at most two",
                        edge.original_edge_index,
                        detectors.len()
                    )));
                }
                if detectors.is_empty() {
                    return Err(NpError::new(format!(
                        "graphlike decomposition for DEM edge {} component {component_index} is a pure logical component; at least one detector is required",
                        edge.original_edge_index
                    )));
                }

                detector_xor.extend_from_slice(&detectors);
                observable_xor.extend_from_slice(&observables);
                compiled_components.push((detectors, observables));
            }

            if !gf2_support_equal(&detector_xor, &edge.detectors)
                || !gf2_support_equal(&observable_xor, &edge.observables)
            {
                return Err(NpError::new(format!(
                    "graphlike decomposition for DEM edge {} does not reproduce the parent detector and observable support under GF(2) XOR",
                    edge.original_edge_index
                )));
            }

            for (detectors, observables) in compiled_components {
                builder.push_edge(
                    &detectors,
                    &observables,
                    edge.probability,
                    edge.original_edge_index,
                )?;
            }
        }

        Ok(builder.build())
    }

    pub fn compile_binary_linear_problem(&self) -> NpResult<BinaryLinearDecodingProblem> {
        let indexed = self.compile_indexed()?;
        let mut h_entries = Vec::new();
        let mut f_entries = Vec::new();
        let mut probabilities = Vec::with_capacity(indexed.edges.len());
        let mut log_likelihood_ratios = Vec::with_capacity(indexed.edges.len());
        let mut dem_edge_indices = Vec::with_capacity(indexed.edges.len());

        for (column, edge) in indexed.edges.iter().enumerate() {
            for detector in &edge.detectors {
                h_entries.push((*detector, column));
            }
            for observable in &edge.observables {
                f_entries.push((*observable, column));
            }
            probabilities.push(edge.probability);
            log_likelihood_ratios.push(edge.weight);
            dem_edge_indices.push(edge.original_edge_index);
        }

        Ok(BinaryLinearDecodingProblem {
            detector_ids: indexed.detector_ids.clone(),
            detector_coords: indexed.detector_coords.clone(),
            observable_ids: indexed.observable_ids.clone(),
            edge_count: indexed.edges.len(),
            h: SparseBinaryMatrix {
                row_count: indexed.detector_ids.len(),
                col_count: indexed.edges.len(),
                entries: h_entries,
            },
            f: SparseBinaryMatrix {
                row_count: indexed.observable_ids.len(),
                col_count: indexed.edges.len(),
                entries: f_entries,
            },
            probabilities,
            log_likelihood_ratios,
            dem_edge_indices,
        })
    }
}

fn stable_detector_coords(dem: &DetectorErrorModel, detector_ids: &[i64]) -> Vec<Vec<f64>> {
    stable_detector_coords_from_declarations(&dem.detectors, detector_ids)
}

fn stable_detector_coords_from_declarations(
    detectors: &[crate::Detector],
    detector_ids: &[i64],
) -> Vec<Vec<f64>> {
    let coords_by_id = detectors
        .iter()
        .map(|detector| (detector.id, detector.coords.clone()))
        .collect::<HashMap<_, _>>();
    detector_ids
        .iter()
        .map(|detector_id| coords_by_id.get(detector_id).cloned().unwrap_or_default())
        .collect()
}

fn id_index(ids: &[i64]) -> HashMap<i64, usize> {
    ids.iter()
        .copied()
        .enumerate()
        .map(|(index, id)| (id, index))
        .collect()
}

fn gf2_support_equal(left: &[usize], right: &[usize]) -> bool {
    let mut left = left.to_vec();
    let mut right = right.to_vec();
    parity_canonicalize(&mut left);
    parity_canonicalize(&mut right);
    left.sort_unstable();
    right.sort_unstable();
    left == right
}

pub fn log_likelihood_ratio(probability: f64) -> f64 {
    let p = probability.clamp(1e-15, 1.0 - 1e-15);
    ((1.0 - p) / p).ln()
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::{DemEvent, Detector, DetectorErrorEdge, LogicalObservable};

    fn edge(
        probability: f64,
        detectors: Vec<i64>,
        observables: Vec<i64>,
        location_id: &str,
    ) -> DetectorErrorEdge {
        DetectorErrorEdge {
            probability,
            detectors,
            observables,
            location_id: location_id.to_string(),
            event: DemEvent::Pauli("X".to_string()),
            tags: HashMap::new(),
        }
    }

    fn dem() -> DetectorErrorModel {
        DetectorErrorModel {
            detectors: vec![
                Detector {
                    id: 5,
                    measurement_keys: Vec::new(),
                    coords: vec![5.0, 0.0],
                },
                Detector {
                    id: 2,
                    measurement_keys: Vec::new(),
                    coords: vec![2.0, 0.0],
                },
            ],
            observables: vec![LogicalObservable {
                id: 7,
                measurement_keys: Vec::new(),
                pauli_qubits: Vec::new(),
                pauli: String::new(),
            }],
            edges: vec![
                edge(0.1, vec![2, 9], vec![7], "a"),
                edge(0.2, vec![5], vec![], "b"),
            ],
        }
    }

    #[test]
    fn indexed_dem_preserves_declared_order_and_appends_edge_ids() {
        let indexed = dem().compile_indexed().unwrap();

        assert_eq!(indexed.detector_ids, vec![5, 2, 9]);
        assert_eq!(
            indexed.detector_coords,
            vec![vec![5.0, 0.0], vec![2.0, 0.0], Vec::<f64>::new()]
        );
        assert_eq!(indexed.observable_ids, vec![7]);
        assert_eq!(indexed.edges[0].detectors, vec![1, 2]);
        assert_eq!(indexed.edges[0].observables, vec![0]);
        assert_eq!(indexed.edges[0].original_edge_index, 0);
    }

    #[test]
    fn graphlike_problem_rejects_hyperedges() {
        let mut dem = dem();
        dem.edges.push(edge(0.3, vec![1, 2, 3], vec![], "hyper"));

        let err = dem.compile_graphlike_problem().unwrap_err();

        assert!(err.message().contains("at most two detectors"));
    }

    #[test]
    fn graphlike_decomposition_accepts_order_independent_support_and_preserves_emission_order() {
        let dem = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![
                edge(0.125, vec![10, 20, 30], vec![7], "hyper"),
                edge(0.25, vec![40], vec![], "plain"),
            ],
        };
        let decomposition = HashMap::from([(
            0,
            vec![
                GraphlikeDecompositionComponent {
                    detectors: vec![30],
                    observables: vec![],
                },
                GraphlikeDecompositionComponent {
                    detectors: vec![20, 10, 20, 20],
                    observables: vec![7, 7, 7],
                },
            ],
        )]);

        let problem = dem
            .compile_graphlike_problem_with_decomposition(&decomposition)
            .unwrap();
        let edges = problem
            .iter_edges()
            .map(GraphlikeEdgeRef::to_owned)
            .collect::<Vec<_>>();

        assert_eq!(problem.detector_ids(), &[10, 20, 30, 40]);
        assert_eq!(problem.observable_ids(), &[7]);
        assert_eq!(edges.len(), 3);
        assert_eq!(edges[0].detectors, vec![2]);
        assert!(edges[0].fault_observables.is_empty());
        assert_eq!(edges[1].detectors, vec![1, 0]);
        assert_eq!(edges[1].fault_observables, vec![0]);
        assert_eq!(edges[2].detectors, vec![3]);
        assert_eq!(
            edges
                .iter()
                .map(|edge| edge.dem_edge_index)
                .collect::<Vec<_>>(),
            vec![0, 0, 1]
        );
        assert_eq!(
            edges
                .iter()
                .map(|edge| edge.probability)
                .collect::<Vec<_>>(),
            vec![0.125, 0.125, 0.25]
        );
    }

    #[test]
    fn graphlike_decomposition_rejects_invalid_edge_index_and_empty_component_list() {
        let dem = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![edge(0.25, vec![10], vec![], "edge")],
        };

        let err = dem
            .compile_graphlike_problem_with_decomposition(&HashMap::from([(1, vec![])]))
            .unwrap_err();
        assert!(err.message().contains("index 1"));

        let err = dem
            .compile_graphlike_problem_with_decomposition(&HashMap::from([(0, vec![])]))
            .unwrap_err();
        assert!(err.message().contains("at least one component"));
    }

    #[test]
    fn graphlike_decomposition_rejects_invalid_components() {
        let dem = DetectorErrorModel {
            detectors: vec![
                Detector {
                    id: 10,
                    measurement_keys: Vec::new(),
                    coords: Vec::new(),
                },
                Detector {
                    id: 20,
                    measurement_keys: Vec::new(),
                    coords: Vec::new(),
                },
                Detector {
                    id: 30,
                    measurement_keys: Vec::new(),
                    coords: Vec::new(),
                },
            ],
            observables: vec![LogicalObservable {
                id: 7,
                measurement_keys: Vec::new(),
                pauli_qubits: Vec::new(),
                pauli: String::new(),
            }],
            edges: vec![edge(0.25, vec![10, 20, 30], vec![7], "hyper")],
        };

        let cases = [
            (
                vec![GraphlikeDecompositionComponent {
                    detectors: vec![10, 10],
                    observables: vec![],
                }],
                "empty after GF(2)",
            ),
            (
                vec![GraphlikeDecompositionComponent {
                    detectors: vec![],
                    observables: vec![7],
                }],
                "pure logical component",
            ),
            (
                vec![GraphlikeDecompositionComponent {
                    detectors: vec![10, 20, 30],
                    observables: vec![7],
                }],
                "expected at most two",
            ),
            (
                vec![GraphlikeDecompositionComponent {
                    detectors: vec![99],
                    observables: vec![],
                }],
                "unknown detector id 99",
            ),
            (
                vec![GraphlikeDecompositionComponent {
                    detectors: vec![10],
                    observables: vec![99],
                }],
                "unknown logical observable id 99",
            ),
        ];
        for (components, expected) in cases {
            let err = dem
                .compile_graphlike_problem_with_decomposition(&HashMap::from([(0, components)]))
                .unwrap_err();
            assert!(
                err.message().contains(expected),
                "expected {expected:?} in {:?}",
                err.message()
            );
        }
    }

    #[test]
    fn graphlike_decomposition_rejects_xor_mismatch() {
        let dem = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![edge(0.25, vec![10, 20, 30], vec![], "hyper")],
        };
        let decomposition = HashMap::from([(
            0,
            vec![
                GraphlikeDecompositionComponent {
                    detectors: vec![10, 20],
                    observables: vec![],
                },
                GraphlikeDecompositionComponent {
                    detectors: vec![20, 30],
                    observables: vec![],
                },
            ],
        )]);

        let err = dem
            .compile_graphlike_problem_with_decomposition(&decomposition)
            .unwrap_err();

        assert!(err.message().contains("does not reproduce"));
    }

    #[test]
    fn graphlike_problem_preserves_detector_coords() {
        let problem = dem().compile_graphlike_problem().unwrap();

        assert_eq!(problem.detector_ids(), &[5, 2, 9]);
        assert_eq!(
            problem.detector_coords(),
            &[vec![5.0, 0.0], vec![2.0, 0.0], Vec::<f64>::new()]
        );
    }

    #[test]
    fn graphlike_problem_rejects_undetectable_logical_edges() {
        let dem = DetectorErrorModel {
            detectors: Vec::new(),
            observables: vec![LogicalObservable {
                id: 0,
                measurement_keys: Vec::new(),
                pauli_qubits: Vec::new(),
                pauli: String::new(),
            }],
            edges: vec![edge(0.3, vec![], vec![0], "logical")],
        };

        let err = dem.compile_graphlike_problem().unwrap_err();

        assert!(err.message().contains("undetectable logical edge"));
    }

    #[test]
    fn binary_linear_problem_matches_dem_flips() {
        let problem = dem().compile_binary_linear_problem().unwrap();

        assert_eq!(problem.h.row_count, 3);
        assert_eq!(
            problem.detector_coords,
            vec![vec![5.0, 0.0], vec![2.0, 0.0], Vec::<f64>::new()]
        );
        assert_eq!(problem.h.col_count, 2);
        assert_eq!(problem.h.entries, vec![(1, 0), (2, 0), (0, 1)]);
        assert_eq!(problem.f.entries, vec![(0, 0)]);
        assert_eq!(problem.probabilities, vec![0.1, 0.2]);
        assert_eq!(problem.dem_edge_indices, vec![0, 1]);
    }

    #[test]
    fn canonical_problem_views_reduce_edge_targets_by_parity() {
        let dem = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![
                edge(1.0, vec![1, 1], vec![9, 9], "cancelled"),
                edge(0.5, vec![4, 2, 4], vec![8, 8, 7], "odd"),
            ],
        };

        let indexed = dem.compile_indexed().unwrap();
        let binary = dem.compile_binary_linear_problem().unwrap();

        assert_eq!(indexed.detector_ids, vec![1, 4, 2]);
        assert_eq!(indexed.detector_coords, vec![vec![], vec![], vec![]]);
        assert_eq!(indexed.observable_ids, vec![9, 8, 7]);
        assert!(indexed.edges[0].detectors.is_empty());
        assert!(indexed.edges[0].observables.is_empty());
        assert_eq!(indexed.edges[1].detectors, vec![2]);
        assert_eq!(indexed.edges[1].observables, vec![2]);
        assert_eq!(binary.h.entries, vec![(2, 1)]);
        assert_eq!(binary.f.entries, vec![(2, 1)]);
    }

    #[test]
    fn graphlike_classification_uses_parity_reduced_support() {
        let graphlike = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![edge(0.25, vec![1, 2, 3, 2], vec![], "reduced")],
        };
        let hypergraph = DetectorErrorModel {
            detectors: Vec::new(),
            observables: Vec::new(),
            edges: vec![edge(0.25, vec![1, 2, 3, 2, 4], vec![], "hyper")],
        };

        assert!(graphlike.is_graphlike());
        assert_eq!(
            graphlike
                .compile_graphlike_problem()
                .unwrap()
                .edge(0)
                .unwrap()
                .detectors()
                .collect::<Vec<_>>(),
            vec![0, 2],
        );
        assert!(!hypergraph.is_graphlike());
        assert!(hypergraph.compile_graphlike_problem().is_err());
    }

    #[test]
    fn compact_graphlike_problem_round_trips_owned_edges_and_native_view() {
        let problem = dem().compile_graphlike_problem().unwrap();
        let owned = problem
            .iter_edges()
            .map(GraphlikeEdgeRef::to_owned)
            .collect::<Vec<_>>();

        assert_eq!(owned.len(), 2);
        assert_eq!(owned[0].detectors, vec![1, 2]);
        assert_eq!(owned[0].fault_observables, vec![0]);
        assert_eq!(
            problem.edge(1).unwrap().detectors().collect::<Vec<_>>(),
            vec![0]
        );

        let view = problem.native_view();
        assert_eq!(view.abi_version, NATIVE_GRAPHLIKE_PROBLEM_ABI_VERSION);
        assert_eq!(
            view.struct_size,
            mem::size_of::<FaultScopeNativeGraphlikeProblemV1>()
        );
        assert_eq!(
            view.edge_struct_size,
            mem::size_of::<FaultScopeNativeGraphlikeEdgeV1>()
        );
        assert_eq!(view.detector_count, 3);
        assert_eq!(view.observable_count, 1);
        assert_eq!(view.edge_count, 2);
        assert_eq!(view.fault_observable_count, 1);
        let native_edges = unsafe { std::slice::from_raw_parts(view.edges, view.edge_count) };
        assert_eq!(native_edges[0].detector_count, 2);
        assert_eq!(native_edges[0].detector0, 1);
        assert_eq!(native_edges[0].detector1, 2);
        assert_eq!(native_edges[0].fault_observable_offset, 0);
        assert_eq!(native_edges[0].fault_observable_count, 1);
    }

    #[test]
    fn graphlike_constructor_validates_metadata_and_canonicalizes_edge_parity() {
        let problem = GraphlikeDecodingProblem::new(
            vec![10, 20],
            vec![vec![], vec![]],
            vec![0, 1],
            vec![GraphlikeEdge {
                detectors: vec![1, 0, 1],
                fault_observables: vec![1, 0, 1],
                probability: 0.25,
                dem_edge_index: 7,
            }],
        )
        .unwrap();
        let edge = problem.edge(0).unwrap();
        assert_eq!(edge.detectors().collect::<Vec<_>>(), vec![0]);
        assert_eq!(edge.fault_observables().collect::<Vec<_>>(), vec![0]);
        assert_eq!(edge.weight(), log_likelihood_ratio(0.25));

        let err = GraphlikeDecodingProblem::new(vec![10], vec![], vec![], vec![]).unwrap_err();
        assert!(err.message().contains("coordinate count"));

        let err = GraphlikeDecodingProblem::new(
            vec![10],
            vec![vec![]],
            vec![],
            vec![GraphlikeEdge {
                detectors: vec![0],
                fault_observables: vec![],
                probability: f64::NAN,
                dem_edge_index: 9,
            }],
        )
        .unwrap_err();
        assert!(err.message().contains("probability must be in [0, 1]"));
    }

    #[test]
    fn compiled_views_reject_duplicate_declarations() {
        let mut dem = dem();
        dem.detectors.push(dem.detectors[0].clone());

        let err = dem.compile_indexed().unwrap_err();

        assert_eq!(err.message(), "detector ids must be unique");
    }
}