fathomdb_schema/

lib.rs

//! **FathomDB schema** — the versioned migration registry and bootstrap.
//!
//! An internal leaf crate of the FathomDB workspace. It owns `SCHEMA_VERSION`,
//! the ordered `MIGRATIONS` table, and the routine that brings an on-disk
//! SQLite database up to the current version. `fathomdb-engine` calls it on the
//! open path; **application code should depend on the `fathomdb` facade crate
//! instead** and never invoke migration directly.
//!
//! The on-disk sentinel is SQLite's `PRAGMA user_version`. A migration step is
//! applied inside one `BEGIN IMMEDIATE` together with the version bump, so a
//! crash mid-step rolls back and the step re-runs whole.
//!
//! ⚠ Most steps are accretive, but not all are. Step 23 (TC-33) recreates
//! `canonical_edges` with INTEGER epoch-second temporal columns and **does not
//! migrate the data**: existing edge rows do not survive and no stored ISO-8601
//! value is converted. Nodes are unaffected. Anything that describes upgrading
//! an existing workspace must disclose this.

use std::fmt::{Display, Formatter};
use std::time::Instant;

use rusqlite::Connection;

pub const SCHEMA_VERSION: u32 = 25;

/// SQLite `PRAGMA` name carrying the on-disk schema-version sentinel.
///
/// Public on-disk surface per `dev/interfaces/wire.md` § Schema-version
/// sentinel; advanced by successful migrations per `dev/design/migrations.md`.
pub const PRAGMA_USER_VERSION: &str = "user_version";

/// Suffix of the canonical SQLite database file (`<db-name>.sqlite`).
pub const SQLITE_SUFFIX: &str = ".sqlite";

/// Suffix of the SQLite write-ahead log file (`<db-name>.sqlite-wal`).
pub const WAL_SUFFIX: &str = "-wal";

/// Suffix of the sidecar lock file (`<db-name>.sqlite.lock`).
///
/// Per `dev/design/bindings.md` § 7, this sidecar flock is the load-bearing
/// cross-process exclusion layer; it surfaces lock contention before SQLite
/// I/O begins.
pub const LOCK_SUFFIX: &str = ".lock";

/// Suffix of the optional SQLite rollback journal file
/// (`<db-name>.sqlite-journal`).
pub const JOURNAL_SUFFIX: &str = "-journal";

#[must_use]
pub fn bootstrap_steps() -> &'static [&'static str] {
    &["create canonical tables", "register projection metadata", "seed rewrite-era configuration"]
}

/// Canonical tables owned by the rewrite-era schema, in stable display
/// order. Excludes FTS, vec0, and projection shadow tables (re-derivable
/// from canonical state) and internal `_fathomdb_*` metadata.
///
/// `doctor dump-row-counts` enumerates this set; `doctor dump-schema`
/// uses it to order canonical tables ahead of derived/internal ones.
pub const CANONICAL_TABLES: &[&str] = &[
    "canonical_nodes",
    "canonical_edges",
    "operational_collections",
    "operational_mutations",
    "operational_state",
];

#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub struct Migration {
    pub step_id: u32,
    pub sql: &'static str,
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct MigrationStepReport {
    pub step_id: u32,
    pub duration_ms: Option<u64>,
    pub failed: bool,
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct MigrationReport {
    pub schema_version_before: u32,
    pub schema_version_after: u32,
    pub migration_steps: Vec<MigrationStepReport>,
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct MigrationFailureReport {
    pub schema_version_before: u32,
    pub schema_version_current: u32,
    pub migration_steps: Vec<MigrationStepReport>,
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub enum MigrationError {
    IncompatibleSchemaVersion { seen: u32, supported: u32 },
    MigrationError(MigrationFailureReport),
    Storage { message: &'static str },
}

impl Display for MigrationError {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::IncompatibleSchemaVersion { seen, supported } => {
                write!(f, "database schema version {seen} is incompatible with supported version {supported}")
            }
            Self::MigrationError(report) => write!(
                f,
                "schema migration failed at step {}",
                report.migration_steps.last().map_or(0, |step| step.step_id)
            ),
            Self::Storage { message } => write!(f, "schema storage error: {message}"),
        }
    }
}

impl std::error::Error for MigrationError {}

pub const MIGRATIONS: &[Migration] = &[
    Migration {
        step_id: 1,
        sql: "CREATE TABLE IF NOT EXISTS _fathomdb_schema_meta(key TEXT PRIMARY KEY, value TEXT NOT NULL)",
    },
    Migration {
        step_id: 2,
        sql: "CREATE TABLE IF NOT EXISTS _fathomdb_migrations(step_id INTEGER PRIMARY KEY, applied_at_ms INTEGER NOT NULL);
              CREATE TABLE IF NOT EXISTS canonical_nodes(write_cursor INTEGER NOT NULL, kind TEXT NOT NULL, body TEXT NOT NULL);
              CREATE TABLE IF NOT EXISTS canonical_edges(write_cursor INTEGER NOT NULL, kind TEXT NOT NULL, from_id TEXT NOT NULL, to_id TEXT NOT NULL);",
    },
    Migration {
        step_id: 3,
        sql: "CREATE TABLE IF NOT EXISTS _fathomdb_embedder_profiles(profile TEXT PRIMARY KEY, name TEXT NOT NULL, revision TEXT NOT NULL, dimension INTEGER NOT NULL)",
    },
    Migration {
        step_id: 4,
        sql: "CREATE TABLE IF NOT EXISTS operational_collections(
                  name TEXT PRIMARY KEY,
                  kind TEXT NOT NULL CHECK(kind IN ('append_only_log', 'latest_state')),
                  schema_json TEXT NOT NULL,
                  retention_json TEXT NOT NULL,
                  format_version INTEGER NOT NULL,
                  created_at INTEGER NOT NULL
              );
              CREATE TABLE IF NOT EXISTS operational_mutations(
                  id INTEGER PRIMARY KEY AUTOINCREMENT,
                  collection_name TEXT NOT NULL,
                  record_key TEXT NOT NULL,
                  op_kind TEXT NOT NULL CHECK(op_kind = 'append'),
                  payload_json TEXT NOT NULL,
                  schema_id TEXT,
                  write_cursor INTEGER NOT NULL
              );
              CREATE TABLE IF NOT EXISTS operational_state(
                  collection_name TEXT NOT NULL,
                  record_key TEXT NOT NULL,
                  payload_json TEXT NOT NULL,
                  schema_id TEXT,
                  write_cursor INTEGER NOT NULL,
                  PRIMARY KEY(collection_name, record_key)
              );
              CREATE TABLE IF NOT EXISTS _fathomdb_open_state(key TEXT PRIMARY KEY, value TEXT NOT NULL);
              INSERT OR IGNORE INTO operational_collections(
                  name, kind, schema_json, retention_json, format_version, created_at
              ) VALUES (
                  'projection_failures',
                  'append_only_log',
                  '{\"type\":\"object\"}',
                  '{}',
                  1,
                  0
              );",
    },
    Migration {
        step_id: 5,
        sql: "CREATE VIRTUAL TABLE IF NOT EXISTS search_index USING fts5(
                  body,
                  kind UNINDEXED,
                  write_cursor UNINDEXED
              );",
    },
    Migration {
        step_id: 6,
        sql: "CREATE TABLE IF NOT EXISTS _fathomdb_projection_state(
                  kind TEXT PRIMARY KEY,
                  last_enqueued_cursor INTEGER NOT NULL DEFAULT 0,
                  updated_at INTEGER NOT NULL DEFAULT 0
              );
              CREATE TABLE IF NOT EXISTS _fathomdb_vector_kinds(
                  kind TEXT PRIMARY KEY,
                  profile TEXT NOT NULL,
                  created_at INTEGER NOT NULL DEFAULT 0
              );
              CREATE TABLE IF NOT EXISTS _fathomdb_vector_rows(
                  rowid INTEGER PRIMARY KEY,
                  kind TEXT NOT NULL,
                  write_cursor INTEGER NOT NULL UNIQUE
              );",
    },
    Migration {
        step_id: 7,
        sql: "CREATE TABLE IF NOT EXISTS _fathomdb_projection_terminal(
                  write_cursor INTEGER PRIMARY KEY,
                  state TEXT NOT NULL CHECK(state IN ('failed', 'up_to_date'))
              );",
    },
    // Phase 9 Pack B — REQ-026 / AC-028a/b/c / AC-042 recovery seam.
    // `source_id` is nullable; existing canonical rows back-fill to NULL,
    // so reads from older callers stay schema-stable. REQ-045 accretion
    // offset is documented in `migrations/008_source_id.sql` as inherently
    // impossible for this slice (every existing canonical column is
    // load-bearing for replay / projections / recovery locators); the
    // next schema-touching pack carries the offset budget for two adds.
    Migration {
        step_id: 8,
        sql: "ALTER TABLE canonical_nodes ADD COLUMN source_id TEXT;
              ALTER TABLE canonical_edges ADD COLUMN source_id TEXT;
              CREATE INDEX IF NOT EXISTS canonical_nodes_source_id_idx
                  ON canonical_nodes(source_id);
              CREATE INDEX IF NOT EXISTS canonical_edges_source_id_idx
                  ON canonical_edges(source_id);",
    },
    // 0.7.0 Pack 1 — Vector binary-quantization data encoding.
    // Per `dev/design/0.7.0-vector-quant-pack1.md` D4 (fix-3). Stages
    // the existing f32 corpus + kind mapping into a regular SQL table,
    // drops + recreates `vector_default` with the new schema (sibling
    // `embedding_bin bit[768]`, `source_type TEXT partition key`,
    // `kind TEXT`, `created_at INTEGER`), then repopulates with
    // SQL-side `vec_quantize_binary` and the D3 CASE mapping. A
    // prefix CHECK-constraint preflight aborts the migration if any
    // `_fathomdb_vector_rows.kind` is outside the locked vocabulary.
    //
    // `<dim>=768` is hardcoded against the default profile
    // (`load_default_profile` -> `DEFAULT_EMBEDDER_DIMENSION` in
    // fathomdb-engine). The design notes this constraint and defers
    // a runtime-dim migration to 0.7.1.
    Migration {
        step_id: 9,
        // SQL-side: D4 fix-3.1 preflight only. The vec0 reshape itself is
        // dim-aware and lives in the engine crate's
        // `ensure_vector_partition_pack1` (called by `ensure_vector_partition`
        // immediately after `migrate_with_event_sink` returns). Splitting the
        // preflight (SQL, in-tx with `apply_one`) from the reshape (Rust,
        // dim-driven by `_fathomdb_embedder_profiles.dimension`) is required
        // because `fathomdb-schema::Migration` is a `&'static str` with no
        // runtime parameterization, and the existing dim=8 / dim=384 test
        // suite must stay GREEN. The reshape is idempotent across crashes:
        // if open fails between this step's commit (user_version=9) and the
        // Rust reshape, the next open re-detects the old shape and replays
        // the reshape. See dev/plans/runs/0.7.0-PVQ-P1-IMPL-output.json
        // for the design-memo deviation note.
        sql: "CREATE TEMP TABLE _vec0_migration_assertion(
                  check_passes INTEGER NOT NULL CHECK(check_passes = 1)
              );
              INSERT INTO _vec0_migration_assertion(check_passes)
                  SELECT CASE WHEN EXISTS (
                      SELECT 1 FROM _fathomdb_vector_rows
                      WHERE kind NOT IN ('email','article','paper','meeting','note','todo','doc')
                  ) THEN 0 ELSE 1 END;
              DROP TABLE _vec0_migration_assertion;",
    },
    // 0.7.1 EU-5a2 — mean-centering schema column.
    // Per `dev/design/embedder.md` §0.2: nullable BLOB holding the
    // pinned per-workspace mean vector for the default profile. Byte
    // length, when non-NULL, MUST equal `4 * dimension` (f32 little-endian).
    // Pure additive ALTER; SQLite stores NULL for the pre-existing row.
    // Lifecycle (compute-once-on-first-ingest threshold-pin) is in the
    // engine crate, not the schema layer.
    Migration {
        step_id: 10,
        sql: "ALTER TABLE _fathomdb_embedder_profiles ADD COLUMN mean_vec BLOB",
    },
    // 0.8.0 Slice 5 (G1) — global FTS5 tokenizer-default upgrade.
    // Per `dev/plans/0.8.0-implementation.md` § "Slice 5" and the design
    // memo `dev/design/0.8.0-slice-5-G1-design.md`. Migrations are
    // forward-only and immutable, and FTS5 has no `ALTER … tokenize`, so the
    // tokenizer default is upgraded by dropping and recreating the
    // `search_index` virtual table rather than editing the step-5 DDL (which
    // would change the tokenizer for new DBs only). The drop+recreate leaves
    // the FTS index empty on a migrated DB; the engine re-tokenizes from the
    // canonical source rows immediately after this step lands (open path,
    // `reproject_search_index_after_tokenizer_upgrade`) — projection-only, no
    // source-record migration. `DROP TABLE` already satisfies the accretion
    // guard's `names_removal` branch; the exemption marker is carried to
    // document intent and match the established pattern.
    Migration {
        step_id: 11,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: tokenizer-default upgrade (drop+recreate FTS5 projection; no source-record migration)
              DROP TABLE IF EXISTS search_index;
              CREATE VIRTUAL TABLE search_index USING fts5(
                  body,
                  kind UNINDEXED,
                  write_cursor UNINDEXED,
                  tokenize = 'porter unicode61 remove_diacritics 2'
              );",
    },
    // 0.8.0 Slice 15 (G0 KEYSTONE) — transaction-time canonical-identity
    // substrate. Per `dev/adr/ADR-0.8.0-canonical-identity-substrate.md`
    // (SIGNED 2026-06-03) and `dev/design/slice-15-g0-design.md`. Two additive
    // nullable columns on BOTH canonical tables: `logical_id TEXT` (stable
    // cross-re-ingestion identity; NULL = legacy/own-identity row) and
    // `superseded_at INTEGER` (transaction-time tombstone; NULL = active row).
    // A partial UNIQUE INDEX `(logical_id) WHERE superseded_at IS NULL` per table
    // enforces one active version per logical id — scoped to `logical_id` ALONE
    // (Decision 5, HITL-SIGNED 2026-06-05; `kind` is payload/classification on
    // nodes and relationship-type on edges, NEVER an identity-scope component).
    // NULL-safe, so the many legacy NULL-logical_id rows never collide (SQLite
    // treats each NULL as distinct; load-bearing). The folded G4/G5 read indexes
    // (`canonical_nodes(kind)`, `canonical_edges(from_id)/(to_id)`) ride this one
    // accretion offset budget. Pure additive ALTER (no DROP) → the exemption
    // marker is REQUIRED (the accretion guard rejects ADD COLUMN without it);
    // legacy rows read NULL with no data migration / re-open (in-place ALTER).
    // Step-12 amended IN PLACE (Slice 31, no SCHEMA_VERSION bump): already-migrated
    // local v12 DBs keep the old compound index until rebuilt (HITL: disposable).
    Migration {
        step_id: 12,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: G0 transaction-time identity substrate
              ALTER TABLE canonical_nodes ADD COLUMN logical_id TEXT;
              ALTER TABLE canonical_nodes ADD COLUMN superseded_at INTEGER;
              ALTER TABLE canonical_edges ADD COLUMN logical_id TEXT;
              ALTER TABLE canonical_edges ADD COLUMN superseded_at INTEGER;
              CREATE UNIQUE INDEX IF NOT EXISTS canonical_nodes_logical_active_idx
                  ON canonical_nodes(logical_id) WHERE superseded_at IS NULL;
              CREATE UNIQUE INDEX IF NOT EXISTS canonical_edges_logical_active_idx
                  ON canonical_edges(logical_id) WHERE superseded_at IS NULL;
              CREATE INDEX IF NOT EXISTS canonical_nodes_kind_idx
                  ON canonical_nodes(kind);
              CREATE INDEX IF NOT EXISTS canonical_edges_from_id_idx
                  ON canonical_edges(from_id);
              CREATE INDEX IF NOT EXISTS canonical_edges_to_id_idx
                  ON canonical_edges(to_id);",
    },
    // 0.8.0 Slice 33 (G3 / F4-READ) — op-store paginated read-back hardening.
    // Per `dev/design/slice-33-cursor-hardening-design.md`. The governed
    // `read.collection` / `read.mutations` SELECT is
    // `WHERE collection_name = ?1 AND id > ?2 ORDER BY id LIMIT ?3`. Without an
    // index on `collection_name`, SQLite rides the `id` PRIMARY KEY (EXPLAIN:
    // `SEARCH … USING INTEGER PRIMARY KEY (rowid>?)`), scanning the id-ordered
    // log and filtering `collection_name` row-by-row — O(rows-scanned) for a
    // small collection inside a large multi-collection log. The composite
    // `(collection_name, id)` index makes the plan index-driven (EXPLAIN:
    // `SEARCH … USING INDEX operational_mutations_collection_id_idx
    // (collection_name=? AND id>?)`): the leading equality on `collection_name`
    // fixes the prefix, the trailing `id` serves BOTH the after-id cursor range
    // and `ORDER BY id` with no temp B-tree — O(page). Pure additive
    // `CREATE INDEX` (no table/column add, no DROP, no table reshape), so the
    // accretion guard does not flag it and no exemption marker is required.
    Migration {
        step_id: 13,
        sql: "CREATE INDEX IF NOT EXISTS operational_mutations_collection_id_idx
                  ON operational_mutations(collection_name, id);",
    },
    // 0.8.1 Slice 15 (G11) — fact-on-edge enrichment + edge projectability.
    // Per `dev/adr/ADR-0.8.1-graph-substrate-g11-migration.md` (HITL-SIGNED
    // 2026-06-13). Five additive nullable columns on `canonical_edges`:
    //   `body`              — the fact/relationship text for FTS + vector projection
    //   `t_valid`           — event valid-time; NULL = "still valid"
    //   `t_invalid`         — event invalid-time; NULL = "still valid"
    //     (SUPERSEDED BY STEP 23 / TC-33: both were ISO-8601 TEXT here and are
    //     now INTEGER epoch seconds with a `typeof` CHECK. The "NULL = still
    //     valid" semantic is UNCHANGED and load-bearing — see step 23 for why
    //     `NOT NULL` would be the wrong structural spelling.)
    //   `confidence`        — extraction confidence ∈ [0.0, 1.0] from the harness
    //   `extractor_model_id`— opaque model id from BYO-LLM harness `ready.model`
    // All five are nullable; pre-G11 rows read NULL (no data migration required).
    // Also creates `search_index_edges` FTS5 virtual table for edge-body FTS
    // projection (Option B: separate table, no modification to the existing
    // `search_index` path). MIGRATION-ACCRETION-EXEMPTION required for ADD COLUMN.
    Migration {
        step_id: 14,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: G11 edge enrichment (5 additive nullable columns + edge FTS table)
              ALTER TABLE canonical_edges ADD COLUMN body TEXT;
              ALTER TABLE canonical_edges ADD COLUMN t_valid TEXT;
              ALTER TABLE canonical_edges ADD COLUMN t_invalid TEXT;
              ALTER TABLE canonical_edges ADD COLUMN confidence REAL;
              ALTER TABLE canonical_edges ADD COLUMN extractor_model_id TEXT;
              CREATE VIRTUAL TABLE IF NOT EXISTS search_index_edges USING fts5(
                  body,
                  kind UNINDEXED,
                  write_cursor UNINDEXED,
                  tokenize = 'porter unicode61 remove_diacritics 2'
              );",
    },
    // 0.8.1 Slice 30 (R3) SCHEMA-GATE-1 — temporal_fallback provenance flag.
    // HITL-SIGNED 2026-06-13: approved additive schema bump.
    // Edges whose `t_valid` was defaulted to `created_at` by the ELPS extractor
    // (not text-grounded) carry this flag so the graph-arm BFS can exclude them
    // from temporal queries. NULL = not a fallback (pre-column rows and edges
    // written without the flag are treated as NOT temporal_fallback — safe default
    // since they were written before provenance tracking existed or via a direct
    // write where the caller owns the t_valid).
    // MIGRATION-ACCRETION-EXEMPTION required for ADD COLUMN.
    Migration {
        step_id: 15,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: R3 temporal_fallback provenance flag (additive nullable BOOLEAN column)
              ALTER TABLE canonical_edges ADD COLUMN temporal_fallback INTEGER;",
    },
    // 0.8.14 Slice 5 (EXP-S KEYSTONE) — kind-tagged coexisting-index substrate.
    // Per `dev/adr/ADR-0.8.14-exp-s-kind-tagged-coexisting-index-substrate.md` D1
    // (RATIFIED 2026-07-03) and `dev/plans/plan-0.8.14.md` §2 (R-SUB-1/R-SUB-3).
    // Adds `row_kind` — a SEPARATE structural-role axis on `canonical_nodes`,
    // orthogonal to the doc-type `kind` (email/article/paper/meeting/note/todo/
    // doc/edge_fact). Vocabulary: `leaf` (normal record — the DEFAULT, which
    // preserves current behavior for every existing/normal row), `coverage`
    // (coverage/summary rows), `graph` (graph structural rows). D1 is explicit:
    // this must NOT overload the doc-type `kind` vocabulary or touch its three
    // hard-locked sites (engine `resolve_source_type` / `KIND_TO_SOURCE_TYPE_CASE_SQL`
    // / this crate's migration-9 preflight CHECK). NOT NULL DEFAULT 'leaf' is a
    // constant default, so pre-existing rows back-fill to `leaf` in-place (no data
    // migration / re-open) and the migration is forward-only. Additive ADD COLUMN
    // (no DROP) → the accretion guard REQUIRES the exemption marker. No vec0
    // embedding/quant/pooling change (ADR §D6): this step does NOT rewrite vec0
    // rows, so the eu7 fidelity gate stays a documented no-op at Slice 20.
    Migration {
        step_id: 16,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: EXP-S row_kind structural-role tag (additive NOT NULL DEFAULT 'leaf' column; separate axis from doc-type kind)
              ALTER TABLE canonical_nodes ADD COLUMN row_kind TEXT NOT NULL DEFAULT 'leaf';",
    },
    // 0.8.14 Slice 10 (F5 — fielded FTS / BM25F) — multi-column FTS5 index.
    // Per `dev/adr/ADR-0.8.1-deferred-f5-fielded-fts-bm25f.md` §3.1 and
    // `dev/adr/ADR-0.8.14-exp-s-kind-tagged-coexisting-index-substrate.md` §D4
    // (RATIFIED 2026-07-03; F5 co-lands by the §D8 HITL override) and
    // `dev/plans/plan-0.8.14.md` §2 (R-F5-1 / R-SUB-3). Creates a NEW FTS5 virtual
    // table `search_index_v2` over the doc-type node fields `kind` / `body` /
    // `status`, so a BM25F query can weight each field independently
    // (`bm25(search_index_v2, W_kind, W_body, W_status)`), riding the EXP-S
    // substrate. This is ADDITIVE and coexists with the single-column body-only
    // `search_index` (which is RETAINED, byte-unchanged — the existing RRF/lexical
    // query path keeps using it, so its determinism pins are untouched): the new
    // table is a second coexisting index in the "one store, many indexes"
    // substrate, exactly like `search_index_edges` (step 14, Option B). FTS5 has
    // no in-place column-add, so BM25F requires a new virtual table + an O(N)
    // re-index; the co-land with step 16 means an old DB pays ONE re-index window
    // (`SCHEMA_VERSION` 15 -> 17 in one open). The `status` field is derived from
    // the JSON body's `$.status`, guarded by `json_valid` so non-JSON bodies
    // index an empty status; this is F5's own `$.status`-derived field, NOT
    // the value the shipped G10 SearchFilter reads (G10 reads vec0 `status`,
    // still the empty sentinel). The
    // `write_cursor` UNINDEXED column mirrors `search_index` for the
    // canonical-row join (rowid==write_cursor identity is preserved by the
    // engine write path; the vec0 corpus is NOT touched, so the eu7 fidelity gate
    // stays a documented no-op at Slice 20 — ADR-0.8.14 §D6). `CREATE VIRTUAL
    // TABLE` does not trip the accretion guard (it fires only on `CREATE TABLE` /
    // `ADD COLUMN`), but the exemption marker is carried to document the additive
    // re-index intent and match the step-11/step-14 virtual-table precedent.
    Migration {
        step_id: 17,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: F5 fielded FTS (new multi-column search_index_v2 FTS5 table + O(N) re-index; search_index retained)
              CREATE VIRTUAL TABLE IF NOT EXISTS search_index_v2 USING fts5(
                  kind,
                  body,
                  status,
                  write_cursor UNINDEXED,
                  tokenize = 'porter unicode61 remove_diacritics 2'
              );
              INSERT INTO search_index_v2(kind, body, status, write_cursor)
                  SELECT
                      kind,
                      body,
                      CASE WHEN json_valid(body)
                           THEN COALESCE(json_extract(body, '$.status'), '')
                           ELSE '' END,
                      write_cursor
                  FROM canonical_nodes;",
    },
    // 0.8.16 Slice 5 (F9 KEYSTONE) — node-level importance ranking scalar.
    // Per `dev/adr/ADR-0.8.16-f9-importance-confidence-ranking.md` §2.1
    // (SIGNED 2026-07-08) and `dev/plans/plan-0.8.16.md` §2 (R-F9-1/R-F9-4).
    // Adds `importance REAL` on `canonical_nodes` — a caller-supplied ranking
    // scalar, symmetric with the existing genuine-NULL `canonical_edges.confidence`
    // (step-14). 3-way sentinel (frozen): `NULL` = never assigned (graceful-absent,
    // ranks NEUTRAL — the OPP-12 Q6a graceful-absent state, load-bearing for
    // R-F9-4); `0.0` = explicit floor/de-weight; `(0.0, 1.0]` = explicit importance.
    // Nullable, so pre-existing rows read NULL in-place (no data migration / re-open):
    // the graceful-absent default preserves current ranking for every existing row.
    // Additive `ADD COLUMN` (no DROP) → the accretion guard REQUIRES the exemption
    // marker. This step does NOT rewrite vec0 / vector rows (ADR §4 eu7 no-op basis):
    // it adds a scalar column only, so the eu7 fidelity gate stays a documented no-op.
    Migration {
        step_id: 18,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: F9 importance ranking scalar (additive nullable REAL; 3-way sentinel, NULL=graceful-absent)
              ALTER TABLE canonical_nodes ADD COLUMN importance REAL;",
    },
    // 0.8.18 Slice 5 (#5 vector-equivalence probe KEYSTONE) — the
    // `_fathomdb_embed_probe` self-check substrate. Per
    // `dev/adr/ADR-0.8.18-vector-equivalence-self-check.md` (SIGNED 2026-07-09)
    // and `dev/design/0.8.18-slice-0-vector-equivalence-publish-design.md` §U1
    // (R-VEQ-1). Creates a new internal table holding the 45 committed
    // equivalence probes, each with its **UN-centered f32 reference vector**
    // (`4 * dim` little-endian bytes) and the embedder identity that produced it.
    // The engine populates the 45 rows at first vector-kind registration (open
    // path, adjacent to `ensure_vector_partition`); this migration only creates
    // the empty table. **Store f32 ONLY — the Phase-1 mean-centered bits are
    // NEVER persisted** (they are recomputed at check time from the un-centered
    // reference + the live pinned `mean_vec`, U1-d). This step does NOT rewrite
    // vec0 / vector rows (eu7 no-op basis): it creates a fresh sidecar table only,
    // so the eu7 fidelity gate stays a documented no-op. `CREATE TABLE` adds
    // schema (no DROP) → the accretion guard REQUIRES the exemption marker.
    Migration {
        step_id: 19,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: #5 vector-equivalence probe substrate (new internal _fathomdb_embed_probe table; UN-centered f32 references only, NEVER persists P1 bits)
              CREATE TABLE IF NOT EXISTS _fathomdb_embed_probe(
                  probe_ordinal INTEGER PRIMARY KEY,
                  probe_text TEXT NOT NULL,
                  reference_vec BLOB NOT NULL,
                  embedder_name TEXT NOT NULL,
                  embedder_revision TEXT NOT NULL,
                  dim INTEGER NOT NULL
              );",
    },
    // 0.8.19 Slice 5 (OPP-12 record-lifecycle Phase-1 KEYSTONE) — the existence
    // axis. Per `dev/design/0.8.19-slice-0-opp12-phase1-design.md` §5 (the ONE
    // 19→20 migration) and `dev/plans/plan-0.8.19.md` §2 (R-EX-1/R-MIG-1). Adds
    // the two existence columns on `canonical_nodes`:
    //   `state`  — the `LifecycleState` enum, stored as TEXT. `NOT NULL DEFAULT
    //              'active'` so EVERY pre-existing row back-fills to `active`
    //              in-place (no data migration / re-open); the shipped corpus is
    //              wholly `active`, so the new default-read exclusion
    //              (`AND state = 'active'` co-located with `superseded_at IS NULL`
    //              at each retrieval site) is a documented NO-OP on it (eu7 no-op
    //              basis, design §9).
    //   `reason` — nullable advisory cause for the CURRENT state (quarantine cause
    //              for `pending`; delete cause for the delete-family). Engine never
    //              interprets it.
    // Plus `canonical_nodes_state_active_idx` — a PARTIAL index over active rows
    // keyed by `write_cursor` (the dominant retrieval/join key), serving the
    // active-only default-read hot path.
    // Scoped per F-23 ruling 1a: existence columns ONLY — NO surrogate-`logical_id`
    // backfill (anonymous rows keep `logical_id = NULL`; surrogate minting is
    // Phase-2/0.8.20). One migration per release (I-6). This step does NOT rewrite
    // vec0 / vector rows (eu7 no-op basis). Additive `ADD COLUMN` (no DROP) → the
    // accretion guard REQUIRES the exemption marker.
    Migration {
        step_id: 20,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: OPP-12 Phase-1 existence axis (state NOT NULL DEFAULT 'active' + nullable reason on canonical_nodes + active-only partial index; no surrogate backfill — F-23 ruling 1a)
              ALTER TABLE canonical_nodes ADD COLUMN state TEXT NOT NULL DEFAULT 'active';
              ALTER TABLE canonical_nodes ADD COLUMN reason TEXT;
              CREATE INDEX IF NOT EXISTS canonical_nodes_state_active_idx
                  ON canonical_nodes(write_cursor) WHERE state = 'active';",
    },
    // Step 21 (0.8.20 Slice 5c) — legacy provenance backfill, per
    // `dev/design/0.8.20-slice0-erasure-design.md` §4 work item 7 and
    // `dev/plans/plan-0.8.20.md` R-20-E8.
    //
    // Erasure runs through provenance: `excise_source` addresses rows BY
    // `source_id`, so a stored row with `source_id IS NULL` is reachable by no
    // erasure call at all — it is un-erasable. Pre-0.8.20 the public write type
    // carried `source_id: Option<String>` and a `None` landed NULL, so shipped
    // databases hold such rows. R-20-E3 closes the write path going forward
    // (`SourceId` makes the absence inexpressible); this step repairs the rows
    // already on disk by stamping them with the reserved
    // `_legacy:pre-0.8.20`, after which an operator can erase them.
    //
    // THE GATE IS EXACT, LOAD-BEARING AND **NODE-ONLY**: on `canonical_nodes`
    // the predicate is `WHERE source_id IS NULL AND logical_id IS NULL`; on
    // `canonical_edges` it is `WHERE source_id IS NULL` alone. The asymmetry is
    // deliberate, and the reason is that the gate's rationale holds for one
    // table and not the other.
    //
    // The rationale comes from the TC-11 pin (CLOSED): a GOVERNED row — one
    // carrying a `logical_id` — is addressable in its own right, because `purge`
    // reaches it BY `logical_id`. Stamping it with a shared `_legacy:`
    // provenance would make it collateral of an
    // `excise_source('_legacy:pre-0.8.20')` call aimed at anonymous rows, which
    // is precisely the over-erasure the pin forbids. That argument is sound FOR
    // NODES: governed nodes keep NULL `source_id` by design, and that is not a
    // gap.
    //
    // It is FALSE FOR EDGES. `purge` resolves its lifecycle target exclusively
    // through `canonical_nodes` (`SELECT state FROM canonical_nodes WHERE
    // logical_id = ?1 AND superseded_at IS NULL`) and then erases edges by
    // ENDPOINT (`from_id`/`to_id`) — it never resolves an edge by edge
    // `logical_id`. An edge `logical_id` is only a SUPERSESSION identity; it
    // confers no purge-addressability whatsoever. Applying the node gate to
    // edges therefore left legacy edges with `source_id IS NULL AND logical_id
    // IS NOT NULL` skipped by this backfill (⇒ unreachable by
    // `excise_source`/`erase_source`) AND not purge-addressable (⇒ unreachable
    // by `purge`), so they were erasable by NO verb and could only disappear
    // incidentally when a connected node happened to be purged. That defeats
    // R-20-E8, whose entire purpose is that legacy NULL-provenance rows become
    // erasable. (codex §9 P1; `legacy_backfill_covers_governed_edges`.)
    //
    // Back-filling an edge's `source_id` does NOT touch the TC-11 pin: the pin
    // forbids populating `logical_id` on an existing row and forbids re-deriving
    // a stored row's id-space, and this writes neither.
    //
    // The pin's enforcing invariant is also respected: this statement READS
    // `logical_id` as its predicate and NEVER writes one. No row transitions
    // `logical_id` NULL -> NOT NULL, and no stored row's id-space is re-derived
    // (`s21_backfill_populates_no_logical_id` asserts both).
    //
    // Rows that already carry provenance are untouched (`source_id IS NULL`
    // half of the predicate), so caller-supplied ids are never overwritten.
    //
    // No accretion exemption marker: this is a pure data `UPDATE` with no
    // `CREATE TABLE` / `ADD COLUMN`, so the guard does not fire (cf. step 13).
    // One migration per release (I-6).
    Migration {
        step_id: 21,
        sql: "UPDATE canonical_nodes
                 SET source_id = '_legacy:pre-0.8.20'
               WHERE source_id IS NULL AND logical_id IS NULL;
              UPDATE canonical_edges
                 SET source_id = '_legacy:pre-0.8.20'
               WHERE source_id IS NULL;",
    },
    // Step 22 (0.8.20 Slice 10b) — R-20-NV node validity window, per
    // `dev/plans/plan-0.8.20.md` §3 (R-20-NV). Adds the two world-time validity
    // columns on `canonical_nodes`:
    //   `valid_from`  — inclusive lower bound of the window.
    //   `valid_until` — EXCLUSIVE upper bound of the window.
    // The interval is HALF-OPEN: `[valid_from, valid_until)`. A node is valid at
    // instant `t` iff `(valid_from IS NULL OR valid_from <= t) AND (valid_until
    // IS NULL OR valid_until > t)`. NULL means UNBOUNDED on that side, so
    // NULL/NULL is "valid for all time". This convention is stated once here and
    // is the same one `ReadView::valid_as_of` compiles to at every read site.
    //
    // **UNITS: INTEGER epoch SECONDS (UTC).** At the time this step shipped it
    // DELIBERATELY DIVERGED from `canonical_edges.t_valid`/`t_invalid` (step 14),
    // which were then ISO-8601 TEXT compared through `datetime(...)`. The
    // divergence was intentional and flagged rather than silently resolved:
    //   (a) the release contract for R-20-NV specifies INTEGER windows;
    //   (b) INTEGER windows are directly comparable/indexable with no `datetime()`
    //       conversion per row, so the validity conjunct stays sargable against
    //       `canonical_nodes_validity_idx`;
    //   (c) the node-validity instant is a BOUND PARAMETER (`:now` seam), never a
    //       `datetime('now')` SQL literal, so node validity is deterministically
    //       testable — whereas the EDGE path then still inlined `datetime('now')`.
    //
    // **RESOLVED by step 23 (TC-33, HITL-RATIFIED 2026-07-21).** The divergence
    // this step escalated is now CLOSED: the edge columns are INTEGER epoch
    // seconds too, and the edge read sites bind the same `:now` seam described in
    // (c). Reason (c)'s "the shipped EDGE path still inlines `datetime('now')`"
    // and the step-22 SQL comment's "which are unchanged" are both HISTORICAL as
    // of step 23 — the migration SQL string is left verbatim because applied SQL
    // text is not rewritten, and this Rust comment carries the correction.
    //
    // Existing rows get NULL/NULL on both columns (SQLite `ADD COLUMN` with no
    // DEFAULT back-fills NULL in place, no table rewrite), i.e. unbounded ⇒
    // always valid ⇒ EVERY pre-existing row's default-view visibility is
    // UNCHANGED (asserted by `s22_preexisting_rows_stay_visible_in_default_view`
    // and, at the engine level, by the R-20-NV suite). This step does NOT rewrite
    // vec0 / vector rows (eu7 no-op basis).
    //
    // Crash-safety + idempotence come from the runner, exactly as for step 20:
    // `apply_one` wraps the batch AND the `PRAGMA user_version` bump in a single
    // `BEGIN IMMEDIATE`/`COMMIT`, so a crash mid-step rolls back to 21 and the
    // step re-runs whole; and `migrate_with_event_sink` only applies steps with
    // `step_id > user_version`, so a completed step never re-runs (which matters
    // because `ALTER TABLE ... ADD COLUMN` has no `IF NOT EXISTS` form).
    // One migration per release (I-6). Additive `ADD COLUMN` (no DROP) → the
    // accretion guard REQUIRES the exemption marker.
    Migration {
        step_id: 22,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: R-20-NV node validity window (valid_from/valid_until INTEGER epoch-seconds on canonical_nodes; NULL = unbounded; half-open [valid_from, valid_until); deliberately INTEGER, diverging from the ISO-8601 TEXT canonical_edges.t_valid/t_invalid, which are unchanged)
              ALTER TABLE canonical_nodes ADD COLUMN valid_from INTEGER;
              ALTER TABLE canonical_nodes ADD COLUMN valid_until INTEGER;
              CREATE INDEX IF NOT EXISTS canonical_nodes_validity_idx
                  ON canonical_nodes(valid_from, valid_until)
                  WHERE superseded_at IS NULL AND state = 'active';",
    },
    // 0.8.20 Slice 15c (TC-33) — edge temporal representation → INTEGER epoch
    // seconds, closing the divergence step 22 deliberately flagged above.
    // HITL-RATIFIED 2026-07-21 (`dev/plans/plan-0.8.20.md` §9 decision 3):
    // `t_valid`/`t_invalid` are INTEGER epoch seconds in STORAGE and on the
    // GOVERNED SDK SURFACE; the BYO-LLM EXTRACTOR boundary keeps ISO-8601 and is
    // normalised engine-side with HARD REJECTION.
    //
    // **Why the CHECKs, and why NOT `NOT NULL`.** The failure mode this step
    // exists to remove is FAIL-OPEN. A NULL `t_invalid` means "still valid", so
    // an unparseable timestamp that coerces to NULL silently RESURRECTS an
    // invalidated edge. Under the old TEXT column the junk failed CLOSED by
    // accident (`datetime('junk')` → NULL ⇒ the disjunct is falsy ⇒ the row
    // vanished from every read); moving to INTEGER would INVERT that polarity
    // unless junk is made unstorable. So the invariant is STRUCTURAL — a
    // `typeof(...)` CHECK — not merely upheld by call sites (cf. TC-28, an
    // invariant held only by call sites; not repeated here).
    // `NOT NULL` would be WRONG: NULL legitimately means "still valid" and that
    // shipped semantic must survive. `typeof(x) = 'integer'` makes junk
    // unstorable while preserving NULL-means-still-valid.
    //
    // **NO DATA MIGRATION (HITL 2026-07-21).** SQLite cannot change a column's
    // type in place, and cannot add a CHECK via `ALTER TABLE`, so both INTEGER
    // affinity and the structural CHECKs require RECREATING the table. Per the
    // ruling this is a PLAIN RECREATE: existing `canonical_edges` rows DO NOT
    // SURVIVE. Nothing is staged, converted, backfilled, or re-inserted, and no
    // stored ISO-8601 value is converted. FathomDB is pre-1.0 beta and 0.8.20 is
    // a coordinated breaking pair — users do not carry data across it.
    //
    // **Two consequences that DO need handling** (neither is a data migration —
    // one clears derived state, the other preserves a monotonic counter):
    //
    //   1. `search_index_edges` is edge-derived and would be left holding FTS
    //      rows for edges that no longer exist. Every reader JOINs it back to
    //      `canonical_edges` so orphans are inert, but they are dead weight and
    //      are cleared here.
    //   1b. The VECTOR projection of the dropped edges is ALSO row-owned and
    //      must be removed — it is NOT inert (fix-6, codex §9 P1). It has two
    //      halves (see the engine's `ROW_OWNED_PROJECTIONS`, class `Vector`):
    //        - `_fathomdb_vector_rows` — the sidecar/registry table (created by
    //          migration step 6, so it ALWAYS exists here). Its dropped-edge
    //          rows are deleted BELOW, scoped to edge cursors read from
    //          `canonical_edges` while it still exists (it also holds NODE
    //          sidecar rows, which MUST survive — so this is a scoped DELETE,
    //          not a truncate like `search_index_edges`).
    //        - `vector_default` — the vec0 virtual table that actually feeds
    //          KNN candidate selection. It is created by the ENGINE's dim-aware
    //          `ensure_vector_partition` AFTER `migrate` returns, so on a fresh
    //          DB (and in the schema crate's own migration tests) it does not
    //          exist yet and referencing it in this SQL would fail the step. Its
    //          orphaned edge rows are therefore pruned by the ENGINE right after
    //          `ensure_vector_partition`, matched against the sidecar this step
    //          clears. These orphans are NOT "made harmless by (2)": (2) only
    //          stops cursor REUSE; an orphaned `vector_default` row (whose
    //          `canonical_edges` row is gone) still occupies a top-K KNN
    //          candidate slot and is then discarded at hydration, silently
    //          returning too few vector results on an upgraded DB.
    //   2. `load_next_cursor` takes MAX(write_cursor) across canonical_nodes /
    //      canonical_edges / operational_mutations / operational_state. Dropping
    //      the edge rows can LOWER that high-water mark, so freshly allocated
    //      cursors would REUSE values that stale `_fathomdb_projection_terminal`
    //      / `_fathomdb_vector_rows` / vec0 rows still key on — silently marking
    //      a brand-new row as already-projected, so it never gets indexed. The
    //      old maximum is therefore RESERVED into `_fathomdb_open_state` and
    //      `load_next_cursor` folds it in. This preserves NO user data; it keeps
    //      an identifier counter monotonic.
    //      The `HAVING` is load-bearing: a bare aggregate over an EMPTY
    //      `canonical_edges` still returns one row, whose `MAX` is NULL, which
    //      violates `_fathomdb_open_state.value NOT NULL` — i.e. without it the
    //      step fails on EVERY fresh database.
    //   3. `write_cursor` is a SINGLE global sequence shared across nodes AND
    //      edges, and `advance_projection_cursor` (engine) walks the readiness
    //      watermark forward ONE value at a time, ONLY while the next cursor has
    //      a `_fathomdb_projection_terminal` row. A body-bearing edge whose
    //      vector projection had NOT completed at upgrade has NO terminal row; if
    //      step 23 dropped it we would leave a cursor value with no terminal and
    //      no owning row, so the projection cursor STALLS PERMANENTLY at that gap
    //      — and because the sequence is shared this also freezes advancement
    //      past SURVIVING node projections (every upgraded DB's `wait_for_idle` /
    //      search-freshness wedges). So BEFORE the DROP — while `canonical_edges`
    //      still exists to read — a terminal is recorded for every edge cursor
    //      that lacks one. This is projection-cursor STATE bookkeeping, NOT data
    //      preservation: the edge rows still do not survive; we only reconcile
    //      the engine's cursor state machine so it does not dangle on cursors
    //      whose rows we correctly dropped. It is COMPLEMENTARY to (2): (2) stops
    //      cursor REUSE below the old high-water mark; (3) stops cursor STALL on
    //      the dropped cursors themselves. Both are needed.
    //      The state token is `'up_to_date'`, NOT `'superseded'`. The terminal
    //      table (step 7) carries `CHECK(state IN ('failed','up_to_date'))` and
    //      the writer is `INSERT OR IGNORE`; under SQLite, `OR IGNORE` SKIPS a
    //      CHECK-violating row and returns no error, so a `'superseded'` backfill
    //      would be SILENTLY DROPPED and the cursor would still stall (a vacuous
    //      green). `'up_to_date'` is the CHECK-valid, non-`'failed'` terminal
    //      that honestly means "nothing left to project here" for a deleted row,
    //      and `INSERT OR IGNORE` leaves any already-present terminal untouched
    //      (the write_cursor PRIMARY KEY conflict is ignored).
    //
    // The recreate restores the full step-1→22 column set IN ORDER (positional
    // `row.get(i)` sites depend on it) and all four indexes, which `DROP TABLE`
    // removes with the table.
    //
    // Crash-safety/idempotence are the runner's, as for steps 20/22: `apply_one`
    // wraps the batch AND the `PRAGMA user_version` bump in one `BEGIN
    // IMMEDIATE`, so a crash mid-step rolls back to 22 and the step re-runs
    // whole. `check_migration_accretion` does not fire (the SQL names both
    // `CREATE TABLE` and `DROP TABLE`), but the exemption marker is carried for
    // documentation, matching the convention of the surrounding steps.
    Migration {
        step_id: 23,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: TC-33 edge temporal representation → INTEGER epoch seconds (recreate canonical_edges with INTEGER t_valid/t_invalid + typeof CHECKs so junk is UNSTORABLE; NULL still means \"still valid\"). NO DATA MIGRATION (HITL 2026-07-21): existing edge rows do NOT survive and no stored ISO-8601 value is converted.
              INSERT OR REPLACE INTO _fathomdb_open_state(key, value)
                  SELECT 'tc33_reserved_write_cursor',
                         CAST(MAX(write_cursor) AS TEXT)
                  FROM canonical_edges
                  HAVING MAX(write_cursor) IS NOT NULL;
              DELETE FROM search_index_edges;
              -- fix-4 (TC-33): mark every edge cursor terminal BEFORE the DROP so
              -- the SHARED projection cursor can walk past rows this recreate
              -- removes; a pending edge (no terminal) would otherwise strand the
              -- cursor and freeze surviving node projections too. 'up_to_date' is
              -- the CHECK-valid token ('superseded' would be swallowed by
              -- OR IGNORE). Complementary to the reserved-high-water fix above.
              INSERT OR IGNORE INTO _fathomdb_projection_terminal(write_cursor, state)
                  SELECT write_cursor, 'up_to_date' FROM canonical_edges;
              -- fix-6 (TC-33): delete the dropped edges' VECTOR sidecar rows
              -- BEFORE the DROP, while canonical_edges still lists the edge
              -- cursors. Scoped to edge cursors — _fathomdb_vector_rows also
              -- holds NODE sidecar rows, which must survive. The vec0 table
              -- vector_default is engine-created (dim-aware) and may not exist
              -- here, so the engine prunes it to match right after
              -- ensure_vector_partition. This is the third row-owned-projection
              -- facet step 23 clears for every dropped edge (with the reserved
              -- high-water mark and the terminal backfill above). NO DATA
              -- MIGRATION: it deletes derived rows for already-dropped edges.
              DELETE FROM _fathomdb_vector_rows
                  WHERE write_cursor IN (SELECT write_cursor FROM canonical_edges);
              DROP TABLE canonical_edges;
              CREATE TABLE canonical_edges(
                  write_cursor INTEGER NOT NULL,
                  kind TEXT NOT NULL,
                  from_id TEXT NOT NULL,
                  to_id TEXT NOT NULL,
                  source_id TEXT,
                  logical_id TEXT,
                  superseded_at INTEGER,
                  body TEXT,
                  t_valid INTEGER CHECK (t_valid IS NULL OR typeof(t_valid) = 'integer'),
                  t_invalid INTEGER CHECK (t_invalid IS NULL OR typeof(t_invalid) = 'integer'),
                  confidence REAL,
                  extractor_model_id TEXT,
                  temporal_fallback INTEGER
              );
              CREATE INDEX IF NOT EXISTS canonical_edges_source_id_idx
                  ON canonical_edges(source_id);
              CREATE UNIQUE INDEX IF NOT EXISTS canonical_edges_logical_active_idx
                  ON canonical_edges(logical_id) WHERE superseded_at IS NULL;
              CREATE INDEX IF NOT EXISTS canonical_edges_from_id_idx
                  ON canonical_edges(from_id);
              CREATE INDEX IF NOT EXISTS canonical_edges_to_id_idx
                  ON canonical_edges(to_id);",
    },
    // 0.8.20 Slice 15d (R-20-PR / R-20-EAV) — the projection-registry EAV +
    // property-FTS substrate the declarative `configure_projections` verb
    // projects into. NET-NEW: before this step there is NO attribute/EAV store
    // and NO property-FTS (only `body`-FTS `search_index`/`search_index_v2` +
    // vector). Three tables:
    //
    //   1. `_fathomdb_projection_registry` — the DURABLE record of every declared
    //      `ProjectionSpec` (Q5: the engine `ProjectionSpec` is a DERIVED cache
    //      re-driven idempotently on boot; this table is what boot re-derive
    //      reads). `roles` is a JSON array of `ProjectionRole` (set semantics —
    //      dedup/membership, no order dependence). `fts_tokenizer` is non-NULL
    //      iff a `searchable→FTS` sub-target was declared; `vector_embedder` +
    //      `vector_declared` record the `searchable→vector` sub-object which is
    //      STORED here but NOT built in 15d (Slice 20 R-20-DR attaches
    //      `dense_readiness` onto exactly this `vector` sub-object — additive).
    //
    //   2. `canonical_attributes` — the EAV attribute store. A ROW-OWNED,
    //      rebuild-durable projection: each row is 1:1 with the owning canonical
    //      node's `write_cursor`, holds one declared attribute value at rest, and
    //      MUST die with that node (registered in `ROW_OWNED_PROJECTIONS` so
    //      `purge`/`excise_source` reach it — an unregistered content-storing
    //      table re-opens the Slice-5 `search_index_v2` leak class). The values
    //      are derived from the node `body` JSON (`$.<name>`), so the store is
    //      re-derivable from canonical state (CQRS drift answer). `filterable`
    //      queries hit the `(attr_name, attr_value)` composite index (cheap
    //      equality/range, same-transaction).
    //
    //   3. `property_search_index` — the property-FTS5 shadow of the attribute
    //      values (`searchable→FTS`, same-transaction). Also ROW-OWNED (keyed by
    //      `write_cursor UNINDEXED`, same shape as `search_index_edges`). Default
    //      tokenizer matches `body`-FTS (`porter unicode61 remove_diacritics 2`);
    //      a per-attr custom tokenizer is the ≥0.9.x multi-field FTS work and is
    //      recorded in the registry but not honoured here (graceful-graft later).
    //
    // NO DATA MIGRATION (HITL 2026-07-21): these steps define the new shape only.
    // Nothing is backfilled at migrate time — `configure_projections` backfills
    // per-declaration, and boot re-derive re-applies the persisted registry.
    //
    // Additive `CREATE TABLE` (no DROP) → the accretion guard REQUIRES the
    // exemption marker. Crash-safety/idempotence are the runner's: `apply_one`
    // wraps the batch + the `user_version` bump in one `BEGIN IMMEDIATE`.
    Migration {
        step_id: 24,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: R-20-PR/R-20-EAV projection-registry EAV + property-FTS substrate (net-new _fathomdb_projection_registry durable derived-cache + canonical_attributes row-owned EAV projection + property_search_index FTS5 property-FTS). NO DATA MIGRATION (HITL 2026-07-21): shape only, no backfill.
              CREATE TABLE _fathomdb_projection_registry(
                  name TEXT PRIMARY KEY,
                  roles TEXT NOT NULL,
                  fts_tokenizer TEXT,
                  vector_embedder TEXT,
                  vector_declared INTEGER NOT NULL DEFAULT 0
              );
              CREATE TABLE canonical_attributes(
                  write_cursor INTEGER NOT NULL,
                  attr_name TEXT NOT NULL,
                  attr_value TEXT
              );
              CREATE INDEX canonical_attributes_name_value_idx
                  ON canonical_attributes(attr_name, attr_value);
              CREATE INDEX canonical_attributes_cursor_idx
                  ON canonical_attributes(write_cursor);
              CREATE VIRTUAL TABLE property_search_index USING fts5(
                  attr_value,
                  attr_name UNINDEXED,
                  write_cursor UNINDEXED,
                  tokenize = 'porter unicode61 remove_diacritics 2'
              );",
    },
    // 0.8.21 Slice 45 — an additive durable encoding of the optional literal
    // nested-member source path for a projection declaration. `NULL` preserves
    // the legacy direct top-level lookup by projection name; a JSON array stores
    // every path segment exactly. Shape only: no canonical body rewrite and no
    // projection backfill happens during migration.
    Migration {
        step_id: 25,
        sql: "-- MIGRATION-ACCRETION-EXEMPTION: Slice-45 nested projection source declaration; additive registry column only, no data migration or canonical-body rewrite.
              ALTER TABLE _fathomdb_projection_registry ADD COLUMN source TEXT;",
    },
];

/// `_fathomdb_open_state` key under which step 23 reserved the pre-TC-33
/// `canonical_edges` write-cursor high-water mark.
///
/// Step 23 recreates `canonical_edges` (no data migration), which can LOWER the
/// `MAX(write_cursor)` the engine's cursor allocator derives from the canonical
/// tables. Reusing a cursor would collide with stale projection shadow rows that
/// still key on it, silently marking a new row as already-projected. The engine
/// folds this reserved value into its allocation so cursors stay monotonic.
pub const RESERVED_WRITE_CURSOR_KEY: &str = "tc33_reserved_write_cursor";

pub fn migrate(conn: &Connection) -> Result<MigrationReport, MigrationError> {
    migrate_with_steps(conn, MIGRATIONS)
}

pub fn migrate_with_steps(
    conn: &Connection,
    migrations: &[Migration],
) -> Result<MigrationReport, MigrationError> {
    migrate_with_event_sink(conn, migrations, |_| {})
}

pub fn migrate_with_event_sink(
    conn: &Connection,
    migrations: &[Migration],
    mut emit: impl FnMut(&MigrationStepReport),
) -> Result<MigrationReport, MigrationError> {
    let before = user_version(conn)?;
    if before > SCHEMA_VERSION {
        return Err(MigrationError::IncompatibleSchemaVersion {
            seen: before,
            supported: SCHEMA_VERSION,
        });
    }

    let mut current = before;
    let mut reports = Vec::new();

    for migration in migrations.iter().filter(|migration| migration.step_id > before) {
        if migration.step_id != current.saturating_add(1) {
            return Err(MigrationError::Storage {
                message: "migration registry is not contiguous",
            });
        }

        let started = Instant::now();
        if let Err(_err) = apply_one(conn, migration) {
            reports.push(MigrationStepReport {
                step_id: migration.step_id,
                duration_ms: Some(duration_ms(started)),
                failed: true,
            });
            emit(reports.last().expect("failed step report was just pushed"));
            let schema_version_current = user_version(conn).unwrap_or(current);
            return Err(MigrationError::MigrationError(MigrationFailureReport {
                schema_version_before: before,
                schema_version_current,
                migration_steps: reports,
            }));
        }

        current = migration.step_id;
        reports.push(MigrationStepReport {
            step_id: migration.step_id,
            duration_ms: Some(duration_ms(started)),
            failed: false,
        });
        emit(reports.last().expect("successful step report was just pushed"));
    }

    Ok(MigrationReport {
        schema_version_before: before,
        schema_version_after: user_version(conn)?,
        migration_steps: reports,
    })
}

fn apply_one(conn: &Connection, migration: &Migration) -> rusqlite::Result<()> {
    conn.execute_batch("BEGIN IMMEDIATE")?;
    let result = (|| {
        conn.execute_batch(migration.sql)?;
        conn.pragma_update(None, PRAGMA_USER_VERSION, migration.step_id)?;
        Ok(())
    })();

    match result {
        Ok(()) => conn.execute_batch("COMMIT"),
        Err(err) => {
            let _ = conn.execute_batch("ROLLBACK");
            Err(err)
        }
    }
}

fn user_version(conn: &Connection) -> Result<u32, MigrationError> {
    conn.query_row("PRAGMA user_version", [], |row| row.get::<_, u32>(0))
        .map_err(|_| MigrationError::Storage { message: "could not read schema version" })
}

fn duration_ms(started: Instant) -> u64 {
    u64::try_from(started.elapsed().as_millis()).unwrap_or(u64::MAX)
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct MigrationAccretionError {
    pub offender: String,
}

impl Display for MigrationAccretionError {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        write!(f, "migration accretion guard rejected {}", self.offender)
    }
}

impl std::error::Error for MigrationAccretionError {}

/// 0.8.20 Slice 25 (R-20-SUR) — rejection from the TC-11 `logical_id` pin.
///
/// Carries the offending migration's `name` (as `MigrationAccretionError` does)
/// PLUS the normalised offending `statement`, because a migration step is a
/// batch: naming the file alone would leave an author hunting for which of a
/// dozen statements tripped the guard.
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct MigrationLogicalIdPinError {
    /// The migration step / file name handed to the guard.
    pub offender: String,
    /// The single offending statement, comment-stripped, string-literal-elided,
    /// uppercased and whitespace-collapsed (the guard's normalised view).
    pub statement: String,
}

impl Display for MigrationLogicalIdPinError {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        write!(
            f,
            "TC-11 logical_id pin rejected {}: a migration may never populate `logical_id` on an \
             existing canonical row — offending statement: {}",
            self.offender, self.statement
        )
    }
}

impl std::error::Error for MigrationLogicalIdPinError {}

/// The two canonical tables that carry the identity column the pin protects.
/// Uppercase because the guard compares against a normalised (uppercased) view.
const PINNED_IDENTITY_TABLES: [&str; 2] = ["CANONICAL_NODES", "CANONICAL_EDGES"];

/// The protected column, uppercased for the same reason.
const PINNED_IDENTITY_COLUMN: &str = "LOGICAL_ID";

/// 0.8.20 Slice 25 (R-20-SUR) — the **TC-11 pin's static migration guard**, and
/// the sibling of [`check_migration_accretion`].
///
/// # What it enforces
///
/// TC-11 pin A (HITL-ratified 2026-07-12; `dev/plans/plan-0.8.20.md` §2.1) rules
/// that anonymous / doc-seeded nodes stay `h:<content-hash>` **permanently** —
/// the anonymous-surrogate leg is CANCELLED, not deferred — and that enforcement
/// is "**no new column**": the record IS `canonical_nodes.logical_id`'s
/// null-ness. The invariant is therefore a PROHIBITION:
///
/// > No migration, backfill, or verb shall ever populate `logical_id` on an
/// > existing canonical row, and a stored row's id-space is NEVER re-derived.
///
/// This function is the migration half of that prohibition, checked STATICALLY —
/// before the SQL can ever run. Supplying a `logical_id` at WRITE time is what
/// makes a record governed; a migration is not a write time.
///
/// # Rejected shapes
///
/// On `canonical_nodes` / `canonical_edges` only:
///
/// - `UPDATE … SET … logical_id …` — the direct forward-mint;
/// - `INSERT`/`REPLACE … INTO …` that names `logical_id`, i.e. a recreate-and-copy
///   backfill (`SELECT COALESCE(logical_id, mint(…))`);
/// - `INSERT`/`REPLACE … INTO …` with NO explicit column list — it writes every
///   column, `logical_id` among them, without naming it;
/// - `ALTER TABLE … ADD COLUMN logical_id … DEFAULT …` — a default populates
///   every EXISTING row in one statement;
/// - `ALTER TABLE … RENAME … logical_id` — a rename turns an already-populated
///   column INTO the identity column with no write at all;
/// - `CREATE TRIGGER … logical_id …` — a deferred `UPDATE`;
/// - `CREATE TABLE …(… logical_id … DEFAULT …)` — same reasoning as `ADD COLUMN`;
/// - ANY of the write shapes above behind a leading `WITH … AS (…)` /
///   `WITH RECURSIVE …` CTE clause, which SQLite allows in FRONT of `UPDATE`,
///   `INSERT` and `DELETE` — see the keyword-independent catch-all below.
///
/// # Accepted shapes (the ladder already ships all four)
///
/// - DECLARING the column (`ALTER TABLE canonical_nodes ADD COLUMN logical_id
///   TEXT`, step 12) — declaration is not population;
/// - INDEXING it (`CREATE UNIQUE INDEX … ON canonical_nodes(logical_id) WHERE
///   superseded_at IS NULL`, steps 12/23);
/// - READING it as a PREDICATE (`WHERE source_id IS NULL AND logical_id IS
///   NULL`, step 21 — which writes only `source_id`);
/// - RE-DECLARING it in a `CREATE TABLE` recreate (step 23's TC-33 edge
///   recreate, which deliberately copies no rows).
///
/// # Deliberately conservative
///
/// The guard refuses any statement that WRITES INTO `logical_id` on a canonical
/// table, including a copy that would merely PRESERVE the value through a
/// table-recreate. Distinguishing "preserving copy" from "minting copy" needs
/// positional matching of an insert column list against a `SELECT` expression
/// list — fragile, and trivially gamed by the exact class of change the pin
/// exists to stop. A future recreate must follow step 23's shipped precedent
/// (declare the column; do not copy rows through it), or come back through the
/// HITL to change the pin itself.
///
/// Conservatism also decides the SCHEMA-QUALIFIED case: `main.canonical_nodes`,
/// `temp.canonical_nodes` and every quoted spelling of either half normalise to
/// the bare table name before the comparison, so qualifying the table is not an
/// escape. `main.canonical_nodes_old` is NOT the pinned table — the qualifier is
/// stripped, never widened into a substring match.
///
/// SQLite's `UPDATE OR <conflict-action> …` prefix is not an escape either. All
/// five actions (`ROLLBACK` / `ABORT` / `FAIL` / `IGNORE` / `REPLACE`, verified
/// against SQLite 3.45.1) sit BETWEEN the keyword and the table name, so the
/// clause is skipped — token-exactly, so a table genuinely named `or_ledger`
/// still reads as the table — before the comparison. The `INSERT`/`REPLACE` arm
/// anchors on ` INTO `, which the conflict clause precedes, so it never had the
/// hole.
///
/// The reverse error — over-rejection — is a real cost too, so table names are
/// matched by TOKEN, never by substring, on EVERY arm including the trigger one.
/// A `CREATE TRIGGER … ON canonical_nodes_backup` targets a different table and
/// is accepted; a trigger whose BODY writes `logical_id` on a real canonical
/// table is still rejected, because the trigger arm scans the whole fragment
/// (which, by the `;` split, carries the head AND the first body statement) for
/// a pinned table token, and later body statements are their own fragments.
///
/// Conservatism is also why the arms above are not the whole guard. Each of them
/// anchors on the statement's LEADING keyword, and SQLite's grammar puts an
/// optional `WITH …` CTE clause in front of `UPDATE` / `INSERT` / `DELETE`, so
/// `WITH x AS (SELECT 1) UPDATE canonical_nodes SET logical_id = …` (valid, and
/// verified running against SQLite 3.45.1) would match no arm at all. Rather
/// than teach the guard to skip balanced parentheses — a SQL parser by another
/// name — a keyword-INDEPENDENT catch-all runs FIRST and refuses any statement
/// that writes `logical_id` in an ASSIGNMENT position on a pinned table:
/// a ` SET ` clause naming the column while some token names a canonical table,
/// or an ` INTO ` target that IS a canonical table (naming the column, or
/// omitting the column list). Read positions — a `WHERE` predicate, an index
/// column list, a column declaration — are untouched, which is precisely what
/// keeps the four shipped accepts green. See
/// [`writes_pinned_identity_anywhere`], whose assignment half deliberately
/// over-rejects: after an arbitrary prefix the update TARGET cannot be located
/// without parsing, so merely MENTIONING a canonical table anywhere in a
/// statement that assigns `logical_id` is refused.
///
/// # No exemption escape hatch — deliberately
///
/// [`check_migration_accretion`] honours a `-- MIGRATION-ACCRETION-EXEMPTION: `
/// marker because accretion is a BUDGET an author may knowingly spend. The TC-11
/// pin is not a budget; it is TERMINAL-FOREVER. An escape hatch would defeat it,
/// so there is none: a marked offender is rejected identically to an unmarked
/// one. Changing the pin is an HITL decision, not a comment.
///
/// # Known limits (stated, not hidden)
///
/// This is a lexical guard, not a SQL parser. It normalises away comments and
/// string literals, unwraps `"…"` / `[…]` / `` `…` `` quoted identifiers, and
/// tightens whitespace around `.` so a schema qualifier is one token (SQLite
/// accepts `main . canonical_nodes`; verified against SQLite 3.45) — then it
/// splits on `;`. A `CREATE TRIGGER` body therefore splits into fragments: the
/// FIRST body statement stays glued to the `CREATE TRIGGER …` head (the split
/// point is the `;` that ends it) and is judged with the head by the trigger
/// arm's whole-fragment token scan; every LATER body statement is its own
/// fragment and is judged independently by the `UPDATE` / `INSERT` arms. It
/// cannot see through dynamically-built SQL, which migrations do not use
/// (`MIGRATIONS` holds `&'static str` literals).
///
/// A leading `WITH …` CTE is NOT among the limits — the keyword-independent
/// catch-all above closes that family. What remains open, stated plainly rather
/// than papered over, is **cross-statement table identity**: the guard judges
/// each `;`-separated statement ALONE and holds no model of which name refers to
/// which table over the course of a step. A migration that renames the pinned
/// table out of the way, writes `logical_id` under the new name, and renames it
/// back —
///
/// ```sql
/// ALTER TABLE canonical_nodes RENAME TO tmp_x;
/// UPDATE tmp_x SET logical_id = 'minted' WHERE logical_id IS NULL;
/// ALTER TABLE tmp_x RENAME TO canonical_nodes;
/// ```
///
/// — is therefore ACCEPTED, as is its sibling (`CREATE TABLE … AS SELECT …
/// 'minted' AS logical_id FROM canonical_nodes`, `DROP`, `RENAME TO
/// canonical_nodes`). Closing it means tracking table identity across
/// statements, which is a different guard, not a wider arm; it is recorded here
/// (and in the slice's reviewer record) as a KNOWN residual rather than silently
/// implied to be covered. Note that the second half of the TC-11 prohibition —
/// the runtime write path — is enforced elsewhere, so this guard being lexical
/// is not the pin's only defence.
pub fn check_migration_logical_id_pin(
    name: &str,
    sql: &str,
) -> Result<(), MigrationLogicalIdPinError> {
    for statement in normalized_statements(sql) {
        if statement_violates_logical_id_pin(&statement) {
            return Err(MigrationLogicalIdPinError { offender: name.to_string(), statement });
        }
    }
    Ok(())
}

/// Split `sql` into per-statement NORMALISED views: comments removed, string
/// literals elided to `''`, quoted identifiers unwrapped to bare ones,
/// uppercased, whitespace collapsed to single spaces.
///
/// Scanning is strictly left-to-right so precedence is correct: a `--` inside a
/// string literal is data, and a `'` inside a comment is prose.
fn normalized_statements(sql: &str) -> Vec<String> {
    let mut statements = Vec::new();
    let mut current = String::new();
    let chars: Vec<char> = sql.chars().collect();
    let mut i = 0;

    while i < chars.len() {
        let c = chars[i];
        match c {
            // Line comment: drop to end of line (the newline becomes whitespace).
            '-' if chars.get(i + 1) == Some(&'-') => {
                while i < chars.len() && chars[i] != '\n' {
                    i += 1;
                }
            }
            // Block comment: drop to the closing delimiter.
            '/' if chars.get(i + 1) == Some(&'*') => {
                i += 2;
                while i < chars.len() && !(chars[i] == '*' && chars.get(i + 1) == Some(&'/')) {
                    i += 1;
                }
                i = (i + 2).min(chars.len());
                current.push(' ');
            }
            // String literal: elide the contents (they can never be an
            // identifier). `''` inside a literal is an escaped quote.
            '\'' => {
                i += 1;
                while i < chars.len() {
                    if chars[i] == '\'' {
                        if chars.get(i + 1) == Some(&'\'') {
                            i += 2;
                            continue;
                        }
                        i += 1;
                        break;
                    }
                    i += 1;
                }
                current.push_str("''");
            }
            // Quoted identifiers: UNWRAP them, so `"logical_id"` / `[logical_id]`
            // / `` `logical_id` `` are the same identifier to the guard that they
            // are to SQLite.
            '"' | '`' | '[' => {
                let close = if c == '[' { ']' } else { c };
                i += 1;
                while i < chars.len() && chars[i] != close {
                    current.push(chars[i].to_ascii_uppercase());
                    i += 1;
                }
                i += 1;
            }
            ';' => {
                statements.push(normalize_statement(&current));
                current.clear();
                i += 1;
            }
            _ => {
                current.push(c.to_ascii_uppercase());
                i += 1;
            }
        }
    }
    statements.push(normalize_statement(&current));
    statements.retain(|s| !s.is_empty());
    statements
}

/// The per-statement tail of the normalisation: collapse whitespace, then
/// tighten qualified names so a schema qualifier is ONE token.
fn normalize_statement(raw: &str) -> String {
    tighten_qualified_names(&collapse_whitespace(raw))
}

fn collapse_whitespace(raw: &str) -> String {
    raw.split_whitespace().collect::<Vec<_>>().join(" ")
}

/// Remove whitespace around `.` so `main . canonical_nodes` normalises to
/// `MAIN.CANONICAL_NODES`.
///
/// SQLite's tokenizer accepts whitespace around the qualifier dot (verified
/// against SQLite 3.45: `UPDATE main . t SET …` parses and targets `main.t`),
/// while the token extractors below cut at whitespace — so without this the
/// spaced spelling would extract the bare token `MAIN` and slip the pin.
/// Comments are already stripped and string literals already elided to `''` by
/// this point, so no `.` that survives here is data.
fn tighten_qualified_names(statement: &str) -> String {
    if !statement.contains('.') {
        return statement.to_string();
    }
    statement.split('.').map(str::trim).collect::<Vec<_>>().join(".")
}

/// Does one NORMALISED statement write into `logical_id` on a canonical table?
fn statement_violates_logical_id_pin(statement: &str) -> bool {
    let names_column = statement.contains(PINNED_IDENTITY_COLUMN);

    // FIRST, and independent of the leading keyword: the keyword-anchored arms
    // below all begin `statement.starts_with(…)`, and SQLite's grammar allows a
    // `WITH …` CTE clause in FRONT of UPDATE / INSERT / DELETE — so
    // `WITH x AS (SELECT 1) UPDATE canonical_nodes SET logical_id = …` runs the
    // forbidden backfill while starting with none of them. This catch-all closes
    // that whole family without a paren-matching CTE parser, and runs BEFORE the
    // arms because several of them `return false` early (a non-pinned UPDATE
    // target, say), which would otherwise shadow it.
    if writes_pinned_identity_anywhere(statement, names_column) {
        return true;
    }

    // A trigger is a deferred write; one that so much as mentions the identity
    // column AND names a canonical table — as its ON-target, or anywhere in the
    // first body statement, which the `;` split glues onto the head — is refused
    // whole. Later body statements split into their own fragments, which the
    // UPDATE / INSERT arms below catch independently.
    if statement.starts_with("CREATE") && statement.contains(" TRIGGER ") && names_column {
        return mentions_pinned_table(statement);
    }

    if statement.starts_with("UPDATE") {
        let Some(table) = update_target_table(statement) else { return false };
        if !is_pinned_table(&table) {
            return false;
        }
        // Only the SET clause assigns. Reading `logical_id` in a WHERE predicate
        // (step 21) is explicitly legitimate.
        return set_clause(statement).is_some_and(|clause| clause.contains(PINNED_IDENTITY_COLUMN));
    }

    if statement.starts_with("INSERT") || statement.starts_with("REPLACE") {
        let Some((table, rest)) = table_after_into(statement) else { return false };
        if !is_pinned_table(&table) {
            return false;
        }
        // Naming the column anywhere in an insert into a canonical table is a
        // backfill; a MISSING column list writes every column, identity included.
        return names_column || !rest.trim_start().starts_with('(');
    }

    if statement.starts_with("ALTER") {
        let Some(table) = token_after(statement, "ALTER TABLE ") else { return false };
        if !is_pinned_table(&table) || !names_column {
            return false;
        }
        // Declaring the column bare is how step 12 shipped it. A DEFAULT
        // populates every existing row; a RENAME conscripts a populated one.
        return statement.contains("DEFAULT") || statement.contains("RENAME");
    }

    if statement.starts_with("CREATE") && statement.contains(" TABLE ") {
        let Some(table) = token_after(statement, " TABLE ") else { return false };
        // A recreate may DECLARE the column (step 23 does); it may not default it.
        return is_pinned_table(&table) && names_column && statement.contains("DEFAULT");
    }

    false
}

/// The keyword-INDEPENDENT catch-all: does `statement` write `logical_id` on a
/// pinned table ANYWHERE, whatever it starts with?
///
/// Every other arm anchors on the leading keyword, so any prefix that displaces
/// it — SQLite's optional `WITH …` / `WITH RECURSIVE …` CTE clause is the one
/// that actually exists, and it is legal in front of `UPDATE`, `INSERT` and
/// `DELETE` — slips them all. Parsing CTE parentheses to find the real head
/// keyword would be a SQL parser; the pin is TERMINAL-FOREVER and its stated
/// stance is that over-rejection is a cost worth paying and under-rejection is
/// not, so this fires on WRITE POSITION instead of on statement shape:
///
/// - an assignment: the ` SET ` clause (up to `WHERE` / `FROM` / `RETURNING`)
///   names `logical_id`, and SOME token of the statement is a pinned table;
/// - an insert target: the table after ` INTO ` is pinned, and the statement
///   either names `logical_id` or omits the column list (which writes every
///   column, identity included) — the same rule the `INSERT` arm applies.
///
/// READ positions are deliberately untouched, which is exactly what keeps the
/// four shipped accepts green: a `WHERE … logical_id IS NULL` predicate (step
/// 21, which writes only `source_id`), an index column list (steps 12/23), a
/// bare `ADD COLUMN logical_id TEXT` declaration (step 12) and a `CREATE TABLE`
/// re-declaration (step 23) all name the column without assigning to it. The
/// insert half checks the TARGET table, not mere mention, so step 23's
/// `INSERT … INTO _fathomdb_open_state … SELECT … FROM canonical_edges` — which
/// reads a pinned table — stays accepted.
///
/// The assignment half is deliberately coarser than the `UPDATE` arm: it asks
/// only whether a pinned table is MENTIONED, because after an arbitrary prefix
/// the update target cannot be located token-wise without parsing. So
/// `WITH x AS (SELECT 1 FROM canonical_nodes) UPDATE other SET logical_id = …`
/// is refused too. That is over-rejection by design, and cheap to work around
/// honestly (don't name a canonical table in the CTE); the reverse mistake is
/// not recoverable.
fn writes_pinned_identity_anywhere(statement: &str, names_column: bool) -> bool {
    if names_column
        && mentions_pinned_table(statement)
        && set_clause(statement).is_some_and(|clause| clause.contains(PINNED_IDENTITY_COLUMN))
    {
        return true;
    }
    table_after_into(statement).is_some_and(|(table, rest)| {
        is_pinned_table(&table) && (names_column || !rest.trim_start().starts_with('('))
    })
}

/// The bare table name from a possibly schema-qualified token.
///
/// SQLite resolves `main.canonical_nodes` (or `temp.canonical_nodes`, or any
/// quoted spelling of either half — the normaliser has already unwrapped those)
/// to the SAME pinned table as the bare name, so the qualifier is stripped
/// before the comparison. SQLite permits at most ONE qualifier, so the part
/// after the dot is the table name. This is a STRIP, not a widening to a
/// substring match: `main.canonical_nodes_old` is still a different table.
fn bare_table_name(token: &str) -> &str {
    token.rsplit_once('.').map_or(token, |(_, table)| table)
}

fn is_pinned_table(token: &str) -> bool {
    PINNED_IDENTITY_TABLES.contains(&bare_table_name(token))
}

/// Does any IDENTIFIER TOKEN of `statement` name a pinned canonical table?
///
/// Token-based, never a substring: `canonical_nodes_backup` is a DIFFERENT
/// table, and a `contains` test would conscript every lookalike name into the
/// pin — rejecting legitimate backup/recreate scaffolding. The statement is cut
/// on every character that cannot appear in an identifier, keeping `.` so a
/// schema qualifier stays one token for [`is_pinned_table`] to strip.
///
/// Used by the trigger arm, whose target table can sit anywhere in the head
/// (`… ON <table> …`), and which — because the `;` split glues the FIRST body
/// statement onto the head — must also see a table named inside that body.
fn mentions_pinned_table(statement: &str) -> bool {
    statement
        .split(|c: char| !(c.is_ascii_alphanumeric() || c == '_' || c == '.'))
        .any(is_pinned_table)
}

/// SQLite's five `UPDATE OR <conflict-action>` / `INSERT OR <conflict-action>`
/// spellings (verified against SQLite 3.45.1).
const SQLITE_CONFLICT_ACTIONS: [&str; 5] = ["ROLLBACK", "ABORT", "FAIL", "IGNORE", "REPLACE"];

/// The target table of an `UPDATE`, skipping SQLite's optional conflict clause.
///
/// `UPDATE OR REPLACE canonical_nodes SET logical_id = …` is a valid, running
/// backfill; the conflict action sits BETWEEN the keyword and the table name, so
/// taking the first token after `UPDATE ` yields `OR` and the pin is bypassed.
/// The skip is token-EXACT (the action must be a whole token followed by a
/// space), so a table actually named `or_ledger` is still read as the table.
///
/// The `INSERT`/`REPLACE` arm needs no equivalent: it anchors on ` INTO `, which
/// the conflict clause precedes (`INSERT OR IGNORE INTO canonical_nodes …`).
fn update_target_table(statement: &str) -> Option<String> {
    let mut rest = statement.strip_prefix("UPDATE ")?;
    if let Some(after_or) = rest.strip_prefix("OR ") {
        if let Some(after_action) = SQLITE_CONFLICT_ACTIONS
            .iter()
            .find_map(|action| after_or.strip_prefix(*action)?.strip_prefix(' '))
        {
            rest = after_action;
        }
    }
    first_token(rest)
}

/// The first identifier token after `marker`, cut at whitespace or `(`.
fn token_after(statement: &str, marker: &str) -> Option<String> {
    first_token(statement.split_once(marker)?.1)
}

/// The leading identifier token of `rest`, cut at whitespace, `(` or `,`.
fn first_token(rest: &str) -> Option<String> {
    let token: String =
        rest.chars().take_while(|c| !c.is_whitespace() && *c != '(' && *c != ',').collect();
    (!token.is_empty()).then_some(token)
}

/// `(table, remainder-after-the-table-name)` for an `INSERT`/`REPLACE … INTO …`.
fn table_after_into(statement: &str) -> Option<(String, String)> {
    let rest = statement.split_once(" INTO ")?.1;
    let table: String =
        rest.chars().take_while(|c| !c.is_whitespace() && *c != '(' && *c != ',').collect();
    (!table.is_empty()).then(|| (table.clone(), rest[table.len()..].to_string()))
}

/// The assignment half of an `UPDATE`: everything between ` SET ` and the first
/// clause keyword that ends it.
fn set_clause(statement: &str) -> Option<&str> {
    let after_set = statement.split_once(" SET ")?.1;
    let end = [" WHERE ", " FROM ", " RETURNING "]
        .iter()
        .filter_map(|kw| after_set.find(kw))
        .min()
        .unwrap_or(after_set.len());
    Some(&after_set[..end])
}

pub fn check_migration_accretion(name: &str, sql: &str) -> Result<(), MigrationAccretionError> {
    let upper = sql.to_ascii_uppercase();
    let adds_schema = upper.contains("CREATE TABLE") || upper.contains("ADD COLUMN");
    let names_removal = upper.contains("DROP TABLE") || upper.contains("DROP COLUMN");
    let has_exemption = sql.contains("-- MIGRATION-ACCRETION-EXEMPTION: ");

    if adds_schema && !names_removal && !has_exemption {
        return Err(MigrationAccretionError { offender: name.to_string() });
    }

    Ok(())
}