fastqrab-steps 0.9.1

Pipeline building blocks for fastqrab: read transformations, filters, reports, and demultiplexing
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
use std::borrow::Cow;
use std::cell::RefCell;

use crate::transformations::prelude::*;
use fastqrab_dna::dna::reverse_complement;
use fastqrab_io::io::WrappedFastQReadMut;

/// Algorithm to use for scoring overlaps and resolving mismatches
#[derive(Clone, PartialEq, Eq, JsonSchema)]
#[tpd]
#[derive(Debug)]
pub enum Algorithm {
    /// fastp algorithm: quality-score based mismatch resolution
    /// Uses hamming distance for overlap detection and chooses higher quality base for mismatches
    #[tpd(alias = "FastpSeemsWeird")]
    Fastp,
}

/// Strategy when reads cannot be merged due to insufficient overlap
#[derive(Clone, PartialEq, Eq, JsonSchema)]
#[tpd]
#[derive(Debug)]
pub enum NoOverlapStrategy {
    /// Keep reads as they are (no merging)
    AsIs,
    /// Concatenate reads with spacer into first segment
    Concatenate,
}

/// Merge paired end reads if they're overlapping
#[derive(Clone, JsonSchema)]
#[tpd]
#[derive(Debug)]
pub struct MergeReads {
    /// Algorithm to use for overlap scoring and mismatch resolution
    pub algorithm: Algorithm,

    /// Minimum overlap length required for merging (suggested: 30, minimum: 5)
    pub min_overlap: usize,

    /// Maximum allowed mismatch rate (0.0 to 1.0, suggested: 0.2)
    pub max_mismatch_rate: f64,

    /// Maximum allowed absolute number of mismatches (suggested: 5)
    pub max_mismatch_count: usize,

    /// Strategy when no overlap is found
    pub no_overlap_strategy: NoOverlapStrategy,

    /// Tag label to store merge status (suggested: "merged")
    /// Tag will be true if reads were merged, false otherwise
    pub out_label: Option<TagLabel>,

    /// Spacer sequence to use when concatenating (required if `no_overlap_strategy` = 'concatenate')
    pub concatenate_spacer: Option<String>,

    /// Quality score to use for spacer bases (suggested: 33, which is Phred quality 0)
    pub spacer_quality_char: Option<u8>,

    /// Whether to reverse complement segment2 before merging
    pub reverse_complement_segment2: bool,

    #[schemars(with = "String")]
    #[tpd(adapt_in_verify(String))]
    pub segment1: SegmentIndex,
    #[schemars(with = "String")]
    #[tpd(adapt_in_verify(String))]
    pub segment2: SegmentIndex,
}

impl VerifyIn<PartialConfig> for PartialMergeReads {
    fn verify(
        &mut self,
        parent: &PartialConfig,
        _options: &VerifyOptions,
    ) -> std::result::Result<(), ValidationFailure>
    where
        Self: Sized + toml_pretty_deser::Visitor,
    {
        self.segment1.validate_segment(parent);
        self.segment2.validate_segment(parent);
        if let Some(segment1) = self.segment1.as_ref()
            && let Some(segment2) = self.segment2.as_ref()
            && let MustAdapt::PostVerify(index1) = segment1
            && let MustAdapt::PostVerify(index2) = segment2
            && index1 == index2
        {
            let spans = vec![
                (
                    self.segment1.span(),
                    "Must be different from segment2".to_string(),
                ),
                (
                    self.segment2.span(),
                    "Must be different from segment1".to_string(),
                ),
            ];
            self.segment1 = TomlValue::new_custom(
                Some(MustAdapt::PostVerify(*index1)),
                spans,
                Some(&format!(
                    "Available segments: {}",
                    parent
                        .input
                        .as_ref()
                        .expect("Expected input_def to be present at this point. Bug in config validation")
                        .get_segment_order()
                        .join(", ")
                )),
            );
        }

        if let Some(no_overlap_strategy) = self.no_overlap_strategy.as_ref()
            && let Some(concatenate_spacer) = self.concatenate_spacer.as_ref()
            && *no_overlap_strategy == NoOverlapStrategy::Concatenate
            && concatenate_spacer.is_none()
        {
            return Err(ValidationFailure::new(
                "Missing key: 'concatenate_spacer'",
                Some(
                    "concatenate_spacer is required when no_overlap_strategy = 'concatenate'. Please specify a spacer sequence (e.g., concatenate_spacer = \"NNNN\").",
                ),
            ));
        }

        self.min_overlap.verify(|v| {
            if *v < 5 {
                Err(ValidationFailure::new(
                    "Invalid value. Must be >= 5",
                    Some("Set a valid value."),
                ))
            } else {
                Ok(())
            }
        });
        self.max_mismatch_rate.verify(|v| {
            if *v < 0.0 || *v >= 1.0 {
                Err(ValidationFailure::new(
                    "Invalid value. Must be in [0.0..1.0)",
                    Some("Set a valid value >= 0 and < 1.0."),
                ))
            } else {
                Ok(())
            }
        });
        self.spacer_quality_char.verify(|opt_v| {
            if let Some(v) = opt_v
                && !(33..=126).contains(v)
            {
                return Err(ValidationFailure::new(
                    "Invalid value. Must be in [33..126]",
                    Some("Set a valid value."),
                ));
            }
            Ok(())
        });

        Ok(())
    }
}

impl TagUser for PartialTaggedVariant<PartialMergeReads> {
    fn get_tag_usage(
        &mut self,
        _tags_available: &IndexMap<TagLabel, TagMetadata>,
        _segment_order: &[String],
    ) -> Option<TagUsageInfo<'_>> {
        if let Some(inner) = self.toml_value.value.as_mut() {
            Some(TagUsageInfo {
                declared_tag: inner.out_label.to_declared_tag(TagValueType::Bool),
                ..Default::default()
            })
        } else {
            None // cov:excl-line
        }
    }
}

impl Step for MergeReads {
    fn apply(
        &self,
        mut block: FastQBlocksCombined,
        _input_info: &InputInfo,
        _demultiplex_info: &OptDemultiplex,
    ) -> anyhow::Result<(FastQBlocksCombined, bool)> {
        let seg1_idx = self.segment1.0;
        let seg2_idx = self.segment2.0;
        let reverse_complement_segment2 = self.reverse_complement_segment2;
        let no_overlap_strategy = self.no_overlap_strategy.clone();
        let concatenate_spacer = self.concatenate_spacer.clone();
        let spacer_qual = self.spacer_quality_char.unwrap_or(33);
        let min_overlap = self.min_overlap;
        let max_mismatch_rate = self.max_mismatch_rate;
        let max_mismatch_count = self.max_mismatch_count;
        let algorithm = self.algorithm.clone();

        // Track which reads were merged (if label is set)
        let merge_status: RefCell<Option<Vec<bool>>> = RefCell::new(
            self.out_label
                .as_ref()
                .map(|_| Vec::with_capacity(block.len())),
        );

        // Process each read pair using apply_mut
        block.apply_mut(|reads: &mut [WrappedFastQReadMut]| {
            let read1_seq = reads[seg1_idx as usize].seq();
            let read1_qual = reads[seg1_idx as usize].qual();
            let read2_seq = reads[seg2_idx as usize].seq();
            let read2_qual = reads[seg2_idx as usize].qual();

            // Optionally reverse complement read2
            let (read2_seq_processed, read2_qual_processed): (Cow<[u8]>, Cow<[u8]>) =
                if reverse_complement_segment2 {
                    let rc_seq = reverse_complement(read2_seq);
                    let rc_qual: Vec<u8> = read2_qual.iter().rev().copied().collect();
                    (Cow::Owned(rc_seq), Cow::Owned(rc_qual))
                } else {
                    (Cow::Borrowed(read2_seq), Cow::Borrowed(read2_qual))
                };

            // Try to find overlap and merge
            let merge_result = merge_reads(
                read1_seq,
                read1_qual,
                &read2_seq_processed,
                &read2_qual_processed,
                &algorithm,
                min_overlap,
                max_mismatch_rate,
                max_mismatch_count,
            );

            // Apply the merge result and track if merged
            let was_merged = match merge_result {
                MergeResult::Merged {
                    merged_seq,
                    merged_qual,
                } => {
                    // Update segment1 with merged sequence
                    reads[seg1_idx as usize].replace_seq(&merged_seq, &merged_qual);
                    // Clear segment2
                    reads[seg2_idx as usize].clear();
                    true
                }
                MergeResult::NoOverlap => {
                    // Handle according to strategy
                    if no_overlap_strategy == NoOverlapStrategy::Concatenate {
                        let spacer = concatenate_spacer
                            .as_ref()
                            .expect("concatenate_spacer must be Some in concatenate mode");

                        // Concatenate read1 + spacer + read2_processed into segment1
                        let mut concatenated_seq = read1_seq.to_vec();
                        concatenated_seq.extend_from_slice(spacer.as_bytes());
                        concatenated_seq.extend_from_slice(&read2_seq_processed);

                        let mut concatenated_qual = read1_qual.to_vec();
                        concatenated_qual.extend(std::iter::repeat_n(spacer_qual, spacer.len()));
                        concatenated_qual.extend_from_slice(&read2_qual_processed);

                        // Update segment1 with concatenated sequence
                        reads[seg1_idx as usize].replace_seq(&concatenated_seq, &concatenated_qual);
                        // Clear segment2
                        reads[seg2_idx as usize].clear();
                    }
                    // Otherwise keep reads as they are (NoOverlapStrategy::AsIs)
                    false
                }
            };

            // Record merge status if tracking
            if let Some(merge_status) = merge_status.borrow_mut().as_mut() {
                merge_status.push(was_merged);
            }
        });

        // Add merge status tag if label was specified

        if let Some(merge_status) = merge_status.take() {
            let tag_values: TagColumn = TagColumn::Bool(merge_status.into_iter().collect());
            block.tags.insert(
                self.out_label
                    .as_ref()
                    .expect("out_label must be set for merge type")
                    .clone(),
                tag_values,
            );
        }

        Ok((block, true))
    }
}

#[derive(Debug)]
enum MergeResult {
    Merged {
        merged_seq: Vec<u8>,
        merged_qual: Vec<u8>,
    },
    NoOverlap,
}

/// Try to merge two reads by finding their overlap
/// seq2 should already be processed (reverse complemented if needed)
#[expect(clippy::too_many_arguments, reason = "we need them")]
fn merge_reads(
    seq1: &[u8],
    qual1: &[u8],
    seq2: &[u8],
    qual2: &[u8],
    algorithm: &Algorithm,
    min_overlap: usize,
    max_mismatch_rate: f64,
    max_mismatch_count: usize,
) -> MergeResult {
    match algorithm {
        Algorithm::Fastp => {
            let ov = find_best_overlap_fastp(
                seq1,
                seq2,
                min_overlap,
                max_mismatch_rate,
                max_mismatch_count,
            );
            if let Some((offset, overlap_len)) = ov {
                // Merge the reads
                let (merged_seq, merged_qual) =
                    merge_at_offset_fastp(seq1, qual1, seq2, qual2, offset, overlap_len);
                MergeResult::Merged {
                    merged_seq,
                    merged_qual,
                }
            } else {
                MergeResult::NoOverlap
            }
        }
    }
}

/// Find the best overlap using fastp algorithm (hamming distance)
/// I not fond of this. It's a faithful rewrite of the C(++) fastp code,
/// but it's missing a *large* set of test cases that verify that a)
/// it does what fastp actually does,
/// and b) that all of it's branches get exercised.
/// Mutation testing really is having a field day with this,
/// and devising test cases that cover all the branches & loop conditions
/// is somewhat tricky.
#[expect(
    clippy::cast_possible_truncation,
    reason = "u64 to usize is fine for our target systems"
)]
#[expect(
    clippy::cast_sign_loss,
    clippy::cast_precision_loss,
    reason = "max_mismatch_rate is 0..=1"
)]
#[expect(clippy::nonminimal_bool, reason = "it's clearer this way")]
fn find_best_overlap_fastp(
    seq1: &[u8],
    seq2: &[u8], //must already have been reverse complemented
    min_overlap: usize,
    max_mismatch_rate: f64,
    max_mismatch_count: usize,
) -> Option<(isize, usize)> {
    //offset, length
    let len1: isize = seq1
        .len()
        .try_into()
        .expect("seq1 len too large for isize. Max supported read size is 2^31 bases");
    let len2: isize = seq2
        .len()
        .try_into()
        .expect("seq2 len too large for isize. Max supported read size is 2^31 bases"); //already reverse complement

    let complete_compare_require = 50;

    let mut overlap_len;
    let mut offset: isize = 0;
    let mut diff;
    let overlap_require: isize = min_overlap
        .try_into()
        .expect("min_overlap too large for isize");
    let diff_percent_limit = max_mismatch_rate;
    let diff_limit = max_mismatch_count;
    let str1 = seq1;
    let str2 = seq2;

    // forward
    // a match of less than overlapRequire is considered as unconfident
    while offset
        < len1
            .checked_sub(overlap_require)
            .expect("Subtraction below range - how large is your min_overlap that you exceed an isize after substraction?")
    {
        // the overlap length of r1 & r2 when r2 is move right for offset
        overlap_len = (len1 - offset).min(len2);
        let overlap_diff_limit = diff_limit.min((overlap_len as f64 * diff_percent_limit) as usize);

        diff = 0;
        let mut last_i = 0;
        for i in 0..overlap_len {
            if str1[(offset + i) as usize] != str2[i as usize] {
                diff += 1;
                if diff > overlap_diff_limit && i < complete_compare_require {
                    break;
                }
            }
            last_i = i + 1;
        }
        if diff <= overlap_diff_limit
            || (diff > overlap_diff_limit && last_i > complete_compare_require)
        {
            return Some((offset, overlap_len as usize));
        }

        offset += 1;
    }

    // reverse
    // in this case, the adapter is sequenced since TEMPLATE_LEN < SEQ_LEN
    // check if distance can get smaller if offset goes negative
    // this only happens when insert DNA is shorter than sequencing read length, and some adapter/primer is sequenced but not trimmed cleanly
    // we go reversely
    offset = 0;
    while offset > -(len2 - overlap_require) {
        // the overlap length of r1 & r2 when r2 is move right for offset
        overlap_len = len1.min(len2 - (offset.abs()));
        let overlap_diff_limit = diff_limit.min((overlap_len as f64 * diff_percent_limit) as usize);

        diff = 0;
        let mut last_i = 0;
        for i in 0..overlap_len {
            if str1[i as usize] != str2[(-offset + i) as usize] {
                diff += 1;
                if diff > overlap_diff_limit && i < complete_compare_require {
                    break;
                }
            }
            last_i = i + 1;
        }

        if diff <= overlap_diff_limit
            || (diff > overlap_diff_limit && last_i > complete_compare_require)
        {
            return Some((offset, overlap_len as usize));
        }

        offset -= 1;
    }
    None
}

/// fastp is documented to prefer R1 bases, no matter what.
#[expect(clippy::cast_sign_loss, reason = "Sign is checked before")]
fn merge_at_offset_fastp(
    seq1: &[u8],
    qual1: &[u8],
    seq2: &[u8],
    qual2: &[u8],
    offset: isize,
    overlap_len: usize,
) -> (Vec<u8>, Vec<u8>) {
    #[expect(clippy::too_many_arguments, reason = "we need them")]
    fn append_overlap(
        seq1: &[u8],
        qual1: &[u8],
        seq2: &[u8],
        qual2: &[u8],
        overlap_len: usize,
        merged_seq: &mut Vec<u8>,
        merged_qual: &mut Vec<u8>,
        offset: usize,
        inside_out: bool,
    ) {
        for i in 0..overlap_len {
            let (pos1, pos2) = if inside_out {
                (i, offset + i)
            } else {
                (offset + i, i)
            };

            let base1 = seq1[pos1];
            let base2 = seq2[pos2];
            let q1 = qual1[pos1];
            let q2 = qual2[pos2];

            if base1 == base2 {
                // Agreement - use base1.
                merged_seq.push(base1);
                merged_qual.push(q1);
            } else {
                // Mismatch - fastp does something special here..
                const GOOD_QUAL: u8 = 30 + 33;
                const BAD_QUAL: u8 = 14 + 33;
                if q2 >= GOOD_QUAL && q1 <= BAD_QUAL {
                    // use R2
                    merged_seq.push(base2);
                    merged_qual.push(q2);
                } else {
                    //use r1
                    merged_seq.push(base1);
                    merged_qual.push(q1);
                }
            }
        }
    }
    let mut merged_seq = Vec::new();
    let mut merged_qual = Vec::new();

    if offset >= 0 {
        let offset = offset as usize;
        // Non-overlapping part of seq1
        merged_seq.extend_from_slice(&seq1[..offset]);
        merged_qual.extend_from_slice(&qual1[..offset]);

        // Overlapping part - resolve mismatches using quality scores
        append_overlap(
            seq1,
            qual1,
            seq2,
            qual2,
            overlap_len,
            &mut merged_seq,
            &mut merged_qual,
            offset,
            false,
        );

        // Non-overlapping part of seq2 - ONLY if offset > 0! to match fastp
        if offset > 0 && overlap_len < seq2.len() {
            merged_seq.extend_from_slice(&seq2[overlap_len..]);
            merged_qual.extend_from_slice(&qual2[overlap_len..]);
        }
    } else {
        let offset = (-offset) as usize;
        // fastp  only keeps the overlapping part.
        // Overlapping part - resolve mismatches using quality scores
        append_overlap(
            seq1,
            qual1,
            seq2,
            qual2,
            overlap_len,
            &mut merged_seq,
            &mut merged_qual,
            offset,
            true,
        );
    }

    (merged_seq, merged_qual)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_find_best_overlap_fastp() {
        let seq1 = b"ACGTACGTACGT";
        let seq2 = b"GTACGTACGTAA";

        let result = find_best_overlap_fastp(seq1, seq2, 4, 0.2, 2);
        assert_eq!(result, Some((2, 10))); // seq2 starts at position 4 in seq1 with overlap length 8

        let result = find_best_overlap_fastp(b"AGTCAA", b"CTCCA", 4, 0.2, 2);
        assert_eq!(result, None); // No sufficient overlap

        let result = find_best_overlap_fastp(b"AGTCAA", b"AGTCAA", 4, 0.2, 2);
        assert_eq!(result, Some((0, 6))); // Perfect overlap
        //
        let result = find_best_overlap_fastp(b"AGTCAA", b"ACAGTCAA", 4, 0.2, 2);
        assert_eq!(result, Some((-2, 6)));

        //good threshold is ?
        //bad threshold is /

        let r = merge_at_offset_fastp(
            b"AAAAAAAAAAAAAAAAAA",
            b"???@@@>>>./0./0./0",
            b"TTTTTTTTTTTTTTTTTT",
            b"./0./0./0???@@@>>>",
            0,
            18,
        );
        assert_eq!(&r.0, b"AAAAAAAAATTATTAAAA");
        //assert_eq!(&r.1, b"cccc");
    }
}