fame 0.3.10

Fame — Facade for Agent Memory over PDT
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
//! Runtime OpenAPI generation for config-driven entities
//!
//! Generates OpenAPI paths and JSON schemas from [`EntityConfig`] definitions,
//! merges them with the existing utoipa-generated spec, and serves the combined
//! result so Aether (and other consumers) can discover document endpoints.

use std::sync::Arc;

use serde_json::{json, Map, Value};
use utoipa::openapi::OpenApi;
use utoipa::OpenApi as OpenApiDerive;

use crate::entity_config::{EntityConfig, FieldType};

/// Generate a merged OpenAPI spec: the existing utoipa [`ApiDoc`] paths/schemas
/// plus dynamically generated paths/schemas for all config-driven entities.
///
/// Uses JSON manipulation on the serialised utoipa spec for simplicity and
/// reliability across utoipa versions.
pub fn generate_merged_openapi(configs: &[Arc<EntityConfig>]) -> OpenApi {
    // Get the base spec from utoipa
    let base_api = crate::models::ApiDoc::openapi();

    // Serialize to JSON for manipulation
    let mut spec: Value = serde_json::to_value(&base_api).unwrap_or_else(|_| {
        json!({
            "openapi": "3.0.3",
            "info": {"title": "NGHR", "version": "0.1.0"},
            "paths": {},
            "components": {"schemas": {}},
        })
    });

    // Ensure paths and components exist
    if spec.get("paths").is_none() {
        spec["paths"] = json!({});
    }
    if spec.get("components").is_none() {
        spec["components"] = json!({});
    }
    if spec["components"].get("schemas").is_none() {
        spec["components"]["schemas"] = json!({});
    }

    for config in configs {
        if config.handler != "generic" {
            continue;
        }

        let slug_plural = format!("{}s", config.slug);
        let base_path = format!("/api/v1/{}", slug_plural);
        let entity_name = &config.name;

        // --- Add schemas ---
        let schemas = &mut spec["components"]["schemas"];

        // Entity response schema
        schemas[entity_name] = generate_entity_schema_json(config);

        // Create request schema
        schemas[&format!("Create{}Request", entity_name)] = generate_create_schema_json(config);

        // List response schema
        schemas[&format!("{}ListResponse", entity_name)] = json!({
            "type": "object",
            "properties": {
                "entities": {
                    "type": "array",
                    "items": {
                        "$ref": format!("#/components/schemas/{}", entity_name)
                    }
                },
                "total": {"type": "integer"}
            },
            "required": ["entities", "total"]
        });

        // --- Add paths ---
        let paths = &mut spec["paths"];

        // GET /{base} — list
        let mut list_params = vec![
            json!({
                "name": "status",
                "in": "query",
                "required": false,
                "schema": {"type": "string"},
                "description": "Filter by status"
            }),
            json!({
                "name": "attached_to",
                "in": "query",
                "required": false,
                "schema": {"type": "string"},
                "description": "Filter by relation target (e.g. project ID)"
            }),
        ];

        // Add enum values to status param if available
        if let Some(values) = config.status_values() {
            list_params[0]["schema"]["enum"] =
                Value::Array(values.iter().map(|v| Value::String(v.clone())).collect());
        }

        paths[&base_path] = json!({
            "get": {
                "operationId": format!("list_{}", slug_plural),
                "tags": ["entities"],
                "parameters": list_params,
                "responses": {
                    "200": {
                        "description": format!("List of {}s", config.slug),
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": format!("#/components/schemas/{}ListResponse", entity_name)
                                }
                            }
                        }
                    }
                }
            },
            "post": {
                "operationId": format!("create_{}", config.slug),
                "tags": ["entities"],
                "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "$ref": format!("#/components/schemas/Create{}Request", entity_name)
                            }
                        }
                    }
                },
                "responses": {
                    "201": {
                        "description": format!("{} created", entity_name),
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": format!("#/components/schemas/{}", entity_name)
                                }
                            }
                        }
                    }
                }
            }
        });

        // GET /{base}/{id} — get
        paths[&format!("{}/{{id}}", base_path)] = json!({
            "get": {
                "operationId": format!("get_{}", config.slug),
                "tags": ["entities"],
                "parameters": [
                    {"name": "id", "in": "path", "required": true, "schema": {"type": "string"}}
                ],
                "responses": {
                    "200": {
                        "description": format!("{} details", entity_name),
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": format!("#/components/schemas/{}", entity_name)
                                }
                            }
                        }
                    }
                }
            }
        });

        // PATCH /{base}/{id}/content — agent identity charters only (v0.3.0):
        // the governed identity-content update surface (tocpi calls this for
        // in-place re-chartering). Mirrors the tocpi content contract.
        if config.slug == "agent-identity" {
            paths[&format!("{}/{{id}}/content", base_path)] = json!({
                "patch": {
                    "operationId": format!("update_{}_content", config.slug),
                    "tags": ["entities"],
                    "parameters": [
                        {"name": "id", "in": "path", "required": true, "schema": {"type": "string"}},
                        {"name": "X-Instance-Id", "in": "header", "required": true, "schema": {"type": "string"}, "description": "Agent asset ID — identity content is instance-scoped (agent nested DB)"}
                    ],
                    "requestBody": {
                        "content": {
                            "application/json": {
                                "schema": {
                                    "type": "object",
                                    "properties": {
                                        "content": {"type": "string", "description": "New identity content (empty string = explicit wipe, logged)"}
                                    },
                                    "required": ["content"]
                                }
                            }
                        }
                    },
                    "responses": {
                        "200": {
                            "description": "Content updated in place (entity + old→new sha256 echo)",
                            "content": {
                                "application/json": {
                                    "schema": {
                                        "type": "object",
                                        "properties": {
                                            "content_hash": {
                                                "type": "object",
                                                "properties": {
                                                    "old": {"type": ["string", "null"]},
                                                    "new": {"type": "string"}
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        },
                        "400": {"description": "Missing X-Instance-Id or content field"},
                        "403": {"description": "Cedar deny — principal outside the stored admin_group"},
                        "404": {"description": "Identity not found (never create-on-miss)"}
                    }
                }
            });
        }

        // PATCH /{base}/{id}/status
        paths[&format!("{}/{{id}}/status", base_path)] = json!({
            "patch": {
                "operationId": format!("update_{}_status", config.slug),
                "tags": ["entities"],
                "parameters": [
                    {"name": "id", "in": "path", "required": true, "schema": {"type": "string"}}
                ],
                "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "type": "object",
                                "properties": {
                                    "status": {"type": "string"}
                                },
                                "required": ["status"]
                            }
                        }
                    }
                },
                "responses": {
                    "200": {
                        "description": "Status updated",
                        "content": {
                            "application/json": {
                                "schema": {
                                    "$ref": format!("#/components/schemas/{}", entity_name)
                                }
                            }
                        }
                    }
                }
            }
        });
    }

    // Ensure every schema object in the spec has a "required" field.
    // utoipa 5.x's OpenApi deserializer requires "required" on all Object schemas,
    // but the base spec and inline path schemas may omit it when empty.
    ensure_required_fields(&mut spec);

    // Deserialize back into OpenApi
    serde_json::from_value(spec).unwrap_or_else(|e| {
        tracing::error!("Failed to rebuild OpenAPI spec: {}", e);
        crate::models::ApiDoc::openapi()
    })
}

/// Map a [`FieldType`] to an OpenAPI schema type string.
fn field_type_to_openapi(ft: &FieldType) -> &'static str {
    match ft {
        FieldType::Text | FieldType::Markdown => "string",
        FieldType::Date => "string",
        FieldType::Enum => "string",
        FieldType::TagArray => "array",
        FieldType::Relation => "string",
        FieldType::Metadata => "object",
    }
}

/// Generate a JSON Schema object for the entity response.
fn generate_entity_schema_json(config: &EntityConfig) -> Value {
    let mut props = Map::new();

    // Always include id
    props.insert("id".to_string(), json!({"type": "string"}));

    for (field_name, field_config) in &config.fields {
        let type_str = field_type_to_openapi(&field_config.field_type);

        let mut field_schema = json!({"type": type_str});

        if let Some(values) = &field_config.values {
            field_schema["enum"] =
                Value::Array(values.iter().map(|v| Value::String(v.clone())).collect());
        }

        if let Some(label) = &field_config.label {
            field_schema["description"] = Value::String(label.clone());
        }

        props.insert(field_name.clone(), field_schema);
    }

    // Ensure created_at/updated_at exist
    if !props.contains_key("created_at") {
        props.insert(
            "created_at".to_string(),
            json!({"type": "string", "format": "date-time"}),
        );
    }
    if !props.contains_key("updated_at") {
        props.insert(
            "updated_at".to_string(),
            json!({"type": "string", "format": "date-time"}),
        );
    }

    let mut required: Vec<String> = config
        .fields
        .iter()
        .filter(|(_, fc)| fc.required)
        .map(|(name, _)| name.clone())
        .collect();
    required.push("id".to_string());

    json!({
        "type": "object",
        "properties": props,
        "required": required,
    })
}

/// Generate the create request schema for an entity.
fn generate_create_schema_json(config: &EntityConfig) -> Value {
    let mut props = Map::new();
    let mut required: Vec<String> = Vec::new();

    for (field_name, field_config) in &config.fields {
        // Skip computed/system fields
        if matches!(
            field_config.map.as_deref(),
            Some("created_at") | Some("updated_at")
        ) {
            continue;
        }

        let type_str = field_type_to_openapi(&field_config.field_type);

        let mut field_schema = json!({"type": type_str});

        if let Some(values) = &field_config.values {
            field_schema["enum"] =
                Value::Array(values.iter().map(|v| Value::String(v.clone())).collect());
        }

        props.insert(field_name.clone(), field_schema);

        if field_config.required {
            required.push(field_name.clone());
        }
    }

    json!({
        "type": "object",
        "properties": props,
        "required": required,
    })
}

/// Recursively walk the spec JSON and ensure every object schema has a "required" field.
///
/// utoipa 5.x's `OpenApi` deserializer treats `required` as a non-optional field
/// on `Object` types. Schemas generated via `json!({})` or from older base specs
/// may omit it entirely, causing `missing field 'required'` deserialization errors.
/// This function patches all such schemas to include `"required": []` where missing.
fn ensure_required_fields(spec: &mut Value) {
    // Recursively walk the entire JSON tree. Any object that has "properties"
    // but no "required" gets patched. Also patches "parameters" in path operations.
    ensure_required_recursive(spec);
}

/// Recursive walker — patches any dict that looks like a schema (has "properties")
/// or a parameter (has "in") that's missing "required".
fn ensure_required_recursive(value: &mut Value) {
    match value {
        Value::Object(map) => {
            // Patch object schemas: has "properties" or type=="object" but no "required"
            let is_object_schema = map.get("type").and_then(|v| v.as_str()) == Some("object")
                || map.contains_key("properties");
            if is_object_schema && !map.contains_key("required") {
                map.insert("required".to_string(), json!([]));
            }

            // Patch parameters: has "in" (query/path/header/cookie) but no "required"
            if map.contains_key("in") && !map.contains_key("required") {
                map.insert("required".to_string(), json!(false));
            }

            // Recurse into all values
            for (_, v) in map.iter_mut() {
                ensure_required_recursive(v);
            }
        }
        Value::Array(arr) => {
            for item in arr.iter_mut() {
                ensure_required_recursive(item);
            }
        }
        _ => {}
    }
}