Skip to main content

fallow_graph/resolve/
mod.rs

1//! Import specifier resolution using `oxc_resolver`.
2//!
3//! Orchestrates the resolution pipeline: for every extracted module, resolves all
4//! import specifiers in parallel (via rayon) to an [`ResolveResult`] — internal file,
5//! npm package, external file, or unresolvable. The entry point is [`resolve_all_imports`].
6//!
7//! Resolution is split into submodules by import kind:
8//! - `static_imports` — ES `import` declarations
9//! - `dynamic_imports` — `import()` expressions and glob-based dynamic patterns
10//! - `require_imports` — CommonJS `require()` calls
11//! - `re_exports` — `export { x } from './y'` re-export sources
12//! - `upgrades` — post-resolution pass fixing non-deterministic bare specifier results
13//!
14//! Handles tsconfig path aliases (auto-discovered per file), pnpm virtual store paths,
15//! React Native platform extensions, and package.json `exports` subpath resolution with
16//! output-to-source directory fallback.
17
18mod dynamic_imports;
19pub(crate) mod fallbacks;
20mod path_info;
21mod re_exports;
22mod react_native;
23mod require_imports;
24mod specifier;
25mod static_imports;
26#[cfg(test)]
27mod tests;
28mod types;
29mod upgrades;
30
31pub use path_info::{extract_package_name, is_bare_specifier, is_path_alias};
32pub use types::{ResolveResult, ResolvedImport, ResolvedModule, ResolvedReExport};
33
34use std::path::{Path, PathBuf};
35use std::sync::Mutex;
36
37use rayon::prelude::*;
38use rustc_hash::{FxHashMap, FxHashSet};
39
40use fallow_types::discover::{DiscoveredFile, FileId};
41use fallow_types::extract::ModuleInfo;
42
43use dynamic_imports::{resolve_dynamic_imports, resolve_dynamic_patterns};
44use re_exports::resolve_re_exports;
45use require_imports::resolve_require_imports;
46use specifier::create_resolver;
47use static_imports::resolve_static_imports;
48use types::ResolveContext;
49use upgrades::apply_specifier_upgrades;
50
51/// Resolve all imports across all modules in parallel.
52#[must_use]
53#[expect(
54    clippy::too_many_arguments,
55    reason = "resolver inputs come from disjoint sources (config, plugins, workspace, filesystem); \
56              bundling them into a struct would be a cross-cutting refactor outside this task"
57)]
58pub fn resolve_all_imports(
59    modules: &[ModuleInfo],
60    files: &[DiscoveredFile],
61    workspaces: &[fallow_config::WorkspaceInfo],
62    active_plugins: &[String],
63    path_aliases: &[(String, String)],
64    scss_include_paths: &[PathBuf],
65    root: &Path,
66    extra_conditions: &[String],
67) -> Vec<ResolvedModule> {
68    // Build workspace name → root index for pnpm store fallback.
69    // Canonicalize roots to match path_to_id (which uses canonical paths).
70    // Without this, macOS /var → /private/var and similar platform symlinks
71    // cause workspace roots to mismatch canonical file paths.
72    let canonical_ws_roots: Vec<PathBuf> = workspaces
73        .par_iter()
74        .map(|ws| dunce::canonicalize(&ws.root).unwrap_or_else(|_| ws.root.clone()))
75        .collect();
76    let workspace_roots: FxHashMap<&str, &Path> = workspaces
77        .iter()
78        .zip(canonical_ws_roots.iter())
79        .map(|(ws, canonical)| (ws.name.as_str(), canonical.as_path()))
80        .collect();
81
82    // Check if project root is already canonical (no symlinks in path).
83    // When true, raw paths == canonical paths for files under root, so we can skip
84    // the upfront bulk canonicalize() of all source files (21k+ syscalls on large projects).
85    // A lazy CanonicalFallback handles the rare intra-project symlink case.
86    let root_is_canonical = dunce::canonicalize(root).is_ok_and(|c| c == root);
87
88    // Pre-compute canonical paths ONCE for all files in parallel (avoiding repeated syscalls).
89    // Skipped when root is canonical — the lazy fallback below handles edge cases.
90    let canonical_paths: Vec<PathBuf> = if root_is_canonical {
91        Vec::new()
92    } else {
93        files
94            .par_iter()
95            .map(|f| dunce::canonicalize(&f.path).unwrap_or_else(|_| f.path.clone()))
96            .collect()
97    };
98
99    // Primary path → FileId index. When root is canonical, uses raw paths (fast).
100    // Otherwise uses pre-computed canonical paths (correct for all symlink configurations).
101    let path_to_id: FxHashMap<&Path, FileId> = if root_is_canonical {
102        files.iter().map(|f| (f.path.as_path(), f.id)).collect()
103    } else {
104        canonical_paths
105            .iter()
106            .enumerate()
107            .map(|(idx, canonical)| (canonical.as_path(), files[idx].id))
108            .collect()
109    };
110
111    // Also index by non-canonical path for fallback lookups
112    let raw_path_to_id: FxHashMap<&Path, FileId> =
113        files.iter().map(|f| (f.path.as_path(), f.id)).collect();
114
115    // FileIds are sequential 0..n, so direct array indexing is faster than FxHashMap.
116    let file_paths: Vec<&Path> = files.iter().map(|f| f.path.as_path()).collect();
117
118    // Create resolver ONCE and share across threads (oxc_resolver::Resolver is Send + Sync)
119    let resolver = create_resolver(active_plugins, extra_conditions);
120
121    // Lazy canonical fallback — only needed when root is canonical (path_to_id uses raw paths).
122    // When root is NOT canonical, path_to_id already uses canonical paths, no fallback needed.
123    let canonical_fallback = if root_is_canonical {
124        Some(types::CanonicalFallback::new(files))
125    } else {
126        None
127    };
128
129    // Dedup set for broken-tsconfig warnings. See `ResolveContext::tsconfig_warned`.
130    let tsconfig_warned: Mutex<FxHashSet<String>> = Mutex::new(FxHashSet::default());
131
132    // Shared resolution context — avoids passing 6 arguments to every resolve_specifier call
133    let ctx = ResolveContext {
134        resolver: &resolver,
135        path_to_id: &path_to_id,
136        raw_path_to_id: &raw_path_to_id,
137        workspace_roots: &workspace_roots,
138        path_aliases,
139        scss_include_paths,
140        root,
141        canonical_fallback: canonical_fallback.as_ref(),
142        tsconfig_warned: &tsconfig_warned,
143    };
144
145    // Resolve in parallel — shared resolver instance.
146    // Each file resolves its own imports independently (no shared bare specifier cache).
147    // oxc_resolver's internal caches (package.json, tsconfig, directory entries) are
148    // shared across threads for performance.
149    let mut resolved: Vec<ResolvedModule> = modules
150        .par_iter()
151        .filter_map(|module| {
152            let Some(file_path) = file_paths.get(module.file_id.0 as usize) else {
153                tracing::warn!(
154                    file_id = module.file_id.0,
155                    "Skipping module with unknown file_id during resolution"
156                );
157                return None;
158            };
159
160            let mut all_imports = resolve_static_imports(&ctx, file_path, &module.imports);
161            all_imports.extend(resolve_require_imports(
162                &ctx,
163                file_path,
164                &module.require_calls,
165            ));
166
167            let from_dir = if canonical_paths.is_empty() {
168                // Root is canonical — raw paths are canonical
169                file_path.parent().unwrap_or(file_path)
170            } else {
171                canonical_paths
172                    .get(module.file_id.0 as usize)
173                    .and_then(|p| p.parent())
174                    .unwrap_or(file_path)
175            };
176
177            Some(ResolvedModule {
178                file_id: module.file_id,
179                path: file_path.to_path_buf(),
180                exports: module.exports.clone(),
181                re_exports: resolve_re_exports(&ctx, file_path, &module.re_exports),
182                resolved_imports: all_imports,
183                resolved_dynamic_imports: resolve_dynamic_imports(
184                    &ctx,
185                    file_path,
186                    &module.dynamic_imports,
187                ),
188                resolved_dynamic_patterns: resolve_dynamic_patterns(
189                    from_dir,
190                    &module.dynamic_import_patterns,
191                    &canonical_paths,
192                    files,
193                ),
194                member_accesses: module.member_accesses.clone(),
195                whole_object_uses: module.whole_object_uses.clone(),
196                has_cjs_exports: module.has_cjs_exports,
197                unused_import_bindings: module.unused_import_bindings.iter().cloned().collect(),
198            })
199        })
200        .collect();
201
202    apply_specifier_upgrades(&mut resolved);
203
204    resolved
205}