Skip to main content

fallow_engine/
vital_signs.rs

1//! Vital signs computation and snapshot persistence.
2//!
3//! Vital signs are a fixed set of project-wide metrics computed from available
4//! health data. They are always shown as a summary in the health report and can
5//! be persisted to `.fallow/snapshots/` for Phase 2b trend tracking.
6
7use std::path::{Path, PathBuf};
8
9use crate::git_env::clear_ambient_git_env;
10
11/// Number of seconds in one day.
12const SECS_PER_DAY: u64 = 86_400;
13
14use fallow_output::{
15    DEFAULT_CYCLOMATIC_CRITICAL, FileHealthScore, HEALTH_SCORE_FORMULA_VERSION,
16    HOTSPOT_SCORE_THRESHOLD, HealthScore, HealthScorePenalties, HealthTrend, HotspotEntry,
17    RiskProfile, SNAPSHOT_SCHEMA_VERSION, TrendCount, TrendDirection, TrendMetric, TrendPoint,
18    VitalSigns, VitalSignsCounts, VitalSignsSnapshot, letter_grade,
19};
20
21/// Data sources for computing vital signs.
22///
23/// Fields are `Option` because not all pipelines run in every health invocation.
24pub struct VitalSignsInput<'a> {
25    /// All parsed modules (always available).
26    pub modules: &'a [crate::source::ModuleInfo],
27    /// Optional file-id allowlist used to restrict per-module aggregates
28    /// (cyclomatic distribution, total LOC, unit profiles) to a subset.
29    /// Used by `--workspace` and `--group-by` to scope project-wide metrics
30    /// to a single workspace package without re-parsing.
31    /// `None` includes every module in `modules`.
32    pub module_filter: Option<&'a rustc_hash::FxHashSet<crate::discover::FileId>>,
33    /// File health scores (available when file_scores/hotspots/targets are computed).
34    pub file_scores: Option<&'a [FileHealthScore]>,
35    /// Hotspot entries (available when hotspots are computed).
36    pub hotspots: Option<&'a [HotspotEntry]>,
37    /// Total discovered files (already scoped to the workspace when `--workspace` is set).
38    pub total_files: usize,
39    /// Analysis results (available when file_scores pipeline ran). When a
40    /// `module_filter` is also set, callers should pass workspace-scoped
41    /// counts here so `dead_*_pct` denominators line up with the rest of the
42    /// metrics.
43    pub analysis_counts: Option<AnalysisCounts>,
44}
45
46impl<'a> VitalSignsInput<'a> {
47    /// Iterate the modules selected by `module_filter`.
48    fn selected_modules(&self) -> impl Iterator<Item = &'a crate::source::ModuleInfo> + '_ {
49        let filter = self.module_filter;
50        self.modules
51            .iter()
52            .filter(move |m| filter.is_none_or(|set| set.contains(&m.file_id)))
53    }
54}
55
56/// Aggregate counts from the analysis pipeline.
57#[derive(Clone, Copy)]
58pub struct AnalysisCounts {
59    pub total_exports: usize,
60    pub dead_files: usize,
61    pub dead_exports: usize,
62    pub unused_deps: usize,
63    pub circular_deps: usize,
64    pub total_deps: usize,
65}
66
67fn collect_sorted_cyclomatic(input: &VitalSignsInput<'_>) -> Vec<u16> {
68    let mut values: Vec<u16> = input
69        .selected_modules()
70        .flat_map(|m| m.complexity.iter().map(|c| c.cyclomatic))
71        .collect();
72    values.sort_unstable();
73    values
74}
75
76fn average_cyclomatic(all_cyclomatic: &[u16]) -> f64 {
77    if all_cyclomatic.is_empty() {
78        return 0.0;
79    }
80
81    let sum: u64 = all_cyclomatic.iter().map(|&c| u64::from(c)).sum();
82    (sum as f64 / all_cyclomatic.len() as f64 * 10.0).round() / 10.0
83}
84
85fn critical_complexity_pct(all_cyclomatic: &[u16]) -> Option<f64> {
86    if all_cyclomatic.is_empty() {
87        return None;
88    }
89
90    let critical_count = all_cyclomatic
91        .iter()
92        .filter(|&&c| c >= DEFAULT_CYCLOMATIC_CRITICAL)
93        .count();
94    Some((critical_count as f64 / all_cyclomatic.len() as f64 * 1000.0).round() / 10.0)
95}
96
97#[expect(
98    clippy::cast_possible_truncation,
99    reason = "percentile index is bounded by the cyclomatic collection length"
100)]
101fn p90_cyclomatic(all_cyclomatic: &[u16]) -> u32 {
102    if all_cyclomatic.is_empty() {
103        return 0;
104    }
105
106    let idx = (all_cyclomatic.len() as f64 * 0.9).ceil() as usize;
107    let idx = idx.min(all_cyclomatic.len()) - 1;
108    u32::from(all_cyclomatic[idx])
109}
110
111#[expect(
112    clippy::cast_possible_truncation,
113    reason = "analysis counts are bounded by project size and emitted as compact u32 metrics"
114)]
115fn analysis_count_vitals(
116    counts: Option<&AnalysisCounts>,
117    total_files: usize,
118) -> (Option<f64>, Option<f64>, Option<u32>, Option<u32>) {
119    let Some(counts) = counts else {
120        return (None, None, None, None);
121    };
122
123    let dead_file_pct = if total_files > 0 {
124        Some((counts.dead_files as f64 / total_files as f64 * 1000.0).round() / 10.0)
125    } else {
126        Some(0.0)
127    };
128    let dead_export_pct = if counts.total_exports > 0 {
129        Some((counts.dead_exports as f64 / counts.total_exports as f64 * 1000.0).round() / 10.0)
130    } else {
131        Some(0.0)
132    };
133
134    (
135        dead_file_pct,
136        dead_export_pct,
137        Some(counts.unused_deps as u32),
138        Some(counts.circular_deps as u32),
139    )
140}
141
142struct SelectedModuleMetrics {
143    total_loc: u64,
144    line_counts: Vec<u32>,
145    param_counts: Vec<u8>,
146}
147
148fn selected_module_metrics(input: &VitalSignsInput<'_>) -> SelectedModuleMetrics {
149    let mut total_loc = 0;
150    let mut line_counts = Vec::new();
151    let mut param_counts = Vec::new();
152
153    for module in input.selected_modules() {
154        total_loc += module.line_offsets.len() as u64;
155        line_counts.extend(module.complexity.iter().map(|c| c.line_count));
156        param_counts.extend(module.complexity.iter().map(|c| c.param_count));
157    }
158
159    SelectedModuleMetrics {
160        total_loc,
161        line_counts,
162        param_counts,
163    }
164}
165
166fn vital_sign_counts(input: &VitalSignsInput<'_>, total_loc: u64) -> Option<VitalSignsCounts> {
167    input.analysis_counts.as_ref().map(|ac| VitalSignsCounts {
168        total_files: input.total_files,
169        total_exports: ac.total_exports,
170        dead_files: ac.dead_files,
171        dead_exports: ac.dead_exports,
172        duplicated_lines: None,
173        total_lines: Some(total_loc as usize),
174        files_scored: input.file_scores.map(<[_]>::len),
175        total_deps: ac.total_deps,
176    })
177}
178
179/// Compute vital signs from available health data.
180pub fn compute_vital_signs(input: &VitalSignsInput<'_>) -> VitalSigns {
181    let all_cyclomatic = collect_sorted_cyclomatic(input);
182    let avg_cyclomatic = average_cyclomatic(&all_cyclomatic);
183    let critical_complexity_pct = critical_complexity_pct(&all_cyclomatic);
184    let p90_cyclomatic = p90_cyclomatic(&all_cyclomatic);
185
186    let (dead_file_pct, dead_export_pct, unused_dep_count, circular_dep_count) =
187        analysis_count_vitals(input.analysis_counts.as_ref(), input.total_files);
188    let unused_deps_per_k_files =
189        unused_dep_count.map(|count| per_k_files(count, input.total_files));
190    let circular_deps_per_k_files =
191        circular_dep_count.map(|count| per_k_files(count, input.total_files));
192
193    let (maintainability_avg, maintainability_low_pct) = maintainability_vitals(input.file_scores);
194
195    let (hotspot_count, hotspot_top_pct_count) = hotspot_vitals(input.hotspots, input.total_files);
196
197    let module_metrics = selected_module_metrics(input);
198    let counts = vital_sign_counts(input, module_metrics.total_loc);
199    let functions_over_60_loc_per_k = functions_over_60_loc_per_k(&module_metrics.line_counts);
200    let unit_size_profile = unit_size_profile(&module_metrics.line_counts);
201
202    let unit_interfacing_profile =
203        unit_interfacing_profile(&module_metrics.param_counts, &all_cyclomatic);
204
205    let (p95_fan_in, coupling_high_pct) = if let Some(scores) = input.file_scores {
206        compute_coupling_concentration(scores)
207    } else {
208        (None, None)
209    };
210
211    VitalSigns {
212        dead_file_pct,
213        dead_export_pct,
214        avg_cyclomatic,
215        critical_complexity_pct,
216        p90_cyclomatic,
217        duplication_pct: None, // Lazy: only set if duplication pipeline was run
218        hotspot_count,
219        hotspot_top_pct_count,
220        maintainability_avg,
221        maintainability_low_pct,
222        unused_dep_count,
223        unused_deps_per_k_files,
224        circular_dep_count,
225        circular_deps_per_k_files,
226        counts,
227        unit_size_profile,
228        functions_over_60_loc_per_k,
229        unit_interfacing_profile,
230        p95_fan_in,
231        coupling_high_pct,
232        // Set post-construction from the whole-project analysis results (only
233        // when the opt-in prop-drilling rule is enabled); see health/mod.rs.
234        prop_drilling_chain_count: None,
235        prop_drilling_max_depth: None,
236        // Set post-construction from the whole-project render fan-in metric
237        // (whenever React is declared, the core metric carries the aggregates);
238        // see health/mod.rs.
239        p95_render_fan_in: None,
240        render_fan_in_high_pct: None,
241        max_render_fan_in: None,
242        top_render_fan_in: Vec::new(),
243        total_loc: module_metrics.total_loc,
244    }
245}
246
247fn per_k_files(count: u32, total_files: usize) -> f64 {
248    if total_files == 0 {
249        0.0
250    } else {
251        (f64::from(count) / total_files as f64 * 10_000.0).round() / 10.0
252    }
253}
254
255fn maintainability_vitals(scores: Option<&[FileHealthScore]>) -> (Option<f64>, Option<f64>) {
256    let Some(scores) = scores.filter(|scores| !scores.is_empty()) else {
257        return (None, None);
258    };
259    let sum: f64 = scores.iter().map(|s| s.maintainability_index).sum();
260    let low_count = scores
261        .iter()
262        .filter(|s| s.maintainability_index < 70.0)
263        .count();
264    (
265        Some((sum / scores.len() as f64 * 10.0).round() / 10.0),
266        Some((low_count as f64 / scores.len() as f64 * 1000.0).round() / 10.0),
267    )
268}
269
270fn hotspot_vitals(
271    hotspots: Option<&[HotspotEntry]>,
272    total_files: usize,
273) -> (Option<u32>, Option<u32>) {
274    let hotspot_count = hotspots.map(|entries| {
275        entries
276            .iter()
277            .filter(|e| e.score >= HOTSPOT_SCORE_THRESHOLD)
278            .count() as u32
279    });
280    let hotspot_top_pct_count = hotspots.map(|entries| {
281        if total_files == 0 || entries.is_empty() {
282            return 0;
283        }
284        let top_count = (total_files as f64 * 0.01).ceil() as usize;
285        entries
286            .iter()
287            .take(top_count.max(1))
288            .filter(|entry| entry.score > 0.0)
289            .count() as u32
290    });
291    (hotspot_count, hotspot_top_pct_count)
292}
293
294fn functions_over_60_loc_per_k(line_counts: &[u32]) -> Option<f64> {
295    if line_counts.is_empty() {
296        return None;
297    }
298    let over_60 = line_counts
299        .iter()
300        .filter(|&&line_count| line_count > 60)
301        .count();
302    Some((over_60 as f64 / line_counts.len() as f64 * 10_000.0).round() / 10.0)
303}
304
305fn unit_size_profile(line_counts: &[u32]) -> Option<RiskProfile> {
306    (!line_counts.is_empty()).then(|| compute_size_risk_profile(line_counts))
307}
308
309fn unit_interfacing_profile(param_counts: &[u8], all_cyclomatic: &[u16]) -> Option<RiskProfile> {
310    if all_cyclomatic.is_empty() {
311        return None;
312    }
313    Some(compute_interfacing_risk_profile(param_counts))
314}
315
316/// Compute unit size risk profile from function line counts.
317///
318/// Bins: low risk (1-15 LOC), medium risk (16-30), high risk (31-60), very high risk (>60).
319fn compute_size_risk_profile(line_counts: &[u32]) -> RiskProfile {
320    if line_counts.is_empty() {
321        return RiskProfile {
322            low_risk: 0.0,
323            medium_risk: 0.0,
324            high_risk: 0.0,
325            very_high_risk: 0.0,
326        };
327    }
328    let total = line_counts.len() as f64;
329    let low = line_counts.iter().filter(|&&lc| lc <= 15).count() as f64;
330    let medium = line_counts
331        .iter()
332        .filter(|&&lc| (16..=30).contains(&lc))
333        .count() as f64;
334    let high = line_counts
335        .iter()
336        .filter(|&&lc| (31..=60).contains(&lc))
337        .count() as f64;
338    let very_high = line_counts.iter().filter(|&&lc| lc > 60).count() as f64;
339    RiskProfile {
340        low_risk: (low / total * 1000.0).round() / 10.0,
341        medium_risk: (medium / total * 1000.0).round() / 10.0,
342        high_risk: (high / total * 1000.0).round() / 10.0,
343        very_high_risk: (very_high / total * 1000.0).round() / 10.0,
344    }
345}
346
347/// Compute unit interfacing risk profile from function parameter counts.
348///
349/// Bins: low risk (0-2 params), medium risk (3-4), high risk (5-6), very high risk (>=7).
350fn compute_interfacing_risk_profile(param_counts: &[u8]) -> RiskProfile {
351    if param_counts.is_empty() {
352        return RiskProfile {
353            low_risk: 0.0,
354            medium_risk: 0.0,
355            high_risk: 0.0,
356            very_high_risk: 0.0,
357        };
358    }
359    let total = param_counts.len() as f64;
360    let low = param_counts.iter().filter(|&&pc| pc <= 2).count() as f64;
361    let medium = param_counts
362        .iter()
363        .filter(|&&pc| (3..=4).contains(&pc))
364        .count() as f64;
365    let high = param_counts
366        .iter()
367        .filter(|&&pc| (5..=6).contains(&pc))
368        .count() as f64;
369    let very_high = param_counts.iter().filter(|&&pc| pc >= 7).count() as f64;
370    RiskProfile {
371        low_risk: (low / total * 1000.0).round() / 10.0,
372        medium_risk: (medium / total * 1000.0).round() / 10.0,
373        high_risk: (high / total * 1000.0).round() / 10.0,
374        very_high_risk: (very_high / total * 1000.0).round() / 10.0,
375    }
376}
377
378/// Compute coupling concentration from file health scores.
379///
380/// Returns (p95_fan_in, coupling_high_pct) where coupling_high_pct is the
381/// percentage of files with fan-in above the effective threshold (max(p95_fan_in, 10)).
382///
383/// The component-graph analogue (render fan-in concentration:
384/// `p95_render_fan_in` / `render_fan_in_high_pct` / `max_render_fan_in`) is
385/// computed in core (`crate::render_fan_in`), which has the
386/// resolved-module graph the CLI lacks. It mirrors this helper verbatim (p95 +
387/// `high_pct` over the per-component distinct-parents distribution, reusing the
388/// same `max(p95, 10)` floor) and is assigned onto `VitalSigns` in
389/// `health/mod.rs::prepare_health_vital_data`.
390#[expect(
391    clippy::cast_possible_truncation,
392    reason = "fan-in values are bounded by project size"
393)]
394fn compute_coupling_concentration(scores: &[FileHealthScore]) -> (Option<u32>, Option<f64>) {
395    if scores.is_empty() {
396        return (None, None);
397    }
398    let mut fan_ins: Vec<usize> = scores.iter().map(|s| s.fan_in).collect();
399    fan_ins.sort_unstable();
400    let idx = (fan_ins.len() as f64 * 0.95).ceil() as usize;
401    let idx = idx.min(fan_ins.len()) - 1;
402    let p95 = fan_ins[idx] as u32;
403
404    let threshold = (p95 as usize).max(10);
405    let high_count = fan_ins.iter().filter(|&&fi| fi > threshold).count();
406    let high_pct = (high_count as f64 / fan_ins.len() as f64 * 1000.0).round() / 10.0;
407
408    (Some(p95), Some(high_pct))
409}
410
411/// Compute a project-level health score from vital signs.
412///
413/// The score starts at 100 and subtracts penalties for each metric.
414/// Missing metrics (from pipelines that didn't run) don't penalize.
415/// `total_files` is used to normalize the hotspot count penalty.
416pub fn compute_health_score(vs: &VitalSigns, total_files: usize) -> HealthScore {
417    let penalties = compute_health_score_penalties(vs, total_files);
418    let score = apply_health_score_penalties(&penalties);
419    let grade = letter_grade(score);
420
421    HealthScore {
422        formula_version: HEALTH_SCORE_FORMULA_VERSION,
423        score,
424        grade,
425        penalties,
426    }
427}
428
429fn compute_health_score_penalties(vs: &VitalSigns, total_files: usize) -> HealthScorePenalties {
430    HealthScorePenalties {
431        dead_files: vs.dead_file_pct.map(|pct| round1((pct * 0.2).min(15.0))),
432        dead_exports: vs.dead_export_pct.map(|pct| round1((pct * 0.2).min(15.0))),
433        complexity: complexity_penalty(vs),
434        p90_complexity: p90_complexity_penalty(vs),
435        maintainability: maintainability_penalty(vs),
436        hotspots: hotspot_penalty(vs, total_files),
437        unused_deps: dependency_count_penalty(
438            vs.unused_deps_per_k_files,
439            vs.unused_dep_count,
440            25.0,
441            10.0,
442        ),
443        circular_deps: dependency_count_penalty(
444            vs.circular_deps_per_k_files,
445            vs.circular_dep_count,
446            25.0,
447            10.0,
448        ),
449        unit_size: unit_size_penalty(vs),
450        coupling: coupling_penalty(vs),
451        duplication: vs
452            .duplication_pct
453            .map(|dp| round1((dp - 5.0).clamp(0.0, 10.0))),
454        prop_drilling: prop_drilling_penalty(vs),
455    }
456}
457
458fn apply_health_score_penalties(penalties: &HealthScorePenalties) -> f64 {
459    let mut score = 100.0_f64;
460
461    subtract_optional_penalty(&mut score, penalties.dead_files);
462    subtract_optional_penalty(&mut score, penalties.dead_exports);
463    score -= penalties.complexity;
464    score -= penalties.p90_complexity;
465    subtract_optional_penalty(&mut score, penalties.maintainability);
466    subtract_optional_penalty(&mut score, penalties.hotspots);
467    subtract_optional_penalty(&mut score, penalties.unused_deps);
468    subtract_optional_penalty(&mut score, penalties.circular_deps);
469    subtract_optional_penalty(&mut score, penalties.unit_size);
470    subtract_optional_penalty(&mut score, penalties.coupling);
471    subtract_optional_penalty(&mut score, penalties.duplication);
472    subtract_optional_penalty(&mut score, penalties.prop_drilling);
473
474    round1(score).clamp(0.0, 100.0)
475}
476
477/// Small capped penalty for prop-drilling chains, sized like the coupling
478/// penalty (~5pt cap). Each located chain costs 1pt up to the cap; a deeper
479/// chain does not cost more (depth is descriptive, not a tunable threshold).
480/// `None` (no penalty) unless the opt-in `prop-drilling` rule populated the
481/// count, so the score is unchanged by default.
482fn prop_drilling_penalty(vs: &VitalSigns) -> Option<f64> {
483    vs.prop_drilling_chain_count
484        .map(|count| round1((f64::from(count) * 1.0).min(5.0)))
485}
486
487fn round1(value: f64) -> f64 {
488    (value * 10.0).round() / 10.0
489}
490
491fn subtract_optional_penalty(score: &mut f64, penalty: Option<f64>) {
492    if let Some(penalty) = penalty {
493        *score -= penalty;
494    }
495}
496
497fn complexity_penalty(vs: &VitalSigns) -> f64 {
498    if let Some(critical_pct) = vs.critical_complexity_pct {
499        round1((critical_pct * 4.0).min(20.0))
500    } else {
501        round1(((vs.avg_cyclomatic - 1.5).max(0.0) * 5.0).min(20.0))
502    }
503}
504
505fn p90_complexity_penalty(vs: &VitalSigns) -> f64 {
506    if vs.critical_complexity_pct.is_some() {
507        0.0
508    } else {
509        round1((f64::from(vs.p90_cyclomatic) - 10.0).clamp(0.0, 10.0))
510    }
511}
512
513fn maintainability_penalty(vs: &VitalSigns) -> Option<f64> {
514    if let Some(low_pct) = vs.maintainability_low_pct {
515        Some(round1((low_pct * 1.5).min(15.0)))
516    } else {
517        vs.maintainability_avg
518            .map(|mi| round1(((70.0 - mi).max(0.0) * 0.5).min(15.0)))
519    }
520}
521
522fn hotspot_penalty(vs: &VitalSigns, total_files: usize) -> Option<f64> {
523    if let Some(top_pct_count) = vs.hotspot_top_pct_count {
524        return Some(if total_files > 0 {
525            let top_pct_bucket = (total_files as f64 * 0.01).ceil().max(1.0);
526            round1((f64::from(top_pct_count) / top_pct_bucket * 10.0).min(10.0))
527        } else {
528            0.0
529        });
530    }
531
532    vs.hotspot_count.map(|hc| {
533        if total_files > 0 {
534            round1((f64::from(hc) / total_files as f64 * 200.0).min(10.0))
535        } else {
536            0.0
537        }
538    })
539}
540
541fn dependency_count_penalty(
542    per_k: Option<f64>,
543    count: Option<u32>,
544    per_k_cap: f64,
545    count_cap: f64,
546) -> Option<f64> {
547    if let Some(per_k) = per_k {
548        Some(round1((per_k * 0.5).min(per_k_cap)))
549    } else {
550        count.map(|count| round1(f64::from(count).min(count_cap)))
551    }
552}
553
554fn unit_size_penalty(vs: &VitalSigns) -> Option<f64> {
555    if let Some(per_k) = vs.functions_over_60_loc_per_k {
556        Some(round1((per_k * 0.5).min(10.0)))
557    } else {
558        vs.unit_size_profile
559            .as_ref()
560            .map(|profile| round1(((profile.very_high_risk - 5.0).max(0.0) * 0.5).min(10.0)))
561    }
562}
563
564fn coupling_penalty(vs: &VitalSigns) -> Option<f64> {
565    if let Some(high_pct) = vs.coupling_high_pct {
566        Some(round1((high_pct * 0.5).min(5.0)))
567    } else {
568        vs.p95_fan_in
569            .map(|p95| round1(((f64::from(p95) - 30.0).max(0.0) * 0.25).min(5.0)))
570    }
571}
572
573/// Build the raw counts for a snapshot.
574pub fn build_counts(input: &VitalSignsInput<'_>) -> VitalSignsCounts {
575    let (total_exports, dead_files, dead_exports, total_deps) = input
576        .analysis_counts
577        .as_ref()
578        .map_or((0, 0, 0, 0), |counts| {
579            (
580                counts.total_exports,
581                counts.dead_files,
582                counts.dead_exports,
583                counts.total_deps,
584            )
585        });
586
587    let total_lines: usize = input.selected_modules().map(|m| m.line_offsets.len()).sum();
588
589    VitalSignsCounts {
590        total_files: input.total_files,
591        total_exports,
592        dead_files,
593        dead_exports,
594        duplicated_lines: None,
595        total_lines: Some(total_lines),
596        files_scored: input.file_scores.map(<[_]>::len),
597        total_deps,
598    }
599}
600
601/// Get the current git SHA (short form).
602#[expect(
603    clippy::disallowed_methods,
604    reason = "trusted git spawn with ambient repo-state env stripped, matching the core git spawn policy"
605)]
606fn git_sha(root: &Path) -> Option<String> {
607    let mut command = std::process::Command::new("git");
608    command
609        .args(["rev-parse", "--short", "HEAD"])
610        .current_dir(root);
611    clear_ambient_git_env(&mut command);
612    command
613        .output()
614        .ok()
615        .filter(|o| o.status.success())
616        .map(|o| String::from_utf8_lossy(&o.stdout).trim().to_string())
617}
618
619/// Get the current git branch name.
620#[expect(
621    clippy::disallowed_methods,
622    reason = "trusted git spawn with ambient repo-state env stripped, matching the core git spawn policy"
623)]
624fn git_branch(root: &Path) -> Option<String> {
625    let mut command = std::process::Command::new("git");
626    command
627        .args(["rev-parse", "--abbrev-ref", "HEAD"])
628        .current_dir(root);
629    clear_ambient_git_env(&mut command);
630    command
631        .output()
632        .ok()
633        .filter(|o| o.status.success())
634        .and_then(|o| {
635            let name = String::from_utf8_lossy(&o.stdout).trim().to_string();
636            if name == "HEAD" { None } else { Some(name) }
637        })
638}
639
640/// Build a snapshot from vital signs and input data.
641pub fn build_snapshot(
642    vital_signs: VitalSigns,
643    counts: VitalSignsCounts,
644    root: &Path,
645    shallow_clone: bool,
646    health_score: Option<&HealthScore>,
647    coverage_model: Option<fallow_output::CoverageModel>,
648) -> VitalSignsSnapshot {
649    let now = chrono_timestamp();
650
651    VitalSignsSnapshot {
652        snapshot_schema_version: SNAPSHOT_SCHEMA_VERSION,
653        version: env!("CARGO_PKG_VERSION").to_string(),
654        timestamp: now,
655        git_sha: git_sha(root),
656        git_branch: git_branch(root),
657        shallow_clone,
658        vital_signs,
659        counts,
660        score: health_score.map(|s| s.score),
661        grade: health_score.map(|s| s.grade.to_string()),
662        coverage_model,
663    }
664}
665
666/// ISO 8601 UTC timestamp without external chrono dependency.
667pub fn chrono_timestamp() -> String {
668    use std::time::SystemTime;
669    let now = SystemTime::now()
670        .duration_since(SystemTime::UNIX_EPOCH)
671        .unwrap_or_default();
672    let secs = now.as_secs();
673
674    let days = secs / SECS_PER_DAY;
675    let time_secs = secs % SECS_PER_DAY;
676    let hours = time_secs / 3600;
677    let minutes = (time_secs % 3600) / 60;
678    let seconds = time_secs % 60;
679
680    let (year, month, day) = days_to_ymd(days);
681
682    format!("{year:04}-{month:02}-{day:02}T{hours:02}:{minutes:02}:{seconds:02}Z")
683}
684
685/// Convert days since Unix epoch to (year, month, day).
686const fn days_to_ymd(days: u64) -> (u64, u64, u64) {
687    let z = days + 719_468;
688    let era = z / 146_097;
689    let doe = z - era * 146_097;
690    let yoe = (doe - doe / 1460 + doe / 36524 - doe / 146_096) / 365;
691    let y = yoe + era * 400;
692    let doy = doe - (365 * yoe + yoe / 4 - yoe / 100);
693    let mp = (5 * doy + 2) / 153;
694    let d = doy - (153 * mp + 2) / 5 + 1;
695    let m = if mp < 10 { mp + 3 } else { mp - 9 };
696    let y = if m <= 2 { y + 1 } else { y };
697    (y, m, d)
698}
699
700/// Save a snapshot to disk.
701///
702/// If `path` is `None`, writes to `.fallow/snapshots/{timestamp}.json`.
703/// Creates parent directories as needed.
704pub fn save_snapshot(
705    snapshot: &VitalSignsSnapshot,
706    root: &Path,
707    explicit_path: Option<&Path>,
708) -> Result<PathBuf, String> {
709    let path = explicit_path.map_or_else(
710        || {
711            let dir = root.join(".fallow").join("snapshots");
712            let filename = snapshot.timestamp.replace(':', "-");
713            dir.join(format!("{filename}.json"))
714        },
715        Path::to_path_buf,
716    );
717
718    if let Some(parent) = path.parent() {
719        std::fs::create_dir_all(parent)
720            .map_err(|e| format!("failed to create snapshot directory: {e}"))?;
721    }
722
723    let json =
724        serde_json::to_string_pretty(snapshot).map_err(|e| format!("failed to serialize: {e}"))?;
725    std::fs::write(&path, json).map_err(|e| format!("failed to write snapshot: {e}"))?;
726
727    Ok(path)
728}
729
730/// Load all snapshots from the default snapshot directory, sorted by timestamp ascending.
731///
732/// Corrupt or unreadable files are skipped with a warning to stderr.
733/// Returns an empty vec if the directory does not exist.
734#[expect(
735    clippy::print_stderr,
736    reason = "corrupt-snapshot warnings to stderr, preserved verbatim from the CLI health path"
737)]
738pub fn load_snapshots(root: &Path) -> Vec<VitalSignsSnapshot> {
739    let dir = root.join(".fallow").join("snapshots");
740    let Ok(entries) = std::fs::read_dir(&dir) else {
741        return Vec::new();
742    };
743
744    let mut snapshots = Vec::new();
745    for entry in entries {
746        let Ok(entry) = entry else { continue };
747        let path = entry.path();
748        if path.extension().is_some_and(|ext| ext == "json") {
749            match std::fs::read_to_string(&path) {
750                Ok(content) => match serde_json::from_str::<VitalSignsSnapshot>(&content) {
751                    Ok(snap) => snapshots.push(snap),
752                    Err(e) => {
753                        eprintln!("warning: skipping corrupt snapshot {}: {e}", path.display());
754                    }
755                },
756                Err(e) => {
757                    eprintln!("warning: could not read snapshot {}: {e}", path.display());
758                }
759            }
760        }
761    }
762
763    snapshots.sort_by(|a, b| a.timestamp.cmp(&b.timestamp));
764    snapshots
765}
766
767/// Tolerance for treating a metric delta as "stable" rather than improving/declining.
768const TREND_TOLERANCE: f64 = 0.5;
769
770fn trend_point_from_snapshot(prev: &VitalSignsSnapshot) -> TrendPoint {
771    TrendPoint {
772        timestamp: prev.timestamp.clone(),
773        git_sha: prev.git_sha.clone(),
774        score: prev.score,
775        grade: prev.grade.clone(),
776        coverage_model: prev.coverage_model.clone(),
777        snapshot_schema_version: Some(prev.snapshot_schema_version),
778    }
779}
780
781fn overall_trend_direction(metrics: &[TrendMetric]) -> TrendDirection {
782    let (improving, declining) = metrics.iter().fold((0usize, 0usize), |(imp, dec), metric| {
783        match metric.direction {
784            TrendDirection::Improving => (imp + 1, dec),
785            TrendDirection::Declining => (imp, dec + 1),
786            TrendDirection::Stable => (imp, dec),
787        }
788    });
789
790    match improving.cmp(&declining) {
791        std::cmp::Ordering::Greater => TrendDirection::Improving,
792        std::cmp::Ordering::Less => TrendDirection::Declining,
793        std::cmp::Ordering::Equal => TrendDirection::Stable,
794    }
795}
796
797/// Compute a trend comparison between the current run and the most recent snapshot.
798///
799/// Uses the stored `score` field from the snapshot (never re-derives it).
800/// Returns `None` if no snapshots are available.
801pub fn compute_trend(
802    current_vs: &VitalSigns,
803    current_counts: &VitalSignsCounts,
804    current_score: Option<f64>,
805    snapshots: &[VitalSignsSnapshot],
806) -> Option<HealthTrend> {
807    let prev = snapshots.last()?;
808
809    let compared_to = trend_point_from_snapshot(prev);
810
811    let metrics = TrendBuilder::new(prev, current_vs, current_counts, current_score).build();
812
813    let overall_direction = overall_trend_direction(&metrics);
814
815    Some(HealthTrend {
816        compared_to,
817        metrics,
818        snapshots_loaded: snapshots.len(),
819        overall_direction,
820    })
821}
822
823struct TrendBuilder<'a> {
824    prev: &'a VitalSignsSnapshot,
825    current_vs: &'a VitalSigns,
826    current_counts: &'a VitalSignsCounts,
827    current_score: Option<f64>,
828    metrics: Vec<TrendMetric>,
829}
830
831impl TrendBuilder<'_> {
832    fn new<'a>(
833        prev: &'a VitalSignsSnapshot,
834        current_vs: &'a VitalSigns,
835        current_counts: &'a VitalSignsCounts,
836        current_score: Option<f64>,
837    ) -> TrendBuilder<'a> {
838        TrendBuilder {
839            prev,
840            current_vs,
841            current_counts,
842            current_score,
843            metrics: Vec::new(),
844        }
845    }
846
847    fn build(mut self) -> Vec<TrendMetric> {
848        self.add_score_metric();
849        self.add_dead_code_metrics();
850        self.add_complexity_metrics();
851        self.add_dependency_metrics();
852        self.add_structure_metrics();
853        self.metrics
854    }
855
856    fn push(&mut self, input: TrendMetricInput) {
857        self.metrics.push(make_metric(input));
858    }
859
860    fn add_score_metric(&mut self) {
861        if let (Some(prev_score), Some(cur_score)) = (self.prev.score, self.current_score) {
862            self.push(TrendMetricInput {
863                name: "score",
864                label: "Health Score",
865                previous: prev_score,
866                current: cur_score,
867                unit: "",
868                higher_is_better: true,
869                previous_count: None,
870                current_count: None,
871            });
872        }
873    }
874
875    fn add_dead_code_metrics(&mut self) {
876        if let (Some(prev_val), Some(cur_val)) = (
877            self.prev.vital_signs.dead_file_pct,
878            self.current_vs.dead_file_pct,
879        ) {
880            self.push(TrendMetricInput {
881                name: "dead_file_pct",
882                label: "Dead Files",
883                previous: prev_val,
884                current: cur_val,
885                unit: "%",
886                higher_is_better: false,
887                previous_count: Some(TrendCount {
888                    value: self.prev.counts.dead_files,
889                    total: self.prev.counts.total_files,
890                }),
891                current_count: Some(TrendCount {
892                    value: self.current_counts.dead_files,
893                    total: self.current_counts.total_files,
894                }),
895            });
896        }
897
898        if let (Some(prev_val), Some(cur_val)) = (
899            self.prev.vital_signs.dead_export_pct,
900            self.current_vs.dead_export_pct,
901        ) {
902            self.push(TrendMetricInput {
903                name: "dead_export_pct",
904                label: "Dead Exports",
905                previous: prev_val,
906                current: cur_val,
907                unit: "%",
908                higher_is_better: false,
909                previous_count: Some(TrendCount {
910                    value: self.prev.counts.dead_exports,
911                    total: self.prev.counts.total_exports,
912                }),
913                current_count: Some(TrendCount {
914                    value: self.current_counts.dead_exports,
915                    total: self.current_counts.total_exports,
916                }),
917            });
918        }
919    }
920
921    fn add_complexity_metrics(&mut self) {
922        self.push(TrendMetricInput {
923            name: "avg_cyclomatic",
924            label: "Avg Cyclomatic",
925            previous: self.prev.vital_signs.avg_cyclomatic,
926            current: self.current_vs.avg_cyclomatic,
927            unit: "",
928            higher_is_better: false,
929            previous_count: None,
930            current_count: None,
931        });
932
933        if let (Some(prev_val), Some(cur_val)) = (
934            self.prev.vital_signs.maintainability_avg,
935            self.current_vs.maintainability_avg,
936        ) {
937            self.push(TrendMetricInput {
938                name: "maintainability_avg",
939                label: "Maintainability",
940                previous: prev_val,
941                current: cur_val,
942                unit: "",
943                higher_is_better: true,
944                previous_count: None,
945                current_count: None,
946            });
947        }
948
949        if let (Some(prev_profile), Some(cur_profile)) = (
950            &self.prev.vital_signs.unit_size_profile,
951            &self.current_vs.unit_size_profile,
952        ) {
953            self.push(TrendMetricInput {
954                name: "unit_size_very_high_pct",
955                label: "Oversized Fns",
956                previous: prev_profile.very_high_risk,
957                current: cur_profile.very_high_risk,
958                unit: "%",
959                higher_is_better: false,
960                previous_count: None,
961                current_count: None,
962            });
963        }
964
965        if let (Some(prev_val), Some(cur_val)) = (
966            self.prev.vital_signs.duplication_pct,
967            self.current_vs.duplication_pct,
968        ) {
969            self.push(TrendMetricInput {
970                name: "duplication_pct",
971                label: "Duplication",
972                previous: prev_val,
973                current: cur_val,
974                unit: "%",
975                higher_is_better: false,
976                previous_count: self
977                    .prev
978                    .counts
979                    .duplicated_lines
980                    .zip(self.prev.counts.total_lines)
981                    .map(|(d, t)| TrendCount { value: d, total: t }),
982                current_count: self
983                    .current_counts
984                    .duplicated_lines
985                    .zip(self.current_counts.total_lines)
986                    .map(|(d, t)| TrendCount { value: d, total: t }),
987            });
988        }
989    }
990
991    fn add_dependency_metrics(&mut self) {
992        if let (Some(prev_val), Some(cur_val)) = (
993            self.prev.vital_signs.unused_dep_count,
994            self.current_vs.unused_dep_count,
995        ) {
996            self.push(TrendMetricInput {
997                name: "unused_dep_count",
998                label: "Unused Deps",
999                previous: f64::from(prev_val),
1000                current: f64::from(cur_val),
1001                unit: "",
1002                higher_is_better: false,
1003                previous_count: None,
1004                current_count: None,
1005            });
1006        }
1007    }
1008
1009    fn add_structure_metrics(&mut self) {
1010        if let (Some(prev_val), Some(cur_val)) = (
1011            self.prev.vital_signs.circular_dep_count,
1012            self.current_vs.circular_dep_count,
1013        ) {
1014            self.push(TrendMetricInput {
1015                name: "circular_dep_count",
1016                label: "Circular Deps",
1017                previous: f64::from(prev_val),
1018                current: f64::from(cur_val),
1019                unit: "",
1020                higher_is_better: false,
1021                previous_count: None,
1022                current_count: None,
1023            });
1024        }
1025
1026        if let (Some(prev_val), Some(cur_val)) = (
1027            self.prev.vital_signs.hotspot_count,
1028            self.current_vs.hotspot_count,
1029        ) {
1030            self.push(TrendMetricInput {
1031                name: "hotspot_count",
1032                label: "Hotspots",
1033                previous: f64::from(prev_val),
1034                current: f64::from(cur_val),
1035                unit: "",
1036                higher_is_better: false,
1037                previous_count: None,
1038                current_count: None,
1039            });
1040        }
1041
1042        if let (Some(prev_val), Some(cur_val)) =
1043            (self.prev.vital_signs.p95_fan_in, self.current_vs.p95_fan_in)
1044        {
1045            self.push(TrendMetricInput {
1046                name: "p95_fan_in",
1047                label: "P95 Fan-in",
1048                previous: f64::from(prev_val),
1049                current: f64::from(cur_val),
1050                unit: "",
1051                higher_is_better: false,
1052                previous_count: None,
1053                current_count: None,
1054            });
1055        }
1056    }
1057}
1058
1059/// Build a single trend metric.
1060struct TrendMetricInput {
1061    name: &'static str,
1062    label: &'static str,
1063    previous: f64,
1064    current: f64,
1065    unit: &'static str,
1066    higher_is_better: bool,
1067    previous_count: Option<TrendCount>,
1068    current_count: Option<TrendCount>,
1069}
1070
1071fn make_metric(input: TrendMetricInput) -> TrendMetric {
1072    let TrendMetricInput {
1073        name,
1074        label,
1075        previous,
1076        current,
1077        unit,
1078        higher_is_better,
1079        previous_count,
1080        current_count,
1081    } = input;
1082    let delta = (current - previous).round_to(1);
1083    let direction = if delta.abs() < TREND_TOLERANCE {
1084        TrendDirection::Stable
1085    } else if (higher_is_better && delta > 0.0) || (!higher_is_better && delta < 0.0) {
1086        TrendDirection::Improving
1087    } else {
1088        TrendDirection::Declining
1089    };
1090
1091    TrendMetric {
1092        name,
1093        label,
1094        previous,
1095        current,
1096        delta,
1097        direction,
1098        unit,
1099        previous_count,
1100        current_count,
1101    }
1102}
1103
1104/// Extension trait for rounding floats to N decimal places.
1105trait RoundTo {
1106    fn round_to(self, decimals: u32) -> Self;
1107}
1108
1109impl RoundTo for f64 {
1110    fn round_to(self, decimals: u32) -> Self {
1111        let factor = 10_f64.powi(decimals as i32);
1112        (self * factor).round() / factor
1113    }
1114}
1115
1116#[cfg(test)]
1117mod tests {
1118    use super::*;
1119
1120    fn make_module(id: u32, cyclomatic: u16) -> crate::source::ModuleInfo {
1121        crate::source::ModuleInfo {
1122            file_id: crate::discover::FileId(id),
1123            exports: Vec::new(),
1124            imports: Vec::new(),
1125            re_exports: Vec::new(),
1126            dynamic_imports: Vec::new(),
1127            dynamic_import_patterns: Vec::new(),
1128            require_calls: Vec::new(),
1129            package_path_references: Box::default(),
1130            member_accesses: Vec::new(),
1131            semantic_facts: Box::default(),
1132            whole_object_uses: Box::default(),
1133            has_cjs_exports: false,
1134            has_angular_component_template_url: false,
1135            content_hash: 0,
1136            suppressions: Vec::new(),
1137            unknown_suppression_kinds: Vec::new(),
1138            unused_import_bindings: Vec::new(),
1139            type_referenced_import_bindings: vec![],
1140            value_referenced_import_bindings: vec![],
1141            line_offsets: Vec::new(),
1142            flag_uses: Vec::new(),
1143            class_heritage: Vec::new(),
1144            exported_factory_returns: Box::default(),
1145            injection_tokens: Vec::new(),
1146            local_type_declarations: Vec::new(),
1147            public_signature_type_references: Vec::new(),
1148            namespace_object_aliases: Vec::new(),
1149            iconify_prefixes: Vec::new(),
1150            iconify_icon_names: Vec::new(),
1151            auto_import_candidates: Vec::new(),
1152            directives: Vec::new(),
1153            client_only_dynamic_import_spans: Vec::new(),
1154            security_sinks: Vec::new(),
1155            security_sinks_skipped: 0,
1156            security_unresolved_callee_sites: Vec::new(),
1157            tainted_bindings: Vec::new(),
1158            sanitized_sink_args: Vec::new(),
1159            security_control_sites: Vec::new(),
1160            callee_uses: Vec::new(),
1161            misplaced_directives: Vec::new(),
1162            inline_server_action_exports: Vec::new(),
1163            di_key_sites: Vec::new(),
1164            has_dynamic_provide: false,
1165            referenced_import_bindings: Vec::new(),
1166            component_props: Vec::new(),
1167            has_props_attrs_fallthrough: false,
1168            has_define_expose: false,
1169            has_define_model: false,
1170            has_unharvestable_props: false,
1171            component_emits: Vec::new(),
1172            angular_inputs: Vec::new(),
1173            angular_outputs: Vec::new(),
1174            has_unharvestable_emits: false,
1175            has_dynamic_emit: false,
1176            has_emit_whole_object_use: false,
1177            load_return_keys: Vec::new(),
1178            has_unharvestable_load: false,
1179            has_load_data_whole_use: false,
1180            has_page_data_store_whole_use: false,
1181            component_functions: Vec::new(),
1182            react_props: Vec::new(),
1183            hook_uses: Vec::new(),
1184            render_edges: Vec::new(),
1185            svelte_dispatched_events: Vec::new(),
1186            svelte_listened_events: Vec::new(),
1187            angular_component_selectors: Vec::new(),
1188            registered_custom_elements: Vec::new(),
1189            used_custom_element_tags: Vec::new(),
1190            angular_used_selectors: Vec::new(),
1191            angular_entry_component_refs: Vec::new(),
1192            has_dynamic_component_render: false,
1193            has_dynamic_dispatch: false,
1194            complexity: vec![fallow_types::extract::FunctionComplexity {
1195                name: format!("fn_{id}"),
1196                line: id + 1,
1197                col: 0,
1198                cyclomatic,
1199                cognitive: 0,
1200                line_count: 10,
1201                param_count: 0,
1202                react_hook_count: 0,
1203                react_jsx_max_depth: 0,
1204                react_prop_count: 0,
1205                source_hash: None,
1206                contributions: Vec::new(),
1207            }],
1208        }
1209    }
1210
1211    #[expect(
1212        clippy::cast_possible_truncation,
1213        reason = "test values are trivially small"
1214    )]
1215    fn make_modules() -> Vec<crate::source::ModuleInfo> {
1216        (0..10)
1217            .map(|i| make_module(i, (i as u16 + 1) * 2))
1218            .collect()
1219    }
1220
1221    fn assert_close(actual: f64, expected: f64) {
1222        assert!(
1223            (actual - expected).abs() < f64::EPSILON,
1224            "expected {expected}, got {actual}"
1225        );
1226    }
1227
1228    fn assert_some_close(actual: Option<f64>, expected: f64) {
1229        assert_close(actual.expect("expected metric to be present"), expected);
1230    }
1231
1232    #[test]
1233    fn compute_cyclomatic_stats() {
1234        let modules = make_modules();
1235        let input = VitalSignsInput {
1236            modules: &modules,
1237            module_filter: None,
1238            file_scores: None,
1239            hotspots: None,
1240            total_files: 10,
1241            analysis_counts: None,
1242        };
1243        let vs = compute_vital_signs(&input);
1244        assert!((vs.avg_cyclomatic - 11.0).abs() < f64::EPSILON);
1245        assert_eq!(vs.p90_cyclomatic, 18);
1246    }
1247
1248    #[test]
1249    fn compute_with_analysis_counts() {
1250        let modules = make_modules();
1251        let input = VitalSignsInput {
1252            modules: &modules,
1253            module_filter: None,
1254            file_scores: None,
1255            hotspots: None,
1256            total_files: 100,
1257            analysis_counts: Some(AnalysisCounts {
1258                total_exports: 500,
1259                dead_files: 5,
1260                dead_exports: 50,
1261                unused_deps: 3,
1262                circular_deps: 2,
1263                total_deps: 40,
1264            }),
1265        };
1266        let vs = compute_vital_signs(&input);
1267        assert_eq!(vs.dead_file_pct, Some(5.0)); // 5/100 * 100
1268        assert_eq!(vs.dead_export_pct, Some(10.0)); // 50/500 * 100
1269        assert_eq!(vs.unused_dep_count, Some(3));
1270        assert_eq!(vs.circular_dep_count, Some(2));
1271    }
1272
1273    #[test]
1274    fn compute_hotspot_count_with_threshold() {
1275        let hotspots = vec![
1276            HotspotEntry {
1277                path: PathBuf::from("a.ts"),
1278                score: 80.0,
1279                commits: 10,
1280                weighted_commits: 8.0,
1281                lines_added: 100,
1282                lines_deleted: 50,
1283                complexity_density: 0.5,
1284                fan_in: 5,
1285                trend: crate::churn::ChurnTrend::Stable,
1286                ownership: None,
1287                is_test_path: false,
1288            },
1289            HotspotEntry {
1290                path: PathBuf::from("b.ts"),
1291                score: 30.0, // Below threshold
1292                commits: 5,
1293                weighted_commits: 3.0,
1294                lines_added: 40,
1295                lines_deleted: 20,
1296                complexity_density: 0.2,
1297                fan_in: 2,
1298                trend: crate::churn::ChurnTrend::Cooling,
1299                ownership: None,
1300                is_test_path: false,
1301            },
1302            HotspotEntry {
1303                path: PathBuf::from("c.ts"),
1304                score: 50.0, // At threshold
1305                commits: 8,
1306                weighted_commits: 6.0,
1307                lines_added: 80,
1308                lines_deleted: 30,
1309                complexity_density: 0.4,
1310                fan_in: 3,
1311                trend: crate::churn::ChurnTrend::Accelerating,
1312                ownership: None,
1313                is_test_path: false,
1314            },
1315        ];
1316        let modules = Vec::new();
1317        let input = VitalSignsInput {
1318            modules: &modules,
1319            module_filter: None,
1320            file_scores: None,
1321            hotspots: Some(&hotspots),
1322            total_files: 10,
1323            analysis_counts: None,
1324        };
1325        let vs = compute_vital_signs(&input);
1326        assert_eq!(vs.hotspot_count, Some(2)); // 80.0 and 50.0 meet threshold
1327        assert_eq!(vs.hotspot_top_pct_count, Some(1)); // top 1% bucket rounds up to one file
1328    }
1329
1330    #[test]
1331    fn compute_without_hotspots_gives_none() {
1332        let modules = Vec::new();
1333        let input = VitalSignsInput {
1334            modules: &modules,
1335            module_filter: None,
1336            file_scores: None,
1337            hotspots: None,
1338            total_files: 0,
1339            analysis_counts: None,
1340        };
1341        let vs = compute_vital_signs(&input);
1342        assert!(vs.hotspot_count.is_none());
1343    }
1344
1345    #[test]
1346    fn snapshot_save_and_load() {
1347        let dir = tempfile::tempdir().unwrap();
1348        let root = dir.path();
1349        let vs = VitalSigns {
1350            dead_file_pct: Some(3.2),
1351            dead_export_pct: Some(8.1),
1352            avg_cyclomatic: 4.7,
1353            p90_cyclomatic: 12,
1354            hotspot_count: Some(5),
1355            maintainability_avg: Some(72.4),
1356            unused_dep_count: Some(4),
1357            circular_dep_count: Some(2),
1358            ..Default::default()
1359        };
1360        let counts = VitalSignsCounts {
1361            total_files: 1200,
1362            total_exports: 5400,
1363            dead_files: 38,
1364            dead_exports: 437,
1365            files_scored: Some(1150),
1366            total_deps: 42,
1367            ..Default::default()
1368        };
1369        let health_score = compute_health_score(&vs, 1200);
1370        let snapshot = build_snapshot(vs, counts, root, false, Some(&health_score), None);
1371        let saved_path = save_snapshot(&snapshot, root, None).unwrap();
1372
1373        assert!(saved_path.exists());
1374        assert!(saved_path.starts_with(root.join(".fallow/snapshots")));
1375
1376        let content = std::fs::read_to_string(&saved_path).unwrap();
1377        let loaded: VitalSignsSnapshot = serde_json::from_str(&content).unwrap();
1378        assert_eq!(loaded.snapshot_schema_version, SNAPSHOT_SCHEMA_VERSION);
1379        assert!((loaded.vital_signs.avg_cyclomatic - 4.7).abs() < f64::EPSILON);
1380        assert_eq!(loaded.counts.total_files, 1200);
1381        assert!(loaded.score.is_some());
1382        assert!(loaded.grade.is_some());
1383    }
1384
1385    #[test]
1386    fn snapshot_save_explicit_path() {
1387        let dir = tempfile::tempdir().unwrap();
1388        let root = dir.path();
1389        let explicit = root.join("my-snapshot.json");
1390        let vs = VitalSigns {
1391            avg_cyclomatic: 1.0,
1392            p90_cyclomatic: 2,
1393            ..Default::default()
1394        };
1395        let counts = VitalSignsCounts::default();
1396        let snapshot = build_snapshot(vs, counts, root, false, None, None);
1397        let saved = save_snapshot(&snapshot, root, Some(&explicit)).unwrap();
1398        assert_eq!(saved, explicit);
1399        assert!(explicit.exists());
1400    }
1401
1402    #[test]
1403    fn snapshot_save_creates_nested_dirs() {
1404        let dir = tempfile::tempdir().unwrap();
1405        let root = dir.path();
1406        let nested = root.join("a/b/c/snapshot.json");
1407        let vs = VitalSigns {
1408            avg_cyclomatic: 1.0,
1409            p90_cyclomatic: 2,
1410            ..Default::default()
1411        };
1412        let counts = VitalSignsCounts::default();
1413        let snapshot = build_snapshot(vs, counts, root, false, None, None);
1414        let saved = save_snapshot(&snapshot, root, Some(&nested)).unwrap();
1415        assert_eq!(saved, nested);
1416        assert!(nested.exists());
1417    }
1418
1419    #[test]
1420    fn days_to_ymd_epoch() {
1421        assert_eq!(days_to_ymd(0), (1970, 1, 1));
1422    }
1423
1424    #[test]
1425    fn days_to_ymd_known_date() {
1426        assert_eq!(days_to_ymd(20_537), (2026, 3, 25));
1427    }
1428
1429    #[test]
1430    fn health_score_perfect() {
1431        let vs = VitalSigns {
1432            dead_file_pct: Some(0.0),
1433            dead_export_pct: Some(0.0),
1434            avg_cyclomatic: 1.0,
1435            p90_cyclomatic: 2,
1436            hotspot_count: Some(0),
1437            maintainability_avg: Some(90.0),
1438            unused_dep_count: Some(0),
1439            circular_dep_count: Some(0),
1440            ..Default::default()
1441        };
1442        let score = compute_health_score(&vs, 100);
1443        assert!((score.score - 100.0).abs() < f64::EPSILON);
1444        assert_eq!(score.grade, "A");
1445    }
1446
1447    #[test]
1448    fn health_score_no_optional_metrics() {
1449        let vs = VitalSigns {
1450            avg_cyclomatic: 1.0,
1451            p90_cyclomatic: 2,
1452            ..Default::default()
1453        };
1454        let score = compute_health_score(&vs, 0);
1455        assert!((score.score - 100.0).abs() < f64::EPSILON);
1456        assert_eq!(score.grade, "A");
1457        assert!(score.penalties.dead_files.is_none());
1458        assert!(score.penalties.unused_deps.is_none());
1459        assert!(score.penalties.duplication.is_none());
1460    }
1461
1462    #[test]
1463    fn health_score_dead_code_penalty() {
1464        let vs = VitalSigns {
1465            dead_file_pct: Some(50.0),
1466            dead_export_pct: Some(30.0),
1467            avg_cyclomatic: 1.0,
1468            p90_cyclomatic: 2,
1469            ..Default::default()
1470        };
1471        let score = compute_health_score(&vs, 100);
1472        assert!((score.score - 84.0).abs() < 0.1);
1473        assert_eq!(score.grade, "B");
1474    }
1475
1476    #[test]
1477    fn health_score_complexity_penalty() {
1478        let vs = VitalSigns {
1479            avg_cyclomatic: 5.5,
1480            p90_cyclomatic: 15,
1481            ..Default::default()
1482        };
1483        let score = compute_health_score(&vs, 100);
1484        assert!((score.score - 75.0).abs() < 0.1);
1485        assert_eq!(score.grade, "B");
1486    }
1487
1488    #[test]
1489    fn health_score_prop_drilling_penalty_opt_in() {
1490        let base = || VitalSigns {
1491            avg_cyclomatic: 1.0,
1492            p90_cyclomatic: 2,
1493            ..Default::default()
1494        };
1495        let base_score = compute_health_score(&base(), 100).score;
1496
1497        // Each located chain costs 1pt (depth is descriptive, not a multiplier).
1498        let three = VitalSigns {
1499            prop_drilling_chain_count: Some(3),
1500            prop_drilling_max_depth: Some(5),
1501            ..base()
1502        };
1503        assert!((base_score - compute_health_score(&three, 100).score - 3.0).abs() < 0.1);
1504
1505        // Capped at 5pt regardless of chain count.
1506        let many = VitalSigns {
1507            prop_drilling_chain_count: Some(20),
1508            ..base()
1509        };
1510        assert!((base_score - compute_health_score(&many, 100).score - 5.0).abs() < 0.1);
1511
1512        // Dormant by default: the opt-in rule is off, so the count is `None` and
1513        // the score is unchanged.
1514        let off = VitalSigns {
1515            prop_drilling_chain_count: None,
1516            ..base()
1517        };
1518        assert!((base_score - compute_health_score(&off, 100).score).abs() < f64::EPSILON);
1519    }
1520
1521    #[test]
1522    fn health_score_clamped_at_zero() {
1523        let vs = VitalSigns {
1524            dead_file_pct: Some(100.0),
1525            dead_export_pct: Some(100.0),
1526            avg_cyclomatic: 10.0,
1527            p90_cyclomatic: 30,
1528            hotspot_count: Some(50),
1529            maintainability_avg: Some(20.0),
1530            unused_dep_count: Some(100),
1531            circular_dep_count: Some(50),
1532            ..Default::default()
1533        };
1534        let score = compute_health_score(&vs, 100);
1535        assert!((score.score).abs() < f64::EPSILON);
1536        assert_eq!(score.grade, "F");
1537    }
1538
1539    #[test]
1540    fn health_score_hotspot_normalized_by_files() {
1541        let vs = VitalSigns {
1542            avg_cyclomatic: 1.0,
1543            p90_cyclomatic: 2,
1544            hotspot_count: Some(5),
1545            ..Default::default()
1546        };
1547        let score_100 = compute_health_score(&vs, 100);
1548        let score_1000 = compute_health_score(&vs, 1000);
1549        assert!(score_1000.score > score_100.score);
1550    }
1551
1552    #[test]
1553    fn health_score_hotspot_top_pct_can_use_full_budget() {
1554        let vs = VitalSigns {
1555            avg_cyclomatic: 1.0,
1556            p90_cyclomatic: 2,
1557            hotspot_count: Some(0),
1558            hotspot_top_pct_count: Some(250),
1559            ..Default::default()
1560        };
1561
1562        let score = compute_health_score(&vs, 25_000);
1563
1564        assert_some_close(score.penalties.hotspots, 10.0);
1565        assert_close(score.score, 90.0);
1566    }
1567
1568    #[test]
1569    fn health_score_duplication_penalty() {
1570        let vs = VitalSigns {
1571            dead_file_pct: None,
1572            dead_export_pct: None,
1573            avg_cyclomatic: 1.0,
1574            critical_complexity_pct: None,
1575            p90_cyclomatic: 2,
1576            duplication_pct: Some(10.0), // 10% - 5% = 5 points
1577            hotspot_count: None,
1578            hotspot_top_pct_count: None,
1579            maintainability_avg: None,
1580            maintainability_low_pct: None,
1581            unused_dep_count: None,
1582            unused_deps_per_k_files: None,
1583            circular_dep_count: None,
1584            circular_deps_per_k_files: None,
1585            counts: None,
1586            unit_size_profile: None,
1587            functions_over_60_loc_per_k: None,
1588            unit_interfacing_profile: None,
1589            p95_fan_in: None,
1590            coupling_high_pct: None,
1591            prop_drilling_chain_count: None,
1592            prop_drilling_max_depth: None,
1593            p95_render_fan_in: None,
1594            render_fan_in_high_pct: None,
1595            max_render_fan_in: None,
1596            top_render_fan_in: Vec::new(),
1597            total_loc: 0,
1598        };
1599        let score = compute_health_score(&vs, 100);
1600        assert_eq!(score.penalties.duplication, Some(5.0));
1601
1602        let vs_low = VitalSigns {
1603            duplication_pct: Some(4.0),
1604            ..vs.clone()
1605        };
1606        let score_low = compute_health_score(&vs_low, 100);
1607        assert_eq!(score_low.penalties.duplication, Some(0.0));
1608
1609        let vs_high = VitalSigns {
1610            duplication_pct: Some(20.0),
1611            ..vs
1612        };
1613        let score_high = compute_health_score(&vs_high, 100);
1614        assert_eq!(score_high.penalties.duplication, Some(10.0));
1615    }
1616
1617    #[test]
1618    fn health_score_uses_scale_invariant_monorepo_signals() {
1619        let vs = VitalSigns {
1620            dead_file_pct: Some(4.0),
1621            dead_export_pct: Some(9.0),
1622            avg_cyclomatic: 2.3,
1623            critical_complexity_pct: Some(2.3),
1624            p90_cyclomatic: 4,
1625            duplication_pct: Some(6.0),
1626            hotspot_count: Some(0),
1627            hotspot_top_pct_count: Some(250),
1628            maintainability_avg: Some(91.0),
1629            maintainability_low_pct: Some(8.0),
1630            unused_dep_count: Some(180),
1631            unused_deps_per_k_files: Some(7.2),
1632            circular_dep_count: Some(450),
1633            circular_deps_per_k_files: Some(18.0),
1634            unit_size_profile: Some(RiskProfile {
1635                low_risk: 80.0,
1636                medium_risk: 12.7,
1637                high_risk: 5.0,
1638                very_high_risk: 2.3,
1639            }),
1640            functions_over_60_loc_per_k: Some(23.0),
1641            p95_fan_in: Some(7),
1642            coupling_high_pct: Some(4.0),
1643            ..Default::default()
1644        };
1645        let score = compute_health_score(&vs, 25_000);
1646        let penalties = &score.penalties;
1647
1648        assert_some_close(penalties.dead_files, 0.8);
1649        assert_some_close(penalties.dead_exports, 1.8);
1650        assert_close(penalties.complexity, 9.2);
1651        assert!((penalties.p90_complexity).abs() < f64::EPSILON);
1652        assert_some_close(penalties.maintainability, 12.0);
1653        assert_some_close(penalties.hotspots, 10.0);
1654        assert_some_close(penalties.unused_deps, 3.6);
1655        assert_some_close(penalties.circular_deps, 9.0);
1656        assert_some_close(penalties.unit_size, 10.0);
1657        assert_some_close(penalties.coupling, 2.0);
1658        assert_some_close(penalties.duplication, 1.0);
1659        assert_close(score.score, 40.6);
1660        assert_eq!(score.grade, "D");
1661    }
1662
1663    #[test]
1664    fn load_snapshots_empty_dir() {
1665        let dir = tempfile::tempdir().unwrap();
1666        let snaps = load_snapshots(dir.path());
1667        assert!(snaps.is_empty());
1668    }
1669
1670    #[test]
1671    fn load_snapshots_returns_sorted() {
1672        let dir = tempfile::tempdir().unwrap();
1673        let root = dir.path();
1674        let snap_dir = root.join(".fallow/snapshots");
1675        std::fs::create_dir_all(&snap_dir).unwrap();
1676
1677        let older = make_test_snapshot("2026-01-01T00:00:00Z", Some(72.0));
1678        let newer = make_test_snapshot("2026-03-01T00:00:00Z", Some(78.0));
1679
1680        std::fs::write(
1681            snap_dir.join("2026-03-01T00-00-00Z.json"),
1682            serde_json::to_string(&newer).unwrap(),
1683        )
1684        .unwrap();
1685        std::fs::write(
1686            snap_dir.join("2026-01-01T00-00-00Z.json"),
1687            serde_json::to_string(&older).unwrap(),
1688        )
1689        .unwrap();
1690
1691        let loaded = load_snapshots(root);
1692        assert_eq!(loaded.len(), 2);
1693        assert_eq!(loaded[0].timestamp, "2026-01-01T00:00:00Z");
1694        assert_eq!(loaded[1].timestamp, "2026-03-01T00:00:00Z");
1695    }
1696
1697    #[test]
1698    fn load_snapshots_skips_corrupt_files() {
1699        let dir = tempfile::tempdir().unwrap();
1700        let root = dir.path();
1701        let snap_dir = root.join(".fallow/snapshots");
1702        std::fs::create_dir_all(&snap_dir).unwrap();
1703
1704        std::fs::write(snap_dir.join("corrupt.json"), "not valid json").unwrap();
1705        let good = make_test_snapshot("2026-02-01T00:00:00Z", Some(80.0));
1706        std::fs::write(
1707            snap_dir.join("good.json"),
1708            serde_json::to_string(&good).unwrap(),
1709        )
1710        .unwrap();
1711
1712        let loaded = load_snapshots(root);
1713        assert_eq!(loaded.len(), 1);
1714        assert_eq!(loaded[0].timestamp, "2026-02-01T00:00:00Z");
1715    }
1716
1717    #[test]
1718    fn load_snapshots_ignores_non_json() {
1719        let dir = tempfile::tempdir().unwrap();
1720        let root = dir.path();
1721        let snap_dir = root.join(".fallow/snapshots");
1722        std::fs::create_dir_all(&snap_dir).unwrap();
1723
1724        std::fs::write(snap_dir.join("readme.txt"), "not a snapshot").unwrap();
1725
1726        let loaded = load_snapshots(root);
1727        assert!(loaded.is_empty());
1728    }
1729
1730    #[test]
1731    fn compute_trend_no_snapshots() {
1732        let vs = make_test_vital_signs();
1733        let counts = make_test_counts();
1734        assert!(compute_trend(&vs, &counts, Some(78.0), &[]).is_none());
1735    }
1736
1737    #[test]
1738    fn compute_trend_improving() {
1739        let prev = make_test_snapshot("2026-01-01T00:00:00Z", Some(72.0));
1740        let vs = VitalSigns {
1741            dead_file_pct: Some(2.8),
1742            dead_export_pct: Some(7.5),
1743            avg_cyclomatic: 4.1,
1744            p90_cyclomatic: 12,
1745            hotspot_count: Some(3),
1746            maintainability_avg: Some(75.0),
1747            unused_dep_count: Some(3),
1748            circular_dep_count: Some(1),
1749            ..Default::default()
1750        };
1751        let counts = VitalSignsCounts {
1752            total_files: 100,
1753            total_exports: 500,
1754            dead_files: 3,
1755            dead_exports: 38,
1756            files_scored: Some(95),
1757            total_deps: 40,
1758            ..Default::default()
1759        };
1760
1761        let trend = compute_trend(&vs, &counts, Some(78.0), &[prev]).unwrap();
1762        assert_eq!(trend.compared_to.timestamp, "2026-01-01T00:00:00Z");
1763        assert_eq!(trend.snapshots_loaded, 1);
1764        assert_eq!(trend.overall_direction, TrendDirection::Improving);
1765
1766        let score_metric = trend.metrics.iter().find(|m| m.name == "score").unwrap();
1767        assert_eq!(score_metric.direction, TrendDirection::Improving);
1768        assert!((score_metric.delta - 6.0).abs() < f64::EPSILON);
1769    }
1770
1771    #[test]
1772    fn compute_trend_stable_within_tolerance() {
1773        let prev = make_test_snapshot("2026-01-01T00:00:00Z", Some(78.0));
1774        let vs = make_test_vital_signs();
1775        let counts = make_test_counts();
1776
1777        let trend = compute_trend(&vs, &counts, Some(78.3), &[prev]).unwrap();
1778        let score_metric = trend.metrics.iter().find(|m| m.name == "score").unwrap();
1779        assert_eq!(score_metric.direction, TrendDirection::Stable);
1780    }
1781
1782    #[test]
1783    fn compute_trend_uses_most_recent_snapshot() {
1784        let older = make_test_snapshot("2026-01-01T00:00:00Z", Some(60.0));
1785        let newer = make_test_snapshot("2026-03-01T00:00:00Z", Some(72.0));
1786        let vs = make_test_vital_signs();
1787        let counts = make_test_counts();
1788
1789        let trend = compute_trend(&vs, &counts, Some(78.0), &[older, newer]).unwrap();
1790        assert_eq!(trend.compared_to.score, Some(72.0));
1791        assert_eq!(trend.snapshots_loaded, 2);
1792    }
1793
1794    #[test]
1795    fn compute_trend_includes_raw_counts() {
1796        let prev = make_test_snapshot("2026-01-01T00:00:00Z", Some(72.0));
1797        let vs = make_test_vital_signs();
1798        let counts = make_test_counts();
1799
1800        let trend = compute_trend(&vs, &counts, Some(78.0), &[prev]).unwrap();
1801        let dead_files = trend
1802            .metrics
1803            .iter()
1804            .find(|m| m.name == "dead_file_pct")
1805            .unwrap();
1806        assert!(dead_files.previous_count.is_some());
1807        assert!(dead_files.current_count.is_some());
1808    }
1809
1810    fn make_test_vital_signs() -> VitalSigns {
1811        VitalSigns {
1812            dead_file_pct: Some(3.2),
1813            dead_export_pct: Some(8.1),
1814            avg_cyclomatic: 4.2,
1815            p90_cyclomatic: 12,
1816            hotspot_count: Some(5),
1817            maintainability_avg: Some(72.4),
1818            unused_dep_count: Some(4),
1819            circular_dep_count: Some(2),
1820            ..Default::default()
1821        }
1822    }
1823
1824    fn make_test_counts() -> VitalSignsCounts {
1825        VitalSignsCounts {
1826            total_files: 100,
1827            total_exports: 500,
1828            dead_files: 3,
1829            dead_exports: 40,
1830            files_scored: Some(95),
1831            total_deps: 42,
1832            ..Default::default()
1833        }
1834    }
1835
1836    fn make_test_snapshot(timestamp: &str, score: Option<f64>) -> VitalSignsSnapshot {
1837        VitalSignsSnapshot {
1838            snapshot_schema_version: SNAPSHOT_SCHEMA_VERSION,
1839            version: "2.5.5".into(),
1840            timestamp: timestamp.into(),
1841            git_sha: Some("abc1234".into()),
1842            git_branch: Some("main".into()),
1843            shallow_clone: false,
1844            vital_signs: VitalSigns {
1845                dead_file_pct: Some(3.2),
1846                dead_export_pct: Some(8.1),
1847                avg_cyclomatic: 4.7,
1848                p90_cyclomatic: 12,
1849                hotspot_count: Some(5),
1850                maintainability_avg: Some(72.4),
1851                unused_dep_count: Some(4),
1852                circular_dep_count: Some(2),
1853                ..Default::default()
1854            },
1855            counts: VitalSignsCounts {
1856                total_files: 100,
1857                total_exports: 500,
1858                dead_files: 3,
1859                dead_exports: 40,
1860                files_scored: Some(95),
1861                total_deps: 42,
1862                ..Default::default()
1863            },
1864            score,
1865            grade: score.map(|s| letter_grade(s).to_string()),
1866            coverage_model: None,
1867        }
1868    }
1869}