fallow-core 3.37.0

Internal detector backend for fallow-engine and fallow-api
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99

use fallow_config::Severity;
use fallow_types::output_dead_code::{DuplicatePropShapeFinding, ThinWrapperFinding};

use crate::suppress::IssueKind;

use super::{
    FrameworkSpecificFindingsInput, duplicate_prop_shape::find_duplicate_prop_shapes,
    retain_unsuppressed, thin_wrapper::find_thin_wrappers,
};

pub(super) fn populate_thin_wrapper_findings(input: &mut FrameworkSpecificFindingsInput<'_>) {
    if input.config.rules.thin_wrapper == Severity::Off
        && !input.config.overrides.iter().any(|override_config| {
            override_config
                .rules
                .thin_wrapper
                .is_some_and(|severity| severity != Severity::Off)
        })
    {
        return;
    }
    let findings = collect_thin_wrapper_findings(input);
    input.results.thin_wrappers =
        retain_unsuppressed(input, findings, IssueKind::ThinWrapper, |f| {
            Some((f.wrapper.file.as_path(), f.wrapper.line))
        });
}

fn collect_thin_wrapper_findings(
    input: &FrameworkSpecificFindingsInput<'_>,
) -> Vec<ThinWrapperFinding> {
    let scan = find_thin_wrappers(
        input.graph,
        input.modules,
        input.resolved_modules,
        input.declared_deps,
        input.line_offsets_by_file,
    );
    if scan.components_scanned > 0 {
        tracing::info!(
            components_scanned = scan.components_scanned,
            thin_wrappers = scan.wrappers.len(),
            "React detected, {} component(s) scanned for thin wrappers",
            scan.components_scanned
        );
    }
    scan.wrappers
        .into_iter()
        .map(ThinWrapperFinding::with_actions)
        .collect()
}

/// Multi-file suppress model: a per-member finding
/// is dropped by a line-level (`// fallow-ignore-next-line duplicate-prop-shape`
/// at its component definition) or a file-level
/// (`// fallow-ignore-file duplicate-prop-shape`) suppress, but the suppressed
/// member STILL appears in its siblings' `sharing_components`, because the
/// `sharing_components` roster is built at emit time (before this filter) and
/// the group is real regardless of suppression.
pub(super) fn populate_duplicate_prop_shape_findings(
    input: &mut FrameworkSpecificFindingsInput<'_>,
) {
    if input.config.rules.duplicate_prop_shape == Severity::Off
        && !input.config.overrides.iter().any(|override_config| {
            override_config
                .rules
                .duplicate_prop_shape
                .is_some_and(|severity| severity != Severity::Off)
        })
    {
        return;
    }
    let scan = find_duplicate_prop_shapes(
        input.graph,
        input.modules,
        input.declared_deps,
        input.line_offsets_by_file,
    );
    if scan.components_scanned > 0 {
        tracing::info!(
            components_scanned = scan.components_scanned,
            duplicate_prop_shapes = scan.groups.len(),
            "React detected, {} component(s) scanned for duplicate prop shapes",
            scan.components_scanned
        );
    }
    // A suppression drops THIS member only. Its slot in the siblings'
    // `sharing_components` is unaffected, because the roster was built at emit
    // time.
    let findings = scan
        .groups
        .into_iter()
        .map(DuplicatePropShapeFinding::with_actions)
        .collect();
    input.results.duplicate_prop_shapes =
        retain_unsuppressed(input, findings, IssueKind::DuplicatePropShape, |f| {
            Some((f.shape.file.as_path(), f.shape.line))
        });
}