fallow-core 3.35.0

Internal detector backend for fallow-engine and fallow-api
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180

//! Duplicate-export tests for aliased-import adapters.

use std::path::PathBuf;

use rustc_hash::FxHashMap;

use super::find_duplicate_exports;
use super::tests::{build_duplicate_graph, test_config};
use crate::results::DuplicateExport;
use crate::suppress::SuppressionContext;

#[test]
fn duplicate_exports_direct_import_still_flagged() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/a.ts", false),
            ("/src/b.ts", false),
        ],
        &[
            (1, "helper", false),
            (2, "helper", false),
            (2, "other", false),
        ],
        &[(0, 1, "helper", false), (1, 2, "other", false)],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert_eq!(
        result.len(),
        1,
        "directly connected files should still be flagged"
    );
}

fn duplicate_location_paths(duplicate: &DuplicateExport) -> Vec<PathBuf> {
    let mut paths: Vec<PathBuf> = duplicate
        .locations
        .iter()
        .map(|location| location.path.clone())
        .collect();
    paths.sort();
    paths
}

#[test]
fn duplicate_exports_skip_aliased_import_wrapper() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/adapter.ts", false),
            ("/src/core.ts", false),
        ],
        &[(1, "helper", false), (2, "helper", false)],
        &[(0, 1, "helper", false), (1, 2, "helper", false)],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert!(
        result.is_empty(),
        "an adapter that imports `helper` under an alias is not an independent origin"
    );
}

#[test]
fn duplicate_exports_wrapper_keeps_independent_pair() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/adapter.ts", false),
            ("/src/core.ts", false),
            ("/src/other.ts", false),
        ],
        &[
            (1, "helper", false),
            (2, "helper", false),
            (3, "helper", false),
        ],
        &[
            (0, 1, "helper", false),
            (1, 2, "helper", false),
            (0, 2, "helper", false),
            (0, 3, "helper", false),
        ],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert_eq!(result.len(), 1);
    assert_eq!(
        duplicate_location_paths(&result[0]),
        vec![
            PathBuf::from("/src/core.ts"),
            PathBuf::from("/src/other.ts")
        ]
    );
}

#[test]
fn duplicate_exports_type_only_aliased_wrapper() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/adapter.ts", false),
            ("/src/core.ts", false),
        ],
        &[(1, "Props", true), (2, "Props", true)],
        &[(0, 1, "Props", true), (1, 2, "Props", true)],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert!(
        result.is_empty(),
        "a type adapter that imports `Props` under an alias is not an independent origin"
    );
}

#[test]
fn duplicate_exports_keep_mutual_aliased_imports() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/a.ts", false),
            ("/src/b.ts", false),
        ],
        &[(1, "helper", false), (2, "helper", false)],
        &[
            (0, 1, "helper", false),
            (0, 2, "helper", false),
            (1, 2, "helper", false),
            (2, 1, "helper", false),
        ],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert_eq!(
        result.len(),
        1,
        "two modules that import `helper` from each other have no origin to derive from"
    );
    assert_eq!(
        duplicate_location_paths(&result[0]),
        vec![PathBuf::from("/src/a.ts"), PathBuf::from("/src/b.ts")]
    );
}

#[test]
fn duplicate_exports_skip_adapter_cycle_that_reaches_origin() {
    let graph = build_duplicate_graph(
        &[
            ("/src/entry.ts", true),
            ("/src/a.ts", false),
            ("/src/b.ts", false),
            ("/src/core.ts", false),
        ],
        &[
            (1, "helper", false),
            (2, "helper", false),
            (3, "helper", false),
        ],
        &[
            (0, 1, "helper", false),
            (0, 2, "helper", false),
            (1, 2, "helper", false),
            (2, 1, "helper", false),
            (2, 3, "helper", false),
        ],
    );
    let suppressions = SuppressionContext::empty();
    let config = test_config();
    let result = find_duplicate_exports(&graph, &config, &suppressions, &FxHashMap::default(), &[]);
    assert!(
        result.is_empty(),
        "adapters whose links reach `core.ts` derive their export from it"
    );
}