fallow-core 3.2.0

Internal detector backend for fallow-engine and fallow-api
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
use super::common::{create_config, create_config_with_ignore_decorators, fixture_path};

#[test]
fn enum_class_members_detects_unused_members() {
    let root = fixture_path("enum-class-members");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_enum_member_names: Vec<&str> = results
        .unused_enum_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        unused_enum_member_names.contains(&"Inactive"),
        "Inactive should be detected as unused enum member, found: {unused_enum_member_names:?}"
    );
    assert!(
        unused_enum_member_names.contains(&"Pending"),
        "Pending should be detected as unused enum member, found: {unused_enum_member_names:?}"
    );

    let unused_class_member_names: Vec<&str> = results
        .unused_class_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        unused_class_member_names.contains(&"unusedMethod"),
        "unusedMethod should be detected as unused class member, found: {unused_class_member_names:?}"
    );

    assert!(
        !unused_class_member_names.contains(&"greet"),
        "greet should NOT be unused (called via instance), found: {unused_class_member_names:?}"
    );

    assert!(
        unused_class_member_names.contains(&"name"),
        "name should be detected as unused class property, found: {unused_class_member_names:?}"
    );
}

#[test]
fn exported_instance_class_members_are_credited_to_class() {
    let root = fixture_path("exported-instance-class-members");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"Box.bump".to_string()),
        "Box.bump should be credited through exported instance usage, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"Box.current".to_string()),
        "Box.current getter/setter should be credited through exported instance usage, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"Box.unused".to_string()),
        "Box.unused should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn public_api_class_members_reexported_from_entry_points_are_not_reported() {
    let root = fixture_path("issue-643-public-api-class-members");
    let config = create_config(root.clone());
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<(String, String, String)> = results
        .unused_class_members
        .iter()
        .map(|m| {
            let path = m
                .member
                .path
                .strip_prefix(&root)
                .unwrap_or(&m.member.path)
                .to_string_lossy()
                .replace('\\', "/");
            (
                path,
                m.member.parent_name.clone(),
                m.member.member_name.clone(),
            )
        })
        .collect();

    for public_member in [
        ("src/named-builder.ts", "NamedBuilder", "notNull"),
        ("src/named-builder.ts", "NamedBuilder", "default"),
        ("src/renamed-builder.ts", "RenamedBuilder", "columnType"),
        ("src/default-builder.ts", "DefaultBuilder", "select"),
        ("src/star-builder.ts", "StarBuilder", "publicApi"),
        ("src/subpath-builder.ts", "SubpathBuilder", "transaction"),
        ("src/gel-database.ts", "GelDatabase", "select"),
        ("src/gel-database.ts", "GelDatabase", "transaction"),
    ] {
        assert!(
            !unused_class_members.contains(&(
                public_member.0.to_string(),
                public_member.1.to_string(),
                public_member.2.to_string(),
            )),
            "entry-point public API class members should not be reported, found: {unused_class_members:?}"
        );
    }

    assert!(
        unused_class_members.contains(&(
            "src/internal.ts".to_string(),
            "InternalOnly".to_string(),
            "unused".to_string(),
        )),
        "reachable internal class members should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&(
            "src/internal.ts".to_string(),
            "InternalOnly".to_string(),
            "used".to_string(),
        )),
        "used internal class members should not be reported, found: {unused_class_members:?}"
    );

    let unused_enum_members: Vec<(String, String, String)> = results
        .unused_enum_members
        .iter()
        .map(|m| {
            let path = m
                .member
                .path
                .strip_prefix(&root)
                .unwrap_or(&m.member.path)
                .to_string_lossy()
                .replace('\\', "/");
            (
                path,
                m.member.parent_name.clone(),
                m.member.member_name.clone(),
            )
        })
        .collect();
    assert!(
        unused_enum_members.contains(&(
            "src/status.ts".to_string(),
            "PublicStatus".to_string(),
            "External".to_string(),
        )),
        "entry-point enum member behavior is unchanged by the public class API skip, found: {unused_enum_members:?}"
    );
}

#[test]
fn cross_package_enum_class_members_credit_re_exported_origin() {
    let root = fixture_path("cross-package-enum-class-members");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_enum_member_names: Vec<&str> = results
        .unused_enum_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        !unused_enum_member_names.contains(&"Active"),
        "StatusCode.Active should be credited via cross-package access, found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Inactive"),
        "StatusCode.Inactive should be credited via cross-package access, found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Pending"),
        "StatusCode.Pending should be credited via cross-package access, found: {unused_enum_member_names:?}"
    );
    assert!(
        unused_enum_member_names.contains(&"Archived"),
        "StatusCode.Archived is genuinely unused and should still be flagged, found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"East"),
        "Direction.East should be credited via cross-package access, found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"West"),
        "Direction.West should be credited via cross-package access, found: {unused_enum_member_names:?}"
    );
    assert!(
        unused_enum_member_names.contains(&"North"),
        "Direction.North is genuinely unused, found: {unused_enum_member_names:?}"
    );
    assert!(
        unused_enum_member_names.contains(&"South"),
        "Direction.South is genuinely unused, found: {unused_enum_member_names:?}"
    );

    let unused_class_member_names: Vec<&str> = results
        .unused_class_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        !unused_class_member_names.contains(&"toUpper"),
        "StringUtils.toUpper should be credited via cross-package access, found: {unused_class_member_names:?}"
    );
    assert!(
        unused_class_member_names.contains(&"toLower"),
        "StringUtils.toLower is genuinely unused, found: {unused_class_member_names:?}"
    );
    assert!(
        unused_class_member_names.contains(&"reverse"),
        "StringUtils.reverse is genuinely unused, found: {unused_class_member_names:?}"
    );
}

#[test]
fn injected_dependency_object_credits_class_member_usage() {
    let root = fixture_path("injected-dependency-class-members");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<(&str, &str)> = results
        .unused_class_members
        .iter()
        .map(|m| (m.member.parent_name.as_str(), m.member.member_name.as_str()))
        .collect();

    assert!(
        !unused_class_members.contains(&("FooClass", "foo")),
        "FooClass.foo should be credited through this.deps.foo.foo(), found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&("FooClass", "unused")),
        "the fixture should still report genuinely unused members, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_fixture_pom_methods_are_credited_from_tests() {
    let root = fixture_path("playwright-pom-fixtures");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"AdminPage.assertGreeting".to_string()),
        "AdminPage.assertGreeting should be credited through the typed Playwright fixture, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"UserPage.assertGreeting".to_string()),
        "UserPage.assertGreeting should be credited through the typed Playwright fixture, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"AdminPage.unusedAdminOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"UserPage.unusedUserOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_nested_fixture_pom_methods_are_credited_from_tests() {
    let root = fixture_path("playwright-pom-fixtures-nested");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"AdminPage.assertGreeting".to_string()),
        "AdminPage.assertGreeting should be credited through nested-fixture chained access (pages.adminPage.assertGreeting), found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"UserPage.assertGreeting".to_string()),
        "UserPage.assertGreeting should be credited through nested-fixture destructuring ({{ pages: {{ userPage }} }}), found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"AdminPage.unusedAdminOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"UserPage.unusedUserOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_helper_function_fixture_pom_methods_are_credited() {
    let root = fixture_path("issue-491-playwright-fixture-helper-function");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"LoginActions.openLogin".to_string()),
        "LoginActions.openLogin should be credited through the helper-function fixture (appTest()()), found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"AdminActions.openAdmin".to_string()),
        "AdminActions.openAdmin should be credited through nested destructuring on the helper-function fixture, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"LoginActions.unusedLoginOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"AdminActions.unusedAdminOnly".to_string()),
        "genuinely unused POM methods should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_helper_function_with_local_setup_fixture_pom_methods_are_credited() {
    let root = fixture_path("issue-586-playwright-helper-local-setup");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"SidebarActionsLocal.openPatientsWithLocal".to_string()),
        "SidebarActionsLocal.openPatientsWithLocal should be credited through a helper that has local setup before returning base.extend, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"SidebarActionsDirect.openPatientsDirect".to_string()),
        "SidebarActionsDirect.openPatientsDirect should remain credited through the direct-return control helper, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"SidebarActionsLocal.unusedLocalOnly".to_string()),
        "genuinely unused local POM methods should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"SidebarActionsDirect.unusedDirectOnly".to_string()),
        "genuinely unused direct POM methods should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_fixture_teardown_credits_factory_getter_member_usage() {
    let root = fixture_path("issue-386-playwright-fixture-teardown");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"ProcessEventsService.queryEventsForProcessId".to_string()),
        "ProcessEventsService.queryEventsForProcessId should be credited through a Playwright fixture teardown factory getter, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"ProcessEventsService.unusedServiceMethod".to_string()),
        "genuinely unused service methods should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members
            .iter()
            .any(|member| member.starts_with("AuditService.")),
        "Object.keys(factory.auditService) should credit the whole target service through the typed getter chain, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_fixture_getter_chain_credits_nested_fixture_methods() {
    let root = fixture_path("issue-1190-playwright-fixture-getter-chain");
    let config = create_config_with_ignore_decorators(root, vec!["@step".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"MessageChecks.hasExpectedRecord".to_string()),
        "MessageChecks.hasExpectedRecord should be credited through app.assert.messageChecks.hasExpectedRecord(), found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasMessageForRecordId".to_string()),
        "MessageChecks.hasMessageForRecordId should be credited through app.assert.messageChecks.hasMessageForRecordId(), found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"MessageChecks.unusedCheck".to_string()),
        "a decorated but genuinely unused MessageChecks method should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_wrapper_fixtures_credit_nested_fixture_methods() {
    let root = fixture_path("issue-1210-playwright-wrapper-fixtures");
    let config = create_config_with_ignore_decorators(root, vec!["@step".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"MessageChecks.hasExpectedRecord".to_string()),
        "MessageChecks.hasExpectedRecord should remain credited through the direct fixture, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasMessageForRecordId".to_string()),
        "MessageChecks.hasMessageForRecordId should remain credited through the direct fixture, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasMergedRecord".to_string()),
        "MessageChecks.hasMergedRecord should be credited through mergeTests, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasMergedMessageForRecordId".to_string()),
        "MessageChecks.hasMergedMessageForRecordId should be credited through aliased mergeTests, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasExtendedRecord".to_string()),
        "MessageChecks.hasExtendedRecord should be credited through wrapper .extend, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasExtendedMessageForRecordId".to_string()),
        "MessageChecks.hasExtendedMessageForRecordId should be credited through wrapper .extend, found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"MessageChecks.hasExtendedMergedRecord".to_string()),
        "MessageChecks.hasExtendedMergedRecord should be credited through transitive wrapper aliases, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"MessageChecks.isActuallyUnused".to_string()),
        "the first genuinely unused decorated control should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"MessageChecks.isActuallyUnusedExtended".to_string()),
        "the second genuinely unused decorated control should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn playwright_branch_selected_fixture_aliases_are_credited() {
    let root = fixture_path("issue-1270-playwright-fixture-branch-aliases");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    for credited in [
        "SingleReader.directControl",
        "SingleReader.ternarySelected",
        "SingleReader.ifElseSelected",
        "SingleReader.switchSelected",
        "MergedReader.directControl",
        "MergedReader.ternarySelected",
        "MergedReader.ifElseSelected",
        "MergedReader.switchSelected",
        "MergedReader.ifElseDirect",
        "MergedReader.switchDirect",
    ] {
        assert!(
            !unused_class_members.contains(&credited.to_string()),
            "{credited} should be credited through Playwright fixture aliases, found: {unused_class_members:?}"
        );
    }

    assert!(
        unused_class_members.contains(&"SingleReader.unusedSingle".to_string()),
        "the single-fixture unused control should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"MergedReader.unusedMerged".to_string()),
        "the merged-fixture unused control should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn fluent_builder_chain_credits_intermediate_setters() {
    let root = fixture_path("issue-387-fluent-builder");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    for credited in [
        "EventBuilder.setEventVersion",
        "EventBuilder.setProcessId",
        "EventBuilder.setSubject",
        "EventBuilder.build",
    ] {
        assert!(
            !unused_class_members.contains(&credited.to_string()),
            "{credited} is reached through a fluent-builder chain off `EventBuilder.createWithDefaults()` / `EventBuilder.create()`, should be credited (issue #387), found: {unused_class_members:?}"
        );
    }
    assert!(
        unused_class_members.contains(&"EventBuilder.setUnused".to_string()),
        "genuinely unused fluent setters should still be reported, found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"EventBuilder.fakeFromNonFactory".to_string()),
        "fluent-chain credit must not piggy-back on a non-factory root method, found: {unused_class_members:?}"
    );
}

#[test]
fn generic_constrained_param_credits_base_class_member() {
    let root = fixture_path("issue-388-generic-constraint");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"BaseClient.fetchLatest".to_string()),
        "BaseClient.fetchLatest is called via a generic-constrained `this.client`, should be credited (issue #388), found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"BaseClient.unusedBaseMethod".to_string()),
        "genuinely unused base methods should still be reported, found: {unused_class_members:?}"
    );
}

#[test]
fn angular_inject_fields_credit_service_member_usage() {
    let root = fixture_path("angular-inject-class-members");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_class_members: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused_class_members.contains(&"InnerService.aaa".to_string()),
        "InnerService.aaa should be credited through this.inner.aaa where inner = inject(InnerService), found: {unused_class_members:?}"
    );
    assert!(
        !unused_class_members.contains(&"InnerService.bbb".to_string()),
        "InnerService.bbb should be credited through this.inner.bbb where inner = inject(InnerService), found: {unused_class_members:?}"
    );
    assert!(
        unused_class_members.contains(&"InnerService.ccc".to_string()),
        "InnerService.ccc should still be reported as genuinely unused, found: {unused_class_members:?}"
    );
}

#[test]
fn enum_whole_object_uses_no_false_positives() {
    let root = fixture_path("enum-whole-object");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_enum_member_names: Vec<&str> = results
        .unused_enum_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        !unused_enum_member_names.contains(&"Active"),
        "Active should not be unused (Object.values), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Inactive"),
        "Inactive should not be unused (Object.values), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Pending"),
        "Pending should not be unused (Object.values), found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"Up"),
        "Up should not be unused (Object.keys), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Down"),
        "Down should not be unused (Object.keys), found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"Red"),
        "Red should not be unused (for..in), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Green"),
        "Green should not be unused (for..in), found: {unused_enum_member_names:?}"
    );

    assert!(
        unused_enum_member_names.contains(&"Low"),
        "Low should be unused (only High accessed via computed), found: {unused_enum_member_names:?}"
    );
    assert!(
        unused_enum_member_names.contains(&"Medium"),
        "Medium should be unused (only High accessed via computed), found: {unused_enum_member_names:?}"
    );
}

#[test]
fn enum_type_level_usage_no_false_positives() {
    let root = fixture_path("enum-type-level");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused_enum_member_names: Vec<&str> = results
        .unused_enum_members
        .iter()
        .map(|m| m.member.member_name.as_str())
        .collect();

    assert!(
        !unused_enum_member_names.contains(&"xs"),
        "xs should not be unused (mapped type constraint), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"xxl"),
        "xxl should not be unused (mapped type constraint), found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"Active"),
        "Active should not be unused (type qualified name), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Inactive"),
        "Inactive should not be unused (runtime access), found: {unused_enum_member_names:?}"
    );

    assert!(
        unused_enum_member_names.contains(&"Pending"),
        "Pending should be unused (no type-level or runtime access), found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"Red"),
        "Red should not be unused (Record<Color, T>), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Blue"),
        "Blue should not be unused (Record<Color, T>), found: {unused_enum_member_names:?}"
    );

    assert!(
        !unused_enum_member_names.contains(&"Up"),
        "Up should not be unused (keyof typeof in mapped type), found: {unused_enum_member_names:?}"
    );
    assert!(
        !unused_enum_member_names.contains(&"Right"),
        "Right should not be unused (keyof typeof in mapped type), found: {unused_enum_member_names:?}"
    );
}

#[test]
fn typed_binding_through_nullable_unions_credits_class_methods() {
    let root = fixture_path("typed-binding-wrappers");
    let config = create_config(root);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        !unused.contains(&"Aggregate.rename".to_string()),
        "Aggregate.rename should be credited through `Aggregate | undefined`, found unused: {unused:?}"
    );

    assert!(
        unused.contains(&"Aggregate.archive".to_string()),
        "Aggregate.archive should not be credited through `Promise<Aggregate>`, found unused: {unused:?}"
    );

    assert!(
        unused.contains(&"Aggregate.unusedMethod".to_string()),
        "Aggregate.unusedMethod should still be flagged as unused, found unused: {unused:?}"
    );
}

#[test]
fn ignore_decorators_unlocks_only_listed_decorators() {
    let root = fixture_path("ignore-decorators-mixed");
    let config = create_config_with_ignore_decorators(root, vec!["@step".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        unused.contains(&"Demo.decoratedOnly".to_string()),
        "decoratedOnly carries only @step and should be reported, found: {unused:?}"
    );
    assert!(
        unused.contains(&"Demo.plainUnused".to_string()),
        "plainUnused has no decorators and should be reported, found: {unused:?}"
    );
    assert!(
        !unused.contains(&"Demo.mixed".to_string()),
        "mixed carries a non-ignored @Inject and must stay skipped, found: {unused:?}"
    );
    assert!(
        !unused.contains(&"Demo.frameworkOnly".to_string()),
        "frameworkOnly carries only the non-ignored @Inject and must stay skipped, found: {unused:?}"
    );
    assert!(
        !unused.contains(&"Demo.actuallyUsed".to_string()),
        "actuallyUsed is called from entry and must not be reported, found: {unused:?}"
    );
}

#[test]
fn ignore_decorators_dotted_entry_matches_exact_path() {
    let root = fixture_path("ignore-decorators-namespaced");
    let config = create_config_with_ignore_decorators(root, vec!["decorators.log".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        unused.contains(&"Demo.loggedMethod".to_string()),
        "loggedMethod's @decorators.log matches the dotted entry and the method should be reported, found: {unused:?}"
    );
    assert!(
        !unused.contains(&"Demo.auditedMethod".to_string()),
        "auditedMethod's @decorators.audit is not in the ignore list and must stay skipped, found: {unused:?}"
    );
    assert!(
        unused.contains(&"Demo.plainMethod".to_string()),
        "plainMethod has no decorators and should be reported, found: {unused:?}"
    );
}

#[test]
fn ignore_decorators_bare_entry_collapses_namespace() {
    let root = fixture_path("ignore-decorators-namespaced");
    let config = create_config_with_ignore_decorators(root, vec!["decorators".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        unused.contains(&"Demo.loggedMethod".to_string()),
        "loggedMethod's @decorators.log should match bare entry 'decorators', found: {unused:?}"
    );
    assert!(
        unused.contains(&"Demo.auditedMethod".to_string()),
        "auditedMethod's @decorators.audit should match bare entry 'decorators', found: {unused:?}"
    );
}

#[test]
fn ignore_decorators_applies_to_declaring_class_only() {
    let root = fixture_path("ignore-decorators-inheritance");
    let config = create_config_with_ignore_decorators(root, vec!["@step".to_string()]);
    let results = fallow_core::analyze(&config).expect("analysis should succeed");

    let unused: Vec<String> = results
        .unused_class_members
        .iter()
        .map(|m| format!("{}.{}", m.member.parent_name, m.member.member_name))
        .collect();

    assert!(
        unused.contains(&"Page.run".to_string()),
        "Page.run carries only @step and should be reported on the declaring class, found: {unused:?}"
    );
    let admin_findings: Vec<&String> = unused
        .iter()
        .filter(|entry| entry.starts_with("AdminPage."))
        .collect();
    assert!(
        admin_findings.is_empty(),
        "AdminPage has no own members; no findings should be attributed to it, found: {admin_findings:?}"
    );
}