fallow-core 2.40.3

Core analysis engine for the fallow TypeScript/JavaScript codebase analyzer
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
use std::path::{Path, PathBuf};

use fallow_types::discover::{EntryPoint, EntryPointSource};

use super::entry_points::resolve_entry_path;
use super::parse_scripts::{extract_script_file_refs, looks_like_script_file};

/// Discover entry points from infrastructure config files (Dockerfile, Procfile, fly.toml).
///
/// These files reference source files as entry points for processes that run outside
/// the main JS/TS build pipeline (workers, migrations, cron jobs, etc.).
pub fn discover_infrastructure_entry_points(root: &Path) -> Vec<EntryPoint> {
    let _span = tracing::info_span!("discover_infrastructure_entry_points").entered();
    let mut file_refs: Vec<String> = Vec::new();

    // Search for Dockerfiles in root and common subdirectories
    let search_dirs: Vec<PathBuf> = std::iter::once(root.to_path_buf())
        .chain(
            ["config", "docker", "deploy", ".docker"]
                .iter()
                .map(|d| root.join(d)),
        )
        .filter(|d| d.is_dir())
        .collect();

    for dir in &search_dirs {
        for entry in std::fs::read_dir(dir).into_iter().flatten().flatten() {
            let name = entry.file_name();
            let name_str = name.to_string_lossy();
            if is_dockerfile(&name_str)
                && let Ok(content) = std::fs::read_to_string(entry.path())
            {
                file_refs.extend(extract_dockerfile_file_refs(&content));
            }
        }
    }

    // Procfile (Heroku, Foreman, etc.)
    if let Ok(content) = std::fs::read_to_string(root.join("Procfile")) {
        file_refs.extend(extract_procfile_file_refs(&content));
    }

    // fly.toml and fly.*.toml (Fly.io — projects often have fly.worker.toml, etc.)
    for entry in std::fs::read_dir(root).into_iter().flatten().flatten() {
        let name = entry.file_name();
        let name_str = name.to_string_lossy();
        if (name_str == "fly.toml" || (name_str.starts_with("fly.") && name_str.ends_with(".toml")))
            && let Ok(content) = std::fs::read_to_string(entry.path())
        {
            file_refs.extend(extract_fly_toml_file_refs(&content));
        }
    }

    if file_refs.is_empty() {
        return Vec::new();
    }

    // Resolve file references against project root
    let canonical_root = dunce::canonicalize(root).unwrap_or_else(|_| root.to_path_buf());
    let mut entries: Vec<EntryPoint> = file_refs
        .iter()
        .filter_map(|file_ref| {
            resolve_entry_path(
                root,
                file_ref,
                &canonical_root,
                EntryPointSource::InfrastructureConfig,
            )
        })
        .collect();

    entries.sort_by(|a, b| a.path.cmp(&b.path));
    entries.dedup_by(|a, b| a.path == b.path);

    if !entries.is_empty() {
        tracing::info!(
            count = entries.len(),
            "infrastructure entry points discovered"
        );
    }

    entries
}

/// Check if a filename is a Dockerfile.
fn is_dockerfile(name: &str) -> bool {
    name == "Dockerfile"
        || (name.starts_with("Dockerfile.") && !name.ends_with(".dockerignore"))
        || name.ends_with(".Dockerfile")
}

/// Extract file path references from Dockerfile RUN/CMD/ENTRYPOINT instructions.
///
/// Handles both shell form (`CMD node file.js`) and exec form (`CMD ["node", "file.js"]`).
/// Multi-line commands with `\` continuation are joined.
fn extract_dockerfile_file_refs(content: &str) -> Vec<String> {
    let mut refs = Vec::new();
    let lines: Vec<&str> = content.lines().collect();
    let mut i = 0;

    while i < lines.len() {
        let line = lines[i].trim();

        // Skip comments and empty lines
        if line.is_empty() || line.starts_with('#') {
            i += 1;
            continue;
        }

        // Check for RUN, CMD, ENTRYPOINT instructions
        let Some(instruction_end) = strip_dockerfile_instruction(line) else {
            i += 1;
            continue;
        };

        // Handle multi-line continuation with `\`
        let mut full_cmd = instruction_end.to_string();
        while full_cmd.ends_with('\\') {
            full_cmd.truncate(full_cmd.len() - 1);
            i += 1;
            if i >= lines.len() {
                break;
            }
            full_cmd.push(' ');
            full_cmd.push_str(lines[i].trim());
        }

        // Handle exec form: ["node", "file.js", "--flag"]
        let cmd_str = full_cmd.trim();
        let command = if cmd_str.starts_with('[') {
            parse_exec_form(cmd_str)
        } else {
            cmd_str.to_string()
        };

        refs.extend(extract_script_file_refs(&command));
        // Also extract file paths from flag values (e.g., --alias:name=./path.ts)
        refs.extend(extract_flag_value_file_refs(&command));
        i += 1;
    }

    refs
}

/// Extract file path references from flag values like `--alias:name=./path.ts`.
///
/// Build tools (esbuild, webpack, etc.) use flag values that reference source files.
/// This extracts paths from `--key=value` patterns where the value looks like a source file.
fn extract_flag_value_file_refs(command: &str) -> Vec<String> {
    let mut refs = Vec::new();
    for token in command.split_whitespace() {
        if !token.starts_with('-') {
            continue;
        }
        // Extract value after `=` in flags like --alias:name=./path.ts
        if let Some((_key, value)) = token.split_once('=')
            && looks_like_script_file(value)
        {
            refs.push(value.to_string());
        }
    }
    refs
}

/// Strip a Dockerfile instruction keyword (RUN, CMD, ENTRYPOINT) and return the rest.
fn strip_dockerfile_instruction(line: &str) -> Option<&str> {
    for keyword in &["RUN ", "CMD ", "ENTRYPOINT "] {
        if line.len() >= keyword.len() && line[..keyword.len()].eq_ignore_ascii_case(keyword) {
            return Some(&line[keyword.len()..]);
        }
    }
    None
}

/// Parse Docker/TOML exec form `["cmd", "arg1", "arg2"]` into a shell-like command string.
///
/// Handles commas inside quoted strings correctly.
fn parse_exec_form(s: &str) -> String {
    let inner = s.trim().trim_start_matches('[').trim_end_matches(']');
    let mut parts = Vec::new();
    let mut in_quotes = false;
    let mut current = String::new();
    for ch in inner.chars() {
        match ch {
            '"' | '\'' => in_quotes = !in_quotes,
            ',' if !in_quotes => {
                let t = current.trim().to_string();
                if !t.is_empty() {
                    parts.push(t);
                }
                current.clear();
            }
            _ => current.push(ch),
        }
    }
    let t = current.trim().to_string();
    if !t.is_empty() {
        parts.push(t);
    }
    parts.join(" ")
}

/// Extract file path references from a Procfile.
///
/// Format: `process_type: command`
fn extract_procfile_file_refs(content: &str) -> Vec<String> {
    let mut refs = Vec::new();
    for line in content.lines() {
        let line = line.trim();
        if line.is_empty() || line.starts_with('#') {
            continue;
        }
        // Procfile format: `type: command`
        if let Some((_process_type, command)) = line.split_once(':') {
            refs.extend(extract_script_file_refs(command.trim()));
        }
    }
    refs
}

/// Extract file path references from fly.toml.
///
/// Parses `release_command`, `cmd` at any level, and all keys under `[processes]`.
fn extract_fly_toml_file_refs(content: &str) -> Vec<String> {
    let mut refs = Vec::new();
    let mut in_processes_section = false;

    for line in content.lines() {
        let line = line.trim();
        if line.is_empty() || line.starts_with('#') {
            continue;
        }

        // Track TOML sections
        if line.starts_with('[') {
            in_processes_section =
                line.trim_start_matches('[').trim_end_matches(']').trim() == "processes";
            continue;
        }

        // Match key = "value" or key = 'value' patterns
        if let Some((key, value)) = line.split_once('=') {
            let key = key.trim();
            let value = value.trim().trim_matches('"').trim_matches('\'');

            // Global keys: release_command, cmd
            // Section keys: all keys under [processes]
            if matches!(key, "release_command" | "cmd") || in_processes_section {
                let command = if value.starts_with('[') {
                    parse_exec_form(value)
                } else {
                    value.to_string()
                };
                refs.extend(extract_script_file_refs(&command));
            }
        }
    }

    refs
}

#[cfg(test)]
mod tests {
    use super::*;

    // is_dockerfile tests
    #[test]
    fn dockerfile_detection() {
        assert!(is_dockerfile("Dockerfile"));
        assert!(is_dockerfile("Dockerfile.worker"));
        assert!(is_dockerfile("Dockerfile.dev"));
        assert!(is_dockerfile("app.Dockerfile"));
        assert!(!is_dockerfile("Dockerfile.dockerignore"));
        assert!(!is_dockerfile("README.md"));
        assert!(!is_dockerfile("docker-compose.yml"));
    }

    // extract_dockerfile_file_refs tests
    #[test]
    fn dockerfile_run_node() {
        let refs = extract_dockerfile_file_refs("RUN node scripts/db-migrate.mjs");
        assert_eq!(refs, vec!["scripts/db-migrate.mjs"]);
    }

    #[test]
    fn dockerfile_cmd_shell_form() {
        let refs = extract_dockerfile_file_refs("CMD node dist/server.js");
        assert_eq!(refs, vec!["dist/server.js"]);
    }

    #[test]
    fn dockerfile_cmd_exec_form() {
        let refs = extract_dockerfile_file_refs(r#"CMD ["node", "scripts/server.js"]"#);
        assert_eq!(refs, vec!["scripts/server.js"]);
    }

    #[test]
    fn dockerfile_entrypoint_exec_form() {
        let refs = extract_dockerfile_file_refs(r#"ENTRYPOINT ["node", "src/index.ts"]"#);
        assert_eq!(refs, vec!["src/index.ts"]);
    }

    #[test]
    fn dockerfile_run_esbuild() {
        let refs = extract_dockerfile_file_refs(
            "RUN npx esbuild src/server/jobs/worker.ts --outfile=dist-worker/worker.mjs --bundle",
        );
        // Extracts both the entry point and the outfile from flag values
        assert_eq!(
            refs,
            vec!["src/server/jobs/worker.ts", "dist-worker/worker.mjs"]
        );
    }

    #[test]
    fn dockerfile_multiline_run() {
        let refs =
            extract_dockerfile_file_refs("RUN node \\\n  scripts/db-migrate.mjs \\\n  --verbose");
        assert_eq!(refs, vec!["scripts/db-migrate.mjs"]);
    }

    #[test]
    fn dockerfile_skips_comments_and_other_instructions() {
        let content =
            "FROM node:20\n# This is a comment\nCOPY . .\nRUN node scripts/seed.ts\nEXPOSE 3000";
        let refs = extract_dockerfile_file_refs(content);
        assert_eq!(refs, vec!["scripts/seed.ts"]);
    }

    #[test]
    fn dockerfile_case_insensitive() {
        let refs = extract_dockerfile_file_refs("run node scripts/migrate.ts");
        assert_eq!(refs, vec!["scripts/migrate.ts"]);
    }

    #[test]
    fn dockerfile_run_tsx_runner() {
        let refs = extract_dockerfile_file_refs("RUN tsx src/worker.ts");
        assert_eq!(refs, vec!["src/worker.ts"]);
    }

    #[test]
    fn dockerfile_no_file_refs() {
        let content = "FROM node:20\nRUN npm install\nRUN npm run build\nCMD [\"npm\", \"start\"]";
        let refs = extract_dockerfile_file_refs(content);
        assert!(refs.is_empty());
    }

    // extract_procfile_file_refs tests
    #[test]
    fn procfile_basic() {
        let refs = extract_procfile_file_refs("web: node server.js\nworker: node worker.js");
        assert_eq!(refs, vec!["server.js", "worker.js"]);
    }

    #[test]
    fn procfile_with_comments() {
        let refs = extract_procfile_file_refs("# comment\nweb: node src/index.ts");
        assert_eq!(refs, vec!["src/index.ts"]);
    }

    #[test]
    fn procfile_empty() {
        let refs = extract_procfile_file_refs("");
        assert!(refs.is_empty());
    }

    // extract_fly_toml_file_refs tests
    #[test]
    fn fly_toml_release_command() {
        let refs = extract_fly_toml_file_refs(r#"release_command = "node scripts/db-migrate.mjs""#);
        assert_eq!(refs, vec!["scripts/db-migrate.mjs"]);
    }

    #[test]
    fn fly_toml_process_commands() {
        let content = "[processes]\nweb = \"node dist/server.js\"\nworker = \"node src/worker.ts\"";
        let refs = extract_fly_toml_file_refs(content);
        assert_eq!(refs, vec!["dist/server.js", "src/worker.ts"]);
    }

    #[test]
    fn fly_toml_cmd() {
        let refs = extract_fly_toml_file_refs(r#"cmd = "node src/index.js""#);
        assert_eq!(refs, vec!["src/index.js"]);
    }

    #[test]
    fn fly_toml_ignores_non_process_keys() {
        let refs = extract_fly_toml_file_refs(r#"app = "my-app""#);
        assert!(refs.is_empty());
    }

    #[test]
    fn fly_toml_comments_and_sections() {
        let content = "# deploy config\n[deploy]\nrelease_command = \"node scripts/migrate.mjs\"";
        let refs = extract_fly_toml_file_refs(content);
        assert_eq!(refs, vec!["scripts/migrate.mjs"]);
    }

    // parse_exec_form tests
    #[test]
    fn exec_form_basic() {
        assert_eq!(
            parse_exec_form(r#"["node", "server.js"]"#),
            "node server.js"
        );
    }

    #[test]
    fn exec_form_with_flags() {
        assert_eq!(
            parse_exec_form(r#"["node", "--max-old-space-size=4096", "server.js"]"#),
            "node --max-old-space-size=4096 server.js"
        );
    }

    #[test]
    fn exec_form_with_commas_in_args() {
        // Commas inside quoted strings should not split the argument
        assert_eq!(
            parse_exec_form(r#"["node", "--require=a,b", "server.js"]"#),
            "node --require=a,b server.js"
        );
    }

    #[test]
    fn fly_toml_arbitrary_process_name() {
        // Any key under [processes] should be detected, not just hardcoded names
        let content = "[processes]\nmigrations = \"node scripts/migrate.mjs\"";
        let refs = extract_fly_toml_file_refs(content);
        assert_eq!(refs, vec!["scripts/migrate.mjs"]);
    }

    #[test]
    fn fly_toml_exec_form_array() {
        let content = r#"cmd = ["node", "src/index.js"]"#;
        let refs = extract_fly_toml_file_refs(content);
        assert_eq!(refs, vec!["src/index.js"]);
    }

    #[test]
    fn fly_toml_section_switching() {
        // Keys after a non-processes section should not be treated as processes
        let content =
            "[processes]\nworker = \"node src/worker.ts\"\n[env]\nNODE_ENV = \"production\"";
        let refs = extract_fly_toml_file_refs(content);
        assert_eq!(refs, vec!["src/worker.ts"]);
    }

    // strip_dockerfile_instruction tests
    #[test]
    fn strip_instruction_run() {
        assert_eq!(
            strip_dockerfile_instruction("RUN node server.js"),
            Some("node server.js")
        );
    }

    #[test]
    fn strip_instruction_cmd() {
        assert_eq!(
            strip_dockerfile_instruction("CMD node server.js"),
            Some("node server.js")
        );
    }

    #[test]
    fn strip_instruction_entrypoint() {
        assert_eq!(
            strip_dockerfile_instruction("ENTRYPOINT node server.js"),
            Some("node server.js")
        );
    }

    #[test]
    fn strip_instruction_case_insensitive() {
        assert_eq!(
            strip_dockerfile_instruction("run node server.js"),
            Some("node server.js")
        );
        assert_eq!(
            strip_dockerfile_instruction("cmd node server.js"),
            Some("node server.js")
        );
    }

    #[test]
    fn strip_instruction_non_matching() {
        assert_eq!(strip_dockerfile_instruction("FROM node:20"), None);
        assert_eq!(strip_dockerfile_instruction("COPY . ."), None);
        assert_eq!(strip_dockerfile_instruction("EXPOSE 3000"), None);
        assert_eq!(strip_dockerfile_instruction("ENV FOO=bar"), None);
    }

    // extract_flag_value_file_refs tests
    #[test]
    fn flag_value_file_refs_esbuild_outfile() {
        let refs = extract_flag_value_file_refs("npx esbuild src/entry.ts --outfile=dist/out.js");
        assert_eq!(refs, vec!["dist/out.js"]);
    }

    #[test]
    fn flag_value_file_refs_alias() {
        let refs = extract_flag_value_file_refs("node --alias:helper=./src/helper.ts app.js");
        assert_eq!(refs, vec!["./src/helper.ts"]);
    }

    #[test]
    fn flag_value_file_refs_no_flags() {
        let refs = extract_flag_value_file_refs("node src/server.js");
        assert!(refs.is_empty(), "non-flag tokens should not match");
    }

    #[test]
    fn flag_value_file_refs_flag_without_file() {
        let refs = extract_flag_value_file_refs("node --max-old-space-size=4096 server.js");
        assert!(
            refs.is_empty(),
            "flag values that are not file paths should not match"
        );
    }

    // parse_exec_form edge cases
    #[test]
    fn exec_form_single_element() {
        assert_eq!(parse_exec_form(r#"["node"]"#), "node");
    }

    #[test]
    fn exec_form_empty() {
        assert_eq!(parse_exec_form("[]"), "");
    }

    #[test]
    fn exec_form_single_quotes() {
        assert_eq!(parse_exec_form("['node', 'server.js']"), "node server.js");
    }

    // discover_infrastructure_entry_points integration tests
    mod integration {
        use super::*;

        #[test]
        fn discovers_dockerfile_cmd_entry_point() {
            let dir = tempfile::tempdir().expect("create temp dir");
            let src = dir.path().join("src");
            std::fs::create_dir_all(&src).unwrap();
            std::fs::write(src.join("server.ts"), "export const s = 1;").unwrap();

            let dockerfile = "FROM node:20\nCOPY . .\nCMD node src/server.ts";
            std::fs::write(dir.path().join("Dockerfile"), dockerfile).unwrap();

            let entries = discover_infrastructure_entry_points(dir.path());
            assert_eq!(entries.len(), 1);
            assert!(entries[0].path.ends_with("src/server.ts"));
            assert!(matches!(
                entries[0].source,
                EntryPointSource::InfrastructureConfig
            ));
        }

        #[test]
        fn discovers_procfile_entry_points() {
            let dir = tempfile::tempdir().expect("create temp dir");
            std::fs::write(dir.path().join("server.js"), "// server").unwrap();
            std::fs::write(dir.path().join("worker.js"), "// worker").unwrap();

            let procfile = "web: node server.js\nworker: node worker.js";
            std::fs::write(dir.path().join("Procfile"), procfile).unwrap();

            let entries = discover_infrastructure_entry_points(dir.path());
            assert_eq!(entries.len(), 2);

            let paths: Vec<String> = entries
                .iter()
                .map(|e| e.path.file_name().unwrap().to_string_lossy().into_owned())
                .collect();
            assert!(paths.contains(&"server.js".to_string()));
            assert!(paths.contains(&"worker.js".to_string()));
        }

        #[test]
        fn no_infrastructure_files_returns_empty() {
            let dir = tempfile::tempdir().expect("create temp dir");
            let entries = discover_infrastructure_entry_points(dir.path());
            assert!(entries.is_empty());
        }

        #[test]
        fn discovers_variant_dockerfile_names() {
            let dir = tempfile::tempdir().expect("create temp dir");
            let scripts = dir.path().join("scripts");
            std::fs::create_dir_all(&scripts).unwrap();
            std::fs::write(scripts.join("migrate.ts"), "// migrate").unwrap();

            // Dockerfile.worker variant
            let dockerfile = "FROM node:20\nRUN node scripts/migrate.ts";
            std::fs::write(dir.path().join("Dockerfile.worker"), dockerfile).unwrap();

            let entries = discover_infrastructure_entry_points(dir.path());
            assert_eq!(entries.len(), 1);
            assert!(entries[0].path.ends_with("scripts/migrate.ts"));
        }

        #[test]
        fn deduplicates_entry_points() {
            let dir = tempfile::tempdir().expect("create temp dir");
            std::fs::write(dir.path().join("server.js"), "// server").unwrap();

            // Both Dockerfile and Procfile reference the same file
            std::fs::write(
                dir.path().join("Dockerfile"),
                "FROM node:20\nCMD node server.js",
            )
            .unwrap();
            std::fs::write(dir.path().join("Procfile"), "web: node server.js").unwrap();

            let entries = discover_infrastructure_entry_points(dir.path());
            assert_eq!(
                entries.len(),
                1,
                "duplicate entry points should be deduplicated"
            );
        }
    }
}