fallow-config 3.18.0

Configuration types and workspace discovery for fallow codebase intelligence
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
//! Parser for the top-level `overrides` section of a root `package.json` as
//! used by npm.
//!
//! npm supports forcing transitive dependency versions through a top-level
//! `overrides` object in the root `package.json`:
//!
//! ```json
//! {
//!   "overrides": {
//!     "sanitize-html": ">=2.17.4",
//!     "typescript": "$typescript",
//!     "lit-markdown": {
//!       ".": "^1.0.0",
//!       "sanitize-html": ">=2.17.4"
//!     }
//!   }
//! }
//! ```
//!
//! Unlike pnpm's flat `parent>child` keys, npm expresses parent scoping by
//! nesting objects: a child key inside a parent's object only applies within
//! that parent's dependency subtree. The special `"."` key pins the version of
//! the enclosing parent itself. The `"$package"` value form references the
//! version declared for `package` in the root dependencies.
//!
//! The parser flattens nested objects into the same [`PnpmOverrideEntry`]
//! shape the pnpm parser produces (joining nesting levels with `>`), so the
//! unused-override and misconfigured-override detectors can analyze npm and
//! pnpm overrides through one code path.
//!
//! bun reads the same top-level `overrides` object and, as a Yarn migration
//! aid, a top-level `resolutions` object with flat string entries whose keys
//! may use yarn's dependency-path spelling (`parent/child`, `**/child`).
//! [`parse_bun_package_json_resolutions`] maps that dialect onto the shared
//! entry shape so bun repositories get the same two findings for
//! `resolutions` (issue #2367).

use super::pnpm_overrides::{
    ParsedOverrideKey, PnpmOverrideData, PnpmOverrideEntry, parse_override_key,
    split_pkg_and_selector,
};

const OVERRIDES_KEY: &str = "overrides";
const RESOLUTIONS_KEY: &str = "resolutions";
const YARN_GLOB_SEGMENT: &str = "**";
const YARN_COMMENT_KEY_PREFIX: &str = "//";

/// Parse the top-level `overrides` section of a root `package.json`. Returns
/// an empty `PnpmOverrideData` when the file has no overrides, when the JSON
/// is malformed, or when the section is present but empty.
#[must_use]
pub fn parse_npm_package_json_overrides(source: &str) -> PnpmOverrideData {
    let value: serde_json::Value = match serde_json::from_str(source) {
        Ok(v) => v,
        Err(_) => return PnpmOverrideData::default(),
    };
    let Some(overrides) = value.get(OVERRIDES_KEY).and_then(|o| o.as_object()) else {
        return PnpmOverrideData::default();
    };

    let mut line_index = NpmOverridesLineIndex::build(source, OVERRIDES_KEY, true);
    let mut entries = Vec::new();
    let mut path: Vec<String> = Vec::new();
    flatten_overrides(overrides, &mut path, &mut line_index, &mut entries);
    PnpmOverrideData { entries }
}

/// Parse the Yarn-style top-level `resolutions` object of a root
/// `package.json` the way bun reads it (issue #2367). bun treats
/// `resolutions` as an alias of `overrides` with flat string entries: a key
/// is a bare package (`left-pad`, `@scope/pkg`, `pkg@<2`), a yarn dependency
/// path (`parent/child`, `**/child`, `parent/**/child`, where `@scope/name`
/// spans two path segments), or the pnpm `parent>child` form. Paths deeper
/// than one parent and non-string values are kept as entries without a
/// parsed key or value so the misconfigured-override detector reports them,
/// matching the warning bun prints before skipping such entries. Keys that
/// start with `//` are comments and skipped. Returns empty data when the
/// file has no `resolutions` object or the JSON is malformed. Callers decide
/// whether the repository installs with bun and whether an `overrides` key
/// shadows the section.
#[must_use]
pub fn parse_bun_package_json_resolutions(source: &str) -> PnpmOverrideData {
    let value: serde_json::Value = match serde_json::from_str(source) {
        Ok(v) => v,
        Err(_) => return PnpmOverrideData::default(),
    };
    let Some(resolutions) = value.get(RESOLUTIONS_KEY).and_then(|o| o.as_object()) else {
        return PnpmOverrideData::default();
    };

    let mut line_index = NpmOverridesLineIndex::build(source, RESOLUTIONS_KEY, false);
    let mut entries = Vec::with_capacity(resolutions.len());
    for (key, value) in resolutions {
        let line = line_index.next_line_for(key);
        if key.starts_with(YARN_COMMENT_KEY_PREFIX) {
            continue;
        }
        let raw_value = match value {
            serde_json::Value::String(s) => Some(s.clone()),
            _ => None,
        };
        let Some(line) = line else {
            continue;
        };
        entries.push(PnpmOverrideEntry {
            raw_key: key.clone(),
            parsed_key: parse_resolution_key(key),
            raw_value,
            line,
        });
    }
    PnpmOverrideData { entries }
}

/// Parse a `resolutions` key into the shared override key shape. The pnpm
/// `parent>child` spelling is delegated to the pnpm key parser; everything
/// else is a yarn dependency path where `**` segments match any depth,
/// `@scope/name` spans two segments, and at most one parent precedes the
/// target. Returns `None` for the shapes bun rejects: an empty segment, a
/// bare scope, a trailing `**`, or more than one parent level.
fn parse_resolution_key(key: &str) -> Option<ParsedOverrideKey> {
    let trimmed = key.trim();
    if trimmed.is_empty() {
        return None;
    }
    if let Some(delimiter) = pnpm_delimiter(trimmed) {
        if pnpm_delimiter(&trimmed[delimiter + 1..]).is_some() {
            return None;
        }
        return parse_override_key(trimmed);
    }

    let mut segments: Vec<String> = Vec::with_capacity(2);
    let mut tokens = trimmed.split('/').peekable();
    while let Some(token) = tokens.next() {
        if token.is_empty() {
            return None;
        }
        if token == YARN_GLOB_SEGMENT {
            tokens.peek()?;
            continue;
        }
        let segment = if token.starts_with('@') {
            let name = tokens.next().filter(|name| !name.is_empty())?;
            format!("{token}/{name}")
        } else {
            token.to_string()
        };
        if segments.len() == 2 {
            return None;
        }
        segments.push(segment);
    }

    let (parent, target) = match segments.as_slice() {
        [target] => (None, target),
        [parent, target] => (Some(parent), target),
        _ => return None,
    };
    let (target_package, target_version_selector) = split_pkg_and_selector(target)?;
    let (parent_package, parent_version_selector) = match parent {
        Some(parent) => {
            let (package, selector) = split_pkg_and_selector(parent)?;
            (Some(package), selector)
        }
        None => (None, None),
    };
    Some(ParsedOverrideKey {
        parent_package,
        parent_version_selector,
        target_package,
        target_version_selector,
    })
}

/// Byte offset of the pnpm `parent>child` delimiter as bun recognises it:
/// the first `>` past the first byte that is not preceded by a space, `|`,
/// or `@`, so `pkg@>=1` keeps its version selector intact.
fn pnpm_delimiter(key: &str) -> Option<usize> {
    let bytes = key.as_bytes();
    bytes.iter().enumerate().skip(1).find_map(|(index, byte)| {
        (*byte == b'>' && !matches!(bytes[index - 1], b' ' | b'|' | b'@')).then_some(index)
    })
}

/// Depth-first flattening of the (possibly nested) overrides object into flat
/// entries. `serde_json` is built with `preserve_order`, so map iteration
/// follows source order and stays aligned with the line index cursor.
fn flatten_overrides(
    object: &serde_json::Map<String, serde_json::Value>,
    path: &mut Vec<String>,
    line_index: &mut NpmOverridesLineIndex,
    entries: &mut Vec<PnpmOverrideEntry>,
) {
    for (key, value) in object {
        let line = line_index.next_line_for(key);
        if let serde_json::Value::Object(child) = value {
            path.push(key.clone());
            flatten_overrides(child, path, line_index, entries);
            path.pop();
            continue;
        }

        let raw_value = match value {
            serde_json::Value::String(s) => Some(s.clone()),
            serde_json::Value::Null => None,
            other => Some(other.to_string()),
        };
        let Some(line) = line else {
            continue;
        };
        let (raw_key, parsed_key) = build_npm_key(path, key);
        entries.push(PnpmOverrideEntry {
            raw_key,
            parsed_key,
            raw_value,
            line,
        });
    }
}

/// Build the flattened key and parsed structure for one npm override entry.
///
/// `path` holds the enclosing parent keys (outermost first); `key` is the
/// entry's own key. The npm `"."` key targets the enclosing parent itself, so
/// it is dropped from the effective segment list. The flattened `raw_key`
/// joins the effective segments with `>` to mirror pnpm's spelling in
/// reports and suppression rules.
fn build_npm_key(path: &[String], key: &str) -> (String, Option<ParsedOverrideKey>) {
    let mut segments: Vec<&str> = path.iter().map(String::as_str).collect();
    if key == "." {
        if segments.is_empty() {
            return (key.to_string(), None);
        }
    } else {
        segments.push(key);
    }

    let raw_key = segments.join(">");
    let Some(target_segment) = segments.last() else {
        return (raw_key, None);
    };
    let Some((target_package, target_version_selector)) = split_pkg_and_selector(target_segment)
    else {
        return (raw_key, None);
    };

    let (parent_package, parent_version_selector) = if segments.len() >= 2 {
        // Credit against the outermost parent: that is the direct dependency
        // the user declares in package.json.
        match split_pkg_and_selector(segments[0]) {
            Some((pkg, selector)) => (Some(pkg), selector),
            None => return (raw_key, None),
        }
    } else {
        (None, None)
    };

    (
        raw_key,
        Some(ParsedOverrideKey {
            parent_package,
            parent_version_selector,
            target_package,
            target_version_selector,
        }),
    )
}

/// Ordered `(key, line)` pairs for every key inside one top-level section
/// object (`overrides` or `resolutions`), consumed by a forward-only cursor
/// during flattening.
struct NpmOverridesLineIndex {
    entries: Vec<(String, u32)>,
    cursor: usize,
}

impl NpmOverridesLineIndex {
    /// Return the line of the next recorded key matching `key`, scanning
    /// forward from the cursor so repeated child names under different
    /// parents resolve to their own occurrence.
    fn next_line_for(&mut self, key: &str) -> Option<u32> {
        let found = self.entries[self.cursor..]
            .iter()
            .position(|(k, _)| k == key)?;
        let index = self.cursor + found;
        self.cursor = index + 1;
        Some(self.entries[index].1)
    }

    /// Walk the raw source with a brace-depth scanner and record every key
    /// inside the top-level `section` object, paired with its 1-based line
    /// number. With `nested` set, keys at any depth inside the section are
    /// recorded (npm scopes overrides by nesting); otherwise only the
    /// section's direct keys are, so a nested object value bun rejects cannot
    /// shift the cursor onto a later key of the same name.
    fn build(source: &str, section: &'static str, nested: bool) -> Self {
        let mut scan = NpmOverridesJsonScan::new(section, nested);
        let mut current_line = 1u32;

        for ch in source.chars() {
            if ch == '\n' {
                current_line += 1;
            }

            if scan.in_string {
                scan.consume_in_string_char(ch);
            } else {
                scan.consume_structural_char(ch, current_line);
            }
        }

        Self {
            entries: scan.entries,
            cursor: 0,
        }
    }
}

/// Char-by-char brace-depth scanner state for a top-level section line
/// index. Mirrors the pnpm `pnpm.overrides` scanner, but can record keys at
/// every nesting depth inside the section object because npm scopes
/// overrides by nesting rather than by `parent>child` keys.
struct NpmOverridesJsonScan {
    section: &'static str,
    nested: bool,
    entries: Vec<(String, u32)>,
    depth: i32,
    section_depth: Option<i32>,
    in_string: bool,
    escape: bool,
    last_key: Option<String>,
    key_buf: String,
    collecting_key: bool,
}

impl NpmOverridesJsonScan {
    fn new(section: &'static str, nested: bool) -> Self {
        Self {
            section,
            nested,
            entries: Vec::new(),
            depth: 0,
            section_depth: None,
            in_string: false,
            escape: false,
            last_key: None,
            key_buf: String::new(),
            collecting_key: false,
        }
    }

    fn consume_in_string_char(&mut self, ch: char) {
        if self.escape {
            if self.collecting_key {
                self.key_buf.push(ch);
            }
            self.escape = false;
            return;
        }
        if ch == '\\' {
            self.escape = true;
            if self.collecting_key {
                self.key_buf.push(ch);
            }
            return;
        }
        if ch == '"' {
            self.in_string = false;
            if self.collecting_key {
                let raw_key = std::mem::take(&mut self.key_buf);
                let quoted = format!("\"{raw_key}\"");
                self.last_key = serde_json::from_str(&quoted).ok().or(Some(raw_key));
                self.collecting_key = false;
            }
            return;
        }
        if self.collecting_key {
            self.key_buf.push(ch);
        }
    }

    fn consume_structural_char(&mut self, ch: char, current_line: u32) {
        match ch {
            '"' => {
                self.in_string = true;
                self.collecting_key = true;
                self.key_buf.clear();
            }
            '{' => self.depth += 1,
            '}' => {
                // The section object closes when depth returns to the level
                // where its key was seen.
                if self.section_depth == Some(self.depth - 1) {
                    self.section_depth = None;
                }
                self.depth -= 1;
            }
            ':' => self.record_key_after_colon(current_line),
            ',' => {
                self.last_key = None;
            }
            _ => {}
        }
    }

    fn record_key_after_colon(&mut self, current_line: u32) {
        let Some(key) = self.last_key.take() else {
            return;
        };
        if self.section_depth.is_none() && self.depth == 1 && key == self.section {
            self.section_depth = Some(self.depth);
        } else if let Some(d) = self.section_depth
            && self.depth > d
            && (self.nested || self.depth == d + 1)
        {
            self.entries.push((key, current_line));
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn parses_top_level_simple_override() {
        let json = r#"{
  "name": "root",
  "overrides": {
    "sanitize-html": ">=2.17.4"
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        assert_eq!(data.entries[0].raw_key, "sanitize-html");
        assert_eq!(data.entries[0].raw_value.as_deref(), Some(">=2.17.4"));
        assert_eq!(data.entries[0].line, 4);
        let parsed = data.entries[0].parsed_key.as_ref().unwrap();
        assert_eq!(parsed.target_package, "sanitize-html");
        assert!(parsed.parent_package.is_none());
    }

    #[test]
    fn flattens_nested_overrides_with_parent() {
        let json = r#"{
  "overrides": {
    "lit-markdown": {
      ".": "^1.0.0",
      "sanitize-html": ">=2.17.4"
    }
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 2);

        assert_eq!(data.entries[0].raw_key, "lit-markdown");
        assert_eq!(data.entries[0].line, 4);
        let dot = data.entries[0].parsed_key.as_ref().unwrap();
        assert_eq!(dot.target_package, "lit-markdown");
        assert!(dot.parent_package.is_none());

        assert_eq!(data.entries[1].raw_key, "lit-markdown>sanitize-html");
        assert_eq!(data.entries[1].line, 5);
        let nested = data.entries[1].parsed_key.as_ref().unwrap();
        assert_eq!(nested.target_package, "sanitize-html");
        assert_eq!(nested.parent_package.as_deref(), Some("lit-markdown"));
    }

    #[test]
    fn deep_nesting_credits_outermost_parent() {
        let json = r#"{
  "overrides": {
    "a": {
      "b": {
        "c": "^1.0.0"
      }
    }
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        assert_eq!(data.entries[0].raw_key, "a>b>c");
        assert_eq!(data.entries[0].line, 5);
        let parsed = data.entries[0].parsed_key.as_ref().unwrap();
        assert_eq!(parsed.target_package, "c");
        assert_eq!(parsed.parent_package.as_deref(), Some("a"));
    }

    #[test]
    fn version_selector_on_key_is_parsed() {
        let json = r#"{"overrides": {"@types/react@<18": "18.0.0"}}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        let parsed = data.entries[0].parsed_key.as_ref().unwrap();
        assert_eq!(parsed.target_package, "@types/react");
        assert_eq!(parsed.target_version_selector.as_deref(), Some("<18"));
    }

    #[test]
    fn escaped_json_override_key_keeps_its_source_line() {
        let json = r#"{
  "overrides": {
    "left\u002dpad": "^1.3.0"
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        assert_eq!(data.entries[0].raw_key, "left-pad");
        assert_eq!(data.entries[0].line, 3);
    }

    #[test]
    fn dollar_reference_value_is_preserved() {
        let json = r#"{"overrides": {"typescript": "$typescript"}}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        assert_eq!(data.entries[0].raw_value.as_deref(), Some("$typescript"));
    }

    #[test]
    fn repeated_child_names_get_distinct_lines() {
        let json = r#"{
  "overrides": {
    "parent-one": {
      "shared-child": "^1.0.0"
    },
    "parent-two": {
      "shared-child": "^2.0.0"
    }
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 2);
        assert_eq!(data.entries[0].raw_key, "parent-one>shared-child");
        assert_eq!(data.entries[0].line, 4);
        assert_eq!(data.entries[1].raw_key, "parent-two>shared-child");
        assert_eq!(data.entries[1].line, 7);
    }

    #[test]
    fn nested_overrides_key_deeper_in_document_is_ignored() {
        let json = r#"{
  "config": {
    "overrides": {
      "not-an-override": "^1.0.0"
    }
  }
}"#;
        let data = parse_npm_package_json_overrides(json);
        assert!(data.entries.is_empty());
    }

    #[test]
    fn top_level_dot_key_is_unparsable() {
        let json = r#"{"overrides": {".": "^1.0.0"}}"#;
        let data = parse_npm_package_json_overrides(json);
        assert_eq!(data.entries.len(), 1);
        assert!(data.entries[0].parsed_key.is_none());
    }

    #[test]
    fn package_json_without_overrides_returns_no_entries() {
        let data = parse_npm_package_json_overrides(r#"{"dependencies": {"axios": "^1"}}"#);
        assert!(data.entries.is_empty());
    }

    #[test]
    fn pnpm_overrides_section_is_not_picked_up() {
        let data =
            parse_npm_package_json_overrides(r#"{"pnpm": {"overrides": {"axios": "^1.6.0"}}}"#);
        assert!(data.entries.is_empty());
    }

    #[test]
    fn malformed_json_returns_no_entries() {
        let data = parse_npm_package_json_overrides("{not valid json");
        assert!(data.entries.is_empty());
    }

    // Issue #2367: bun reads Yarn-style `resolutions` as an `overrides` alias.

    fn parsed(entry: &PnpmOverrideEntry) -> &ParsedOverrideKey {
        entry
            .parsed_key
            .as_ref()
            .unwrap_or_else(|| panic!("{} should parse", entry.raw_key))
    }

    #[test]
    fn resolutions_flat_entries_parse_with_lines() {
        let json = r#"{
  "name": "root",
  "resolutions": {
    "ws": "^8.21.0",
    "left-pad": "^1.3.0"
  }
}"#;
        let data = parse_bun_package_json_resolutions(json);
        assert_eq!(data.entries.len(), 2);
        assert_eq!(data.entries[0].raw_key, "ws");
        assert_eq!(data.entries[0].line, 4);
        assert_eq!(data.entries[1].raw_key, "left-pad");
        assert_eq!(data.entries[1].raw_value.as_deref(), Some("^1.3.0"));
        assert_eq!(data.entries[1].line, 5);
        let left_pad = parsed(&data.entries[1]);
        assert_eq!(left_pad.target_package, "left-pad");
        assert!(left_pad.parent_package.is_none());
    }

    #[test]
    fn resolutions_yarn_path_keys_map_to_parent_and_target() {
        let json = r#"{
  "resolutions": {
    "**/left-pad": "^1.3.0",
    "react/left-pad": "^1.3.0",
    "react/**/left-pad": "^1.3.0",
    "@scope/parent/left-pad": "^1.3.0",
    "@scope/parent/@scope/child": "^1.3.0",
    "react@^18/left-pad": "^1.3.0",
    "@types/react@<18": "18.0.0"
  }
}"#;
        let data = parse_bun_package_json_resolutions(json);
        assert_eq!(data.entries.len(), 7);

        let glob = parsed(&data.entries[0]);
        assert_eq!(data.entries[0].raw_key, "**/left-pad");
        assert_eq!(glob.target_package, "left-pad");
        assert!(glob.parent_package.is_none());
        assert_eq!(data.entries[0].line, 3);

        let scoped_parent = parsed(&data.entries[1]);
        assert_eq!(scoped_parent.parent_package.as_deref(), Some("react"));
        assert_eq!(scoped_parent.target_package, "left-pad");

        let glob_between = parsed(&data.entries[2]);
        assert_eq!(glob_between.parent_package.as_deref(), Some("react"));
        assert_eq!(glob_between.target_package, "left-pad");

        let scoped = parsed(&data.entries[3]);
        assert_eq!(scoped.parent_package.as_deref(), Some("@scope/parent"));
        assert_eq!(scoped.target_package, "left-pad");

        let both_scoped = parsed(&data.entries[4]);
        assert_eq!(both_scoped.parent_package.as_deref(), Some("@scope/parent"));
        assert_eq!(both_scoped.target_package, "@scope/child");

        let ranged_parent = parsed(&data.entries[5]);
        assert_eq!(ranged_parent.parent_package.as_deref(), Some("react"));
        assert_eq!(
            ranged_parent.parent_version_selector.as_deref(),
            Some("^18")
        );
        assert_eq!(ranged_parent.target_package, "left-pad");

        let selector = parsed(&data.entries[6]);
        assert_eq!(selector.target_package, "@types/react");
        assert_eq!(selector.target_version_selector.as_deref(), Some("<18"));
        assert_eq!(data.entries[6].line, 9);
    }

    #[test]
    fn resolutions_pnpm_delimiter_keys_parse_like_overrides() {
        let json = r#"{"resolutions": {"react>left-pad": "^1.3.0", "pkg@>=1": "^2.0.0"}}"#;
        let data = parse_bun_package_json_resolutions(json);
        assert_eq!(data.entries.len(), 2);
        let chained = parsed(&data.entries[0]);
        assert_eq!(chained.parent_package.as_deref(), Some("react"));
        assert_eq!(chained.target_package, "left-pad");
        // `@>` is a version selector, not the pnpm delimiter.
        let selector = parsed(&data.entries[1]);
        assert!(selector.parent_package.is_none());
        assert_eq!(selector.target_package, "pkg");
        assert_eq!(selector.target_version_selector.as_deref(), Some(">=1"));
    }

    #[test]
    fn resolutions_shapes_bun_rejects_are_unparsable_or_valueless() {
        let json = r#"{
  "resolutions": {
    "a/b/c": "^1.0.0",
    "a>b>c": "^1.0.0",
    "@scope": "^1.0.0",
    "left-pad/**": "^1.0.0",
    "nested": { "left-pad": "^1.3.0" },
    "left-pad": "^1.3.0"
  }
}"#;
        let data = parse_bun_package_json_resolutions(json);
        assert_eq!(data.entries.len(), 6);
        for entry in &data.entries[..4] {
            assert!(
                entry.parsed_key.is_none(),
                "{} is deeper than one parent or malformed and must not parse",
                entry.raw_key
            );
        }
        assert_eq!(data.entries[4].raw_key, "nested");
        assert!(data.entries[4].parsed_key.is_some());
        assert!(
            data.entries[4].raw_value.is_none(),
            "bun only honours string resolution values"
        );
        // The nested object's inner key must not steal the line of the later
        // top-level entry with the same name.
        assert_eq!(data.entries[5].raw_key, "left-pad");
        assert_eq!(data.entries[5].line, 8);
    }

    #[test]
    fn resolutions_comment_keys_are_skipped_without_shifting_lines() {
        let json = r#"{
  "resolutions": {
    "//": "pin for CVE-2024-0001",
    "left-pad": "^1.3.0"
  }
}"#;
        let data = parse_bun_package_json_resolutions(json);
        assert_eq!(data.entries.len(), 1);
        assert_eq!(data.entries[0].raw_key, "left-pad");
        assert_eq!(data.entries[0].line, 4);
    }

    #[test]
    fn resolutions_parser_ignores_overrides_and_nested_sections() {
        assert!(
            parse_bun_package_json_resolutions(r#"{"overrides": {"left-pad": "^1.3.0"}}"#)
                .entries
                .is_empty()
        );
        assert!(
            parse_bun_package_json_resolutions(
                r#"{"config": {"resolutions": {"left-pad": "^1.3.0"}}}"#
            )
            .entries
            .is_empty()
        );
        assert!(
            parse_npm_package_json_overrides(r#"{"resolutions": {"left-pad": "^1.3.0"}}"#)
                .entries
                .is_empty()
        );
        assert!(
            parse_bun_package_json_resolutions("{not valid json")
                .entries
                .is_empty()
        );
    }
}