fallow-cli 3.22.0

CLI for fallow, codebase intelligence for TypeScript and JavaScript
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
/// Knip rule names mapped to fallow rule names.
pub(super) const KNIP_RULE_MAP: &[(&str, &str)] = &[
    ("files", "unused-files"),
    ("dependencies", "unused-dependencies"),
    ("devDependencies", "unused-dev-dependencies"),
    ("exports", "unused-exports"),
    ("types", "unused-types"),
    ("enumMembers", "unused-enum-members"),
    ("classMembers", "unused-class-members"),
    ("unlisted", "unlisted-dependencies"),
    ("unresolved", "unresolved-imports"),
    ("duplicates", "duplicate-exports"),
    ("cycles", "circular-dependencies"),
];

/// Knip fields that cannot be mapped and generate warnings.
pub(super) const KNIP_UNMAPPABLE_FIELDS: &[(&str, &str, Option<&str>)] = &[
    ("project", "Fallow auto-discovers project files", None),
    (
        "paths",
        "Fallow reads path mappings from tsconfig.json automatically",
        None,
    ),
    (
        "ignoreFiles",
        "Fallow has no dedicated ignoreFiles field",
        Some(
            "use overrides[].files with rules.unused-files = \"off\"; this keeps matching files in the analysis graph",
        ),
    ),
    (
        "ignoreBinaries",
        "Binary filtering is not configurable in fallow",
        None,
    ),
    (
        "ignoreMembers",
        "Member-level ignoring is not configurable in fallow",
        Some("use inline suppression comments: // fallow-ignore-next-line"),
    ),
    (
        "ignoreUnresolved",
        "Unresolved import filtering is not configurable in fallow",
        Some("use inline suppression comments: // fallow-ignore-next-line unresolved-import"),
    ),
    (
        "ignoreWorkspaces",
        "Workspace filtering is not configurable per-workspace",
        Some("use --workspace flag to scope output to a single package"),
    ),
    (
        "ignoreIssues",
        "No global issue ignoring in fallow",
        Some("use inline suppression comments: // fallow-ignore-file [issue-type]"),
    ),
    (
        "includeEntryExports",
        "Entry export inclusion is not configurable in fallow",
        None,
    ),
    (
        "tags",
        "Tag-based filtering is not supported in fallow",
        None,
    ),
    (
        "compilers",
        "Custom compilers are not supported in fallow (uses Oxc parser)",
        None,
    ),
    ("treatConfigHintsAsErrors", "No equivalent in fallow", None),
    ("treatTagHintsAsErrors", "No equivalent in fallow", None),
];

/// Knip root keys that `migrate_knip` translates into fallow config, plus the
/// `$schema` key every JSON config may carry. A key here is neither a plugin
/// section nor an unmappable field, so the unknown-key ladder in
/// `warn_unhandled_root_keys` must stay quiet about it.
pub(super) const KNIP_MIGRATED_FIELDS: &[&str] = &[
    "$schema",
    "entry",
    "exclude",
    "ignore",
    "ignoreDependencies",
    "ignoreExportsUsedInFile",
    "include",
    "rules",
    "workspaces",
];

/// Knip issue type names that have no fallow equivalent.
pub(super) const KNIP_UNMAPPABLE_ISSUE_TYPES: &[&str] = &[
    "optionalPeerDependencies",
    "binaries",
    "nsExports",
    "nsTypes",
    "catalog",
    "catalogReferences",
    "namespaceMembers",
];

/// Knip plugin config keys that a built-in fallow plugin covers. Fallow
/// detects these frameworks and tools from the project itself, so the knip
/// section has no fallow counterpart and can be dropped.
///
/// Keys come from the `Plugins` map in knip and from the plugin sections of
/// knip's published JSON schema, which still accepts a few keys that the
/// plugin map has since renamed. A key belongs here only when a plugin in
/// `fallow_core::plugins` registers the same tool. Keys that no fallow plugin
/// covers belong in `KNIP_UNSUPPORTED_PLUGIN_KEYS` instead.
pub(super) const KNIP_PLUGIN_KEYS: &[&str] = &[
    "angular",
    "astro",
    "ava",
    "babel",
    "biome",
    "bun",
    "c8",
    "capacitor",
    "changesets",
    "commitizen",
    "commitlint",
    "convex",
    "cspell",
    "cucumber",
    "cypress",
    "danger",
    "dependency-cruiser",
    "docusaurus",
    "drizzle",
    "electron-vite",
    "eslint",
    "expo",
    "fumadocs",
    "gatsby",
    "graphql-codegen",
    "hardhat",
    "husky",
    "jest",
    "karma",
    "knex",
    "lefthook",
    "lint-staged",
    "lit",
    "markdownlint",
    "mocha",
    "msw",
    "nest",
    "next",
    "next-intl",
    "nitro",
    "nodemon",
    "nuxt",
    "nx",
    "nyc",
    "openapi-ts",
    "oxlint",
    "panda-css",
    "parcel",
    "playwright",
    "plop",
    "pm2",
    "pnpm",
    "postcss",
    "prettier",
    "prisma",
    "qwik",
    "react-native",
    "react-router",
    "relay",
    "remark",
    "remix",
    "rolldown",
    "rollup",
    "rsbuild",
    "rspack",
    "sanity",
    "semantic-release",
    "sentry",
    "simple-git-hooks",
    "size-limit",
    "storybook",
    "stryker",
    "stylelint",
    "sveltekit",
    "svgo",
    "svgr",
    "swc",
    "syncpack",
    "tailwind",
    "tanstack-router",
    "tsd",
    "tsdown",
    "tsup",
    "typedoc",
    "typescript",
    "unocss",
    "vercel",
    "vite",
    "vitepress",
    "vitest",
    "webdriver-io",
    "webpack",
    "wrangler",
    "wxt",
];

/// Knip plugin config keys that no built-in fallow plugin covers. The section
/// is still recognized so a migration reports it instead of dropping it in
/// silence, but fallow makes no claim to detect the tool.
pub(super) const KNIP_UNSUPPORTED_PLUGIN_KEYS: &[&str] = &[
    "astro-db",
    "astro-markdoc",
    "astro-og-canvas",
    "borp",
    "bumpp",
    "catalyst",
    "changelogen",
    "changelogithub",
    "create-typescript-app",
    "dotenv",
    "eleventy",
    "esbuild",
    "eve",
    "execa",
    "expressive-code",
    "fast",
    "github-action",
    "github-actions",
    "glob",
    "i18next-parser",
    "ladle",
    "laravel-vite-plugin",
    "linthtml",
    "lockfile-lint",
    "lost-pixel",
    "lunaria",
    "marko",
    "mdx",
    "mdxlint",
    "metro",
    "moonrepo",
    "nano-spawn",
    "nano-staged",
    "netlify",
    "next-mdx",
    "node",
    "node-modules-inspector",
    "node-test-runner",
    "npm-package-json-lint",
    "nuxtjs-i18n",
    "oclif",
    "openclaw",
    "orval",
    "oxfmt",
    "payload",
    "pino",
    "playwright-ct",
    "playwright-test",
    "pre-commit",
    "preconstruct",
    "quasar",
    "raycast",
    "react-cosmos",
    "react-email",
    "release-it",
    "rslib",
    "rstest",
    "serverless-framework",
    "sst",
    "starlight",
    "stencil",
    "svelte",
    "sveltejs-package",
    "tanstack-start",
    "taskfile",
    "tauri",
    "temporal",
    "travis",
    "ts-node",
    "tsx",
    "unbuild",
    "unplugin-auto-import",
    "unplugin-icons",
    "unplugin-vue-components",
    "unplugin-vue-i18n",
    "unplugin-vue-markdown",
    "unplugin-vue-router",
    "vercel-og",
    "vike",
    "vite-plugin-pages",
    "vite-plugin-pwa",
    "vite-plugin-vue-layouts-next",
    "vite-plus",
    "vite-pwa-assets-generator",
    "vue",
    "wireit",
    "xo",
    "yarn",
    "yorkie",
    "zx",
];

#[cfg(test)]
mod tests {
    use super::*;
    use rustc_hash::{FxHashMap, FxHashSet};

    /// Knip plugin keys whose spelling differs from the built-in fallow plugin
    /// that covers the same tool. Every other entry of `KNIP_PLUGIN_KEYS` has
    /// to match a registered plugin name exactly, so a sixth spelling
    /// difference fails `plugin_keys_resolve_to_builtin_plugins` until it is
    /// declared here.
    const KNIP_PLUGIN_KEY_ALIASES: &[(&str, &str)] = &[
        ("electron-vite", "electron"),
        ("nest", "nestjs"),
        ("next", "nextjs"),
        ("panda-css", "pandacss"),
        ("webdriver-io", "webdriverio"),
    ];

    fn builtin_plugins() -> FxHashSet<&'static str> {
        fallow_engine::plugins::registry::builtin_plugin_names()
            .into_iter()
            .collect()
    }

    #[test]
    fn rule_map_has_no_empty_keys_or_values() {
        for (knip, fallow) in KNIP_RULE_MAP {
            assert!(!knip.is_empty(), "KNIP_RULE_MAP contains an empty knip key");
            assert!(
                !fallow.is_empty(),
                "KNIP_RULE_MAP contains an empty fallow value for key `{knip}`"
            );
        }
    }

    #[test]
    fn rule_map_has_no_duplicate_knip_keys() {
        let mut seen = FxHashSet::default();
        for (knip, _) in KNIP_RULE_MAP {
            assert!(
                seen.insert(*knip),
                "KNIP_RULE_MAP has duplicate knip key `{knip}`"
            );
        }
    }

    #[test]
    fn rule_map_has_no_duplicate_fallow_values() {
        let mut seen = FxHashSet::default();
        for (_, fallow) in KNIP_RULE_MAP {
            assert!(
                seen.insert(*fallow),
                "KNIP_RULE_MAP has duplicate fallow value `{fallow}`"
            );
        }
    }

    #[test]
    fn rule_map_is_non_empty() {
        assert!(
            !KNIP_RULE_MAP.is_empty(),
            "KNIP_RULE_MAP should not be empty"
        );
    }

    #[test]
    fn unmappable_fields_is_non_empty() {
        assert!(
            !KNIP_UNMAPPABLE_FIELDS.is_empty(),
            "KNIP_UNMAPPABLE_FIELDS should not be empty"
        );
    }

    #[test]
    fn unmappable_fields_have_non_empty_names_and_messages() {
        for (field, message, _) in KNIP_UNMAPPABLE_FIELDS {
            assert!(
                !field.is_empty(),
                "KNIP_UNMAPPABLE_FIELDS contains an empty field name"
            );
            assert!(
                !message.is_empty(),
                "KNIP_UNMAPPABLE_FIELDS contains an empty message for `{field}`"
            );
        }
    }

    #[test]
    fn unmappable_fields_do_not_overlap_with_rule_map_keys() {
        let rule_keys: FxHashSet<&str> = KNIP_RULE_MAP.iter().map(|(k, _)| *k).collect();
        for (field, _, _) in KNIP_UNMAPPABLE_FIELDS {
            assert!(
                !rule_keys.contains(field),
                "KNIP_UNMAPPABLE_FIELDS entry `{field}` overlaps with KNIP_RULE_MAP"
            );
        }
    }

    #[test]
    fn unmappable_issue_types_is_non_empty() {
        assert!(
            !KNIP_UNMAPPABLE_ISSUE_TYPES.is_empty(),
            "KNIP_UNMAPPABLE_ISSUE_TYPES should not be empty"
        );
    }

    #[test]
    fn unmappable_issue_types_do_not_overlap_with_rule_map_keys() {
        let rule_keys: FxHashSet<&str> = KNIP_RULE_MAP.iter().map(|(k, _)| *k).collect();
        for issue_type in KNIP_UNMAPPABLE_ISSUE_TYPES {
            assert!(
                !rule_keys.contains(issue_type),
                "KNIP_UNMAPPABLE_ISSUE_TYPES entry `{issue_type}` overlaps with KNIP_RULE_MAP"
            );
        }
    }

    #[test]
    fn plugin_keys_is_non_empty() {
        assert!(
            !KNIP_PLUGIN_KEYS.is_empty(),
            "KNIP_PLUGIN_KEYS should not be empty"
        );
    }

    #[test]
    fn plugin_keys_contains_known_plugins() {
        let expected = ["eslint", "jest", "vitest", "next", "webpack", "storybook"];
        for name in expected {
            assert!(
                KNIP_PLUGIN_KEYS.contains(&name),
                "KNIP_PLUGIN_KEYS should contain `{name}`"
            );
        }
    }

    #[test]
    fn plugin_keys_are_sorted() {
        for window in KNIP_PLUGIN_KEYS.windows(2) {
            assert!(
                window[0] < window[1],
                "KNIP_PLUGIN_KEYS is not sorted: `{}` should come after `{}`",
                window[1],
                window[0]
            );
        }
    }

    #[test]
    fn plugin_keys_have_no_duplicates() {
        let mut seen = FxHashSet::default();
        for key in KNIP_PLUGIN_KEYS {
            assert!(
                seen.insert(*key),
                "KNIP_PLUGIN_KEYS has duplicate entry `{key}`"
            );
        }
    }

    #[test]
    fn plugin_keys_do_not_overlap_with_unmappable_fields() {
        let unmappable: FxHashSet<&str> =
            KNIP_UNMAPPABLE_FIELDS.iter().map(|(f, _, _)| *f).collect();
        for key in KNIP_PLUGIN_KEYS {
            assert!(
                !unmappable.contains(key),
                "KNIP_PLUGIN_KEYS entry `{key}` overlaps with KNIP_UNMAPPABLE_FIELDS"
            );
        }
    }

    /// The unknown-root-key ladder decides by table membership, so a key that
    /// sits in two tables would either warn twice or warn wrongly.
    #[test]
    fn migrated_fields_do_not_overlap_with_the_other_tables() {
        let unmappable: FxHashSet<&str> =
            KNIP_UNMAPPABLE_FIELDS.iter().map(|(f, _, _)| *f).collect();
        let covered: FxHashSet<&str> = KNIP_PLUGIN_KEYS.iter().copied().collect();
        let unsupported: FxHashSet<&str> = KNIP_UNSUPPORTED_PLUGIN_KEYS.iter().copied().collect();
        for field in KNIP_MIGRATED_FIELDS {
            assert!(
                !unmappable.contains(field),
                "KNIP_MIGRATED_FIELDS entry `{field}` overlaps with KNIP_UNMAPPABLE_FIELDS"
            );
            assert!(
                !covered.contains(field),
                "KNIP_MIGRATED_FIELDS entry `{field}` overlaps with KNIP_PLUGIN_KEYS"
            );
            assert!(
                !unsupported.contains(field),
                "KNIP_MIGRATED_FIELDS entry `{field}` overlaps with KNIP_UNSUPPORTED_PLUGIN_KEYS"
            );
        }
    }

    #[test]
    fn unsupported_plugin_keys_is_non_empty() {
        assert!(
            !KNIP_UNSUPPORTED_PLUGIN_KEYS.is_empty(),
            "KNIP_UNSUPPORTED_PLUGIN_KEYS should not be empty"
        );
    }

    #[test]
    fn unsupported_plugin_keys_are_sorted() {
        for window in KNIP_UNSUPPORTED_PLUGIN_KEYS.windows(2) {
            assert!(
                window[0] < window[1],
                "KNIP_UNSUPPORTED_PLUGIN_KEYS is not sorted: `{}` should come after `{}`",
                window[1],
                window[0]
            );
        }
    }

    #[test]
    fn unsupported_plugin_keys_have_no_duplicates() {
        let mut seen = FxHashSet::default();
        for key in KNIP_UNSUPPORTED_PLUGIN_KEYS {
            assert!(
                seen.insert(*key),
                "KNIP_UNSUPPORTED_PLUGIN_KEYS has duplicate entry `{key}`"
            );
        }
    }

    #[test]
    fn unsupported_plugin_keys_do_not_overlap_with_plugin_keys() {
        let covered: FxHashSet<&str> = KNIP_PLUGIN_KEYS.iter().copied().collect();
        for key in KNIP_UNSUPPORTED_PLUGIN_KEYS {
            assert!(
                !covered.contains(key),
                "`{key}` is in both KNIP_PLUGIN_KEYS and KNIP_UNSUPPORTED_PLUGIN_KEYS"
            );
        }
    }

    #[test]
    fn unsupported_plugin_keys_do_not_overlap_with_unmappable_fields() {
        let unmappable: FxHashSet<&str> =
            KNIP_UNMAPPABLE_FIELDS.iter().map(|(f, _, _)| *f).collect();
        for key in KNIP_UNSUPPORTED_PLUGIN_KEYS {
            assert!(
                !unmappable.contains(key),
                "KNIP_UNSUPPORTED_PLUGIN_KEYS entry `{key}` overlaps with KNIP_UNMAPPABLE_FIELDS"
            );
        }
    }

    /// Fallow has no Marko plugin, so the knip `marko` section must land in the
    /// unsupported table rather than claim auto-detection.
    #[test]
    fn marko_is_recognized_as_unsupported() {
        assert!(
            KNIP_UNSUPPORTED_PLUGIN_KEYS.contains(&"marko"),
            "KNIP_UNSUPPORTED_PLUGIN_KEYS should contain `marko`"
        );
        assert!(
            !KNIP_PLUGIN_KEYS.contains(&"marko"),
            "KNIP_PLUGIN_KEYS should not claim to cover `marko`"
        );
    }

    /// The claim `KNIP_PLUGIN_KEYS` makes is that fallow auto-detects the tool,
    /// so every key has to resolve to a plugin the built-in registry actually
    /// registers. Renaming or removing a plugin without moving its knip key
    /// fails here instead of shipping a migration that promises detection
    /// fallow no longer performs.
    #[test]
    fn plugin_keys_resolve_to_builtin_plugins() {
        let builtin = builtin_plugins();
        let aliases: FxHashMap<&str, &str> = KNIP_PLUGIN_KEY_ALIASES.iter().copied().collect();
        for key in KNIP_PLUGIN_KEYS {
            let plugin = aliases.get(key).copied().unwrap_or(key);
            assert!(
                builtin.contains(plugin),
                "KNIP_PLUGIN_KEYS entry `{key}` resolves to plugin `{plugin}`, which the built-in registry does not register; move the key to KNIP_UNSUPPORTED_PLUGIN_KEYS or declare its alias in KNIP_PLUGIN_KEY_ALIASES"
            );
        }
    }

    /// The other half of the same invariant: a key parked as unsupported must
    /// not name a plugin fallow does register, or the migration understates
    /// what fallow covers.
    #[test]
    fn unsupported_plugin_keys_name_no_builtin_plugin() {
        let builtin = builtin_plugins();
        for key in KNIP_UNSUPPORTED_PLUGIN_KEYS {
            assert!(
                !builtin.contains(key),
                "KNIP_UNSUPPORTED_PLUGIN_KEYS entry `{key}` names a registered built-in plugin; move it to KNIP_PLUGIN_KEYS"
            );
        }
    }

    #[test]
    fn plugin_key_aliases_are_used_and_needed() {
        let builtin = builtin_plugins();
        for (key, plugin) in KNIP_PLUGIN_KEY_ALIASES {
            assert!(
                KNIP_PLUGIN_KEYS.contains(key),
                "KNIP_PLUGIN_KEY_ALIASES declares `{key}`, which is not a knip plugin key"
            );
            assert!(
                !builtin.contains(key),
                "KNIP_PLUGIN_KEY_ALIASES entry `{key}` is itself a built-in plugin name; the alias to `{plugin}` is not needed"
            );
        }
    }

    #[test]
    fn plugin_keys_cover_recently_added_fallow_plugins() {
        let expected = [
            "bun",
            "electron-vite",
            "oxlint",
            "panda-css",
            "pnpm",
            "sveltekit",
            "tanstack-router",
            "webdriver-io",
        ];
        for name in expected {
            assert!(
                KNIP_PLUGIN_KEYS.contains(&name),
                "KNIP_PLUGIN_KEYS should contain `{name}`"
            );
        }
    }
}