#[path = "common/mod.rs"]
mod common;
use common::{fixture_path, parse_json, run_fallow, run_fallow_in_root};
#[test]
fn fix_dry_run_exits_0() {
let output = run_fallow(
"fix",
"basic-project",
&["--dry-run", "--format", "json", "--quiet"],
);
assert_eq!(
output.code, 0,
"fix --dry-run should exit 0, stderr: {}",
output.stderr
);
}
#[test]
fn fix_dry_run_json_has_dry_run_flag() {
let output = run_fallow(
"fix",
"basic-project",
&["--dry-run", "--format", "json", "--quiet"],
);
let json = parse_json(&output);
assert_eq!(
json["dry_run"].as_bool(),
Some(true),
"dry_run should be true"
);
}
#[test]
fn fix_dry_run_finds_fixable_items() {
let output = run_fallow(
"fix",
"basic-project",
&["--dry-run", "--format", "json", "--quiet"],
);
let json = parse_json(&output);
let fixes = json["fixes"].as_array().unwrap();
assert!(!fixes.is_empty(), "basic-project should have fixable items");
for fix in fixes {
assert!(fix.get("type").is_some(), "fix should have 'type'");
let has_path = fix.get("path").is_some() || fix.get("package").is_some();
assert!(has_path, "fix should have 'path' or 'package'");
}
}
#[test]
fn fix_dry_run_does_not_have_applied_key() {
let output = run_fallow(
"fix",
"basic-project",
&["--dry-run", "--format", "json", "--quiet"],
);
let json = parse_json(&output);
let fixes = json["fixes"].as_array().unwrap();
for fix in fixes {
assert!(
fix.get("applied").is_none(),
"dry-run fixes should not have 'applied' key"
);
}
}
#[test]
fn fix_removes_unused_exported_enum_declaration() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"enum-fix","main":"src/index.ts"}"#,
)
.unwrap();
std::fs::write(root.join("src/index.ts"), "import './enum';\n").unwrap();
std::fs::write(
root.join("src/enum.ts"),
"export enum MyEnum {\n A,\n B,\n}\n",
)
.unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should exit 0, stdout: {}, stderr: {}",
output.stdout, output.stderr
);
assert_eq!(
std::fs::read_to_string(root.join("src/enum.ts")).unwrap(),
"\n"
);
let output = run_fallow_in_root("fix", root, &["--dry-run", "--format", "json", "--quiet"]);
let json = parse_json(&output);
assert!(json["fixes"].as_array().unwrap().is_empty());
}
#[test]
fn fix_folds_imported_enum_with_all_members_unused() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"enum-fold","main":"src/index.ts"}"#,
)
.unwrap();
std::fs::write(
root.join("src/index.ts"),
"import { MyEnum } from './enum';\nconsole.log(typeof MyEnum);\n",
)
.unwrap();
std::fs::write(
root.join("src/enum.ts"),
"export enum MyEnum {\n A,\n B,\n}\n",
)
.unwrap();
let output = run_fallow_in_root("fix", root, &["--dry-run", "--format", "json", "--quiet"]);
let json = parse_json(&output);
let fixes = json["fixes"].as_array().unwrap();
assert_eq!(
fixes.len(),
1,
"fold should collapse the per-member fixes into a single remove_export entry"
);
assert_eq!(fixes[0]["type"], "remove_export");
assert_eq!(fixes[0]["name"], "MyEnum");
let output = run_fallow_in_root("fix", root, &["--yes", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should exit 0, stdout: {}, stderr: {}",
output.stdout, output.stderr
);
let after = std::fs::read_to_string(root.join("src/enum.ts")).unwrap();
assert_eq!(
after, "\n",
"enum.ts should be empty after the fold (single trailing newline)"
);
let output = run_fallow_in_root("fix", root, &["--dry-run", "--format", "json", "--quiet"]);
let json = parse_json(&output);
assert!(
json["fixes"].as_array().unwrap().is_empty(),
"second pass should find nothing more to fix"
);
}
#[test]
fn fix_adds_ignore_exports_config_rules_for_duplicate_exports() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src/one")).unwrap();
std::fs::create_dir_all(root.join("src/two")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"dup-config","main":"src/index.ts"}"#,
)
.unwrap();
std::fs::write(root.join(".fallowrc.json"), "{}\n").unwrap();
std::fs::write(
root.join("src/index.ts"),
"export { Button } from './one';\nexport { Button as Button2 } from './two';\nconsole.log(Button2);\n",
)
.unwrap();
std::fs::write(root.join("src/one/index.ts"), "export const Button = 1;\n").unwrap();
std::fs::write(root.join("src/two/index.ts"), "export const Button = 2;\n").unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should exit 0, stdout: {}, stderr: {}",
output.stdout, output.stderr
);
let json = parse_json(&output);
let fixes = json["fixes"].as_array().unwrap();
let config_fix = fixes
.iter()
.find(|fix| fix["type"] == "add_ignore_exports")
.expect("fix output should include an ignoreExports config edit");
assert_eq!(config_fix["applied"], true);
assert_eq!(config_fix["config_key"], "ignoreExports");
assert_eq!(config_fix["entries"].as_array().unwrap().len(), 2);
let config: serde_json::Value =
serde_json::from_str(&std::fs::read_to_string(root.join(".fallowrc.json")).unwrap())
.unwrap();
let ignore_exports = config["ignoreExports"].as_array().unwrap();
assert_eq!(ignore_exports[0]["file"], "src/one/index.ts");
assert_eq!(ignore_exports[1]["file"], "src/two/index.ts");
let output = run_fallow_in_root(
"dead-code",
root,
&["--duplicate-exports", "--format", "json", "--quiet"],
);
assert_eq!(
output.code, 0,
"post-fix check should pass: {}",
output.stderr
);
let json = parse_json(&output);
assert_eq!(json["summary"]["duplicate_exports"].as_u64(), Some(0));
}
#[test]
fn fix_round_trips_utf8_bom_on_json_config() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src/one")).unwrap();
std::fs::create_dir_all(root.join("src/two")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"bom-config","main":"src/index.ts"}"#,
)
.unwrap();
let bom_input = "\u{FEFF}{\n \"entry\": [\"src/index.ts\"]\n}\n";
std::fs::write(root.join(".fallowrc.json"), bom_input).unwrap();
std::fs::write(
root.join("src/index.ts"),
"export { Button } from './one';\nexport { Button as Button2 } from './two';\nconsole.log(Button2);\n",
)
.unwrap();
std::fs::write(root.join("src/one/index.ts"), "export const Button = 1;\n").unwrap();
std::fs::write(root.join("src/two/index.ts"), "export const Button = 2;\n").unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should succeed on BOM-prefixed config: {}",
output.stderr
);
let written = std::fs::read_to_string(root.join(".fallowrc.json")).unwrap();
assert!(
written.starts_with('\u{FEFF}'),
"BOM stripped from output (got bytes {:?})",
&written.as_bytes()[..written.len().min(8)]
);
let post = run_fallow_in_root(
"dead-code",
root,
&["--duplicate-exports", "--format", "json", "--quiet"],
);
assert_eq!(
post.code, 0,
"post-fix analysis must succeed on BOM-preserved config: {}",
post.stderr
);
let json = parse_json(&post);
assert_eq!(json["summary"]["duplicate_exports"].as_u64(), Some(0));
}
#[cfg(unix)]
#[test]
fn fix_writes_through_symlinked_config() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
let real_dir = root.join("config-source");
std::fs::create_dir_all(&real_dir).unwrap();
std::fs::create_dir_all(root.join("src/one")).unwrap();
std::fs::create_dir_all(root.join("src/two")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"symlink-config","main":"src/index.ts"}"#,
)
.unwrap();
let real_path = real_dir.join(".fallowrc.json");
std::fs::write(&real_path, "{}\n").unwrap();
std::os::unix::fs::symlink(&real_path, root.join(".fallowrc.json")).unwrap();
std::fs::write(
root.join("src/index.ts"),
"export { Button } from './one';\nexport { Button as Button2 } from './two';\nconsole.log(Button2);\n",
)
.unwrap();
std::fs::write(root.join("src/one/index.ts"), "export const Button = 1;\n").unwrap();
std::fs::write(root.join("src/two/index.ts"), "export const Button = 2;\n").unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix on symlinked config should succeed: {}",
output.stderr
);
let meta = std::fs::symlink_metadata(root.join(".fallowrc.json")).unwrap();
assert!(
meta.file_type().is_symlink(),
"symlink was replaced with regular file by atomic_write"
);
let target_content = std::fs::read_to_string(&real_path).unwrap();
assert!(
target_content.contains("\"ignoreExports\""),
"symlink target was not updated, got: {target_content}"
);
}
#[test]
fn fix_without_yes_in_non_tty_exits_2() {
let output = run_fallow("fix", "basic-project", &["--format", "json", "--quiet"]);
assert_eq!(output.code, 2, "fix without --yes in non-TTY should exit 2");
}
#[test]
fn fix_catalog_delete_preceding_comments_config_is_consumed() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("packages/app")).unwrap();
std::fs::write(
root.join(".fallowrc.json"),
r#"{
"fix": {
"catalog": {
"deletePrecedingComments": "always"
}
}
}
"#,
)
.unwrap();
std::fs::write(
root.join("pnpm-workspace.yaml"),
"packages:\n - 'packages/*'\n\ncatalog:\n is-odd: ^1.0.0\n # pinned for issue #360\n is-even: ^1.0.0\n",
)
.unwrap();
std::fs::write(
root.join("packages/app/package.json"),
r#"{
"name": "app",
"version": "0.0.0",
"dependencies": {
"is-odd": "catalog:"
}
}
"#,
)
.unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should exit 0, stdout: {}, stderr: {}",
output.stdout, output.stderr
);
let after = std::fs::read_to_string(root.join("pnpm-workspace.yaml")).unwrap();
assert_eq!(
after,
"packages:\n - 'packages/*'\n\ncatalog:\n is-odd: ^1.0.0\n"
);
let json = parse_json(&output);
let fixes = json["fixes"].as_array().unwrap();
let catalog_fix = fixes
.iter()
.find(|fix| fix["type"] == "remove_catalog_entry")
.expect("fix output should include the catalog entry removal");
assert_eq!(catalog_fix["line"], 6, "line tracks the deletion start");
assert_eq!(
catalog_fix["entry_line"], 7,
"entry_line tracks the original catalog entry position"
);
assert_eq!(catalog_fix["removed_lines"], 2);
}
#[test]
fn fix_catalog_fallow_keep_marker_preserves_block() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("packages/app")).unwrap();
std::fs::write(
root.join(".fallowrc.json"),
r#"{
"fix": {
"catalog": {
"deletePrecedingComments": "always"
}
}
}
"#,
)
.unwrap();
std::fs::write(
root.join("pnpm-workspace.yaml"),
"packages:\n - 'packages/*'\n\ncatalog:\n is-odd: ^1.0.0\n # fallow-keep audit trail\n is-even: ^1.0.0\n",
)
.unwrap();
std::fs::write(
root.join("packages/app/package.json"),
r#"{
"name": "app",
"version": "0.0.0",
"dependencies": {
"is-odd": "catalog:"
}
}
"#,
)
.unwrap();
let output = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix should exit 0, stderr: {}",
output.stderr
);
let after = std::fs::read_to_string(root.join("pnpm-workspace.yaml")).unwrap();
assert_eq!(
after,
"packages:\n - 'packages/*'\n\ncatalog:\n is-odd: ^1.0.0\n # fallow-keep audit trail\n",
"fallow-keep marker must preserve the comment even when the entry is removed under `always`"
);
}
#[test]
fn fix_catalog_issue_335_empties_parent_to_empty_map_not_null() {
let temp = tempfile::tempdir().expect("tempdir");
let root = temp.path().to_path_buf();
let fixture = fixture_path("issue-329-pnpm-catalog");
copy_dir_recursive(&fixture, &root).expect("copy fixture");
let output = run_fallow_in_root("fix", &root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
output.code, 0,
"fix --yes should exit 0, stderr: {}",
output.stderr
);
let workspace_path = root.join("pnpm-workspace.yaml");
let after = std::fs::read_to_string(&workspace_path).expect("read workspace file");
let parsed: serde_yaml_ng::Value =
serde_yaml_ng::from_str(&after).expect("post-fix YAML must parse");
let react17 = parsed
.get("catalogs")
.and_then(|c| c.get("react17"))
.unwrap_or_else(|| panic!("post-fix YAML missing catalogs.react17:\n{after}"));
assert!(
react17
.as_mapping()
.is_some_and(serde_yaml_ng::Mapping::is_empty),
"catalogs.react17 must be an empty mapping `{{}}`, not null. \
Got value: {react17:?}\nFile content:\n{after}"
);
let legacy = parsed
.get("catalogs")
.and_then(|c| c.get("legacy"))
.and_then(serde_yaml_ng::Value::as_mapping)
.expect("catalogs.legacy must remain a mapping");
assert!(
legacy.contains_key(serde_yaml_ng::Value::String("is-odd".to_string())),
"catalogs.legacy must still declare `is-odd`. Got: {legacy:?}"
);
let default_catalog = parsed
.get("catalog")
.and_then(serde_yaml_ng::Value::as_mapping)
.expect("catalog: must remain a mapping");
assert!(
default_catalog.contains_key(serde_yaml_ng::Value::String("react".to_string())),
"default catalog must still declare `react` (it has consumers). Got: {default_catalog:?}"
);
let json = parse_json(&output);
assert_eq!(
json["skipped"].as_u64(),
Some(1),
"fixture has one hardcoded-pkg skip; envelope must report skipped: 1, got: {}",
json["skipped"]
);
}
#[test]
fn fix_json_envelope_carries_skipped_content_changed_count() {
let output = run_fallow(
"fix",
"basic-project",
&["--dry-run", "--format", "json", "--quiet"],
);
let json = parse_json(&output);
assert!(
json.get("skipped_content_changed").is_some(),
"fix envelope must include `skipped_content_changed` field: {}",
output.stdout,
);
assert_eq!(
json["skipped_content_changed"].as_u64(),
Some(0),
"no files should be skipped on a clean dry-run",
);
}
#[test]
fn fix_round_trip_clears_targeted_findings() {
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"round-trip","main":"src/index.ts"}"#,
)
.unwrap();
std::fs::write(
root.join("src/index.ts"),
"import { kept } from './utils';\nconsole.log(kept);\n",
)
.unwrap();
std::fs::write(
root.join("src/utils.ts"),
"export const kept = 1;\nexport const stale = 2;\nexport const orphan = 3;\n",
)
.unwrap();
let fix = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
assert_eq!(
fix.code, 0,
"fix should exit 0 on a clean run; stderr: {}",
fix.stderr
);
let fix_json = parse_json(&fix);
let total_fixed = fix_json["total_fixed"].as_u64().unwrap_or(0);
assert!(total_fixed >= 2, "fix should remove both stale exports");
let check = run_fallow_in_root("check", root, &["--format", "json", "--quiet"]);
let check_json = parse_json(&check);
let unused_exports = check_json["unused_exports"].as_array().map_or(0, Vec::len);
assert_eq!(
unused_exports, 0,
"fixed exports must not reappear; check output: {}",
check.stdout
);
}
#[cfg(unix)]
#[test]
fn fix_batch_aborts_when_a_target_directory_is_read_only() {
use std::os::unix::fs::PermissionsExt;
let dir = tempfile::tempdir().unwrap();
let root = dir.path();
std::fs::create_dir_all(root.join("src/sealed")).unwrap();
std::fs::write(
root.join("package.json"),
r#"{"name":"batch-atomic","main":"src/index.ts"}"#,
)
.unwrap();
let entry = "import { kept } from './open/utils';\nimport { also } from './sealed/locked';\n\
console.log(kept, also);\n";
std::fs::create_dir_all(root.join("src/open")).unwrap();
std::fs::write(root.join("src/index.ts"), entry).unwrap();
let open_original = "export const kept = 1;\nexport const stale = 2;\n";
std::fs::write(root.join("src/open/utils.ts"), open_original).unwrap();
let sealed_original = "export const also = 1;\nexport const sealed_stale = 2;\n";
std::fs::write(root.join("src/sealed/locked.ts"), sealed_original).unwrap();
let sealed_dir = root.join("src/sealed");
let mut perms = std::fs::metadata(&sealed_dir).unwrap().permissions();
perms.set_mode(0o555);
std::fs::set_permissions(&sealed_dir, perms).unwrap();
let fix = run_fallow_in_root("fix", root, &["--yes", "--format", "json", "--quiet"]);
let mut restore = std::fs::metadata(&sealed_dir).unwrap().permissions();
restore.set_mode(0o755);
std::fs::set_permissions(&sealed_dir, restore).unwrap();
assert_eq!(
fix.code, 2,
"batch commit failure must surface as exit 2; stdout: {} stderr: {}",
fix.stdout, fix.stderr,
);
let post_open = std::fs::read_to_string(root.join("src/open/utils.ts")).unwrap();
assert_eq!(
post_open, open_original,
"healthy file must be untouched when a sibling file's stage failed",
);
let post_sealed = std::fs::read_to_string(root.join("src/sealed/locked.ts")).unwrap();
assert_eq!(
post_sealed, sealed_original,
"sealed file must be untouched (stage couldn't even land its temp)",
);
}
fn copy_dir_recursive(src: &std::path::Path, dst: &std::path::Path) -> std::io::Result<()> {
std::fs::create_dir_all(dst)?;
for entry in std::fs::read_dir(src)? {
let entry = entry?;
let ty = entry.file_type()?;
let src_path = entry.path();
let dst_path = dst.join(entry.file_name());
if ty.is_dir() {
copy_dir_recursive(&src_path, &dst_path)?;
} else {
std::fs::copy(&src_path, &dst_path)?;
}
}
Ok(())
}