fakecloud-core 0.49.0

Core service traits and dispatch for FakeCloud
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
/// Offset-based pagination helper for AWS list operations.
///
/// Parses `next_token` as a numeric offset (defaulting to 0 if `None` or unparseable),
/// slices `items` starting at that offset, and returns at most `max_results` items
/// along with an optional next token for the following page.
///
/// Prefer [`paginate_checked`] for client-facing list ops: this variant treats a
/// malformed `next_token` as offset 0, which can drive an infinite client
/// pagination loop. It remains for callers whose service model declares no
/// invalid-token error (returning one would be an undeclared error).
#[must_use]
pub fn paginate<T: Clone>(
    items: &[T],
    next_token: Option<&str>,
    max_results: usize,
) -> (Vec<T>, Option<String>) {
    if max_results == 0 {
        return (Vec::new(), None);
    }
    let offset: usize = next_token.and_then(|s| s.parse().ok()).unwrap_or(0);
    let page = if offset < items.len() {
        &items[offset..]
    } else {
        &[][..]
    };
    let has_more = page.len() > max_results;
    let result: Vec<T> = page.iter().take(max_results).cloned().collect();
    let token = if has_more {
        Some((offset + max_results).to_string())
    } else {
        None
    };
    (result, token)
}

/// Error from [`paginate_checked`]: `next_token` was present but is not a valid
/// offset token (not produced by a prior page of the same list op). AWS rejects
/// such tokens with `InvalidNextToken` (or a service-specific equivalent);
/// callers map this to their wire error (bug-audit 2026-05-28, 1.7).
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct InvalidNextToken;

/// Strict variant of [`paginate`]: a `next_token` that is present but does not
/// parse as a non-negative offset is rejected with [`InvalidNextToken`] instead
/// of being silently treated as offset 0 (which can drive an infinite client
/// pagination loop). `None` still means "first page".
pub fn paginate_checked<T: Clone>(
    items: &[T],
    next_token: Option<&str>,
    max_results: usize,
) -> Result<(Vec<T>, Option<String>), InvalidNextToken> {
    let offset: usize = match next_token {
        None => 0,
        Some(tok) => tok.parse().map_err(|_| InvalidNextToken)?,
    };
    if max_results == 0 {
        return Ok((Vec::new(), None));
    }
    let page = if offset < items.len() {
        &items[offset..]
    } else {
        &[][..]
    };
    let has_more = page.len() > max_results;
    let result: Vec<T> = page.iter().take(max_results).cloned().collect();
    let token = if has_more {
        Some((offset + max_results).to_string())
    } else {
        None
    };
    Ok((result, token))
}

/// Parse a client-supplied offset token (as minted by [`paginate`] /
/// [`paginate_checked`] / [`page_json_response`]). Absent or empty is offset 0.
pub fn parse_offset_token(token: Option<&str>) -> Result<usize, InvalidNextToken> {
    match token.filter(|t| !t.is_empty()) {
        None => Ok(0),
        Some(t) => t.parse().map_err(|_| InvalidNextToken),
    }
}

/// Page a successful JSON list response in place: the array at `items` is
/// sliced to `[start, start + size)` (`size` of `None` keeps everything from
/// `start`), and `token_key` is set to the offset token of the next page when
/// items remain, or removed when none do (AWS omits an exhausted token rather
/// than sending it empty). Responses that are not JSON objects with an array
/// at `items` are returned unchanged.
///
/// This lets a handler render its full, stably ordered listing and a service
/// apply `MaxResults` / `NextToken` uniformly at its dispatch boundary.
pub fn page_json_response(
    resp: crate::service::AwsResponse,
    items: &str,
    token_key: &str,
    start: usize,
    size: Option<usize>,
) -> crate::service::AwsResponse {
    use crate::service::ResponseBody;
    if !resp.status.is_success() {
        return resp;
    }
    let ResponseBody::Bytes(bytes) = &resp.body else {
        return resp;
    };
    let Ok(mut value) = serde_json::from_slice::<serde_json::Value>(bytes) else {
        return resp;
    };
    let Some(obj) = value.as_object_mut() else {
        return resp;
    };
    let Some(list) = obj.get_mut(items).and_then(|v| v.as_array_mut()) else {
        return resp;
    };
    let total = list.len();
    let start = start.min(total);
    let end = size.map_or(total, |n| start.saturating_add(n).min(total));
    let page: Vec<serde_json::Value> = list.drain(start..end).collect();
    *list = page;
    if end < total {
        obj.insert(
            token_key.to_string(),
            serde_json::Value::String(end.to_string()),
        );
    } else {
        obj.remove(token_key);
    }
    crate::service::AwsResponse {
        body: ResponseBody::Bytes(bytes::Bytes::from(
            serde_json::to_vec(&value).expect("serde_json::Value serialization is infallible"),
        )),
        ..resp
    }
}

/// Where a JSON-protocol paging input travels on the wire.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum PageLoc {
    /// An `@httpQuery` parameter.
    Query(&'static str),
    /// A top-level JSON body member.
    Body(&'static str),
}

/// One paginated JSON-protocol operation, as generated from its Smithy model
/// by `scripts/generate-json-pagination-tables.py`.
#[derive(Clone, Copy, Debug)]
pub struct JsonPagedOp {
    pub action: &'static str,
    /// The input page token.
    pub token: PageLoc,
    /// The input page size, if the operation models one.
    pub size: Option<PageLoc>,
    /// The output list a page slices (its JSON member name).
    pub items: &'static str,
    /// The output member carrying the next page's token (JSON name).
    pub next_token: &'static str,
    /// The output token is `@required`: the last page sends it empty rather
    /// than omitting it.
    pub next_token_required: bool,
    /// The error code the operation declares for a token it did not mint
    /// (always an HTTP 400). `None` when it declares none, in which case an
    /// unrecognised token starts from the top rather than returning an
    /// undeclared error.
    pub bad_token: Option<&'static str>,
}

/// A validated page request for a [`JsonPagedOp`].
#[derive(Clone, Copy, Debug)]
pub struct JsonPage {
    op: &'static JsonPagedOp,
    start: usize,
    size: Option<usize>,
}

fn read_page_input(
    req: &crate::service::AwsRequest,
    body: &serde_json::Value,
    loc: PageLoc,
) -> Option<String> {
    match loc {
        PageLoc::Query(name) => req.query_params.get(name).cloned(),
        PageLoc::Body(name) => match body.get(name)? {
            serde_json::Value::String(s) => Some(s.clone()),
            serde_json::Value::Number(n) => Some(n.to_string()),
            _ => None,
        },
    }
}

/// Validate a request to one of `ops` before its handler runs: a token the
/// service did not mint is rejected with the operation's declared error.
/// Returns the window to slice the handler's listing to, or `None` when the
/// operation is not paginated or the request asks for everything. A page size
/// of 0 (the models' default) means "the service default", here the whole
/// listing.
pub fn validate_json_page(
    ops: &'static [JsonPagedOp],
    action: &str,
    req: &crate::service::AwsRequest,
) -> Result<Option<JsonPage>, crate::service::AwsServiceError> {
    let Some(op) = ops.iter().find(|o| o.action == action) else {
        return Ok(None);
    };
    let body: serde_json::Value = if req.body.is_empty() {
        serde_json::Value::Null
    } else {
        serde_json::from_slice(&req.body).unwrap_or(serde_json::Value::Null)
    };
    let token = read_page_input(req, &body, op.token);
    let start = match (parse_offset_token(token.as_deref()), op.bad_token) {
        (Ok(n), _) => n,
        (Err(_), Some(code)) => {
            return Err(crate::service::AwsServiceError::aws_error(
                http::StatusCode::BAD_REQUEST,
                code,
                format!("Invalid pagination token: {}", token.unwrap_or_default()),
            ))
        }
        (Err(_), None) => 0,
    };
    let size = op
        .size
        .and_then(|loc| read_page_input(req, &body, loc))
        .and_then(|v| v.parse::<usize>().ok())
        .filter(|n| *n > 0);
    if start == 0 && size.is_none() {
        return Ok(None);
    }
    Ok(Some(JsonPage { op, start, size }))
}

/// Slice a handler's full listing to `page` (see [`page_json_response`]),
/// keeping a `@required` output token present (empty) on the last page.
pub fn apply_json_page(
    resp: crate::service::AwsResponse,
    page: JsonPage,
) -> crate::service::AwsResponse {
    let op = page.op;
    let paged = page_json_response(resp, op.items, op.next_token, page.start, page.size);
    if !op.next_token_required {
        return paged;
    }
    let crate::service::ResponseBody::Bytes(bytes) = &paged.body else {
        return paged;
    };
    let Ok(mut v) = serde_json::from_slice::<serde_json::Value>(bytes) else {
        return paged;
    };
    match v.as_object_mut() {
        Some(obj) if !obj.contains_key(op.next_token) => {
            obj.insert(
                op.next_token.to_string(),
                serde_json::Value::String(String::new()),
            );
            crate::service::AwsResponse::json_value(paged.status, v)
        }
        _ => paged,
    }
}

/// The operations in a Smithy model (`aws-models/<svc>.json`, parsed) whose
/// input carries a page token (`NextToken` / `nextToken` / `position`) and
/// whose output returns one, sorted. Services check their generated
/// [`JsonPagedOp`] tables against this so a model refresh that adds a
/// paginated operation fails a test until the table is regenerated.
pub fn model_paginated_actions(model: &serde_json::Value) -> Vec<String> {
    const TOKENS: [&str; 3] = ["NextToken", "nextToken", "position"];
    let Some(shapes) = model["shapes"].as_object() else {
        return Vec::new();
    };
    let members = |target: &serde_json::Value| {
        target
            .as_str()
            .and_then(|t| shapes.get(t))
            .map(|s| s["members"].clone())
            .unwrap_or_default()
    };
    let mut out: Vec<String> = shapes
        .iter()
        .filter(|(_, s)| s["type"] == "operation")
        .filter(|(_, s)| {
            let input = members(&s["input"]["target"]);
            let output = members(&s["output"]["target"]);
            TOKENS.iter().any(|t| input.get(*t).is_some())
                && TOKENS.iter().any(|t| output.get(*t).is_some())
        })
        .filter_map(|(id, _)| id.rsplit('#').next().map(str::to_string))
        .collect();
    out.sort_unstable();
    out
}

#[cfg(test)]
mod tests {
    use super::*;

    fn json_body(resp: &crate::service::AwsResponse) -> serde_json::Value {
        match &resp.body {
            crate::service::ResponseBody::Bytes(b) => serde_json::from_slice(b).unwrap(),
            _ => panic!("not bytes"),
        }
    }

    #[test]
    fn page_json_response_slices_and_sets_or_clears_the_token() {
        let full = || {
            crate::service::AwsResponse::ok_json(
                serde_json::json!({"Things": [0, 1, 2, 3, 4], "NextToken": ""}),
            )
        };
        let p1 = json_body(&page_json_response(
            full(),
            "Things",
            "NextToken",
            0,
            Some(2),
        ));
        assert_eq!(p1["Things"], serde_json::json!([0, 1]));
        assert_eq!(p1["NextToken"], "2");
        let p3 = json_body(&page_json_response(
            full(),
            "Things",
            "NextToken",
            4,
            Some(2),
        ));
        assert_eq!(p3["Things"], serde_json::json!([4]));
        assert!(p3.get("NextToken").is_none(), "{p3}");
        let all = json_body(&page_json_response(full(), "Things", "NextToken", 0, None));
        assert_eq!(all["Things"].as_array().unwrap().len(), 5);
        assert!(all.get("NextToken").is_none());
        // A response without the list is left alone.
        let other = json_body(&page_json_response(
            crate::service::AwsResponse::ok_json(serde_json::json!({"X": 1})),
            "Things",
            "NextToken",
            0,
            Some(1),
        ));
        assert_eq!(other, serde_json::json!({"X": 1}));
    }

    fn req_with(query: &[(&str, &str)], body: serde_json::Value) -> crate::service::AwsRequest {
        crate::service::AwsRequest {
            service: "svc".into(),
            action: "ListThings".into(),
            region: "us-east-1".into(),
            account_id: "000000000000".into(),
            request_id: "rid".into(),
            headers: http::HeaderMap::new(),
            query_params: query
                .iter()
                .map(|(k, v)| (k.to_string(), v.to_string()))
                .collect(),
            body: bytes::Bytes::from(serde_json::to_vec(&body).unwrap()),
            body_stream: parking_lot::Mutex::new(None),
            path_segments: Vec::new(),
            raw_path: "/".into(),
            raw_query: String::new(),
            method: http::Method::GET,
            is_query_protocol: false,
            access_key_id: None,
            principal: None,
        }
    }

    static OPS: [JsonPagedOp; 2] = [
        JsonPagedOp {
            action: "ListThings",
            token: PageLoc::Query("nextToken"),
            size: Some(PageLoc::Query("maxResults")),
            items: "things",
            next_token: "nextToken",
            next_token_required: false,
            bad_token: Some("BadRequestException"),
        },
        JsonPagedOp {
            action: "DescribeThings",
            token: PageLoc::Body("NextToken"),
            size: Some(PageLoc::Body("MaxResults")),
            items: "Things",
            next_token: "NextToken",
            next_token_required: true,
            bad_token: None,
        },
    ];

    #[test]
    fn json_pages_validate_tokens_and_slice() {
        let full =
            |key: &str| crate::service::AwsResponse::ok_json(serde_json::json!({ key: [0, 1, 2] }));
        // Query-carried token + size; a foreign token is the declared error.
        let page = validate_json_page(
            &OPS,
            "ListThings",
            &req_with(&[("maxResults", "2")], serde_json::json!({})),
        )
        .unwrap()
        .unwrap();
        let p1 = json_body(&apply_json_page(full("things"), page));
        assert_eq!(p1["things"], serde_json::json!([0, 1]));
        assert_eq!(p1["nextToken"], "2");
        let err = validate_json_page(
            &OPS,
            "ListThings",
            &req_with(&[("nextToken", "x")], serde_json::json!({})),
        )
        .unwrap_err();
        assert_eq!(err.code(), "BadRequestException");
        // Unpaginated op or "everything" requests are left alone.
        assert!(
            validate_json_page(&OPS, "Other", &req_with(&[], serde_json::json!({})))
                .unwrap()
                .is_none()
        );
        assert!(
            validate_json_page(&OPS, "ListThings", &req_with(&[], serde_json::json!({})))
                .unwrap()
                .is_none()
        );

        // Body-carried; no declared token error means a foreign token starts
        // over; a required token stays (empty) on the last page.
        let page = validate_json_page(
            &OPS,
            "DescribeThings",
            &req_with(
                &[],
                serde_json::json!({"MaxResults": 5, "NextToken": "junk"}),
            ),
        )
        .unwrap()
        .unwrap();
        let last = json_body(&apply_json_page(full("Things"), page));
        assert_eq!(last["Things"], serde_json::json!([0, 1, 2]));
        assert_eq!(last["NextToken"], "");
    }

    #[test]
    fn model_paginated_actions_needs_token_in_and_out() {
        let model = serde_json::json!({"shapes": {
            "s#A": {"type": "operation", "input": {"target": "s#AIn"}, "output": {"target": "s#AOut"}},
            "s#AIn": {"type": "structure", "members": {"NextToken": {}}},
            "s#AOut": {"type": "structure", "members": {"NextToken": {}, "Items": {}}},
            "s#B": {"type": "operation", "input": {"target": "s#BIn"}, "output": {"target": "s#BOut"}},
            "s#BIn": {"type": "structure", "members": {"nextToken": {}}},
            "s#BOut": {"type": "structure", "members": {}}
        }});
        assert_eq!(model_paginated_actions(&model), vec!["A".to_string()]);
    }

    #[test]
    fn parse_offset_token_rejects_non_offsets() {
        assert_eq!(parse_offset_token(None), Ok(0));
        assert_eq!(parse_offset_token(Some("")), Ok(0));
        assert_eq!(parse_offset_token(Some("7")), Ok(7));
        assert_eq!(parse_offset_token(Some("abc")), Err(InvalidNextToken));
    }

    #[test]
    fn first_page() {
        let items: Vec<i32> = (0..10).collect();
        let (page, token) = paginate(&items, None, 3);
        assert_eq!(page, vec![0, 1, 2]);
        assert_eq!(token, Some("3".to_string()));
    }

    #[test]
    fn middle_page() {
        let items: Vec<i32> = (0..10).collect();
        let (page, token) = paginate(&items, Some("3"), 3);
        assert_eq!(page, vec![3, 4, 5]);
        assert_eq!(token, Some("6".to_string()));
    }

    #[test]
    fn last_page() {
        let items: Vec<i32> = (0..10).collect();
        let (page, token) = paginate(&items, Some("9"), 3);
        assert_eq!(page, vec![9]);
        assert_eq!(token, None);
    }

    #[test]
    fn exact_page_boundary() {
        let items: Vec<i32> = (0..6).collect();
        let (page, token) = paginate(&items, Some("3"), 3);
        assert_eq!(page, vec![3, 4, 5]);
        assert_eq!(token, None);
    }

    #[test]
    fn offset_beyond_items() {
        let items: Vec<i32> = (0..3).collect();
        let (page, token) = paginate(&items, Some("100"), 3);
        assert!(page.is_empty());
        assert_eq!(token, None);
    }

    #[test]
    fn invalid_token_defaults_to_zero() {
        let items: Vec<i32> = (0..5).collect();
        let (page, token) = paginate(&items, Some("not_a_number"), 3);
        assert_eq!(page, vec![0, 1, 2]);
        assert_eq!(token, Some("3".to_string()));
    }

    #[test]
    fn zero_max_results_returns_empty_page_without_token() {
        // AWS list ops reject MaxResults=0 at the validation layer; if the helper
        // ever sees zero it returns an empty page with no continuation token so
        // callers can't accidentally paginate forever on a non-advancing offset.
        let items: Vec<i32> = (0..5).collect();
        let (page, token) = paginate(&items, None, 0);
        assert!(page.is_empty());
        assert_eq!(token, None);
    }

    #[test]
    fn empty_items() {
        let items: Vec<i32> = vec![];
        let (page, token) = paginate(&items, None, 10);
        assert!(page.is_empty());
        assert_eq!(token, None);
    }

    // bug-audit 2026-05-28, 1.7: paginate_checked rejects a malformed next_token
    // instead of silently treating it as offset 0.
    #[test]
    fn checked_none_is_first_page() {
        let items: Vec<i32> = (0..5).collect();
        let (page, token) = paginate_checked(&items, None, 3).unwrap();
        assert_eq!(page, vec![0, 1, 2]);
        assert_eq!(token, Some("3".to_string()));
    }

    #[test]
    fn checked_valid_token_advances() {
        let items: Vec<i32> = (0..5).collect();
        let (page, token) = paginate_checked(&items, Some("3"), 3).unwrap();
        assert_eq!(page, vec![3, 4]);
        assert_eq!(token, None);
    }

    #[test]
    fn checked_garbage_token_is_rejected() {
        let items: Vec<i32> = (0..5).collect();
        assert_eq!(
            paginate_checked(&items, Some("not_a_number"), 3),
            Err(InvalidNextToken)
        );
    }

    #[test]
    fn checked_negative_token_is_rejected() {
        let items: Vec<i32> = (0..5).collect();
        assert_eq!(
            paginate_checked(&items, Some("-1"), 3),
            Err(InvalidNextToken)
        );
    }
}