ez-ffmpeg 0.12.0

A safe and ergonomic Rust interface for FFmpeg integration, designed for ease of use.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
use crate::core::filter::frame_filter_context::FrameFilterContext;
use crate::filter::frame_filter::FrameFilter;
use crate::wgpu_filter::shaders;
use crate::wgpu_filter::wgpu_frame_filter::WgpuFrameFilter;
use ffmpeg_next::Frame;
use ffmpeg_sys_next::{av_frame_get_buffer, AVPixelFormat};
use std::collections::HashMap;

fn make_ctx(map: &mut HashMap<String, Box<dyn std::any::Any + Send>>) -> FrameFilterContext<'_> {
    FrameFilterContext::new("wgpu_test", map)
}

/// Builds a planar YUV frame; luma is either a constant or a deterministic
/// gradient, chroma is neutral (128). Neutral chroma is deliberate: saturated
/// chroma at extreme luma goes out of the RGB gamut and clamps (physically
/// correct but not invertible), which would mask grid-alignment bugs behind
/// gamut error.
fn make_planar_frame(w: i32, h: i32, fmt: AVPixelFormat, const_luma: Option<u8>, pts: i64) -> Frame {
    let (sub_x, sub_y) = match fmt {
        AVPixelFormat::AV_PIX_FMT_YUV420P | AVPixelFormat::AV_PIX_FMT_YUVJ420P => (2usize, 2usize),
        AVPixelFormat::AV_PIX_FMT_YUV422P => (2, 1),
        AVPixelFormat::AV_PIX_FMT_YUV444P => (1, 1),
        other => panic!("unsupported test format {other:?}"),
    };
    unsafe {
        let mut frame = Frame::empty();
        let p = frame.as_mut_ptr();
        (*p).width = w;
        (*p).height = h;
        (*p).format = fmt as i32;
        assert!(av_frame_get_buffer(p, 1) >= 0);
        (*p).pts = pts;
        (*p).time_base = ffmpeg_sys_next::AVRational { num: 1, den: 30 };

        let ls_y = (*p).linesize[0] as usize;
        let y = std::slice::from_raw_parts_mut((*p).data[0], ls_y * h as usize);
        for row in 0..h as usize {
            for col in 0..w as usize {
                y[row * ls_y + col] =
                    const_luma.unwrap_or(((16 + row * 2 + col) % 220 + 16) as u8);
            }
        }
        let cw = (w as usize).div_ceil(sub_x);
        let ch = (h as usize).div_ceil(sub_y);
        for plane in 1..=2 {
            let ls = (*p).linesize[plane] as usize;
            let data = std::slice::from_raw_parts_mut((*p).data[plane], ls * ch);
            for row in 0..ch {
                for col in 0..cw {
                    data[row * ls + col] = 128;
                }
            }
        }
        frame
    }
}

fn make_yuv420p_frame(w: i32, h: i32) -> Frame {
    make_planar_frame(w, h, AVPixelFormat::AV_PIX_FMT_YUV420P, None, 0)
}

/// A props-only frame like the EOF timestamp marker decoders send through
/// pipelines: valid AVFrame, no data buffers.
fn make_marker_frame(pts: i64) -> Frame {
    unsafe {
        let mut frame = Frame::empty();
        (*frame.as_mut_ptr()).pts = pts;
        frame
    }
}

fn init_filter(filter: &mut WgpuFrameFilter) -> bool {
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    match filter.init(&ctx) {
        Ok(()) => true,
        Err(e) if e.contains("adapter") || e.contains("device") => {
            eprintln!("skipping wgpu test (no GPU): {e}");
            false
        }
        Err(e) => panic!("init failed: {e}"),
    }
}

/// Emulates the pipeline driver: `filter_frame` per input, `request_frame`
/// polling after each input and until all expected outputs have drained.
fn drive(filter: &mut WgpuFrameFilter, inputs: Vec<Frame>, expected: usize) -> Vec<Frame> {
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    let mut out = Vec::new();
    for frame in inputs {
        if let Some(f) = filter.filter_frame(frame, &ctx).expect("filter_frame") {
            out.push(f);
        }
        while let Some(f) = filter.request_frame(&ctx).expect("request_frame") {
            out.push(f);
        }
    }
    for _ in 0..2000 {
        while let Some(f) = filter.request_frame(&ctx).expect("request_frame") {
            out.push(f);
        }
        if out.len() >= expected {
            break;
        }
        std::thread::sleep(std::time::Duration::from_millis(1));
    }
    assert_eq!(out.len(), expected, "expected {expected} outputs");
    out
}

fn max_luma_diff(out: &Frame, expected: &Frame, w: usize, h: usize) -> i32 {
    unsafe {
        let o = out.as_ptr();
        let e = expected.as_ptr();
        let ls_o = (*o).linesize[0] as usize;
        let ls_e = (*e).linesize[0] as usize;
        let od = std::slice::from_raw_parts((*o).data[0], ls_o * h);
        let ed = std::slice::from_raw_parts((*e).data[0], ls_e * h);
        let mut max_diff = 0i32;
        for row in 0..h {
            for col in 0..w {
                let d = (od[row * ls_o + col] as i32 - ed[row * ls_e + col] as i32).abs();
                max_diff = max_diff.max(d);
            }
        }
        max_diff
    }
}

#[test]
fn test_identity_roundtrip() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let (w, h) = (322, 182); // odd-ish sizes exercise stride/tail paths
    let expected = make_yuv420p_frame(w, h);
    let out = drive(&mut filter, vec![make_yuv420p_frame(w, h)], 1)
        .pop()
        .unwrap();
    unsafe {
        assert_eq!((*out.as_ptr()).width, w);
        assert_eq!((*out.as_ptr()).height, h);
        assert_eq!((*out.as_ptr()).format, AVPixelFormat::AV_PIX_FMT_YUV420P as i32);
    }
    // YUV -> RGB -> YUV roundtrip through 8-bit RGBA allows small error.
    let diff = max_luma_diff(&out, &expected, w as usize, h as usize);
    assert!(diff <= 3, "luma max diff too large: {diff}");
}

#[test]
fn test_yuv444p_and_yuv422p_roundtrip() {
    for fmt in [
        AVPixelFormat::AV_PIX_FMT_YUV444P,
        AVPixelFormat::AV_PIX_FMT_YUV422P,
    ] {
        let mut filter = WgpuFrameFilter::new_identity().unwrap();
        if !init_filter(&mut filter) {
            return;
        }
        let (w, h) = (321, 181);
        let expected = make_planar_frame(w, h, fmt, None, 0);
        let out = drive(&mut filter, vec![make_planar_frame(w, h, fmt, None, 0)], 1)
            .pop()
            .unwrap();
        unsafe {
            assert_eq!((*out.as_ptr()).width, w);
            assert_eq!((*out.as_ptr()).height, h);
            // 4:2:2/4:4:4 inputs are chroma-downsampled to 4:2:0 on output.
            assert_eq!((*out.as_ptr()).format, AVPixelFormat::AV_PIX_FMT_YUV420P as i32);
        }
        let diff = max_luma_diff(&out, &expected, w as usize, h as usize);
        assert!(diff <= 3, "{fmt:?} luma max diff too large: {diff}");
    }
}

#[test]
fn test_async_ordering_and_eof_flush() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap(); // 2 in flight
    if !init_filter(&mut filter) {
        return;
    }
    let lumas = [40u8, 90, 140, 190];
    let mut inputs: Vec<Frame> = lumas
        .iter()
        .enumerate()
        .map(|(i, &l)| make_planar_frame(64, 48, AVPixelFormat::AV_PIX_FMT_YUV420P, Some(l), i as i64))
        .collect();
    // EOF marker arrives while GPU frames are still in flight; it must leave
    // last, after every real frame, in arrival order.
    inputs.push(make_marker_frame(100));

    let out = drive(&mut filter, inputs, 5);
    unsafe {
        for (i, frame) in out.iter().enumerate().take(4) {
            let p = frame.as_ptr();
            assert_eq!((*p).pts, i as i64, "output order broken at {i}");
            let luma = *(*p).data[0];
            let want = lumas[i] as i32;
            assert!(
                (luma as i32 - want).abs() <= 3,
                "frame {i}: luma {luma}, want ~{want}"
            );
        }
        let marker = out[4].as_ptr();
        assert_eq!((*marker).pts, 100);
        assert!((*marker).data[0].is_null(), "marker must stay props-only");
    }
}

/// Regression: the scheduler's pipeline loop (`run_pipeline`) stops after
/// its first request_frame sweep that yields nothing once the source has
/// disconnected, then `uninit` discards whatever is still pending. The EOF
/// marker is the last thing a source sends, so `filter_frame(marker)` must
/// resolve every in-flight readback before returning — unlike `drive`,
/// this driver grants the filter no grace polling at all.
#[test]
fn test_eof_marker_drains_in_flight_without_polling() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap(); // 2 in flight
    if !init_filter(&mut filter) {
        return;
    }
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    let mut out = Vec::new();
    for i in 0..3i64 {
        let frame = make_planar_frame(
            1280,
            720,
            AVPixelFormat::AV_PIX_FMT_YUV420P,
            Some(40 + 40 * i as u8),
            i,
        );
        if let Some(f) = filter.filter_frame(frame, &ctx).expect("filter_frame") {
            out.push(f);
        }
    }
    // The marker is the last send before the source drops its channel.
    if let Some(f) = filter
        .filter_frame(make_marker_frame(100), &ctx)
        .expect("marker filter_frame")
    {
        out.push(f);
    }
    // Exactly one non-blocking sweep, like run_pipeline's final pass.
    while let Some(f) = filter.request_frame(&ctx).expect("request_frame") {
        out.push(f);
    }
    assert_eq!(
        out.len(),
        4,
        "in-flight frames or the EOF marker were dropped at EOF"
    );
    unsafe {
        for (i, frame) in out.iter().enumerate().take(3) {
            assert_eq!((*frame.as_ptr()).pts, i as i64, "order broken at {i}");
        }
        let marker = out[3].as_ptr();
        assert_eq!((*marker).pts, 100);
        assert!((*marker).data[0].is_null(), "marker must stay props-only");
    }
}

#[test]
fn test_size_change_midstream() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let sizes = [(320, 180), (322, 182), (320, 180)];
    let inputs: Vec<Frame> = sizes
        .iter()
        .enumerate()
        .map(|(i, &(w, h))| {
            make_planar_frame(
                w,
                h,
                AVPixelFormat::AV_PIX_FMT_YUV420P,
                Some(60 + 60 * i as u8),
                i as i64,
            )
        })
        .collect();
    let out = drive(&mut filter, inputs, 3);
    unsafe {
        for (i, frame) in out.iter().enumerate() {
            let p = frame.as_ptr();
            assert_eq!((*p).pts, i as i64);
            assert_eq!(((*p).width, (*p).height), sizes[i], "size mismatch at {i}");
            let luma = *(*p).data[0];
            let want = 60 + 60 * i as i32;
            assert!(
                (luma as i32 - want).abs() <= 3,
                "frame {i}: luma {luma}, want ~{want}"
            );
        }
    }
}

#[test]
fn test_frames_in_flight_one_is_synchronous() {
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .frames_in_flight(1)
        .build()
        .unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    for i in 0..2 {
        let out = filter
            .filter_frame(make_yuv420p_frame(160, 90), &ctx)
            .expect("filter_frame");
        assert!(out.is_some(), "sync mode must return its own frame ({i})");
    }
}

#[test]
fn test_oversized_frame_rejected() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    // The device is created with wgpu's default limits, which cap 2D
    // textures at 8192; exceeding that must be a clean Err, not a panic
    // from wgpu's uncaptured-error handler.
    let frame = make_planar_frame(8200, 16, AVPixelFormat::AV_PIX_FMT_YUV420P, Some(60), 0);
    let err = match filter.filter_frame(frame, &ctx) {
        Err(e) => e,
        Ok(_) => panic!("oversized frame must be rejected"),
    };
    assert!(
        err.contains("maximum texture dimension"),
        "unexpected error: {err}"
    );
}

#[test]
fn test_builder_rejects_bad_frames_in_flight() {
    for n in [0usize, 5] {
        let result = WgpuFrameFilter::builder()
            .shader_wgsl(shaders::IDENTITY_FS)
            .frames_in_flight(n)
            .build();
        assert!(result.is_err(), "frames_in_flight({n}) must be rejected");
    }
}

#[test]
fn test_output_resize() {
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .output_size(160, 90)
        .build()
        .unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let out = drive(&mut filter, vec![make_yuv420p_frame(320, 180)], 1)
        .pop()
        .unwrap();
    unsafe {
        assert_eq!((*out.as_ptr()).width, 160);
        assert_eq!((*out.as_ptr()).height, 90);
    }
}

#[test]
fn test_rejects_unsupported_and_hw_formats() {
    let mut filter = WgpuFrameFilter::new_identity().unwrap();
    if !init_filter(&mut filter) {
        return;
    }
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);

    unsafe {
        let mut rgb = Frame::empty();
        let p = rgb.as_mut_ptr();
        (*p).width = 64;
        (*p).height = 64;
        (*p).format = AVPixelFormat::AV_PIX_FMT_RGB24 as i32;
        assert!(av_frame_get_buffer(p, 1) >= 0);
        let err = match filter.filter_frame(rgb, &ctx) {
            Err(e) => e,
            Ok(_) => panic!("RGB24 input must be rejected"),
        };
        assert!(err.contains("format=yuv420p"), "unexpected error: {err}");

        // Allocate as YUV420P (so buf[0] is non-null) and then relabel as a
        // hardware format: hardware frames now take the download path, and
        // this fake frame has no hw_frames_ctx, so the download must fail
        // cleanly without anything dereferencing the misdescribed planes.
        let mut hw = make_yuv420p_frame(64, 64);
        (*hw.as_mut_ptr()).format = AVPixelFormat::AV_PIX_FMT_CUDA as i32;
        let err = match filter.filter_frame(hw, &ctx) {
            Err(e) => e,
            Ok(_) => panic!("a fake hardware frame must fail the download"),
        };
        assert!(
            err.contains("download hardware frame"),
            "unexpected error: {err}"
        );
    }
}

#[test]
fn test_params_handle_size_check() {
    let filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .params(1.0f32)
        .build()
        .unwrap();
    assert!(filter.params_handle::<f32>().is_ok());
    assert!(filter.params_handle::<[f32; 4]>().is_err());
}

#[test]
fn test_params_shader_size_mismatch_fails_at_init() {
    // Shader declares a 32-byte params struct, builder provides 4 bytes
    // (buffer rounded to 16): must be a clean Err at init, not a panic
    // on first submit.
    let shader = r#"
        @group(0) @binding(0) var texture1: texture_2d<f32>;
        @group(0) @binding(1) var sampler1: sampler;
        struct EzUniforms { play_time: f32, width: f32, height: f32, _pad: f32 };
        @group(0) @binding(2) var<uniform> ez: EzUniforms;
        struct BigParams { a: vec4<f32>, b: vec4<f32> };
        @group(1) @binding(0) var<uniform> params: BigParams;
        @fragment
        fn fs_main(@location(0) tex_coord: vec2<f32>) -> @location(0) vec4<f32> {
            return textureSample(texture1, sampler1, tex_coord) + params.a * 0.0;
        }
    "#;
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shader)
        .params(1.0f32)
        .build()
        .unwrap();
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    match filter.init(&ctx) {
        Err(e) if e.contains("adapter") || e.contains("device") => {
            eprintln!("skipping wgpu test (no GPU): {e}");
        }
        Err(e) => assert!(
            e.contains("pipeline") || e.contains("binding"),
            "expected binding-contract diagnostics, got: {e}"
        ),
        Ok(()) => panic!("init must fail when shader params exceed provided buffer"),
    }
}

#[test]
fn test_bad_shader_fails_at_init_with_diagnostics() {
    let mut filter = WgpuFrameFilter::new_simple("not valid wgsl at all").unwrap();
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    match filter.init(&ctx) {
        Err(e) if e.contains("adapter") || e.contains("device") => {
            eprintln!("skipping wgpu test (no GPU): {e}");
        }
        Err(e) => assert!(
            e.contains("shader") || e.contains("Shader") || e.contains("parse"),
            "expected shader diagnostics, got: {e}"
        ),
        Ok(()) => panic!("init must fail for invalid WGSL"),
    }
}

/// Pass-through filter counting every frame it sees; stands in for a
/// downstream filter that must receive drained frames via `run_filters_from`.
struct CountingFilter {
    seen: std::sync::Arc<std::sync::atomic::AtomicUsize>,
}

impl FrameFilter for CountingFilter {
    fn media_type(&self) -> ffmpeg_sys_next::AVMediaType {
        ffmpeg_sys_next::AVMediaType::AVMEDIA_TYPE_VIDEO
    }

    fn filter_frame(
        &mut self,
        frame: Frame,
        _ctx: &FrameFilterContext,
    ) -> Result<Option<Frame>, String> {
        self.seen
            .fetch_add(1, std::sync::atomic::Ordering::Relaxed);
        Ok(Some(frame))
    }
}

/// Emulates `run_pipeline` (`src/core/scheduler/frame_filter_pipeline.rs`)
/// against a real `FramePipeline`: `run_filters` per input, then per-filter
/// `request_frame` polling that feeds `run_filters_from(i + 1, ..)`, and
/// continued polling after the source is exhausted. A downstream filter must
/// see every drained frame exactly once, in arrival order, marker last.
#[test]
fn test_frame_pipeline_driver_semantics() {
    use crate::filter::frame_pipeline::FramePipeline;
    use ffmpeg_sys_next::AVMediaType::AVMEDIA_TYPE_VIDEO;

    fn poll_all(pipeline: &mut FramePipeline, out: &mut Vec<Frame>) {
        for i in 0..pipeline.filter_len() {
            loop {
                match pipeline.request_frame(i).expect("request_frame") {
                    Some(f) => {
                        if let Some(f) =
                            pipeline.run_filters_from(i + 1, f).expect("run_filters_from")
                        {
                            out.push(f);
                        }
                    }
                    None => break,
                }
            }
        }
    }

    let filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .build()
        .expect("builder");
    let seen = std::sync::Arc::new(std::sync::atomic::AtomicUsize::new(0));
    let mut pipeline = FramePipeline::new(AVMEDIA_TYPE_VIDEO, None);
    pipeline.add_filter("wgpu", Box::new(filter));
    pipeline.add_filter(
        "count",
        Box::new(CountingFilter {
            seen: std::sync::Arc::clone(&seen),
        }),
    );
    match pipeline.init_filters() {
        Ok(()) => {}
        Err(e) if e.contains("adapter") || e.contains("device") => {
            eprintln!("skipping wgpu test (no GPU): {e}");
            return;
        }
        Err(e) => panic!("init failed: {e}"),
    }

    let n_real = 4usize;
    let mut inputs: Vec<Frame> = (0..n_real)
        .map(|i| {
            make_planar_frame(
                64,
                48,
                AVPixelFormat::AV_PIX_FMT_YUV420P,
                Some((40 + 40 * i) as u8),
                i as i64,
            )
        })
        .collect();
    inputs.push(make_marker_frame(n_real as i64));
    let expected = n_real + 1;

    let mut out = Vec::new();
    for frame in inputs {
        if let Some(f) = pipeline.run_filters(frame).expect("run_filters") {
            out.push(f);
        }
        poll_all(&mut pipeline, &mut out);
    }
    for _ in 0..2000 {
        poll_all(&mut pipeline, &mut out);
        if out.len() >= expected {
            break;
        }
        std::thread::sleep(std::time::Duration::from_millis(1));
    }
    pipeline.uninit_filters();

    assert_eq!(out.len(), expected, "all frames must drain through the chain");
    for (i, f) in out.iter().enumerate() {
        assert_eq!(unsafe { (*f.as_ptr()).pts }, i as i64, "arrival order");
    }
    // SAFETY: reading a pointer field of a live frame.
    unsafe {
        assert!(
            (*out.last().unwrap().as_ptr()).buf[0].is_null(),
            "marker must exit last and stay props-only"
        );
    }
    assert_eq!(
        seen.load(std::sync::atomic::Ordering::Relaxed),
        expected,
        "downstream filter must see every drained frame"
    );
}

/// A source that ends without any EOF marker (e.g. an upstream abort closes
/// the channel) must not lose real frames: everything already submitted
/// drains through `request_frame` polling alone.
#[test]
fn test_drain_without_marker() {
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .build()
        .expect("builder");
    if !init_filter(&mut filter) {
        return;
    }
    let inputs: Vec<Frame> = (0..4)
        .map(|i| {
            make_planar_frame(
                64,
                48,
                AVPixelFormat::AV_PIX_FMT_YUV420P,
                Some((40 + 40 * i) as u8),
                i as i64,
            )
        })
        .collect();
    let out = drive(&mut filter, inputs, 4);
    for (i, f) in out.iter().enumerate() {
        assert_eq!(unsafe { (*f.as_ptr()).pts }, i as i64, "arrival order");
    }
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    filter.uninit(&ctx);
}

/// Zero-copy readback: output planes point into the mapped staging buffer.
/// Verifies pixel correctness, that dropping frames recycles buffers back to
/// the filter (drained on the next filter_frame), and ordering across many
/// frames with only `frames_in_flight` submissions outstanding.
#[test]
fn test_zero_copy_readback_roundtrip_and_recycle() {
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .zero_copy_readback(true)
        .build()
        .expect("builder");
    if !init_filter(&mut filter) {
        return;
    }

    let (w, h) = (322, 182); // odd-ish sizes exercise stride/tail paths
    let expected = make_yuv420p_frame(w, h);

    let n = 12usize;
    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    let mut seen = 0usize;
    for i in 0..n {
        let mut frame = make_yuv420p_frame(w, h);
        unsafe { (*frame.as_mut_ptr()).pts = i as i64 };
        // Frames are dropped right after checking, exercising the recycle
        // path: later iterations must reuse returned buffers instead of
        // growing GPU memory without bound.
        if let Some(out) = filter.filter_frame(frame, &ctx).expect("filter_frame") {
            assert_eq!(unsafe { (*out.as_ptr()).pts }, seen as i64, "order");
            let diff = max_luma_diff(&out, &expected, w as usize, h as usize);
            assert!(diff <= 3, "luma diff too large at frame {seen}: {diff}");
            seen += 1;
        }
        while let Some(out) = filter.request_frame(&ctx).expect("request_frame") {
            assert_eq!(unsafe { (*out.as_ptr()).pts }, seen as i64, "order");
            seen += 1;
        }
    }
    for _ in 0..2000 {
        while let Some(out) = filter.request_frame(&ctx).expect("request_frame") {
            assert_eq!(unsafe { (*out.as_ptr()).pts }, seen as i64, "order");
            seen += 1;
        }
        if seen >= n {
            break;
        }
        std::thread::sleep(std::time::Duration::from_millis(1));
    }
    assert_eq!(seen, n, "all zero-copy frames must drain");
    filter.uninit(&ctx);
}

/// Zero-copy frames must survive their filter: uninit while a frame is still
/// alive downstream, then read the frame afterwards. The AVBuffer free
/// callback silently drops the buffer when the recycle channel is gone.
#[test]
fn test_zero_copy_frame_outlives_filter() {
    let mut filter = WgpuFrameFilter::builder()
        .shader_wgsl(shaders::IDENTITY_FS)
        .zero_copy_readback(true)
        .frames_in_flight(1)
        .build()
        .expect("builder");
    if !init_filter(&mut filter) {
        return;
    }
    let (w, h) = (64, 48);
    let expected = make_yuv420p_frame(w, h);
    let out = drive(&mut filter, vec![make_yuv420p_frame(w, h)], 1)
        .pop()
        .unwrap();

    let mut map = HashMap::new();
    let ctx = make_ctx(&mut map);
    filter.uninit(&ctx);
    drop(filter);

    // The staging buffer behind `out` must still be mapped and readable.
    let diff = max_luma_diff(&out, &expected, w as usize, h as usize);
    assert!(diff <= 3, "luma diff too large after filter drop: {diff}");
}