exiftool-rs 0.5.0

Read, write, and edit metadata in 93 file formats — a pure Rust reimplementation of ExifTool 13.53 with 100% tag name parity (194/194 test files)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
//! Sigma/Foveon X3F RAW file format reader.
//!
//! Parses X3F files: header (v2.x/v4), extended header, PROP key-value pairs,
//! and embedded JPEG (JpgFromRaw / PreviewImage).
//! Mirrors ExifTool's SigmaRaw.pm.

use crate::error::{Error, Result};
use crate::tag::{Tag, TagGroup, TagId};
use crate::value::Value;

pub fn read_x3f(data: &[u8]) -> Result<Vec<Tag>> {
    if data.len() < 40 {
        return Err(Error::InvalidData("X3F too short".into()));
    }
    if &data[0..4] != b"FOVb" {
        return Err(Error::InvalidData("not an X3F file".into()));
    }

    let mut tags = Vec::new();

    // --- File version (little-endian uint32 at offset 4) ---
    let ver_raw = u32_le(data, 4);
    let ver_major = (ver_raw >> 16) as f64;
    let ver_minor = (ver_raw & 0xffff) as f64;
    let ver_f = ver_major + ver_minor / 10000.0; // for comparisons (2.2 → 2.0002, enough)
    let ver_str = format!("{}.{}", ver_raw >> 16, ver_raw & 0xffff);
    tags.push(mk_tag_str(
        "FileVersion",
        "File Version",
        ver_str,
        "X3F",
        "Main",
        "Image",
    ));

    if ver_raw >> 16 >= 4 {
        // Version 4.x header — different layout
        parse_header4(data, &mut tags);
    } else {
        // Version 2.x header
        parse_header2(data, ver_f, &mut tags);
    }

    // --- Directory pointer: last 4 bytes of file ---
    if data.len() < 4 {
        return Ok(tags);
    }
    let dir_offset = u32_le(data, data.len() - 4) as usize;
    if dir_offset + 12 > data.len() {
        return Ok(tags);
    }

    // --- Directory header: "SECd" + ver(4) + entries(4) ---
    if &data[dir_offset..dir_offset + 4] != b"SECd" {
        return Ok(tags);
    }
    let entries = u32_le(data, dir_offset + 8) as usize;
    if entries == 0 || entries > 100 {
        return Ok(tags);
    }
    let dir_data_start = dir_offset + 12;
    if dir_data_start + entries * 12 > data.len() {
        return Ok(tags);
    }

    // Track if we already found a JpgFromRaw
    let mut found_jpg_from_raw = false;

    // --- Parse each directory entry ---
    for i in 0..entries {
        let pos = dir_data_start + i * 12;
        let sec_offset = u32_le(data, pos) as usize;
        let sec_len = u32_le(data, pos + 4) as usize;
        let tag_bytes = &data[pos + 8..pos + 12];

        if sec_offset + sec_len > data.len() {
            continue;
        }
        let sec_data = &data[sec_offset..sec_offset + sec_len];

        match tag_bytes {
            b"PROP" => {
                parse_properties(sec_data, &mut tags);
            }
            b"IMA2" => {
                if !found_jpg_from_raw {
                    if let Some(img_data) = extract_image_data(sec_data) {
                        // Full-size JPEG with EXIF becomes JpgFromRaw
                        if img_data.starts_with(b"\xff\xd8\xff\xe1") {
                            found_jpg_from_raw = true;
                            // Extract EXIF from embedded JPEG
                            if let Ok(jpeg_tags) = crate::formats::jpeg::read_jpeg(img_data) {
                                tags.extend(jpeg_tags);
                            }
                            // Also store as JpgFromRaw binary tag
                            tags.push(mk_tag_binary(
                                "JpgFromRaw",
                                "Jpg From Raw",
                                img_data.to_vec(),
                                "X3F",
                                "Main",
                                "Preview",
                            ));
                        } else {
                            // Non-full-size preview
                            tags.push(mk_tag_binary(
                                "PreviewImage",
                                "Preview Image",
                                img_data.to_vec(),
                                "X3F",
                                "Main",
                                "Preview",
                            ));
                        }
                    }
                } else {
                    // Additional IMA2 entries become PreviewImage
                    if let Some(img_data) = extract_image_data(sec_data) {
                        tags.push(mk_tag_binary(
                            "PreviewImage",
                            "Preview Image",
                            img_data.to_vec(),
                            "X3F",
                            "Main",
                            "Preview",
                        ));
                    }
                }
            }
            b"IMAG" => {
                if let Some(img_data) = extract_image_data(sec_data) {
                    tags.push(mk_tag_binary(
                        "PreviewImage",
                        "Preview Image",
                        img_data.to_vec(),
                        "X3F",
                        "Main",
                        "Preview",
                    ));
                }
            }
            _ => {}
        }
    }

    Ok(tags)
}

/// Extract image payload from a SECi section (28-byte subsection header + data).
/// Returns image bytes only if it's a JPEG (format 18 = 0x12) full-size preview.
fn extract_image_data(sec_data: &[u8]) -> Option<&[u8]> {
    if sec_data.len() < 28 {
        return None;
    }
    if &sec_data[0..4] != b"SECi" {
        return None;
    }
    // Check: version 2.0 (bytes 4-7 = 00 00 02 00), type 2 (bytes 8-11 = 02 00 00 00),
    // format 0x12=18 (bytes 12-15 = 12 00 00 00) → full-size JPEG preview
    let sec_ver = u16_le(sec_data, 6); // major version
    let img_type = u32_le(sec_data, 8);
    let img_fmt = u32_le(sec_data, 12);

    if sec_ver == 2 && img_type == 2 && img_fmt == 0x12 {
        let payload = &sec_data[28..];
        if !payload.is_empty() {
            return Some(payload);
        }
    }
    None
}

/// Parse a v2.x X3F header.
fn parse_header2(data: &[u8], ver_f: f64, tags: &mut Vec<Tag>) {
    // Determine header length
    // v2.3 → 104 bytes, v2.1/v2.2 → 72 bytes
    let hdr_len = if ver_f >= 2.0003 { 104usize } else { 72usize };
    let has_extended = data.len() >= hdr_len + 160;

    // ImageUniqueID: bytes 8..24 (16 bytes) — hex string
    if data.len() >= 24 {
        let uid = hex_bytes(&data[8..24]);
        tags.push(mk_tag_str(
            "ImageUniqueID",
            "Image Unique ID",
            uid,
            "X3F",
            "Header",
            "Camera",
        ));
    }

    // MarkBits: uint32 at offset 24 (position 6 in int32u array starting at 0)
    if data.len() >= 28 {
        let mark = u32_le(data, 24);
        // Perl: PrintConv => { BITMASK => {} } — with no bits defined, prints "(none)" when 0
        let mark_str = if mark == 0 {
            "(none)".to_string()
        } else {
            mark.to_string()
        };
        tags.push(mk_tag_str(
            "MarkBits",
            "Mark Bits",
            mark_str,
            "X3F",
            "Header",
            "Image",
        ));
    }

    // ImageWidth: uint32 at offset 28
    if data.len() >= 32 {
        let w = u32_le(data, 28);
        tags.push(mk_tag_u32(
            "ImageWidth",
            "Image Width",
            w,
            "X3F",
            "Header",
            "Image",
        ));
    }

    // ImageHeight: uint32 at offset 32
    if data.len() >= 36 {
        let h = u32_le(data, 32);
        tags.push(mk_tag_u32(
            "ImageHeight",
            "Image Height",
            h,
            "X3F",
            "Header",
            "Image",
        ));
    }

    // Rotation: uint32 at offset 36
    if data.len() >= 40 {
        let r = u32_le(data, 36);
        tags.push(mk_tag_u32(
            "Rotation", "Rotation", r, "X3F", "Header", "Image",
        ));
    }

    // WhiteBalance: string[32] at offset 40
    if data.len() >= 72 {
        let wb = read_cstr(&data[40..72]);
        if !wb.is_empty() {
            tags.push(mk_tag_str(
                "WhiteBalance",
                "White Balance",
                wb,
                "X3F",
                "Header",
                "Camera",
            ));
        }
    }

    // SceneCaptureType: string[32] at offset 72 (only in v2.3+, hdrLen=104)
    if hdr_len >= 104 && data.len() >= 104 {
        let sct = read_cstr(&data[72..104]);
        if !sct.is_empty() {
            tags.push(mk_tag_str(
                "SceneCaptureType",
                "Scene Capture Type",
                sct,
                "X3F",
                "Header",
                "Image",
            ));
        }
    }

    // Extended header (v2.1/v2.2/v2.3): follows at hdr_len, is 160 bytes
    // Format: 32 bytes of tag-index array, then up to 32 float values
    if has_extended {
        let ext_start = hdr_len;
        // Tag indices: 32 uint8 values; each non-zero entry says "there's data here"
        let tag_indices = &data[ext_start..ext_start + 32];
        for (i, &tidx) in tag_indices.iter().enumerate() {
            if tidx == 0 {
                continue;
            }
            let float_offset = ext_start + 32 + i * 4;
            if float_offset + 4 > data.len() {
                continue;
            }
            let val = f32_le(data, float_offset);
            let val_str = format!("{:.1}", val);

            // tidx corresponds to HeaderExt table index:
            // 1=ExposureAdjust, 2=Contrast, 3=Shadow, 4=Highlight,
            // 5=Saturation, 6=Sharpness, 7=RedAdjust, 8=GreenAdjust,
            // 9=BlueAdjust, 10=X3FillLight
            let name = match tidx {
                1 => "ExposureAdjust",
                2 => "Contrast",
                3 => "Shadow",
                4 => "Highlight",
                5 => "Saturation",
                6 => "Sharpness",
                7 => "RedAdjust",
                8 => "GreenAdjust",
                9 => "BlueAdjust",
                10 => "X3FillLight",
                _ => continue,
            };
            tags.push(mk_tag_str(
                name,
                name,
                val_str,
                "X3F",
                "HeaderExt",
                "Camera",
            ));
        }
    }
}

/// Parse a v4.x X3F header.
fn parse_header4(data: &[u8], tags: &mut Vec<Tag>) {
    // ImageWidth: uint32 at offset 40 (index 10 in int32u array)
    if data.len() >= 44 {
        let w = u32_le(data, 40);
        tags.push(mk_tag_u32(
            "ImageWidth",
            "Image Width",
            w,
            "X3F",
            "Header",
            "Image",
        ));
    }
    // ImageHeight: uint32 at offset 44 (index 11)
    if data.len() >= 48 {
        let h = u32_le(data, 44);
        tags.push(mk_tag_u32(
            "ImageHeight",
            "Image Height",
            h,
            "X3F",
            "Header",
            "Image",
        ));
    }
    // Rotation: uint32 at offset 48 (index 12)
    if data.len() >= 52 {
        let r = u32_le(data, 48);
        tags.push(mk_tag_u32(
            "Rotation", "Rotation", r, "X3F", "Header", "Image",
        ));
    }
}

/// Parse PROP section (SECp): key=value UTF-16LE pairs.
fn parse_properties(sec_data: &[u8], tags: &mut Vec<Tag>) {
    if sec_data.len() < 24 {
        return;
    }
    if &sec_data[0..4] != b"SECp" {
        return;
    }
    let entries = u32_le(sec_data, 8) as usize;
    let fmt = u32_le(sec_data, 12);
    if fmt != 0 {
        return; // only UTF-16LE supported
    }
    let char_len = u32_le(sec_data, 20) as usize;
    let char_start = 24 + 8 * entries;

    if char_start + char_len * 2 > sec_data.len() {
        return;
    }

    // Decode UTF-16LE character array
    let chars_bytes = &sec_data[char_start..char_start + char_len * 2];
    let mut chars = Vec::with_capacity(char_len);
    for i in 0..char_len {
        chars.push(u16::from_le_bytes([
            chars_bytes[i * 2],
            chars_bytes[i * 2 + 1],
        ]));
    }

    for i in 0..entries {
        let entry_off = 24 + i * 8;
        if entry_off + 8 > sec_data.len() {
            break;
        }
        let name_pos = u32_le(sec_data, entry_off) as usize;
        let val_pos = u32_le(sec_data, entry_off + 4) as usize;

        if name_pos >= chars.len() || val_pos >= chars.len() {
            continue;
        }

        let prop_name = extract_utf16_str(&chars, name_pos);
        let prop_val = extract_utf16_str(&chars, val_pos);

        // Map PROP key to ExifTool tag name + raw value + print conversion
        if let Some((tag_name, tag_desc, raw_val, print_val)) = map_prop(&prop_name, &prop_val) {
            let pv = print_val.clone();
            tags.push(Tag {
                id: TagId::Text(tag_name.to_string()),
                name: tag_name.to_string(),
                description: tag_desc.to_string(),
                group: TagGroup {
                    family0: "X3F".to_string(),
                    family1: "Properties".to_string(),
                    family2: "Camera".to_string(),
                },
                raw_value: raw_val,
                print_value: pv,
                priority: 0,
            });
        }
    }
}

/// Map a PROP key/value to (tag_name, tag_description, raw_value, print_value).
/// Returns None if the key is not recognized.
fn map_prop(key: &str, val: &str) -> Option<(&'static str, &'static str, Value, String)> {
    // Helper closure: wrap a string as (raw, print) pair
    let s = |v: &str| -> (Value, String) { (Value::String(v.to_string()), v.to_string()) };

    let (name, desc, raw, pv): (&'static str, &'static str, Value, String) = match key {
        "AEMODE" => {
            let pv = match val {
                "8" => "8-segment",
                "C" => "Center-weighted average",
                "A" => "Average",
                _ => val,
            };
            let (r, p) = s(pv);
            ("MeteringMode", "Metering Mode", r, p)
        }
        "AFMODE" => {
            let (r, p) = s(val);
            ("FocusMode", "Focus Mode", r, p)
        }
        "AP_DESC" => {
            let (r, p) = s(val);
            ("ApertureDisplayed", "Aperture Displayed", r, p)
        }
        "APERTURE" => {
            // FNumber — store as F64 so composite can compute Aperture
            if let Ok(f) = val.parse::<f64>() {
                let pv = format!("{:.1}", f);
                ("FNumber", "F Number", Value::F64(f), pv)
            } else {
                let (r, p) = s(val);
                ("FNumber", "F Number", r, p)
            }
        }
        "BRACKET" => {
            let (r, p) = s(val);
            ("BracketShot", "Bracket Shot", r, p)
        }
        "BURST" => {
            let (r, p) = s(val);
            ("BurstShot", "Burst Shot", r, p)
        }
        "CAMMANUF" => {
            let (r, p) = s(val);
            ("Make", "Make", r, p)
        }
        "CAMMODEL" => {
            let (r, p) = s(val);
            ("Model", "Model", r, p)
        }
        "CAMNAME" => {
            let (r, p) = s(val);
            ("CameraName", "Camera Name", r, p)
        }
        "CAMSERIAL" => {
            let (r, p) = s(val);
            ("SerialNumber", "Serial Number", r, p)
        }
        "CM_DESC" => {
            let (r, p) = s(val);
            ("SceneCaptureType", "Scene Capture Type", r, p)
        }
        "COLORSPACE" => {
            let (r, p) = s(val);
            ("ColorSpace", "Color Space", r, p)
        }
        "DRIVE" => {
            let pv = match val {
                "SINGLE" => "Single Shot",
                "MULTI" => "Multi Shot",
                "2S" => "2 s Timer",
                "10S" => "10 s Timer",
                "UP" => "Mirror Up",
                "AB" => "Auto Bracket",
                "OFF" => "Off",
                _ => val,
            };
            let (r, p) = s(pv);
            ("DriveMode", "Drive Mode", r, p)
        }
        "EXPCOMP" => {
            let (r, p) = s(val);
            ("ExposureCompensation", "Exposure Compensation", r, p)
        }
        "EXPNET" => {
            let (r, p) = s(val);
            ("NetExposureCompensation", "Net Exposure Compensation", r, p)
        }
        "EXPTIME" => {
            // IntegrationTime: value is in microseconds, store as F64 seconds
            if let Ok(usec) = val.parse::<f64>() {
                let secs = usec * 1e-6;
                let print = print_exposure_time(secs);
                (
                    "IntegrationTime",
                    "Integration Time",
                    Value::F64(secs),
                    print,
                )
            } else {
                let (r, p) = s(val);
                ("IntegrationTime", "Integration Time", r, p)
            }
        }
        "FIRMVERS" => {
            let (r, p) = s(val);
            ("FirmwareVersion", "Firmware Version", r, p)
        }
        "FLASH" => {
            let pv = ucfirst_lc(val);
            let (r, _) = s(val);
            ("FlashMode", "Flash Mode", r, pv)
        }
        "FLASHEXPCOMP" => {
            let (r, p) = s(val);
            ("FlashExposureComp", "Flash Exposure Comp", r, p)
        }
        "FLASHPOWER" => {
            let (r, p) = s(val);
            ("FlashPower", "Flash Power", r, p)
        }
        "FLASHTTLMODE" => {
            let (r, p) = s(val);
            ("FlashTTLMode", "Flash TTL Mode", r, p)
        }
        "FLASHTYPE" => {
            let (r, p) = s(val);
            ("FlashType", "Flash Type", r, p)
        }
        "FLENGTH" => {
            // FocalLength — store as F64 so composite 35efl can use it
            if let Ok(f) = val.parse::<f64>() {
                let pv = format!("{:.1} mm", f);
                ("FocalLength", "Focal Length", Value::F64(f), pv)
            } else {
                let (r, p) = s(val);
                ("FocalLength", "Focal Length", r, p)
            }
        }
        "FLEQ35MM" => {
            // FocalLengthIn35mmFormat — store as F64
            if let Ok(f) = val.parse::<f64>() {
                let pv = format!("{:.1} mm", f);
                (
                    "FocalLengthIn35mmFormat",
                    "Focal Length In 35mm Format",
                    Value::F64(f),
                    pv,
                )
            } else {
                let (r, p) = s(val);
                (
                    "FocalLengthIn35mmFormat",
                    "Focal Length In 35mm Format",
                    r,
                    p,
                )
            }
        }
        "FOCUS" => {
            let pv = match val {
                "AF" => "Auto-focus Locked",
                "NO LOCK" => "Auto-focus Didn't Lock",
                "M" => "Manual",
                _ => val,
            };
            let (r, p) = s(pv);
            ("Focus", "Focus", r, p)
        }
        "IMAGERBOARDID" => {
            let (r, p) = s(val);
            ("ImagerBoardID", "Imager Board ID", r, p)
        }
        "IMAGERTEMP" => {
            let pv = format!("{} C", val);
            let (r, _) = s(val);
            ("SensorTemperature", "Sensor Temperature", r, pv)
        }
        "IMAGEBOARDID" => {
            let (r, p) = s(val);
            ("ImageBoardID", "Image Board ID", r, p)
        }
        "ISO" => {
            // Store as F64 so LightValue composite can use it
            if let Ok(f) = val.parse::<f64>() {
                let pv = format!("{}", f as u64);
                ("ISO", "ISO", Value::F64(f), pv)
            } else {
                let (r, p) = s(val);
                ("ISO", "ISO", r, p)
            }
        }
        "LENSARANGE" => {
            let (r, p) = s(val);
            ("LensApertureRange", "Lens Aperture Range", r, p)
        }
        "LENSFRANGE" => {
            let (r, p) = s(val);
            ("LensFocalRange", "Lens Focal Range", r, p)
        }
        "LENSMODEL" => {
            // LensType — if it looks like a hex number, convert to name
            let val_trimmed = val.trim();
            let pv =
                if !val_trimmed.is_empty() && val_trimmed.chars().all(|c| c.is_ascii_hexdigit()) {
                    if let Ok(hex_val) = u32::from_str_radix(val_trimmed, 16) {
                        lens_type_name(hex_val)
                    } else {
                        val.to_string()
                    }
                } else {
                    val.to_string()
                };
            let (r, _) = s(val);
            ("LensType", "Lens Type", r, pv)
        }
        "PMODE" => {
            let pv = match val {
                "P" => "Program",
                "A" => "Aperture Priority",
                "S" => "Shutter Priority",
                "M" => "Manual",
                _ => val,
            };
            let (r, p) = s(pv);
            ("ExposureProgram", "Exposure Program", r, p)
        }
        "RESOLUTION" => {
            let pv = match val {
                "LOW" => "Low",
                "MED" => "Medium",
                "HI" => "High",
                _ => val,
            };
            let (r, p) = s(pv);
            ("Quality", "Quality", r, p)
        }
        "SENSORID" => {
            let (r, p) = s(val);
            ("SensorID", "Sensor ID", r, p)
        }
        "SH_DESC" => {
            let (r, p) = s(val);
            ("ShutterSpeedDisplayed", "Shutter Speed Displayed", r, p)
        }
        "SHUTTER" => {
            // ExposureTime — store as F64
            if let Ok(f) = val.parse::<f64>() {
                let print = print_exposure_time(f);
                ("ExposureTime", "Exposure Time", Value::F64(f), print)
            } else {
                let (r, p) = s(val);
                ("ExposureTime", "Exposure Time", r, p)
            }
        }
        "TIME" => {
            // Unix timestamp → "YYYY:MM:DD HH:MM:SS"
            if let Ok(ts) = val.parse::<i64>() {
                let dt = unix_to_datetime(ts);
                (
                    "DateTimeOriginal",
                    "Date/Time Original",
                    Value::String(dt.clone()),
                    dt,
                )
            } else {
                let (r, p) = s(val);
                ("DateTimeOriginal", "Date/Time Original", r, p)
            }
        }
        "WB_DESC" => {
            let (r, p) = s(val);
            ("WhiteBalance", "White Balance", r, p)
        }
        "VERSION_BF" => {
            let (r, p) = s(val);
            ("VersionBF", "Version BF", r, p)
        }
        _ => return None,
    };
    Some((name, desc, raw, pv))
}

// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------

fn u32_le(data: &[u8], offset: usize) -> u32 {
    u32::from_le_bytes([
        data[offset],
        data[offset + 1],
        data[offset + 2],
        data[offset + 3],
    ])
}

fn u16_le(data: &[u8], offset: usize) -> u16 {
    u16::from_le_bytes([data[offset], data[offset + 1]])
}

fn f32_le(data: &[u8], offset: usize) -> f32 {
    f32::from_le_bytes([
        data[offset],
        data[offset + 1],
        data[offset + 2],
        data[offset + 3],
    ])
}

fn hex_bytes(data: &[u8]) -> String {
    data.iter().map(|b| format!("{:02x}", b)).collect()
}

fn read_cstr(data: &[u8]) -> String {
    let end = data.iter().position(|&b| b == 0).unwrap_or(data.len());
    crate::encoding::decode_utf8_or_latin1(&data[..end])
}

fn extract_utf16_str(chars: &[u16], pos: usize) -> String {
    let mut end = pos;
    while end < chars.len() && chars[end] != 0 {
        end += 1;
    }
    // Since PROP strings are ASCII-compatible, just take low bytes
    chars[pos..end]
        .iter()
        .map(|&c| char::from_u32(c as u32).unwrap_or('?'))
        .collect()
}

/// Format exposure time as "1/N" or decimal.
fn print_exposure_time(secs: f64) -> String {
    if secs <= 0.0 {
        return secs.to_string();
    }
    if secs >= 1.0 {
        return format!("{}", secs as u32);
    }
    // Express as fraction
    let inv = 1.0 / secs;
    let rounded = inv.round() as u64;
    format!("1/{}", rounded)
}

/// Convert Unix timestamp to "YYYY:MM:DD HH:MM:SS".
fn unix_to_datetime(ts: i64) -> String {
    // Simple implementation without external crates
    // Seconds since 1970-01-01 00:00:00 UTC
    let mut secs = ts;
    if secs < 0 {
        return "0000:00:00 00:00:00".to_string();
    }

    let s = (secs % 60) as u32;
    secs /= 60;
    let m = (secs % 60) as u32;
    secs /= 60;
    let h = (secs % 24) as u32;
    secs /= 24;

    // Days since epoch to year/month/day
    let (y, mo, d) = days_to_ymd(secs as u32);
    format!("{:04}:{:02}:{:02} {:02}:{:02}:{:02}", y, mo, d, h, m, s)
}

fn days_to_ymd(mut days: u32) -> (u32, u32, u32) {
    // Gregorian calendar calculation
    let mut year = 1970u32;
    loop {
        let leap = is_leap(year);
        let days_in_year = if leap { 366 } else { 365 };
        if days < days_in_year {
            break;
        }
        days -= days_in_year;
        year += 1;
    }
    let leap = is_leap(year);
    let month_days = [
        31u32,
        if leap { 29 } else { 28 },
        31,
        30,
        31,
        30,
        31,
        31,
        30,
        31,
        30,
        31,
    ];
    let mut month = 1u32;
    for &md in &month_days {
        if days < md {
            break;
        }
        days -= md;
        month += 1;
    }
    (year, month, days + 1)
}

fn is_leap(year: u32) -> bool {
    (year % 4 == 0 && year % 100 != 0) || year % 400 == 0
}

fn ucfirst_lc(s: &str) -> String {
    let lower = s.to_lowercase();
    let mut chars = lower.chars();
    match chars.next() {
        None => String::new(),
        Some(c) => {
            let upper: String = c.to_uppercase().collect();
            upper + chars.as_str()
        }
    }
}

/// Look up Sigma lens type by hex value (from %Image::ExifTool::Sigma::sigmaLensTypes).
fn lens_type_name(hex_val: u32) -> String {
    // Partial list from Sigma.pm sigmaLensTypes — enough for test images
    let name = match hex_val {
        0x000 => "Sigma Lens (0x0)",
        0x100 => "Sigma Lens (0x100)",
        0x101 => "Sigma 18-50mm F3.5-5.6 DC",
        0x103 => "Sigma 18-125mm F3.5-5.6 DC",
        0x104 => "Sigma 18-200mm F3.5-6.3 DC",
        0x105 => "Sigma 24-60mm F2.8 EX DG",
        0x106 => "Sigma 17-70mm F2.8-4.5 DC Macro",
        0x107 => "Sigma 18-50mm F2.8 EX DC",
        0x108 => "Sigma 70-200mm F2.8 II EX DG APO Macro",
        0x109 => "Sigma 50-150mm F2.8 EX DC APO HSM",
        0x10a => "Sigma 28mm F1.8 EX DG",
        0x10b => "Sigma 70mm F2.8 EX DG Macro",
        0x10c => "Sigma 18-50mm F2.8 EX DC Macro",
        0x129 => "Sigma 14mm F2.8 EX Aspherical HSM",
        0x12c => "Sigma 20mm F1.8 EX DG Aspherical RF",
        0x130 => "Sigma 30mm F1.4 EX DC HSM",
        0x145 => "Sigma 15-30mm F3.5-4.5 EX DG Aspherical",
        0x146 => "Sigma 18-35mm F3.5-4.5 Aspherical",
        0x150 => "Sigma 50mm F2.8 EX DG Macro",
        0x151 => "Sigma 105mm F2.8 EX DG Macro",
        0x152 => "Sigma 180mm F3.5 EX DG APO HSM Macro",
        0x153 => "Sigma 150mm F2.8 EX DG HSM APO Macro",
        0x154 => "Sigma 10-20mm F4-5.6 EX DC",
        0x155 => "Sigma 12-24mm F4.5-5.6 EX DG Aspherical",
        0x156 => "Sigma 17-35mm F2.8-4 EX DG Aspherical",
        0x157 => "Sigma 24mm F1.8 EX DG Aspherical Macro",
        0x158 => "Sigma 28-70mm F2.8-4 DG",
        0x169 => "Sigma 70-300mm F4-5.6 APO DG Macro",
        0x184 => "Sigma 24-70mm F2.8 EX DG Macro",
        0x190 => "Sigma APO 70-200mm F2.8 EX DG",
        0x194 => "Sigma 300mm F2.8 APO EX DG HSM",
        0x195 => "Sigma 500mm F4.5 APO EX DG HSM",
        0x1a0 => "Sigma 24-135mm F2.8-4.5",
        _ => "",
    };
    if name.is_empty() {
        format!("Unknown ({:#x})", hex_val)
    } else {
        name.to_string()
    }
}

// ---------------------------------------------------------------------------
// Tag constructors
// ---------------------------------------------------------------------------

fn mk_tag_str(name: &str, desc: &str, value: String, f0: &str, f1: &str, f2: &str) -> Tag {
    let pv = value.clone();
    Tag {
        id: TagId::Text(name.to_string()),
        name: name.to_string(),
        description: desc.to_string(),
        group: TagGroup {
            family0: f0.to_string(),
            family1: f1.to_string(),
            family2: f2.to_string(),
        },
        raw_value: Value::String(value),
        print_value: pv,
        priority: 0,
    }
}

fn mk_tag_u32(name: &str, desc: &str, value: u32, f0: &str, f1: &str, f2: &str) -> Tag {
    let pv = value.to_string();
    Tag {
        id: TagId::Text(name.to_string()),
        name: name.to_string(),
        description: desc.to_string(),
        group: TagGroup {
            family0: f0.to_string(),
            family1: f1.to_string(),
            family2: f2.to_string(),
        },
        raw_value: Value::U32(value),
        print_value: pv,
        priority: 0,
    }
}

fn mk_tag_binary(name: &str, desc: &str, data: Vec<u8>, f0: &str, f1: &str, f2: &str) -> Tag {
    let pv = format!(
        "(Binary data {} bytes, use -b option to extract)",
        data.len()
    );
    Tag {
        id: TagId::Text(name.to_string()),
        name: name.to_string(),
        description: desc.to_string(),
        group: TagGroup {
            family0: f0.to_string(),
            family1: f1.to_string(),
            family2: f2.to_string(),
        },
        raw_value: Value::Binary(data),
        print_value: pv,
        priority: 0,
    }
}