ethos-doc-core 0.1.0

Ethos canonical document model, IDs, errors, schema types, traits, c14n and fingerprints
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
/*
 * Copyright 2026 The Ethos maintainers
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

//! Internal source-only `crop_element` resolver for Milestone D contract work.
//!
//! This module validates the committed request and descriptor identity rules over
//! native Ethos document JSON. It intentionally does not add a CLI command,
//! binding surface, rendered backend, or sandbox boundary.

use crate::c14n;
use crate::error::EthosError;
use crate::model::{Document, Page};
use crate::SCHEMA_VERSION;
use serde::{Deserialize, Serialize};
use serde_json::json;

const CROP_ELEMENT_REQUEST_ARTIFACT_TYPE: &str = "ethos.crop_element_request.v1";
const CROP_DESCRIPTOR_ARTIFACT_TYPE: &str = "ethos.crop_descriptor.v1";
const CROP_ELEMENT_REQUEST_REF_VERSION: &str = "ethos.crop_element_request_ref.v1";
const LOGICAL_CROP_REF_VERSION: &str = "ethos.logical_crop_ref.v1";

/// Source-only `crop_element` request envelope.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct CropElementRequest {
    /// Request artifact type, currently `ethos.crop_element_request.v1`.
    pub artifact_type: String,
    /// Contract schema version.
    pub schema_version: String,
    /// Stable request identity.
    pub request_ref: String,
    /// Expected canonical document fingerprint.
    pub document_fingerprint: String,
    /// Element id in the canonical Ethos document graph.
    pub element_id: String,
    /// Requested rendering mode.
    pub rendering: CropElementRendering,
    /// Fingerprint of caller-provided source PDF bytes for rendered requests.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub source_pdf_fingerprint: Option<String>,
}

/// Supported `crop_element` rendering modes.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum CropElementRendering {
    /// Emit only a JSON crop descriptor.
    DescriptorOnly,
    /// Emit a crop descriptor plus rendered crop artifact.
    Rendered,
}

impl CropElementRendering {
    fn as_contract_str(self) -> &'static str {
        match self {
            CropElementRendering::DescriptorOnly => "descriptor_only",
            CropElementRendering::Rendered => "rendered",
        }
    }
}

/// Deterministic JSON descriptor for one resolved crop element.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct CropElementDescriptor {
    /// Descriptor artifact type, currently `ethos.crop_descriptor.v1`.
    pub artifact_type: String,
    /// Contract schema version.
    pub schema_version: String,
    /// Stable descriptor filename.
    pub crop_ref: String,
    /// Canonical document fingerprint.
    pub document_fingerprint: String,
    /// Resolved page id.
    pub page: String,
    /// Resolved element bounding box in contract array form.
    pub bbox: [i64; 4],
    /// Logical verification check ids bound to this descriptor.
    pub check_ids: Vec<String>,
    /// Descriptor rendering status.
    pub rendering_status: CropElementRendering,
    /// Fingerprint of caller-provided source PDF bytes for rendered descriptors.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub source_pdf_fingerprint: Option<String>,
    /// Stable rendered crop filename.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub rendered_ref: Option<String>,
    /// Rendered crop format.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub rendered_format: Option<String>,
    /// SHA-256 of rendered crop bytes.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub rendered_sha256: Option<String>,
    /// Rendered crop width in pixels.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub rendered_width_px: Option<u32>,
    /// Rendered crop height in pixels.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub rendered_height_px: Option<u32>,
    /// SHA-256 of resolved element text when textual evidence is present.
    #[serde(skip_serializing_if = "Option::is_none")]
    pub text_sha256: Option<String>,
}

/// Fail-closed `crop_element` resolver diagnostic.
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct CropElementError {
    diagnostic: &'static str,
}

impl CropElementError {
    /// Deterministic diagnostic message for the resolver failure.
    pub fn diagnostic(&self) -> &'static str {
        self.diagnostic
    }

    fn new(diagnostic: &'static str) -> Self {
        CropElementError { diagnostic }
    }
}

impl core::fmt::Display for CropElementError {
    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
        f.write_str(self.diagnostic)
    }
}

impl std::error::Error for CropElementError {}

/// Compute the source-only `crop_element` request identity.
pub fn crop_element_request_ref(request: &CropElementRequest) -> Result<String, EthosError> {
    let mut identity = json!({
        "document_fingerprint": request.document_fingerprint,
        "element_id": request.element_id,
        "rendering": request.rendering.as_contract_str(),
        "version": CROP_ELEMENT_REQUEST_REF_VERSION,
    });
    if let Some(source_pdf_fingerprint) = &request.source_pdf_fingerprint {
        identity.as_object_mut().expect("json object").insert(
            "source_pdf_fingerprint".to_string(),
            json!(source_pdf_fingerprint),
        );
    }
    let digest = c14n::sha256_hex(&identity)
        .map_err(|err| EthosError::internal(format!("crop_element request_ref error: {err}")))?;
    Ok(format!("request-{digest}"))
}

/// Compute the logical crop descriptor filename for a bound verification check.
pub fn crop_element_crop_ref(
    document_fingerprint: &str,
    check_id: &str,
    page: &str,
) -> Result<String, EthosError> {
    let identity = json!({
        "check_id": check_id,
        "document_fingerprint": document_fingerprint,
        "page": page,
        "version": LOGICAL_CROP_REF_VERSION,
    });
    let digest = c14n::sha256_hex(&identity)
        .map_err(|err| EthosError::internal(format!("crop_element crop_ref error: {err}")))?;
    Ok(format!("crop-{digest}.json"))
}

/// Resolve one descriptor-only crop descriptor from a native Ethos document and request.
pub fn resolve_crop_element_descriptor(
    document: &Document,
    request: &CropElementRequest,
    check_id: &str,
) -> Result<CropElementDescriptor, CropElementError> {
    if request.artifact_type != CROP_ELEMENT_REQUEST_ARTIFACT_TYPE {
        return Err(CropElementError::new(
            "request artifact_type is not ethos.crop_element_request.v1",
        ));
    }
    if request.schema_version != SCHEMA_VERSION {
        return Err(CropElementError::new(
            "request schema_version is not supported",
        ));
    }
    if request.request_ref.is_empty() {
        return Err(CropElementError::new("request_ref is missing"));
    }
    if request.document_fingerprint.is_empty() || document.fingerprint.is_empty() {
        return Err(CropElementError::new("document_fingerprint is missing"));
    }
    let expected_request_ref = crop_element_request_ref(request).map_err(|_| {
        CropElementError::new("request_ref does not match crop element request identity tuple")
    })?;
    if request.request_ref != expected_request_ref {
        return Err(CropElementError::new(
            "request_ref does not match crop element request identity tuple",
        ));
    }
    if request.document_fingerprint != document.fingerprint {
        return Err(CropElementError::new(
            "request document_fingerprint does not match document fingerprint",
        ));
    }
    if !is_check_id(check_id) {
        return Err(CropElementError::new(
            "descriptor must bind exactly one logical check id",
        ));
    }
    match request.rendering {
        CropElementRendering::DescriptorOnly => {
            if request.source_pdf_fingerprint.is_some() {
                return Err(CropElementError::new(
                    "descriptor_only crop_element request must not include source_pdf_fingerprint",
                ));
            }
        }
        CropElementRendering::Rendered => {
            let Some(source_pdf_fingerprint) = request.source_pdf_fingerprint.as_deref() else {
                return Err(CropElementError::new(
                    "rendered crop_element request requires source_pdf_fingerprint",
                ));
            };
            if source_pdf_fingerprint != document.source.fingerprint {
                return Err(CropElementError::new(
                    "request source_pdf_fingerprint does not match document source fingerprint",
                ));
            }
        }
    }

    let element = document
        .payload
        .elements
        .iter()
        .find(|element| element.id == request.element_id)
        .ok_or_else(|| CropElementError::new("request element_id does not resolve in document"))?;
    let page = document
        .payload
        .pages
        .iter()
        .find(|page| page.id == element.page)
        .ok_or_else(|| CropElementError::new("resolved element is missing page"))?;
    validate_resolved_bbox(element.bbox, page)?;

    let text_sha256 = element
        .text
        .as_deref()
        .map(|text| c14n::sha256_hex_bytes(text.as_bytes()));
    let crop_ref =
        crop_element_crop_ref(&document.fingerprint, check_id, &element.page).map_err(|_| {
            CropElementError::new("descriptor crop_ref does not match logical identity tuple")
        })?;

    Ok(CropElementDescriptor {
        artifact_type: CROP_DESCRIPTOR_ARTIFACT_TYPE.to_string(),
        schema_version: SCHEMA_VERSION.to_string(),
        crop_ref,
        document_fingerprint: document.fingerprint.clone(),
        page: element.page.clone(),
        bbox: element.bbox.to_array(),
        check_ids: vec![check_id.to_string()],
        rendering_status: request.rendering,
        source_pdf_fingerprint: request.source_pdf_fingerprint.clone(),
        rendered_ref: None,
        rendered_format: None,
        rendered_sha256: None,
        rendered_width_px: None,
        rendered_height_px: None,
        text_sha256,
    })
}

fn validate_resolved_bbox(bbox: crate::geom::QRect, page: &Page) -> Result<(), CropElementError> {
    let [x0, y0, x1, y1] = bbox.to_array();
    if x0 >= x1 || y0 >= y1 {
        return Err(CropElementError::new(
            "resolved element bbox has non-positive area",
        ));
    }
    if x0 < 0 || y0 < 0 || x1 > page.width || y1 > page.height {
        return Err(CropElementError::new(
            "resolved element bbox exceeds page bounds",
        ));
    }
    Ok(())
}

fn is_check_id(value: &str) -> bool {
    value.len() == 5
        && value
            .strip_prefix('v')
            .is_some_and(|digits| digits.chars().all(|ch| ch.is_ascii_digit()))
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::model::Document;
    use serde_json::Value;

    fn fixture_document() -> Document {
        serde_json::from_str(include_str!(
            "../../../schemas/examples/document.example.json"
        ))
        .unwrap()
    }

    fn fixture_request() -> CropElementRequest {
        serde_json::from_str(include_str!(
            "../../../schemas/examples/crop-element-request.example.json"
        ))
        .unwrap()
    }

    fn expected_descriptor_value() -> Value {
        serde_json::from_str(include_str!(
            "../../../schemas/examples/crop-descriptor.example.json"
        ))
        .unwrap()
    }

    #[test]
    fn crop_element_descriptor_matches_committed_example() {
        let descriptor =
            resolve_crop_element_descriptor(&fixture_document(), &fixture_request(), "v0001")
                .unwrap();

        assert_eq!(
            serde_json::to_value(descriptor).unwrap(),
            expected_descriptor_value()
        );
    }

    #[test]
    fn crop_element_request_ref_matches_committed_example() {
        let request = fixture_request();

        assert_eq!(
            crop_element_request_ref(&request).unwrap(),
            request.request_ref
        );
    }

    #[test]
    fn crop_element_request_rejects_unknown_fields() {
        let mut request = serde_json::to_value(fixture_request()).unwrap();
        request
            .as_object_mut()
            .unwrap()
            .insert("unexpected".to_string(), Value::Bool(true));

        let error = serde_json::from_value::<CropElementRequest>(request).unwrap_err();
        assert!(error.to_string().contains("unknown field `unexpected`"));
    }

    #[test]
    fn crop_element_crop_ref_matches_committed_descriptor() {
        let document = fixture_document();
        let descriptor = expected_descriptor_value();

        assert_eq!(
            crop_element_crop_ref(&document.fingerprint, "v0001", "p0001").unwrap(),
            descriptor["crop_ref"]
        );
    }

    #[test]
    fn stale_request_ref_fails_closed() {
        let mut request = fixture_request();
        request.request_ref = format!("request-{}", "0".repeat(64));

        let err = resolve_crop_element_descriptor(&fixture_document(), &request, "v0001")
            .expect_err("stale request_ref must fail");

        assert_eq!(
            err.diagnostic(),
            "request_ref does not match crop element request identity tuple"
        );
    }

    #[test]
    fn document_fingerprint_mismatch_fails_closed() {
        let mut request = fixture_request();
        request.document_fingerprint = format!("sha256:{}", "0".repeat(64));
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let err = resolve_crop_element_descriptor(&fixture_document(), &request, "v0001")
            .expect_err("document fingerprint mismatch must fail");

        assert_eq!(
            err.diagnostic(),
            "request document_fingerprint does not match document fingerprint"
        );
    }

    #[test]
    fn missing_document_fingerprint_fails_closed() {
        let mut document = fixture_document();
        document.fingerprint.clear();
        let mut request = fixture_request();
        request.document_fingerprint.clear();
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let err = resolve_crop_element_descriptor(&document, &request, "v0001")
            .expect_err("missing document fingerprint must fail");

        assert_eq!(err.diagnostic(), "document_fingerprint is missing");
    }

    #[test]
    fn unresolved_element_fails_closed() {
        let mut request = fixture_request();
        request.element_id = "e999999".to_string();
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let err = resolve_crop_element_descriptor(&fixture_document(), &request, "v0001")
            .expect_err("unknown element must fail");

        assert_eq!(
            err.diagnostic(),
            "request element_id does not resolve in document"
        );
    }

    #[test]
    fn missing_element_page_fails_closed() {
        let mut document = fixture_document();
        document.payload.pages.clear();

        let err = resolve_crop_element_descriptor(&document, &fixture_request(), "v0001")
            .expect_err("missing page must fail");

        assert_eq!(err.diagnostic(), "resolved element is missing page");
    }

    #[test]
    fn zero_area_element_bbox_fails_closed() {
        let mut document = fixture_document();
        let element = document
            .payload
            .elements
            .iter_mut()
            .find(|element| element.id == fixture_request().element_id)
            .expect("fixture element exists");
        element.bbox = crate::geom::QRect::new(10, 20, 10, 30).unwrap();

        let err = resolve_crop_element_descriptor(&document, &fixture_request(), "v0001")
            .expect_err("zero-area bbox must fail");

        assert_eq!(
            err.diagnostic(),
            "resolved element bbox has non-positive area"
        );
    }

    #[test]
    fn negative_element_bbox_fails_closed() {
        let mut document = fixture_document();
        let element = document
            .payload
            .elements
            .iter_mut()
            .find(|element| element.id == fixture_request().element_id)
            .expect("fixture element exists");
        element.bbox = crate::geom::QRect::new(-1, 0, 10, 10).unwrap();

        let err = resolve_crop_element_descriptor(&document, &fixture_request(), "v0001")
            .expect_err("negative bbox coordinate must fail");

        assert_eq!(
            err.diagnostic(),
            "resolved element bbox exceeds page bounds"
        );
    }

    #[test]
    fn page_overflow_element_bbox_fails_closed() {
        let mut document = fixture_document();
        let page = document
            .payload
            .pages
            .iter()
            .find(|page| page.id == "p0001")
            .expect("fixture page exists")
            .clone();
        let element = document
            .payload
            .elements
            .iter_mut()
            .find(|element| element.id == fixture_request().element_id)
            .expect("fixture element exists");
        element.bbox = crate::geom::QRect::new(0, 0, page.width + 1, 10).unwrap();

        let err = resolve_crop_element_descriptor(&document, &fixture_request(), "v0001")
            .expect_err("bbox beyond page width must fail");

        assert_eq!(
            err.diagnostic(),
            "resolved element bbox exceeds page bounds"
        );
    }

    #[test]
    fn malformed_check_id_fails_closed() {
        let err = resolve_crop_element_descriptor(&fixture_document(), &fixture_request(), "v1")
            .expect_err("malformed check id must fail");

        assert_eq!(
            err.diagnostic(),
            "descriptor must bind exactly one logical check id"
        );
    }

    #[test]
    fn rendered_descriptor_binds_source_fingerprint() {
        let mut request = fixture_request();
        request.rendering = CropElementRendering::Rendered;
        request.source_pdf_fingerprint = Some(fixture_document().source.fingerprint);
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let descriptor =
            resolve_crop_element_descriptor(&fixture_document(), &request, "v0001").unwrap();

        assert_eq!(descriptor.rendering_status, CropElementRendering::Rendered);
        assert_eq!(
            descriptor.source_pdf_fingerprint,
            Some(fixture_document().source.fingerprint)
        );
    }

    #[test]
    fn rendered_request_requires_source_fingerprint() {
        let mut request = fixture_request();
        request.rendering = CropElementRendering::Rendered;
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let err = resolve_crop_element_descriptor(&fixture_document(), &request, "v0001")
            .expect_err("rendered request without source fingerprint must fail");

        assert_eq!(
            err.diagnostic(),
            "rendered crop_element request requires source_pdf_fingerprint"
        );
    }

    #[test]
    fn rendered_request_rejects_source_fingerprint_mismatch() {
        let mut request = fixture_request();
        request.rendering = CropElementRendering::Rendered;
        request.source_pdf_fingerprint = Some("sha256:".to_string() + &"0".repeat(64));
        request.request_ref = crop_element_request_ref(&request).unwrap();

        let err = resolve_crop_element_descriptor(&fixture_document(), &request, "v0001")
            .expect_err("rendered request with mismatched source fingerprint must fail");

        assert_eq!(
            err.diagnostic(),
            "request source_pdf_fingerprint does not match document source fingerprint"
        );
    }
}