espflash 4.4.0

//! Library and application errors

#[cfg(feature = "serialport")]
use std::fmt::{Display, Formatter};
use std::{array::TryFromSliceError, io, num::ParseIntError, str::Utf8Error};

use miette::Diagnostic;
#[cfg(feature = "serialport")]
use slip_codec::SlipError;
use strum::VariantNames;
use thiserror::Error;

#[cfg(feature = "cli")]
use crate::cli::monitor::parser::esp_defmt::DefmtError;
#[cfg(feature = "serialport")]
use crate::command::CommandType;
use crate::{
    flasher::{FlashFrequency, FlashSize},
    target::Chip,
};

// A type alias for a dynamic error that can be used in the library.
// https://d34dl0ck.me/rust-bites-designing-error-types-in-rust-libraries/index.html
type CoreError = Box<dyn core::error::Error + Send + Sync>;

/// All possible errors returned by espflash
#[derive(Debug, Diagnostic, Error)]
#[non_exhaustive]
pub enum Error {
    /// App partition not found
    #[error("App partition not found")]
    #[diagnostic(code(espflash::app_partition_not_found))]
    AppPartitionNotFound,

    /// Operation was cancelled by the user
    #[error("Operation was cancelled by the user")]
    #[diagnostic(code(espflash::cancelled))]
    Cancelled,

    /// Unable to detect chip type
    #[error("{0}")]
    #[diagnostic(
        code(espflash::chip_detect_error),
        help("Supported chips are: {}\n\
              If your chip is supported, try hard-resetting the device and try again",
             Chip::VARIANTS.join(", ")
        )
    )]
    ChipDetectError(String),

    /// The specified chip does not match the detected chip
    #[error("Chip provided with `-c/--chip` ({0}) does not match the detected chip ({1})")]
    #[diagnostic(
        code(espflash::chip_mismatch),
        help(
            "Ensure that the correct chip is selected, or remove the `-c/--chip` option to autodetect the chip"
        )
    )]
    ChipMismatch(String, String),

    /// Chip argument not provided, this is required when using the `--before
    /// no-reset-no-sync` option
    #[error(
        "Chip argument not provided, this is required when using the `--before no-reset-no-sync` option"
    )]
    #[diagnostic(
        code(espflash::chip_not_provided),
        help("Ensure that you provide the `-c/--chip` option with the proper chip")
    )]
    ChipNotProvided,

    /// Corrupted data received
    #[error("Corrupt data, expected {0:2x?} bytes but received {1:2x?} bytes")]
    #[diagnostic(code(espflash::read_flash::corrupt_data))]
    CorruptData(usize, usize),

    /// The calculated and received MD5 digests do not match
    #[error("MD5 digest mismatch: expected {0:2x?}, received: {1:2x?}")]
    #[diagnostic(code(espflash::read_flash::digest_mismatch))]
    DigestMismatch(Vec<u8>, Vec<u8>),

    /// Supplied ELF image can not be run from RAM, as it includes segments
    /// mapped to ROM addresses
    #[error(
        "Supplied ELF image can not be run from RAM, as it includes segments mapped to ROM addresses"
    )]
    #[diagnostic(
        code(espflash::not_ram_loadable),
        help(
            "Either build the binary to be all in RAM, or remove the `--ram` option to load the image to flash"
        )
    )]
    ElfNotRamLoadable,

    /// The supplied ELF image is too large for the configured app partition
    #[error(
        "Supplied ELF image of {0}B is too big, and doesn't fit configured app partition of {1}B"
    )]
    #[diagnostic(
        code(espflash::image_too_big),
        help("Reduce the size of the binary or increase the size of the app partition."),
        url(
            "https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/partition-tables.html#built-in-partition-tables"
        )
    )]
    ElfTooBig(u32, u32),

    /// Failed to connect to on-device flash
    #[error("Failed to connect to on-device flash")]
    #[diagnostic(code(espflash::flash_connect))]
    FlashConnect,

    /// Received MD5 digest has the incorrect length
    #[error("Expected MD5 digest (16 bytes), received: {0:#x} bytes")]
    #[diagnostic(code(espflash::read_flash::incorrect_digest_length))]
    IncorrectDigestLength(usize),

    /// Incorrect response from the stub/ROM loader
    #[error("Incorrect response from the stub/ROM loader")]
    #[diagnostic(code(espflash::read_flash::incorrect_response))]
    IncorrectResponse,

    /// The provided bootloader binary is invalid
    #[error("The provided bootloader binary is invalid")]
    InvalidBootloader,

    /// Specified bootloader path is not a `.bin` file
    #[error("Specified bootloader path is not a .bin file")]
    #[diagnostic(code(espflash::invalid_bootloader_path))]
    InvalidBootloaderPath,

    /// Invalid flash size provided
    #[error("The flash size '{0}' is invalid")]
    #[diagnostic(
        code(espflash::invalid_flash_size),
        help("The accepted values are: {:?}", FlashSize::VARIANTS)
    )]
    InvalidFlashSize(String),

    /// IO error
    #[cfg(not(feature = "serialport"))]
    #[error(transparent)]
    IoError(#[from] io::Error),

    /// Specified partition table path is not a `.bin` or `.csv` file
    #[error("Specified partition table path is not a .bin or .csv file")]
    #[diagnostic(code(espflash::invalid_partition_table_path))]
    InvalidPartitionTablePath,

    /// No serial ports could be detected
    #[error("No serial ports could be detected")]
    #[diagnostic(
        code(espflash::no_serial),
        help(
            "Make sure you have connected a device to the host system. If the device is connected but not listed, try using the `--list-all-ports` flag."
        )
    )]
    NoSerial,

    /// Read more bytes than expected
    #[error("Read more bytes than expected")]
    #[diagnostic(code(espflash::read_flash::read_more_than_expected))]
    ReadMoreThanExpected,

    /// Command requires using the RAM stub
    #[error("This command requires using the RAM stub")]
    #[diagnostic(
        code(espflash::stub_required),
        help("Don't use the `--no-stub` option with the command")
    )]
    StubRequired,

    /// Serial port could not be found
    #[error("The serial port '{0}' could not be found")]
    #[diagnostic(
        code(espflash::serial_not_found),
        help("Make sure the correct device is connected to the host system")
    )]
    SerialNotFound(String),

    /// No serial port argument was provided
    #[error("No serial port was provided")]
    #[diagnostic(
        code(espflash::serial_not_selected),
        help(
            "Make sure to provide a serial port via argument, environment variable or configuration file when using the `--non-interactive` flag"
        )
    )]
    SerialNotSelected,

    /// Chip does not support a specific feature
    #[error("The {chip} does not support {feature}")]
    #[diagnostic(code(espflash::unsupported_feature))]
    UnsupportedFeature {
        /// Chip
        chip: Chip,
        /// Unsupported feature
        feature: String,
    },

    /// Unsupported flash chip
    #[error("Flash chip not supported, unrecognized flash ID: {0:#x}")]
    #[diagnostic(code(espflash::unrecognized_flash))]
    UnsupportedFlash(u8),

    /// Flash frequency not supported by chip
    #[error("The specified flash frequency '{frequency}' is not supported by the {chip}")]
    #[diagnostic(code(espflash::unsupported_flash_frequency))]
    UnsupportedFlashFrequency {
        /// Chip
        chip: Chip,
        /// Flash frequency
        frequency: FlashFrequency,
    },

    /// Unsupported chip revision for connected chip
    #[error(
        "Minimum supported revision is {major}.{minor}, connected device's revision is {found_major}.{found_minor}"
    )]
    #[diagnostic(code(espflash::unsupported_chip_revision))]
    UnsupportedChipRevision {
        /// Minimum supported major version
        major: u16,
        /// Minimum supported minor version
        minor: u16,
        /// Detected major version
        found_major: u16,
        /// Detected minor version
        found_minor: u16,
    },

    /// Failed to parse chip revision due to invalid format
    #[error(
        "Failed to parse chip revision: {chip_rev}. Chip revision must be in the format `major.minor`"
    )]
    #[diagnostic(code(espflash::cli::parse_chip_rev_error))]
    ParseChipRevError {
        /// Chip revision
        chip_rev: String,
    },

    /// Error while connecting to device
    #[error("Error while connecting to device")]
    Connection(CoreError),

    /// Communication error while flashing device
    #[error("Communication error while flashing device")]
    Flashing(CoreError),

    /// Supplied ELF image is not valid
    #[error("Supplied ELF image is not valid")]
    #[diagnostic(
        code(espflash::invalid_elf),
        help("Try running `cargo clean` and rebuilding the image")
    )]
    InvalidElf(CoreError),

    /// Supplied ELF image contains an invalid application descriptor
    #[error("Supplied ELF image contains an invalid application descriptor")]
    #[diagnostic(code(espflash::invalid_app_descriptor))]
    InvalidAppDescriptor(CoreError),

    /// The bootloader returned an error
    #[error("The bootloader returned an error")]
    #[cfg(feature = "serialport")]
    RomError(CoreError),

    /// The selected partition does not exist in the partition table
    #[error("The selected partition does not exist in the partition table")]
    MissingPartition(CoreError),

    /// The partition table is missing or invalid
    #[error("The partition table is missing or invalid")]
    MissingPartitionTable(CoreError),

    /// `defmt` error
    #[cfg(feature = "cli")]
    #[error(transparent)]
    #[diagnostic(transparent)]
    Defmt(#[from] DefmtError),

    /// Verification of flash content failed
    #[error("Verification of flash content failed")]
    #[diagnostic(code(espflash::verify_failed))]
    VerifyFailed,

    /// Error during user interaction
    #[cfg(feature = "cli")]
    #[error(transparent)]
    #[diagnostic(code(espflash::dialoguer_error))]
    DialoguerError(CoreError),

    /// Error while trying to convert from slice
    #[error(transparent)]
    TryFromSlice(CoreError),

    /// Error while trying to parse int from text
    #[error(transparent)]
    ParseIntError(CoreError),

    /// Error while trying to parse UTF-8 from bytes
    #[error(transparent)]
    Utf8Error(CoreError),

    /// Failed to open file
    #[error("Failed to open file: {0}")]
    FileOpenError(String, #[source] io::Error),

    /// Failed to parse partition table
    #[error("Failed to parse partition table")]
    Partition(CoreError),

    /// Invalid response from target device
    #[error("Invalid response: {0}")]
    #[diagnostic(code(espflash::invalid_response))]
    InvalidResponse(String),

    /// An invalid address and/or size argument was provided
    #[error("Invalid `address`({address})  and/or `size`({size}) argument(s)")]
    #[diagnostic(
        code(espflash::erase_region::invalid_argument),
        help("`address` ({address}) and `size` ({size}) must be multiples of 0x1000 (4096)")
    )]
    InvalidEraseRegionArgument {
        /// Address argument
        address: u32,
        /// Size argument
        size: u32,
    },

    /// Firmware was built for a chip other than what was detected
    #[error("The firmware was built for {elf}, but the detected chip is {detected}")]
    #[diagnostic(
        code(espflash::chip_mismatch),
        help(
            "Ensure that the device is connected and your host recognizes the serial adapter. (File {elf}, detected chip is {detected})"
        )
    )]
    FirmwareChipMismatch {
        /// Chip which the ELF file was built for
        elf: String,
        /// Chip which was detected
        detected: Chip,
    },

    /// The partition table does not fit into the flash
    #[error("The partition table does not fit into the flash ({0})")]
    #[diagnostic(
        code(espflash::partition_table::does_not_fit),
        help("Make sure you set the correct flash size with the `--flash-size` option")
    )]
    PartitionTableDoesNotFit(FlashSize),

    /// App descriptor not present in the binary
    #[error("{0}")]
    #[diagnostic(code(espflash::app_desc::app_descriptor_not_present))]
    AppDescriptorNotPresent(String),

    /// Key is not in the expected section
    #[error("Misplaced key, check your configuration file. Key: {0}")]
    MisplacedKey(String),

    /// The efuse field is larger than 32 bit.
    #[error("Requested efuse field is larger than 32 bit. Use `read_efuse_le`.")]
    EfuseFieldTooLarge,

    /// Specified eFuse block does not exist
    #[error("specified eFuse block does not exist: {0}")]
    InvalidEfuseBlock(u32),

    /// Unsupported crystal frequency
    #[error("Unsupported crystal frequency: {0}")]
    UnsupportedXtalFrequency(String),

    /// Failed to write eFuse
    #[error("Failed to write eFuse: {0}")]
    WritingEfuseFailed(String),

    /// Timed out while waiting for eFuse controller to return to idle
    #[error("Timed out while waiting for eFuse controller to return to idle")]
    TimedOutWaitingForEfuseController,

    /// Tried to use an unsupported eFuse coding scheme
    #[error("Tried to use an unsupported eFuse coding scheme: {0}")]
    UnsupportedEfuseCodingScheme(String),

    /// Tried to write to address < 0x8000 with Secure Download enabled
    #[error("Tried to write to address < 0x8000 with Secure Download enabled")]
    SecureDownloadBootloaderProtection,
}

#[cfg(feature = "serialport")]
impl From<SlipError> for Error {
    fn from(err: SlipError) -> Self {
        let conn_err: ConnectionError = err.into(); // uses first impl
        Self::Connection(Box::new(conn_err))
    }
}

#[cfg(feature = "serialport")]
impl From<io::Error> for Error {
    fn from(err: io::Error) -> Self {
        Self::Connection(err.into())
    }
}

#[cfg(feature = "serialport")]
#[cfg_attr(docsrs, doc(cfg(feature = "serialport")))]
impl From<serialport::Error> for Error {
    fn from(err: serialport::Error) -> Self {
        Self::Connection(err.into())
    }
}

impl From<TryFromSliceError> for Error {
    fn from(err: TryFromSliceError) -> Self {
        Self::TryFromSlice(Box::new(err))
    }
}

impl From<ParseIntError> for Error {
    fn from(err: ParseIntError) -> Self {
        Self::ParseIntError(Box::new(err))
    }
}

impl From<Utf8Error> for Error {
    fn from(err: Utf8Error) -> Self {
        Self::Utf8Error(Box::new(err))
    }
}

impl From<object::Error> for Error {
    fn from(err: object::Error) -> Self {
        Self::InvalidElf(err.into())
    }
}

impl From<AppDescriptorError> for Error {
    fn from(err: AppDescriptorError) -> Self {
        Self::InvalidAppDescriptor(Box::new(err))
    }
}

impl From<esp_idf_part::Error> for Error {
    fn from(err: esp_idf_part::Error) -> Self {
        Self::Partition(Box::new(err))
    }
}

#[cfg(feature = "cli")]
impl From<dialoguer::Error> for Error {
    fn from(err: dialoguer::Error) -> Self {
        Self::DialoguerError(err.into())
    }
}

/// App descriptor errors.
#[derive(Debug, Diagnostic, Error)]
#[non_exhaustive]
pub(crate) enum AppDescriptorError {
    #[error("Invalid app descriptor magic word: {0:#x}")]
    #[diagnostic(code(espflash::invalid_app_descriptor_magic_word))]
    MagicWordMismatch(u32),

    #[error("The app description segment is not aligned to any valid MMU page size.")]
    #[diagnostic(
        code(espflash::invalid_app_descriptor_alignment),
        help("Try specifying the MMU page size manually.")
    )]
    IncorrectDescriptorAlignment,
}

/// Connection-related errors.
#[derive(Debug, Diagnostic, Error)]
#[non_exhaustive]
#[cfg(feature = "serialport")]
pub(crate) enum ConnectionError {
    #[error("Failed to connect to the device")]
    #[diagnostic(
        code(espflash::connection_failed),
        help(
            "Ensure that the device is connected and the reset and boot pins are not being held down"
        )
    )]
    ConnectionFailed,

    #[error("Serial port not found")]
    #[diagnostic(
        code(espflash::connection_failed),
        help("Ensure that the device is connected and your host recognizes the serial adapter")
    )]
    DeviceNotFound,

    #[error("Received packet has invalid SLIP framing")]
    #[diagnostic(
        code(espflash::slip_framing),
        help(
            "Try hard-resetting the device and try again, if the error persists your ROM may be corrupted"
        )
    )]
    FramingError,

    #[error("Invalid stub handshake response received")]
    InvalidStubHandshake,

    #[error("Download mode successfully detected, but getting no sync reply")]
    #[diagnostic(
        code(espflash::no_sync_reply),
        help("The serial TX path seems to be down")
    )]
    NoSyncReply,

    #[error("Received packet too large for buffer")]
    #[diagnostic(
        code(espflash::oversized_packet),
        help(
            "Try hard-resetting the device and try again, if the error persists your ROM may be corrupted"
        )
    )]
    OverSizedPacket,

    #[error(
        "Failed to read the available bytes on the serial port. Available bytes: {0}, Read bytes: {1}"
    )]
    #[diagnostic(code(espflash::read_mismatch))]
    ReadMismatch(u32, u32),

    #[cfg(feature = "serialport")]
    #[error("Timeout while running {0}command")]
    #[diagnostic(code(espflash::timeout))]
    Timeout(TimedOutCommand),

    #[cfg(feature = "serialport")]
    #[error("IO error while using serial port: {0}")]
    #[diagnostic(code(espflash::serial_error))]
    Serial(#[source] serialport::Error),

    #[error("Wrong boot mode detected ({0})! The chip needs to be in download mode.")]
    #[diagnostic(code(espflash::wrong_boot_mode))]
    WrongBootMode(String),
}

#[cfg(feature = "serialport")]
impl From<io::Error> for ConnectionError {
    fn from(err: io::Error) -> Self {
        from_error_kind(err.kind(), err)
    }
}

#[cfg(feature = "serialport")]
#[cfg_attr(docsrs, doc(cfg(feature = "serialport")))]
impl From<serialport::Error> for ConnectionError {
    fn from(err: serialport::Error) -> Self {
        use serialport::ErrorKind;

        match err.kind() {
            ErrorKind::Io(kind) => from_error_kind(kind, err),
            ErrorKind::NoDevice => ConnectionError::DeviceNotFound,
            _ => ConnectionError::Serial(err),
        }
    }
}

#[cfg(feature = "serialport")]
impl From<SlipError> for ConnectionError {
    fn from(err: SlipError) -> Self {
        match err {
            SlipError::FramingError => Self::FramingError,
            SlipError::OversizedPacket => Self::OverSizedPacket,
            SlipError::ReadError(io) => Self::from(io),
            SlipError::EndOfStream => Self::FramingError,
        }
    }
}

/// An executed command which has timed out.
#[derive(Clone, Debug, Default)]
#[cfg(feature = "serialport")]
pub(crate) struct TimedOutCommand {
    command: Option<CommandType>,
}

#[cfg(feature = "serialport")]
impl Display for TimedOutCommand {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        match &self.command {
            Some(command) => write!(f, "{command} "),
            None => Ok(()),
        }
    }
}

#[cfg(feature = "serialport")]
impl From<CommandType> for TimedOutCommand {
    fn from(ct: CommandType) -> Self {
        TimedOutCommand { command: Some(ct) }
    }
}

/// Errors originating from a device's ROM functionality.
#[derive(Clone, Copy, Debug, Default, Diagnostic, Error, strum::FromRepr)]
#[non_exhaustive]
#[repr(u8)]
#[cfg(feature = "serialport")]
pub(crate) enum RomErrorKind {
    #[error("Invalid message received")]
    #[diagnostic(code(espflash::rom::invalid_message))]
    InvalidMessage = 0x05,

    #[error("Bootloader failed to execute command")]
    #[diagnostic(code(espflash::rom::failed))]
    FailedToAct = 0x06,

    #[error("Received message has invalid CRC")]
    #[diagnostic(code(espflash::rom::crc))]
    InvalidCrc = 0x07,

    #[error("Bootloader failed to write to flash")]
    #[diagnostic(code(espflash::rom::flash_write))]
    FlashWriteError = 0x08,

    #[error("Bootloader failed to read from flash")]
    #[diagnostic(code(espflash::rom::flash_read))]
    FlashReadError = 0x09,

    #[error("Invalid length for flash read")]
    #[diagnostic(code(espflash::rom::flash_read_length))]
    FlashReadLengthError = 0x0a,

    #[error("Malformed compressed data received")]
    #[diagnostic(code(espflash::rom::deflate))]
    DeflateError = 0x0b,

    #[error("Bad data length")]
    #[diagnostic(code(espflash::rom::data_len))]
    BadDataLen = 0xc0,

    #[error("Bad data checksum")]
    #[diagnostic(code(espflash::rom::data_crc))]
    BadDataChecksum = 0xc1,

    #[error("Bad block size")]
    #[diagnostic(code(espflash::rom::block_size))]
    BadBlocksize = 0xc2,

    #[error("Invalid command")]
    #[diagnostic(code(espflash::rom::cmd))]
    InvalidCommand = 0xc3,

    #[error("SPI operation failed")]
    #[diagnostic(code(espflash::rom::spi))]
    FailedSpiOp = 0xc4,

    #[error("SPI unlock failed")]
    #[diagnostic(code(espflash::rom::spi_unlock))]
    FailedSpiUnlock = 0xc5,

    #[error("Not in flash mode")]
    #[diagnostic(code(espflash::rom::flash_mode))]
    NotInFlashMode = 0xc6,

    #[error("Error when uncompressing the data")]
    #[diagnostic(code(espflash::rom::inflate))]
    InflateError = 0xc7,

    #[error("Didn't receive enough data")]
    #[diagnostic(code(espflash::rom::not_enough))]
    NotEnoughData = 0xc8,

    #[error("Received too much data")]
    #[diagnostic(code(espflash::rom::too_much_data))]
    TooMuchData = 0xc9,

    #[default]
    #[error("Other")]
    #[diagnostic(code(espflash::rom::other))]
    Other = 0xff,
}

#[cfg(feature = "serialport")]
impl From<u8> for RomErrorKind {
    fn from(raw: u8) -> Self {
        Self::from_repr(raw).unwrap_or_default()
    }
}

/// An error originating from a device's ROM functionality.
#[derive(Clone, Copy, Debug, Diagnostic, Error)]
#[error("Error while running {command} command")]
#[cfg(feature = "serialport")]
#[non_exhaustive]
pub(crate) struct RomError {
    command: CommandType,
    #[source]
    kind: RomErrorKind,
}

#[cfg(feature = "serialport")]
impl RomError {
    /// Create a new [RomError].
    pub(crate) fn new(command: CommandType, kind: RomErrorKind) -> RomError {
        RomError { command, kind }
    }
}

/// Missing partition error.
#[cfg(feature = "cli")]
#[derive(Debug, Diagnostic, Error)]
#[error("Missing partition")]
#[diagnostic(
    code(espflash::partition_table::missing_partition),
    help("Partition table must contain the partition of type `{0}` to be erased")
)]
pub(crate) struct MissingPartition(String);

#[cfg(feature = "cli")]
impl From<String> for MissingPartition {
    fn from(part: String) -> Self {
        MissingPartition(part)
    }
}

/// Missing partition table error.
#[cfg(feature = "cli")]
#[derive(Debug, Error, Diagnostic)]
#[error("No partition table could be found")]
#[diagnostic(
    code(espflash::partition_table::missing_partition_table),
    help("Try providing a CSV or binary partition table with the `--partition-table` argument.")
)]
pub(crate) struct MissingPartitionTable;

/// Extension helpers.
#[cfg(feature = "serialport")]
pub(crate) trait ResultExt {
    /// Mark an error as having occurred during the flashing stage.
    fn flashing(self) -> Self;
    /// Mark the command from which this error originates.
    fn for_command(self, command: CommandType) -> Self;
}

#[cfg(feature = "serialport")]
impl<T> ResultExt for Result<T, Error> {
    fn flashing(self) -> Self {
        match self {
            Err(Error::Connection(err)) => Err(Error::Flashing(err)),
            res => res,
        }
    }

    fn for_command(self, command: CommandType) -> Self {
        fn remap_if_timeout(err: CoreError, command: CommandType) -> CoreError {
            match err.downcast::<ConnectionError>() {
                Ok(boxed_ce) => match *boxed_ce {
                    ConnectionError::Timeout(_) => {
                        Box::new(ConnectionError::Timeout(command.into()))
                    }
                    other => Box::new(other),
                },
                Err(orig) => orig,
            }
        }

        match self {
            Err(Error::Connection(err)) => Err(Error::Connection(remap_if_timeout(err, command))),
            Err(Error::Flashing(err)) => Err(Error::Flashing(remap_if_timeout(err, command))),
            res => res,
        }
    }
}

#[cfg(feature = "serialport")]
#[cfg_attr(docsrs, doc(cfg(feature = "serialport")))]
fn from_error_kind<E>(kind: io::ErrorKind, err: E) -> ConnectionError
where
    E: Into<serialport::Error>,
{
    use io::ErrorKind;

    match kind {
        ErrorKind::TimedOut => ConnectionError::Timeout(TimedOutCommand::default()),
        ErrorKind::NotFound => ConnectionError::DeviceNotFound,
        _ => ConnectionError::Serial(err.into()),
    }
}