1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
use crate::error::{CaError, CaResult};
use crate::server::record::{FieldDesc, Record};
use crate::types::{DbFieldType, EpicsValue};
/// Which EPICS record-type name an [`ArrayRecord`] reports. The four
/// upstream array record types (`waveform`, `aai`, `aao`, `subArray`)
/// share the same scalar fields and DBR encoding; differentiation is
/// only at the record-type string and (for `aao`) the output-record
/// flag. Keeping them as one storage type avoids 1500 LOC of
/// duplication while preserving each type's identity to clients.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum ArrayKind {
Waveform,
Aai,
Aao,
SubArray,
}
impl ArrayKind {
pub fn as_record_type(self) -> &'static str {
match self {
Self::Waveform => "waveform",
Self::Aai => "aai",
Self::Aao => "aao",
Self::SubArray => "subArray",
}
}
/// `aao` is an output record (the framework calls `device.write`);
/// the rest are input. Drives [`Record::can_device_write`].
pub fn is_output(self) -> bool {
matches!(self, Self::Aao)
}
}
/// Waveform record — manual Record impl (no macro). Also serves as the
/// storage for `aai`, `aao`, and `subArray` since the four share their
/// scalar surface. The [`Self::kind`] field selects the reported
/// `record_type()` and the output/input distinction.
pub struct WaveformRecord {
pub kind: ArrayKind,
pub val: EpicsValue,
pub nelm: i32,
pub nord: i32,
pub ftvl: i16,
pub mpst: i16, // Monitor Post Mode: 0=Always, 1=OnChange
pub apst: i16, // Archive Post Mode: 0=Always, 1=OnChange
pub hash: u32, // Hash of array for OnChange detection
pub busy: bool, // Record is busy (async operation pending)
pub egu: String,
pub hopr: f64,
pub lopr: f64,
pub prec: i16,
/// subArray-only: starting offset into the source array. Out-of-
/// range values clamp to the source length; NORD=0 in that case.
/// Ignored when `kind != SubArray`.
pub indx: i32,
/// subArray-only: declared maximum length of the source array.
/// Used as an additional upper bound when computing the slice end:
/// `end = min(indx + nelm, min(source_len, malm))`. Defaults to 0
/// for non-subArray kinds — those records ignore the field
/// altogether.
pub malm: i32,
}
/// Type aliases for documentation / pattern-match clarity. All point
/// at [`WaveformRecord`] — runtime type discrimination is the
/// [`ArrayKind`] field.
pub type AaiRecord = WaveformRecord;
pub type AaoRecord = WaveformRecord;
pub type SubArrayRecord = WaveformRecord;
/// menuFtype constants for FTVL field.
const MENU_FTYPE_DOUBLE: i16 = 10;
impl Default for WaveformRecord {
fn default() -> Self {
Self {
kind: ArrayKind::Waveform,
val: EpicsValue::DoubleArray(Vec::new()),
nelm: 1,
nord: 0,
ftvl: MENU_FTYPE_DOUBLE,
mpst: 0,
apst: 0,
hash: 0,
busy: false,
egu: String::new(),
hopr: 0.0,
lopr: 0.0,
prec: 0,
indx: 0,
malm: 0,
}
}
}
impl WaveformRecord {
/// Construct an array record with an explicit [`ArrayKind`].
/// Lets `db_loader::create_record` mint `aai`, `aao`, or `subArray`
/// without needing distinct types per record-type name.
pub fn with_kind(kind: ArrayKind) -> Self {
Self {
kind,
..Default::default()
}
}
}
impl WaveformRecord {
pub fn new(nelm: i32, ftvl: DbFieldType) -> Self {
// Map DBR type to menuFtype index for the ftvl field.
// DBR and menuFtype have different numbering.
let (val, ftvl_idx) = match ftvl {
DbFieldType::Char => (EpicsValue::CharArray(vec![0; nelm as usize]), 1), // CHAR
DbFieldType::Short => (EpicsValue::ShortArray(vec![0; nelm as usize]), 3), // SHORT
DbFieldType::Long => (EpicsValue::LongArray(vec![0; nelm as usize]), 5), // LONG
DbFieldType::Float => (EpicsValue::FloatArray(vec![0.0; nelm as usize]), 9), // FLOAT
DbFieldType::Double => (EpicsValue::DoubleArray(vec![0.0; nelm as usize]), 10), // DOUBLE
_ => (EpicsValue::DoubleArray(vec![0.0; nelm as usize]), 10),
};
Self {
val,
nelm,
nord: 0,
ftvl: ftvl_idx,
..Default::default()
}
}
/// Reallocate VAL buffer to match current FTVL and NELM.
///
/// menuFtype indices: STRING=0, CHAR=1, UCHAR=2, SHORT=3, USHORT=4,
/// LONG=5, ULONG=6, INT64=7, UINT64=8, FLOAT=9, DOUBLE=10, ENUM=11
fn reallocate_val(&mut self) {
let n = self.nelm.max(0) as usize;
self.val = match self.ftvl {
1 | 2 => EpicsValue::CharArray(vec![0; n]), // CHAR, UCHAR
3 | 4 => EpicsValue::ShortArray(vec![0; n]), // SHORT, USHORT
5 | 6 => EpicsValue::LongArray(vec![0; n]), // LONG, ULONG
9 => EpicsValue::FloatArray(vec![0.0; n]), // FLOAT
_ => EpicsValue::DoubleArray(vec![0.0; n]), // DOUBLE, etc.
};
self.nord = 0;
}
}
static WAVEFORM_FIELDS_CHAR: &[FieldDesc] = &[
FieldDesc {
name: "VAL",
dbf_type: DbFieldType::Char,
read_only: false,
},
FieldDesc {
name: "NELM",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NORD",
dbf_type: DbFieldType::Long,
read_only: true,
},
FieldDesc {
name: "FTVL",
dbf_type: DbFieldType::Short,
read_only: false,
},
];
static WAVEFORM_FIELDS_SHORT: &[FieldDesc] = &[
FieldDesc {
name: "VAL",
dbf_type: DbFieldType::Short,
read_only: false,
},
FieldDesc {
name: "NELM",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NORD",
dbf_type: DbFieldType::Long,
read_only: true,
},
FieldDesc {
name: "FTVL",
dbf_type: DbFieldType::Short,
read_only: false,
},
];
static WAVEFORM_FIELDS_LONG: &[FieldDesc] = &[
FieldDesc {
name: "VAL",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NELM",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NORD",
dbf_type: DbFieldType::Long,
read_only: true,
},
FieldDesc {
name: "FTVL",
dbf_type: DbFieldType::Short,
read_only: false,
},
];
static WAVEFORM_FIELDS_FLOAT: &[FieldDesc] = &[
FieldDesc {
name: "VAL",
dbf_type: DbFieldType::Float,
read_only: false,
},
FieldDesc {
name: "NELM",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NORD",
dbf_type: DbFieldType::Long,
read_only: true,
},
FieldDesc {
name: "FTVL",
dbf_type: DbFieldType::Short,
read_only: false,
},
];
static WAVEFORM_FIELDS_DOUBLE: &[FieldDesc] = &[
FieldDesc {
name: "VAL",
dbf_type: DbFieldType::Double,
read_only: false,
},
FieldDesc {
name: "NELM",
dbf_type: DbFieldType::Long,
read_only: false,
},
FieldDesc {
name: "NORD",
dbf_type: DbFieldType::Long,
read_only: true,
},
FieldDesc {
name: "FTVL",
dbf_type: DbFieldType::Short,
read_only: false,
},
];
impl Record for WaveformRecord {
fn record_type(&self) -> &'static str {
self.kind.as_record_type()
}
/// `aao` is an output record; the rest of the array family read
/// from INP. Output records take the device-write path in
/// processing.rs (or fall through to the soft-link write when the
/// DTYP is empty / "Soft Channel").
fn can_device_write(&self) -> bool {
self.kind.is_output()
}
fn get_field(&self, name: &str) -> Option<EpicsValue> {
match name {
"VAL" => {
// Return only NORD valid elements, not the full NELM buffer.
// CA clients use the returned element count to interpret the
// data (e.g. PyDMImageView computes height = count / width).
let mut val = self.val.clone();
val.truncate(self.nord.max(0) as usize);
Some(val)
}
"NELM" => Some(EpicsValue::Long(self.nelm)),
"NORD" => Some(EpicsValue::Long(self.nord)),
"FTVL" => Some(EpicsValue::Short(self.ftvl)),
// subArray-specific INDX/MALM fields. Other array record
// kinds expose them as zero (matches C dbpr output for a
// record type that doesn't declare the field).
"INDX" if matches!(self.kind, ArrayKind::SubArray) => Some(EpicsValue::Long(self.indx)),
"MALM" if matches!(self.kind, ArrayKind::SubArray) => Some(EpicsValue::Long(self.malm)),
_ => None,
}
}
fn put_field(&mut self, name: &str, value: EpicsValue) -> CaResult<()> {
match name {
"VAL" => {
// Coerce value to match FTVL (e.g. String → CharArray for FTVL=CHAR)
let value = match (&value, self.ftvl) {
(EpicsValue::String(s), 1 | 2) => EpicsValue::CharArray(s.as_bytes().to_vec()),
_ => value,
};
// Update NORD based on actual data length, but keep array
// at NELM size to preserve CA channel element count.
let nelm = self.nelm.max(0) as usize;
match value {
EpicsValue::CharArray(mut arr) => {
self.nord = arr.len() as i32;
arr.resize(nelm, 0);
self.val = EpicsValue::CharArray(arr);
}
EpicsValue::ShortArray(mut arr) => {
self.nord = arr.len() as i32;
arr.resize(nelm, 0);
self.val = EpicsValue::ShortArray(arr);
}
EpicsValue::LongArray(mut arr) => {
self.nord = arr.len() as i32;
arr.resize(nelm, 0);
self.val = EpicsValue::LongArray(arr);
}
EpicsValue::FloatArray(mut arr) => {
self.nord = arr.len() as i32;
arr.resize(nelm, 0.0);
self.val = EpicsValue::FloatArray(arr);
}
EpicsValue::DoubleArray(mut arr) => {
self.nord = arr.len() as i32;
arr.resize(nelm, 0.0);
self.val = EpicsValue::DoubleArray(arr);
}
other => {
self.nord = 1;
self.val = other;
}
}
Ok(())
}
"NELM" => {
if let EpicsValue::Long(n) = value {
if n <= 0 {
return Err(CaError::InvalidValue(format!(
"NELM must be positive, got {n}"
)));
}
// C parity for subArray: clamp NELM <= MALM
// (subArrayRecord.c:310-311 in `readValue`,
// init at line 103-104). Other array kinds do
// not have MALM and are unaffected.
self.nelm = if matches!(self.kind, ArrayKind::SubArray) && self.malm > 0 {
n.min(self.malm)
} else {
n
};
self.reallocate_val();
Ok(())
} else {
Err(CaError::InvalidValue(format!(
"NELM requires Long, got {value:?}"
)))
}
}
"FTVL" => {
if let EpicsValue::Short(v) = value {
self.ftvl = v;
self.reallocate_val();
Ok(())
} else {
Err(CaError::InvalidValue(format!(
"FTVL requires Short, got {value:?}"
)))
}
}
"NORD" => Err(CaError::ReadOnlyField(name.to_string())),
"INDX" if matches!(self.kind, ArrayKind::SubArray) => {
let v = match value {
EpicsValue::Long(v) => v,
EpicsValue::Short(v) => v as i32,
_ => return Err(CaError::TypeMismatch("INDX".into())),
};
// C parity (subArrayRecord.c::readValue:313-314):
// `if (indx >= malm) indx = malm - 1`. When MALM is
// 0 (not yet configured) keep the legacy `max(0)`
// floor only.
let v = v.max(0);
self.indx = if self.malm > 0 {
v.min(self.malm - 1)
} else {
v
};
Ok(())
}
"MALM" if matches!(self.kind, ArrayKind::SubArray) => {
let v = match value {
EpicsValue::Long(v) => v,
EpicsValue::Short(v) => v as i32,
_ => return Err(CaError::TypeMismatch("MALM".into())),
};
self.malm = v.max(0);
// C parity (subArrayRecord.c::init_record:103-104):
// shrinking MALM below NELM also clamps NELM. Apply
// the same re-clamp on each MALM put.
if self.malm > 0 && self.nelm > self.malm {
self.nelm = self.malm;
}
if self.malm > 0 && self.indx >= self.malm {
self.indx = self.malm - 1;
}
Ok(())
}
_ => Err(CaError::FieldNotFound(name.to_string())),
}
}
fn field_list(&self) -> &'static [FieldDesc] {
match self.ftvl {
1 | 2 => WAVEFORM_FIELDS_CHAR,
3 | 4 => WAVEFORM_FIELDS_SHORT,
5 | 6 => WAVEFORM_FIELDS_LONG,
9 => WAVEFORM_FIELDS_FLOAT,
_ => WAVEFORM_FIELDS_DOUBLE,
}
}
/// epics-base PR #a02c310 follow-up: subArray slices its input
/// array on `set_val`. Effective slice = source[INDX .. INDX+NELM]
/// further capped by `min(source.len, MALM)` (MALM=0 → no extra
/// cap, matching C dbCommon defaults where the field is set by
/// the record initialiser). All other ArrayKind values delegate
/// to the trait's default `put_field("VAL", ...)` write.
fn set_val(&mut self, value: EpicsValue) -> CaResult<()> {
if !matches!(self.kind, ArrayKind::SubArray) {
return match self.put_field("VAL", value.clone()) {
Ok(()) => Ok(()),
Err(CaError::TypeMismatch(_)) => {
let target = self
.get_field("VAL")
.map(|v| v.db_field_type())
.unwrap_or(DbFieldType::Double);
let coerced = value.convert_to(target);
self.put_field("VAL", coerced)
}
Err(e) => Err(e),
};
}
let start = self.indx.max(0) as usize;
let take = self.nelm.max(0) as usize;
// MALM=0 keeps the legacy "no extra cap" behaviour. When set,
// it bounds how much of the source we're allowed to look at.
let malm_cap = if self.malm > 0 {
self.malm as usize
} else {
usize::MAX
};
let nelm_buf = take; // physical buffer is sized to NELM
macro_rules! slice {
($v:ident, $arr:ident, $variant:ident, $zero:expr) => {{
let src_len = $arr.len().min(malm_cap);
let end = (start + take).min(src_len);
let valid = if start >= src_len { 0 } else { end - start };
let mut out: Vec<_> = if valid > 0 {
$arr[start..end].to_vec()
} else {
Vec::new()
};
out.resize(nelm_buf, $zero);
self.nord = valid as i32;
self.val = EpicsValue::$variant(out);
}};
}
match value {
EpicsValue::CharArray(arr) => slice!(value, arr, CharArray, 0u8),
EpicsValue::ShortArray(arr) => slice!(value, arr, ShortArray, 0i16),
EpicsValue::LongArray(arr) => slice!(value, arr, LongArray, 0i32),
EpicsValue::FloatArray(arr) => slice!(value, arr, FloatArray, 0.0f32),
EpicsValue::DoubleArray(arr) => slice!(value, arr, DoubleArray, 0.0f64),
other => {
// Scalar fed into subArray (e.g. CA put of a single
// number): degrade to "NORD=1 at offset 0" semantics
// when INDX==0, else NORD=0. Matches what C does
// through dbScalarToArray.
if start == 0 {
self.nord = 1;
self.val = other;
} else {
self.nord = 0;
}
}
}
Ok(())
}
}
#[cfg(test)]
mod array_kind_tests {
use super::*;
#[test]
fn waveform_default_kind() {
let r = WaveformRecord::default();
assert_eq!(r.record_type(), "waveform");
assert!(!r.can_device_write(), "waveform is input-only");
}
#[test]
fn aai_record_type_and_input() {
let r = WaveformRecord::with_kind(ArrayKind::Aai);
assert_eq!(r.record_type(), "aai");
assert!(!r.can_device_write(), "aai is input");
}
#[test]
fn aao_is_output() {
let r = WaveformRecord::with_kind(ArrayKind::Aao);
assert_eq!(r.record_type(), "aao");
assert!(r.can_device_write(), "aao must take the device-write path");
}
#[test]
fn sub_array_record_type() {
let r = WaveformRecord::with_kind(ArrayKind::SubArray);
assert_eq!(r.record_type(), "subArray");
assert!(!r.can_device_write(), "subArray is input");
}
#[test]
fn aliases_resolve_to_waveform_record() {
// The type aliases are documentation-only; constructing
// through them must yield the same concrete struct.
let a: AaiRecord = WaveformRecord::with_kind(ArrayKind::Aai);
let b: AaoRecord = WaveformRecord::with_kind(ArrayKind::Aao);
let c: SubArrayRecord = WaveformRecord::with_kind(ArrayKind::SubArray);
assert_eq!(a.record_type(), "aai");
assert_eq!(b.record_type(), "aao");
assert_eq!(c.record_type(), "subArray");
}
/// PR #a02c310 follow-up: subArray slices source[INDX..INDX+NELM]
/// into VAL with NORD set to the actual copied length. Source
/// shorter than INDX → NORD=0. INDX+NELM > source.len → only
/// available tail is copied, rest zero-padded to NELM.
#[test]
fn subarray_slices_input_at_indx_with_nelm_take() {
let mut r = WaveformRecord::with_kind(ArrayKind::SubArray);
// 4-element double buffer; consume up to 4 from offset 2.
r.put_field("NELM", EpicsValue::Long(4)).unwrap();
r.put_field("INDX", EpicsValue::Long(2)).unwrap();
let source = EpicsValue::DoubleArray(vec![10.0, 11.0, 12.0, 13.0, 14.0, 15.0]);
r.set_val(source).unwrap();
assert_eq!(r.nord, 4, "should copy 4 elements from offset 2");
let val = r.get_field("VAL").unwrap();
if let EpicsValue::DoubleArray(v) = val {
assert_eq!(v, vec![12.0, 13.0, 14.0, 15.0]);
} else {
panic!("VAL should be DoubleArray, got {val:?}");
}
}
#[test]
fn subarray_indx_out_of_range_yields_nord_zero() {
let mut r = WaveformRecord::with_kind(ArrayKind::SubArray);
r.put_field("NELM", EpicsValue::Long(3)).unwrap();
r.put_field("INDX", EpicsValue::Long(10)).unwrap();
let source = EpicsValue::LongArray(vec![1, 2, 3]);
r.put_field("FTVL", EpicsValue::Short(5)).unwrap(); // LONG
r.set_val(source).unwrap();
assert_eq!(r.nord, 0, "INDX past source.len must zero NORD");
}
#[test]
fn subarray_partial_tail_zero_pads_to_nelm() {
let mut r = WaveformRecord::with_kind(ArrayKind::SubArray);
r.put_field("NELM", EpicsValue::Long(5)).unwrap();
r.put_field("INDX", EpicsValue::Long(3)).unwrap();
let source = EpicsValue::DoubleArray(vec![1.0, 2.0, 3.0, 4.0, 5.0]);
r.set_val(source).unwrap();
assert_eq!(r.nord, 2, "only 2 elements available from offset 3");
// get_field("VAL") truncates to NORD — caller-visible slice
// is only the 2 valid elements.
if let Some(EpicsValue::DoubleArray(v)) = r.get_field("VAL") {
assert_eq!(v, vec![4.0, 5.0]);
} else {
panic!("VAL must be DoubleArray of valid tail");
}
}
#[test]
fn subarray_malm_caps_visible_source_length() {
let mut r = WaveformRecord::with_kind(ArrayKind::SubArray);
r.put_field("NELM", EpicsValue::Long(4)).unwrap();
r.put_field("INDX", EpicsValue::Long(0)).unwrap();
// MALM caps how far into the source we look — even if the
// source has 8 elements, MALM=3 keeps us to indices [0..3).
r.put_field("MALM", EpicsValue::Long(3)).unwrap();
let source = EpicsValue::DoubleArray(vec![1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0]);
r.set_val(source).unwrap();
assert_eq!(r.nord, 3, "MALM=3 limits visible source to 3 elements");
if let Some(EpicsValue::DoubleArray(v)) = r.get_field("VAL") {
assert_eq!(v, vec![1.0, 2.0, 3.0]);
} else {
panic!("VAL truncated to MALM-bound prefix");
}
}
#[test]
fn subarray_indx_malm_fields_round_trip() {
let mut r = WaveformRecord::with_kind(ArrayKind::SubArray);
r.put_field("INDX", EpicsValue::Long(5)).unwrap();
r.put_field("MALM", EpicsValue::Long(100)).unwrap();
assert_eq!(r.get_field("INDX"), Some(EpicsValue::Long(5)));
assert_eq!(r.get_field("MALM"), Some(EpicsValue::Long(100)));
}
#[test]
fn waveform_does_not_expose_indx_malm() {
// Non-subArray record kinds must NOT expose INDX/MALM via the
// field map — those fields are subArray-specific.
let r = WaveformRecord::with_kind(ArrayKind::Waveform);
assert!(r.get_field("INDX").is_none());
assert!(r.get_field("MALM").is_none());
}
}