entrenar 0.7.11

Training & Optimization library with autograd, LoRA, quantization, and model merging
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
//! Model saving functionality

use super::format::{ModelFormat, SaveConfig};
use super::model::Model;
use crate::Tensor;
use crate::{Error, Result};
use safetensors::tensor::{Dtype, TensorView};
use std::collections::HashMap;
use std::fs::File;
use std::io::Write;
use std::path::Path;

/// Save a model to a file
///
/// # Arguments
///
/// * `model` - The model to save
/// * `path` - Output file path
/// * `config` - Save configuration (format, options)
///
/// # Example
///
/// ```no_run
/// use entrenar::io::{Model, ModelMetadata, save_model, SaveConfig, ModelFormat};
/// # use entrenar::Tensor;
///
/// let params = vec![
///     ("weight".to_string(), Tensor::from_vec(vec![1.0, 2.0], true)),
/// ];
/// let model = Model::new(ModelMetadata::new("my-model", "linear"), params);
/// let config = SaveConfig::new(ModelFormat::Json);
///
/// save_model(&model, "model.json", &config).expect("failed to save model");
/// ```
pub fn save_model(model: &Model, path: impl AsRef<Path>, config: &SaveConfig) -> Result<()> {
    let path = path.as_ref();

    match config.format {
        ModelFormat::SafeTensors => save_safetensors(model, path),
        ModelFormat::Apr => save_apr(model, path),
        ModelFormat::Json => save_json(model, path, config.pretty),
        ModelFormat::Yaml => save_yaml(model, path),
        #[cfg(feature = "gguf")]
        ModelFormat::Gguf => Err(Error::Serialization(
            "GGUF format not yet implemented. Enable 'gguf' feature and use realizar integration."
                .to_string(),
        )),
    }
}

/// Serialize and save a model as JSON
fn save_json(model: &Model, path: &Path, pretty: bool) -> Result<()> {
    let state = model.to_state();
    let data = if pretty {
        serde_json::to_string_pretty(&state)
            .map_err(|e| Error::Serialization(format!("JSON serialization failed: {e}")))?
    } else {
        serde_json::to_string(&state)
            .map_err(|e| Error::Serialization(format!("JSON serialization failed: {e}")))?
    };
    let mut file = File::create(path)?;
    file.write_all(data.as_bytes())?;
    Ok(())
}

/// Serialize and save a model as YAML
fn save_yaml(model: &Model, path: &Path) -> Result<()> {
    let state = model.to_state();
    let data = serde_yaml::to_string(&state)
        .map_err(|e| Error::Serialization(format!("YAML serialization failed: {e}")))?;
    let mut file = File::create(path)?;
    file.write_all(data.as_bytes())?;
    Ok(())
}

/// ALB-086: Infer tensor shapes using config-aware batch analysis.
/// Scans all parameters to find hidden_size from norm weights, then
/// computes proper 2D shapes for all weight matrices.
fn infer_all_tensor_shapes(parameters: &[(String, Tensor)]) -> HashMap<String, Vec<usize>> {
    let mut shapes = HashMap::new();

    // Find hidden_size from a norm weight (always 1D [H])
    let hidden_size = parameters
        .iter()
        .find(|(n, _)| n.ends_with("layernorm.weight") || n == "model.norm.weight")
        .map_or(0, |(_, t)| t.len());

    for (name, tensor) in parameters {
        let numel = tensor.len();
        let shape = if name.ends_with("layernorm.weight") || name == "model.norm.weight" {
            vec![numel]
        } else if hidden_size > 0 && numel % hidden_size == 0 {
            let other_dim = numel / hidden_size;
            // For down_proj: [hidden_size, intermediate_size] — hidden is smaller dim
            // For gate/up_proj: [intermediate_size, hidden_size] — hidden is smaller dim
            // For q/o_proj: [hidden_size, hidden_size] — square
            // For k/v_proj: [kv_dim, hidden_size] — kv_dim < hidden
            // For embed/lm_head: [vocab_size, hidden_size]
            if name.ends_with("down_proj.weight") {
                vec![hidden_size, other_dim]
            } else {
                vec![other_dim, hidden_size]
            }
        } else {
            vec![numel]
        };
        shapes.insert(name.clone(), shape);
    }
    shapes
}

/// Save model in SafeTensors format (HuggingFace compatible)
fn save_safetensors(model: &Model, path: &Path) -> Result<()> {
    // ALB-086: Compute proper 2D shapes for HuggingFace compatibility
    let shapes = infer_all_tensor_shapes(&model.parameters);

    // Collect tensor data with proper lifetime management
    let tensor_data: Vec<(String, Vec<u8>, Vec<usize>)> = model
        .parameters
        .iter()
        .map(|(name, tensor)| {
            let data = tensor.data();
            let bytes: Vec<u8> =
                bytemuck::cast_slice(data.as_slice().expect("tensor data must be contiguous"))
                    .to_vec();
            let shape = shapes.get(name).cloned().unwrap_or_else(|| vec![tensor.len()]);
            (name.clone(), bytes, shape)
        })
        .collect();

    // Create TensorViews from collected data
    let views: Vec<(&str, TensorView<'_>)> = tensor_data
        .iter()
        .map(|(name, bytes, shape)| {
            let view = TensorView::new(Dtype::F32, shape.clone(), bytes)
                .expect("TensorView construction must not fail for valid F32 data");
            (name.as_str(), view)
        })
        .collect();

    // Create metadata with model info
    let mut metadata = HashMap::new();
    metadata.insert("name".to_string(), model.metadata.name.clone());
    metadata.insert("architecture".to_string(), model.metadata.architecture.clone());
    metadata.insert("version".to_string(), model.metadata.version.clone());

    // Serialize to SafeTensors format
    let safetensor_bytes = safetensors::serialize(views, Some(metadata))
        .map_err(|e| Error::Serialization(format!("SafeTensors serialization failed: {e}")))?;

    // Write to file
    std::fs::write(path, safetensor_bytes)?;

    Ok(())
}

/// ALB-096: Save model in APR format (sovereign stack universal format).
///
/// Uses `AprWriter` for atomic single-file checkpoints with proper 2D shapes
/// and model metadata. Supports both model weights and `__training__.*` tensors.
fn save_apr(model: &Model, path: &Path) -> Result<()> {
    use aprender::serialization::apr::AprWriter;
    use serde_json::Value as JsonValue;

    let mut writer = AprWriter::new();

    // Embed model metadata (keys must match AprWriter's well-known key mapping)
    writer.set_metadata("model_name", JsonValue::String(model.metadata.name.clone()));
    writer.set_metadata("architecture", JsonValue::String(model.metadata.architecture.clone()));
    writer.set_metadata("version", JsonValue::String(model.metadata.version.clone()));
    writer.set_metadata("format", JsonValue::String("entrenar-checkpoint".into()));

    // Compute proper 2D shapes (same logic as SafeTensors — ALB-086)
    let shapes = infer_all_tensor_shapes(&model.parameters);

    for (name, tensor) in &model.parameters {
        let data = tensor.data();
        let slice = data.as_slice().expect("tensor data must be contiguous");
        let shape = shapes.get(name).cloned().unwrap_or_else(|| vec![tensor.len()]);
        writer.add_tensor_f32(name, shape, slice);
    }

    writer
        .write(path)
        .map_err(|e| Error::Serialization(format!("APR serialization failed: {e}")))?;

    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::io::{Model, ModelMetadata};
    use crate::Tensor;
    use tempfile::NamedTempFile;

    #[test]
    fn test_save_model_json() {
        let params = vec![
            ("weight".to_string(), Tensor::from_vec(vec![1.0, 2.0, 3.0], true)),
            ("bias".to_string(), Tensor::from_vec(vec![0.1], false)),
        ];

        let model = Model::new(ModelMetadata::new("test-model", "linear"), params);
        let config = SaveConfig::new(ModelFormat::Json);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Verify file was created and has content
        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(!content.is_empty());
        assert!(content.contains("test-model"));
        assert!(content.contains("linear"));
    }

    #[test]
    fn test_save_model_yaml() {
        let params = vec![("weight".to_string(), Tensor::from_vec(vec![1.0, 2.0], true))];

        let model = Model::new(ModelMetadata::new("test", "simple"), params);
        let config = SaveConfig::new(ModelFormat::Yaml);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.contains("test"));
        assert!(content.contains("simple"));
    }

    #[test]
    fn test_save_model_json_pretty() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("pretty-test", "test"), params);
        let config = SaveConfig::new(ModelFormat::Json).with_pretty(true);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        // Pretty JSON should have newlines
        assert!(content.contains('\n'));
    }

    #[test]
    fn test_save_model_json_compact() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("compact-test", "test"), params);
        let config = SaveConfig::new(ModelFormat::Json).with_pretty(false);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        // Compact JSON should be single line (minus trailing)
        let lines: Vec<&str> = content.lines().collect();
        assert_eq!(lines.len(), 1);
    }

    #[test]
    fn test_save_model_empty_params() {
        let model = Model::new(ModelMetadata::new("empty", "test"), vec![]);
        let config = SaveConfig::new(ModelFormat::Json);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.contains("empty"));
    }

    #[test]
    fn test_save_model_large_tensor() {
        let large_data: Vec<f32> = (0..1000).map(|i| i as f32 * 0.001).collect();
        let params = vec![("large".to_string(), Tensor::from_vec(large_data, false))];
        let model = Model::new(ModelMetadata::new("large", "test"), params);
        let config = SaveConfig::new(ModelFormat::Json);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.len() > 1000);
    }

    #[test]
    fn test_save_config_builder() {
        let config = SaveConfig::new(ModelFormat::Json).with_pretty(true);
        assert!(config.pretty);
        assert_eq!(config.format, ModelFormat::Json);
    }

    #[test]
    fn test_save_model_with_compress_option() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("compress-test", "test"), params);
        let config = SaveConfig::new(ModelFormat::Json).with_compress(true);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        // Currently compress is not implemented, but we can still save
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.contains("compress-test"));
    }

    #[test]
    fn test_save_model_multiple_tensors() {
        let params = vec![
            ("layer1.weight".to_string(), Tensor::from_vec(vec![1.0, 2.0], true)),
            ("layer1.bias".to_string(), Tensor::from_vec(vec![0.1], true)),
            ("layer2.weight".to_string(), Tensor::from_vec(vec![3.0, 4.0], false)),
        ];
        let model = Model::new(ModelMetadata::new("multi", "deep"), params);
        let config = SaveConfig::new(ModelFormat::Yaml);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.contains("layer1.weight"));
        assert!(content.contains("layer2.weight"));
    }

    #[test]
    fn test_save_model_with_metadata() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let meta = ModelMetadata::new("meta-test", "test")
            .with_custom("version", serde_json::json!("1.0.0"))
            .with_custom("author", serde_json::json!("test"));
        let model = Model::new(meta, params);
        let config = SaveConfig::new(ModelFormat::Json);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let content = std::fs::read_to_string(temp_file.path()).expect("file read should succeed");
        assert!(content.contains("version"));
    }

    #[test]
    fn test_save_config_default() {
        let config = SaveConfig::default();
        assert_eq!(config.format, ModelFormat::Json);
        assert!(config.pretty);
        assert!(!config.compress);
    }

    #[test]
    fn test_save_model_invalid_path() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("test", "test"), params);
        let config = SaveConfig::new(ModelFormat::Json);

        // Try to save to an invalid directory
        let result = save_model(&model, "/nonexistent/directory/model.json", &config);
        assert!(result.is_err());
    }

    #[test]
    fn test_save_model_safetensors() {
        let params = vec![
            ("weight".to_string(), Tensor::from_vec(vec![1.0, 2.0, 3.0], true)),
            ("bias".to_string(), Tensor::from_vec(vec![0.1], false)),
        ];

        let model = Model::new(ModelMetadata::new("safetensor-test", "linear"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Verify file was created and is binary (starts with safetensors magic)
        let content = std::fs::read(temp_file.path()).expect("file read should succeed");
        assert!(!content.is_empty());
        // SafeTensors files start with a header length (8 bytes)
        assert!(content.len() > 8);
    }

    #[test]
    fn test_save_model_safetensors_can_be_loaded() {
        let params = vec![
            ("layer1.weight".to_string(), Tensor::from_vec(vec![1.0, 2.0, 3.0, 4.0], true)),
            ("layer1.bias".to_string(), Tensor::from_vec(vec![0.5], false)),
        ];

        let model = Model::new(ModelMetadata::new("roundtrip-test", "mlp"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Verify we can load it back with safetensors crate
        let data = std::fs::read(temp_file.path()).expect("file read should succeed");
        let loaded = safetensors::SafeTensors::deserialize(&data).expect("load should succeed");

        // Check tensor names exist - names() returns Vec<&str>
        let names = loaded.names();
        assert!(names.contains(&"layer1.weight"));
        assert!(names.contains(&"layer1.bias"));

        // Check tensor data
        let weight = loaded.tensor("layer1.weight").expect("load should succeed");
        assert_eq!(weight.shape(), &[4]);
        let weight_data: &[f32] = bytemuck::cast_slice(weight.data());
        assert_eq!(weight_data, &[1.0, 2.0, 3.0, 4.0]);
    }

    #[test]
    fn test_save_safetensors_metadata() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("meta-model", "transformer"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Load and check metadata using read_metadata
        let data = std::fs::read(temp_file.path()).expect("file read should succeed");
        let (_, st_metadata) =
            safetensors::SafeTensors::read_metadata(&data).expect("deserialization should succeed");

        let metadata = st_metadata.metadata();
        assert!(metadata.is_some());
        let meta = metadata.as_ref().expect("operation should succeed");
        assert_eq!(meta.get("name").expect("key should exist"), "meta-model");
        assert_eq!(meta.get("architecture").expect("key should exist"), "transformer");
    }

    #[test]
    fn test_save_safetensors_large_tensor() {
        let large_data: Vec<f32> = (0..10000).map(|i| i as f32 * 0.001).collect();
        let params =
            vec![("large_weights".to_string(), Tensor::from_vec(large_data.clone(), false))];
        let model = Model::new(ModelMetadata::new("large", "test"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Verify data integrity
        let data = std::fs::read(temp_file.path()).expect("file read should succeed");
        let loaded = safetensors::SafeTensors::deserialize(&data).expect("load should succeed");
        let tensor = loaded.tensor("large_weights").expect("load should succeed");
        let tensor_data: &[f32] = bytemuck::cast_slice(tensor.data());
        assert_eq!(tensor_data.len(), 10000);
        assert!((tensor_data[0] - 0.0).abs() < 1e-6);
        assert!((tensor_data[9999] - 9.999).abs() < 1e-3);
    }

    #[test]
    fn test_save_safetensors_invalid_path() {
        let params = vec![("w".to_string(), Tensor::from_vec(vec![1.0], false))];
        let model = Model::new(ModelMetadata::new("test", "test"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let result = save_model(&model, "/nonexistent/directory/model.safetensors", &config);
        assert!(result.is_err());
    }

    #[test]
    fn test_save_safetensors_empty_params() {
        let model = Model::new(ModelMetadata::new("empty", "test"), vec![]);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        // Should still create valid file with metadata
        let data = std::fs::read(temp_file.path()).expect("file read should succeed");
        let loaded = safetensors::SafeTensors::deserialize(&data).expect("load should succeed");
        assert_eq!(loaded.len(), 0);
    }

    #[test]
    fn test_save_safetensors_multiple_tensors() {
        let params = vec![
            ("encoder.layer1.weight".to_string(), Tensor::from_vec(vec![1.0, 2.0], true)),
            ("encoder.layer1.bias".to_string(), Tensor::from_vec(vec![0.1], true)),
            ("encoder.layer2.weight".to_string(), Tensor::from_vec(vec![3.0, 4.0, 5.0], false)),
            ("decoder.layer1.weight".to_string(), Tensor::from_vec(vec![6.0, 7.0], false)),
        ];
        let model = Model::new(ModelMetadata::new("encoder-decoder", "transformer"), params);
        let config = SaveConfig::new(ModelFormat::SafeTensors);

        let temp_file = NamedTempFile::new().expect("temp file creation should succeed");
        save_model(&model, temp_file.path(), &config).expect("save should succeed");

        let data = std::fs::read(temp_file.path()).expect("file read should succeed");
        let loaded = safetensors::SafeTensors::deserialize(&data).expect("load should succeed");
        assert_eq!(loaded.len(), 4);

        // names() returns Vec<&str> directly
        let names = loaded.names();
        assert!(names.contains(&"encoder.layer1.weight"));
        assert!(names.contains(&"decoder.layer1.weight"));
    }

    /// ALB-086: Verify SafeTensors saves proper 2D shapes for LlamaForCausalLM weights.
    #[test]
    fn test_safetensors_saves_2d_shapes() {
        let hidden = 64;
        let intermediate = 128;
        let vocab = 256;

        let params = vec![
            ("model.embed_tokens.weight".to_string(), Tensor::zeros(vocab * hidden, false)),
            ("model.norm.weight".to_string(), Tensor::zeros(hidden, false)),
            ("model.layers.0.input_layernorm.weight".to_string(), Tensor::zeros(hidden, false)),
            (
                "model.layers.0.post_attention_layernorm.weight".to_string(),
                Tensor::zeros(hidden, false),
            ),
            (
                "model.layers.0.self_attn.q_proj.weight".to_string(),
                Tensor::zeros(hidden * hidden, false),
            ),
            (
                "model.layers.0.self_attn.k_proj.weight".to_string(),
                Tensor::zeros(16 * hidden, false),
            ),
            (
                "model.layers.0.self_attn.v_proj.weight".to_string(),
                Tensor::zeros(16 * hidden, false),
            ),
            (
                "model.layers.0.self_attn.o_proj.weight".to_string(),
                Tensor::zeros(hidden * hidden, false),
            ),
            (
                "model.layers.0.mlp.gate_proj.weight".to_string(),
                Tensor::zeros(intermediate * hidden, false),
            ),
            (
                "model.layers.0.mlp.up_proj.weight".to_string(),
                Tensor::zeros(intermediate * hidden, false),
            ),
            (
                "model.layers.0.mlp.down_proj.weight".to_string(),
                Tensor::zeros(hidden * intermediate, false),
            ),
        ];

        let metadata = ModelMetadata::new("test", "LlamaForCausalLM");
        let model = Model::new(metadata, params);
        let config =
            crate::io::format::SaveConfig::new(crate::io::format::ModelFormat::SafeTensors);
        let temp = NamedTempFile::new().unwrap();
        save_model(&model, temp.path(), &config).unwrap();

        let data = std::fs::read(temp.path()).unwrap();
        let loaded = safetensors::SafeTensors::deserialize(&data).unwrap();

        // Norm weights should be 1D
        assert_eq!(loaded.tensor("model.norm.weight").unwrap().shape(), &[hidden]);
        assert_eq!(
            loaded.tensor("model.layers.0.input_layernorm.weight").unwrap().shape(),
            &[hidden]
        );

        // Projection weights should be 2D
        assert_eq!(loaded.tensor("model.embed_tokens.weight").unwrap().shape(), &[vocab, hidden]);
        assert_eq!(
            loaded.tensor("model.layers.0.self_attn.q_proj.weight").unwrap().shape(),
            &[hidden, hidden]
        );
        assert_eq!(
            loaded.tensor("model.layers.0.self_attn.k_proj.weight").unwrap().shape(),
            &[16, hidden]
        );
        assert_eq!(
            loaded.tensor("model.layers.0.mlp.gate_proj.weight").unwrap().shape(),
            &[intermediate, hidden]
        );
        assert_eq!(
            loaded.tensor("model.layers.0.mlp.down_proj.weight").unwrap().shape(),
            &[hidden, intermediate]
        );
    }
}