emit_batcher 2.22.3

Batch processing infrastructure for emit.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
/*!
Run channels in a `tokio` runtime.
*/

use std::{
    future::Future,
    io,
    sync::Mutex,
    thread,
    time::{Duration, Instant},
};

use crate::{BatchError, Channel, Receiver, Sender, Wait, sync};

/**
Run [`Receiver::exec`] on a `tokio` runtime in a dedicated background thread.

This function will create a single-threaded `tokio` runtime on a dedicated thread.
*/
pub fn spawn<
    T: Channel + Send + 'static,
    F: Future<Output = Result<(), BatchError<T>>> + Send + 'static,
>(
    thread_name: impl Into<String>,
    receiver: Receiver<T>,
    on_batch: impl FnMut(T) -> F + Send + 'static,
) -> io::Result<thread::JoinHandle<()>>
where
    T::Item: Send + 'static,
{
    let receive = exec(receiver, on_batch);

    thread::Builder::new()
        .name(thread_name.into())
        .spawn(move || {
            tokio::runtime::Builder::new_current_thread()
                .enable_all()
                .build()
                .unwrap()
                .block_on(receive);
        })
}

/**
Run [`Receiver::exec`] on the current `tokio` runtime.
*/
pub async fn exec<T: Channel, F: Future<Output = Result<(), BatchError<T>>>>(
    receiver: Receiver<T>,
    on_batch: impl FnMut(T) -> F,
) {
    let shared = receiver.shared.clone();

    receiver
        .exec_inner(
            move |wait, delay| {
                let shared = shared.clone();

                async move {
                    match wait {
                        // Idle waits can be cut short by a sender notification
                        Wait::Idle => {
                            shared.receiver_notifier.tokio.wait_timeout(delay).await;
                        }
                        // Retry waits are backoff on a failing batch; don't cut them short
                        Wait::Retry => tokio::time::sleep(delay).await,
                    }
                }
            },
            on_batch,
        )
        .await
}

pub(crate) struct Trigger(tokio::sync::Notify, Mutex<Option<bool>>);

impl Trigger {
    pub fn new() -> Self {
        Trigger(tokio::sync::Notify::new(), Mutex::new(None))
    }

    pub fn trigger(&self, value: bool) {
        *self.1.lock().unwrap() = Some(value);
        self.0.notify_one()
    }

    pub async fn wait_timeout(&self, timeout: Duration) -> bool {
        let notified = self.0.notified();
        tokio::pin!(notified);

        notified.as_mut().enable();

        match tokio::time::timeout(timeout, notified).await {
            Ok(()) => self.1.lock().unwrap().take().unwrap_or(false),
            Err::<(), tokio::time::error::Elapsed>(_) => {
                self.1.lock().unwrap().take().unwrap_or(false)
            }
        }
    }
}

/**
Wait for a channel potentially running on a `tokio` thread to process all items active at the point this call was made.

If the current thread is a `tokio` thread then this call will be executed using [`tokio::task::block_in_place`] to avoid starving other work.
*/
pub fn blocking_flush<T: Channel>(sender: &Sender<T>, timeout: Duration) -> bool {
    match tokio::runtime::Handle::try_current() {
        // If we're on a `tokio` thread then await
        Ok(handle) => handle.block_on(flush(sender, timeout)),
        // If we're not on a `tokio` thread then run a regular blocking variant
        Err(_) => sync::blocking_flush(sender, timeout),
    }
}

/**
Wait for a channel potentially running on a `tokio` thread to process all items active at the point this call was made.

This function is an asynchronous variant of [`blocking_send`].
*/
pub async fn flush<T: Channel>(sender: &Sender<T>, timeout: Duration) -> bool {
    let (notifier, notified) = tokio::sync::oneshot::channel();

    sender.when_flushed_inner(move |flushed| {
        let _ = notifier.send(flushed);
    });

    wait(notified, timeout).await
}

/**
Wait for a channel to send a message, blocking if the channel is at capacity.
*/
pub fn blocking_send<T: Channel>(
    sender: &Sender<T>,
    msg: T::Item,
    timeout: Duration,
) -> Result<(), BatchError<T::Item>> {
    match tokio::runtime::Handle::try_current() {
        // If we're on a `tokio` thread then await
        Ok(handle) => handle.block_on(send(sender, msg, timeout)),
        // If we're not on a `tokio` thread then run a regular blocking variant
        Err(_) => sync::blocking_send(sender, msg, timeout),
    }
}

/**
Wait for a channel to send a message, blocking if the channel is at capacity.

This function is an asynchronous variant of [`blocking_send`].
*/
pub async fn send<T: Channel>(
    sender: &Sender<T>,
    msg: T::Item,
    timeout: Duration,
) -> Result<(), BatchError<T::Item>> {
    let start = Instant::now();

    sender
        .send_or_wait(
            msg,
            timeout,
            || start.elapsed(),
            |sender, timeout| async move {
                let (notifier, notified) = tokio::sync::oneshot::channel();

                sender.when_empty(move || {
                    let _ = notifier.send(true);
                });

                wait(notified, timeout).await;
            },
        )
        .await
}

async fn wait(mut notified: tokio::sync::oneshot::Receiver<bool>, timeout: Duration) -> bool {
    // If the trigger has already fired then return the value it fired with
    if let Ok(value) = notified.try_recv() {
        return value;
    }

    // If the timeout is 0 then return immediately
    // The trigger hasn't already fired so there's no point waiting for it
    if timeout == Duration::ZERO {
        return false;
    }

    match tokio::time::timeout(timeout, notified).await {
        // The notifier was triggered
        Ok(Ok(value)) => value,
        // Unexpected hangup; the notifier was dropped without firing so
        // the outcome is unknown; don't report success
        Ok(Err(_)) => false,
        // The timeout was reached instead
        Err(_) => false,
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    use std::sync::{Arc, Mutex};
    use tokio::sync::{Barrier, Semaphore, broadcast};

    use crate::TestBarriers;

    fn barrier() -> Arc<Barrier> {
        Arc::new(Barrier::new(2))
    }

    #[tokio::test]
    async fn async_send_recv_flush() {
        let received = Arc::new(Mutex::new(0));

        let (sender, receiver) = crate::bounded::<Vec<()>>(10);

        let _ = spawn("test_receiver", receiver, {
            let received = received.clone();

            move |batch| {
                let received = received.clone();

                async move {
                    *received.lock().unwrap() += batch.len();

                    Ok(())
                }
            }
        })
        .unwrap();

        for _ in 0..100 {
            send(&sender, (), Duration::from_secs(1))
                .await
                .map_err(|_| "failed to send")
                .unwrap();
        }

        flush(&sender, Duration::from_secs(1)).await;

        assert_eq!(100, *received.lock().unwrap());
    }

    #[tokio::test]
    async fn send_full_capacity() {
        let received = Arc::new(Mutex::new(Vec::new()));
        let post_process_barrier = barrier();

        let (sender, mut receiver) = crate::bounded::<Vec<i32>>(5);

        // Send more messages than capacity
        for i in 0..10 {
            sender.send(i);
        }

        receiver.test_barriers = TestBarriers {
            post_process: Some(post_process_barrier.clone()),
            ..Default::default()
        };

        // Spawn receiver after sending, with barrier after processing
        let _ = spawn("test_receiver", receiver, {
            let received = received.clone();
            move |batch| {
                let received = received.clone();
                async move {
                    received.lock().unwrap().extend(batch);
                    Ok(())
                }
            }
        })
        .unwrap();

        // Wait at barrier for receiver to finish processing
        post_process_barrier.wait().await;

        // Only last 5 messages should remain (0-4 were truncated)
        assert_eq!(vec![5, 6, 7, 8, 9], *received.lock().unwrap());
    }

    #[tokio::test]
    async fn async_send_full_capacity() {
        let received = Arc::new(Mutex::new(0));

        let (sender, receiver) = crate::bounded::<Vec<()>>(5);

        let _ = spawn("test_receiver", receiver, {
            let received = received.clone();
            move |batch| {
                let received = received.clone();
                async move {
                    *received.lock().unwrap() += batch.len();
                    Ok(())
                }
            }
        })
        .unwrap();

        // Send more messages than capacity using async send
        for _ in 0..10 {
            send(&sender, (), Duration::from_secs(1)).await.unwrap();
        }

        // Use flush to wait for all messages to be processed
        flush(&sender, Duration::from_secs(1)).await;

        // All 10 messages should be processed
        assert_eq!(10, *received.lock().unwrap());
    }

    #[tokio::test]
    async fn async_send_timeout() {
        // Channel to signal when receiver has taken a batch
        let (receiver_ready_tx, mut receiver_ready_rx) = broadcast::channel::<()>(100);
        // Semaphore with 0 permits - blocks forever (until cancelled)
        let blocker = Arc::new(Semaphore::new(0));

        let (sender, receiver) = crate::bounded::<Vec<i32>>(5);

        // Spawn receiver task that blocks after taking first batch
        let receiver_task = tokio::task::spawn(async move {
            exec(receiver, {
                let receiver_ready_tx = receiver_ready_tx.clone();
                let blocker = blocker.clone();
                move |_batch| {
                    let receiver_ready_tx = receiver_ready_tx.clone();
                    let blocker = blocker.clone();
                    async move {
                        // Signal that we've received a batch
                        let _ = receiver_ready_tx.send(());
                        // Block forever - acquire will never complete (until task is cancelled)
                        let _ = blocker.acquire().await;
                        Ok(())
                    }
                }
            })
            .await
        });

        // Fill the channel initially
        for i in 0..5 {
            sender.send(i);
        }

        // Wait for receiver to pick up the batch and signal
        receiver_ready_rx.recv().await.ok();

        // Now the channel is empty (receiver has it), fill it again
        for i in 0..5 {
            sender.send(i);
        }

        // Try to send with short timeout - should fail because channel is full
        let result = send(&sender, 99, Duration::from_millis(10)).await;
        assert!(result.is_err());

        // Clean up - abort the receiver task
        receiver_task.abort();
        let _ = receiver_task.await;
    }

    #[tokio::test]
    async fn flush_reports_failed_batch() {
        let (sender, receiver) = crate::bounded::<Vec<i32>>(10);

        let _ = spawn("test_receiver", receiver, |_| async {
            Err(BatchError::no_retry(std::io::Error::new(
                std::io::ErrorKind::Other,
                "explicit failure",
            )))
        })
        .unwrap();

        sender.send(1);

        // The batch is dropped after failing, so the flush must not report success
        assert!(!flush(&sender, Duration::from_secs(5)).await);
    }

    #[tokio::test]
    async fn flush_wakes_idle_receiver() {
        let received = Arc::new(Mutex::new(0));

        let (sender, receiver) = crate::bounded(10);

        let _ = spawn("test_receiver", receiver, {
            let received = received.clone();

            move |batch: Vec<()>| {
                let received = received.clone();

                async move {
                    *received.lock().unwrap() += batch.len();

                    Ok(())
                }
            }
        })
        .unwrap();

        for _ in 0..3 {
            // Let the receiver's idle backoff grow towards its maximum (500ms);
            // by 550ms in it's asleep inside a ~500ms delay
            tokio::time::sleep(Duration::from_millis(550)).await;

            sender.send(());

            // Without a wake the flush would have to wait out the remainder of the
            // receiver's idle delay, which is longer than this timeout
            assert!(flush(&sender, Duration::from_millis(200)).await);
        }

        assert_eq!(3, *received.lock().unwrap());
    }

    #[tokio::test]
    async fn flush_empty() {
        let (sender, receiver) = crate::bounded::<Vec<()>>(10);

        let _ = spawn("test_receiver", receiver, |batch| async move {
            let _ = batch;
            Ok(())
        })
        .unwrap();

        // Flush with zero timeout on empty channel should succeed immediately
        assert!(flush(&sender, Duration::ZERO).await);
    }

    #[tokio::test]
    async fn flush_active() {
        let batch_count = Arc::new(Mutex::new(0));
        // Channel to signal when receiver has taken first batch
        let (receiver_ready_tx, mut receiver_ready_rx) = broadcast::channel::<()>(100);

        let (sender, receiver) = crate::bounded::<Vec<i32>>(10);

        let _ = spawn("test_receiver", receiver, {
            let batch_count = batch_count.clone();
            let receiver_ready_tx = receiver_ready_tx.clone();
            move |_batch| {
                let batch_count = batch_count.clone();
                let receiver_ready_tx = receiver_ready_tx.clone();
                async move {
                    *batch_count.lock().unwrap() += 1;
                    // Signal that we've taken a batch
                    let _ = receiver_ready_tx.send(());
                    Ok(())
                }
            }
        })
        .unwrap();

        // Send initial batch
        for i in 0..3 {
            sender.send(i);
        }

        // Wait for receiver to pick up the batch
        receiver_ready_rx.recv().await.ok();

        // Send more messages (second batch)
        for i in 3..6 {
            sender.send(i);
        }

        // Flush should wait for both batches to complete
        let flushed = flush(&sender, Duration::from_secs(1)).await;
        assert!(flushed);

        // Both batches should have been processed
        assert_eq!(2, *batch_count.lock().unwrap());
    }

    #[tokio::test]
    async fn retry_on_batch_failure() {
        // Channel to signal when receiver has completed a batch
        let (receiver_processed_tx, mut receiver_processed_rx) = broadcast::channel::<()>(100);
        let attempt_count = Arc::new(Mutex::new(0));
        let received = Arc::new(Mutex::new(false));

        let (sender, receiver) = crate::bounded::<Vec<i32>>(10);

        let _ = spawn("test_receiver", receiver, {
            let attempt_count = attempt_count.clone();
            let received = received.clone();
            move |batch| {
                let attempt_count = attempt_count.clone();
                let received = received.clone();
                let receiver_processed_tx = receiver_processed_tx.clone();

                async move {
                    let mut count = attempt_count.lock().unwrap();
                    *count += 1;

                    // Fail first two attempts, succeed on third
                    if *count < 3 {
                        Err(BatchError::retry(
                            std::io::Error::new(std::io::ErrorKind::Other, "temporary failure"),
                            batch,
                        ))
                    } else {
                        *received.lock().unwrap() = true;
                        receiver_processed_tx.send(()).unwrap();

                        Ok(())
                    }
                }
            }
        })
        .unwrap();

        sender.send(42);

        // Wait for receiver to process the batch
        receiver_processed_rx.recv().await.ok();

        assert!(*received.lock().unwrap());
    }

    #[tokio::test]
    async fn processes_remaining_after_drop() {
        // Channel to signal when receiver has completed a batch
        let (receiver_processed_tx, mut receiver_processed_rx) = broadcast::channel::<()>(100);
        let received = Arc::new(Mutex::new(Vec::new()));
        let post_process_barrier = barrier();

        let (sender, mut receiver) = crate::bounded::<Vec<i32>>(10);

        receiver.test_barriers = TestBarriers {
            post_process: Some(post_process_barrier.clone()),
            ..Default::default()
        };

        let _ = spawn("test_receiver", receiver, {
            let received = received.clone();

            move |batch| {
                let received = received.clone();
                let receiver_processed_tx = receiver_processed_tx.clone();

                async move {
                    received.lock().unwrap().extend(batch);
                    receiver_processed_tx.send(()).unwrap();

                    Ok(())
                }
            }
        })
        .unwrap();

        // Send messages and drop sender
        for i in 0..5 {
            sender.send(i);
        }
        drop(sender);

        // Wait at barrier for receiver to finish processing
        post_process_barrier.wait().await;

        // Wait for receiver to process the batch
        receiver_processed_rx.recv().await.ok();

        // All messages should still be processed
        assert_eq!(vec![0, 1, 2, 3, 4], *received.lock().unwrap());
    }

    #[tokio::test]
    async fn try_send_behavior() {
        let pre_take_barrier = barrier();
        let post_process_barrier = barrier();

        let (sender, mut receiver) = crate::bounded::<Vec<i32>>(3);

        receiver.test_barriers = TestBarriers {
            pre_take: Some(pre_take_barrier.clone()),
            post_process: Some(post_process_barrier.clone()),
            ..Default::default()
        };

        let _ = spawn("test_receiver", receiver, |batch| async move {
            let _ = batch;
            Ok(())
        })
        .unwrap();

        // Up to capacity should succeed
        sender.try_send(1).unwrap();
        sender.try_send(2).unwrap();
        sender.try_send(3).unwrap();

        // Should fail when at capacity
        let result = sender.try_send(4);
        assert!(result.is_err());

        // Wait at barrier for receiver to finish processing
        pre_take_barrier.wait().await;
        post_process_barrier.wait().await;

        // Should succeed after processing
        sender.try_send(4).unwrap();
    }

    #[tokio::test]
    async fn try_send_on_closed_channel() {
        let (sender, receiver) = crate::bounded::<Vec<i32>>(10);

        // Drop the receiver to close the channel
        drop(receiver);

        // try_send should fail with a non-retryable error
        let result = sender.try_send(1);
        assert!(result.is_err());

        // Verify the error is non-retryable (no messages to retry)
        let err = result.err().unwrap();
        assert!(err.into_retryable().is_none());
    }

    #[tokio::test]
    async fn when_empty_callback() {
        let callback_fired = Arc::new(Mutex::new(false));
        let pre_take_barrier = barrier();
        let post_take_barrier = barrier();

        let (sender, mut receiver) = crate::bounded::<Vec<i32>>(10);

        receiver.test_barriers = TestBarriers {
            pre_take: Some(pre_take_barrier.clone()),
            post_take: Some(post_take_barrier.clone()),
            ..Default::default()
        };

        let _ = spawn("test_receiver", receiver, |_batch| async move { Ok(()) }).unwrap();

        // Send a message
        sender.send(1);

        sender.when_empty({
            let callback_fired = callback_fired.clone();

            move || {
                *callback_fired.lock().unwrap() = true;
            }
        });

        // Callback shouldn't fire yet (batch not taken)
        assert!(!*callback_fired.lock().unwrap());

        // Wait at barrier for batch to be taken and processed
        pre_take_barrier.wait().await;
        post_take_barrier.wait().await;

        // Callback should have fired
        assert!(*callback_fired.lock().unwrap());
    }

    #[tokio::test]
    async fn when_flushed_callback() {
        // Channel to signal when receiver has completed a batch
        let (when_flushed_tx, mut when_flushed_rx) = broadcast::channel::<()>(100);
        let callback_fired = Arc::new(Mutex::new(false));
        let post_process_barrier = barrier();

        let (sender, mut receiver) = crate::bounded::<Vec<i32>>(10);

        receiver.test_barriers = TestBarriers {
            post_process: Some(post_process_barrier.clone()),
            ..Default::default()
        };

        let _ = spawn("test_receiver", receiver, |_batch| async move { Ok(()) }).unwrap();

        // Send a message
        sender.send(1);

        let callback_fired_clone = callback_fired.clone();
        sender.when_flushed(move || {
            // Set the flag before signalling; the callback runs on the
            // receiver's thread, and the test resumes as soon as the signal
            // is sent
            *callback_fired_clone.lock().unwrap() = true;
            when_flushed_tx.send(()).unwrap();
        });

        // Callback shouldn't fire yet (batch not processed)
        assert!(!*callback_fired.lock().unwrap());

        // Wait at barrier for batch to be processed
        post_process_barrier.wait().await;

        when_flushed_rx.recv().await.ok();

        // Callback should have fired
        assert!(*callback_fired.lock().unwrap());
    }
}