elif-validation 0.2.0

Input validation system for the elif framework
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
//! Numeric value validators

use crate::error::{ValidationError, ValidationResult};
use crate::traits::ValidationRule;
use async_trait::async_trait;
use serde_json::Value;

/// Validator for numeric constraints
#[derive(Debug, Clone)]
pub struct NumericValidator {
    /// Minimum value (inclusive)
    pub min: Option<f64>,
    /// Maximum value (inclusive)
    pub max: Option<f64>,
    /// Allow only integers (no decimals)
    pub integer_only: bool,
    /// Allow only positive numbers (> 0)
    pub positive_only: bool,
    /// Allow only negative numbers (< 0)
    pub negative_only: bool,
    /// Custom error message
    pub message: Option<String>,
}

impl NumericValidator {
    /// Create a new numeric validator with default settings
    pub fn new() -> Self {
        Self {
            min: None,
            max: None,
            integer_only: false,
            positive_only: false,
            negative_only: false,
            message: None,
        }
    }

    /// Set minimum value constraint
    pub fn min(mut self, min: f64) -> Self {
        self.min = Some(min);
        self
    }

    /// Set maximum value constraint
    pub fn max(mut self, max: f64) -> Self {
        self.max = Some(max);
        self
    }

    /// Set value range (min and max)
    pub fn range(mut self, min: f64, max: f64) -> Self {
        self.min = Some(min);
        self.max = Some(max);
        self
    }

    /// Require integer values only (no decimals)
    pub fn integer_only(mut self, integer_only: bool) -> Self {
        self.integer_only = integer_only;
        self
    }

    /// Allow only positive numbers (> 0)
    pub fn positive_only(mut self, positive_only: bool) -> Self {
        self.positive_only = positive_only;
        if positive_only {
            self.negative_only = false;
        }
        self
    }

    /// Allow only negative numbers (< 0)
    pub fn negative_only(mut self, negative_only: bool) -> Self {
        self.negative_only = negative_only;
        if negative_only {
            self.positive_only = false;
        }
        self
    }

    /// Set custom error message
    pub fn message(mut self, message: impl Into<String>) -> Self {
        self.message = Some(message.into());
        self
    }

    /// Extract numeric value from JSON Value
    fn get_numeric_value(&self, value: &Value) -> Option<f64> {
        match value {
            Value::Number(num) => num.as_f64(),
            Value::String(s) => s.parse::<f64>().ok(),
            _ => None,
        }
    }

    /// Check if a number is an integer
    fn is_integer(&self, num: f64) -> bool {
        num.fract() == 0.0
    }

    /// Generate appropriate error message
    fn create_error_message(&self, field: &str, value: f64) -> String {
        if let Some(ref custom_message) = self.message {
            return custom_message.clone();
        }

        if self.positive_only && value <= 0.0 {
            return format!("{} must be a positive number", field);
        }

        if self.negative_only && value >= 0.0 {
            return format!("{} must be a negative number", field);
        }

        if self.integer_only && !self.is_integer(value) {
            return format!("{} must be an integer", field);
        }

        match (self.min, self.max) {
            (Some(min), Some(max)) if min == max => {
                format!("{} must equal {}", field, min)
            }
            (Some(min), Some(max)) => {
                format!("{} must be between {} and {}", field, min, max)
            }
            (Some(min), None) => {
                format!("{} must be at least {}", field, min)
            }
            (None, Some(max)) => {
                format!("{} must be at most {}", field, max)
            }
            (None, None) => {
                format!("{} has invalid numeric value: {}", field, value)
            }
        }
    }
}

impl Default for NumericValidator {
    fn default() -> Self {
        Self::new()
    }
}

#[async_trait]
impl ValidationRule for NumericValidator {
    async fn validate(&self, value: &Value, field: &str) -> ValidationResult<()> {
        // Skip validation for null values
        if value.is_null() {
            return Ok(());
        }

        let num = match self.get_numeric_value(value) {
            Some(n) => n,
            None => {
                return Err(ValidationError::with_code(
                    field,
                    format!("{} must be a numeric value", field),
                    "invalid_type",
                ).into());
            }
        };

        // Check for NaN or infinity
        if !num.is_finite() {
            return Err(ValidationError::with_code(
                field,
                format!("{} must be a finite number", field),
                "invalid_number",
            ).into());
        }

        // Check integer requirement
        if self.integer_only && !self.is_integer(num) {
            return Err(ValidationError::with_code(
                field,
                self.create_error_message(field, num),
                "not_integer",
            ).into());
        }

        // Check positive/negative requirements
        if self.positive_only && num <= 0.0 {
            return Err(ValidationError::with_code(
                field,
                self.create_error_message(field, num),
                "not_positive",
            ).into());
        }

        if self.negative_only && num >= 0.0 {
            return Err(ValidationError::with_code(
                field,
                self.create_error_message(field, num),
                "not_negative",
            ).into());
        }

        // Check minimum value
        if let Some(min) = self.min {
            if num < min {
                return Err(ValidationError::with_code(
                    field,
                    self.create_error_message(field, num),
                    "below_minimum",
                ).into());
            }
        }

        // Check maximum value
        if let Some(max) = self.max {
            if num > max {
                return Err(ValidationError::with_code(
                    field,
                    self.create_error_message(field, num),
                    "above_maximum",
                ).into());
            }
        }

        Ok(())
    }

    fn rule_name(&self) -> &'static str {
        "numeric"
    }

    fn parameters(&self) -> Option<Value> {
        let mut params = serde_json::Map::new();
        
        if let Some(min) = self.min {
            params.insert("min".to_string(), Value::Number(
                serde_json::Number::from_f64(min).unwrap_or(serde_json::Number::from(0))
            ));
        }
        if let Some(max) = self.max {
            params.insert("max".to_string(), Value::Number(
                serde_json::Number::from_f64(max).unwrap_or(serde_json::Number::from(0))
            ));
        }
        params.insert("integer_only".to_string(), Value::Bool(self.integer_only));
        params.insert("positive_only".to_string(), Value::Bool(self.positive_only));
        params.insert("negative_only".to_string(), Value::Bool(self.negative_only));
        
        if let Some(ref message) = self.message {
            params.insert("message".to_string(), Value::String(message.clone()));
        }

        Some(Value::Object(params))
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[tokio::test]
    async fn test_numeric_validator_basic() {
        let validator = NumericValidator::new();
        
        // Valid numbers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(42)), "age").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-10)), "temp").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from_f64(3.14).unwrap()), "pi").await.is_ok());
        
        // String representations of numbers
        assert!(validator.validate(&Value::String("42".to_string()), "age").await.is_ok());
        assert!(validator.validate(&Value::String("3.14".to_string()), "pi").await.is_ok());
        
        // Invalid types
        assert!(validator.validate(&Value::String("not-a-number".to_string()), "age").await.is_err());
        assert!(validator.validate(&Value::Bool(true), "age").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_min_max() {
        let validator = NumericValidator::new().range(0.0, 100.0);
        
        // Within range
        assert!(validator.validate(&Value::Number(serde_json::Number::from(50)), "score").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(0)), "score").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(100)), "score").await.is_ok());
        
        // Out of range
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-1)), "score").await.is_err());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(101)), "score").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_integer_only() {
        let validator = NumericValidator::new().integer_only(true);
        
        // Valid integers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(42)), "count").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(0)), "count").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-10)), "count").await.is_ok());
        
        // Invalid decimals
        assert!(validator.validate(&Value::Number(serde_json::Number::from_f64(3.14).unwrap()), "count").await.is_err());
        assert!(validator.validate(&Value::String("2.5".to_string()), "count").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_positive_only() {
        let validator = NumericValidator::new().positive_only(true);
        
        // Valid positive numbers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(1)), "amount").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from_f64(0.1).unwrap()), "amount").await.is_ok());
        
        // Invalid non-positive numbers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(0)), "amount").await.is_err());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-1)), "amount").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_negative_only() {
        let validator = NumericValidator::new().negative_only(true);
        
        // Valid negative numbers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-1)), "debt").await.is_ok());
        assert!(validator.validate(&Value::Number(serde_json::Number::from_f64(-0.1).unwrap()), "debt").await.is_ok());
        
        // Invalid non-negative numbers
        assert!(validator.validate(&Value::Number(serde_json::Number::from(0)), "debt").await.is_err());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(1)), "debt").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_combined_constraints() {
        let validator = NumericValidator::new()
            .range(1.0, 100.0)
            .integer_only(true)
            .positive_only(true);
        
        // Valid: positive integer in range
        assert!(validator.validate(&Value::Number(serde_json::Number::from(42)), "level").await.is_ok());
        
        // Invalid: decimal
        assert!(validator.validate(&Value::Number(serde_json::Number::from_f64(42.5).unwrap()), "level").await.is_err());
        
        // Invalid: out of range
        assert!(validator.validate(&Value::Number(serde_json::Number::from(0)), "level").await.is_err());
        assert!(validator.validate(&Value::Number(serde_json::Number::from(101)), "level").await.is_err());
        
        // Invalid: negative
        assert!(validator.validate(&Value::Number(serde_json::Number::from(-10)), "level").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_string_parsing() {
        let validator = NumericValidator::new().range(0.0, 10.0);
        
        // Valid string numbers
        assert!(validator.validate(&Value::String("5".to_string()), "rating").await.is_ok());
        assert!(validator.validate(&Value::String("7.5".to_string()), "rating").await.is_ok());
        assert!(validator.validate(&Value::String("0".to_string()), "rating").await.is_ok());
        
        // Invalid string numbers (out of range)
        assert!(validator.validate(&Value::String("-1".to_string()), "rating").await.is_err());
        assert!(validator.validate(&Value::String("11".to_string()), "rating").await.is_err());
        
        // Invalid string (not a number)
        assert!(validator.validate(&Value::String("not-a-number".to_string()), "rating").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_infinity_nan() {
        let validator = NumericValidator::new();
        
        // Test with infinity and NaN strings (should be rejected)
        assert!(validator.validate(&Value::String("inf".to_string()), "value").await.is_err());
        assert!(validator.validate(&Value::String("infinity".to_string()), "value").await.is_err());
        assert!(validator.validate(&Value::String("NaN".to_string()), "value").await.is_err());
    }

    #[tokio::test]
    async fn test_numeric_validator_custom_message() {
        let validator = NumericValidator::new()
            .min(18.0)
            .message("Must be at least 18 years old");
        
        let result = validator.validate(&Value::Number(serde_json::Number::from(16)), "age").await;
        assert!(result.is_err());
        
        let errors = result.unwrap_err();
        let field_errors = errors.get_field_errors("age").unwrap();
        assert_eq!(field_errors[0].message, "Must be at least 18 years old");
    }

    #[tokio::test]
    async fn test_numeric_validator_with_null() {
        let validator = NumericValidator::new().min(0.0);
        
        // Null values should be skipped
        let result = validator.validate(&Value::Null, "optional_number").await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_numeric_validator_error_codes() {
        let validator = NumericValidator::new()
            .range(0.0, 100.0)
            .integer_only(true)
            .positive_only(true);
        
        // Test below minimum error code
        let result = validator.validate(&Value::Number(serde_json::Number::from(-1)), "value").await;
        assert!(result.is_err());
        let errors = result.unwrap_err();
        assert_eq!(errors.errors["value"][0].code, "not_positive");
        
        // Test not integer error code
        let result = validator.validate(&Value::Number(serde_json::Number::from_f64(1.5).unwrap()), "value").await;
        assert!(result.is_err());
        let errors = result.unwrap_err();
        assert_eq!(errors.errors["value"][0].code, "not_integer");
        
        // Test above maximum error code
        let result = validator.validate(&Value::Number(serde_json::Number::from(101)), "value").await;
        assert!(result.is_err());
        let errors = result.unwrap_err();
        assert_eq!(errors.errors["value"][0].code, "above_maximum");
    }
}