elf_loader 0.16.0

A no_std-friendly ELF loader and runtime linker for Rust.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
use super::{
    ObjectBuilder, ObjectSections,
    layout::{SectionGroups, SectionSegments},
};
use crate::{
    Loader, LoaderRun, ParseShdrError, RelocationError, Result,
    elf::{ElfHeader, ElfLayout, ElfRelEntry, ElfRelType, ElfSectionType, ElfShdr},
    image::RawObject,
    input::{ElfReader, ElfReaderExt, IntoElfReader, PathBuf},
    loader::ExpectedElf,
    logging,
    observer::{AfterObjectLoadEvent, BeforeObjectLoadEvent, LoadObserver},
    os::Mmap,
    relocation::ObjectArch,
    runtime::CodeExecutor,
    sync::Arc,
    tls::TlsResolver,
};

impl<Obs, D, Tls, Arch, M, Exec> LoaderRun<'_, Obs, D, Tls, Arch, M, Exec>
where
    Obs: LoadObserver<D, Arch>,
    D: 'static,
    Tls: TlsResolver<Arch>,
    Arch: ObjectArch,
    M: Mmap,
    Exec: CodeExecutor<Arch> + Clone,
{
    /// Sets object section layout groups for this loader run.
    pub fn with_object_section_groups(mut self, groups: SectionGroups) -> Self {
        self.object_groups = Arc::new(groups);
        self
    }
}

impl<'run, Obs, D, Tls, Arch, M, Exec> LoaderRun<'run, Obs, D, Tls, Arch, M, Exec>
where
    Obs: LoadObserver<D, Arch>,
    D: Default + 'static,
    Tls: TlsResolver<Arch>,
    Arch: ObjectArch,
    M: Mmap,
    Exec: CodeExecutor<Arch> + Clone,
{
    /// Loads a relocatable object file into memory and prepares it for relocation.
    ///
    /// # Examples
    /// ```no_run
    /// use elf_loader::{Loader, input::ElfBinary};
    ///
    /// let mut loader = Loader::new();
    /// let bytes = &[]; // Relocatable ELF bytes
    /// let rel = loader.load_object(ElfBinary::new("liba.o", bytes)).unwrap();
    /// ```
    pub fn load_object<'a, I>(&mut self, input: I) -> Result<RawObject<D, Arch, M::Region, Tls>>
    where
        I: IntoElfReader<'a>,
    {
        let object = input.into_reader()?;
        logging::debug!("Loading object: {}", object.path());

        let ehdr = self.read_expected_ehdr(&object, ExpectedElf::Relocatable)?;
        self.load_object_from_ehdr(object, ehdr)
    }

    pub(crate) fn load_object_from_ehdr(
        &mut self,
        object: impl ElfReader,
        ehdr: ElfHeader<Arch::Layout>,
    ) -> Result<RawObject<D, Arch, M::Region, Tls>> {
        let shdrs =
            read_object_shdrs(&ehdr, &object)?.ok_or(ParseShdrError::MissingSectionHeaders)?;
        validate_object_shdrs::<Arch>(&ehdr, &shdrs, &object)?;
        let shstrtab = read_section_name_table(&ehdr, &shdrs, &object)?;
        let mut sections = ObjectSections::new(shdrs, shstrtab);
        let mut user_data = D::default();
        let path = PathBuf::from(object.path());
        let page_size = self.loader.page_size()?.bytes();
        let executor = self.loader.executor();
        let object_groups = Arc::clone(&self.object_groups);
        let observer = &mut self.observer;
        let mapper = self.loader.mapper();
        observer.on_before_object_load(BeforeObjectLoadEvent::new(
            &ehdr,
            &mut sections,
            &object,
            &mut user_data,
        ))?;
        let (section_segments, segments) = SectionSegments::<Arch>::load::<D, _, _>(
            &mut sections,
            &object,
            page_size,
            object_groups,
            observer,
            mapper,
        )?;
        let builder = ObjectBuilder::<Tls, D, Arch, M::Region>::new(
            path,
            sections,
            segments,
            section_segments,
            user_data,
            executor,
        )?;
        let mut raw = builder.build_object();
        observer.on_after_object_load(AfterObjectLoadEvent::new(&mut raw))?;
        let base = raw.base();

        logging::info!("Loaded object: {} at {}", raw.name(), base);

        Ok(raw)
    }
}

impl<D, Tls, Arch, M, Exec> Loader<D, Tls, Arch, M, Exec>
where
    (): LoadObserver<D, Arch>,
    D: Default + 'static,
    Tls: TlsResolver<Arch>,
    Arch: ObjectArch,
    M: Mmap,
    Exec: CodeExecutor<Arch> + Clone,
{
    /// Loads a relocatable object file into memory and prepares it for relocation.
    #[inline]
    pub fn load_object<'a, I>(&self, input: I) -> Result<RawObject<D, Arch, M::Region, Tls>>
    where
        I: IntoElfReader<'a>,
    {
        self.run().load_object(input)
    }
}

fn read_object_shdrs<L: ElfLayout>(
    ehdr: &ElfHeader<L>,
    object: &impl ElfReader,
) -> Result<Option<alloc::vec::Vec<ElfShdr<L>>>> {
    let Some((start, _size)) = ehdr.checked_shdr_layout(object.len())? else {
        return Ok(None);
    };
    object.read_to_vec(start, ehdr.e_shnum()).map(Some)
}

fn read_section_name_table<L: ElfLayout>(
    ehdr: &ElfHeader<L>,
    shdrs: &[ElfShdr<L>],
    object: &impl ElfReader,
) -> Result<alloc::vec::Vec<u8>> {
    let shstrtab = shdrs
        .get(ehdr.e_shstrndx())
        .ok_or_else(|| ParseShdrError::malformed("e_shstrndx is out of range"))?;
    object.read_to_vec(shstrtab.sh_offset(), shstrtab.sh_size())
}

fn validate_object_shdrs<Arch>(
    ehdr: &ElfHeader<Arch::Layout>,
    shdrs: &[ElfShdr<Arch::Layout>],
    object: &impl ElfReader,
) -> Result<()>
where
    Arch: ObjectArch,
{
    let first = shdrs.first().ok_or(ParseShdrError::MissingSectionHeaders)?;
    if first.section_type() != ElfSectionType::NULL || first.sh_size() != 0 {
        return Err(
            ParseShdrError::malformed("section 0 must be an empty SHT_NULL section").into(),
        );
    }

    let mut has_symtab = false;
    let shstrtab = shdrs
        .get(ehdr.e_shstrndx())
        .ok_or_else(|| ParseShdrError::malformed("e_shstrndx is out of range"))?;
    let shstrtab_size = shstrtab.sh_size();
    if shstrtab_size == 0 {
        return Err(ParseShdrError::malformed("section name string table is empty").into());
    }
    for shdr in shdrs {
        match shdr.section_type() {
            ElfSectionType::SYMTAB => has_symtab = true,
            ElfSectionType::REL | ElfSectionType::RELA => {
                validate_relocation_shdr::<Arch>(shdr, shdrs)?
            }
            _ => {}
        }

        if shdr.sh_name() as usize >= shstrtab_size {
            return Err(ParseShdrError::malformed(
                "section name offset exceeds section name string table",
            )
            .into());
        }
    }

    let object_len = object.len();
    for shdr in shdrs {
        if shdr.sh_size() == 0 || shdr.section_type() == ElfSectionType::NOBITS {
            continue;
        }
        let end = shdr
            .sh_offset()
            .checked_add(shdr.sh_size())
            .ok_or_else(|| ParseShdrError::malformed("section content range overflows"))?;
        if end > object_len {
            return Err(ParseShdrError::malformed("section content exceeds object length").into());
        }
    }

    let last = shstrtab
        .sh_offset()
        .checked_add(shstrtab_size - 1)
        .ok_or_else(|| ParseShdrError::malformed("section name string table range overflows"))?;
    let mut last_byte = [0];
    object.read(&mut last_byte, last)?;
    if last_byte[0] != 0 {
        return Err(
            ParseShdrError::malformed("section name string table must end with NUL").into(),
        );
    }

    if !has_symtab {
        return Err(RelocationError::MissingSymbolTable.into());
    }

    Ok(())
}

fn validate_relocation_shdr<Arch>(
    shdr: &ElfShdr<Arch::Layout>,
    shdrs: &[ElfShdr<Arch::Layout>],
) -> Result<()>
where
    Arch: ObjectArch,
{
    debug_assert!(matches!(
        shdr.section_type(),
        ElfSectionType::REL | ElfSectionType::RELA
    ));

    if shdr.section_type() != <ElfRelType<Arch> as ElfRelEntry<Arch::Layout>>::SECTION_TYPE {
        return Err(ParseShdrError::malformed(
            "relocation section type does not match target architecture",
        )
        .into());
    }

    shdrs
        .get(shdr.sh_info() as usize)
        .ok_or_else(|| ParseShdrError::malformed("relocation target section is out of range"))?;

    Ok(())
}

#[cfg(test)]
mod tests {
    use crate::elf::{ElfHeader, ElfShdr, ElfSymbol};
    use crate::{
        Loader, Result,
        elf::{ElfEhdr, ElfLayout, ElfSectionFlags, ElfSectionId, ElfSectionType, NativeElfLayout},
        input::{ElfBinary, ElfReader, Path},
        memory::RegionAccess,
        observer::{AfterObjectLoadEvent, BeforeObjectLoadEvent, LoadObserver},
        relocation::RelocationArch,
        tls::TlsResolver,
    };
    use alloc::vec::Vec;
    use core::mem::size_of;
    use elf::abi::{EI_CLASS, EI_DATA, EI_VERSION, ELFMAGIC, ET_REL, EV_CURRENT};

    struct TestReader {
        bytes: Vec<u8>,
    }

    #[derive(Default)]
    struct ObjectData {
        shstrtab: Option<ElfSectionId>,
    }

    #[derive(Default)]
    struct ObjectObserver {
        found_shstrtab: Option<ElfSectionId>,
        shstrtab_name_seen: bool,
        shstrtab_len: usize,
        borrowed_shstrtab: bool,
        renamed_shstrtab: bool,
        after_object_name_seen: bool,
        after_object_load_seen: bool,
    }

    impl LoadObserver<ObjectData> for ObjectObserver {
        fn on_before_object_load(
            &mut self,
            mut event: BeforeObjectLoadEvent<'_, ObjectData, NativeElfLayout>,
        ) -> Result<()> {
            let shstrtab = event.find_section(".shstrtab");
            event.user_data_mut().shstrtab = shstrtab;
            self.found_shstrtab = shstrtab;
            self.shstrtab_name_seen = shstrtab
                .map(|index| event.section_name(index))
                .is_some_and(|name| name.to_bytes() == b".shstrtab");
            self.borrowed_shstrtab = shstrtab
                .map(|index| {
                    event
                        .borrow_section_bytes(index)
                        .map(|bytes| bytes.is_some())
                })
                .transpose()?
                .unwrap_or(false);
            let mut scratch = Vec::new();
            self.shstrtab_len = shstrtab
                .map(|index| event.with_section_bytes(index, &mut scratch, |bytes| Ok(bytes.len())))
                .transpose()?
                .unwrap_or_default();
            if let Some(index) = shstrtab {
                let shdr = event.section_mut(index);
                shdr.set_sh_name(0);
            }
            self.renamed_shstrtab = shstrtab
                .map(|index| event.section_name(index))
                .is_some_and(|name| name.to_bytes().is_empty());
            Ok(())
        }

        fn on_after_object_load<R: RegionAccess, Tls: TlsResolver<crate::arch::NativeArch>>(
            &mut self,
            event: AfterObjectLoadEvent<'_, ObjectData, crate::arch::NativeArch, R, Tls>,
        ) -> Result<()> {
            self.after_object_name_seen = event.raw().name() == "metadata.o";
            self.after_object_load_seen = true;
            Ok(())
        }
    }

    impl TestReader {
        fn zeroed(size: usize) -> Self {
            Self {
                bytes: alloc::vec![0; size],
            }
        }
    }

    impl ElfReader for TestReader {
        fn path(&self) -> &Path {
            Path::new("<test>")
        }

        fn len(&self) -> usize {
            self.bytes.len()
        }

        fn read(&self, buf: &mut [u8], offset: usize) -> Result<()> {
            buf.copy_from_slice(&self.bytes[offset..offset + buf.len()]);
            Ok(())
        }

        fn as_fd(&self) -> Option<isize> {
            None
        }
    }

    fn make_object_header(shentsize: usize, shnum: usize) -> ElfHeader {
        let ehdr = make_raw_object_header(shentsize, shnum);

        ElfHeader::from_raw(ehdr, Some(crate::arch::NativeArch::MACHINE))
            .expect("failed to parse crafted object header")
    }

    fn make_raw_object_header(shentsize: usize, shnum: usize) -> ElfEhdr {
        let mut ehdr = unsafe { core::mem::zeroed::<ElfEhdr>() };
        ehdr.e_ident[0..4].copy_from_slice(&ELFMAGIC);
        ehdr.e_ident[EI_CLASS] = <NativeElfLayout as ElfLayout>::E_CLASS;
        ehdr.e_ident[EI_DATA] = <NativeElfLayout as ElfLayout>::DATA_ENCODING.raw();
        ehdr.e_ident[EI_VERSION] = EV_CURRENT;
        ehdr.e_type = ET_REL as _;
        ehdr.e_machine = crate::arch::NativeArch::MACHINE.raw();
        ehdr.e_version = EV_CURRENT.into();
        ehdr.e_ehsize = <NativeElfLayout as ElfLayout>::EHDR_SIZE as _;
        ehdr.e_shoff = <NativeElfLayout as ElfLayout>::EHDR_SIZE as _;
        ehdr.e_shentsize = shentsize as _;
        ehdr.e_shnum = shnum as _;

        ehdr
    }

    fn write_value<T>(bytes: &mut [u8], offset: usize, value: &T) {
        let raw = unsafe {
            core::slice::from_raw_parts((value as *const T).cast::<u8>(), size_of::<T>())
        };
        bytes[offset..offset + raw.len()].copy_from_slice(raw);
    }

    fn write_bytes(bytes: &mut [u8], offset: usize, value: &[u8]) {
        bytes[offset..offset + value.len()].copy_from_slice(value);
    }

    fn make_two_section_object(shstrtab: &[u8], shstrtab_name: u32) -> Vec<u8> {
        let ehdr_size = <NativeElfLayout as ElfLayout>::EHDR_SIZE;
        let shdr_size = size_of::<ElfShdr>();
        let shstrtab_offset = ehdr_size + shdr_size * 2;
        let mut bytes = alloc::vec![0u8; shstrtab_offset + shstrtab.len()];

        let mut ehdr = make_raw_object_header(shdr_size, 2);
        ehdr.e_shstrndx = 1;
        write_value(&mut bytes, 0, &ehdr);

        let null_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            0,
            ElfSectionType::NULL,
            ElfSectionFlags::empty(),
            0,
            0,
            0,
            0,
            0,
            0,
            0,
        );
        let shstrtab_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            shstrtab_name,
            ElfSectionType::STRTAB,
            ElfSectionFlags::empty(),
            0,
            shstrtab_offset,
            shstrtab.len(),
            0,
            0,
            1,
            0,
        );
        write_value(&mut bytes, ehdr_size, &null_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size, &shstrtab_shdr);
        write_bytes(&mut bytes, shstrtab_offset, shstrtab);

        bytes
    }

    fn make_metadata_object() -> Vec<u8> {
        const SYMTAB_NAME: u32 = 1;
        const STRTAB_NAME: u32 = 9;
        const SHSTRTAB_NAME: u32 = 17;

        let ehdr_size = <NativeElfLayout as ElfLayout>::EHDR_SIZE;
        let shdr_size = size_of::<ElfShdr>();
        let sym_size = size_of::<ElfSymbol>();
        let strtab = b"\0";
        let shstrtab = b"\0.symtab\0.strtab\0.shstrtab\0";
        let symtab_offset = ehdr_size + shdr_size * 4;
        let strtab_offset = symtab_offset + sym_size;
        let shstrtab_offset = strtab_offset + strtab.len();
        let mut bytes = alloc::vec![0u8; shstrtab_offset + shstrtab.len()];

        let mut ehdr = make_raw_object_header(shdr_size, 4);
        ehdr.e_shstrndx = 3;
        write_value(&mut bytes, 0, &ehdr);

        let null_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            0,
            ElfSectionType::NULL,
            ElfSectionFlags::empty(),
            0,
            0,
            0,
            0,
            0,
            0,
            0,
        );
        let symtab_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            SYMTAB_NAME,
            ElfSectionType::SYMTAB,
            ElfSectionFlags::empty(),
            0,
            symtab_offset,
            sym_size,
            2,
            1,
            size_of::<usize>(),
            sym_size,
        );
        let strtab_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            STRTAB_NAME,
            ElfSectionType::STRTAB,
            ElfSectionFlags::empty(),
            0,
            strtab_offset,
            strtab.len(),
            0,
            0,
            1,
            0,
        );
        let shstrtab_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            SHSTRTAB_NAME,
            ElfSectionType::STRTAB,
            ElfSectionFlags::empty(),
            0,
            shstrtab_offset,
            shstrtab.len(),
            0,
            0,
            1,
            0,
        );
        let null_sym: ElfSymbol<NativeElfLayout> = unsafe { core::mem::zeroed() };

        write_value(&mut bytes, ehdr_size, &null_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size, &symtab_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size * 2, &strtab_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size * 3, &shstrtab_shdr);
        write_value(&mut bytes, symtab_offset, &null_sym);
        write_bytes(&mut bytes, strtab_offset, strtab);
        write_bytes(&mut bytes, shstrtab_offset, shstrtab);

        bytes
    }

    #[test]
    fn prepare_shdrs_rejects_entry_size_mismatch() {
        let header = make_object_header(size_of::<ElfShdr>() + 8, 1);
        let reader = TestReader::zeroed(512);

        let err = super::read_object_shdrs(&header, &reader)
            .expect_err("shdr entry size mismatch should fail");
        assert!(matches!(
            err,
            crate::Error::ParseShdr(crate::ParseShdrError::InvalidEntrySize { .. })
        ));
    }

    #[test]
    fn prepare_shdrs_rejects_table_past_object_len() {
        let header = make_object_header(size_of::<ElfShdr>(), 2);
        let reader =
            TestReader::zeroed(<NativeElfLayout as ElfLayout>::EHDR_SIZE + size_of::<ElfShdr>());

        let err = super::read_object_shdrs(&header, &reader)
            .expect_err("shdr table past object length should fail");
        assert!(matches!(
            err,
            crate::Error::Io(crate::IoError::ReadOutOfBounds(_))
        ));
    }

    #[test]
    fn load_object_rejects_section_content_past_object_len() {
        let ehdr_size = <NativeElfLayout as ElfLayout>::EHDR_SIZE;
        let shdr_size = size_of::<ElfShdr>();
        let shstrtab = b"\0.text\0.shstrtab\0";
        let shstrtab_offset = ehdr_size + shdr_size * 3;
        let mut bytes = alloc::vec![0u8; shstrtab_offset + shstrtab.len()];

        let mut ehdr = make_raw_object_header(shdr_size, 3);
        ehdr.e_shstrndx = 2;
        write_value(&mut bytes, 0, &ehdr);

        let null_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            0,
            ElfSectionType::NULL,
            ElfSectionFlags::empty(),
            0,
            0,
            0,
            0,
            0,
            0,
            0,
        );
        let content_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            1,
            ElfSectionType::PROGBITS,
            ElfSectionFlags::empty(),
            0,
            bytes.len() - 4,
            8,
            0,
            0,
            1,
            0,
        );
        let shstrtab_shdr: ElfShdr<NativeElfLayout> = ElfShdr::new(
            7,
            ElfSectionType::STRTAB,
            ElfSectionFlags::empty(),
            0,
            shstrtab_offset,
            shstrtab.len(),
            0,
            0,
            1,
            0,
        );
        write_value(&mut bytes, ehdr_size, &null_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size, &content_shdr);
        write_value(&mut bytes, ehdr_size + shdr_size * 2, &shstrtab_shdr);
        write_bytes(&mut bytes, shstrtab_offset, shstrtab);

        let loader = Loader::new();
        let result = loader.load_object(ElfBinary::owned("bad.o", bytes));
        assert!(matches!(
            result,
            Err(crate::Error::ParseShdr(
                crate::ParseShdrError::Malformed { .. }
            ))
        ));
    }

    #[test]
    fn load_object_rejects_section_name_table_without_nul() {
        let loader = Loader::new();
        let result = loader.load_object(ElfBinary::owned(
            "bad.o",
            make_two_section_object(b"\0.shstrtab", 1),
        ));
        assert!(matches!(
            result,
            Err(crate::Error::ParseShdr(
                crate::ParseShdrError::Malformed { .. }
            ))
        ));
    }

    #[test]
    fn load_object_rejects_section_name_offset_past_table() {
        let loader = Loader::new();
        let result =
            loader.load_object(ElfBinary::owned("bad.o", make_two_section_object(b"\0", 1)));
        assert!(matches!(
            result,
            Err(crate::Error::ParseShdr(
                crate::ParseShdrError::Malformed { .. }
            ))
        ));
    }

    #[test]
    fn load_object_notifies_object_load_observers() {
        let mut observer = ObjectObserver::default();
        let loader = Loader::new().with_data::<ObjectData>();
        let mut run = loader.run().with_observer(&mut observer);

        let _ = run.load_object(ElfBinary::owned("metadata.o", make_metadata_object()));
        drop(run);

        assert_eq!(observer.found_shstrtab, Some(ElfSectionId::new(3)));
        assert!(observer.shstrtab_name_seen);
        assert_eq!(
            observer.shstrtab_len,
            b"\0.symtab\0.strtab\0.shstrtab\0".len()
        );
        assert!(observer.borrowed_shstrtab);
        assert!(observer.renamed_shstrtab);
        assert!(observer.after_object_name_seen);
        assert!(observer.after_object_load_seen);
    }
}