eidetica 0.2.0

Decentralized DB. Remember Everything. Everywhere. All At Once.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
//! System database initialization for the user system
//!
//! Creates and manages _users and _databases system databases.

use handle_trait::Handle;

use super::{
    User,
    crypto::{current_timestamp, derive_encryption_key, encrypt_private_key, hash_password},
    errors::UserError,
    key_manager::UserKeyManager,
    types::{KeyEncryption, UserInfo, UserKey, UserStatus},
};
use crate::{
    Database, Instance, Result,
    auth::{
        crypto::generate_keypair,
        settings::AuthSettings,
        types::{AuthKey, Permission},
    },
    constants::{DATABASES, INSTANCE, USERS},
    crdt::Doc,
    store::Table,
};

/// Create the _instance system database
///
/// This database stores Instance-level configuration and metadata.
/// It is authenticated with the Instance's _device_key.
///
/// # Arguments
/// * `instance` - The Instance handle
/// * `device_signing_key` - The device's Ed25519 signing key
/// * `device_pubkey` - The public key for _device_key (used as admin)
///
/// # Returns
/// The _instance Database
pub fn create_instance_database(
    instance: &Instance,
    device_signing_key: &ed25519_dalek::SigningKey,
    device_pubkey: &str,
) -> Result<Database> {
    // Create database settings
    let mut settings = Doc::new();
    settings.set_string("name", INSTANCE);
    settings.set_string("type", "system");
    settings.set_string("description", "Instance configuration and management");

    // Set up auth with device key as admin
    let mut auth_settings = AuthSettings::new();
    auth_settings.add_key(
        "_device_key",
        AuthKey::active(device_pubkey, Permission::Admin(0))?,
    )?;
    settings.set_doc("auth", auth_settings.as_doc().clone());

    // Create the database with device signing key provided directly
    let database = Database::create(
        settings,
        instance,
        device_signing_key.clone(),
        "_device_key".to_string(),
    )?;

    Ok(database)
}

/// Create the _users system database
///
/// This database stores the user directory mapping user_id → UserInfo.
/// It is authenticated with the Instance's _device_key.
///
/// # Arguments
/// * `instance` - The Instance handle
/// * `device_signing_key` - The device's Ed25519 signing key
/// * `device_pubkey` - The public key for _device_key (used as admin)
///
/// # Returns
/// The created _users Database
pub fn create_users_database(
    instance: &Instance,
    device_signing_key: &ed25519_dalek::SigningKey,
    device_pubkey: &str,
) -> Result<Database> {
    // Create settings for _users database
    let mut settings = Doc::new();
    settings.set_string("name", USERS);
    settings.set_string("type", "system");
    settings.set_string("description", "User directory database");

    // Create auth settings with device key as admin
    let mut auth_settings = AuthSettings::new();
    auth_settings.add_key(
        "_device_key",
        AuthKey::active(device_pubkey, Permission::Admin(0))?,
    )?;

    settings.set_doc("auth", auth_settings.as_doc().clone());

    // Create the database with device signing key provided directly
    let database = Database::create(
        settings,
        instance,
        device_signing_key.clone(),
        "_device_key".to_string(),
    )?;

    Ok(database)
}

/// Create the _databases tracking database
///
/// This database stores the database tracking information mapping
/// database_id → DatabaseTracking.
/// It is authenticated with the Instance's _device_key.
///
/// # Arguments
/// * `instance` - The Instance handle
/// * `device_signing_key` - The device's Ed25519 signing key
/// * `device_pubkey` - The public key for _device_key (used as admin)
///
/// # Returns
/// The created _databases Database
pub fn create_databases_tracking(
    instance: &Instance,
    device_signing_key: &ed25519_dalek::SigningKey,
    device_pubkey: &str,
) -> Result<Database> {
    // Create settings for _databases database
    let mut settings = Doc::new();
    settings.set_string("name", DATABASES);
    settings.set_string("type", "system");
    settings.set_string("description", "Database tracking and registry");

    // Create auth settings with device key as admin
    let mut auth_settings = AuthSettings::new();
    auth_settings.add_key(
        "_device_key",
        AuthKey::active(device_pubkey, Permission::Admin(0))?,
    )?;

    settings.set_doc("auth", auth_settings.as_doc().clone());

    // Create the database with device signing key provided directly
    let database = Database::create(
        settings,
        instance,
        device_signing_key.clone(),
        "_device_key".to_string(),
    )?;

    Ok(database)
}

/// Create a new user account
///
/// This function:
/// 1. Optionally hashes the user's password (if provided)
/// 2. Generates a device keypair for the user
/// 3. Creates a user database for storing keys (encrypted or unencrypted)
/// 4. Creates UserInfo and stores it in _users database with auto-generated UUID
///
/// # Arguments
/// * `users_db` - The _users system database
/// * `instance` - The Instance handle
/// * `username` - Unique username for login
/// * `password` - Optional password. If None, creates passwordless user (instant login, no encryption)
///
/// # Returns
/// A tuple of (user_uuid, UserInfo) where user_uuid is the generated primary key
pub fn create_user(
    users_db: &Database,
    instance: &Instance,
    username: impl AsRef<str>,
    password: Option<&str>,
) -> Result<(String, UserInfo)> {
    let username = username.as_ref();
    // FIXME: Race condition - multiple concurrent creates with same username
    // can both succeed, creating duplicate users. This requires either:
    // 1. Distributed locking mechanism
    // 2. Backend-level unique constraints
    // 3. Periodic cleanup/reconciliation process
    // For now, duplicate detection happens at login time.

    // Check if username already exists
    let users_table = users_db.get_store_viewer::<Table<UserInfo>>("users")?;
    let existing = users_table.search(|u| u.username == username)?;
    if !existing.is_empty() {
        return Err(UserError::UsernameAlreadyExists {
            username: username.to_string(),
        }
        .into());
    }

    // 1. Hash password if provided
    let (password_hash, password_salt) = match password {
        Some(pwd) => {
            let (hash, salt) = hash_password(pwd)?;
            (Some(hash), Some(salt))
        }
        None => (None, None),
    };

    // 2. Generate default keypair for this user (kept in memory only)
    let (user_private_key, user_public_key) = generate_keypair();
    let user_public_key_str = crate::auth::crypto::format_public_key(&user_public_key);

    // 3. Create user database with authentication for both _device_key and user's key
    let mut user_db_settings = Doc::new();
    user_db_settings.set_string("name", format!("_user_{username}"));
    user_db_settings.set_string("type", "user");
    user_db_settings.set_string("description", format!("User database for {username}"));

    // Get device key for auth settings and database creation
    let device_private_key = instance
        .backend()
        .get_private_key("_device_key")?
        .ok_or_else(|| UserError::KeyNotFound {
            key_id: "_device_key".to_string(),
        })?;
    let device_pubkey = device_private_key.verifying_key();
    let device_pubkey_str = crate::auth::crypto::format_public_key(&device_pubkey);

    // Set up authentication with both keys
    let mut auth_settings = AuthSettings::new();
    // TODO: Is it possible for the device key to only have Read permission?
    // Then the device can read it to let the user login but that's it
    // (Though at the moment it wouldn't need explicit read access, every local DB is readable)
    auth_settings.add_key(
        "_device_key",
        AuthKey::active(&device_pubkey_str, Permission::Admin(0))?,
    )?;
    auth_settings.add_key(
        &user_public_key_str,
        AuthKey::active(&user_public_key_str, Permission::Admin(0))?,
    )?;
    user_db_settings.set_doc("auth", auth_settings.as_doc().clone());

    // Create database using device_key directly (KeySource::Provided)
    let user_database = Database::create(
        user_db_settings,
        instance,
        device_private_key,
        "_device_key".to_string(),
    )?;
    let user_database_id = user_database.root_id().clone();

    // 4. Store user's private key (encrypted or unencrypted based on password)
    let user_key = match (password, &password_salt) {
        (Some(pwd), Some(salt)) => {
            // Password-protected: encrypt the key
            let encryption_key = derive_encryption_key(pwd, salt)?;
            let (encrypted_key, nonce) = encrypt_private_key(&user_private_key, &encryption_key)?;

            UserKey {
                key_id: user_public_key_str.clone(),
                private_key_bytes: encrypted_key,
                encryption: KeyEncryption::Encrypted { nonce },
                display_name: Some("Default Key".to_string()),
                created_at: current_timestamp()?,
                last_used: None,
                is_default: true, // First key is always default
                database_sigkeys: std::collections::HashMap::new(),
            }
        }
        _ => {
            // Passwordless: store unencrypted
            UserKey {
                key_id: user_public_key_str.clone(),
                private_key_bytes: user_private_key.to_bytes().to_vec(),
                encryption: KeyEncryption::Unencrypted,
                display_name: Some("Default Key".to_string()),
                created_at: current_timestamp()?,
                last_used: None,
                is_default: true, // First key is always default
                database_sigkeys: std::collections::HashMap::new(),
            }
        }
    };

    let tx = user_database.new_transaction()?;
    let keys_table = tx.get_store::<Table<UserKey>>("keys")?;
    keys_table.insert(user_key)?;
    tx.commit()?;

    // 5. Create UserInfo
    let user_info = UserInfo {
        username: username.to_string(),
        user_database_id,
        password_hash,
        password_salt,
        created_at: current_timestamp()?,
        status: UserStatus::Active,
    };

    // 6. Store UserInfo in _users database with auto-generated UUID
    let tx = users_db.new_transaction()?;
    let users_table = tx.get_store::<Table<UserInfo>>("users")?;
    let user_uuid = users_table.insert(user_info.clone())?; // Generate UUID primary key
    tx.commit()?;

    Ok((user_uuid, user_info))
}

/// Login a user
///
/// This function:
/// 1. Searches for user by username in _users database
/// 2. Verifies password (if provided and required)
/// 3. Opens user's private database
/// 4. Loads and decrypts user keys (or loads unencrypted for passwordless users)
/// 5. Creates UserKeyManager with keys
/// 6. Returns User session object
///
/// # Arguments
/// * `users_db` - The _users system database
/// * `instance` - The Instance handle
/// * `username` - Username for login
/// * `password` - Optional password. None for passwordless users.
///
/// # Returns
/// A User session object with keys loaded
pub fn login_user(
    users_db: &Database,
    instance: &Instance,
    username: impl AsRef<str>,
    password: Option<&str>,
) -> Result<super::User> {
    let username = username.as_ref();

    // 1. Search for user by username
    let users_table = users_db.get_store_viewer::<Table<UserInfo>>("users")?;
    let results = users_table.search(|u| u.username == username)?;

    // Check for duplicate users (race condition detection)
    let (user_uuid, user_info) = match results.len() {
        0 => {
            return Err(UserError::UserNotFound {
                username: username.to_string(),
            }
            .into());
        }
        1 => results.into_iter().next().unwrap(),
        count => {
            // FIXME: Multiple users with same username detected!
            // This indicates the race condition occurred during user creation.
            // Resolution requires manual intervention or automated cleanup.
            return Err(UserError::DuplicateUsersDetected {
                username: username.to_string(),
                count,
            }
            .into());
        }
    };

    // Check if user is disabled
    if user_info.status != UserStatus::Active {
        return Err(UserError::UserDisabled {
            username: username.to_string(),
        }
        .into());
    }

    // 2. Verify password compatibility
    let is_passwordless = user_info.password_hash.is_none();
    match (password, is_passwordless) {
        (Some(pwd), false) => {
            // Password provided for password-protected user: verify it
            let password_hash = user_info.password_hash.as_ref().unwrap();
            super::crypto::verify_password(pwd, password_hash)?;
        }
        (None, true) => {
            // No password for passwordless user: OK
        }
        (Some(_), true) => {
            // Password provided for passwordless user: reject
            return Err(UserError::InvalidPassword.into());
        }
        (None, false) => {
            // No password for password-protected user: reject
            return Err(UserError::PasswordRequired {
                operation: "login for password-protected user".to_string(),
            }
            .into());
        }
    }

    // 3. Temporarily open user's private database to read keys (unauthenticated read)
    let temp_user_database = Database::open_readonly(user_info.user_database_id.clone(), instance)?;

    // 4. Load keys from user database
    let keys_table = temp_user_database.get_store_viewer::<Table<UserKey>>("keys")?;
    let keys: Vec<UserKey> = keys_table
        .search(|_| true)? // Get all keys
        .into_iter()
        .map(|(_, key)| key)
        .collect();

    // 5. Create UserKeyManager
    let key_manager = if let Some(pwd) = password {
        // Password-protected: decrypt keys
        let password_salt =
            user_info
                .password_salt
                .as_ref()
                .ok_or_else(|| UserError::PasswordRequired {
                    operation: "decrypt keys for password-protected user".to_string(),
                })?;
        UserKeyManager::new(pwd, password_salt, keys)?
    } else {
        // Passwordless: load unencrypted keys
        UserKeyManager::new_passwordless(keys)?
    };

    // 6. Re-open user database with the user's default key using open()
    // This configures the database to use KeySource::Provided with the user's key
    // so all operations work without needing keys in the backend
    let default_key_id = key_manager
        .get_default_key_id()
        .ok_or(UserError::NoKeysAvailable)?;
    let default_signing_key = key_manager
        .get_signing_key(&default_key_id)
        .ok_or_else(|| UserError::KeyNotFound {
            key_id: default_key_id.clone(),
        })?
        .clone();

    let user_database = Database::open(
        instance.handle(),
        &user_info.user_database_id,
        default_signing_key,
        default_key_id,
    )?;

    // 7. Update last_login in separate table
    // TODO: this is a log, so it will grow unbounded over time and should probably be moved to a log table
    let tx = users_db.new_transaction()?;
    let last_login_table = tx.get_store::<Table<i64>>("last_login")?;
    last_login_table.set(&user_uuid, current_timestamp()?)?;
    tx.commit()?;

    // 8. Create User session
    Ok(User::new(
        user_uuid,
        user_info,
        user_database,
        instance.handle(),
        key_manager,
    ))
}

/// List all users in the system
///
/// # Arguments
/// * `users_db` - The _users system database
///
/// # Returns
/// Vector of usernames
pub fn list_users(users_db: &Database) -> Result<Vec<String>> {
    let users_table = users_db.get_store_viewer::<Table<UserInfo>>("users")?;
    let users: Vec<UserInfo> = users_table
        .search(|_| true)? // Get all users
        .into_iter()
        .map(|(_, user)| user)
        .collect();
    Ok(users.into_iter().map(|u| u.username).collect())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::Instance;
    use crate::auth::crypto::{format_public_key, generate_keypair};
    use crate::backend::BackendImpl;
    use crate::backend::database::InMemory;
    use crate::store::DocStore;
    use crate::store::SettingsStore;

    use std::sync::Arc;

    /// Test helper: Create Instance with device key initialized
    fn setup_instance() -> (Instance, ed25519_dalek::SigningKey, String) {
        let backend = Arc::new(InMemory::new());
        let (device_key, device_pubkey) = generate_keypair();
        let pubkey_str = format_public_key(&device_pubkey);
        backend
            .store_private_key("_device_key", device_key.clone())
            .unwrap();

        // Create Instance with initialized device key
        let instance = Instance::create_internal(backend).unwrap();

        (instance, device_key, pubkey_str)
    }

    #[test]
    fn test_create_instance_database() {
        let (instance, device_key, pubkey_str) = setup_instance();

        let instance_db = create_instance_database(&instance, &device_key, &pubkey_str).unwrap();

        // Verify database was created
        assert!(!instance_db.root_id().to_string().is_empty());

        // Verify settings
        let transaction = instance_db.new_transaction().unwrap();
        let doc_store = transaction.get_store::<DocStore>("_settings").unwrap();
        let name = doc_store.get_string("name").unwrap();
        assert_eq!(name, INSTANCE);

        // Verify auth settings
        let settings_store = SettingsStore::new(&transaction).unwrap();
        let auth_settings = settings_store.get_auth_settings().unwrap();
        let device_key = auth_settings.get_key("_device_key").unwrap();
        assert_eq!(device_key.permissions(), &Permission::Admin(0));
        assert_eq!(device_key.pubkey(), &pubkey_str);
    }

    #[test]
    fn test_create_users_database() {
        let (instance, device_key, pubkey_str) = setup_instance();

        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Verify database was created
        assert!(!users_db.root_id().to_string().is_empty());

        // Verify settings
        let transaction = users_db.new_transaction().unwrap();
        let doc_store = transaction.get_store::<DocStore>("_settings").unwrap();
        let name = doc_store.get_string("name").unwrap();
        assert_eq!(name, USERS);
    }

    #[test]
    fn test_create_databases_tracking() {
        let (instance, device_key, pubkey_str) = setup_instance();

        let databases_db = create_databases_tracking(&instance, &device_key, &pubkey_str).unwrap();

        // Verify database was created
        assert!(!databases_db.root_id().to_string().is_empty());

        // Verify settings
        let transaction = databases_db.new_transaction().unwrap();
        let doc_store = transaction.get_store::<DocStore>("_settings").unwrap();
        let name = doc_store.get_string("name").unwrap();
        assert_eq!(name, DATABASES);
    }

    #[test]
    fn test_system_databases_have_device_key_auth() {
        let (instance, device_key, pubkey_str) = setup_instance();

        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Verify _device_key has admin access
        let transaction = users_db.new_transaction().unwrap();
        let settings_store = SettingsStore::new(&transaction).unwrap();
        let auth_settings = settings_store.get_auth_settings().unwrap();
        let device_key = auth_settings.get_key("_device_key").unwrap();

        assert_eq!(device_key.permissions(), &Permission::Admin(0));
        assert_eq!(device_key.pubkey(), &pubkey_str);
    }

    #[test]
    fn test_create_user() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a user with password
        let (user_uuid, user_info) =
            create_user(&users_db, &instance, "alice", Some("password123")).unwrap();

        // Verify user info
        assert_eq!(user_info.username, "alice");
        assert_eq!(user_info.status, UserStatus::Active);
        assert!(user_info.password_hash.is_some());
        assert!(user_info.password_salt.is_some());
        assert!(!user_uuid.is_empty());

        // Verify user was stored in _users database
        let users_table = users_db
            .get_store_viewer::<Table<UserInfo>>("users")
            .unwrap();
        let stored_user = users_table.get(&user_uuid).unwrap();
        assert_eq!(stored_user.username, "alice");
    }

    #[test]
    fn test_create_user_passwordless() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a passwordless user
        let (user_uuid, user_info) = create_user(&users_db, &instance, "bob", None).unwrap();

        // Verify user info
        assert_eq!(user_info.username, "bob");
        assert_eq!(user_info.status, UserStatus::Active);
        assert!(user_info.password_hash.is_none());
        assert!(user_info.password_salt.is_none());
        assert!(!user_uuid.is_empty());

        // Verify user was stored in _users database
        let users_table = users_db
            .get_store_viewer::<Table<UserInfo>>("users")
            .unwrap();
        let stored_user = users_table.get(&user_uuid).unwrap();
        assert_eq!(stored_user.username, "bob");
    }

    #[test]
    fn test_create_duplicate_user() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create first user
        create_user(&users_db, &instance, "alice", Some("password123")).unwrap();

        // Try to create duplicate
        let result = create_user(&users_db, &instance, "alice", Some("password456"));
        assert!(result.is_err());
    }

    #[test]
    fn test_login_user() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a user with password
        create_user(&users_db, &instance, "bob", Some("bobpassword")).unwrap();

        // Login user
        let user = login_user(&users_db, &instance, "bob", Some("bobpassword")).unwrap();

        // Verify user session
        assert_eq!(user.username(), "bob");

        // Verify last_login was recorded in separate table
        let last_login_table = users_db
            .get_store_viewer::<Table<i64>>("last_login")
            .unwrap();
        let last_login = last_login_table.get(user.user_uuid()).unwrap();
        assert!(last_login > 0);
    }

    #[test]
    fn test_login_user_passwordless() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a passwordless user
        create_user(&users_db, &instance, "charlie", None).unwrap();

        // Login user without password
        let user = login_user(&users_db, &instance, "charlie", None).unwrap();

        // Verify user session
        assert_eq!(user.username(), "charlie");

        // Verify last_login was recorded
        let last_login_table = users_db
            .get_store_viewer::<Table<i64>>("last_login")
            .unwrap();
        let last_login = last_login_table.get(user.user_uuid()).unwrap();
        assert!(last_login > 0);
    }

    #[test]
    fn test_login_wrong_password() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a user
        create_user(&users_db, &instance, "dave", Some("correct_password")).unwrap();

        // Try to login with wrong password
        let result = login_user(&users_db, &instance, "dave", Some("wrong_password"));
        assert!(result.is_err());
    }

    #[test]
    fn test_login_password_mismatch() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Create a passwordless user
        create_user(&users_db, &instance, "eve", None).unwrap();

        // Try to login with password (should fail)
        let result = login_user(&users_db, &instance, "eve", Some("password"));
        assert!(result.is_err());

        // Create a password-protected user
        create_user(&users_db, &instance, "frank", Some("password")).unwrap();

        // Try to login without password (should fail)
        let result = login_user(&users_db, &instance, "frank", None);
        assert!(result.is_err());
    }

    #[test]
    fn test_login_nonexistent_user() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Try to login user that doesn't exist
        let result = login_user(&users_db, &instance, "nonexistent", Some("password"));
        assert!(result.is_err());
    }

    #[test]
    fn test_list_users() {
        let (instance, device_key, pubkey_str) = setup_instance();
        let users_db = create_users_database(&instance, &device_key, &pubkey_str).unwrap();

        // Initially no users
        let users = list_users(&users_db).unwrap();
        assert_eq!(users.len(), 0);

        // Create some users (mix of password-protected and passwordless)
        create_user(&users_db, &instance, "alice", Some("pass1")).unwrap();
        create_user(&users_db, &instance, "bob", None).unwrap();
        create_user(&users_db, &instance, "charlie", Some("pass3")).unwrap();

        // List users
        let users = list_users(&users_db).unwrap();
        assert_eq!(users.len(), 3);
        assert!(users.contains(&"alice".into()));
        assert!(users.contains(&"bob".into()));
        assert!(users.contains(&"charlie".into()));
    }
}