eggfetch-core 0.1.4

Async-first Rust HTTP client engine (tokio + hyper) with connection pooling, phase-aware timeouts, TLS, proxies, and compression
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
//! Request types and builder.

use std::net::SocketAddr;
use std::sync::Arc;

use bytes::Bytes;
use http::Version;

use crate::body::RequestBody;
use crate::client::Client;
use crate::error::Result;
use crate::headers::Headers;
use crate::redirect::RedirectPolicy;
use crate::response::Response;
use crate::retry::RetryPolicy;
use crate::timeout::Timeout;
use crate::trace::TraceObserver;

use crate::auth::AuthScheme;
#[cfg(feature = "proxy")]
use crate::proxy::ProxyConfig;

/// A validated set of remote socket addresses for one logical HTTP origin.
///
/// The addresses control only the physical TCP destination. The request URL,
/// HTTP authority, TLS SNI, certificate verification, and origin policy still
/// use the logical URL. An empty set cannot be constructed. Callers are
/// responsible for validating that the addresses are appropriate for their
/// application and redirect policy.
#[derive(Clone, PartialEq, Eq)]
pub struct ResolvedTarget {
    addresses: Arc<[SocketAddr]>,
}

impl ResolvedTarget {
    /// Construct a resolved destination from one or more socket addresses.
    ///
    /// # Errors
    ///
    /// Returns [`crate::Error::InvalidResolvedTarget`] for an empty set.
    pub fn new<I>(addresses: I) -> crate::Result<Self>
    where
        I: IntoIterator<Item = SocketAddr>,
    {
        let addresses: Vec<_> = addresses.into_iter().collect();
        if addresses.is_empty() {
            return Err(crate::Error::InvalidResolvedTarget(
                "resolved destination set must not be empty".into(),
            ));
        }
        Ok(Self {
            addresses: addresses.into(),
        })
    }

    /// Return the caller-supplied destination addresses in their attempt order.
    #[must_use]
    pub fn addresses(&self) -> &[SocketAddr] {
        &self.addresses
    }
}

impl std::fmt::Debug for ResolvedTarget {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("ResolvedTarget")
            .field("address_count", &self.addresses.len())
            .finish()
    }
}

/// Typed transport-level hints carried on a request.
///
/// These are *not* HTTP headers and do not affect logical URL semantics
/// (routing, cookies, auth-origin comparisons, redirects, proxy selection).
/// They control only the wire-level behavior of the transport layer.
///
/// Timeout is kept in the existing [`Timeout`] model and must not be
/// duplicated here.
#[derive(Default, Clone)]
pub struct TransportHints {
    /// Override the wire request target (e.g. `OPTIONS *`, absolute-form).
    ///
    /// When present this replaces only the URI sent on the wire; the
    /// logical URL used for connection routing, Host header defaults,
    /// cookies, auth, redirects, and proxy selection remains unchanged.
    pub target: Option<Bytes>,
    /// Override the TLS Server Name Indication hostname.
    ///
    /// TCP connects to the URL host/IP; TLS uses this name for SNI and
    /// certificate verification.
    pub sni_hostname: Option<String>,
    /// Caller-supplied physical destinations for the logical URL origin.
    ///
    /// When present, direct routing uses exactly these addresses and never
    /// performs a DNS lookup. Same-origin redirects preserve this snapshot;
    /// cross-origin redirects fail closed. Proxy, UDS, and HTTP/3 routes are
    /// rejected while this hint is active.
    pub resolved_target: Option<ResolvedTarget>,
    /// Optional trace observer for transport lifecycle events.
    ///
    /// When present, the transport layer emits typed events at each
    /// lifecycle boundary (TCP connect, TLS handshake, request/response
    /// headers, body chunks, connection close). The observer is invoked
    /// synchronously within the async context and must not block.
    pub trace: Option<Arc<dyn TraceObserver>>,
}

impl std::fmt::Debug for TransportHints {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("TransportHints")
            .field("target", &self.target)
            .field("sni_hostname", &self.sni_hostname)
            .field("resolved_target", &self.resolved_target)
            .field("trace", &self.trace.as_ref().map(|_| "..."))
            .finish()
    }
}

/// Proxy override for a specific request.
///
/// Controls whether a request inherits the client-level proxy,
/// bypasses the proxy entirely, or uses a specific proxy configuration.
#[derive(Debug, Clone, Default)]
#[allow(
    clippy::large_enum_variant,
    reason = "ProxyConfig is transient and cloning it is cheap; boxing adds unnecessary allocation"
)]
pub enum ProxyOverride {
    /// Inherit the client-level proxy configuration (default).
    #[default]
    Inherit,
    /// Send the request directly, bypassing any client proxy.
    Direct,
    /// Use a specific proxy configuration for this request.
    #[cfg(feature = "proxy")]
    Override(ProxyConfig),
}

/// Parts returned by [`Request::into_parts`].
///
/// This is the complete logical-request state carried across retry and
/// redirect policy transformations. All reconstruction goes through the
/// typed helpers below so a newly added field fails to compile (via
/// exhaustive construction) rather than being silently dropped.
pub(crate) struct RequestParts {
    pub(crate) method: http::Method,
    pub(crate) url: url::Url,
    pub(crate) headers: Headers,
    pub(crate) body: RequestBody,
    pub(crate) version: Version,
    pub(crate) timeout: Option<Timeout>,
    pub(crate) redirect: Option<RedirectPolicy>,
    pub(crate) auth: Option<AuthScheme>,
    pub(crate) auth_disabled: bool,
    pub(crate) decompress: Option<bool>,
    pub(crate) max_decoded_body_size: Option<usize>,
    pub(crate) max_decompression_ratio: Option<f64>,
    pub(crate) proxy_override: ProxyOverride,
    pub(crate) retry: Option<RetryPolicy>,
    pub(crate) transport_hints: TransportHints,
}

impl RequestParts {
    /// Reassemble the parts into a [`Request`] without body replay.
    ///
    /// Exhaustively constructs the request so adding a field to
    /// [`RequestParts`] without updating this path is a compile error.
    /// Used by regression tests as the canonical round-trip anchor; the
    /// live retry path uses [`Self::retry_request`] with a shrunk deadline.
    #[allow(
        dead_code,
        reason = "exhaustiveness anchor for RequestParts: guarantees new fields fail to compile even though live code uses retry_request"
    )]
    pub(crate) fn into_request(self) -> Request {
        let RequestParts {
            method,
            url,
            headers,
            body,
            version,
            timeout,
            redirect,
            auth,
            auth_disabled,
            decompress,
            max_decoded_body_size,
            max_decompression_ratio,
            proxy_override,
            retry,
            transport_hints,
        } = self;
        let mut request = Request::new(method, url);
        *request.headers_mut() = headers;
        request.set_body(body);
        request.set_version(version);
        request.set_timeout(timeout);
        request.set_redirect(redirect);
        request.set_auth(auth);
        request.set_auth_disabled(auth_disabled);
        request.set_decompress(decompress);
        request.set_max_decoded_body_size(max_decoded_body_size);
        request.set_max_decompression_ratio(max_decompression_ratio);
        #[cfg(feature = "proxy")]
        request.set_proxy_override(proxy_override);
        #[cfg(not(feature = "proxy"))]
        let _ = proxy_override;
        request.set_retry(retry);
        request.set_transport_hints(transport_hints);
        request
    }

    /// Build the retry attempt for the same logical request.
    ///
    /// Preserves every request-local override that remains valid for
    /// another attempt (including transport hints, proxy/decompression
    /// overrides, auth-disable state, redirect and retry policy) while
    /// applying the shrunk `attempt_timeout` for the remaining total
    /// deadline. Non-replayable stream bodies return the existing
    /// [`crate::error::Error::BodyNotReplayableForRetry`] classification.
    ///
    /// # Errors
    ///
    /// Returns [`crate::error::Error::BodyNotReplayableForRetry`] when the
    /// saved body is a one-shot stream.
    pub(crate) fn retry_request(
        &self,
        attempt_timeout: Option<Timeout>,
    ) -> crate::error::Result<Request> {
        let replayed = self.body.try_clone_for_retry()?;
        let mut request = Request::new(self.method.clone(), self.url.clone());
        *request.headers_mut() = self.headers.clone();
        request.set_body(replayed);
        request.set_version(self.version);
        request.set_timeout(attempt_timeout);
        request.set_redirect(self.redirect.clone());
        request.set_auth(self.auth.clone());
        request.set_auth_disabled(self.auth_disabled);
        request.set_decompress(self.decompress);
        request.set_max_decoded_body_size(self.max_decoded_body_size);
        request.set_max_decompression_ratio(self.max_decompression_ratio);
        #[cfg(feature = "proxy")]
        request.set_proxy_override(self.proxy_override.clone());
        request.set_retry(self.retry.clone());
        request.set_transport_hints(self.transport_hints.clone());
        Ok(request)
    }

    /// Apply a shrunk total deadline to a timeout value.
    ///
    /// Returns the timeout with `total` replaced by `total - elapsed`
    /// (saturating). Used by both retry and redirect loops so the original
    /// total deadline shrinks rather than restarting on each attempt/hop.
    pub(crate) fn shrink_total_deadline(
        timeout: &Timeout,
        elapsed: std::time::Duration,
    ) -> Timeout {
        let mut out = *timeout;
        if let Some(total) = out.total {
            out.total = Some(total.saturating_sub(elapsed));
        }
        out
    }
}

/// An outgoing HTTP request.
///
/// # Security
///
/// The `Debug` implementation redacts secrets: the URL is rendered without
/// userinfo, query parameters, or fragments (query strings routinely carry
/// API keys), sensitive headers use the redacted form, and the body is
/// summarized by length only. See [`crate::redact`].
pub struct Request {
    method: http::Method,
    url: url::Url,
    headers: Headers,
    body: RequestBody,
    version: Version,
    timeout: Option<Timeout>,
    redirect: Option<RedirectPolicy>,
    auth: Option<AuthScheme>,
    auth_disabled: bool,
    decompress: Option<bool>,
    max_decoded_body_size: Option<usize>,
    max_decompression_ratio: Option<f64>,
    /// Proxy override: `None` = inherit, `Some(None)` = direct, `Some(Some(c))` = explicit.
    proxy_override: ProxyOverride,
    /// Per-request retry policy override.
    retry: Option<RetryPolicy>,
    /// Typed transport-level hints (target override, SNI hostname, etc.).
    transport_hints: TransportHints,
}

impl std::fmt::Debug for Request {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("Request")
            .field("method", &self.method)
            .field("url", &crate::redact::redact_url(&self.url))
            .field("headers", &self.headers)
            .field("body", &self.body)
            .field("version", &self.version)
            .field("timeout", &self.timeout)
            .field("redirect", &self.redirect)
            .field("auth", &self.auth)
            .field("auth_disabled", &self.auth_disabled)
            .field("decompress", &self.decompress)
            .field("max_decoded_body_size", &self.max_decoded_body_size)
            .field("max_decompression_ratio", &self.max_decompression_ratio)
            .field("proxy_override", &self.proxy_override)
            .field("retry", &self.retry)
            .field("transport_hints", &self.transport_hints)
            .finish()
    }
}

impl Request {
    /// Create a new request (crate-internal).
    pub(crate) fn new(method: http::Method, url: url::Url) -> Self {
        Self {
            method,
            url,
            headers: Headers::new(),
            body: RequestBody::default(),
            version: Version::HTTP_11,
            timeout: None,
            redirect: None,
            auth: None,
            auth_disabled: false,
            decompress: None,
            max_decoded_body_size: None,
            max_decompression_ratio: None,
            proxy_override: ProxyOverride::Inherit,
            retry: None,
            transport_hints: TransportHints::default(),
        }
    }

    /// Returns the HTTP method.
    #[must_use]
    pub fn method(&self) -> &http::Method {
        &self.method
    }

    /// Returns the request URL.
    #[must_use]
    pub fn url(&self) -> &url::Url {
        &self.url
    }

    /// Returns a reference to the request headers.
    #[must_use]
    pub fn headers(&self) -> &Headers {
        &self.headers
    }

    /// Returns a mutable reference to the request headers.
    pub fn headers_mut(&mut self) -> &mut Headers {
        &mut self.headers
    }

    /// Returns the request body.
    #[must_use]
    pub fn body(&self) -> &RequestBody {
        &self.body
    }

    /// Set the request body.
    pub fn set_body(&mut self, body: RequestBody) {
        self.body = body;
    }

    /// Returns the HTTP version.
    #[must_use]
    pub fn version(&self) -> Version {
        self.version
    }

    /// Set the HTTP version.
    pub fn set_version(&mut self, version: Version) {
        self.version = version;
    }

    /// Returns the request timeout configuration, if set.
    #[must_use]
    pub fn timeout(&self) -> Option<&Timeout> {
        self.timeout.as_ref()
    }

    /// Set the request-level timeout.
    pub fn set_timeout(&mut self, timeout: Option<Timeout>) {
        self.timeout = timeout;
    }

    /// Returns the request-level redirect policy override, if set.
    #[must_use]
    pub fn redirect(&self) -> Option<&RedirectPolicy> {
        self.redirect.as_ref()
    }

    /// Set the request-level redirect policy override.
    pub fn set_redirect(&mut self, redirect: Option<RedirectPolicy>) {
        self.redirect = redirect;
    }

    /// Returns a reference to the request-level auth override, if set.
    #[must_use]
    pub fn auth(&self) -> Option<&AuthScheme> {
        self.auth.as_ref()
    }

    /// Set the request-level auth override.
    pub fn set_auth(&mut self, auth: Option<AuthScheme>) {
        self.auth = auth;
    }

    /// Returns whether auth has been explicitly disabled for this request.
    #[must_use]
    pub fn is_auth_disabled(&self) -> bool {
        self.auth_disabled
    }

    /// Mark this request as having auth explicitly disabled.
    pub fn set_auth_disabled(&mut self, disabled: bool) {
        self.auth_disabled = disabled;
    }

    /// Returns the per-request decompression override, if set.
    ///
    /// - `Some(true)`: force decompression on
    /// - `Some(false)`: force decompression off
    /// - `None`: use client-level setting
    #[must_use]
    pub fn decompress(&self) -> Option<bool> {
        self.decompress
    }

    /// Set the per-request decompression override.
    pub fn set_decompress(&mut self, decompress: Option<bool>) {
        self.decompress = decompress;
    }

    /// Returns the per-request decoded response body size limit, if set.
    ///
    /// `None` means the client-level setting is used.
    #[must_use]
    pub fn max_decoded_body_size(&self) -> Option<usize> {
        self.max_decoded_body_size
    }

    /// Set the per-request decoded response body size limit.
    pub fn set_max_decoded_body_size(&mut self, max: Option<usize>) {
        self.max_decoded_body_size = max;
    }

    /// Returns the per-request decompression ratio limit, if set.
    ///
    /// `None` means the client-level setting is used.
    #[must_use]
    pub fn max_decompression_ratio(&self) -> Option<f64> {
        self.max_decompression_ratio
    }

    /// Set the per-request decompression ratio limit.
    pub fn set_max_decompression_ratio(&mut self, ratio: Option<f64>) {
        self.max_decompression_ratio = ratio;
    }

    /// Returns the proxy override for this request.
    #[cfg(feature = "proxy")]
    #[must_use]
    pub fn proxy_override(&self) -> &ProxyOverride {
        &self.proxy_override
    }

    /// Set the per-request proxy override.
    #[cfg(feature = "proxy")]
    pub fn set_proxy_override(&mut self, proxy: ProxyOverride) {
        self.proxy_override = proxy;
    }

    /// Returns the per-request retry policy override, if set.
    #[must_use]
    pub fn retry(&self) -> Option<&RetryPolicy> {
        self.retry.as_ref()
    }

    /// Set the per-request retry policy override.
    pub fn set_retry(&mut self, retry: Option<RetryPolicy>) {
        self.retry = retry;
    }

    /// Returns a reference to the transport hints for this request.
    #[must_use]
    pub fn transport_hints(&self) -> &TransportHints {
        &self.transport_hints
    }

    /// Set the transport hints for this request.
    pub fn set_transport_hints(&mut self, hints: TransportHints) {
        self.transport_hints = hints;
    }

    /// Decompose a request into its parts.
    ///
    /// Returns the request fields as named parts.
    pub(crate) fn into_parts(self) -> RequestParts {
        RequestParts {
            method: self.method,
            url: self.url,
            headers: self.headers,
            body: self.body,
            version: self.version,
            timeout: self.timeout,
            redirect: self.redirect,
            auth: self.auth,
            auth_disabled: self.auth_disabled,
            decompress: self.decompress,
            max_decoded_body_size: self.max_decoded_body_size,
            max_decompression_ratio: self.max_decompression_ratio,
            proxy_override: self.proxy_override,
            retry: self.retry,
            transport_hints: self.transport_hints,
        }
    }
}

/// Fluent builder for constructing requests.
pub struct RequestBuilder {
    client: Option<Client>,
    method: http::Method,
    url: url::Url,
    headers: Headers,
    body: RequestBody,
    timeout: Option<Timeout>,
    redirect: Option<RedirectPolicy>,
    auth: Option<AuthScheme>,
    auth_disabled: bool,
    decompress: Option<bool>,
    max_decoded_body_size: Option<usize>,
    max_decompression_ratio: Option<f64>,
    proxy_override: ProxyOverride,
    retry: Option<RetryPolicy>,
    transport_hints: TransportHints,
    error: Option<crate::Error>,
}

impl RequestBuilder {
    /// Create a new request builder associated with a client.
    pub(crate) fn new(client: Client, method: http::Method, url: url::Url) -> Self {
        Self {
            client: Some(client),
            method,
            url,
            headers: Headers::new(),
            body: RequestBody::default(),
            timeout: None,
            redirect: None,
            auth: None,
            auth_disabled: false,
            decompress: None,
            max_decoded_body_size: None,
            max_decompression_ratio: None,
            proxy_override: ProxyOverride::Inherit,
            retry: None,
            transport_hints: TransportHints::default(),
            error: None,
        }
    }

    /// Add a single header to the request.
    #[must_use]
    pub fn header(mut self, name: &str, value: &str) -> Self {
        if let Err(e) = self.headers.insert(name, value) {
            if self.error.is_none() {
                self.error = Some(e);
            }
        }
        self
    }

    /// Replace all headers with the provided set.
    #[must_use]
    pub fn headers(mut self, headers: Headers) -> Self {
        self.headers = headers;
        self
    }

    /// Append a query parameter to the URL.
    #[must_use]
    pub fn query(mut self, key: &str, value: &str) -> Self {
        self.url.query_pairs_mut().append_pair(key, value);
        self
    }

    /// Set the request body from any type that converts into `RequestBody`.
    #[must_use]
    pub fn body(mut self, body: impl Into<RequestBody>) -> Self {
        self.body = body.into();
        self
    }

    /// Set the request body from bytes.
    #[must_use]
    pub fn bytes(self, data: impl Into<Bytes>) -> Self {
        self.body(RequestBody::Bytes(data.into()))
    }

    /// Serialize a value as JSON and use it as a replayable request body.
    ///
    /// Sets `Content-Type: application/json` unless the request already has
    /// an explicit content type. The value is serialized before any network
    /// operation; serialization failures are returned immediately. Like the
    /// other body setters, this replaces a body set earlier in the chain. A
    /// later `body()` or `bytes()` call replaces the JSON bytes; it does not
    /// remove a content type that was already set.
    ///
    /// # Errors
    ///
    /// Returns [`crate::Error::JsonSerialize`] when the value cannot be
    /// serialized, or a header error if the default content type is invalid.
    #[cfg(feature = "json")]
    pub fn json<T: serde::Serialize>(mut self, value: &T) -> Result<Self> {
        let bytes = serde_json::to_vec(value)
            .map_err(|_| crate::Error::JsonSerialize("failed to serialize JSON value".into()))?;
        self.body = RequestBody::Bytes(Bytes::from(bytes));
        if !self.headers.contains("content-type") {
            self.headers.insert("content-type", "application/json")?;
        }
        Ok(self)
    }

    /// Set the timeout for this specific request.
    ///
    /// When set, this overrides the client-level timeout on a per-field
    /// basis: only fields present here replace the corresponding
    /// client-level fields.
    #[must_use]
    pub fn timeout(mut self, timeout: Timeout) -> Self {
        self.timeout = Some(timeout);
        self
    }

    /// Override the redirect policy for this specific request.
    ///
    /// When set, this overrides the client-level redirect policy for
    /// this request only.
    #[must_use]
    pub fn redirect_policy(mut self, policy: RedirectPolicy) -> Self {
        self.redirect = Some(policy);
        self
    }

    /// Set authentication for this specific request.
    ///
    /// Overrides client-level auth.
    #[must_use]
    pub fn auth(mut self, auth: impl Into<AuthScheme>) -> Self {
        self.auth = Some(auth.into());
        self.auth_disabled = false;
        self
    }

    /// Disable authentication for this specific request.
    ///
    /// When set, no auth is applied to this request even if the client
    /// has a default auth configured.
    #[must_use]
    pub fn without_auth(mut self) -> Self {
        self.auth_disabled = true;
        self.auth = None;
        self
    }

    /// Override the proxy for this specific request.
    ///
    /// When set, this proxy is used instead of the client-level proxy.
    #[cfg(feature = "proxy")]
    #[must_use]
    pub fn proxy(mut self, proxy: &crate::proxy::Proxy) -> Self {
        self.proxy_override = ProxyOverride::Override(proxy.config());
        self
    }

    /// Disable proxy for this specific request.
    ///
    /// When set, the request is sent directly without going through
    /// any proxy, even if the client has a default proxy configured.
    #[cfg(feature = "proxy")]
    #[must_use]
    pub fn without_proxy(mut self) -> Self {
        self.proxy_override = ProxyOverride::Direct;
        self
    }

    /// Override decompression for this specific request.
    ///
    /// - `true`: enable decompression regardless of client setting
    /// - `false`: disable decompression regardless of client setting
    #[must_use]
    pub fn decompress(mut self, decompress: bool) -> Self {
        self.decompress = Some(decompress);
        self
    }

    /// Override the client decoded response body size limit for this request.
    ///
    /// The request setting takes precedence over the client setting and is
    /// carried across retries and redirects. A value of zero rejects any
    /// non-empty decoded response body.
    #[must_use]
    pub fn max_decoded_body_size(mut self, max: usize) -> Self {
        self.max_decoded_body_size = Some(max);
        self
    }

    /// Override the client decompression ratio limit for this request.
    ///
    /// The request setting takes precedence over the client setting and is
    /// carried across retries and redirects.
    ///
    /// # Panics
    ///
    /// Panics if `ratio` is not finite or not positive.
    #[must_use]
    pub fn max_decompression_ratio(mut self, ratio: f64) -> Self {
        assert!(
            ratio.is_finite() && ratio > 0.0,
            "max_decompression_ratio must be finite and positive, got {ratio}"
        );
        self.max_decompression_ratio = Some(ratio);
        self
    }

    /// Override the retry policy for this specific request.
    ///
    /// When set, this overrides the client-level retry policy for
    /// this request only.
    #[must_use]
    pub fn retry(mut self, policy: RetryPolicy) -> Self {
        self.retry = Some(policy);
        self
    }

    /// Disable retries for this specific request, even if the client
    /// has a retry policy configured.
    #[must_use]
    pub fn without_retry(mut self) -> Self {
        self.retry = Some(RetryPolicy::default());
        self
    }

    /// Set the transport hints for this request.
    ///
    /// Transport hints control wire-level behavior (target override,
    /// SNI hostname) without affecting logical URL semantics.
    #[must_use]
    pub fn transport_hints(mut self, hints: TransportHints) -> Self {
        self.transport_hints = hints;
        self
    }

    /// Pin this request to caller-supplied remote destinations.
    ///
    /// The logical URL remains unchanged for HTTP authority, TLS identity,
    /// redirects, cookies, and authentication. The set must be non-empty and
    /// each address must use the URL's effective HTTP/HTTPS port. Static
    /// routing is direct-only; proxy and HTTP/3 combinations fail closed.
    #[must_use]
    pub fn resolved_addresses<I>(mut self, addresses: I) -> Self
    where
        I: IntoIterator<Item = SocketAddr>,
    {
        match ResolvedTarget::new(addresses) {
            Ok(target) => self.transport_hints.resolved_target = Some(target),
            Err(error) => {
                if self.error.is_none() {
                    self.error = Some(error);
                }
            }
        }
        self
    }

    /// Build the request without sending it.
    ///
    /// # Errors
    ///
    /// Returns an error if a previous builder step failed (e.g., invalid
    /// header).
    pub fn build(mut self) -> Result<Request> {
        if let Some(e) = self.error.take() {
            return Err(e);
        }
        if let Some(target) = &self.transport_hints.resolved_target {
            let expected_port = self.url.port_or_known_default().ok_or_else(|| {
                crate::Error::InvalidResolvedTarget(
                    "resolved destinations require an HTTP or HTTPS URL".into(),
                )
            })?;
            if target
                .addresses()
                .iter()
                .any(|address| address.port() != expected_port)
            {
                return Err(crate::Error::InvalidResolvedTarget(format!(
                    "all resolved destinations must use the URL's effective port {expected_port}"
                )));
            }
        }
        let request_target = self
            .transport_hints
            .target
            .as_deref()
            .unwrap_or_else(|| self.url.as_str().as_bytes());
        self.headers
            .validate_request_size(&self.method, request_target)?;
        let mut req = Request::new(self.method, self.url);
        req.headers = self.headers;
        req.body = self.body;
        req.timeout = self.timeout;
        req.redirect = self.redirect;
        req.auth = self.auth;
        req.auth_disabled = self.auth_disabled;
        req.decompress = self.decompress;
        req.max_decoded_body_size = self.max_decoded_body_size;
        req.max_decompression_ratio = self.max_decompression_ratio;
        req.proxy_override = self.proxy_override;
        req.retry = self.retry;
        req.transport_hints = self.transport_hints;
        Ok(req)
    }

    /// Build and send the request.
    ///
    /// # Errors
    ///
    /// Returns an error if the request could not be built or sent.
    pub async fn send(self) -> Result<Response> {
        let client = self.client.clone().ok_or_else(|| {
            crate::Error::RequestBuild("no client associated with request builder".into())
        })?;
        let request = self.build()?;
        Box::pin(client.send(request)).await
    }
}

#[cfg(test)]
mod tests {
    use proptest::prelude::*;

    use super::{Request, ResolvedTarget};
    use crate::auth::{AuthScheme, BasicAuth};
    use bytes::Bytes;
    use std::net::SocketAddr;

    proptest::proptest! {
        #[test]
        fn url_parse_round_trip(scheme in "https?", host in "[a-z]{2,10}\\.[a-z]{2,5}", path in "/[a-z]{0,20}") {
            let url_str = format!("{scheme}://{host}{path}");
            let parsed = url::Url::parse(&url_str).unwrap();
            let serialized = parsed.to_string();
            prop_assert_eq!(url_str, serialized);
        }

        #[test]
        fn query_pairs_round_trip(key in "[a-z]{1,10}", value in "[a-z0-9]{1,20}") {
            let mut url = url::Url::parse("http://example.com/").unwrap();
            url.query_pairs_mut().append_pair(&key, &value);
            let found = url.query_pairs().find(|(k, _)| k == &key).map(|(_, v)| v.into_owned());
            prop_assert_eq!(found, Some(value));
        }

        #[test]
        fn url_with_arbitrary_path(path in "/[a-zA-Z0-9._/-]{0,50}") {
            let url_str = format!("http://example.com{path}");
            // Must not panic
            let _ = url::Url::parse(&url_str);
        }
    }

    #[test]
    fn request_debug_redacts_secrets() {
        let url = url::Url::parse("https://example.com/submit?api_key=top-secret-key").unwrap();
        let mut req = Request::new(http::Method::POST, url);
        req.headers_mut()
            .insert("authorization", "Bearer bearer-secret-token")
            .unwrap();
        req.headers_mut()
            .insert("cookie", "session=cookie-secret")
            .unwrap();
        req.set_body(crate::body::RequestBody::Bytes(Bytes::from(
            "password=form-secret",
        )));
        req.set_auth(Some(AuthScheme::Basic(
            BasicAuth::new("user", "auth-secret").unwrap(),
        )));
        let debug = format!("{req:?}");
        for leaked in [
            "top-secret-key",
            "bearer-secret-token",
            "cookie-secret",
            "form-secret",
            "auth-secret",
        ] {
            assert!(
                !debug.contains(leaked),
                "Request Debug must not leak {leaked:?}: {debug}"
            );
        }
        // Non-secret structure is still visible for diagnostics.
        assert!(debug.contains("example.com"), "keeps the host: {debug}");
        assert!(debug.contains("POST"), "keeps the method: {debug}");
    }

    #[test]
    fn resolved_target_rejects_empty_and_hides_addresses_in_debug() {
        assert!(ResolvedTarget::new(Vec::<SocketAddr>::new()).is_err());
        let target = ResolvedTarget::new(["127.0.0.1:443".parse().unwrap()]).unwrap();
        let debug = format!("{target:?}");
        assert!(debug.contains("address_count: 1"));
        assert!(!debug.contains("127.0.0.1"));
    }

    #[test]
    fn request_builder_validates_resolved_target_port() {
        let client = crate::client::Client::new();
        let request = client
            .get("http://example.invalid/")
            .unwrap()
            .resolved_addresses(["127.0.0.1:80".parse().unwrap()])
            .build()
            .unwrap();
        assert_eq!(
            request
                .transport_hints()
                .resolved_target
                .as_ref()
                .unwrap()
                .addresses()
                .len(),
            1
        );

        let error = client
            .get("http://example.invalid/")
            .unwrap()
            .resolved_addresses(["127.0.0.1:443".parse().unwrap()])
            .build()
            .unwrap_err();
        assert_eq!(error.kind(), "invalid_resolved_target");
    }

    #[cfg(feature = "json")]
    #[test]
    fn request_json_sets_default_content_type_and_replayable_body() {
        let client = crate::client::Client::new();
        let request = client
            .post("http://example.invalid/")
            .unwrap()
            .json(&serde_json::json!({"key": "value"}))
            .unwrap()
            .build()
            .unwrap();
        assert_eq!(
            request.headers().get("content-type").unwrap(),
            "application/json"
        );
        assert!(request.body().is_replayable());

        let request = client
            .post("http://example.invalid/")
            .unwrap()
            .header("content-type", "application/vnd.api+json")
            .json(&serde_json::json!([1, 2, 3]))
            .unwrap()
            .build()
            .unwrap();
        assert_eq!(
            request.headers().get("content-type").unwrap(),
            "application/vnd.api+json"
        );
    }
}