1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499
//! Built-in scheduling for systems.
//!
//! Users are free to use their own scheduling.
//!
//! Built-in [`Scheduler`] has following properties:
//! * Separates execution of conflicting systems temporally.
//! * Executes non-conflicting systems in parallel on available worker threads.
//! * Conflicting systems are executed in order of their registration.
//! That means that system defines implicit dependency on all systems with with there's conflict.
//! * In case of write-to-read conflict, reading system that is added later is guaranteed
//! to observe modifications made by writing system that was added before.
//! * In case of read-to-write conflict, reading system that is added before is guaranteed
//! to NOT observe modifications made by writing system that was added later.
//! * In case of write-to-write conflict, writing system that is added before is guaranteed
//! to NOT observe modifications made by writing system that was added later.
//! And writing system that is added later is guaranteed
//! to observe modifications made by writing system that was added before.
//!
#![allow(missing_docs)]
use alloc::{collections::VecDeque, sync::Arc};
use core::{
cell::UnsafeCell,
ops::{Deref, DerefMut},
ptr::NonNull,
sync::atomic::{AtomicUsize, Ordering},
};
use std::thread::Thread;
use hashbrown::HashSet;
use parking_lot::Mutex;
use crate::{
action::ActionBuffer,
executor::{MockExecutor, ScopedExecutor},
query::Access,
system::{ActionQueue, IntoSystem, System},
world::World,
};
/// Scheduler that starts systems in order of their registration.
/// And executes as many non-conflicting systems in parallel as possible.
///
/// # Example
///
/// ```
/// # use edict::{world::World, scheduler::Scheduler, system::{IntoSystem, Res}};
///
/// let mut world = World::new();
/// let mut scheduler = Scheduler::new();
///
/// scheduler.add_system(|| {});
/// scheduler.add_system(|world: &mut World| {
/// println!("{}", world.with_resource::<i32>(|| 0));
/// });
/// scheduler.add_system(|world: &World| {
/// assert_eq!(0, *world.expect_resource::<i32>());
/// });
/// scheduler.add_system(|res: Res<i32>| {
/// assert_eq!(0, *res);
/// });
///
/// scheduler.run_threaded(&mut world);
/// ```
pub struct Scheduler {
systems: Vec<ScheduledSystem>,
schedule_cache_id: Option<u64>,
action_buffers: Vec<ActionBuffer>,
}
struct SyncUnsafeCell<T: ?Sized> {
inner: UnsafeCell<T>,
}
impl<T> SyncUnsafeCell<T> {
pub fn new(value: T) -> Self {
SyncUnsafeCell {
inner: UnsafeCell::new(value),
}
}
}
unsafe impl<T: ?Sized> Sync for SyncUnsafeCell<T> {}
impl<T: ?Sized> Deref for SyncUnsafeCell<T> {
type Target = UnsafeCell<T>;
fn deref(&self) -> &UnsafeCell<T> {
&self.inner
}
}
impl<T: ?Sized> DerefMut for SyncUnsafeCell<T> {
fn deref_mut(&mut self) -> &mut UnsafeCell<T> {
&mut self.inner
}
}
struct ScheduledSystem {
system: SyncUnsafeCell<Box<dyn System + Send>>,
wait: AtomicUsize,
dependents: Vec<usize>,
dependencies: usize,
is_local: bool,
}
struct QueueInner<T> {
items: Mutex<VecDeque<T>>,
thread: Thread,
}
struct Queue<T> {
inner: Arc<QueueInner<T>>,
}
impl<T> Clone for Queue<T> {
#[inline]
fn clone(&self) -> Self {
Queue {
inner: self.inner.clone(),
}
}
}
impl<T> Drop for Queue<T> {
#[inline]
fn drop(&mut self) {
if Arc::strong_count(&self.inner) == 2 {
self.inner.thread.unpark();
}
}
}
impl<T> Queue<T> {
#[inline]
fn new() -> Self {
Queue {
inner: Arc::new(QueueInner {
items: Mutex::new(VecDeque::new()),
thread: std::thread::current(),
}),
}
}
#[inline]
fn enqueue(&self, item: T) {
self.inner.items.lock().push_back(item);
self.inner.thread.unpark();
}
#[inline]
fn try_deque(&self) -> Option<T> {
self.inner.items.lock().pop_front()
}
#[inline]
fn deque(&self) -> Result<T, ()> {
loop {
if let Some(item) = self.try_deque() {
return Ok(item);
}
if Arc::strong_count(&self.inner) == 1 {
return Err(());
}
std::thread::park();
}
}
}
impl ActionQueue for Queue<ActionBuffer> {
#[inline]
fn get<'a>(&self) -> ActionBuffer {
match self.try_deque() {
Some(buffer) => buffer,
None => ActionBuffer::new(),
}
}
#[inline]
fn flush(&mut self, buffer: ActionBuffer) {
self.enqueue(buffer);
}
}
#[derive(Clone, Copy)]
struct NonNullWorld {
ptr: NonNull<World>,
}
unsafe impl Send for NonNullWorld {}
struct Task<'scope> {
system_idx: usize,
systems: &'scope [ScheduledSystem],
world: NonNullWorld,
task_queue: Queue<Task<'scope>>,
action_queue: Queue<ActionBuffer>,
}
impl<'scope> Task<'scope> {
fn run(self, executor: &impl ScopedExecutor<'scope>) {
let Task {
system_idx,
systems,
world,
task_queue,
mut action_queue,
} = self;
let mut dependents = &systems[system_idx].dependents[..];
let mut unroll = Some(unsafe {
// # Safety
//
// Only spawned task gets to run this system.
&mut **systems[system_idx].system.get()
});
while let Some(system) = unroll.take() {
unsafe {
system.run_unchecked(world.ptr, &mut action_queue);
}
for &dependent_idx in dependents {
let old = systems[dependent_idx].wait.fetch_sub(1, Ordering::AcqRel);
if old == 0 {
let is_local = systems[dependent_idx].is_local;
if !is_local && unroll.is_none() {
unroll = Some(unsafe {
// # Safety
//
// Only task that decrements zeroed wait counter gets to run this system.
&mut **systems[dependent_idx].system.inner.get()
});
dependents = &systems[dependent_idx].dependents[..];
} else {
let task = Task {
system_idx: dependent_idx,
systems: systems,
world: world,
task_queue: task_queue.clone(),
action_queue: action_queue.clone(),
};
if is_local {
task_queue.enqueue(task);
} else {
executor.spawn(move |executor| task.run(executor));
}
}
}
}
}
}
}
impl Scheduler {
/// Creates new empty scheduler.
pub fn new() -> Self {
Scheduler {
systems: Vec::new(),
schedule_cache_id: None,
action_buffers: Vec::new(),
}
}
/// Adds system to the scheduler.
pub fn add_system<M>(&mut self, system: impl IntoSystem<M>) {
self.add_boxed_system(Box::new(system.into_system()));
}
/// Adds system to the scheduler.
pub fn add_boxed_system(&mut self, system: Box<dyn System + Send>) {
self.systems.push(ScheduledSystem {
is_local: system.is_local(),
system: SyncUnsafeCell::new(system),
wait: AtomicUsize::new(0),
dependents: Vec::new(),
dependencies: 0,
});
self.schedule_cache_id = None;
}
#[cfg(feature = "std")]
pub fn run_threaded(&mut self, world: &mut World) {
use crate::action::ActionBufferSliceExt;
let buffers = std::thread::scope(|scope| self.run_with(world, &scope));
buffers.execute_all(world);
}
#[cfg(feature = "rayon")]
pub fn run_rayon(&mut self, world: &mut World) {
use crate::action::ActionBufferSliceExt;
let buffers = rayon::in_place_scope(|scope| self.run_with(world, scope));
buffers.execute_all(world);
}
pub fn run_sequential(&mut self, world: &mut World) {
use crate::action::ActionBufferSliceExt;
let buffers = self.run_with(world, &mut MockExecutor);
buffers.execute_all(world);
}
/// Runs all systems in the scheduler.
/// Provided closure should spawn system execution task.
///
/// Running systems on the current thread instead can be viable for debugging purposes.
#[must_use]
pub fn run_with<'scope, 'later: 'scope>(
&'later mut self,
world: &'scope mut World,
executor: &impl ScopedExecutor<'scope>,
) -> &'later mut [ActionBuffer] {
self.reschedule(world);
for system in &mut self.systems {
*system.wait.get_mut() = system.dependencies;
}
let task_queue = Queue::new();
let action_queue = Queue::new();
for buffer in self.action_buffers.drain(..) {
action_queue.enqueue(buffer);
}
let mut unroll = None;
let world_ptr = NonNull::from(world);
for (idx, system) in self.systems.iter().enumerate() {
let old = system.wait.fetch_sub(1, Ordering::Acquire);
if old == 0 {
let is_local = system.is_local;
let task = Task {
system_idx: idx,
world: NonNullWorld { ptr: world_ptr },
systems: &self.systems,
task_queue: task_queue.clone(),
action_queue: action_queue.clone(),
};
if is_local {
if unroll.is_none() {
unroll = Some(task);
} else {
task_queue.enqueue(task);
}
} else {
executor.spawn(move |executor| task.run(executor));
}
}
}
if let Some(task) = unroll {
task.run(executor);
}
while let Ok(task) = task_queue.deque() {
task.run(executor);
}
while let Ok(buffer) = action_queue.deque() {
self.action_buffers.push(buffer);
}
&mut self.action_buffers[..]
}
fn reschedule(&mut self, world: &World) {
if self.schedule_cache_id == Some(world.archetype_set_id()) {
return;
}
for i in 0..self.systems.len() {
// Reset dependencies.
let a = &mut self.systems[i];
a.dependents.clear();
a.dependencies = 0;
let mut deps = HashSet::new();
'j: for j in (0..i).rev() {
let a = &self.systems[i];
let b = &self.systems[j];
for &d in &b.dependents {
if deps.contains(&d) {
// A transitive dependency.
deps.insert(j);
continue 'j;
}
}
let system_a = unsafe {
// # Safety
//
// Unique access to systems.
&*a.system.get()
};
let system_b = unsafe {
// # Safety
//
// Unique access to systems.
// j is always less than i
&*b.system.get()
};
if conflicts(system_a.world_access(), system_b.world_access()) {
// Conflicts on world access.
// Add a dependency.
self.systems[j].dependents.push(i);
self.systems[i].dependencies += 1;
deps.insert(j);
continue 'j;
}
for id in world.resource_types() {
if conflicts(system_a.access_resource(id), system_b.access_resource(id)) {
// Conflicts on this resource.
// Add a dependency.
self.systems[j].dependents.push(i);
self.systems[i].dependencies += 1;
deps.insert(j);
continue 'j;
}
}
for archetype in world.archetypes() {
let system_a = unsafe {
// # Safety
//
// Unique access to systems.
&*a.system.get()
};
let system_b = unsafe {
// # Safety
//
// Unique access to systems.
// j is always less than i
&*b.system.get()
};
if !system_a.visit_archetype(archetype) || !system_b.visit_archetype(archetype)
{
// Ignore skipped archetypes.
continue;
}
for info in archetype.infos() {
if conflicts(
system_a.access_component(info.id()),
system_b.access_component(info.id()),
) {
// Conflicts on this archetype.
// Add a dependency.
self.systems[j].dependents.push(i);
self.systems[i].dependencies += 1;
deps.insert(j);
continue 'j;
}
}
}
}
}
}
}
mod test {
#![cfg(test)]
use super::*;
use crate::{component::Component, system::State};
struct Foo;
impl Component for Foo {}
#[test]
fn test() {
let mut world = World::new();
let mut scheduler = Scheduler::new();
scheduler.add_system(|mut q: State<i32>| {
*q = 11;
println!("{}", *q);
});
scheduler.run_sequential(&mut world);
}
}
fn conflicts(lhs: Option<Access>, rhs: Option<Access>) -> bool {
matches!(
(lhs, rhs),
(Some(Access::Write), Some(_)) | (Some(_), Some(Access::Write))
)
}