edgefirst-codec 0.23.2

Image codec for decoding JPEG/PNG into pre-allocated EdgeFirst tensors
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
// SPDX-FileCopyrightText: Copyright 2026 Au-Zone Technologies
// SPDX-License-Identifier: Apache-2.0

//! NEON-optimised YCbCr color conversion.
//!
//! Processes 16 pixels per iteration using NEON SIMD intrinsics.
//! BT.601 full-range with 16-bit fixed-point arithmetic.
//!
//! The approach:
//! 1. Load 16 Y/Cb/Cr values
//! 2. Widen to i16, subtract 128 from Cb/Cr
//! 3. Fixed-point multiply-accumulate for R/G/B
//! 4. Clamp to [0, 255] via unsigned saturation
//! 5. Interleaved store via vst3q/vst4q

use std::arch::aarch64::*;

/// BT.601 full-range constants scaled to fit i16 multiply (shift 6 not 16).
/// Using 7-bit fractional precision to keep intermediates in i16 range.
///
/// We use a different strategy: widen to i32 for the multiplies, then narrow.
/// Constants at 16-bit precision (>> 16 shift at end).
/// Actually, for NEON we use a simpler approach: 8-bit fixed-point with
/// widening multiply.
///
/// R = Y + 1.402 * (Cr - 128)
/// G = Y - 0.34414 * (Cb - 128) - 0.71414 * (Cr - 128)
/// B = Y + 1.772 * (Cb - 128)
///
/// Using 7-bit fixed point (multiply by 128):
///  CR_TO_R = round(1.402 * 128) = 179
///  CB_TO_G = round(-0.34414 * 128) = -44
///  CR_TO_G = round(-0.71414 * 128) = -91
///  CB_TO_B = round(1.772 * 128) = 227
const CR_TO_R_7: i16 = 179;
const CB_TO_G_7: i16 = -44;
const CR_TO_G_7: i16 = -91;
const CB_TO_B_7: i16 = 227;

/// NEON YCbCr → RGB packed (3 bytes per pixel).
pub fn ycbcr_to_rgb_neon(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    unsafe { ycbcr_to_rgb_neon_inner(y_row, cb_row, cr_row, output, width) }
}

#[target_feature(enable = "neon")]
unsafe fn ycbcr_to_rgb_neon_inner(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    let chunks = width / 8;

    let cr_r = vdupq_n_s16(CR_TO_R_7);
    let cb_g = vdupq_n_s16(CB_TO_G_7);
    let cr_g = vdupq_n_s16(CR_TO_G_7);
    let cb_b = vdupq_n_s16(CB_TO_B_7);
    let c128 = vdupq_n_s16(128);

    for i in 0..chunks {
        let base = i * 8;

        // Load 8 Y/Cb/Cr samples
        let y_u8 = vld1_u8(y_row.as_ptr().add(base));
        let cb_u8 = vld1_u8(cb_row.as_ptr().add(base));
        let cr_u8 = vld1_u8(cr_row.as_ptr().add(base));

        // Widen to i16
        let y16 = vreinterpretq_s16_u16(vmovl_u8(y_u8));
        let cb16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cb_u8)), c128);
        let cr16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cr_u8)), c128);

        // R = Y + (Cr * 179 + 64) >> 7
        let r_offset = vrshrq_n_s16::<7>(vmulq_s16(cr16, cr_r));
        let r16 = vaddq_s16(y16, r_offset);

        // G = Y + ((Cb * -44) + (Cr * -91) + 64) >> 7
        let g_offset = vrshrq_n_s16::<7>(vaddq_s16(vmulq_s16(cb16, cb_g), vmulq_s16(cr16, cr_g)));
        let g16 = vaddq_s16(y16, g_offset);

        // B = Y + (Cb * 227 + 64) >> 7
        let b_offset = vrshrq_n_s16::<7>(vmulq_s16(cb16, cb_b));
        let b16 = vaddq_s16(y16, b_offset);

        // Clamp to [0, 255] via unsigned saturating narrowing
        let r8 = vqmovun_s16(r16);
        let g8 = vqmovun_s16(g16);
        let b8 = vqmovun_s16(b16);

        // Interleaved RGB store
        let rgb = uint8x8x3_t(r8, g8, b8);
        vst3_u8(output.as_mut_ptr().add(base * 3), rgb);
    }

    // Handle remaining pixels with scalar
    let start = chunks * 8;
    for j in start..width {
        let y = y_row[j] as i32;
        let cb = cb_row[j] as i32 - 128;
        let cr = cr_row[j] as i32 - 128;
        let r = (y + ((cr * CR_TO_R_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let g =
            (y + ((cb * CB_TO_G_7 as i32 + cr * CR_TO_G_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let b = (y + ((cb * CB_TO_B_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        output[j * 3] = r;
        output[j * 3 + 1] = g;
        output[j * 3 + 2] = b;
    }
}

/// NEON YCbCr → RGBA packed (4 bytes per pixel, alpha = 255).
pub fn ycbcr_to_rgba_neon(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    unsafe { ycbcr_to_rgba_neon_inner(y_row, cb_row, cr_row, output, width) }
}

#[target_feature(enable = "neon")]
unsafe fn ycbcr_to_rgba_neon_inner(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    let chunks = width / 8;

    let cr_r = vdupq_n_s16(CR_TO_R_7);
    let cb_g = vdupq_n_s16(CB_TO_G_7);
    let cr_g = vdupq_n_s16(CR_TO_G_7);
    let cb_b = vdupq_n_s16(CB_TO_B_7);
    let c128 = vdupq_n_s16(128);
    let alpha = vdup_n_u8(255);

    for i in 0..chunks {
        let base = i * 8;

        let y_u8 = vld1_u8(y_row.as_ptr().add(base));
        let cb_u8 = vld1_u8(cb_row.as_ptr().add(base));
        let cr_u8 = vld1_u8(cr_row.as_ptr().add(base));

        let y16 = vreinterpretq_s16_u16(vmovl_u8(y_u8));
        let cb16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cb_u8)), c128);
        let cr16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cr_u8)), c128);

        let r_offset = vrshrq_n_s16::<7>(vmulq_s16(cr16, cr_r));
        let r16 = vaddq_s16(y16, r_offset);

        let g_offset = vrshrq_n_s16::<7>(vaddq_s16(vmulq_s16(cb16, cb_g), vmulq_s16(cr16, cr_g)));
        let g16 = vaddq_s16(y16, g_offset);

        let b_offset = vrshrq_n_s16::<7>(vmulq_s16(cb16, cb_b));
        let b16 = vaddq_s16(y16, b_offset);

        let r8 = vqmovun_s16(r16);
        let g8 = vqmovun_s16(g16);
        let b8 = vqmovun_s16(b16);

        let rgba = uint8x8x4_t(r8, g8, b8, alpha);
        vst4_u8(output.as_mut_ptr().add(base * 4), rgba);
    }

    // Scalar tail
    let start = chunks * 8;
    for j in start..width {
        let y = y_row[j] as i32;
        let cb = cb_row[j] as i32 - 128;
        let cr = cr_row[j] as i32 - 128;
        let r = (y + ((cr * CR_TO_R_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let g =
            (y + ((cb * CB_TO_G_7 as i32 + cr * CR_TO_G_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let b = (y + ((cb * CB_TO_B_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        output[j * 4] = r;
        output[j * 4 + 1] = g;
        output[j * 4 + 2] = b;
        output[j * 4 + 3] = 255;
    }
}

/// NEON YCbCr → BGRA packed (4 bytes per pixel, alpha = 255).
pub fn ycbcr_to_bgra_neon(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    unsafe { ycbcr_to_bgra_neon_inner(y_row, cb_row, cr_row, output, width) }
}

#[target_feature(enable = "neon")]
unsafe fn ycbcr_to_bgra_neon_inner(
    y_row: &[u8],
    cb_row: &[u8],
    cr_row: &[u8],
    output: &mut [u8],
    width: usize,
) {
    let chunks = width / 8;

    let cr_r = vdupq_n_s16(CR_TO_R_7);
    let cb_g = vdupq_n_s16(CB_TO_G_7);
    let cr_g = vdupq_n_s16(CR_TO_G_7);
    let cb_b = vdupq_n_s16(CB_TO_B_7);
    let c128 = vdupq_n_s16(128);
    let alpha = vdup_n_u8(255);

    for i in 0..chunks {
        let base = i * 8;

        let y_u8 = vld1_u8(y_row.as_ptr().add(base));
        let cb_u8 = vld1_u8(cb_row.as_ptr().add(base));
        let cr_u8 = vld1_u8(cr_row.as_ptr().add(base));

        let y16 = vreinterpretq_s16_u16(vmovl_u8(y_u8));
        let cb16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cb_u8)), c128);
        let cr16 = vsubq_s16(vreinterpretq_s16_u16(vmovl_u8(cr_u8)), c128);

        let r_offset = vrshrq_n_s16::<7>(vmulq_s16(cr16, cr_r));
        let r16 = vaddq_s16(y16, r_offset);

        let g_offset = vrshrq_n_s16::<7>(vaddq_s16(vmulq_s16(cb16, cb_g), vmulq_s16(cr16, cr_g)));
        let g16 = vaddq_s16(y16, g_offset);

        let b_offset = vrshrq_n_s16::<7>(vmulq_s16(cb16, cb_b));
        let b16 = vaddq_s16(y16, b_offset);

        let r8 = vqmovun_s16(r16);
        let g8 = vqmovun_s16(g16);
        let b8 = vqmovun_s16(b16);

        // BGRA order: B, G, R, A
        let bgra = uint8x8x4_t(b8, g8, r8, alpha);
        vst4_u8(output.as_mut_ptr().add(base * 4), bgra);
    }

    // Scalar tail
    let start = chunks * 8;
    for j in start..width {
        let y = y_row[j] as i32;
        let cb = cb_row[j] as i32 - 128;
        let cr = cr_row[j] as i32 - 128;
        let r = (y + ((cr * CR_TO_R_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let g =
            (y + ((cb * CB_TO_G_7 as i32 + cr * CR_TO_G_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let b = (y + ((cb * CB_TO_B_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        output[j * 4] = b;
        output[j * 4 + 1] = g;
        output[j * 4 + 2] = r;
        output[j * 4 + 3] = 255;
    }
}

#[cfg(test)]
mod tests {
    use super::{ycbcr_to_bgra_neon, ycbcr_to_rgb_neon, ycbcr_to_rgba_neon};
    use super::{CB_TO_B_7, CB_TO_G_7, CR_TO_G_7, CR_TO_R_7};

    /// Deterministic synthetic YCbCr row: 16 pixels spanning typical broadcast range.
    /// Y in ~[16,235], Cb/Cr in ~[16,240].
    fn make_ycbcr_row() -> ([u8; 16], [u8; 16], [u8; 16]) {
        let y: [u8; 16] = [
            16, 40, 64, 80, 100, 120, 128, 140, 160, 180, 200, 210, 220, 230, 235, 200,
        ];
        let cb: [u8; 16] = [
            128, 100, 80, 64, 150, 200, 128, 90, 110, 170, 210, 128, 60, 220, 128, 140,
        ];
        let cr: [u8; 16] = [
            128, 200, 60, 180, 100, 128, 220, 128, 90, 160, 128, 50, 200, 128, 170, 100,
        ];
        (y, cb, cr)
    }

    /// 7-bit fixed-point scalar reference matching the NEON rounding behavior.
    /// vrshrq_n_s16::<7> rounds to nearest (adds 64 then truncates).
    fn scalar_rgb_7bit(y: u8, cb: u8, cr: u8) -> (u8, u8, u8) {
        let y = y as i32;
        let cb = cb as i32 - 128;
        let cr = cr as i32 - 128;
        let r = (y + ((cr * CR_TO_R_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let g =
            (y + ((cb * CB_TO_G_7 as i32 + cr * CR_TO_G_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        let b = (y + ((cb * CB_TO_B_7 as i32 + 64) >> 7)).clamp(0, 255) as u8;
        (r, g, b)
    }

    #[test]
    fn ycbcr_to_rgb_parity() {
        if !std::arch::is_aarch64_feature_detected!("neon") {
            eprintln!("SIMD feature not available, skipping");
            return;
        }

        let (y, cb, cr) = make_ycbcr_row();
        let width = 16usize;
        let mut simd_out = vec![0u8; width * 3];
        ycbcr_to_rgb_neon(&y, &cb, &cr, &mut simd_out, width);

        for i in 0..width {
            let (sr, sg, sb) = scalar_rgb_7bit(y[i], cb[i], cr[i]);
            let vr = simd_out[i * 3];
            let vg = simd_out[i * 3 + 1];
            let vb = simd_out[i * 3 + 2];
            let dr = (sr as i32 - vr as i32).abs();
            let dg = (sg as i32 - vg as i32).abs();
            let db = (sb as i32 - vb as i32).abs();
            assert!(
                dr <= 1,
                "RGB R parity mismatch at pixel {i}: scalar={sr}, simd={vr}, diff={dr}"
            );
            assert!(
                dg <= 1,
                "RGB G parity mismatch at pixel {i}: scalar={sg}, simd={vg}, diff={dg}"
            );
            assert!(
                db <= 1,
                "RGB B parity mismatch at pixel {i}: scalar={sb}, simd={vb}, diff={db}"
            );
        }
    }

    #[test]
    fn ycbcr_to_rgba_parity() {
        if !std::arch::is_aarch64_feature_detected!("neon") {
            eprintln!("SIMD feature not available, skipping");
            return;
        }

        let (y, cb, cr) = make_ycbcr_row();
        let width = 16usize;
        let mut simd_out = vec![0u8; width * 4];
        ycbcr_to_rgba_neon(&y, &cb, &cr, &mut simd_out, width);

        for i in 0..width {
            let (sr, sg, sb) = scalar_rgb_7bit(y[i], cb[i], cr[i]);
            let vr = simd_out[i * 4];
            let vg = simd_out[i * 4 + 1];
            let vb = simd_out[i * 4 + 2];
            let va = simd_out[i * 4 + 3];
            let dr = (sr as i32 - vr as i32).abs();
            let dg = (sg as i32 - vg as i32).abs();
            let db = (sb as i32 - vb as i32).abs();
            assert!(
                dr <= 1,
                "RGBA R parity mismatch at pixel {i}: scalar={sr}, simd={vr}, diff={dr}"
            );
            assert!(
                dg <= 1,
                "RGBA G parity mismatch at pixel {i}: scalar={sg}, simd={vg}, diff={dg}"
            );
            assert!(
                db <= 1,
                "RGBA B parity mismatch at pixel {i}: scalar={sb}, simd={vb}, diff={db}"
            );
            assert_eq!(va, 255, "RGBA alpha must be 255 at pixel {i}");
        }
    }

    #[test]
    fn ycbcr_to_bgra_parity() {
        if !std::arch::is_aarch64_feature_detected!("neon") {
            eprintln!("SIMD feature not available, skipping");
            return;
        }

        let (y, cb, cr) = make_ycbcr_row();
        let width = 16usize;
        let mut simd_out = vec![0u8; width * 4];
        ycbcr_to_bgra_neon(&y, &cb, &cr, &mut simd_out, width);

        for i in 0..width {
            let (sr, sg, sb) = scalar_rgb_7bit(y[i], cb[i], cr[i]);
            // BGRA layout: B G R A
            let vb = simd_out[i * 4];
            let vg = simd_out[i * 4 + 1];
            let vr = simd_out[i * 4 + 2];
            let va = simd_out[i * 4 + 3];
            let dr = (sr as i32 - vr as i32).abs();
            let dg = (sg as i32 - vg as i32).abs();
            let db = (sb as i32 - vb as i32).abs();
            assert!(
                dr <= 1,
                "BGRA R parity mismatch at pixel {i}: scalar={sr}, simd={vr}, diff={dr}"
            );
            assert!(
                dg <= 1,
                "BGRA G parity mismatch at pixel {i}: scalar={sg}, simd={vg}, diff={dg}"
            );
            assert!(
                db <= 1,
                "BGRA B parity mismatch at pixel {i}: scalar={sb}, simd={vb}, diff={db}"
            );
            assert_eq!(va, 255, "BGRA alpha must be 255 at pixel {i}");
        }
    }
}