dyniak 2.0.0

Riak-compatible protocol surface (HTTP + PBC) and storage bridge for the Dynomite Rust port
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248

//! End-to-end HTTP round-trip test for the multi-key transaction
//! endpoint of the Riak HTTP gateway.
//!
//! Spins up [`dyniak::serve_http`] over a real
//! `tokio::net::TcpListener` backed by a transactional
//! [`dyniak::datastore::NoxuDatastore`], then drives:
//!
//! * `POST /transactions` with a three-put batch -> `200 OK` and
//!   `result: "committed"`; the keys are visible afterwards.
//! * `POST /transactions` with `abort: true` -> `409 Conflict` and
//!   `result: "aborted"`; none of its writes are visible.
//! * `POST /buckets/users/transactions` whose op targets a
//!   different bucket -> `400 Bad Request`.
//!
//! The test inspects the retained concrete `NoxuDatastore` handle to
//! confirm what did and did not land, because the v0.0.1 HTTP `GET`
//! handler is a trampoline that does not read the K/V store.
//!
//! Gated on the `noxu` feature: the transaction endpoint needs a
//! transactional backend, and `NoxuDatastore` is the only
//! implementation.
#![cfg(feature = "noxu")]

use std::sync::Arc;
use std::time::Duration;

use tokio::io::{AsyncReadExt, AsyncWriteExt};
use tokio::net::{TcpListener, TcpStream};

use dyniak::datastore::NoxuDatastore;
use dyniak::serve_http;
use dynomite::embed::Datastore;

/// Send a raw HTTP request and read the full response back.
async fn send_request(addr: std::net::SocketAddr, request: &str) -> String {
    let mut stream = TcpStream::connect(addr).await.expect("connect");
    stream
        .write_all(request.as_bytes())
        .await
        .expect("write request");
    stream.flush().await.expect("flush");
    let mut buf = Vec::with_capacity(4096);
    let read = tokio::time::timeout(Duration::from_secs(5), stream.read_to_end(&mut buf))
        .await
        .expect("response timeout");
    let _ = read.expect("read response");
    String::from_utf8(buf).expect("response is utf-8")
}

/// Pull the numeric status code out of an HTTP/1.1 response.
fn status_code(response: &str) -> u16 {
    let line = response.lines().next().expect("status line");
    let mut parts = line.split_whitespace();
    let _version = parts.next().expect("version");
    parts
        .next()
        .expect("status code")
        .parse()
        .expect("status is numeric")
}

/// Return the response body (everything after the header break).
fn body_of(response: &str) -> &str {
    let split = response.find("\r\n\r\n").expect("end of headers");
    &response[split + 4..]
}

/// Build a `POST` request line + headers + body for `path`.
fn post(path: &str, body: &str) -> String {
    format!(
        "POST {path} HTTP/1.1\r\n\
         Host: localhost\r\n\
         Content-Type: application/json\r\n\
         Content-Length: {}\r\n\
         Connection: close\r\n\
         \r\n{body}",
        body.len()
    )
}

/// Build a `GET` request for `path`. The object GET path returns the
/// stored `HttpObject` envelope re-encoded under the negotiated codec
/// (default `application/json`).
fn get(path: &str) -> String {
    format!(
        "GET {path} HTTP/1.1\r\n\
         Host: localhost\r\n\
         Accept: application/json\r\n\
         Connection: close\r\n\
         \r\n"
    )
}

/// Decode the value a transaction stored under `(bucket, key)` from
/// its `HttpObject` storage envelope -- the canonical form every
/// dyniak write path uses, so a transaction-written object reads
/// back through HTTP GET and PBC RpbGet alike. Returns `None` when
/// the key is absent.
fn stored_value(ds: &NoxuDatastore, bucket: &[u8], key: &[u8]) -> Option<Vec<u8>> {
    let sbucket = dyniak::router::composite_storage_bucket(b"default", bucket);
    let raw = ds.get_object(&sbucket, key).unwrap()?;
    let obj = dyniak::proto::http::object::HttpObject::from_storage_bytes(&raw)
        .expect("transaction-written object decodes as an HttpObject envelope");
    Some(obj.value)
}

#[tokio::test]
async fn http_transaction_commit_abort_and_bucket_scope() {
    let listener = TcpListener::bind("127.0.0.1:0").await.expect("bind");
    let addr = listener.local_addr().expect("local_addr");

    let dir = tempfile::TempDir::new().expect("tempdir");
    let ds = Arc::new(NoxuDatastore::open_transactional(dir.path()).expect("open transactional"));
    let ds_for_server: Arc<dyn Datastore> = ds.clone();
    let server = tokio::spawn(async move { serve_http(listener, ds_for_server).await });

    // Yield so the accept loop is reached before clients knock.
    tokio::time::sleep(Duration::from_millis(10)).await;

    // --- Commit a three-put batch --------------------------------
    let commit_body = r#"{"operations":[
        {"op":"put","bucket":"users","key":"alice","value":"a",
         "indexes":[{"name":"age_int","value":"30"}]},
        {"op":"put","bucket":"users","key":"bob","value":"b"},
        {"op":"put","bucket":"users","key":"carol","value":"c"}
    ]}"#;
    let resp = send_request(addr, &post("/transactions", commit_body)).await;
    assert_eq!(status_code(&resp), 200, "commit status: {resp}");
    let parsed: serde_json::Value =
        serde_json::from_str(body_of(&resp)).expect("commit body is JSON");
    assert_eq!(parsed["result"], "committed");
    assert_eq!(parsed["operations"], 3);

    // All three keys, and the 2i entry, are visible after commit.
    // Values read back through the canonical HttpObject envelope --
    // a transaction writes the same storage form the HTTP and PBC
    // put paths do, so they are interoperable with every reader.
    assert_eq!(
        stored_value(&ds, b"users", b"alice").as_deref(),
        Some(&b"a"[..])
    );
    assert_eq!(
        stored_value(&ds, b"users", b"bob").as_deref(),
        Some(&b"b"[..])
    );
    assert_eq!(
        stored_value(&ds, b"users", b"carol").as_deref(),
        Some(&b"c"[..])
    );
    assert_eq!(
        ds.index_eq(
            &dyniak::router::composite_storage_bucket(b"default", b"users"),
            b"age_int",
            b"30"
        )
        .unwrap(),
        vec![b"alice".to_vec()]
    );

    // Regression (docs/journal/2026-06-19-bug-txn-storage-format.md):
    // a transaction-written object must read back through the HTTP
    // object GET path. Before the fix this returned 500 ("stored
    // object is corrupt") because the transaction stored raw value
    // bytes while GET expected the HttpObject envelope.
    let get_resp = send_request(addr, &get("/buckets/users/keys/alice")).await;
    assert_eq!(
        status_code(&get_resp),
        200,
        "txn-write then HTTP GET: {get_resp}"
    );
    let envelope: serde_json::Value =
        serde_json::from_str(body_of(&get_resp)).expect("GET body is a JSON HttpObject");
    // HttpObject.value is bytes; serde renders it as a JSON array.
    // The stored value was "a" == [97].
    assert_eq!(
        envelope["value"],
        serde_json::json!([97]),
        "GET returned the wrong value: {get_resp}"
    );

    // --- Abort a batch -------------------------------------------
    let abort_body = r#"{"abort":true,"operations":[
        {"op":"put","bucket":"users","key":"dave","value":"d",
         "indexes":[{"name":"age_int","value":"40"}]}
    ]}"#;
    let resp = send_request(addr, &post("/transactions", abort_body)).await;
    assert_eq!(status_code(&resp), 409, "abort status: {resp}");
    let parsed: serde_json::Value =
        serde_json::from_str(body_of(&resp)).expect("abort body is JSON");
    assert_eq!(parsed["result"], "aborted");

    // Nothing from the aborted batch landed.
    assert!(stored_value(&ds, b"users", b"dave").is_none());
    assert!(ds
        .index_eq(
            &dyniak::router::composite_storage_bucket(b"default", b"users"),
            b"age_int",
            b"40"
        )
        .unwrap()
        .is_empty());

    // --- Bucket-scoped route rejects a cross-bucket op -----------
    let mismatch_body = r#"{"operations":[
        {"op":"put","bucket":"other","key":"k","value":"v"}
    ]}"#;
    let resp = send_request(addr, &post("/buckets/users/transactions", mismatch_body)).await;
    assert_eq!(status_code(&resp), 400, "bucket-scope status: {resp}");
    assert!(ds
        .get_object(
            &dyniak::router::composite_storage_bucket(b"default", b"other"),
            b"k"
        )
        .unwrap()
        .is_none());

    server.abort();
    let _ = server.await;
}

#[tokio::test]
async fn http_transaction_bucket_scoped_commit() {
    let listener = TcpListener::bind("127.0.0.1:0").await.expect("bind");
    let addr = listener.local_addr().expect("local_addr");

    let dir = tempfile::TempDir::new().expect("tempdir");
    let ds = Arc::new(NoxuDatastore::open_transactional(dir.path()).expect("open transactional"));
    let ds_for_server: Arc<dyn Datastore> = ds.clone();
    let server = tokio::spawn(async move { serve_http(listener, ds_for_server).await });
    tokio::time::sleep(Duration::from_millis(10)).await;

    let body = r#"{"operations":[
        {"op":"put","bucket":"users","key":"erin","value":"e"},
        {"op":"delete","bucket":"users","key":"ghost"}
    ]}"#;
    let resp = send_request(addr, &post("/buckets/users/transactions", body)).await;
    assert_eq!(status_code(&resp), 200, "status: {resp}");
    let parsed: serde_json::Value = serde_json::from_str(body_of(&resp)).expect("body is JSON");
    assert_eq!(parsed["result"], "committed");
    assert_eq!(parsed["operations"], 2);
    assert_eq!(
        stored_value(&ds, b"users", b"erin").as_deref(),
        Some(&b"e"[..])
    );

    server.abort();
    let _ = server.await;
}