dynamo_renderer/deepseek/

v4.rs

// SPDX-FileCopyrightText: Copyright (c) 2024-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

//! DeepSeek V4 native prompt formatting
//!
//! Native Rust port of DeepSeek V4's chat encoding (encoding_dsv4.py).
//!
//! Reference: DeepSeek-V4-Pro/encoding/encoding_dsv4.py

use anyhow::{Context, Result};
use serde_json::Value as JsonValue;
use std::fmt::Write;

use super::common::{
    NormalizeNonText, REASONING_EFFORT_HIGH, REASONING_EFFORT_MAX, RESPONSE_FORMAT_TEMPLATE,
    TOOL_CALLS_BLOCK_NAME, TOOLS_TEMPLATE, drop_thinking_messages, encode_arguments_to_dsml,
    find_last_user_index, merge_tool_messages, normalize_message_contents, render_tools,
    sort_tool_results_by_call_order, task_token, to_json,
};
pub use super::common::{ReasoningEffort, ThinkingMode, tokens};

#[derive(Clone, Copy)]
pub(super) enum Encoding {
    V4(Option<ReasoningEffort>),
    V41(u8),
}

impl Encoding {
    fn is_v41(self) -> bool {
        matches!(self, Self::V41(_))
    }

    fn tag(self, v4: &'static str, v41: &'static str) -> &'static str {
        if self.is_v41() { v41 } else { v4 }
    }

    fn reasoning_prefix(self) -> String {
        match self {
            Self::V4(Some(ReasoningEffort::High)) => REASONING_EFFORT_HIGH.to_string(),
            Self::V4(Some(ReasoningEffort::Max)) => REASONING_EFFORT_MAX.to_string(),
            Self::V4(None) => String::new(),
            Self::V41(effort) => format!(
                "Reasoning Effort: {effort} (range 1-100, the higher the value, the more thorough the reasoning)\n\n"
            ),
        }
    }

    fn render_tools(self, tools: &[JsonValue]) -> String {
        let template = if self.is_v41() {
            TOOLS_TEMPLATE
                .replace("{dsml_token}tool_calls", "{dsml_token} calls")
                .replace("{dsml_token}invoke", "{dsml_token} invoke")
                .replace("{dsml_token}parameter", "{dsml_token} parameter")
        } else {
            TOOLS_TEMPLATE.to_string()
        };
        render_tools(&template, tools)
    }
}

/// Render a single message at the given index.
fn render_message(
    prompt: &mut String,
    index: usize,
    messages: &[JsonValue],
    thinking_mode: ThinkingMode,
    drop_thinking: bool,
    encoding: Encoding,
    last_user_idx: Option<usize>,
) -> Result<()> {
    let msg = &messages[index];

    let role = msg
        .get("role")
        .and_then(|r| r.as_str())
        .context("Missing 'role' field")?;

    if encoding.is_v41()
        && (role == "system" || (index == 0 && thinking_mode == ThinkingMode::Thinking))
    {
        prompt.push_str("<｜System｜>");
    }
    if index == 0 && thinking_mode == ThinkingMode::Thinking {
        prompt.push_str(&encoding.reasoning_prefix());
    }

    match role {
        "system" => {
            let content = msg.get("content").and_then(|c| c.as_str()).unwrap_or("");
            prompt.push_str(content);
            if let Some(tools) = msg.get("tools").and_then(|t| t.as_array()) {
                prompt.push_str("\n\n");
                prompt.push_str(&encoding.render_tools(tools));
            }
            if let Some(response_format) = msg.get("response_format") {
                prompt.push_str("\n\n");
                prompt.push_str(
                    &RESPONSE_FORMAT_TEMPLATE.replace("{schema}", &to_json(response_format)),
                );
            }
        }

        "developer" => {
            let content = msg
                .get("content")
                .and_then(|c| c.as_str())
                .filter(|s| !s.is_empty())
                .context("Developer role requires content")?;

            prompt.push_str(tokens::USER_START);
            prompt.push_str(content);

            if let Some(tools) = msg.get("tools").and_then(|t| t.as_array()) {
                prompt.push_str("\n\n");
                prompt.push_str(&encoding.render_tools(tools));
            }
            if let Some(response_format) = msg.get("response_format") {
                prompt.push_str("\n\n");
                prompt.push_str(
                    &RESPONSE_FORMAT_TEMPLATE.replace("{schema}", &to_json(response_format)),
                );
            }
        }

        "user" => {
            prompt.push_str(tokens::USER_START);
            if let Some(blocks) = msg.get("content_blocks").and_then(|b| b.as_array()) {
                for (block_idx, block) in blocks.iter().enumerate() {
                    if block_idx > 0 {
                        prompt.push_str("\n\n");
                    }
                    let block_type = block.get("type").and_then(|v| v.as_str()).unwrap_or("");
                    match block_type {
                        "text" => {
                            let text = block.get("text").and_then(|v| v.as_str()).unwrap_or("");
                            prompt.push_str(text);
                        }
                        "tool_result" => {
                            prompt.push_str("<tool_result>");
                            render_tool_result_content(
                                prompt,
                                block.get("content").unwrap_or(&JsonValue::Null),
                            )?;
                            prompt.push_str("</tool_result>");
                        }
                        other => {
                            write!(prompt, "[Unsupported {}]", other)?;
                        }
                    }
                }
            }
        }

        "latest_reminder" => {
            let content = msg.get("content").and_then(|c| c.as_str()).unwrap_or("");
            prompt.push_str(tokens::LATEST_REMINDER);
            prompt.push_str(content);
        }

        "tool" => {
            anyhow::bail!(
                "deepseek_v4 merges tool messages into user; preprocess with merge_tool_messages()"
            );
        }

        "assistant" => {
            let content = msg.get("content").and_then(|c| c.as_str()).unwrap_or("");
            let reasoning = msg
                .get("reasoning_content")
                .and_then(|c| c.as_str())
                .unwrap_or("");
            let wo_eos = msg.get("wo_eos").and_then(|v| v.as_bool()).unwrap_or(false);

            let prev_has_task = index > 0
                && messages[index - 1]
                    .get("task")
                    .map(|v| !v.is_null())
                    .unwrap_or(false);

            if thinking_mode == ThinkingMode::Thinking && !prev_has_task {
                let render_thinking = !drop_thinking || last_user_idx.is_none_or(|u| index > u);
                if render_thinking {
                    prompt.push_str(reasoning);
                    prompt.push_str(tokens::THINKING_END);
                }
            }

            prompt.push_str(content);

            if let Some(tool_calls) = msg.get("tool_calls").and_then(|t| t.as_array())
                && !tool_calls.is_empty()
            {
                prompt.push_str("\n\n");
                writeln!(
                    prompt,
                    "<{}{}>",
                    tokens::DSML_TOKEN,
                    encoding.tag(TOOL_CALLS_BLOCK_NAME, " calls")
                )?;

                for (call_idx, tc) in tool_calls.iter().enumerate() {
                    if call_idx > 0 {
                        prompt.push('\n');
                    }
                    // Accept both OpenAI-format (nested `function`) and internal
                    // `{name, arguments}` shape, matching Python's `tool_calls_from_openai_format`.
                    let fn_obj = tc.get("function").unwrap_or(tc);
                    let name = fn_obj
                        .get("name")
                        .and_then(|n| n.as_str())
                        .context("Missing tool call name")?;
                    let arguments = if encoding.is_v41() {
                        super::v41::encode_arguments(fn_obj)?
                    } else {
                        encode_arguments_to_dsml(fn_obj)?
                    };
                    write!(
                        prompt,
                        "<{}{} name=\"{}\">\n{}\n</{}{}>",
                        tokens::DSML_TOKEN,
                        encoding.tag("invoke", " invoke"),
                        name,
                        arguments,
                        tokens::DSML_TOKEN,
                        encoding.tag("invoke", " invoke")
                    )?;
                }
                write!(
                    prompt,
                    "\n</{}{}>",
                    tokens::DSML_TOKEN,
                    encoding.tag(TOOL_CALLS_BLOCK_NAME, " calls")
                )?;
            }

            if !wo_eos {
                prompt.push_str(tokens::EOS);
            }
        }

        other => anyhow::bail!("Unknown role: {}", other),
    }

    // Early return if the next message is not assistant/latest_reminder — no transition appended.
    if index + 1 < messages.len() {
        let next_role = messages[index + 1].get("role").and_then(|r| r.as_str());
        if !matches!(next_role, Some("assistant") | Some("latest_reminder")) {
            return Ok(());
        }
    }

    // Transition tokens based on task field and role.
    let task = msg.get("task").and_then(|v| v.as_str());
    if let Some(task) = task {
        let sp = task_token(task).with_context(|| format!("Invalid task: '{}'", task))?;
        if task != "action" {
            prompt.push_str(sp);
        } else {
            prompt.push_str(tokens::ASSISTANT_START);
            prompt.push_str(if thinking_mode != ThinkingMode::Thinking {
                tokens::THINKING_END
            } else {
                tokens::THINKING_START
            });
            prompt.push_str(sp);
        }
    } else if matches!(role, "user" | "developer")
        || (encoding.is_v41() && role == "system" && index > 0)
    {
        prompt.push_str(tokens::ASSISTANT_START);
        let seed_thinking = thinking_mode == ThinkingMode::Thinking
            && (!drop_thinking || last_user_idx.is_none_or(|u| index >= u));
        prompt.push_str(if seed_thinking {
            tokens::THINKING_START
        } else {
            tokens::THINKING_END
        });
    }

    Ok(())
}

/// Render a tool_result `content` payload (string or content-block list).
fn render_tool_result_content(prompt: &mut String, content: &JsonValue) -> Result<()> {
    match content {
        JsonValue::String(s) => prompt.push_str(s),
        JsonValue::Array(items) => {
            for (index, item) in items.iter().enumerate() {
                if index > 0 {
                    prompt.push_str("\n\n");
                }
                let item_type = item.get("type").and_then(|v| v.as_str()).unwrap_or("");
                if item_type == "text" {
                    prompt.push_str(item.get("text").and_then(|v| v.as_str()).unwrap_or(""));
                } else {
                    write!(prompt, "[Unsupported {}]", item_type)?;
                }
            }
        }
        JsonValue::Null => {}
        _ => prompt.push_str(&to_json(content)),
    }
    Ok(())
}

/// Encode messages to prompt string with default options.
///
/// Equivalent to `encode_messages_with_options(.., drop_thinking=true, reasoning_effort=None)`.
pub fn encode_messages(
    messages: &[JsonValue],
    thinking_mode: ThinkingMode,
    add_bos_token: bool,
) -> Result<String> {
    encode_messages_with_options(messages, thinking_mode, add_bos_token, true, None)
}

/// Encode messages to prompt string.
///
/// # Arguments
/// * `messages` - Array of messages in OpenAI format
/// * `thinking_mode` - Chat or Thinking
/// * `add_bos_token` - Whether to prepend BOS token
/// * `drop_thinking` - Drop reasoning_content from earlier turns (auto-disabled if tools present)
/// * `reasoning_effort` - Optional reasoning effort level (High and Max prepend distinct verbatim blocks)
pub fn encode_messages_with_options(
    messages: &[JsonValue],
    thinking_mode: ThinkingMode,
    add_bos_token: bool,
    drop_thinking: bool,
    reasoning_effort: Option<ReasoningEffort>,
) -> Result<String> {
    encode_owned_messages(
        messages.to_vec(),
        thinking_mode,
        add_bos_token,
        drop_thinking,
        Encoding::V4(reasoning_effort),
    )
}

pub(super) fn encode_owned_messages(
    messages: Vec<JsonValue>,
    thinking_mode: ThinkingMode,
    add_bos_token: bool,
    drop_thinking: bool,
    encoding: Encoding,
) -> Result<String> {
    let merged = merge_tool_messages(messages);
    // V4.1 orders source messages before merging, using the same routine as its media hook.
    let mut full = if encoding.is_v41() {
        merged
    } else {
        sort_tool_results_by_call_order(merged)
    };

    let mut prompt = String::new();
    if add_bos_token {
        prompt.push_str(tokens::BOS);
    }

    // Auto-disable drop_thinking when any message carries a `tools` field.
    let has_tools = full.iter().any(|m| {
        m.get("tools")
            .map(|v| match v {
                JsonValue::Array(a) => !a.is_empty(),
                JsonValue::Null => false,
                _ => true,
            })
            .unwrap_or(false)
    });
    let effective_drop_thinking = drop_thinking && !has_tools;

    if thinking_mode == ThinkingMode::Thinking && effective_drop_thinking {
        full = if encoding.is_v41() {
            super::v41::drop_thinking_messages(full)
        } else {
            drop_thinking_messages(full)
        };
    }

    let last_user_idx = if encoding.is_v41() {
        super::v41::find_last_user_index(&full)
    } else {
        find_last_user_index(&full)
    };
    for idx in 0..full.len() {
        render_message(
            &mut prompt,
            idx,
            &full,
            thinking_mode,
            effective_drop_thinking,
            encoding,
            last_user_idx,
        )?;
    }

    Ok(prompt)
}

/// DeepSeek V4 Prompt Formatter
#[derive(Debug)]
pub struct DeepSeekV4Formatter {
    thinking_mode: ThinkingMode,
}

impl DeepSeekV4Formatter {
    pub fn new(thinking_mode: ThinkingMode) -> Self {
        Self { thinking_mode }
    }

    /// Create formatter with thinking mode enabled (default for DSV4)
    pub fn new_thinking() -> Self {
        Self::new(ThinkingMode::Thinking)
    }

    /// Create formatter with chat mode
    pub fn new_chat() -> Self {
        Self::new(ThinkingMode::Chat)
    }

    fn resolve_reasoning_effort(v: Option<&JsonValue>) -> (bool, Option<ReasoningEffort>) {
        match v.and_then(JsonValue::as_str) {
            Some("none") => (true, None),
            Some("max") => (false, Some(ReasoningEffort::Max)),
            Some("high") | Some("medium") | Some("xhigh") => (false, Some(ReasoningEffort::High)),
            Some("low") | Some("minimal") => (false, None),
            None if v.is_none() => (false, Some(ReasoningEffort::High)),
            _ => {
                tracing::warn!(
                    value = ?v,
                    "reasoning_effort must be one of \"none\", \"minimal\", \"low\", \"medium\", \"high\", \"xhigh\", \"max\"; ignoring and using API default (high)"
                );
                (false, Some(ReasoningEffort::High))
            }
        }
    }

    fn resolve_drop_thinking(
        args: Option<&std::collections::HashMap<String, serde_json::Value>>,
    ) -> bool {
        let Some(args) = args else { return true };
        let Some(v) = args.get("drop_thinking") else {
            return true;
        };
        if let Some(b) = v.as_bool() {
            return b;
        }
        tracing::warn!(
            value = ?v,
            "chat_template_args.drop_thinking must be a bool; ignoring and using default (true)"
        );
        true
    }
}

impl crate::OAIPromptFormatter for DeepSeekV4Formatter {
    fn supports_add_generation_prompt(&self) -> bool {
        true
    }

    fn render(&self, req: &dyn crate::OAIChatLikeRequest) -> Result<String> {
        let args = req.chat_template_args();
        let effort_value = req
            .reasoning_effort()
            .map(|value| serde_json::to_value(value).context("serialize reasoning_effort"))
            .transpose()?
            .or_else(|| args.and_then(|args| args.get("reasoning_effort").cloned()));
        let (disable_thinking, reasoning_effort) =
            Self::resolve_reasoning_effort(effort_value.as_ref());
        let mut thinking_mode = super::common::resolve_thinking_mode(args, self.thinking_mode);
        if disable_thinking {
            thinking_mode = ThinkingMode::Chat;
        }
        let drop_thinking = Self::resolve_drop_thinking(args);

        let messages_json = crate::messages_to_json(req)?;
        crate::reject_unsupported_partial_assistant(&messages_json)?;
        crate::reject_unsupported_message_tools(&messages_json, &["developer"])?;

        let JsonValue::Array(mut messages_array) = messages_json else {
            anyhow::bail!("Messages is not an array");
        };

        normalize_message_contents(&mut messages_array, NormalizeNonText::LeaveUntouched);

        super::common::inject_tools_and_response_format(&mut messages_array, req)?;

        encode_owned_messages(
            messages_array,
            thinking_mode,
            true,
            drop_thinking,
            Encoding::V4(reasoning_effort),
        )
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::json;

    #[test]
    fn test_simple_conversation() {
        let messages = json!([
            {"role": "system", "content": "You are a helpful assistant."},
            {"role": "user", "content": "Hello"},
            {"role": "assistant", "reasoning_content": "greet", "content": "Hi!"},
            {"role": "user", "content": "What is 2+2?"}
        ]);
        let out =
            encode_messages(messages.as_array().unwrap(), ThinkingMode::Thinking, true).unwrap();
        assert!(out.starts_with(tokens::BOS));
        assert!(out.ends_with(&format!(
            "{}{}",
            tokens::ASSISTANT_START,
            tokens::THINKING_START
        )));
        // drop_thinking default true → earlier reasoning stripped
        assert!(!out.contains("greet"));
    }

    #[test]
    fn test_reasoning_effort_prefixes() {
        let messages = json!([
            {"role": "system", "content": "hi"},
            {"role": "user", "content": "hello"}
        ]);

        let high = encode_messages_with_options(
            messages.as_array().unwrap(),
            ThinkingMode::Thinking,
            true,
            true,
            Some(ReasoningEffort::High),
        )
        .unwrap();
        let max = encode_messages_with_options(
            messages.as_array().unwrap(),
            ThinkingMode::Thinking,
            true,
            true,
            Some(ReasoningEffort::Max),
        )
        .unwrap();
        let low = encode_messages_with_options(
            messages.as_array().unwrap(),
            ThinkingMode::Thinking,
            true,
            true,
            None,
        )
        .unwrap();

        assert_eq!(
            high,
            concat!(
                "<｜begin▁of▁sentence｜>Reasoning Effort: Absolute maximum with no shortcuts permitted.\n",
                "You MUST be very thorough in your thinking and comprehensively decompose the problem to resolve the root cause, rigorously stress-testing your logic against all potential paths, edge cases, and adversarial scenarios.\n",
                "Explicitly write out your entire deliberation process, documenting every intermediate step, considered alternative, and rejected hypothesis to ensure absolutely no assumption is left unchecked.\n\n",
                "hi<｜User｜>hello<｜Assistant｜><think>"
            )
        );
        assert_eq!(
            max,
            concat!(
                "<｜begin▁of▁sentence｜>Reasoning Effort: Beyond maximum — exhaustive, relentless, and uncompromising.\n",
                "You MUST reason with the utmost depth and rigor, leaving absolutely nothing to chance: exhaustively decompose the problem into its most fundamental components, trace every causal chain to its root, and resolve the underlying cause rather than any surface symptom.\n",
                "Do not stop reasoning until you have independently verified the solution from multiple angles and are certain that no assumption remains unchecked and no error remains undiscovered.\n\n",
                "hi<｜User｜>hello<｜Assistant｜><think>"
            )
        );
        assert_eq!(
            low,
            "<｜begin▁of▁sentence｜>hi<｜User｜>hello<｜Assistant｜><think>"
        );
    }

    #[test]
    fn test_content_blocks_with_tool_result() {
        // `merge_tool_messages` turns a `tool` role followed by a plain user text
        // into a single user turn whose `content_blocks` interleave the tool result
        // with the text, joined by "\n\n" at render time. Users don't construct
        // `content_blocks` directly — both the Python reference and this port
        // overwrite any user-supplied `content_blocks` with a single text block.
        let messages = json!([
            {"role": "user", "content": "call tool"},
            {"role": "assistant", "content": "", "tool_calls": [{
                "id": "c1", "type": "function",
                "function": {"name": "f", "arguments": "{}"}
            }]},
            {"role": "tool", "tool_call_id": "c1", "content": "RESULT"},
            {"role": "user", "content": "thanks"}
        ]);
        let out = encode_messages(messages.as_array().unwrap(), ThinkingMode::Chat, true).unwrap();
        assert!(
            out.contains("<tool_result>RESULT</tool_result>\n\nthanks"),
            "expected tool_result block followed by 'thanks' in the merged user turn, got:\n{}",
            out
        );
    }

    #[test]
    fn test_user_task_preserved_when_merged_after_tool_result() {
        let messages = json!([
            {"role": "assistant", "content": "", "tool_calls": [{
                "id": "c1", "type": "function",
                "function": {"name": "search", "arguments": "{}"}
            }]},
            {"role": "tool", "tool_call_id": "c1", "content": "RESULT"},
            {"role": "user", "content": "Search", "task": "action"},
            {"role": "assistant", "content": "OK"}
        ]);

        let out = encode_messages(messages.as_array().unwrap(), ThinkingMode::Chat, true).unwrap();
        assert!(
            out.contains(&format!(
                "{}Search{}{}{}OK",
                "<tool_result>RESULT</tool_result>\n\n",
                tokens::ASSISTANT_START,
                tokens::THINKING_END,
                tokens::TASK_ACTION
            )),
            "expected merged user text to keep the action task transition, got:\n{}",
            out
        );
    }

    #[test]
    fn test_drop_thinking_auto_disable_when_tools_present() {
        let messages = json!([
            {"role": "system", "content": "s", "tools": [{
                "type": "function",
                "function": {"name": "f", "description": "", "parameters": {"type": "object", "properties": {}}}
            }]},
            {"role": "user", "content": "hi"},
            {"role": "assistant", "reasoning_content": "PRIOR_REASONING", "content": "reply"},
            {"role": "user", "content": "again"}
        ]);
        let out =
            encode_messages(messages.as_array().unwrap(), ThinkingMode::Thinking, true).unwrap();
        // Tools present → drop_thinking auto-disabled → earlier reasoning preserved.
        assert!(out.contains("PRIOR_REASONING"));
    }

    // ---- Regression tests for known divergences from the Python reference ----

    /// Bug: `last_user_idx = None` (no user/developer in history) should behave
    /// like Python's `-1` sentinel — `index >= -1` / `idx >= -1` always true, so
    /// earlier reasoning is preserved and the assistant's reasoning block is
    /// rendered. Rust defaulting `None` to `usize::MAX` / `is_some_and` silently
    /// stripped reasoning instead.
    ///
    /// Byte-equivalent to Python reference with the same input:
    /// `<BOS>sysREASONING_BLOCK</think>hello<EOS>`
    #[test]
    fn test_assistant_reasoning_preserved_when_no_user_in_history() {
        let messages = json!([
            {"role": "system", "content": "sys"},
            {"role": "assistant", "content": "hello", "reasoning_content": "REASONING_BLOCK"}
        ]);
        let out =
            encode_messages(messages.as_array().unwrap(), ThinkingMode::Thinking, true).unwrap();
        assert_eq!(
            out, "<｜begin▁of▁sentence｜>sysREASONING_BLOCK</think>hello<｜end▁of▁sentence｜>",
            "Output must match Python reference byte-for-byte when no user/developer in history"
        );
    }

    /// Bug: `to_json` tracks in-string state via `prev_char != '\\'` which
    /// mis-handles consecutive backslashes. A value containing `\\` (one literal
    /// backslash in JSON) makes the helper think the closing `"` is escaped,
    /// so it stops inserting Python-compatible spaces after subsequent `:`/`,`.
    ///
    /// Python `json.dumps({"path": "\\", "count": 5}, ensure_ascii=False)`
    /// emits `{"path": "\\", "count": 5}` — space after every `:` and `,`.
    #[test]
    fn test_to_json_preserves_spacing_past_escaped_backslash() {
        let v = json!({"path": "\\", "count": 5});
        let got = to_json(&v);
        assert_eq!(
            got, r#"{"path": "\\", "count": 5}"#,
            "to_json must match Python's json.dumps formatting past an escaped backslash"
        );
    }

    #[test]
    fn test_resolve_drop_thinking_warns_on_malformed_value() {
        use std::collections::HashMap;
        // String "false" where a bool is expected → fall back to default (true) and warn.
        let mut args = HashMap::new();
        args.insert(
            "drop_thinking".to_string(),
            serde_json::Value::String("false".to_string()),
        );
        assert!(DeepSeekV4Formatter::resolve_drop_thinking(Some(&args)));
        // Malformed reasoning_effort falls back to the API default (high).
        let malformed = serde_json::Value::String("HIGH".to_string());
        assert_eq!(
            DeepSeekV4Formatter::resolve_reasoning_effort(Some(&malformed)),
            (false, Some(ReasoningEffort::High))
        );
    }

    #[test]
    fn test_resolve_thinking_mode_honors_enable_thinking() {
        use std::collections::HashMap;
        let mut args = HashMap::new();
        args.insert(
            "enable_thinking".to_string(),
            serde_json::Value::Bool(false),
        );
        assert_eq!(
            super::super::common::resolve_thinking_mode(Some(&args), ThinkingMode::Thinking),
            ThinkingMode::Chat
        );
        args.insert("enable_thinking".to_string(), serde_json::Value::Bool(true));
        assert_eq!(
            super::super::common::resolve_thinking_mode(Some(&args), ThinkingMode::Thinking),
            ThinkingMode::Thinking
        );
    }

    struct MockRequest {
        messages: JsonValue,
        typed: Option<Vec<dynamo_protocols::types::ChatCompletionRequestMessage>>,
        chat_template_args: Option<std::collections::HashMap<String, JsonValue>>,
        reasoning_effort: Option<JsonValue>,
        tools: Option<JsonValue>,
        tool_choice: Option<JsonValue>,
        response_format: Option<JsonValue>,
    }

    impl MockRequest {
        fn new(messages: JsonValue) -> Self {
            Self {
                messages,
                typed: None,
                chat_template_args: None,
                reasoning_effort: None,
                tools: None,
                tool_choice: None,
                response_format: None,
            }
        }

        fn with_chat_template_args(
            mut self,
            args: std::collections::HashMap<String, JsonValue>,
        ) -> Self {
            self.chat_template_args = Some(args);
            self
        }

        fn with_reasoning_effort(mut self, reasoning_effort: JsonValue) -> Self {
            self.reasoning_effort = Some(reasoning_effort);
            self
        }

        fn with_tools(mut self, tools: JsonValue) -> Self {
            self.tools = Some(tools);
            self
        }

        fn with_tool_choice(mut self, tool_choice: JsonValue) -> Self {
            self.tool_choice = Some(tool_choice);
            self
        }

        fn with_response_format(mut self, response_format: JsonValue) -> Self {
            self.response_format = Some(response_format);
            self
        }
    }

    impl crate::OAIChatLikeRequest for MockRequest {
        fn model(&self) -> String {
            "deepseek-v4".to_string()
        }

        fn messages(&self) -> minijinja::value::Value {
            assert!(
                self.typed.is_none(),
                "typed requests must skip MiniJinja conversion"
            );
            minijinja::value::Value::from_serialize(&self.messages)
        }

        fn typed_messages(
            &self,
        ) -> Option<&[dynamo_protocols::types::ChatCompletionRequestMessage]> {
            self.typed.as_deref()
        }

        fn should_add_generation_prompt(&self) -> bool {
            true
        }

        fn chat_template_args(
            &self,
        ) -> Option<&std::collections::HashMap<String, serde_json::Value>> {
            self.chat_template_args.as_ref()
        }

        fn reasoning_effort(&self) -> Option<minijinja::value::Value> {
            self.reasoning_effort
                .as_ref()
                .map(minijinja::value::Value::from_serialize)
        }

        fn tools(&self) -> Option<minijinja::value::Value> {
            self.tools
                .as_ref()
                .map(minijinja::value::Value::from_serialize)
        }

        fn tool_choice(&self) -> Option<minijinja::value::Value> {
            self.tool_choice
                .as_ref()
                .map(minijinja::value::Value::from_serialize)
        }

        fn response_format(&self) -> Option<minijinja::value::Value> {
            self.response_format
                .as_ref()
                .map(minijinja::value::Value::from_serialize)
        }
    }

    #[test]
    fn typed_messages_match_value_messages() {
        use crate::OAIPromptFormatter;
        let messages = json!([
            {"role": "system", "content": "Use tools. 中文 🦀"},
            {"role": "user", "content": [{"type": "text", "text": "weather?"}]},
            {"role": "assistant", "content": null, "reasoning_content": "check",
             "tool_calls": [{"id": "call_1", "type": "function",
                 "function": {"name": "weather", "arguments": "{\"city\":\"東京\"}"}}]},
            {"role": "tool", "tool_call_id": "call_1", "content": "sunny"},
            {"role": "user", "content": "explain"}
        ]);
        let mut typed = MockRequest::new(messages.clone());
        typed.typed = Some(serde_json::from_value(messages.clone()).unwrap());
        let value = MockRequest::new(messages);
        for formatter in [
            DeepSeekV4Formatter::new_thinking(),
            DeepSeekV4Formatter::new_chat(),
        ] {
            assert_eq!(
                formatter.render(&typed).unwrap(),
                formatter.render(&value).unwrap()
            );
        }
    }

    fn weather_tool() -> JsonValue {
        json!([{
            "type": "function",
            "function": {
                "name": "get_current_weather",
                "description": "Get the current weather in a given location",
                "parameters": {
                    "type": "object",
                    "properties": {"location": {"type": "string"}},
                    "required": ["location"]
                }
            }
        }])
    }

    #[test]
    fn test_formatter_rejects_unsupported_partial_assistant() {
        use crate::OAIPromptFormatter;

        let request = MockRequest::new(json!([
            {"role": "user", "content": "Continue"},
            {"role": "assistant", "content": "prefix", "partial": true}
        ]));
        let error = DeepSeekV4Formatter::new_thinking()
            .render(&request)
            .unwrap_err();

        assert!(matches!(
            error.downcast_ref::<crate::PromptRenderError>(),
            Some(crate::PromptRenderError::InvalidRequest(message))
                if message.contains("`partial: true` is not supported")
        ));
    }

    #[test]
    fn test_formatter_rejects_system_tools_before_injection() {
        use crate::OAIPromptFormatter;

        let request = MockRequest::new(json!([
            {"role": "system", "tools": [
                {"type": "function", "function": {"name": "dynamic_tool"}}
            ]},
            {"role": "user", "content": "Use a tool"}
        ]))
        .with_tools(weather_tool());
        let error = DeepSeekV4Formatter::new_thinking()
            .render(&request)
            .unwrap_err();

        assert!(matches!(
            error.downcast_ref::<crate::PromptRenderError>(),
            Some(crate::PromptRenderError::InvalidRequest(message))
                if message.contains("message-level `tools`") && message.contains("system")
        ));
    }

    #[test]
    fn test_formatter_preserves_developer_tools_with_top_level_tools() {
        use crate::OAIPromptFormatter;

        let request = MockRequest::new(json!([
            {"role": "developer", "content": "Use a tool", "tools": [
                {"type": "function", "function": {"name": "developer_tool"}}
            ]}
        ]))
        .with_tools(weather_tool());
        let rendered = DeepSeekV4Formatter::new_thinking()
            .render(&request)
            .unwrap();

        assert!(rendered.contains("developer_tool"));
        assert!(rendered.contains("get_current_weather"));
    }

    #[test]
    fn test_render_tool_choice_none_strips_tools_keeps_response_format() {
        use crate::OAIPromptFormatter;

        let req = MockRequest::new(json!([
            {"role": "system", "content": "sys"},
            {"role": "user", "content": "weather in Boston?"}
        ]))
        .with_tools(weather_tool())
        .with_tool_choice(json!("none"))
        .with_response_format(json!({"type": "json_object"}));

        let formatter = DeepSeekV4Formatter::new_chat();
        let out = formatter.render(&req).unwrap();

        assert!(
            !out.contains("## Tools"),
            "tool_choice=none must strip the tools block, got: {out}"
        );
        assert!(
            !out.contains("get_current_weather"),
            "tool schema leaked into prompt despite tool_choice=none: {out}"
        );
        assert!(
            out.contains("## Response Format"),
            "response_format must survive tool_choice=none: {out}"
        );
    }

    #[test]
    fn test_render_tool_choice_auto_keeps_tools() {
        use crate::OAIPromptFormatter;

        let req = MockRequest::new(json!([
            {"role": "system", "content": "sys"},
            {"role": "user", "content": "weather in Boston?"}
        ]))
        .with_tools(weather_tool())
        .with_tool_choice(json!("auto"));

        let formatter = DeepSeekV4Formatter::new_chat();
        let out = formatter.render(&req).unwrap();

        assert!(out.contains("## Tools"));
        assert!(out.contains("get_current_weather"));
    }

    #[test]
    fn test_render_absent_tool_choice_keeps_tools() {
        use crate::OAIPromptFormatter;

        let req = MockRequest::new(json!([
            {"role": "system", "content": "sys"},
            {"role": "user", "content": "weather in Boston?"}
        ]))
        .with_tools(weather_tool());

        let formatter = DeepSeekV4Formatter::new_chat();
        let out = formatter.render(&req).unwrap();

        assert!(out.contains("## Tools"));
        assert!(out.contains("get_current_weather"));
    }

    #[test]
    fn test_resolve_reasoning_effort_accepts_full_range() {
        let effort = |v: &str| {
            let value = json!(v);
            DeepSeekV4Formatter::resolve_reasoning_effort(Some(&value))
        };

        assert_eq!(effort("max"), (false, Some(ReasoningEffort::Max)));
        assert_eq!(effort("xhigh"), (false, Some(ReasoningEffort::High)));
        assert_eq!(effort("high"), (false, Some(ReasoningEffort::High)));
        assert_eq!(effort("minimal"), (false, None));
        assert_eq!(effort("low"), (false, None));
        assert_eq!(effort("medium"), (false, Some(ReasoningEffort::High)));
        assert_eq!(effort("none"), (true, None));
        assert_eq!(effort("bogus"), (false, Some(ReasoningEffort::High)));
        assert_eq!(
            DeepSeekV4Formatter::resolve_reasoning_effort(None),
            (false, Some(ReasoningEffort::High))
        );
    }

    #[test]
    fn test_render_leaves_null_assistant_tool_content_empty() {
        use crate::OAIPromptFormatter;

        let req = MockRequest::new(json!([
            {"role": "user", "content": "call tool"},
            {"role": "assistant", "content": null, "tool_calls": [{
                "id": "c1", "type": "function",
                "function": {"name": "f", "arguments": "{}"}
            }]}
        ]));

        let formatter = DeepSeekV4Formatter::new_chat();
        let out = formatter.render(&req).unwrap();

        assert!(out.contains(&format!(
            "<{}{}>",
            tokens::DSML_TOKEN,
            TOOL_CALLS_BLOCK_NAME
        )));
        assert!(!out.contains("null"));
    }

    #[test]
    fn test_render_wires_reasoning_effort_from_chat_template_args() {
        use crate::OAIPromptFormatter;
        use std::collections::HashMap;

        for (effort, expected) in [
            ("high", REASONING_EFFORT_HIGH),
            ("max", REASONING_EFFORT_MAX),
        ] {
            let mut args = HashMap::new();
            args.insert("reasoning_effort".to_string(), json!(effort));

            let req = MockRequest::new(json!([
                {"role": "system", "content": "sys"},
                {"role": "user", "content": "hi"}
            ]))
            .with_chat_template_args(args);

            let formatter = DeepSeekV4Formatter::new_thinking();
            let out = formatter.render(&req).unwrap();

            assert!(out.starts_with(tokens::BOS));
            assert!(
                out[tokens::BOS.len()..].starts_with(expected),
                "{effort} preamble should appear after BOS, got:\n{out}"
            );
        }
    }

    #[test]
    fn test_render_wires_top_level_reasoning_effort_and_none_disables_thinking() {
        use crate::OAIPromptFormatter;

        let formatter = DeepSeekV4Formatter::new_thinking();
        for (effort, expected_prefix) in [
            ("high", "Reasoning Effort: Absolute maximum"),
            ("max", "Reasoning Effort: Beyond maximum"),
        ] {
            let req: dynamo_protocols::types::CreateChatCompletionRequest =
                serde_json::from_value(json!({
                    "model": "deepseek-v4",
                    "messages": [{"role": "user", "content": "hi"}],
                    "reasoning_effort": effort
                }))
                .unwrap();
            let out = formatter.render(&req).unwrap();

            assert!(
                out[tokens::BOS.len()..].starts_with(expected_prefix),
                "top-level {effort} did not select its prefix: {out}"
            );
            assert!(out.ends_with(tokens::THINKING_START));
        }

        let req: dynamo_protocols::types::CreateChatCompletionRequest =
            serde_json::from_value(json!({
                "model": "deepseek-v4",
                "messages": [{"role": "user", "content": "hi"}],
                "reasoning_effort": "none"
            }))
            .unwrap();
        let out = formatter.render(&req).unwrap();

        assert_eq!(
            out,
            "<｜begin▁of▁sentence｜><｜User｜>hi<｜Assistant｜></think>"
        );
    }

    #[test]
    fn test_top_level_reasoning_effort_precedes_template_argument() {
        use crate::OAIPromptFormatter;
        use std::collections::HashMap;

        let mut args = HashMap::new();
        args.insert("reasoning_effort".to_string(), json!("max"));
        let req = MockRequest::new(json!([{"role": "user", "content": "hi"}]))
            .with_chat_template_args(args)
            .with_reasoning_effort(json!("low"));

        let out = DeepSeekV4Formatter::new_thinking().render(&req).unwrap();

        assert_eq!(
            out,
            "<｜begin▁of▁sentence｜><｜User｜>hi<｜Assistant｜><think>"
        );
    }

    #[test]
    fn test_render_drop_thinking_override_from_chat_template_args() {
        use crate::OAIPromptFormatter;
        use std::collections::HashMap;

        let messages = json!([
            {"role": "user", "content": "first"},
            {"role": "assistant", "reasoning_content": "PRIOR", "content": "reply"},
            {"role": "user", "content": "again"}
        ]);

        // Default (drop_thinking=true): prior reasoning stripped.
        let req_default = MockRequest::new(messages.clone());
        let formatter = DeepSeekV4Formatter::new_thinking();
        let out_default = formatter.render(&req_default).unwrap();
        assert!(
            !out_default.contains("PRIOR"),
            "default drop_thinking=true should strip prior reasoning, got:\n{}",
            out_default
        );

        // drop_thinking=false override: prior reasoning survives.
        let mut args = HashMap::new();
        args.insert("drop_thinking".to_string(), json!(false));
        let req_keep = MockRequest::new(messages).with_chat_template_args(args);
        let out_keep = formatter.render(&req_keep).unwrap();
        assert!(
            out_keep.contains("PRIOR"),
            "drop_thinking=false override should preserve prior reasoning, got:\n{}",
            out_keep
        );
    }

    // N4: developer-role interactions with drop_thinking.
    // find_last_user_index returns the index of user OR developer messages; the
    // drop_thinking reasoning cutoff and the thinking-seed insertion treat
    // user and developer identically.

    #[test]
    fn test_developer_only_conversation_renders_developer_content() {
        let messages = json!([
            {"role": "system", "content": "sys"},
            {"role": "developer", "content": "x"},
            {"role": "assistant", "reasoning_content": "R", "content": "ok"}
        ]);
        let out =
            encode_messages(messages.as_array().unwrap(), ThinkingMode::Thinking, true).unwrap();
        assert!(
            out.contains("x"),
            "developer content should appear in output, got:\n{}",
            out
        );
    }

    #[test]
    fn test_developer_as_last_user_index_controls_reasoning_cutoff() {
        // Indices: 0=user, 1=assistant(FIRST), 2=developer(y), 3=assistant(SECOND).
        // find_last_user_index = 2 (developer). With drop_thinking=true:
        //   - assistant idx=1 < 2  → reasoning_content stripped.
        //   - assistant idx=3 >= 2 → reasoning_content preserved.
        let messages = json!([
            {"role": "user", "content": "a"},
            {"role": "assistant", "reasoning_content": "FIRST", "content": "r1"},
            {"role": "developer", "content": "y"},
            {"role": "assistant", "reasoning_content": "SECOND", "content": "r2"}
        ]);
        let out =
            encode_messages(messages.as_array().unwrap(), ThinkingMode::Thinking, true).unwrap();
        assert!(
            !out.contains("FIRST"),
            "reasoning before last user/developer (idx 1 < 2) should be stripped, got:\n{}",
            out
        );
        assert!(
            out.contains("SECOND"),
            "reasoning at/after last user/developer (idx 3 > 2) should survive, got:\n{}",
            out
        );
    }
}