dynamic-mcp 1.5.0

MCP proxy server that reduces LLM context overhead with on-demand tool loading from multiple upstream servers.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
use crate::proxy::types::{JsonRpcError, JsonRpcRequest, JsonRpcResponse};
use crate::proxy::ModularMcpClient;
use anyhow::Result;
use serde_json::json;
use std::collections::HashSet;
use std::sync::Arc;

pub struct ModularMcpServer {
    client: Arc<tokio::sync::RwLock<ModularMcpClient>>,
    name: String,
    version: String,
    subscriptions: Arc<tokio::sync::RwLock<HashSet<String>>>,
}

impl ModularMcpServer {
    pub fn new(
        client: Arc<tokio::sync::RwLock<ModularMcpClient>>,
        name: String,
        version: String,
    ) -> Self {
        Self {
            client,
            name,
            version,
            subscriptions: Arc::new(tokio::sync::RwLock::new(HashSet::new())),
        }
    }

    pub async fn handle_request(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        match request.method.as_str() {
            "initialize" => self.handle_initialize(request).await,
            "tools/list" => self.handle_list_tools(request).await,
            "tools/call" => self.handle_call_tool(request).await,
            "resources/list" => self.handle_resources_list(request).await,
            "resources/read" => self.handle_resources_read(request).await,
            "resources/templates/list" => self.handle_resources_templates_list(request).await,
            "resources/subscribe" => self.handle_resources_subscribe(request).await,
            "resources/unsubscribe" => self.handle_resources_unsubscribe(request).await,
            "prompts/list" => self.handle_prompts_list(request).await,
            "prompts/get" => self.handle_prompts_get(request).await,
            _ => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: None,
                error: Some(JsonRpcError {
                    code: -32601,
                    message: format!("Method not found: {}", request.method),
                    data: None,
                }),
            },
        }
    }

    async fn handle_initialize(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        JsonRpcResponse {
            jsonrpc: "2.0".to_string(),
            id: request.id,
            result: Some(json!({
                "protocolVersion": "2024-11-05",
                "capabilities": {
                    "tools": {},
                    "resources": {
                        "subscribe": true
                    },
                    "prompts": {}
                },
                "serverInfo": {
                    "name": self.name,
                    "version": self.version
                }
            })),
            error: None,
        }
    }

    async fn handle_list_tools(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;
        let groups = client.list_groups();
        let failed_groups = client.list_failed_groups();

        let group_names: Vec<String> = groups.iter().map(|g| g.name.clone()).collect();

        let groups_desc = groups
            .iter()
            .map(|g| format!("- {}: {}", g.name, g.description))
            .collect::<Vec<_>>()
            .join("\n");

        let failed_desc = if !failed_groups.is_empty() {
            let failed = failed_groups
                .iter()
                .map(|g| format!("- {}: {} (Error: {})", g.name, g.description, g.error))
                .collect::<Vec<_>>()
                .join("\n");
            format!("\n\nUnavailable groups (connection failed):\n{}", failed)
        } else {
            String::new()
        };

        let get_tools_desc = format!(
            "dynamic-mcp manages multiple MCP servers as organized groups, \
            providing only the necessary group's tool descriptions to the LLM \
            on demand instead of overwhelming it with all tool descriptions at once.\n\n\
            Use this tool to retrieve available tools in a specific group, \
            then use call_dynamic_tool to execute them.\n\n\
            Available groups:\n{}{}",
            groups_desc, failed_desc
        );

        let call_tool_desc = r#"Execute a tool from a specific MCP group. Proxies the call to the appropriate upstream MCP server.

Use get_dynamic_tools first to discover available tools and their input schemas in the specified group, then use this tool to execute them.

This maintains a clean separation between discovery (context-efficient) and execution phases, enabling effective management of large tool collections across multiple MCP servers.

Example usage:
  call_dynamic_tool(group="playwright", name="browser_navigate", args={"url": "https://example.com"})
  → Executes the browser_navigate tool from the playwright group with the specified arguments"#;

        JsonRpcResponse {
            jsonrpc: "2.0".to_string(),
            id: request.id,
            result: Some(json!({
                "tools": [
                    {
                        "name": "get_dynamic_tools",
                        "description": get_tools_desc,
                        "inputSchema": {
                            "type": "object",
                            "properties": {
                                "group": {
                                    "type": "string",
                                    "description": "The name of the MCP group to get tools from",
                                    "enum": group_names
                                }
                            },
                            "required": ["group"]
                        }
                    },
                    {
                        "name": "call_dynamic_tool",
                        "description": call_tool_desc,
                        "inputSchema": {
                            "type": "object",
                            "properties": {
                                "group": {
                                    "type": "string",
                                    "description": "The name of the MCP group containing the tool",
                                    "enum": group_names
                                },
                                "name": {
                                    "type": "string",
                                    "description": "The name of the tool to execute"
                                },
                                "args": {
                                    "type": "object",
                                    "description": "Arguments to pass to the tool",
                                    "additionalProperties": true
                                }
                            },
                            "required": ["group", "name"]
                        }
                    }
                ]
            })),
            error: None,
        }
    }

    async fn handle_call_tool(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let params = request.params.clone().unwrap_or(json!({}));
        let tool_name = params.get("name").and_then(|v| v.as_str()).unwrap_or("");
        let arguments = params.get("arguments").cloned().unwrap_or(json!({}));

        match tool_name {
            "get_dynamic_tools" => {
                let group = arguments.get("group").and_then(|v| v.as_str());

                if group.is_none() {
                    return JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: None,
                        error: Some(JsonRpcError {
                            code: -32602,
                            message: "Missing required parameter: group".to_string(),
                            data: None,
                        }),
                    };
                }

                let client = self.client.read().await;
                match client.list_tools(group.unwrap()) {
                    Ok(tools) => {
                        let tools_json: Vec<_> = tools
                            .iter()
                            .map(|tool| {
                                let mut schema = tool.input_schema.clone();
                                if let Some(obj) = schema.as_object_mut() {
                                    obj.remove("$schema");
                                }
                                json!({
                                    "name": tool.name,
                                    "description": tool.description,
                                    "inputSchema": schema
                                })
                            })
                            .collect();

                        JsonRpcResponse {
                            jsonrpc: "2.0".to_string(),
                            id: request.id,
                            result: Some(json!({
                                "content": [
                                    {
                                        "type": "text",
                                        "text": serde_json::to_string_pretty(&tools_json).unwrap_or_else(|_| "[]".to_string())
                                    }
                                ]
                            })),
                            error: None,
                        }
                    }
                    Err(e) => JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: None,
                        error: Some(JsonRpcError {
                            code: -32603,
                            message: format!("Failed to list tools: {}", e),
                            data: None,
                        }),
                    },
                }
            }
            "call_dynamic_tool" => {
                let group = arguments.get("group").and_then(|v| v.as_str());
                let name = arguments.get("name").and_then(|v| v.as_str());
                let args = arguments.get("args").cloned().unwrap_or(json!({}));

                if group.is_none() || name.is_none() {
                    return JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: None,
                        error: Some(JsonRpcError {
                            code: -32602,
                            message: "Missing required parameters: group and name".to_string(),
                            data: None,
                        }),
                    };
                }

                let client = self.client.read().await;
                match client.call_tool(group.unwrap(), name.unwrap(), args).await {
                    Ok(result) => JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: Some(result),
                        error: None,
                    },
                    Err(e) => JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: Some(json!({
                            "content": [{
                                "type": "text",
                                "text": format!("Tool execution failed: {}", e),
                                "isError": true
                            }]
                        })),
                        error: None,
                    },
                }
            }
            _ => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: None,
                error: Some(JsonRpcError {
                    code: -32601,
                    message: format!("Unknown tool: {}", tool_name),
                    data: None,
                }),
            },
        }
    }

    async fn handle_resources_list(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;

        let group_name_opt = request
            .params
            .as_ref()
            .and_then(|p| p.get("group"))
            .and_then(|g| g.as_str())
            .map(String::from);

        let cursor = request
            .params
            .as_ref()
            .and_then(|p| p.get("cursor"))
            .and_then(|c| c.as_str())
            .map(String::from);

        match group_name_opt {
            Some(group_name) => match client.proxy_resources_list(&group_name, cursor).await {
                Ok(result) => JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: Some(result),
                    error: None,
                },
                Err(e) => JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32603,
                        message: format!("Failed to list resources: {}", e),
                        data: None,
                    }),
                },
            },
            None => {
                let groups = client.list_groups();
                let mut all_resources = Vec::new();

                for group in groups {
                    if let Ok(result) = client.proxy_resources_list(&group.name, None).await {
                        if let Some(resources_array) =
                            result.get("resources").and_then(|v| v.as_array())
                        {
                            all_resources.extend(resources_array.iter().cloned());
                        }
                    }
                }

                JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: Some(json!({
                        "resources": all_resources
                    })),
                    error: None,
                }
            }
        }
    }

    async fn handle_resources_read(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;

        let uri = match request.params.as_ref() {
            Some(params) => match params.get("uri").and_then(|u| u.as_str()).map(String::from) {
                Some(u) => u,
                None => {
                    return JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: request.id,
                        result: None,
                        error: Some(JsonRpcError {
                            code: -32602,
                            message: "Missing required parameter: uri".to_string(),
                            data: None,
                        }),
                    };
                }
            },
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: "Missing params object".to_string(),
                        data: None,
                    }),
                };
            }
        };

        // Find which group has this resource
        let groups = client.list_groups();
        let mut found_group: Option<String> = None;

        for group in groups {
            if let Ok(result) = client.proxy_resources_list(&group.name, None).await {
                if let Some(resources_array) = result.get("resources").and_then(|v| v.as_array()) {
                    for resource in resources_array {
                        if let Some(resource_uri) = resource.get("uri").and_then(|u| u.as_str()) {
                            if resource_uri == uri {
                                found_group = Some(group.name.clone());
                                break;
                            }
                        }
                    }
                }
                if found_group.is_some() {
                    break;
                }
            }
        }

        let group_name = match found_group {
            Some(g) => g,
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: format!("Resource not found: {}", uri),
                        data: None,
                    }),
                };
            }
        };

        match client.proxy_resources_read(&group_name, uri).await {
            Ok(result) => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: Some(result),
                error: None,
            },
            Err(e) => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: None,
                error: Some(JsonRpcError {
                    code: -32603,
                    message: format!("Failed to read resource: {}", e),
                    data: None,
                }),
            },
        }
    }

    async fn handle_resources_templates_list(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;
        let groups = client.list_groups();
        let mut all_templates = Vec::new();

        for group in groups {
            if let Ok(result) = client.proxy_resources_templates_list(&group.name).await {
                if let Some(templates_array) =
                    result.get("resourceTemplates").and_then(|v| v.as_array())
                {
                    all_templates.extend(templates_array.iter().cloned());
                }
            }
        }

        JsonRpcResponse {
            jsonrpc: "2.0".to_string(),
            id: request.id,
            result: Some(json!({
                "resourceTemplates": all_templates
            })),
            error: None,
        }
    }

    async fn handle_resources_subscribe(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let uri = match request
            .params
            .as_ref()
            .and_then(|p| p.get("uri"))
            .and_then(|u| u.as_str())
        {
            Some(uri) => uri.to_string(),
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: "Missing required parameter: uri".to_string(),
                        data: None,
                    }),
                };
            }
        };

        let mut subs = self.subscriptions.write().await;
        subs.insert(uri.clone());
        tracing::debug!("Client subscribed to resource changes for uri: {}", uri);

        JsonRpcResponse {
            jsonrpc: "2.0".to_string(),
            id: request.id,
            result: Some(json!({})),
            error: None,
        }
    }

    async fn handle_resources_unsubscribe(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let uri = match request
            .params
            .as_ref()
            .and_then(|p| p.get("uri"))
            .and_then(|u| u.as_str())
        {
            Some(uri) => uri.to_string(),
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: "Missing required parameter: uri".to_string(),
                        data: None,
                    }),
                };
            }
        };

        let mut subs = self.subscriptions.write().await;
        subs.remove(&uri);
        tracing::debug!("Client unsubscribed from resource changes for uri: {}", uri);

        JsonRpcResponse {
            jsonrpc: "2.0".to_string(),
            id: request.id,
            result: Some(json!({})),
            error: None,
        }
    }

    async fn handle_prompts_list(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;

        let group_name_opt = request
            .params
            .as_ref()
            .and_then(|p| p.get("group"))
            .and_then(|g| g.as_str())
            .map(String::from);

        let cursor = request
            .params
            .as_ref()
            .and_then(|p| p.get("cursor"))
            .and_then(|c| c.as_str())
            .map(String::from);

        match group_name_opt {
            Some(group_name) => match client.proxy_prompts_list(&group_name, cursor).await {
                Ok(result) => JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: Some(result),
                    error: None,
                },
                Err(e) => JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32603,
                        message: format!("Failed to list prompts: {}", e),
                        data: None,
                    }),
                },
            },
            None => {
                let groups = client.list_groups();
                let mut all_prompts = Vec::new();

                for group in groups {
                    if let Ok(result) = client.proxy_prompts_list(&group.name, None).await {
                        if let Some(prompts_array) =
                            result.get("prompts").and_then(|v| v.as_array())
                        {
                            all_prompts.extend(prompts_array.iter().cloned());
                        }
                    }
                }

                JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: Some(json!({
                        "prompts": all_prompts
                    })),
                    error: None,
                }
            }
        }
    }

    async fn handle_prompts_get(&self, request: JsonRpcRequest) -> JsonRpcResponse {
        let client = self.client.read().await;

        let (prompt_name, arguments) = match request.params.as_ref() {
            Some(params) => {
                let name = params
                    .get("name")
                    .and_then(|n| n.as_str())
                    .map(String::from);
                let args = params.get("arguments").cloned();

                match name {
                    Some(n) => (n, args),
                    None => {
                        return JsonRpcResponse {
                            jsonrpc: "2.0".to_string(),
                            id: request.id,
                            result: None,
                            error: Some(JsonRpcError {
                                code: -32602,
                                message: "Missing required parameter: name".to_string(),
                                data: None,
                            }),
                        };
                    }
                }
            }
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: "Missing params object".to_string(),
                        data: None,
                    }),
                };
            }
        };

        // Find which group has this prompt
        let groups = client.list_groups();
        let mut found_group: Option<String> = None;

        for group in groups {
            if let Ok(result) = client.proxy_prompts_list(&group.name, None).await {
                if let Some(prompts_array) = result.get("prompts").and_then(|v| v.as_array()) {
                    for prompt in prompts_array {
                        if let Some(prompt_name_str) = prompt.get("name").and_then(|n| n.as_str()) {
                            if prompt_name_str == prompt_name {
                                found_group = Some(group.name.clone());
                                break;
                            }
                        }
                    }
                }
                if found_group.is_some() {
                    break;
                }
            }
        }

        let group_name = match found_group {
            Some(g) => g,
            None => {
                return JsonRpcResponse {
                    jsonrpc: "2.0".to_string(),
                    id: request.id,
                    result: None,
                    error: Some(JsonRpcError {
                        code: -32602,
                        message: format!("Prompt not found: {}", prompt_name),
                        data: None,
                    }),
                };
            }
        };

        match client
            .proxy_prompts_get(&group_name, prompt_name, arguments)
            .await
        {
            Ok(result) => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: Some(result),
                error: None,
            },
            Err(e) => JsonRpcResponse {
                jsonrpc: "2.0".to_string(),
                id: request.id,
                result: None,
                error: Some(JsonRpcError {
                    code: -32603,
                    message: format!("Failed to get prompt: {}", e),
                    data: None,
                }),
            },
        }
    }

    #[allow(dead_code)]
    async fn get_active_subscriptions(&self) -> HashSet<String> {
        let subs = self.subscriptions.read().await;
        subs.clone()
    }

    #[allow(dead_code)]
    fn validate_prompt_arguments(
        &self,
        arguments: &Option<serde_json::Value>,
        argument_schema: &Option<Vec<crate::proxy::types::PromptArgument>>,
    ) -> Result<(), String> {
        if let Some(schema) = argument_schema {
            let provided = arguments
                .as_ref()
                .and_then(|a| a.as_object())
                .map(|o| o.keys().cloned().collect::<HashSet<_>>())
                .unwrap_or_default();

            for arg in schema {
                if arg.required && !provided.contains(arg.name.as_str()) {
                    return Err(format!("Missing required prompt argument: {}", arg.name));
                }
            }
        }
        Ok(())
    }

    pub async fn run_stdio(&self) -> Result<()> {
        use crate::proxy::types::JsonRpcMessage;
        use tokio::io::{AsyncBufReadExt, AsyncWriteExt, BufReader};

        let stdin = tokio::io::stdin();
        let mut stdout = tokio::io::stdout();
        let mut reader = BufReader::new(stdin);
        let mut line = String::new();

        tracing::info!("MCP server listening on stdio");

        loop {
            line.clear();
            let bytes_read = reader.read_line(&mut line).await?;

            if bytes_read == 0 {
                break;
            }

            let trimmed = line.trim();
            if trimmed.is_empty() {
                continue;
            }

            // Try to parse as JsonRpcMessage (handles both single request and batch array)
            match serde_json::from_str::<JsonRpcMessage>(trimmed) {
                Ok(JsonRpcMessage::Batch(requests)) => {
                    tracing::debug!("Received batch request with {} requests", requests.len());

                    if requests.is_empty() {
                        // Empty batch is invalid per JSON-RPC spec
                        let error_response = JsonRpcResponse {
                            jsonrpc: "2.0".to_string(),
                            id: serde_json::Value::Null,
                            result: None,
                            error: Some(JsonRpcError {
                                code: -32600,
                                message: "Invalid Request: batch array cannot be empty".to_string(),
                                data: None,
                            }),
                        };
                        let response_json = serde_json::to_string(&error_response)?;
                        stdout.write_all(response_json.as_bytes()).await?;
                        stdout.write_all(b"\n").await?;
                        stdout.flush().await?;
                        continue;
                    }

                    // Process all requests in the batch
                    let mut responses = Vec::new();
                    let mut has_notifications_only = true;

                    for request in requests {
                        let is_notification = matches!(request.id, serde_json::Value::Null);

                        if !is_notification {
                            has_notifications_only = false;
                            tracing::debug!("Processing batch request: {}", request.method);
                            let response = self.handle_request(request).await;
                            responses.push(response);
                        } else {
                            tracing::debug!(
                                "Received notification in batch: {} (no response needed)",
                                request.method
                            );
                        }
                    }

                    // Only send response if batch contained at least one non-notification
                    if !has_notifications_only {
                        let response_json = serde_json::to_string(&responses)?;
                        stdout.write_all(response_json.as_bytes()).await?;
                        stdout.write_all(b"\n").await?;
                        stdout.flush().await?;
                    }
                }
                Ok(JsonRpcMessage::Request(request)) => {
                    let is_notification = matches!(request.id, serde_json::Value::Null);

                    if is_notification {
                        tracing::debug!(
                            "Received notification: {} (no response needed)",
                            request.method
                        );
                        continue;
                    }

                    tracing::debug!("Received request: {}", request.method);
                    let response = self.handle_request(request).await;
                    let response_json = serde_json::to_string(&response)?;
                    stdout.write_all(response_json.as_bytes()).await?;
                    stdout.write_all(b"\n").await?;
                    stdout.flush().await?;
                }
                Err(e) => {
                    tracing::error!("Failed to parse request: {}. Raw input: {}", e, trimmed);
                    let error_response = JsonRpcResponse {
                        jsonrpc: "2.0".to_string(),
                        id: serde_json::Value::Null,
                        result: None,
                        error: Some(JsonRpcError {
                            code: -32700,
                            message: format!("Parse error: {}", e),
                            data: None,
                        }),
                    };
                    let response_json = serde_json::to_string(&error_response)?;
                    stdout.write_all(response_json.as_bytes()).await?;
                    stdout.write_all(b"\n").await?;
                    stdout.flush().await?;
                }
            }
        }

        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::proxy::ModularMcpClient;

    fn create_test_server() -> ModularMcpServer {
        let client = ModularMcpClient::new();
        ModularMcpServer::new(
            Arc::new(tokio::sync::RwLock::new(client)),
            "test-server".to_string(),
            "1.0.0".to_string(),
        )
    }

    #[tokio::test]
    async fn test_handle_initialize() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "initialize");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());

        let result = response.result.unwrap();
        assert_eq!(result.get("protocolVersion").unwrap(), "2024-11-05");
        assert_eq!(
            result
                .get("serverInfo")
                .unwrap()
                .get("name")
                .unwrap()
                .as_str()
                .unwrap(),
            "test-server"
        );
    }

    #[tokio::test]
    async fn test_handle_list_tools_empty() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/list");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());

        let result = response.result.unwrap();
        let tools = result.get("tools").unwrap().as_array().unwrap();
        assert_eq!(tools.len(), 2);
        assert_eq!(
            tools[0].get("name").unwrap().as_str().unwrap(),
            "get_dynamic_tools"
        );
        assert_eq!(
            tools[1].get("name").unwrap().as_str().unwrap(),
            "call_dynamic_tool"
        );
    }

    #[tokio::test]
    async fn test_handle_unknown_method() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "unknown/method");
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32601);
        assert!(error.message.contains("Method not found"));
    }

    #[tokio::test]
    async fn test_handle_call_tool_missing_params() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/call")
            .with_params(json!({"name": "get_dynamic_tools", "arguments": {}}));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Missing required parameter"));
    }

    #[tokio::test]
    async fn test_handle_call_tool_unknown_tool() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/call").with_params(json!({
            "name": "unknown-tool",
            "arguments": {}
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32601);
        assert!(error.message.contains("Unknown tool"));
    }

    #[tokio::test]
    async fn test_handle_get_dynamic_tools_nonexistent_group() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/call").with_params(json!({
            "name": "get_dynamic_tools",
            "arguments": {
                "group": "nonexistent"
            }
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32603);
        assert!(error.message.contains("Failed to list tools"));
    }

    #[tokio::test]
    async fn test_handle_call_dynamic_tool_missing_group() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/call").with_params(json!({
            "name": "call_dynamic_tool",
            "arguments": {
                "name": "some-tool"
            }
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
    }

    #[tokio::test]
    async fn test_handle_call_dynamic_tool_missing_name() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/call").with_params(json!({
            "name": "call_dynamic_tool",
            "arguments": {
                "group": "some-group"
            }
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
    }

    #[tokio::test]
    async fn test_initialize_includes_resources_capability() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "initialize");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        let result = response.result.unwrap();
        let capabilities = result.get("capabilities").unwrap();

        assert!(capabilities.get("resources").is_some());
        let resources = capabilities.get("resources").unwrap();
        assert_eq!(resources.get("subscribe").unwrap(), true);
    }

    #[tokio::test]
    async fn test_handle_resources_list_missing_group() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/list").with_params(json!({
            "cursor": None::<String>
        }));
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());
        let result = response.result.unwrap();
        assert!(result.get("resources").is_some());
        let resources = result.get("resources").unwrap().as_array().unwrap();
        assert_eq!(resources.len(), 0);
    }

    #[tokio::test]
    async fn test_handle_resources_list_nonexistent_group() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/list").with_params(json!({
            "group": "nonexistent"
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32603);
        assert!(error.message.contains("Failed to list resources"));
    }

    #[tokio::test]
    async fn test_handle_resources_read_resource_not_found() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/read").with_params(json!({
            "uri": "file:///nonexistent.txt"
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Resource not found"));
    }

    #[tokio::test]
    async fn test_handle_resources_read_missing_uri() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/read").with_params(json!({
            "group": "some-group"
        }));
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Missing required parameter: uri"));
    }

    #[tokio::test]
    async fn test_handle_resources_read_no_params() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/read");
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Missing params object"));
    }

    #[tokio::test]
    async fn test_handle_resources_read_auto_routes_to_correct_group() {
        let server = create_test_server();
        // This test would need a mock setup to verify the resource is found in the correct group
        // For now, testing that uri-only requests work (group parameter is discovered automatically)
        let request = JsonRpcRequest::new(1, "resources/read").with_params(json!({
            "uri": "file:///test.txt"
        }));
        let response = server.handle_request(request).await;

        // Should either succeed (if resource found) or return "Resource not found" (not "Missing required parameters")
        if let Some(error) = &response.error {
            assert!(
                error.message.contains("Resource not found")
                    || error.message.contains("Failed to read resource")
            );
            assert!(!error.message.contains("Missing required parameters"));
        }
    }

    #[tokio::test]
    async fn test_config_parsing() {
        let config_json = r#"{
            "mcpServers": {
                "test-server": {
                    "description": "Comprehensive MCP server with tools and resources",
                    "command": "npx",
                    "args": ["-y", "@modelcontextprotocol/server-everything"]
                }
            }
        }"#;

        let parsed: serde_json::Value =
            serde_json::from_str(config_json).expect("Config should parse");

        assert!(parsed.get("mcpServers").is_some());
        let servers = parsed.get("mcpServers").unwrap().as_object().unwrap();
        assert!(servers.contains_key("test-server"));

        let server = &servers["test-server"];
        assert_eq!(
            server.get("description").unwrap().as_str().unwrap(),
            "Comprehensive MCP server with tools and resources"
        );
    }

    #[tokio::test]
    async fn test_tools_list_structure_for_comprehensive_servers() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "tools/list");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());

        let result = response.result.unwrap();
        assert!(result.is_object());

        let has_tools = result.get("tools").is_some() || result.get("_meta").is_some();
        assert!(
            has_tools,
            "Response should have tools info or metadata for empty client"
        );
    }

    #[tokio::test]
    async fn test_resources_list_protocol_compliance() {
        let server = create_test_server();
        let request =
            JsonRpcRequest::new(1, "resources/list").with_params(json!({ "group": "test" }));
        let response = server.handle_request(request).await;

        assert!(response.jsonrpc == "2.0");
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert!(error.code <= -32600);
    }

    #[tokio::test]
    async fn test_resources_read_protocol_compliance() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/read")
            .with_params(json!({ "uri": "file:///test.txt" }));
        let response = server.handle_request(request).await;

        assert!(response.jsonrpc == "2.0");
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert!(error.code <= -32600);
    }

    #[tokio::test]
    async fn test_initialize_includes_tools_and_resources_capabilities() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "initialize");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        let result = response.result.unwrap();
        let capabilities = result.get("capabilities").unwrap();

        assert!(
            capabilities.get("tools").is_some(),
            "Should have tools capability"
        );
        assert!(
            capabilities.get("resources").is_some(),
            "Should have resources capability"
        );

        let resources_cap = capabilities.get("resources").unwrap();
        assert!(
            resources_cap.get("subscribe").is_some(),
            "Resources should declare subscribe capability"
        );
    }

    #[tokio::test]
    async fn test_handle_prompts_list_missing_group() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "prompts/list");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());
        let result = response.result.unwrap();
        assert!(result.get("prompts").is_some());
        let prompts = result.get("prompts").unwrap().as_array().unwrap();
        assert_eq!(prompts.len(), 0);
    }

    #[tokio::test]
    async fn test_handle_prompts_list_nonexistent_group() {
        let server = create_test_server();
        let request =
            JsonRpcRequest::new(1, "prompts/list").with_params(json!({ "group": "nonexistent" }));
        let response = server.handle_request(request).await;

        assert!(response.error.is_some());
        let error = response.error.unwrap();
        assert_eq!(error.code, -32603);
    }

    #[tokio::test]
    async fn test_handle_prompts_get_auto_routes_to_correct_group() {
        let server = create_test_server();
        let request =
            JsonRpcRequest::new(1, "prompts/get").with_params(json!({ "name": "test_prompt" }));
        let response = server.handle_request(request).await;

        // Should either succeed (if prompt found) or return "Prompt not found" (not "Missing required parameters")
        if let Some(error) = &response.error {
            assert!(
                error.message.contains("Prompt not found")
                    || error.message.contains("Failed to get prompt")
            );
            assert!(!error.message.contains("Missing required parameters"));
        }
    }

    #[tokio::test]
    async fn test_handle_prompts_get_missing_name() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "prompts/get").with_params(json!({ "group": "test" }));
        let response = server.handle_request(request).await;

        assert!(response.error.is_some());
        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Missing required parameter: name"));
    }

    #[tokio::test]
    async fn test_handle_prompts_get_nonexistent_prompt() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "prompts/get")
            .with_params(json!({ "name": "nonexistent_prompt" }));
        let response = server.handle_request(request).await;

        assert!(response.error.is_some());
        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("Prompt not found"));
    }

    #[tokio::test]
    async fn test_prompts_list_protocol_compliance() {
        let server = create_test_server();
        let request =
            JsonRpcRequest::new(1, "prompts/list").with_params(json!({ "group": "test" }));
        let response = server.handle_request(request).await;

        assert!(response.jsonrpc == "2.0");
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert!(error.code <= -32600);
    }

    #[tokio::test]
    async fn test_prompts_get_protocol_compliance() {
        let server = create_test_server();
        let request =
            JsonRpcRequest::new(1, "prompts/get").with_params(json!({ "name": "test_prompt" }));
        let response = server.handle_request(request).await;

        assert!(response.jsonrpc == "2.0");
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert!(error.code <= -32600);
    }

    #[tokio::test]
    async fn test_prompts_capability_declared() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "initialize");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        let result = response.result.unwrap();
        let capabilities = result.get("capabilities").unwrap();

        assert!(
            capabilities.get("prompts").is_some(),
            "Should have prompts capability"
        );
    }

    #[tokio::test]
    async fn test_batch_request_parsing() {
        use crate::proxy::types::JsonRpcMessage;

        let batch_json = r#"[
            {"jsonrpc": "2.0", "id": 1, "method": "initialize"},
            {"jsonrpc": "2.0", "id": 2, "method": "tools/list"}
        ]"#;

        let result: Result<JsonRpcMessage, _> = serde_json::from_str(batch_json);
        assert!(result.is_ok());

        match result.unwrap() {
            JsonRpcMessage::Batch(requests) => {
                assert_eq!(requests.len(), 2);
                assert_eq!(requests[0].method, "initialize");
                assert_eq!(requests[1].method, "tools/list");
            }
            JsonRpcMessage::Request(_) => panic!("Expected batch, got single request"),
        }
    }

    #[tokio::test]
    async fn test_single_request_parsing() {
        use crate::proxy::types::JsonRpcMessage;

        let request_json = r#"{"jsonrpc": "2.0", "id": 1, "method": "initialize"}"#;
        let result: Result<JsonRpcMessage, _> = serde_json::from_str(request_json);
        assert!(result.is_ok());

        match result.unwrap() {
            JsonRpcMessage::Request(request) => {
                assert_eq!(request.method, "initialize");
                assert_eq!(request.id, serde_json::json!(1));
            }
            JsonRpcMessage::Batch(_) => panic!("Expected single request, got batch"),
        }
    }

    #[tokio::test]
    async fn test_batch_with_notifications() {
        use crate::proxy::types::JsonRpcMessage;

        let batch_json = r#"[
            {"jsonrpc": "2.0", "id": 1, "method": "initialize"},
            {"jsonrpc": "2.0", "method": "notified"},
            {"jsonrpc": "2.0", "id": 2, "method": "tools/list"}
        ]"#;

        let result: Result<JsonRpcMessage, _> = serde_json::from_str(batch_json);
        assert!(result.is_ok());

        match result.unwrap() {
            JsonRpcMessage::Batch(requests) => {
                assert_eq!(requests.len(), 3);
                // First is normal request
                assert_eq!(requests[0].id, serde_json::json!(1));
                // Second is notification (id should be null)
                assert!(matches!(requests[1].id, serde_json::Value::Null));
                // Third is normal request
                assert_eq!(requests[2].id, serde_json::json!(2));
            }
            JsonRpcMessage::Request(_) => panic!("Expected batch, got single request"),
        }
    }

    #[tokio::test]
    async fn test_batch_response_order_preserved() {
        let server = create_test_server();

        let req1 = JsonRpcRequest::new(1, "initialize");
        let req2 = JsonRpcRequest::new(2, "initialize");
        let req3 = JsonRpcRequest::new(3, "initialize");

        let resp1 = server.handle_request(req1).await;
        let resp2 = server.handle_request(req2).await;
        let resp3 = server.handle_request(req3).await;

        assert_eq!(resp1.id, serde_json::json!(1));
        assert_eq!(resp2.id, serde_json::json!(2));
        assert_eq!(resp3.id, serde_json::json!(3));
    }

    #[tokio::test]
    async fn test_empty_batch_is_invalid() {
        use crate::proxy::types::JsonRpcMessage;

        let empty_batch_json = "[]";
        let result: Result<JsonRpcMessage, _> = serde_json::from_str(empty_batch_json);

        match result {
            Ok(JsonRpcMessage::Batch(requests)) => {
                assert_eq!(requests.len(), 0);
            }
            Ok(JsonRpcMessage::Request(_)) => {
                panic!("Expected batch, got single request");
            }
            Err(_) => {
                panic!("Empty batch should parse successfully (validation happens in run_stdio)");
            }
        }
    }

    #[tokio::test]
    async fn test_resources_subscribe_with_uri() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/subscribe")
            .with_params(json!({"uri": "file:///test.txt"}));
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());
    }

    #[tokio::test]
    async fn test_resources_subscribe_missing_uri() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/subscribe");
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("uri"));
        assert!(error.message.contains("Missing required parameter"));
    }

    #[tokio::test]
    async fn test_resources_unsubscribe_with_uri() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/unsubscribe")
            .with_params(json!({"uri": "file:///test.txt"}));
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        assert!(response.result.is_some());
    }

    #[tokio::test]
    async fn test_resources_unsubscribe_missing_uri() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "resources/unsubscribe");
        let response = server.handle_request(request).await;

        assert!(response.result.is_none());
        assert!(response.error.is_some());

        let error = response.error.unwrap();
        assert_eq!(error.code, -32602);
        assert!(error.message.contains("uri"));
        assert!(error.message.contains("Missing required parameter"));
    }

    #[tokio::test]
    async fn test_initialize_announces_subscription_support() {
        let server = create_test_server();
        let request = JsonRpcRequest::new(1, "initialize");
        let response = server.handle_request(request).await;

        assert!(response.error.is_none());
        let result = response.result.unwrap();
        let capabilities = result.get("capabilities").unwrap();
        let resources_cap = capabilities.get("resources").unwrap();

        assert_eq!(resources_cap.get("subscribe").unwrap(), true);
    }

    #[tokio::test]
    async fn test_subscription_tracking_subscribe() {
        let server = create_test_server();

        let request = JsonRpcRequest::new(1, "resources/subscribe")
            .with_params(json!({"uri": "file:///test.txt"}));
        let _response = server.handle_request(request).await;

        let subs = server.get_active_subscriptions().await;
        assert!(subs.contains("file:///test.txt"));
    }

    #[tokio::test]
    async fn test_subscription_tracking_unsubscribe() {
        let server = create_test_server();

        let sub_req = JsonRpcRequest::new(1, "resources/subscribe")
            .with_params(json!({"uri": "file:///test.txt"}));
        let _sub_response = server.handle_request(sub_req).await;

        let unsub_req = JsonRpcRequest::new(2, "resources/unsubscribe")
            .with_params(json!({"uri": "file:///test.txt"}));
        let _unsub_response = server.handle_request(unsub_req).await;

        let subs = server.get_active_subscriptions().await;
        assert!(!subs.contains("file:///test.txt"));
    }

    #[tokio::test]
    async fn test_multiple_subscriptions() {
        let server = create_test_server();

        let req1 = JsonRpcRequest::new(1, "resources/subscribe")
            .with_params(json!({"uri": "file:///file1.txt"}));
        let req2 = JsonRpcRequest::new(2, "resources/subscribe")
            .with_params(json!({"uri": "file:///file2.txt"}));
        let req3 = JsonRpcRequest::new(3, "resources/subscribe")
            .with_params(json!({"uri": "file:///file3.txt"}));

        let _res1 = server.handle_request(req1).await;
        let _res2 = server.handle_request(req2).await;
        let _res3 = server.handle_request(req3).await;

        let subs = server.get_active_subscriptions().await;
        assert_eq!(subs.len(), 3);
        assert!(subs.contains("file:///file1.txt"));
        assert!(subs.contains("file:///file2.txt"));
        assert!(subs.contains("file:///file3.txt"));
    }

    #[test]
    fn test_prompt_argument_validation_success() {
        use crate::proxy::types::PromptArgument;

        let server = create_test_server();

        let schema = vec![
            PromptArgument {
                name: "query".to_string(),
                description: Some("Search query".to_string()),
                required: true,
            },
            PromptArgument {
                name: "limit".to_string(),
                description: Some("Result limit".to_string()),
                required: false,
            },
        ];

        let arguments = json!({ "query": "test", "limit": 10 });

        let result = server.validate_prompt_arguments(&Some(arguments), &Some(schema));
        assert!(result.is_ok());
    }

    #[test]
    fn test_prompt_argument_validation_missing_required() {
        use crate::proxy::types::PromptArgument;

        let server = create_test_server();

        let schema = vec![PromptArgument {
            name: "query".to_string(),
            description: Some("Search query".to_string()),
            required: true,
        }];

        let arguments = json!({ "other": "value" });

        let result = server.validate_prompt_arguments(&Some(arguments), &Some(schema));
        assert!(result.is_err());
        assert!(result.unwrap_err().contains("query"));
    }
}