dwctl 8.38.2

The Doubleword Control Layer - A self-hostable observability and analytics platform for LLM applications
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
//! Inference endpoint health synchronization.

use crate::api::models::inference_endpoints::OpenAIModel;
use crate::db::handlers::deployments::DeploymentFilter;
use crate::db::handlers::repository::Repository;
use crate::db::handlers::{Deployments, InferenceEndpoints};
use crate::db::models::deployments::{DeploymentCreateDBRequest, DeploymentDBResponse, DeploymentUpdateDBRequest, ModelStatus};
use crate::db::models::inference_endpoints::InferenceEndpointDBResponse;
use crate::errors::AliasConflict;
use crate::sync::deployments::fetch_models::{FetchModels, FetchModelsReqwest, SyncConfig};
use crate::types::{DeploymentId, InferenceEndpointId, UserId};
use anyhow::Result;
use chrono::Utc;
use serde::{Deserialize, Serialize};
use sqlx::PgPool;
use std::collections::HashMap;
use std::collections::HashSet;
use tracing::{debug, instrument, warn};
use utoipa::ToSchema;
use uuid::Uuid;

#[derive(Debug, thiserror::Error)]
pub enum SyncError {
    #[error("Alias conflicts detected")]
    AliasConflicts { conflicts: Vec<crate::errors::AliasConflict> },
    #[error(transparent)]
    Other(#[from] anyhow::Error),
}

#[derive(Debug, Serialize, Deserialize, ToSchema)]
pub struct EndpointSyncResponse {
    /// Endpoint that was synchronized
    #[schema(value_type = String, format = "uuid")]
    pub endpoint_id: InferenceEndpointId,
    /// Number of changes made during sync
    pub changes_made: usize,
    /// Number of new models created
    pub new_models_created: usize,
    /// Number of models reactivated
    pub models_reactivated: usize,
    /// Number of models deactivated
    pub models_deactivated: usize,
    /// Number of models deleted (filtered out)
    pub models_deleted: usize,
    /// Total number of models fetched from endpoint
    pub total_models_fetched: usize,
    /// Number of models after applying filter
    pub filtered_models_count: usize,
    /// Sync timestamp
    pub synced_at: chrono::DateTime<chrono::Utc>,
}

/// Synchronize deployments for a specific inference endpoint
#[instrument]
pub async fn synchronize_endpoint(endpoint_id: InferenceEndpointId, pool: PgPool) -> Result<EndpointSyncResponse> {
    let mut tx = pool.begin().await?;
    let endpoint_info;
    // Automatically synchronize the endpoint after creating
    {
        let mut endpoints_repo = InferenceEndpoints::new(&mut tx);

        // Get endpoint info
        endpoint_info = endpoints_repo
            .get_by_id(endpoint_id)
            .await?
            .ok_or_else(|| anyhow::anyhow!("Endpoint not found: {}", endpoint_id))?;
    }

    // Create sync config from endpoint
    let sync_config = SyncConfig::from_endpoint(&endpoint_info);

    // Create fetcher
    let fetcher = FetchModelsReqwest::new(sync_config);

    // Perform the sync
    let sync_result;
    {
        let mut deployments_repo = Deployments::new(&mut tx);
        sync_result = sync_endpoint_models(endpoint_info, &mut deployments_repo, fetcher).await
    }

    tx.commit()
        .await
        .map_err(|e| anyhow::anyhow!("Failed to commit sync transaction: {}", e))?;
    sync_result
}

/// Synchronizes models for an endpoint by fetching and comparing with existing deployments
#[instrument(skip(deployments_repo, fetch_models))]
pub async fn sync_endpoint_models<D, F>(
    endpoint_info: InferenceEndpointDBResponse,
    deployments_repo: &mut D,
    fetch_models: F,
) -> Result<EndpointSyncResponse>
where
    D: Repository<
            CreateRequest = DeploymentCreateDBRequest,
            UpdateRequest = DeploymentUpdateDBRequest,
            Response = DeploymentDBResponse,
            Id = DeploymentId,
            Filter = DeploymentFilter,
        >,
    F: FetchModels,
{
    // Get fetched + existing models
    let fetched_models = fetch_models.fetch().await?;
    let existing_models = get_existing_models(deployments_repo, endpoint_info.id).await?;

    // Names are used for deduplication - i.e. we can't have Qwen/Qwen3-VL twice in the same endpoint.
    let existing_model_names: HashSet<String> = existing_models.iter().map(|m| m.model_name.clone()).collect();
    let fetched_model_names: HashSet<String> = fetched_models.data.iter().map(|m| m.id.clone()).collect();

    let mut changes_made = 0;
    let mut new_models_created = 0;
    let mut models_reactivated = 0;
    let mut models_deactivated = 0;
    let mut models_deleted = 0;
    let sync_time = Utc::now();

    // Filter models based on endpoint's model_filter if specified
    let models_to_sync: Vec<_> = if let Some(model_filter) = &endpoint_info.model_filter {
        // Only sync models that are in the filter
        fetched_models
            .data
            .iter()
            .filter(|model| model_filter.contains(&model.id))
            .collect()
    } else {
        // No filter specified, sync all models
        fetched_models.data.iter().collect()
    };

    debug!(
        "Endpoint {} model filter: {:?}, syncing {} of {} fetched models",
        endpoint_info.name,
        endpoint_info.model_filter,
        models_to_sync.len(),
        fetched_models.data.len()
    );

    // Use system user ID (nil UUID) for creating deployments
    let system_user_id = Uuid::nil();

    // Create new models that don't exist yet.
    for model in &models_to_sync {
        if !existing_model_names.contains(&model.id) {
            match create_deployment(deployments_repo, model, &endpoint_info, system_user_id).await {
                Ok(_) => {
                    debug!("Created new deployment for model: {}", model.id);
                    new_models_created += 1;
                    changes_made += 1;
                }
                Err(e) => {
                    warn!("Failed to create deployment for model {}: {}", model.id, e);
                }
            }
        }
    }

    // Update status for existing models using proper status transitions
    for existing_model in &existing_models {
        let existing_model_present = fetched_model_names.contains(&existing_model.model_name);

        // Skip deleted models entirely - respect user deletions
        if existing_model.deleted {
            continue;
        }

        // Check if model should be filtered out based on endpoint's model_filter
        // If there's a filter and this model isn't in it, delete it
        if let Some(model_filter) = &endpoint_info.model_filter
            && !model_filter.contains(&existing_model.model_name)
        {
            if let Err(e) = deployments_repo.delete(existing_model.id).await {
                warn!("Failed to delete filtered-out model {}: {}", existing_model.model_name, e);
            } else {
                debug!("Deleted model {} (removed from filter)", existing_model.model_name);
                models_deleted += 1;
                changes_made += 1;
            }
            continue;
        }

        // Now handle models that are in the filter
        match (&existing_model.status, existing_model_present) {
            // Model is active and present in API - update sync time and detect type if missing
            (ModelStatus::Active, true) => {
                let mut update = DeploymentUpdateDBRequest::status_update(None, sync_time);

                // If model_type is not set, detect and set it
                if existing_model.model_type.is_none() {
                    let detected_type = crate::db::models::deployments::ModelType::detect_from_name(&existing_model.model_name);
                    update.model_type = Some(Some(detected_type));
                }

                if let Err(e) = deployments_repo.update(existing_model.id, &update).await {
                    warn!("Failed to update sync time for active model {}: {}", existing_model.model_name, e);
                }
            }

            // Model is inactive but now present in API - reactivate it and detect type if missing
            (ModelStatus::Inactive, true) => {
                let mut update = DeploymentUpdateDBRequest::status_update(Some(ModelStatus::Active), sync_time);

                // If model_type is not set, detect and set it
                if existing_model.model_type.is_none() {
                    let detected_type = crate::db::models::deployments::ModelType::detect_from_name(&existing_model.model_name);
                    update.model_type = Some(Some(detected_type));
                }

                if let Err(e) = deployments_repo.update(existing_model.id, &update).await {
                    warn!("Failed to reactivate model {}: {}", existing_model.model_name, e);
                } else {
                    debug!("Reactivated model {} (returned to API)", existing_model.model_name);
                    models_reactivated += 1;
                    changes_made += 1;
                }
            }

            // Model is active but missing from API - mark inactive
            (ModelStatus::Active, false) => {
                let update = DeploymentUpdateDBRequest::status_update(Some(ModelStatus::Inactive), sync_time);
                if let Err(e) = deployments_repo.update(existing_model.id, &update).await {
                    warn!("Failed to deactivate model {}: {}", existing_model.model_name, e);
                } else {
                    debug!("Deactivated model {} (missing from API)", existing_model.model_name);
                    models_deactivated += 1;
                    changes_made += 1;
                }
            }

            // Model is inactive and still missing from API - update sync time
            (ModelStatus::Inactive, false) => {
                let update = DeploymentUpdateDBRequest::status_update(None, sync_time);
                if let Err(e) = deployments_repo.update(existing_model.id, &update).await {
                    warn!("Failed to update sync time for inactive model {}: {}", existing_model.model_name, e);
                }
            }
        }
    }

    debug!(
        "Sync completed: {} new models created, {} reactivated, {} deactivated, {} deleted, {} total changes",
        new_models_created, models_reactivated, models_deactivated, models_deleted, changes_made
    );

    Ok(EndpointSyncResponse {
        endpoint_id: endpoint_info.id,
        changes_made,
        new_models_created,
        models_reactivated,
        models_deactivated,
        models_deleted,
        total_models_fetched: fetched_models.data.len(),
        filtered_models_count: models_to_sync.len(),
        synced_at: sync_time,
    })
}

/// Sync function for endpoint creation with optional alias mapping
#[instrument(skip(deployments_repo, fetch_models))]
pub async fn sync_endpoint_models_with_aliases<D, F>(
    endpoint_info: InferenceEndpointDBResponse,
    deployments_repo: &mut D,
    fetch_models: F,
    alias_mapping: &Option<HashMap<String, String>>,
) -> std::result::Result<EndpointSyncResponse, SyncError>
where
    D: Repository<
            CreateRequest = DeploymentCreateDBRequest,
            UpdateRequest = DeploymentUpdateDBRequest,
            Response = DeploymentDBResponse,
            Id = DeploymentId,
            Filter = DeploymentFilter,
        >,
    F: FetchModels,
{
    // Get fetched models
    let fetched_models = fetch_models.fetch().await?;
    let existing_models = get_existing_models(deployments_repo, endpoint_info.id)
        .await
        .map_err(|e| anyhow::anyhow!("Failed to get existing models: {}", e))?;

    let existing_model_names: HashSet<String> = existing_models.iter().map(|m| m.model_name.clone()).collect();
    let mut changes_made = 0;
    let mut new_models_created = 0;
    let sync_time = Utc::now();

    // Filter models based on endpoint's model_filter if specified
    let models_to_sync: Vec<_> = if let Some(model_filter) = &endpoint_info.model_filter {
        fetched_models
            .data
            .iter()
            .filter(|model| model_filter.contains(&model.id))
            .collect()
    } else {
        fetched_models.data.iter().collect()
    };

    debug!(
        "Endpoint {} syncing {} of {} fetched models with alias mapping: {:?}",
        endpoint_info.name,
        models_to_sync.len(),
        fetched_models.data.len(),
        alias_mapping
    );

    // Use system user ID for creating deployments
    let system_user_id = Uuid::nil();

    // Create new models with custom aliases if provided
    for model in &models_to_sync {
        if !existing_model_names.contains(&model.id) {
            // Determine the alias for this model
            let alias = alias_mapping
                .as_ref()
                .and_then(|mapping| mapping.get(&model.id))
                .cloned()
                .unwrap_or_else(|| model.id.clone());

            match create_deployment_with_alias(deployments_repo, model, &endpoint_info, system_user_id, alias.clone()).await {
                Ok(_) => {
                    debug!("Created new deployment for model: {} with alias: {}", model.id, alias);
                    new_models_created += 1;
                    changes_made += 1;
                }
                Err(e) => {
                    // Check if this is an alias conflict and extract structured info
                    if let Some(conflict) = extract_alias_conflict_from_error(&e, &model.id, &alias) {
                        warn!("Alias conflict for model '{}' with alias '{}': {}", model.id, alias, e);
                        // Return immediately with just this one conflict
                        return Err(SyncError::AliasConflicts { conflicts: vec![conflict] });
                    } else {
                        // For non-conflict errors, fail fast
                        return Err(SyncError::Other(e));
                    }
                }
            }
        }
    }

    // Check for duplicate aliases in the alias mapping (or default aliases)
    let mut seen_aliases = std::collections::HashMap::new();
    let mut conflicts = Vec::new();
    for model in &models_to_sync {
        let alias = alias_mapping
            .as_ref()
            .and_then(|mapping| mapping.get(&model.id))
            .cloned()
            .unwrap_or_else(|| model.id.clone());
        if let Some(existing_model) = seen_aliases.insert(alias.clone(), model.id.clone()) {
            // Found a duplicate alias in this batch
            conflicts.push(AliasConflict {
                model_name: model.id.clone(),
                attempted_alias: alias.clone(),
            });
            conflicts.push(AliasConflict {
                model_name: existing_model,
                attempted_alias: alias.clone(),
            });
        }
    }
    if !conflicts.is_empty() {
        return Err(SyncError::AliasConflicts { conflicts });
    }

    debug!(
        "Sync completed: {} new models created, {} total changes",
        new_models_created, changes_made
    );

    Ok(EndpointSyncResponse {
        endpoint_id: endpoint_info.id,
        changes_made,
        new_models_created,
        models_reactivated: 0,
        models_deactivated: 0,
        models_deleted: 0,
        total_models_fetched: fetched_models.data.len(),
        filtered_models_count: models_to_sync.len(),
        synced_at: sync_time,
    })
}

/// Extract alias conflict information from database error - specific to deployment creation
fn extract_alias_conflict_from_error(
    error: &anyhow::Error,
    model_name: &str,
    attempted_alias: &str,
) -> Option<crate::errors::AliasConflict> {
    if let Some(crate::db::errors::DbError::UniqueViolation {
        constraint,
        conflicting_value,
        ..
    }) = error.downcast_ref::<crate::db::errors::DbError>()
        && constraint.as_deref() == Some("deployed_models_alias_unique")
    {
        return Some(crate::errors::AliasConflict {
            model_name: model_name.to_string(),
            attempted_alias: conflicting_value.clone().unwrap_or_else(|| attempted_alias.to_string()),
        });
    }
    None
}

/// Create deployment with custom alias - now returns structured error info
async fn create_deployment_with_alias<D>(
    deployments_repo: &mut D,
    model: &OpenAIModel,
    endpoint_info: &InferenceEndpointDBResponse,
    created_by: UserId,
    alias: String,
) -> Result<()>
where
    D: Repository<CreateRequest = DeploymentCreateDBRequest, Response = DeploymentDBResponse>,
{
    // Auto-detect model type from name
    let detected_type = crate::db::models::deployments::ModelType::detect_from_name(&model.id);

    let db_request = DeploymentCreateDBRequest::builder()
        .created_by(created_by)
        .model_name(model.id.clone())
        .alias(alias.clone())
        .maybe_model_type(Some(detected_type))
        .hosted_on(endpoint_info.id)
        .build();

    match deployments_repo.create(&db_request).await {
        Ok(_) => {
            debug!(
                "Created deployment for model: {} with alias: {} on endpoint: {}",
                model.id, alias, endpoint_info.name
            );
            Ok(())
        }
        Err(e) => {
            // Convert DbError to anyhow::Error so we can extract conflict info later
            Err(anyhow::Error::from(e))
        }
    }
}

// Update the get_existing_models function to handle the Result conversion
async fn get_existing_models<D>(
    deployments_repo: &mut D,
    endpoint_id: InferenceEndpointId,
) -> crate::db::errors::Result<Vec<DeploymentDBResponse>>
where
    D: Repository<Response = DeploymentDBResponse, Id = DeploymentId, Filter = DeploymentFilter>,
{
    // Fetch all models for this endpoint, including soft-deleted ones for sync purposes
    let filter = DeploymentFilter::new(0, i64::MAX).with_endpoint(endpoint_id);
    deployments_repo.list(&filter).await
}

async fn create_deployment<D>(
    deployments_repo: &mut D,
    model: &OpenAIModel,
    endpoint_info: &InferenceEndpointDBResponse,
    created_by: UserId,
) -> Result<()>
where
    D: Repository<CreateRequest = DeploymentCreateDBRequest, Response = DeploymentDBResponse>,
{
    // Auto-detect model type from name
    let detected_type = crate::db::models::deployments::ModelType::detect_from_name(&model.id);

    let db_request = DeploymentCreateDBRequest::builder()
        .created_by(created_by)
        .model_name(model.id.clone())
        .alias(model.id.clone()) // Use model ID as alias by default
        .maybe_model_type(Some(detected_type))
        .hosted_on(endpoint_info.id)
        .build();

    deployments_repo.create(&db_request).await?;
    Ok(())
}

/// Update deployment aliases and create/remove deployments based on model filter
pub async fn update_endpoint_aliases<D>(
    endpoint: InferenceEndpointDBResponse,
    deployments_repo: &mut D,
    alias_mapping: &HashMap<String, String>,
) -> Result<EndpointSyncResponse, SyncError>
where
    D: Repository<
            CreateRequest = DeploymentCreateDBRequest,
            UpdateRequest = DeploymentUpdateDBRequest,
            Response = DeploymentDBResponse,
            Id = DeploymentId,
            Filter = DeploymentFilter,
        >,
{
    let mut changes_made = 0;
    let mut new_models_created = 0;
    let mut models_deleted = 0;

    // Get current deployments for this endpoint
    let current_deployments = deployments_repo
        .list(&DeploymentFilter::new(0, 1000).with_endpoint(endpoint.id))
        .await
        .map_err(|e| SyncError::Other(e.into()))?;

    // Build a map of existing deployments by model_name for quick lookup
    let existing_deployments_map: HashMap<String, &DeploymentDBResponse> =
        current_deployments.iter().map(|d| (d.model_name.clone(), d)).collect();

    // Get the models that should be deployed based on the endpoint's model_filter
    let models_to_deploy: HashSet<String> = if let Some(model_filter) = &endpoint.model_filter {
        model_filter.iter().cloned().collect()
    } else {
        // If no filter, we should keep all existing models and not create new ones
        // This is different from initial sync where we might want to sync all available models
        existing_deployments_map.keys().cloned().collect()
    };

    // --- 1. Batch alias conflict check for updates ---
    // Collect all alias changes (model_name, new_alias, deployment_id)
    let mut update_aliases = Vec::new();
    let mut update_alias_strings = Vec::new();
    let mut update_exclude_ids = Vec::new();
    for deployment in &current_deployments {
        if models_to_deploy.contains(&deployment.model_name)
            && !deployment.deleted
            && let Some(new_alias) = alias_mapping.get(&deployment.model_name)
        {
            let trimmed_alias = new_alias.trim().to_string();
            if deployment.alias != trimmed_alias {
                update_aliases.push((deployment.model_name.clone(), trimmed_alias.clone(), deployment.id));
                update_alias_strings.push(trimmed_alias);
                update_exclude_ids.push(deployment.id);
            }
        }
    }
    // Query for conflicts in one go (excluding the deployments being updated)
    let mut conflict_update_aliases = HashSet::new();
    if !update_alias_strings.is_empty() {
        let filter = DeploymentFilter::new(0, 1000).with_aliases(update_alias_strings.clone());
        let conflict_updates = deployments_repo.list(&filter).await.map_err(|e| SyncError::Other(e.into()))?;
        for d in conflict_updates {
            // Only treat as conflict if not the deployment being updated
            if !update_exclude_ids.contains(&d.id) {
                conflict_update_aliases.insert(d.alias.clone());
            }
        }
    }

    // --- 2. Batch alias conflict check for creations ---
    let mut create_aliases = Vec::new();
    let mut create_model_names = Vec::new();
    for model_name in &models_to_deploy {
        if !existing_deployments_map.contains_key(model_name) {
            // This model needs to be deployed
            let alias = alias_mapping
                .get(model_name)
                .cloned()
                .unwrap_or_else(|| model_name.clone())
                .trim()
                .to_string();
            create_aliases.push(alias.clone());
            create_model_names.push(model_name.clone());
        }
    }
    let mut conflict_create_aliases = HashSet::new();
    if !create_aliases.is_empty() {
        let filter = DeploymentFilter::new(0, 1000).with_aliases(create_aliases.clone());
        let conflict_creates = deployments_repo.list(&filter).await.map_err(|e| SyncError::Other(e.into()))?;
        for d in conflict_creates {
            conflict_create_aliases.insert(d.alias.clone());
        }
    }

    // --- 3. Apply updates, error if conflicts found ---
    // Check for intra-batch duplicate aliases in updates
    let mut seen = std::collections::HashSet::new();
    let mut intra_batch_conflicts = Vec::new();
    for (_, alias, _) in &update_aliases {
        if !seen.insert(alias) {
            intra_batch_conflicts.push(alias.clone());
        }
    }
    if !intra_batch_conflicts.is_empty() {
        return Err(SyncError::AliasConflicts {
            conflicts: intra_batch_conflicts
                .into_iter()
                .map(|alias| AliasConflict {
                    model_name: "<multiple>".to_string(),
                    attempted_alias: alias,
                })
                .collect(),
        });
    }

    for (model_name, new_alias, deployment_id) in update_aliases {
        if conflict_update_aliases.contains(&new_alias) {
            return Err(SyncError::AliasConflicts {
                conflicts: vec![AliasConflict {
                    model_name,
                    attempted_alias: new_alias,
                }],
            });
        }
        let update_request = DeploymentUpdateDBRequest::alias_update(new_alias.clone());
        deployments_repo
            .update(deployment_id, &update_request)
            .await
            .map_err(|e| SyncError::Other(e.into()))?;
        changes_made += 1;
        tracing::info!("Updated deployment {} alias to '{}'", deployment_id, new_alias);
    }

    // --- 4. Create new deployments, error if conflicts found ---
    let system_user_id = uuid::Uuid::nil();
    for (model_name, alias) in create_model_names.into_iter().zip(create_aliases.into_iter()) {
        if conflict_create_aliases.contains(&alias) {
            return Err(SyncError::AliasConflicts {
                conflicts: vec![AliasConflict {
                    model_name,
                    attempted_alias: alias,
                }],
            });
        }
        let db_request = DeploymentCreateDBRequest::builder()
            .created_by(system_user_id)
            .model_name(model_name.clone())
            .alias(alias.clone())
            .hosted_on(endpoint.id)
            .build();

        match deployments_repo.create(&db_request).await {
            Ok(_) => {
                new_models_created += 1;
                changes_made += 1;
                tracing::info!(
                    "Created new deployment for model '{}' with alias '{}' on endpoint {}",
                    model_name,
                    alias,
                    endpoint.id
                );
            }
            Err(e) => {
                tracing::error!("Failed to create deployment for model '{}': {}", model_name, e);
                return Err(SyncError::Other(e.into()));
            }
        }
    }

    // 5. Remove deployments for models that are no longer in the filter
    if endpoint.model_filter.is_some() {
        for deployment in &current_deployments {
            if !models_to_deploy.contains(&deployment.model_name) && !deployment.deleted {
                // This deployment should be removed
                match deployments_repo.delete(deployment.id).await {
                    Ok(true) => {
                        models_deleted += 1;
                        changes_made += 1;
                        tracing::info!("Deleted deployment for model '{}' (removed from filter)", deployment.model_name);
                    }
                    Ok(false) => {
                        tracing::warn!("Deployment {} not found for deletion", deployment.id);
                    }
                    Err(e) => {
                        tracing::error!("Failed to delete deployment {}: {}", deployment.id, e);
                        return Err(SyncError::Other(e.into()));
                    }
                }
            }
        }
    }

    Ok(EndpointSyncResponse {
        endpoint_id: endpoint.id,
        changes_made,
        new_models_created,
        models_reactivated: 0,
        models_deactivated: 0,
        models_deleted,
        total_models_fetched: models_to_deploy.len(),
        filtered_models_count: models_to_deploy.len(),
        synced_at: Utc::now(),
    })
}

#[cfg(test)]
mod tests {
    use crate::{
        DeploymentId, UserId,
        api::models::inference_endpoints::{OpenAIModel, OpenAIModelsResponse},
        db::{
            errors::Result,
            handlers::{InferenceEndpoints, Repository, deployments::DeploymentFilter},
            models::{
                deployments::{
                    DeploymentCreateDBRequest, DeploymentDBResponse, DeploymentUpdateDBRequest, LoadBalancingStrategy, ModelStatus,
                },
                inference_endpoints::InferenceEndpointDBResponse,
            },
        },
        sync::{
            deployments::fetch_models::FetchModels, endpoint_sync::sync_endpoint_models, endpoint_sync::sync_endpoint_models_with_aliases,
        },
    };
    use anyhow::anyhow;
    use async_trait::async_trait;
    use chrono::{DateTime, Utc};
    use std::collections::HashMap;
    use std::sync::{Arc, Mutex};
    use tokio::sync::RwLock;

    #[derive(Debug, Clone)]
    struct MockDeployment {
        id: DeploymentId,
        model_name: String,
        alias: String,
        created_by: UserId,
        status: ModelStatus,
        last_sync: Option<DateTime<Utc>>,
    }

    impl From<MockDeployment> for DeploymentDBResponse {
        fn from(mock: MockDeployment) -> Self {
            DeploymentDBResponse {
                id: mock.id,
                model_name: mock.model_name,
                alias: mock.alias,
                display_name: None,
                created_by: mock.created_by,
                created_at: chrono::Utc::now(),
                updated_at: chrono::Utc::now(),
                model_type: None,
                capabilities: None,
                description: None,
                hosted_on: Some(InferenceEndpoints::default_endpoint_id()),
                status: mock.status,
                last_sync: mock.last_sync,
                deleted: false,
                requests_per_second: None,
                burst_size: None,
                capacity: None,
                batch_capacity: None,
                throughput: None,
                provider_pricing: None,
                // Composite model fields (regular model = not composite)
                is_composite: false,
                lb_strategy: LoadBalancingStrategy::default(),
                fallback_enabled: true,
                fallback_on_rate_limit: true,
                fallback_on_status: vec![429, 500, 502, 503, 504],
                fallback_with_replacement: false,
                fallback_max_attempts: None,
                sanitize_responses: true,
                trusted: false,
                open_responses_adapter: true,
                allowed_batch_completion_windows: None,
                metadata: serde_json::Value::Object(serde_json::Map::new()),
            }
        }
    }

    #[derive(Debug, Clone)]
    struct MockDeploymentsRepo {
        deployments: Arc<RwLock<HashMap<DeploymentId, MockDeployment>>>,
    }

    impl MockDeploymentsRepo {
        fn new() -> Self {
            Self {
                deployments: Arc::new(RwLock::new(HashMap::new())),
            }
        }

        async fn add_deployment(&self, model_name: String, alias: String) -> DeploymentId {
            let id = uuid::Uuid::new_v4();
            let deployment = MockDeployment {
                id,
                model_name,
                alias,
                created_by: uuid::Uuid::nil(),
                status: ModelStatus::Active,
                last_sync: None,
            };
            self.deployments.write().await.insert(id, deployment);
            id
        }

        fn mock_coalesce(request: DeploymentUpdateDBRequest, mut response: DeploymentDBResponse) -> DeploymentDBResponse {
            if let Some(model_name) = &request.model_name {
                response.model_name = model_name.clone();
            }
            if let Some(alias) = &request.alias {
                response.alias = alias.clone();
            }
            if let Some(description) = &request.description {
                response.description = description.clone();
            }
            if let Some(model_type) = &request.model_type {
                response.model_type = model_type.clone();
            }
            if let Some(capabilities) = &request.capabilities {
                response.capabilities = capabilities.clone();
            }
            if let Some(status) = &request.status {
                response.status = status.clone();
            }
            if let Some(last_sync) = &request.last_sync {
                response.last_sync = *last_sync;
            }
            if let Some(deleted) = &request.deleted {
                response.deleted = *deleted;
            }
            response.updated_at = chrono::Utc::now();
            response
        }
    }

    #[async_trait]
    impl Repository for MockDeploymentsRepo {
        type CreateRequest = DeploymentCreateDBRequest;
        type UpdateRequest = DeploymentUpdateDBRequest;
        type Response = DeploymentDBResponse;
        type Id = DeploymentId;
        type Filter = DeploymentFilter;

        async fn create(&mut self, request: &Self::CreateRequest) -> Result<Self::Response> {
            let deployments = self.deployments.read().await;
            if let Some(_existing) = deployments.values().find(|d| d.alias == request.alias) {
                return Err(crate::db::errors::DbError::UniqueViolation {
                    constraint: Some("deployed_models_alias_unique".to_string()),
                    table: Some("deployed_models".to_string()),
                    message: format!("Alias '{}' already exists", request.alias),
                    conflicting_value: Some(request.alias.clone()),
                });
            }
            drop(deployments);

            let id = uuid::Uuid::new_v4();
            let deployment = MockDeployment {
                id,
                model_name: request.model_name.clone(),
                alias: request.alias.clone(),
                created_by: request.created_by,
                status: ModelStatus::Active,
                last_sync: None,
            };
            let response = DeploymentDBResponse::from(deployment.clone());
            self.deployments.write().await.insert(id, deployment);
            Ok(response)
        }

        async fn get_by_id(&mut self, id: Self::Id) -> Result<Option<Self::Response>> {
            let deployments = self.deployments.read().await;
            Ok(deployments.get(&id).map(|d| DeploymentDBResponse::from(d.clone())))
        }

        async fn get_bulk(&mut self, ids: Vec<Self::Id>) -> Result<HashMap<Self::Id, Self::Response>> {
            let deployments = self.deployments.read().await;
            let mut result = HashMap::new();
            for id in ids {
                if let Some(deployment) = deployments.get(&id) {
                    result.insert(id, DeploymentDBResponse::from(deployment.clone()));
                }
            }
            Ok(result)
        }

        async fn delete(&mut self, id: Self::Id) -> Result<bool> {
            let mut deployments = self.deployments.write().await;
            Ok(deployments.remove(&id).is_some())
        }

        async fn update(&mut self, id: Self::Id, request: &Self::UpdateRequest) -> Result<Self::Response> {
            let mut deployments = self.deployments.write().await;

            if let Some(deployment) = deployments.get(&id) {
                let current_response = DeploymentDBResponse::from(deployment.clone());
                let updated_response = Self::mock_coalesce(request.clone(), current_response);

                let updated_deployment = MockDeployment {
                    id: deployment.id,
                    model_name: updated_response.model_name.clone(),
                    alias: updated_response.alias.clone(),
                    created_by: deployment.created_by,
                    status: updated_response.status.clone(),
                    last_sync: updated_response.last_sync,
                };

                deployments.insert(id, updated_deployment);
                Ok(updated_response)
            } else {
                Err(anyhow::anyhow!("Deployment not found").into())
            }
        }

        async fn list(&mut self, filter: &Self::Filter) -> Result<Vec<Self::Response>> {
            let deployments = self.deployments.read().await;
            let mut results: Vec<DeploymentDBResponse> = deployments.values().map(|d| DeploymentDBResponse::from(d.clone())).collect();

            // Apply endpoint filter if specified
            if let Some(endpoint_id) = filter.endpoint_id {
                results.retain(|d| d.hosted_on == Some(endpoint_id));
            }

            // Apply status filter
            if let Some(statuses) = &filter.statuses {
                results.retain(|d| statuses.contains(&d.status));
            }

            // Apply pagination
            let start = filter.skip as usize;
            let end = if filter.limit == i64::MAX {
                results.len()
            } else {
                (start + filter.limit as usize).min(results.len())
            };

            if start < results.len() {
                results = results[start..end].to_vec();
            } else {
                results = vec![];
            }

            Ok(results)
        }
    }

    fn create_test_endpoint() -> InferenceEndpointDBResponse {
        InferenceEndpointDBResponse {
            id: InferenceEndpoints::default_endpoint_id(),
            name: "Test Endpoint".to_string(),
            description: Some("Test endpoint for unit tests".to_string()),
            url: "http://localhost:8080".parse().unwrap(),
            api_key: Some("test-api-key".to_string()),
            model_filter: None, // No filter by default - sync all models
            auth_header_name: "Authorization".to_string(),
            auth_header_prefix: "Bearer ".to_string(),
            created_by: uuid::Uuid::nil(),
            created_at: Utc::now(),
            updated_at: Utc::now(),
        }
    }

    #[derive(Debug, Clone)]
    struct MockFetchModels {
        models: Arc<Mutex<Option<OpenAIModelsResponse>>>,
        error: Arc<Mutex<Option<String>>>,
    }

    impl MockFetchModels {
        fn new() -> Self {
            Self {
                models: Arc::new(Mutex::new(None)),
                error: Arc::new(Mutex::new(None)),
            }
        }

        fn set_models(&self, models: Vec<OpenAIModel>) {
            let response = OpenAIModelsResponse {
                object: "list".to_string(),
                data: models,
            };
            *self.models.lock().unwrap() = Some(response);
        }
    }

    #[async_trait]
    impl FetchModels for MockFetchModels {
        async fn fetch(&self) -> anyhow::Result<OpenAIModelsResponse> {
            if let Some(error) = self.error.lock().unwrap().as_ref() {
                return Err(anyhow!(error.clone()));
            }

            self.models.lock().unwrap().clone().ok_or_else(|| anyhow!("No models configured"))
        }
    }

    fn create_test_model(id: &str) -> OpenAIModel {
        OpenAIModel {
            id: id.to_string(),
            object: "model".to_string(),
            created: Some(1234567890),
            owned_by: "test".to_string(),
        }
    }

    #[tokio::test]
    async fn test_sync_models_adds_new_models() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Configure fetch_models to return new models
        let models = vec![create_test_model("gpt-3.5-turbo"), create_test_model("gpt-4")];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // Run sync - should add 2 new models
        let result = sync_endpoint_models(endpoint_info, &mut repo, fetch_models).await.unwrap();
        assert_eq!(result.changes_made, 2);
        assert_eq!(result.new_models_created, 2);
        assert_eq!(result.models_reactivated, 0);
        assert_eq!(result.models_deactivated, 0);

        // Verify models were added to repository
        let deployments = repo.list(&DeploymentFilter::new(0, 10)).await.unwrap();
        assert_eq!(deployments.len(), 2);

        let model_names: std::collections::HashSet<String> = deployments.iter().map(|d| d.model_name.clone()).collect();
        assert!(model_names.contains("gpt-3.5-turbo"));
        assert!(model_names.contains("gpt-4"));
    }

    #[tokio::test]
    async fn test_sync_models_marks_missing_models_inactive() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Add existing models to repository
        repo.add_deployment("old-model-1".to_string(), "old-model-1".to_string()).await;
        repo.add_deployment("old-model-2".to_string(), "old-model-2".to_string()).await;

        // Configure fetch_models to return empty list (all models should be marked inactive)
        fetch_models.set_models(vec![]);

        let endpoint_info = create_test_endpoint();

        // Run sync - should mark 2 models inactive
        let result = sync_endpoint_models(endpoint_info, &mut repo, fetch_models).await.unwrap();
        assert_eq!(result.changes_made, 2);
        assert_eq!(result.new_models_created, 0);
        assert_eq!(result.models_reactivated, 0);
        assert_eq!(result.models_deactivated, 2);

        // Verify models remain in repository but are marked inactive
        let deployments = repo.list(&DeploymentFilter::new(0, 10)).await.unwrap();
        assert_eq!(deployments.len(), 2); // Models still exist, not deleted

        // Check that all models are marked inactive
        for deployment in &deployments {
            assert_eq!(deployment.status, ModelStatus::Inactive);
            assert!(deployment.last_sync.is_some()); // Should have sync timestamp
        }
    }

    #[tokio::test]
    async fn test_sync_models_mixed_add_delete() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Add existing models to repository
        repo.add_deployment("keep-model".to_string(), "keep-model".to_string()).await;
        repo.add_deployment("delete-model".to_string(), "delete-model".to_string()).await;

        // Configure fetch_models to return one existing model and one new model
        let models = vec![
            create_test_model("keep-model"), // This should stay
            create_test_model("new-model"),  // This should be added
        ];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // Run sync - should add 1 new model and mark 1 model inactive
        let result = sync_endpoint_models(endpoint_info, &mut repo, fetch_models).await.unwrap();
        assert_eq!(result.changes_made, 2); // 1 added + 1 marked inactive
        assert_eq!(result.new_models_created, 1);
        assert_eq!(result.models_deactivated, 1);

        // Verify final state - all models remain in database with status tracking
        let deployments = repo.list(&DeploymentFilter::new(0, 10)).await.unwrap();
        assert_eq!(deployments.len(), 3); // All models remain, none deleted

        let model_names: std::collections::HashSet<String> = deployments.iter().map(|d| d.model_name.clone()).collect();
        assert!(model_names.contains("keep-model"));
        assert!(model_names.contains("new-model"));
        assert!(model_names.contains("delete-model")); // Model still exists but should be inactive

        // Check status of each model
        for deployment in &deployments {
            match deployment.model_name.as_str() {
                "keep-model" => assert_eq!(deployment.status, ModelStatus::Active),
                "new-model" => assert_eq!(deployment.status, ModelStatus::Active),
                "delete-model" => assert_eq!(deployment.status, ModelStatus::Inactive),
                _ => panic!("Unexpected model: {}", deployment.model_name),
            }
        }
    }

    #[tokio::test]
    async fn test_sync_models_no_changes() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Add existing model to repository
        repo.add_deployment("existing-model".to_string(), "existing-model".to_string())
            .await;

        // Configure fetch_models to return the same model
        let models = vec![create_test_model("existing-model")];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // Run sync - no changes should occur
        let result = sync_endpoint_models(endpoint_info, &mut repo, fetch_models).await.unwrap();
        assert_eq!(result.changes_made, 0);
        assert_eq!(result.new_models_created, 0);
        assert_eq!(result.models_reactivated, 0);
        assert_eq!(result.models_deactivated, 0);

        // Verify model is still there
        let deployments = repo.list(&DeploymentFilter::new(0, 10)).await.unwrap();
        assert_eq!(deployments.len(), 1);
        assert_eq!(deployments[0].model_name, "existing-model");
    }

    #[tokio::test]
    async fn test_create_deployment_with_duplicate_alias_fails() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Set up two models
        let models = vec![create_test_model("google/gemma-3-12b-it"), create_test_model("openai/gpt-4")];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // First sync with unique aliases should succeed
        let mut alias_mapping = HashMap::new();
        alias_mapping.insert("google/gemma-3-12b-it".to_string(), "alias-1".to_string());
        alias_mapping.insert("openai/gpt-4".to_string(), "alias-2".to_string());

        let result = crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(
            endpoint_info.clone(),
            &mut repo,
            fetch_models.clone(),
            &Some(alias_mapping),
        )
        .await;
        assert!(result.is_ok());

        // Second sync with a duplicate alias should fail
        let mut alias_mapping_conflict = HashMap::new();
        alias_mapping_conflict.insert("google/gemma-3-12b-it".to_string(), "shared-alias".to_string());
        alias_mapping_conflict.insert("openai/gpt-4".to_string(), "shared-alias".to_string());

        let result = crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(
            endpoint_info.clone(),
            &mut repo,
            fetch_models.clone(),
            &Some(alias_mapping_conflict),
        )
        .await;
        assert!(matches!(result, Err(crate::sync::endpoint_sync::SyncError::AliasConflicts { .. })));
    }

    #[tokio::test]
    async fn test_create_deployment_with_default_alias_conflict() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Set up a model
        let models = vec![create_test_model("google/gemma-3-12b-it")];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // First sync with no alias mapping (alias defaults to model name)
        let result =
            crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(endpoint_info.clone(), &mut repo, fetch_models.clone(), &None)
                .await;
        assert!(result.is_ok());

        // Try to sync again with the same model and no alias mapping (should conflict)
        let result =
            crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(endpoint_info.clone(), &mut repo, fetch_models.clone(), &None)
                .await;
        // Should not error, as it's the same endpoint and model (idempotent)
        assert!(result.is_ok());

        // Now, simulate a second endpoint trying to use the same alias (model name)
        let endpoint_info2 = InferenceEndpointDBResponse {
            id: uuid::Uuid::new_v4(),
            ..create_test_endpoint()
        };
        let result =
            crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(endpoint_info2, &mut repo, fetch_models.clone(), &None).await;
        assert!(matches!(result, Err(crate::sync::endpoint_sync::SyncError::AliasConflicts { .. })));
    }

    #[tokio::test]
    async fn test_update_endpoint_aliases_duplicate_fails() {
        let mut repo = MockDeploymentsRepo::new();

        // Add two deployments with unique aliases
        let _id1 = repo
            .add_deployment("google/gemma-3-12b-it".to_string(), "alias-1".to_string())
            .await;
        let _id2 = repo.add_deployment("openai/gpt-4".to_string(), "alias-2".to_string()).await;

        let endpoint_info = create_test_endpoint();

        // Try to update both to the same alias
        let mut alias_mapping = HashMap::new();
        alias_mapping.insert("google/gemma-3-12b-it".to_string(), "shared-alias".to_string());
        alias_mapping.insert("openai/gpt-4".to_string(), "shared-alias".to_string());

        let result = crate::sync::endpoint_sync::update_endpoint_aliases(endpoint_info.clone(), &mut repo, &alias_mapping).await;
        assert!(matches!(result, Err(crate::sync::endpoint_sync::SyncError::AliasConflicts { .. })));
    }

    #[tokio::test]
    async fn test_update_endpoint_aliases_unique_ok() {
        let mut repo = MockDeploymentsRepo::new();

        // Add two deployments with unique aliases
        let _id1 = repo
            .add_deployment("google/gemma-3-12b-it".to_string(), "alias-1".to_string())
            .await;
        let _id2 = repo.add_deployment("openai/gpt-4".to_string(), "alias-2".to_string()).await;

        let endpoint_info = create_test_endpoint();

        // Update aliases to new unique values
        let mut alias_mapping = HashMap::new();
        alias_mapping.insert("google/gemma-3-12b-it".to_string(), "alias-3".to_string());
        alias_mapping.insert("openai/gpt-4".to_string(), "alias-4".to_string());

        let result = crate::sync::endpoint_sync::update_endpoint_aliases(endpoint_info.clone(), &mut repo, &alias_mapping).await;
        assert!(result.is_ok());
    }

    #[tokio::test]
    async fn test_update_endpoint_aliases_default_alias_conflict() {
        let mut repo = MockDeploymentsRepo::new();

        // Add a deployment with alias = model name
        let _id1 = repo
            .add_deployment("google/gemma-3-12b-it".to_string(), "google/gemma-3-12b-it".to_string())
            .await;

        let endpoint_info = create_test_endpoint();

        // Try to update another deployment to use the same alias
        let _id2 = repo.add_deployment("openai/gpt-4".to_string(), "alias-2".to_string()).await;

        let mut alias_mapping = HashMap::new();
        alias_mapping.insert("openai/gpt-4".to_string(), "google/gemma-3-12b-it".to_string());

        let result = crate::sync::endpoint_sync::update_endpoint_aliases(endpoint_info.clone(), &mut repo, &alias_mapping).await;
        assert!(matches!(result, Err(crate::sync::endpoint_sync::SyncError::AliasConflicts { .. })));
    }

    #[tokio::test]
    async fn test_sync_endpoint_models_with_no_alias_mapping_defaults_to_model_name() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Configure fetch_models to return two models
        let models = vec![create_test_model("google/gemma-3-12b-it"), create_test_model("openai/gpt-4")];
        fetch_models.set_models(models);

        let endpoint_info = create_test_endpoint();

        // Run sync with no alias mapping
        let result =
            crate::sync::endpoint_sync::sync_endpoint_models_with_aliases(endpoint_info.clone(), &mut repo, fetch_models.clone(), &None)
                .await;
        assert!(result.is_ok());

        // Verify deployments were created with alias == model_name
        let deployments = repo.list(&DeploymentFilter::new(0, 10)).await.unwrap();
        let mut found_gemma = false;
        let mut found_gpt4 = false;
        for d in deployments {
            if d.model_name == "google/gemma-3-12b-it" {
                assert_eq!(d.alias, "google/gemma-3-12b-it");
                found_gemma = true;
            }
            if d.model_name == "openai/gpt-4" {
                assert_eq!(d.alias, "openai/gpt-4");
                found_gpt4 = true;
            }
        }
        assert!(found_gemma && found_gpt4);
    }

    #[tokio::test]
    async fn test_sync_endpoint_models_with_alias_mapping() {
        let mut repo = MockDeploymentsRepo::new();
        let fetch_models = MockFetchModels::new();

        // Configure fetch_models to return two models
        let models = vec![create_test_model("google/gemma-3-12b-it"), create_test_model("openai/gpt-4")];
        fetch_models.set_models(models);

        let _endpoint_info = create_test_endpoint();

        // First endpoint sync (should succeed)
        let endpoint_info1 = create_test_endpoint();
        let result = sync_endpoint_models_with_aliases(endpoint_info1.clone(), &mut repo, fetch_models.clone(), &None).await;
        assert!(result.is_ok());

        // Second endpoint sync (should fail due to alias conflict)
        let endpoint_info2 = InferenceEndpointDBResponse {
            id: uuid::Uuid::new_v4(),
            ..create_test_endpoint()
        };
        let result = sync_endpoint_models_with_aliases(endpoint_info2, &mut repo, fetch_models.clone(), &None).await;
        assert!(matches!(result, Err(crate::sync::endpoint_sync::SyncError::AliasConflicts { .. })));
    }
}