drove 0.1.2

Versioned, declarative agent workspaces
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
//! Backend selection: which backend a project reconciles onto, and which
//! named instance (Herdr session, Radiator hub) it targets (D32, D33).

use std::path::{Path, PathBuf};

use anyhow::{Result, bail};

use super::{Backend, herdr::HerdrClient, radiator::RadiatorClient};
use crate::model::BackendTargets;

pub const HERDR_BACKEND: &str = "herdr";
pub const RADIATOR_BACKEND: &str = "radiator";
const KNOWN_BACKENDS: &[&str] = &[HERDR_BACKEND, RADIATOR_BACKEND];

/// The resolved instance a backend connects to: an explicit socket override
/// (`--socket`, always wins over everything else) and an optional named
/// target (Herdr session or Radiator hub) resolved per D46's six-level
/// order. `name: None` defers entirely to the backend's own built-in
/// default, including any env fallback it already implements
/// (`HerdrClient`/`RadiatorClient::discover`).
#[derive(Debug, Clone, Default, PartialEq, Eq)]
pub struct Target {
    pub socket: Option<PathBuf>,
    pub name: Option<String>,
}

/// CLI flags relevant to backend selection, gathered by the caller so this
/// module never reads `std::env` or `clap` itself — the D32/D33 precedence
/// test needs no I/O (spec §10).
#[derive(Debug, Clone, Copy, Default)]
pub struct CliInputs<'a> {
    pub backend: Option<&'a str>,
    pub target: Option<&'a str>,
    /// `--session`, a Herdr alias of `--target` (spec §5).
    pub session: Option<&'a str>,
    pub socket: Option<&'a Path>,
}

/// Explicit environment inputs (D46): variables the caller (or a script
/// wrapping `drove`) sets on purpose to say where it wants to go —
/// `DROVE_BACKEND`, and `DROVE_SESSION`/`DROVE_TARGET` mirroring
/// `--session`/`--target`. Ranks above the profile, like the flags they
/// mirror.
#[derive(Debug, Clone, Default)]
pub struct ExplicitEnvInputs {
    pub drove_backend: Option<String>,
    pub drove_session: Option<String>,
    pub drove_target: Option<String>,
}

/// Ambient host environment inputs (D46): variables Herdr/Radiator export
/// into every pane they host, saying where the caller *is*, not where it
/// wants to go — `HERDR_SESSION`, `RADIATOR_HUB`, and the ambient Radiator
/// detection tie-break. Ranks below the file, just above the built-in
/// default.
#[derive(Debug, Clone, Default)]
pub struct AmbientEnvInputs {
    pub herdr_session: Option<String>,
    pub radiator_hub: Option<String>,
    /// Whether an ambient Radiator hub socket is present with no Herdr pane
    /// marker (`radiator::selected_by_environment`), the built-in level's
    /// tie-breaker when nothing else names a backend.
    pub ambient_radiator: bool,
}

/// A profile's own target declaration (D41): `profile(..., session = ...,
/// backend = ...)`. Sits between environment and file in the resolution
/// order for both the backend id and the target name.
#[derive(Debug, Clone, Copy, Default)]
pub struct ProfileInputs<'a> {
    pub backend: Option<&'a str>,
    /// The profile's `session`: a Herdr session name, or (when the resolved
    /// backend is Radiator) the hub name.
    pub session: Option<&'a str>,
}

/// Resolves the backend id and its target instance per D46's six-level
/// order (flag > explicit env > profile > Drovefile > ambient host env >
/// built-in), purely from already-gathered inputs. `--session`/
/// `DROVE_SESSION` (the Herdr alias of `--target`/`DROVE_TARGET`) name a
/// Herdr session, so they are ignored once Radiator is selected —
/// `--target`/`DROVE_TARGET`, `RADIATOR_HUB`, `radiator.hub(...)` and the
/// `main` built-in still apply in that case. Ambient host env variables
/// (`HERDR_SESSION`, `RADIATOR_HUB`) say where the caller is, not where it
/// wants to go, so they rank below the profile and the file, only above the
/// built-in default.
pub fn resolve(
    cli: CliInputs<'_>,
    explicit_env: &ExplicitEnvInputs,
    ambient_env: &AmbientEnvInputs,
    profile: ProfileInputs<'_>,
    file_backend: Option<&str>,
    file_target: &BackendTargets,
) -> (String, Target) {
    let backend = non_empty(cli.backend)
        .or_else(|| non_empty(explicit_env.drove_backend.as_deref()))
        .or_else(|| non_empty(profile.backend))
        .or_else(|| non_empty(file_backend))
        .map(str::to_owned)
        .unwrap_or_else(|| {
            if ambient_env.ambient_radiator {
                RADIATOR_BACKEND.to_owned()
            } else {
                HERDR_BACKEND.to_owned()
            }
        });

    let name = match backend.as_str() {
        RADIATOR_BACKEND => non_empty(cli.target)
            .or_else(|| non_empty(explicit_env.drove_target.as_deref()))
            .or_else(|| non_empty(profile.session))
            .or_else(|| non_empty(file_target.radiator_hub.as_deref()))
            .or_else(|| non_empty(ambient_env.radiator_hub.as_deref()))
            .map(str::to_owned),
        _ => non_empty(cli.target.or(cli.session))
            .or_else(|| {
                non_empty(
                    explicit_env
                        .drove_target
                        .as_deref()
                        .or(explicit_env.drove_session.as_deref()),
                )
            })
            .or_else(|| non_empty(profile.session))
            .or_else(|| non_empty(file_target.herdr_session.as_deref()))
            .or_else(|| non_empty(ambient_env.herdr_session.as_deref()))
            .map(str::to_owned),
    };

    // D51 point 6: Herdr's actual unnamed session lives at the bare
    // `~/.config/herdr/herdr.sock`, not `sessions/default/herdr.sock`
    // (`resolve_socket_path` already special-cases this for its own
    // ambient-env fallback). A resolved name of exactly `default`, from any
    // level (`--session default`, `DROVE_SESSION=default`,
    // `herdr.session("default")`, ambient `HERDR_SESSION=default`), means
    // the same thing: normalise it to "no named session" here, once, rather
    // than requiring every call site to know about the exception.
    let name = if backend == HERDR_BACKEND && name.as_deref() == Some("default") {
        None
    } else {
        name
    };

    (
        backend,
        Target {
            socket: cli.socket.map(Path::to_path_buf),
            name,
        },
    )
}

fn non_empty(value: Option<&str>) -> Option<&str> {
    value.filter(|value| !value.is_empty())
}

/// Opens the selected backend against its resolved target (D33). An unknown
/// backend id fails with the list of known ones.
pub fn open(id: &str, target: &Target) -> Result<Box<dyn Backend>> {
    match id {
        HERDR_BACKEND => Ok(Box::new(HerdrClient::discover(
            target.socket.as_deref(),
            target.name.as_deref(),
        ))),
        RADIATOR_BACKEND => Ok(Box::new(RadiatorClient::discover(
            target.socket.as_deref(),
            target.name.as_deref(),
        ))),
        other => bail!(
            "unknown backend `{other}`; known backends: {}",
            KNOWN_BACKENDS.join(", ")
        ),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn targets(herdr_session: Option<&str>, radiator_hub: Option<&str>) -> BackendTargets {
        BackendTargets {
            herdr_session: herdr_session.map(str::to_owned),
            radiator_hub: radiator_hub.map(str::to_owned),
        }
    }

    #[test]
    fn open_rejects_an_unknown_backend_id() {
        let error = open("nope", &Target::default())
            .err()
            .expect("unknown backend");
        assert!(error.to_string().contains("unknown backend"));
        assert!(error.to_string().contains("herdr"));
        assert!(error.to_string().contains("radiator"));
    }

    #[test]
    fn open_reaches_radiator_when_selected() {
        // The Radiator backend has no Herdr flavor: its `herdr()` accessor
        // (the core/flavor seam, D28) returns `None`.
        let backend = open(RADIATOR_BACKEND, &Target::default()).expect("open radiator");
        assert!(backend.herdr().is_none());
    }

    #[test]
    fn open_reaches_herdr_when_selected() {
        // The Herdr backend offers the Herdr flavor: `herdr()` returns `Some`.
        let backend = open(HERDR_BACKEND, &Target::default()).expect("open herdr");
        assert!(backend.herdr().is_some());
    }

    #[test]
    fn cli_backend_wins_over_every_other_level() {
        let cli = CliInputs {
            backend: Some("radiator"),
            ..Default::default()
        };
        let mut explicit_env = ExplicitEnvInputs {
            drove_backend: Some("herdr".to_owned()),
            ..Default::default()
        };
        let (backend, _) = resolve(
            cli,
            &explicit_env,
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");

        explicit_env.drove_backend = None;
        let (backend, _) = resolve(
            cli,
            &explicit_env,
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");
    }

    #[test]
    fn explicit_env_backend_wins_over_profile_file_and_built_in() {
        let explicit_env = ExplicitEnvInputs {
            drove_backend: Some("radiator".to_owned()),
            ..Default::default()
        };
        let profile = ProfileInputs {
            backend: Some("herdr"),
            ..Default::default()
        };
        let (backend, _) = resolve(
            CliInputs::default(),
            &explicit_env,
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");
    }

    #[test]
    fn file_backend_wins_over_the_built_in_default() {
        let (backend, _) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some("radiator"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");
    }

    #[test]
    fn built_in_default_is_herdr_unless_ambient_radiator_is_present() {
        let cli = CliInputs::default();
        let (backend, _) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(backend, "herdr");

        let ambient = AmbientEnvInputs {
            ambient_radiator: true,
            ..Default::default()
        };
        let (backend, _) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");
    }

    #[test]
    fn herdr_target_name_follows_the_full_precedence_order() {
        // flag > explicit env (DROVE_TARGET/DROVE_SESSION) > profile > file
        // > ambient host env (HERDR_SESSION) > built-in (D46).
        let file = targets(Some("file-session"), None);
        let profile = ProfileInputs {
            session: Some("profile-session"),
            ..Default::default()
        };
        let ambient = AmbientEnvInputs {
            herdr_session: Some("ambient-session".to_owned()),
            ..Default::default()
        };

        let cli = CliInputs {
            target: Some("cli-target"),
            ..Default::default()
        };
        let explicit_env = ExplicitEnvInputs {
            drove_target: Some("explicit-target".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(cli, &explicit_env, &ambient, profile, Some("herdr"), &file);
        assert_eq!(target.name.as_deref(), Some("cli-target"));

        let cli_session_alias = CliInputs {
            session: Some("cli-session"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli_session_alias,
            &explicit_env,
            &ambient,
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("cli-session"));

        let (_, target) = resolve(
            CliInputs::default(),
            &explicit_env,
            &ambient,
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("explicit-target"));

        let explicit_session = ExplicitEnvInputs {
            drove_session: Some("explicit-session".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &explicit_session,
            &ambient,
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("explicit-session"));

        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &ambient,
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("profile-session"));

        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("file-session"));

        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("ambient-session"));

        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(target.name, None);
    }

    #[test]
    fn radiator_target_name_follows_the_full_precedence_order() {
        let file = targets(None, Some("file-hub"));
        let ambient = AmbientEnvInputs {
            radiator_hub: Some("ambient-hub".to_owned()),
            ..Default::default()
        };
        let cli = CliInputs {
            backend: Some("radiator"),
            target: Some("cli-hub"),
            ..Default::default()
        };
        let explicit_env = ExplicitEnvInputs {
            drove_target: Some("explicit-hub".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &explicit_env,
            &ambient,
            ProfileInputs::default(),
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("cli-hub"));

        let cli_no_target = CliInputs {
            backend: Some("radiator"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli_no_target,
            &explicit_env,
            &ambient,
            ProfileInputs::default(),
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("explicit-hub"));

        let (_, target) = resolve(
            cli_no_target,
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("file-hub"));

        let (_, target) = resolve(
            cli_no_target,
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("ambient-hub"));

        let (_, target) = resolve(
            cli_no_target,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(target.name, None);
    }

    #[test]
    fn session_flag_and_env_are_ignored_for_the_radiator_backend() {
        // `--session`/`DROVE_SESSION` are the Herdr alias of `--target`/
        // `DROVE_TARGET` (spec §5, D46); they must not leak into the
        // Radiator hub name. `--target`/`DROVE_TARGET`, `RADIATOR_HUB`,
        // `radiator.hub()` and the `main` built-in still apply.
        let file = targets(None, Some("file-hub"));
        let cli = CliInputs {
            backend: Some("radiator"),
            session: Some("some-herdr-session"),
            ..Default::default()
        };
        let explicit_env = ExplicitEnvInputs {
            drove_session: Some("some-herdr-session".to_owned()),
            ..Default::default()
        };
        let (backend, target) = resolve(
            cli,
            &explicit_env,
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            None,
            &file,
        );
        assert_eq!(backend, "radiator");
        assert_eq!(target.name.as_deref(), Some("file-hub"));

        let ambient = AmbientEnvInputs {
            radiator_hub: Some("ambient-hub".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &explicit_env,
            &ambient,
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("ambient-hub"));

        let cli_with_target = CliInputs {
            backend: Some("radiator"),
            session: Some("some-herdr-session"),
            target: Some("cli-hub"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli_with_target,
            &explicit_env,
            &ambient,
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("cli-hub"));
    }

    #[test]
    fn profile_backend_wins_over_file_but_loses_to_explicit_env_and_cli() {
        let profile = ProfileInputs {
            backend: Some("radiator"),
            ..Default::default()
        };

        let (backend, _) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "radiator");

        let explicit_env = ExplicitEnvInputs {
            drove_backend: Some("herdr".to_owned()),
            ..Default::default()
        };
        let (backend, _) = resolve(
            CliInputs::default(),
            &explicit_env,
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "herdr");

        let cli = CliInputs {
            backend: Some("herdr"),
            ..Default::default()
        };
        let (backend, _) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(backend, "herdr");
    }

    #[test]
    fn profile_session_wins_over_file_but_loses_to_explicit_env_and_cli_for_herdr() {
        let file = targets(Some("file-session"), None);
        let profile = ProfileInputs {
            session: Some("profile-session"),
            ..Default::default()
        };

        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("profile-session"));

        let explicit_env = ExplicitEnvInputs {
            drove_session: Some("explicit-session".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &explicit_env,
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("explicit-session"));

        let cli = CliInputs {
            target: Some("cli-target"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            Some("herdr"),
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("cli-target"));
    }

    #[test]
    fn profile_session_wins_over_file_but_loses_to_explicit_env_and_cli_for_radiator() {
        let file = targets(None, Some("file-hub"));
        let profile = ProfileInputs {
            session: Some("profile-hub"),
            ..Default::default()
        };
        let cli_radiator = CliInputs {
            backend: Some("radiator"),
            ..Default::default()
        };

        let (_, target) = resolve(
            cli_radiator,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("profile-hub"));

        let explicit_env = ExplicitEnvInputs {
            drove_target: Some("explicit-hub".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli_radiator,
            &explicit_env,
            &AmbientEnvInputs::default(),
            profile,
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("explicit-hub"));

        let cli_with_target = CliInputs {
            backend: Some("radiator"),
            target: Some("cli-hub"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli_with_target,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            profile,
            None,
            &file,
        );
        assert_eq!(target.name.as_deref(), Some("cli-hub"));
    }

    #[test]
    fn profile_session_wins_over_ambient_herdr_session_d46() {
        // The regression D46 fixes: `drove monitoring` run from inside
        // Herdr session `drove` must target the profile's own session, not
        // the ambient one it happens to be running in.
        let profile = ProfileInputs {
            session: Some("drove-mon"),
            ..Default::default()
        };
        let ambient = AmbientEnvInputs {
            herdr_session: Some("drove".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &ambient,
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("drove-mon"));

        let explicit_env = ExplicitEnvInputs {
            drove_session: Some("x".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &explicit_env,
            &ambient,
            profile,
            Some("herdr"),
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("x"));
    }

    #[test]
    fn explicit_socket_is_carried_through_regardless_of_target_name() {
        let cli = CliInputs {
            socket: Some(Path::new("/tmp/explicit.sock")),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            None,
            &BackendTargets::default(),
        );
        assert_eq!(target.socket, Some(PathBuf::from("/tmp/explicit.sock")));
    }

    #[test]
    fn a_herdr_target_name_of_default_normalises_to_no_named_session() {
        // `--session default`.
        let cli = CliInputs {
            session: Some("default"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some(HERDR_BACKEND),
            &BackendTargets::default(),
        );
        assert_eq!(target.name, None);

        // `DROVE_SESSION=default`.
        let explicit_env = ExplicitEnvInputs {
            drove_session: Some("default".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &explicit_env,
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some(HERDR_BACKEND),
            &BackendTargets::default(),
        );
        assert_eq!(target.name, None);

        // `herdr.session("default")` (the file level).
        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some(HERDR_BACKEND),
            &targets(Some("default"), None),
        );
        assert_eq!(target.name, None);

        // Ambient `HERDR_SESSION=default`.
        let ambient = AmbientEnvInputs {
            herdr_session: Some("default".to_owned()),
            ..Default::default()
        };
        let (_, target) = resolve(
            CliInputs::default(),
            &ExplicitEnvInputs::default(),
            &ambient,
            ProfileInputs::default(),
            Some(HERDR_BACKEND),
            &BackendTargets::default(),
        );
        assert_eq!(target.name, None);
    }

    #[test]
    fn a_non_default_herdr_target_name_is_unaffected() {
        let cli = CliInputs {
            session: Some("drove"),
            ..Default::default()
        };
        let (_, target) = resolve(
            cli,
            &ExplicitEnvInputs::default(),
            &AmbientEnvInputs::default(),
            ProfileInputs::default(),
            Some(HERDR_BACKEND),
            &BackendTargets::default(),
        );
        assert_eq!(target.name.as_deref(), Some("drove"));
    }
}