draco-core 1.0.2

Pure Rust core encoder and decoder for Draco geometry compression
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
//! Constrained multi-parallelogram mesh predictor.
//!
//! Like multi-parallelogram, but the encoder selects, per vertex, the best
//! subset of incident triangles and codes the choice as crease/selection flags
//! so the decoder reproduces it exactly. Draco's highest-quality mesh position
//! predictor. Port of Draco's
//! `prediction_scheme_constrained_multi_parallelogram_*`.

use crate::geometry_attribute::PointAttribute;
use crate::geometry_indices::{CornerIndex, INVALID_CORNER_INDEX};
use crate::mesh_prediction_scheme_data::MeshPredictionSchemeData;
use crate::prediction_scheme::{
    PredictionScheme, PredictionSchemeMethod, PredictionSchemeTransformType,
};
use crate::prediction_scheme_parallelogram::ParallelogramDataType;
use std::marker::PhantomData;

#[cfg(feature = "decoder")]
use crate::decoder_buffer::DecoderBuffer;
#[cfg(feature = "decoder")]
use crate::prediction_scheme::{PredictionSchemeDecoder, PredictionSchemeDecodingTransform};
#[cfg(feature = "decoder")]
use crate::rans_bit_decoder::RAnsBitDecoder;

#[cfg(feature = "encoder")]
use crate::encoder_buffer::EncoderBuffer;
#[cfg(feature = "encoder")]
use crate::prediction_scheme::{PredictionSchemeEncoder, PredictionSchemeEncodingTransform};
#[cfg(feature = "encoder")]
use crate::rans_bit_encoder::RAnsBitEncoder;
#[cfg(feature = "encoder")]
use crate::shannon_entropy::ShannonEntropyTracker;

pub const MAX_NUM_PARALLELOGRAMS: usize = 4;

#[cfg(feature = "encoder")]
pub struct MeshPredictionSchemeConstrainedMultiParallelogramEncoder<
    'a,
    DataType,
    CorrType,
    Transform,
> {
    mesh_data: MeshPredictionSchemeData<'a>,
    transform: Transform,
    is_crease_edge: [Vec<bool>; MAX_NUM_PARALLELOGRAMS],
    entropy_tracker: ShannonEntropyTracker,
    /// Target bitstream version (0 = default/2.2). Pre-2.2 crease-edge rANS
    /// streams need a fixed-u32 size prefix instead of a varint.
    bitstream_version: u16,
    _marker: PhantomData<(DataType, CorrType)>,
}

#[cfg(feature = "encoder")]
impl<'a, DataType, CorrType, Transform>
    MeshPredictionSchemeConstrainedMultiParallelogramEncoder<'a, DataType, CorrType, Transform>
where
    Transform: PredictionSchemeEncodingTransform<DataType, CorrType>,
{
    pub fn new(transform: Transform, mesh_data: MeshPredictionSchemeData<'a>) -> Self {
        Self {
            mesh_data,
            transform,
            is_crease_edge: Default::default(),
            entropy_tracker: ShannonEntropyTracker::new(),
            bitstream_version: 0,
            _marker: PhantomData,
        }
    }

    /// Sets the target bitstream version so crease-edge rANS streams use the
    /// correct (pre-2.2 u32 vs 2.2+ varint) size-prefix encoding.
    pub fn set_bitstream_version(&mut self, version: u16) {
        self.bitstream_version = version;
    }

    fn convert_signed_int_to_symbol(val: i64) -> u32 {
        if val >= 0 {
            (val as u32) << 1
        } else {
            ((-val as u32) << 1) - 1
        }
    }
}

#[cfg(feature = "encoder")]
impl<'a, DataType, CorrType, Transform> PredictionScheme<'a>
    for MeshPredictionSchemeConstrainedMultiParallelogramEncoder<'a, DataType, CorrType, Transform>
where
    Transform: PredictionSchemeEncodingTransform<DataType, CorrType>,
{
    fn get_prediction_method(&self) -> PredictionSchemeMethod {
        PredictionSchemeMethod::MeshPredictionConstrainedMultiParallelogram
    }

    fn is_initialized(&self) -> bool {
        self.mesh_data.corner_table().is_some()
    }

    fn get_num_parent_attributes(&self) -> i32 {
        0
    }

    fn get_parent_attribute_type(
        &self,
        _i: i32,
    ) -> crate::geometry_attribute::GeometryAttributeType {
        crate::geometry_attribute::GeometryAttributeType::Generic
    }

    fn set_parent_attribute(&mut self, _att: &'a PointAttribute) -> bool {
        false
    }

    fn get_transform_type(&self) -> PredictionSchemeTransformType {
        self.transform.get_type()
    }
}

#[cfg(feature = "encoder")]
struct Error {
    num_bits: i64,
    residual_error: i64,
}

#[cfg(feature = "encoder")]
impl Error {
    fn new() -> Self {
        Self {
            num_bits: 0,
            residual_error: 0,
        }
    }
}

#[cfg(feature = "encoder")]
impl PartialEq for Error {
    fn eq(&self, other: &Self) -> bool {
        self.num_bits == other.num_bits && self.residual_error == other.residual_error
    }
}

#[cfg(feature = "encoder")]
impl PartialOrd for Error {
    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
        match self.num_bits.partial_cmp(&other.num_bits) {
            Some(std::cmp::Ordering::Equal) => {
                self.residual_error.partial_cmp(&other.residual_error)
            }
            other => other,
        }
    }
}

#[cfg(feature = "encoder")]
impl<'a, DataType, CorrType, Transform> PredictionSchemeEncoder<'a, DataType, CorrType>
    for MeshPredictionSchemeConstrainedMultiParallelogramEncoder<'a, DataType, CorrType, Transform>
where
    DataType: ParallelogramDataType + Into<i64> + Copy + Default + From<i32>,
    CorrType: Copy + Default + From<DataType> + std::ops::Sub<Output = CorrType> + From<i32>,
    Transform: PredictionSchemeEncodingTransform<DataType, CorrType>,
    i64: From<DataType>,
{
    fn compute_correction_values(
        &mut self,
        in_data: &[DataType],
        out_corr: &mut [CorrType],
        size: usize,
        num_components: usize,
        _entry_to_point_id_map: Option<crate::prediction_scheme::EntryToPointIdMap<'_>>,
    ) -> bool {
        self.transform.init(in_data, size, num_components);

        if num_components == 0 || !size.is_multiple_of(num_components) {
            return false;
        }
        let num_entries = size / num_components;

        let corner_table = match self.mesh_data.corner_table() {
            Some(ct) => ct,
            None => return false,
        };
        let vertex_to_data_map = match self.mesh_data.vertex_to_data_map() {
            Some(map) => map,
            None => return false,
        };

        for i in 0..MAX_NUM_PARALLELOGRAMS {
            self.is_crease_edge[i].clear();
        }

        let mut pred_vals = vec![vec![DataType::default(); num_components]; MAX_NUM_PARALLELOGRAMS];
        let mut multi_pred_vals = vec![DataType::default(); num_components];
        let mut entropy_symbols = vec![0u32; num_components];
        let mut predicted_val = vec![DataType::default(); num_components];
        let mut corr_val = vec![CorrType::default(); num_components];
        let mut tmp_entropy_symbols = vec![0u32; num_components];
        let mut tmp_pred_vals = vec![DataType::default(); num_components];

        // Track total parallelograms and used parallelograms for overhead calculation
        let mut total_parallelograms: [i64; MAX_NUM_PARALLELOGRAMS] = [0; MAX_NUM_PARALLELOGRAMS];
        let mut total_used_parallelograms: [i64; MAX_NUM_PARALLELOGRAMS] =
            [0; MAX_NUM_PARALLELOGRAMS];
        #[cfg(feature = "debug_logs")]
        let debug_cmp = crate::debug_env_enabled("DRACO_DEBUG_CMP");
        #[cfg(not(feature = "debug_logs"))]
        let debug_cmp = false;

        // C++ encoder processes vertices from the end because this prediction uses
        // data from previous entries that could be overwritten when an entry is processed.
        // We iterate BACKWARD from (num_entries - 1) down to 1, matching C++.
        for data_id in (1..num_entries).rev() {
            let data_offset = data_id * num_components;

            let corner_id = if let Some(map) = self.mesh_data.data_to_corner_map() {
                if data_id < map.len() {
                    CornerIndex(map[data_id])
                } else {
                    INVALID_CORNER_INDEX
                }
            } else if data_id < corner_table.num_vertices() {
                corner_table.left_most_corner(crate::geometry_indices::VertexIndex(data_id as u32))
            } else {
                INVALID_CORNER_INDEX
            };

            if corner_id == INVALID_CORNER_INDEX {
                predicted_val.fill(DataType::default());
                if data_id > 0 {
                    let prev_offset = (data_id - 1) * num_components;
                    for c in 0..num_components {
                        predicted_val[c] = in_data[prev_offset + c];
                    }
                }

                corr_val.fill(CorrType::default());
                self.transform.compute_correction(
                    &in_data[data_offset..data_offset + num_components],
                    &predicted_val,
                    &mut corr_val,
                );
                for c in 0..num_components {
                    out_corr[data_offset + c] = corr_val[c];
                    // Update entropy tracker with delta residuals?
                    // The C++ implementation seems to only update entropy tracker for the chosen configuration.
                    // If no parallelogram, it falls back to delta.
                    // We should probably update tracker here too to keep it consistent?
                    // But wait, the tracker is used to estimate bits for *parallelogram* residuals.
                    // If we use delta, the residuals might have different distribution.
                    // However, the entropy tracker is global for the attribute.
                    // Let's assume we should update it.
                    // But wait, `ComputeError` uses `entropy_tracker_.Peek`.
                    // And after selection, we call `entropy_tracker_.Push`.
                    // So yes, we should push.

                    // But wait, `ComputeError` calculates `num_bits` based on `entropy_tracker`.
                    // If we don't use `ComputeError` here (because no choice), we still need to push the symbols
                    // so that future `ComputeError` calls have correct context.

                    // But `out_corr` are the residuals.
                    // We need to convert them to symbols.
                    // `CorrType` might not be easily convertible to `i64`.
                    // But `DataType` is.
                    // `compute_correction` computes `out_corr`.
                    // We can compute `dif` manually as `in_data - predicted`.
                    // `DataType` subtraction?
                    // `DataType` has `Into<i64>`.
                    let val = in_data[data_offset + c].into();
                    let pred = predicted_val[c].into();
                    let dif = val - pred;
                    entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                }
                self.entropy_tracker.push(&entropy_symbols);
                continue;
            }

            let mut corners = [INVALID_CORNER_INDEX; MAX_NUM_PARALLELOGRAMS];
            let mut num_parallelograms = 0;

            let start_c = corner_id;
            let mut c = start_c;
            let mut first_pass = true;
            let mut swing_steps = 0usize;
            let max_swing_steps = corner_table.num_corners().saturating_add(1);
            while c != INVALID_CORNER_INDEX {
                swing_steps += 1;
                if swing_steps > max_swing_steps {
                    return false;
                }
                let opp = corner_table.opposite(c);
                if opp != INVALID_CORNER_INDEX {
                    let opp_v = corner_table.vertex(opp);
                    // Match C++ ComputeParallelogramPrediction(): next/prev must be
                    // taken from the opposite corner (oci), not from |c|.
                    let next_v = corner_table.vertex(corner_table.next(opp));
                    let prev_v = corner_table.vertex(corner_table.previous(opp));

                    let opp_data_id = *vertex_to_data_map.get(opp_v.0 as usize).unwrap_or(&-1);
                    let next_data_id = *vertex_to_data_map.get(next_v.0 as usize).unwrap_or(&-1);
                    let prev_data_id = *vertex_to_data_map.get(prev_v.0 as usize).unwrap_or(&-1);

                    if opp_data_id != -1
                        && next_data_id != -1
                        && prev_data_id != -1
                        && (opp_data_id as usize) < data_id
                        && (next_data_id as usize) < data_id
                        && (prev_data_id as usize) < data_id
                        && num_parallelograms < MAX_NUM_PARALLELOGRAMS
                    {
                        corners[num_parallelograms] = c;
                        num_parallelograms += 1;
                        if num_parallelograms == MAX_NUM_PARALLELOGRAMS {
                            break;
                        }
                    }
                }

                // Proceed to the next corner attached to the vertex.
                // First swing left and if we reach a boundary, swing right from
                // the start corner.
                c = if first_pass {
                    corner_table.swing_left(c)
                } else {
                    corner_table.swing_right(c)
                };
                if c == start_c {
                    break;
                }
                if c == INVALID_CORNER_INDEX && first_pass {
                    first_pass = false;
                    c = corner_table.swing_right(start_c);
                }
            }

            if num_parallelograms == 0 {
                predicted_val.fill(DataType::default());
                if data_id > 0 {
                    let prev_offset = (data_id - 1) * num_components;
                    for c in 0..num_components {
                        predicted_val[c] = in_data[prev_offset + c];
                    }
                }

                corr_val.fill(CorrType::default());
                self.transform.compute_correction(
                    &in_data[data_offset..data_offset + num_components],
                    &predicted_val,
                    &mut corr_val,
                );
                for c in 0..num_components {
                    out_corr[data_offset + c] = corr_val[c];
                    // For entropy tracking, C++ uses predicted - actual
                    let val = in_data[data_offset + c].into();
                    let pred = predicted_val[c].into();
                    let dif = pred - val; // predicted - actual, like C++
                    entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                }
                self.entropy_tracker.push(&entropy_symbols);
                continue;
            }

            for i in 0..num_parallelograms {
                let ci = corners[i];
                let oci = corner_table.opposite(ci);
                let vert_opp = vertex_to_data_map[corner_table.vertex(oci).0 as usize];
                // BUG FIX: Must use oci (opposite corner), not ci, to get next/prev vertices
                // This matches C++ ComputeParallelogramPrediction() behavior
                let vert_next =
                    vertex_to_data_map[corner_table.vertex(corner_table.next(oci)).0 as usize];
                let vert_prev =
                    vertex_to_data_map[corner_table.vertex(corner_table.previous(oci)).0 as usize];

                let v_opp_off = (vert_opp as usize) * num_components;
                let v_next_off = (vert_next as usize) * num_components;
                let v_prev_off = (vert_prev as usize) * num_components;

                for k in 0..num_components {
                    pred_vals[i][k] = DataType::compute_parallelogram_prediction(
                        in_data[v_next_off + k],
                        in_data[v_prev_off + k],
                        in_data[v_opp_off + k],
                    );
                }
            }

            let mut best_error = Error {
                num_bits: i64::MAX,
                residual_error: i64::MAX,
            };
            let mut best_config = 0u8;
            let mut best_num_used = 0;

            // C++ increments total_parallelograms BEFORE evaluating any configurations.
            // This is critical for matching the overhead calculation exactly.
            let context = num_parallelograms - 1;
            total_parallelograms[context] += num_parallelograms as i64;

            let num_configs = 1 << num_parallelograms;
            // Config 0 is valid (all creases = delta prediction)
            for config in 0..num_configs {
                let mut num_used = 0;
                for k in 0..num_components {
                    multi_pred_vals[k] = DataType::default();
                }

                for i in 0..num_parallelograms {
                    if (config & (1 << i)) != 0 {
                        num_used += 1;
                    }
                }

                if num_used == 0 {
                    // Delta prediction (config 0: all parallelograms marked as creases)
                    predicted_val.fill(DataType::default());
                    if data_id > 0 {
                        let prev_offset = (data_id - 1) * num_components;
                        for c in 0..num_components {
                            predicted_val[c] = in_data[prev_offset + c];
                        }
                    }

                    let mut error = Error::new();
                    for c in 0..num_components {
                        // For entropy tracking, C++ uses predicted - actual
                        let val = in_data[data_offset + c].into();
                        let pred = predicted_val[c].into();
                        let dif = pred - val; // predicted - actual, like C++
                        error.residual_error += dif.abs();
                        entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                    }

                    let entropy_data = self.entropy_tracker.peek(&entropy_symbols);
                    error.num_bits =
                        ShannonEntropyTracker::get_number_of_data_bits_static(&entropy_data)
                            + ShannonEntropyTracker::get_number_of_r_ans_table_bits_static(
                                &entropy_data,
                            );

                    // Add overhead bits - C++ uses total cumulative overhead
                    // For config 0: no parallelograms used, so total_used stays the same
                    let overhead_bits = Self::compute_overhead_bits(
                        total_used_parallelograms[context],
                        total_parallelograms[context],
                    );
                    error.num_bits += overhead_bits;

                    if error < best_error {
                        best_error = error;
                        best_config = config as u8;
                        best_num_used = 0;
                    }
                    continue;
                }

                // Multi-parallelogram prediction
                // Encoder must use same accumulation as decoder: AddAsUnsigned (wrapping add)
                for k in 0..num_components {
                    let mut sum: i32 = 0;
                    for i in 0..num_parallelograms {
                        if (config & (1 << i)) != 0 {
                            let pred_val: i64 = pred_vals[i][k].into();
                            // AddAsUnsigned: convert to unsigned, add, convert back
                            sum = (sum as u32).wrapping_add(pred_val as u32) as i32;
                        }
                    }
                    // C++ uses truncating integer division (not rounding)
                    let val = sum / num_used;
                    multi_pred_vals[k] = DataType::from(val);
                }

                let mut error = Error::new();
                for c in 0..num_components {
                    // For entropy tracking, C++ uses predicted - actual
                    let val = in_data[data_offset + c].into();
                    let pred = multi_pred_vals[c].into();
                    let dif = pred - val; // predicted - actual, like C++
                    error.residual_error += dif.abs();
                    entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                }

                let entropy_data = self.entropy_tracker.peek(&entropy_symbols);
                error.num_bits =
                    ShannonEntropyTracker::get_number_of_data_bits_static(&entropy_data)
                        + ShannonEntropyTracker::get_number_of_r_ans_table_bits_static(
                            &entropy_data,
                        );

                // Add overhead bits - C++ computes overhead assuming this config is chosen
                // If num_used parallelograms are used, total_used increases by num_used
                let overhead_bits = Self::compute_overhead_bits(
                    total_used_parallelograms[context] + num_used as i64,
                    total_parallelograms[context],
                );

                error.num_bits += overhead_bits;

                if error < best_error {
                    best_error = error;
                    best_config = config as u8;
                    best_num_used = num_used;
                }
            }

            // Diagnostic logging: compare cumulative vs marginal cost choices if requested
            if debug_cmp {
                use std::sync::atomic::AtomicUsize;
                static _CMP_DIV_COUNT: AtomicUsize = AtomicUsize::new(0);
                const _MAX_CMP_DIV_PRINT: usize = 200;

                // Compute marginal-choice simulation (old bug style): per-vertex overhead as local cost
                let mut marginal_best_error = Error::new();
                marginal_best_error.num_bits = i64::MAX;
                let mut _marginal_best_config: u8 = 0;
                for config in 0..(1 << num_parallelograms) {
                    let mut num_used = 0;
                    for i in 0..num_parallelograms {
                        if (config & (1 << i)) != 0 {
                            num_used += 1;
                        }
                    }
                    // compute residual/rans bits same as above
                    tmp_entropy_symbols.fill(0);
                    tmp_pred_vals.fill(DataType::default());
                    if num_used == 0 {
                        if data_id > 0 {
                            let prev_offset = (data_id - 1) * num_components;
                            for c in 0..num_components {
                                tmp_pred_vals[c] = in_data[prev_offset + c];
                            }
                        }
                    } else {
                        for k in 0..num_components {
                            let mut sum: i32 = 0;
                            for i in 0..num_parallelograms {
                                if (config & (1 << i)) != 0 {
                                    let pred_val: i64 = pred_vals[i][k].into();
                                    sum = (sum as u32).wrapping_add(pred_val as u32) as i32;
                                }
                            }
                            let val = sum / num_used;
                            tmp_pred_vals[k] = DataType::from(val);
                        }
                    }
                    let mut tmp_err = Error::new();
                    for c in 0..num_components {
                        let val = in_data[data_offset + c].into();
                        let pred = tmp_pred_vals[c].into();
                        let dif = val - pred;
                        tmp_err.residual_error += dif.abs();
                        tmp_entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                    }
                    let entropy_data = self.entropy_tracker.peek(&tmp_entropy_symbols);
                    tmp_err.num_bits =
                        ShannonEntropyTracker::get_number_of_data_bits_static(&entropy_data)
                            + ShannonEntropyTracker::get_number_of_r_ans_table_bits_static(
                                &entropy_data,
                            );
                    // marginal overhead bits (local) as previously implemented: compute binary entropy with historical p
                    let p = if total_parallelograms[context] == 0 {
                        0.0
                    } else {
                        total_used_parallelograms[context] as f64
                            / total_parallelograms[context] as f64
                    };
                    let p = p.clamp(0.001, 0.999);
                    let num_bits_local = num_parallelograms as i64;
                    let num_ones = num_used as i64;
                    let num_zeros = num_bits_local - num_ones;
                    let local_cost =
                        -(num_ones as f64) * p.log2() - (num_zeros as f64) * (1.0 - p).log2();
                    let local_cost_bits = local_cost.ceil() as i64;
                    tmp_err.num_bits += local_cost_bits;
                    if tmp_err < marginal_best_error {
                        marginal_best_error = tmp_err;
                        _marginal_best_config = config as u8;
                    }
                }
            }

            // Apply best config - update total_used_parallelograms (total_parallelograms already updated above)
            // C++ updates total_used_parallelograms AFTER choosing the best config
            total_used_parallelograms[context] += best_num_used as i64;

            for i in 0..num_parallelograms {
                let is_used = (best_config & (1 << i)) != 0;
                // is_crease_edge stores true if NOT used (crease).
                self.is_crease_edge[context].push(!is_used);
            }

            // Recompute prediction for best config and update output/tracker
            if best_num_used == 0 {
                predicted_val.fill(DataType::default());
                if data_id > 0 {
                    let prev_offset = (data_id - 1) * num_components;
                    for c in 0..num_components {
                        predicted_val[c] = in_data[prev_offset + c];
                    }
                }

                corr_val.fill(CorrType::default());
                self.transform.compute_correction(
                    &in_data[data_offset..data_offset + num_components],
                    &predicted_val,
                    &mut corr_val,
                );
                for c in 0..num_components {
                    out_corr[data_offset + c] = corr_val[c];
                    // For entropy tracking, C++ uses predicted - actual
                    // (opposite of what the transform uses for correction)
                    let val = in_data[data_offset + c].into();
                    let pred = predicted_val[c].into();
                    let dif = pred - val; // predicted - actual, like C++
                    entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                }
            } else {
                // Encoder must use same accumulation as decoder: AddAsUnsigned (wrapping add)
                for k in 0..num_components {
                    let mut sum: i32 = 0;
                    for i in 0..num_parallelograms {
                        if (best_config & (1 << i)) != 0 {
                            let pred_val: i64 = pred_vals[i][k].into();
                            // AddAsUnsigned: convert to unsigned, add, convert back
                            sum = (sum as u32).wrapping_add(pred_val as u32) as i32;
                        }
                    }
                    // C++ uses truncating integer division (not rounding)
                    let val = sum / best_num_used;
                    multi_pred_vals[k] = DataType::from(val);
                }

                corr_val.fill(CorrType::default());
                self.transform.compute_correction(
                    &in_data[data_offset..data_offset + num_components],
                    &multi_pred_vals,
                    &mut corr_val,
                );
                for c in 0..num_components {
                    out_corr[data_offset + c] = corr_val[c];
                    // For entropy tracking, C++ uses predicted - actual
                    // (opposite of what the transform uses for correction)
                    let val = in_data[data_offset + c].into();
                    let pred = multi_pred_vals[c].into();
                    let dif = pred - val; // predicted - actual, like C++
                    entropy_symbols[c] = Self::convert_signed_int_to_symbol(dif);
                }
            }
            self.entropy_tracker.push(&entropy_symbols);
        }

        // First element is always fixed because it cannot be predicted.
        // Use zero prediction like C++ does.
        predicted_val.fill(DataType::default());
        corr_val.fill(CorrType::default());
        self.transform.compute_correction(
            &in_data[0..num_components],
            &predicted_val,
            &mut corr_val,
        );
        for c in 0..num_components {
            out_corr[c] = corr_val[c];
        }

        true
    }

    fn encode_prediction_data(&mut self, buffer: &mut Vec<u8>) -> bool {
        let mut enc = EncoderBuffer::new();
        // Propagate the target version so crease-edge rANS streams pick the right
        // size-prefix encoding (pre-2.2 u32 vs 2.2+ varint).
        enc.set_version(
            (self.bitstream_version >> 8) as u8,
            (self.bitstream_version & 0xff) as u8,
        );

        // C++ bitstream order: crease edges FIRST, then transform data.
        // Encode crease edges.
        for i in 0..MAX_NUM_PARALLELOGRAMS {
            let num_flags = self.is_crease_edge[i].len() as u32;
            enc.encode_varint(num_flags as u64);

            if num_flags > 0 {
                let mut ans_encoder = RAnsBitEncoder::new();
                ans_encoder.start_encoding();

                // C++ encoder processes vertices BACKWARD (high to low) and writes flags
                // in REVERSE order (from last group to first). Since ANS is LIFO, this
                // results in flags decoding in the order they were collected (backward),
                // which is the same order the decoder expects.
                //
                // Rust encoder now also iterates backward, so is_crease_edge is in same order as C++.
                // We must write in reverse order like C++ to match the bitstream exactly.
                //
                // |i| is the context = num_parallelograms - 1, so num_used = i + 1
                let num_used_parallelograms = i + 1;
                let flags = &self.is_crease_edge[i];

                // Write flags in reverse order: start from last group, step backward
                let mut j = flags.len() as i32 - num_used_parallelograms as i32;
                while j >= 0 {
                    for k in 0..num_used_parallelograms {
                        ans_encoder.encode_bit(flags[(j as usize) + k]);
                    }
                    j -= num_used_parallelograms as i32;
                }

                ans_encoder.end_encoding(&mut enc);
            }
        }

        // Encode underlying transform data second (e.g. Wrap min/max bounds).
        let mut transform_data = Vec::new();
        if !self.transform.encode_transform_data(&mut transform_data) {
            return false;
        }
        enc.encode_data(&transform_data);

        buffer.extend_from_slice(enc.data());
        true
    }
}

#[cfg(feature = "encoder")]
impl<'a, DataType, CorrType, Transform>
    MeshPredictionSchemeConstrainedMultiParallelogramEncoder<'a, DataType, CorrType, Transform>
{
    /// Computes the total cumulative overhead bits for the entire overhead stream.
    /// This matches C++ ComputeOverheadBits() which returns:
    ///   ceil(total_parallelograms * binary_shannon_entropy(total_used / total))
    ///
    /// The key insight is that C++ computes the TOTAL bits needed to encode ALL
    /// overhead flags seen so far, not just the marginal cost of the current vertex.
    fn compute_overhead_bits(total_used_parallelograms: i64, total_parallelograms: i64) -> i64 {
        // C++ uses ComputeBinaryShannonEntropy and then multiplies by total_parallelograms
        let entropy = crate::shannon_entropy::compute_binary_shannon_entropy(
            total_parallelograms as u32,
            total_used_parallelograms as u32,
        );
        // Round up to the nearest full bit.
        ((total_parallelograms as f64) * entropy).ceil() as i64
    }
}

#[cfg(feature = "decoder")]
pub struct MeshPredictionSchemeConstrainedMultiParallelogramDecoder<
    'a,
    DataType,
    CorrType,
    Transform,
> {
    mesh_data: MeshPredictionSchemeData<'a>,
    transform: Transform,
    is_crease_edge: [Vec<bool>; MAX_NUM_PARALLELOGRAMS],
    _marker: PhantomData<(DataType, CorrType)>,
}

#[cfg(feature = "decoder")]
impl<'a, DataType, CorrType, Transform>
    MeshPredictionSchemeConstrainedMultiParallelogramDecoder<'a, DataType, CorrType, Transform>
where
    Transform: PredictionSchemeDecodingTransform<DataType, CorrType>,
{
    pub fn new(transform: Transform, mesh_data: MeshPredictionSchemeData<'a>) -> Self {
        Self {
            mesh_data,
            transform,
            is_crease_edge: Default::default(),
            _marker: PhantomData,
        }
    }
}

#[cfg(feature = "decoder")]
impl<'a, DataType, CorrType, Transform> PredictionScheme<'a>
    for MeshPredictionSchemeConstrainedMultiParallelogramDecoder<'a, DataType, CorrType, Transform>
where
    Transform: PredictionSchemeDecodingTransform<DataType, CorrType>,
{
    fn get_prediction_method(&self) -> PredictionSchemeMethod {
        PredictionSchemeMethod::MeshPredictionConstrainedMultiParallelogram
    }

    fn is_initialized(&self) -> bool {
        self.mesh_data.corner_table().is_some()
    }

    fn get_num_parent_attributes(&self) -> i32 {
        0
    }

    fn get_parent_attribute_type(
        &self,
        _i: i32,
    ) -> crate::geometry_attribute::GeometryAttributeType {
        crate::geometry_attribute::GeometryAttributeType::Generic
    }

    fn set_parent_attribute(&mut self, _att: &'a PointAttribute) -> bool {
        false
    }

    fn get_transform_type(&self) -> PredictionSchemeTransformType {
        self.transform.get_type()
    }
}

#[cfg(feature = "decoder")]
impl<'a, DataType, CorrType, Transform> PredictionSchemeDecoder<'a, DataType, CorrType>
    for MeshPredictionSchemeConstrainedMultiParallelogramDecoder<'a, DataType, CorrType, Transform>
where
    DataType: ParallelogramDataType + Into<i64> + Copy + Default + From<i32>,
    CorrType: Copy + Default + From<DataType> + std::ops::Sub<Output = CorrType> + From<i32>,
    Transform: PredictionSchemeDecodingTransform<DataType, CorrType>,
    i64: From<DataType>,
{
    fn decode_prediction_data(&mut self, buffer: &mut DecoderBuffer) -> bool {
        // Draco bitstream order (see C++ MeshPredictionSchemeConstrainedMultiParallelogramDecoder):
        // 1) (optional) mode for < v2.2
        // 2) crease-edge flag streams
        // 3) underlying transform data (e.g. Wrap bounds)

        // Pre-2.2 streams prefix a prediction-mode byte (only the optimal
        // multi-parallelogram mode is supported). 2.2+ dropped it; without this
        // read the mode byte is consumed as the first context's flag count,
        // leaving every crease-edge stream empty.
        #[cfg(feature = "legacy_bitstream_decode")]
        {
            let bitstream_version = buffer.bitstream_version();
            if bitstream_version < 0x0202 {
                match buffer.decode_u8() {
                    Ok(0) => {} // OPTIMAL_MULTI_PARALLELOGRAM
                    _ => return false,
                }
            }
        }

        // Decode crease edges.
        let corner_table = match self.mesh_data.corner_table() {
            Some(ct) => ct,
            None => {
                return false;
            }
        };

        for i in 0..MAX_NUM_PARALLELOGRAMS {
            let num_flags = match buffer.decode_varint() {
                Ok(v) => v as u32,
                Err(_) => return false,
            };

            if num_flags > corner_table.num_corners() as u32 {
                return false;
            }

            if num_flags > 0 {
                self.is_crease_edge[i].resize(num_flags as usize, false);
                let mut ans_decoder = RAnsBitDecoder::new();
                if !ans_decoder.start_decoding(buffer) {
                    return false;
                }
                for j in 0..num_flags {
                    self.is_crease_edge[i][j as usize] = ans_decoder.decode_next_bit();
                }
                ans_decoder.end_decoding();
            }
        }

        // Decode underlying transform data last (e.g. Wrap min/max bounds).
        if !self.transform.decode_transform_data(buffer) {
            return false;
        }
        true
    }

    fn compute_original_values(
        &mut self,
        in_corr: &[CorrType],
        out_data: &mut [DataType],
        size: usize,
        num_components: usize,
        _entry_to_point_id_map: Option<crate::prediction_scheme::EntryToPointIdMap<'_>>,
    ) -> bool {
        self.transform.init(num_components);

        if size == 0 {
            return true;
        }
        if num_components == 0 || !size.is_multiple_of(num_components) {
            return false;
        }
        if size < num_components {
            return false;
        }
        let num_entries = size / num_components;

        let Some(corner_table) = self.mesh_data.corner_table() else {
            return false;
        };
        let Some(vertex_to_data_map) = self.mesh_data.vertex_to_data_map() else {
            return false;
        };
        if in_corr.len() < size || out_data.len() < size {
            return false;
        }

        let mut multi_pred_vals = vec![DataType::default(); num_components];
        let zero_vals = vec![DataType::default(); num_components];
        let mut predicted_val = vec![DataType::default(); num_components];

        // Current position in is_crease_edge
        let mut is_crease_edge_pos = [0usize; MAX_NUM_PARALLELOGRAMS];

        // First value
        if size > 0 {
            self.transform.compute_original_value(
                &zero_vals,
                &in_corr[0..num_components],
                &mut out_data[0..num_components],
            );
        }

        for data_id in 1..num_entries {
            let data_offset = data_id * num_components;

            let corner_id = if let Some(map) = self.mesh_data.data_to_corner_map() {
                if data_id < map.len() {
                    CornerIndex(map[data_id])
                } else {
                    INVALID_CORNER_INDEX
                }
            } else if data_id < corner_table.num_vertices() {
                corner_table.left_most_corner(crate::geometry_indices::VertexIndex(data_id as u32))
            } else {
                INVALID_CORNER_INDEX
            };

            if corner_id == INVALID_CORNER_INDEX {
                let prev_offset = (data_id - 1) * num_components;
                predicted_val.fill(DataType::default());
                for c in 0..num_components {
                    predicted_val[c] = out_data[prev_offset + c];
                }
                self.transform.compute_original_value(
                    &predicted_val,
                    &in_corr[data_offset..data_offset + num_components],
                    &mut out_data[data_offset..data_offset + num_components],
                );
                continue;
            }

            let mut corners = [INVALID_CORNER_INDEX; MAX_NUM_PARALLELOGRAMS];
            let mut num_parallelograms = 0;

            let start_c = corner_id;
            let mut c = start_c;
            let mut first_pass = true;
            let mut swing_steps = 0usize;
            let max_swing_steps = corner_table.num_corners().saturating_add(1);
            while c != INVALID_CORNER_INDEX {
                swing_steps += 1;
                if swing_steps > max_swing_steps {
                    return false;
                }
                let opp = corner_table.opposite(c);
                if opp != INVALID_CORNER_INDEX {
                    let opp_v = corner_table.vertex(opp);
                    // Match C++ ComputeParallelogramPrediction(): next/prev must be
                    // taken from the opposite corner (oci), not from |c|.
                    let next_v = corner_table.vertex(corner_table.next(opp));
                    let prev_v = corner_table.vertex(corner_table.previous(opp));

                    let opp_data_id = *vertex_to_data_map.get(opp_v.0 as usize).unwrap_or(&-1);
                    let next_data_id = *vertex_to_data_map.get(next_v.0 as usize).unwrap_or(&-1);
                    let prev_data_id = *vertex_to_data_map.get(prev_v.0 as usize).unwrap_or(&-1);

                    if opp_data_id != -1
                        && next_data_id != -1
                        && prev_data_id != -1
                        && (opp_data_id as usize) < data_id
                        && (next_data_id as usize) < data_id
                        && (prev_data_id as usize) < data_id
                        && num_parallelograms < MAX_NUM_PARALLELOGRAMS
                    {
                        corners[num_parallelograms] = c;
                        num_parallelograms += 1;
                        if num_parallelograms == MAX_NUM_PARALLELOGRAMS {
                            break;
                        }
                    }
                }

                // Proceed to the next corner attached to the vertex.
                c = if first_pass {
                    corner_table.swing_left(c)
                } else {
                    corner_table.swing_right(c)
                };
                if c == start_c {
                    break;
                }
                if c == INVALID_CORNER_INDEX && first_pass {
                    first_pass = false;
                    c = corner_table.swing_right(start_c);
                }
            }

            let mut num_used_parallelograms = 0;
            if num_parallelograms > 0 {
                for k in 0..num_components {
                    multi_pred_vals[k] = DataType::default();
                }

                for i in 0..num_parallelograms {
                    let context = num_parallelograms - 1;
                    let pos = is_crease_edge_pos[context];
                    is_crease_edge_pos[context] += 1;

                    // Check bounds - if we've exhausted the flags, this is an error
                    if pos >= self.is_crease_edge[context].len() {
                        // This should never happen if encoder/decoder are in sync
                        debug_log!("ERROR: is_crease_edge bounds exceeded: pos={} >= len={}, context={}, data_id={}", 
                            pos, self.is_crease_edge[context].len(), context, data_id);
                        return false;
                    }
                    let is_crease = self.is_crease_edge[context][pos];

                    if !is_crease {
                        // Compute prediction for this parallelogram
                        let ci = corners[i];
                        let oci = corner_table.opposite(ci);
                        let Some(&vert_opp) =
                            vertex_to_data_map.get(corner_table.vertex(oci).0 as usize)
                        else {
                            return false;
                        };
                        let Some(&vert_next) = vertex_to_data_map
                            .get(corner_table.vertex(corner_table.next(oci)).0 as usize)
                        else {
                            return false;
                        };
                        let Some(&vert_prev) = vertex_to_data_map
                            .get(corner_table.vertex(corner_table.previous(oci)).0 as usize)
                        else {
                            return false;
                        };
                        if vert_opp < 0 || vert_next < 0 || vert_prev < 0 {
                            return false;
                        }

                        let v_opp_off = (vert_opp as usize) * num_components;
                        let v_next_off = (vert_next as usize) * num_components;
                        let v_prev_off = (vert_prev as usize) * num_components;
                        if v_opp_off + num_components > out_data.len()
                            || v_next_off + num_components > out_data.len()
                            || v_prev_off + num_components > out_data.len()
                        {
                            return false;
                        }

                        for k in 0..num_components {
                            let p = DataType::compute_parallelogram_prediction(
                                out_data[v_next_off + k],
                                out_data[v_prev_off + k],
                                out_data[v_opp_off + k],
                            );
                            // Use add_as_unsigned for C++ compatible accumulation
                            multi_pred_vals[k] = DataType::add_as_unsigned(multi_pred_vals[k], p);
                        }
                        num_used_parallelograms += 1;
                    }
                }
            }

            if num_used_parallelograms == 0 {
                let prev_offset = (data_id - 1) * num_components;
                predicted_val.fill(DataType::default());
                for c in 0..num_components {
                    predicted_val[c] = out_data[prev_offset + c];
                }
                self.transform.compute_original_value(
                    &predicted_val,
                    &in_corr[data_offset..data_offset + num_components],
                    &mut out_data[data_offset..data_offset + num_components],
                );
            } else {
                // C++ decoder uses truncating integer division (not rounding)
                for c in 0..num_components {
                    let val: i64 = multi_pred_vals[c].into();
                    let averaged = (val / num_used_parallelograms as i64) as i32;
                    multi_pred_vals[c] = DataType::from(averaged);
                }
                self.transform.compute_original_value(
                    &multi_pred_vals,
                    &in_corr[data_offset..data_offset + num_components],
                    &mut out_data[data_offset..data_offset + num_components],
                );
            }
        }
        true
    }
}