distkit 0.5.3

A toolkit of distributed systems primitives for Rust, backed by Redis
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
//! Direct-against-Redis tests for the rwlock backend
//! (`crate::lock::rwlock_backend`): shared reads, exclusive writes, the
//! writer-preference invariant (readers yield to a waiting writer), the
//! `mark_pending` flag (one-shot writes don't enqueue / block readers), FIFO
//! ordering among waiting writers, lazy purge of expired readers / dead waiting
//! writers, and owner-gated refresh / release.
//!
//! All ops on one lock pass a **consistent `ttl_ms`** — the reader/pending purge
//! thresholds are computed from the caller's `ttl_ms`, not stored per member, so
//! mixing ttls on the same key gives inconsistent expiry (see the module review).

use std::time::Duration;

use redis::aio::ConnectionManager;

use crate::lock::rwlock_backend::{self, AcquireOptions};
use crate::lock::tests::common::{RwKeys, make_options_with_rw_keys};

const READER_A: &str = "reader_a";
const READER_B: &str = "reader_b";
const WRITER_A: &str = "writer_a";
const WRITER_B: &str = "writer_b";

const LONG_TTL: i64 = 30_000;
const SHORT_TTL: i64 = 150;
/// Comfortably past `SHORT_TTL` so a short-lived member is purgeable.
const PAST_SHORT_TTL: Duration = Duration::from_millis(300);

async fn conn_and_keys(name: &str) -> (ConnectionManager, RwKeys) {
    let (opts, keys) = make_options_with_rw_keys(name).await;
    (opts.connection_manager.clone(), keys)
}

fn opts<'a>(k: &'a RwKeys, owner: &'a str, ttl_ms: i64) -> AcquireOptions<'a> {
    AcquireOptions {
        owner,
        ttl_ms,
        writer_key: k.writer.as_str(),
        readers_key: k.readers.as_str(),
        pending_writers_key: k.pending.as_str(),
        pending_writers_heartbeat_key: k.pending_heartbeat.as_str(),
    }
}

async fn acquire_read(conn: &mut ConnectionManager, k: &RwKeys, owner: &str, ttl: i64) -> bool {
    rwlock_backend::acquire_read(conn, opts(k, owner, ttl))
        .await
        .unwrap()
}

/// `acquire_write` that joins the writer queue when blocked (the waiting forms).
async fn write_waiting(conn: &mut ConnectionManager, k: &RwKeys, owner: &str, ttl: i64) -> bool {
    rwlock_backend::acquire_write(conn, opts(k, owner, ttl), true)
        .await
        .unwrap()
}

/// `acquire_write` that does not enqueue when blocked (one-shot `try_write`).
async fn write_oneshot(conn: &mut ConnectionManager, k: &RwKeys, owner: &str, ttl: i64) -> bool {
    rwlock_backend::acquire_write(conn, opts(k, owner, ttl), false)
        .await
        .unwrap()
}

async fn release_write(conn: &mut ConnectionManager, k: &RwKeys, owner: &str) -> bool {
    rwlock_backend::release_write(conn, &k.writer, &k.pending, &k.pending_heartbeat, owner)
        .await
        .unwrap()
}

async fn zcard(conn: &mut ConnectionManager, key: &str) -> i64 {
    redis::cmd("ZCARD")
        .arg(key)
        .query_async(conn)
        .await
        .expect("ZCARD")
}

async fn writer_exists(conn: &mut ConnectionManager, key: &str) -> bool {
    let n: i64 = redis::cmd("EXISTS")
        .arg(key)
        .query_async(conn)
        .await
        .expect("EXISTS");
    n == 1
}

/// Seed a zset member at an exact score, bypassing the backend — lets a test
/// place two pending writers at an *identical* arrival score (see
/// `same_ms_writer_fifo_is_lexical`).
async fn zadd(conn: &mut ConnectionManager, key: &str, score: f64, member: &str) {
    let _: i64 = redis::cmd("ZADD")
        .arg(key)
        .arg(score)
        .arg(member)
        .query_async(conn)
        .await
        .expect("ZADD");
}

#[tokio::test]
async fn read_is_shared() {
    let (mut conn, k) = conn_and_keys("read_is_shared").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(acquire_read(&mut conn, &k, READER_B, LONG_TTL).await);
    assert_eq!(
        zcard(&mut conn, &k.readers).await,
        2,
        "both readers hold the lock"
    );
}

#[tokio::test]
async fn writer_blocks_new_readers() {
    let (mut conn, k) = conn_and_keys("writer_blocks_new_readers").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert!(
        !acquire_read(&mut conn, &k, READER_A, LONG_TTL).await,
        "a reader must not acquire while a writer holds the lock"
    );
}

#[tokio::test]
async fn write_waits_for_readers() {
    let (mut conn, k) = conn_and_keys("write_waits_for_readers").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(
        !write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "write fails while a reader holds the lock"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        1,
        "the blocked writer is queued"
    );

    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );
    assert!(
        write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "write succeeds once the reader is gone"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        0,
        "acquiring clears the queue entry"
    );
}

#[tokio::test]
async fn write_excludes_write() {
    let (mut conn, k) = conn_and_keys("write_excludes_write").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert!(
        !write_oneshot(&mut conn, &k, WRITER_B, LONG_TTL).await,
        "a second writer fails while the first holds the lock"
    );
}

#[tokio::test]
async fn reentrant_write_succeeds() {
    let (mut conn, k) = conn_and_keys("reentrant_write_succeeds").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert!(
        write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "the same owner re-acquiring its own write lock should succeed"
    );
}

/// The core invariant: once a writer is waiting, later readers may not jump ahead.
#[tokio::test]
async fn read_blocked_by_waiting_writer() {
    let (mut conn, k) = conn_and_keys("read_blocked_by_waiting_writer").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(
        !write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "writer now waiting"
    );

    assert!(
        !acquire_read(&mut conn, &k, READER_B, LONG_TTL).await,
        "a later reader must not jump ahead of the waiting writer"
    );

    // Writer abandons (release_write clears its pending entry); reader frees.
    assert!(
        !release_write(&mut conn, &k, WRITER_A).await,
        "abandon: not the holder"
    );
    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );
    assert!(
        acquire_read(&mut conn, &k, READER_B, LONG_TTL).await,
        "the reader proceeds once no writer is waiting"
    );
}

#[tokio::test]
async fn oneshot_write_does_not_enqueue_or_block_readers() {
    let (mut conn, k) = conn_and_keys("oneshot_write_does_not_enqueue_or_block_readers").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(
        !write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "one-shot write fails while a reader holds the lock"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        0,
        "mark_pending=false must not register a queue entry"
    );
    assert!(
        acquire_read(&mut conn, &k, READER_B, LONG_TTL).await,
        "a later reader proceeds since no writer is queued"
    );
}

#[tokio::test]
async fn waiting_write_enqueues_and_blocks_readers() {
    let (mut conn, k) = conn_and_keys("waiting_write_enqueues_and_blocks_readers").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(!write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        1,
        "mark_pending=true registers a queue entry"
    );
    assert!(
        !acquire_read(&mut conn, &k, READER_B, LONG_TTL).await,
        "a queued writer blocks later readers"
    );
}

#[tokio::test]
async fn writers_are_served_fifo() {
    let (mut conn, k) = conn_and_keys("writers_are_served_fifo").await;

    // A reader holds the lock so both writers queue.
    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(!write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await);
    // Separate arrival timestamps so FIFO order is unambiguous.
    tokio::time::sleep(Duration::from_millis(5)).await;
    assert!(!write_waiting(&mut conn, &k, WRITER_B, LONG_TTL).await);

    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );

    assert!(
        !write_waiting(&mut conn, &k, WRITER_B, LONG_TTL).await,
        "the later writer must yield to the one that arrived first"
    );
    assert!(
        write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "the earliest-arrived writer wins the lock"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        1,
        "only WRITER_B remains queued"
    );
}

#[tokio::test]
async fn expired_readers_are_purged() {
    let (mut conn, k) = conn_and_keys("expired_readers_are_purged").await;

    assert!(acquire_read(&mut conn, &k, READER_A, SHORT_TTL).await);
    tokio::time::sleep(PAST_SHORT_TTL).await;

    assert!(
        write_oneshot(&mut conn, &k, WRITER_A, SHORT_TTL).await,
        "write succeeds once the stale reader is purged"
    );
}

#[tokio::test]
async fn dead_waiting_writer_is_purged() {
    let (mut conn, k) = conn_and_keys("dead_waiting_writer_is_purged").await;

    // Writer queues behind a reader, then stops heart-beating; reader frees.
    assert!(acquire_read(&mut conn, &k, READER_A, SHORT_TTL).await);
    assert!(!write_waiting(&mut conn, &k, WRITER_A, SHORT_TTL).await);
    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );

    tokio::time::sleep(PAST_SHORT_TTL).await;

    assert!(
        acquire_read(&mut conn, &k, READER_B, SHORT_TTL).await,
        "a reader proceeds once the dead waiting writer is purged"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        0,
        "the dead writer left the queue"
    );
}

#[tokio::test]
async fn refresh_read_renews_and_reports_loss() {
    let (mut conn, k) = conn_and_keys("refresh_read_renews_and_reports_loss").await;

    assert!(acquire_read(&mut conn, &k, READER_A, SHORT_TTL).await);
    assert!(
        rwlock_backend::refresh_read(&mut conn, &k.readers, READER_A, SHORT_TTL)
            .await
            .unwrap(),
        "refreshing a live reader slot succeeds"
    );

    // Stop refreshing READER_B and let its slot age out.
    assert!(acquire_read(&mut conn, &k, READER_B, SHORT_TTL).await);
    tokio::time::sleep(PAST_SHORT_TTL).await;
    assert!(
        !rwlock_backend::refresh_read(&mut conn, &k.readers, READER_B, SHORT_TTL)
            .await
            .unwrap(),
        "refreshing an expired reader slot reports the loss"
    );
}

#[tokio::test]
async fn refresh_write_is_owner_gated() {
    let (mut conn, k) = conn_and_keys("refresh_write_is_owner_gated").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert!(
        rwlock_backend::refresh_write(&mut conn, &k.writer, WRITER_A, LONG_TTL)
            .await
            .unwrap(),
        "owner refresh succeeds"
    );
    assert!(
        !rwlock_backend::refresh_write(&mut conn, &k.writer, WRITER_B, LONG_TTL)
            .await
            .unwrap(),
        "non-owner refresh fails"
    );
}

#[tokio::test]
async fn release_write_is_owner_gated_and_frees() {
    let (mut conn, k) = conn_and_keys("release_write_is_owner_gated_and_frees").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);

    assert!(
        !release_write(&mut conn, &k, WRITER_B).await,
        "non-owner release fails"
    );
    assert!(
        writer_exists(&mut conn, &k.writer).await,
        "key survives a non-owner release"
    );

    assert!(
        release_write(&mut conn, &k, WRITER_A).await,
        "owner release succeeds"
    );
    assert!(
        !writer_exists(&mut conn, &k.writer).await,
        "key gone after owner release"
    );
}

#[tokio::test]
async fn release_write_clears_pending_on_abandon() {
    let (mut conn, k) = conn_and_keys("release_write_clears_pending_on_abandon").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(!write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert_eq!(zcard(&mut conn, &k.pending).await, 1);

    // A writer that gives up before acquiring uses release_write to leave the queue.
    assert!(
        !release_write(&mut conn, &k, WRITER_A).await,
        "never held the writer key"
    );
    assert_eq!(zcard(&mut conn, &k.pending).await, 0, "queue entry cleared");
    assert_eq!(
        zcard(&mut conn, &k.pending_heartbeat).await,
        0,
        "heartbeat cleared"
    );
}

// ---------------------------------------------------------------------------
// Edge-case behavior tests.
//
// These assert the EXPECTED behavior of the rwlock backend (as defined by the
// lock's owner), NOT whatever the code happens to do today. A failing test here
// therefore signals a real or potential bug to fix in the backend logic — it is
// not a cue to relax the assertion. See AGENTS.md "Testing philosophy".
// ---------------------------------------------------------------------------

/// EXPECTED (lock model): we allow many readers XOR one writer. While readers
/// hold the lock a writer enqueues; once any writer is pending, new readers are
/// refused until the pending queue is drained, and the queued writer (not a
/// reader) wins the handoff. So a writer blocked by a held writer enqueues, a
/// later reader is blocked by that queued writer, and on release the writer wins.
#[tokio::test]
async fn writer_blocked_by_writer_enqueues_and_keeps_preference() {
    let (mut conn, k) =
        conn_and_keys("writer_blocked_by_writer_enqueues_and_keeps_preference").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, LONG_TTL).await);
    assert!(
        !write_waiting(&mut conn, &k, WRITER_B, LONG_TTL).await,
        "second writer is blocked by the held writer"
    );
    assert_eq!(
        zcard(&mut conn, &k.pending).await,
        1,
        "a writer blocked by a held writer enqueues, guarding the handoff"
    );
    assert!(
        !acquire_read(&mut conn, &k, READER_A, LONG_TTL).await,
        "a later reader is blocked by the queued writer (writer-preference holds)"
    );

    assert!(
        release_write(&mut conn, &k, WRITER_A).await,
        "holder releases"
    );
    assert!(
        write_waiting(&mut conn, &k, WRITER_B, LONG_TTL).await,
        "the queued writer wins the lock on handoff, not a reader"
    );
}

/// EXPECTED (caller-ttl purge): there is no per-member ttl — purge thresholds
/// follow the calling op's `ttl_ms`. So a later op passing a shorter ttl may purge
/// an older reader that took a longer lease, and the write then proceeds. Intended.
#[tokio::test]
async fn purge_uses_caller_ttl_not_per_member() {
    let (mut conn, k) = conn_and_keys("purge_uses_caller_ttl_not_per_member").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    tokio::time::sleep(PAST_SHORT_TTL).await; // past SHORT_TTL, far short of LONG_TTL

    assert!(
        write_oneshot(&mut conn, &k, WRITER_A, SHORT_TTL).await,
        "a SHORT_TTL op purges the older LONG_TTL reader and acquires"
    );
}

/// EXPECTED (heartbeat cadence): a waiting writer must keep re-attempting faster
/// than `ttl_ms` to hold its queue slot. If it idles past `ttl_ms` its `:pwh`
/// heartbeat (and `:pw` slot) is purged and a later writer proceeds — i.e. the
/// caller's retry interval must stay `< ttl`. Intended.
#[tokio::test]
async fn idle_waiting_writer_loses_its_slot() {
    let (mut conn, k) = conn_and_keys("idle_waiting_writer_loses_its_slot").await;

    assert!(acquire_read(&mut conn, &k, READER_A, SHORT_TTL).await);
    assert!(
        !write_waiting(&mut conn, &k, WRITER_A, SHORT_TTL).await,
        "WRITER_A queues first"
    );
    assert_eq!(zcard(&mut conn, &k.pending).await, 1);

    // WRITER_A stops re-attempting; reader + WRITER_A's heartbeat both age out.
    tokio::time::sleep(PAST_SHORT_TTL).await;

    assert!(
        write_waiting(&mut conn, &k, WRITER_B, SHORT_TTL).await,
        "later WRITER_B proceeds once idle WRITER_A is purged from the queue"
    );
}

/// EXPECTED (ttl validation): every backend op that takes a `ttl_ms` must reject a
/// non-positive value (0 or negative) with an error, in the Rust layer, before
/// touching Redis. One test per ttl-taking entry point so each missing guard fails
/// independently.
#[tokio::test]
async fn acquire_read_rejects_nonpositive_ttl() {
    let (mut conn, k) = conn_and_keys("acquire_read_rejects_nonpositive_ttl").await;
    for ttl in [0_i64, -1] {
        assert!(
            rwlock_backend::acquire_read(&mut conn, opts(&k, READER_A, ttl))
                .await
                .is_err(),
            "acquire_read must error for ttl_ms = {ttl}"
        );
    }
}

#[tokio::test]
async fn acquire_write_rejects_nonpositive_ttl() {
    let (mut conn, k) = conn_and_keys("acquire_write_rejects_nonpositive_ttl").await;
    for ttl in [0_i64, -1] {
        assert!(
            rwlock_backend::acquire_write(&mut conn, opts(&k, WRITER_A, ttl), true)
                .await
                .is_err(),
            "acquire_write must error for ttl_ms = {ttl}"
        );
    }
}

#[tokio::test]
async fn refresh_read_rejects_nonpositive_ttl() {
    let (mut conn, k) = conn_and_keys("refresh_read_rejects_nonpositive_ttl").await;
    for ttl in [0_i64, -1] {
        assert!(
            rwlock_backend::refresh_read(&mut conn, &k.readers, READER_A, ttl)
                .await
                .is_err(),
            "refresh_read must error for ttl_ms = {ttl}"
        );
    }
}

#[tokio::test]
async fn refresh_write_rejects_nonpositive_ttl() {
    let (mut conn, k) = conn_and_keys("refresh_write_rejects_nonpositive_ttl").await;
    for ttl in [0_i64, -1] {
        assert!(
            rwlock_backend::refresh_write(&mut conn, &k.writer, WRITER_A, ttl)
                .await
                .is_err(),
            "refresh_write must error for ttl_ms = {ttl}"
        );
    }
}

/// EXPECTED (release_read gating): releasing a slot you don't hold — a non-member
/// or a second release — returns `Ok(false)`, not an error. Membership is the gate.
#[tokio::test]
async fn release_read_nonmember_and_double_release_return_false() {
    let (mut conn, k) =
        conn_and_keys("release_read_nonmember_and_double_release_return_false").await;

    assert!(
        !rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap(),
        "releasing a reader that never acquired returns false"
    );

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );
    assert!(
        !rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap(),
        "a second release of the same reader returns false"
    );
}

/// EXPECTED (writer self-heal via PX): the `:w` key has no lazy-purge logic — it
/// self-heals purely through Redis `PX` expiry. Once it expires, `refresh_write`
/// reports the loss and another writer can acquire. Intended.
#[tokio::test]
async fn writer_key_expires_via_px_only() {
    let (mut conn, k) = conn_and_keys("writer_key_expires_via_px_only").await;

    assert!(write_oneshot(&mut conn, &k, WRITER_A, SHORT_TTL).await);
    tokio::time::sleep(PAST_SHORT_TTL).await;

    assert!(
        !writer_exists(&mut conn, &k.writer).await,
        "PX expired the writer key"
    );
    assert!(
        !rwlock_backend::refresh_write(&mut conn, &k.writer, WRITER_A, SHORT_TTL)
            .await
            .unwrap(),
        "refresh of an expired writer reports the loss"
    );
    assert!(
        write_oneshot(&mut conn, &k, WRITER_B, SHORT_TTL).await,
        "a different writer acquires once the key has expired"
    );
}

/// EXPECTED (owner validation): an empty owner must be rejected with an error so
/// it can never become a lock holder. Asserted at the acquire entry points; fails
/// until the Rust layer validates the owner.
#[tokio::test]
async fn acquire_read_rejects_empty_owner() {
    let (mut conn, k) = conn_and_keys("acquire_read_rejects_empty_owner").await;
    assert!(
        rwlock_backend::acquire_read(&mut conn, opts(&k, "", LONG_TTL))
            .await
            .is_err(),
        "acquire_read must error for an empty owner"
    );
}

#[tokio::test]
async fn acquire_write_rejects_empty_owner() {
    let (mut conn, k) = conn_and_keys("acquire_write_rejects_empty_owner").await;
    assert!(
        rwlock_backend::acquire_write(&mut conn, opts(&k, "", LONG_TTL), true)
            .await
            .is_err(),
        "acquire_write must error for an empty owner"
    );
}

/// EXPECTED (FIFO granularity): writer FIFO is guaranteed only across distinct
/// arrival milliseconds. Within the same ms the `:pw` scores tie and the order is
/// broken lexically by owner id — same-ms ordering is not an arrival guarantee.
/// Intended; this pins the documented granularity.
#[tokio::test]
async fn same_ms_writer_fifo_is_lexical() {
    let (mut conn, k) = conn_and_keys("same_ms_writer_fifo_is_lexical").await;

    // Identical arrival score for both writers; fresh (far-future) heartbeats so
    // neither is treated as a dead waiter and purged.
    let tied_arrival = 1_000.0;
    let live_heartbeat = 1e15;
    zadd(&mut conn, &k.pending, tied_arrival, WRITER_A).await;
    zadd(&mut conn, &k.pending, tied_arrival, WRITER_B).await;
    zadd(&mut conn, &k.pending_heartbeat, live_heartbeat, WRITER_A).await;
    zadd(&mut conn, &k.pending_heartbeat, live_heartbeat, WRITER_B).await;

    // No readers, no held writer: the queue front decides.
    assert!(
        !write_waiting(&mut conn, &k, WRITER_B, LONG_TTL).await,
        "WRITER_B yields to the lexically smaller member on a same-ms tie"
    );
    assert!(
        write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "the lexically smaller member wins the same-ms tie"
    );
}

/// INVARIANT: a write stays withheld while *any* reader remains, and acquires
/// only after the last reader is released (extends `write_waits_for_readers` to
/// multiple concurrent readers).
#[tokio::test]
async fn write_held_until_all_readers_released() {
    let (mut conn, k) = conn_and_keys("write_held_until_all_readers_released").await;

    assert!(acquire_read(&mut conn, &k, READER_A, LONG_TTL).await);
    assert!(acquire_read(&mut conn, &k, READER_B, LONG_TTL).await);

    assert!(
        !write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "two readers block the write"
    );

    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_A)
            .await
            .unwrap()
    );
    assert!(
        !write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "still blocked while one reader remains"
    );

    assert!(
        rwlock_backend::release_read(&mut conn, &k.readers, READER_B)
            .await
            .unwrap()
    );
    assert!(
        write_waiting(&mut conn, &k, WRITER_A, LONG_TTL).await,
        "write acquires only once the last reader is gone"
    );
}