dist_agent_lang 1.0.20

Agentic programming with library and CLI support for Off/On-chain network integration
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
//! IDE agent runner: a first-class IDE agent that runs the DAL model-turn loop
//! with the workspace as its surface.  Spawned as `AgentType::IDE` so it
//! participates in the agent registry, uses `ResourceBudget` for guard-rails,
//! and is terminated on completion.
//!
//! Tool execution goes through the same logic as the IDE API (run_command,
//! read_file, write_file) so activity events (file_written, run_started,
//! run_stopped, agent_step) are emitted.

use crate::agent_context_schema::{AgentContextSchema, ContextBlock, ConversationTurn};
use crate::ide::run_backend;
use crate::stdlib::agent::{self, AgentConfig, AgentType, ResourceBudget};
use crate::stdlib::ai::{
    execute_fetch_url_result, generate_agent_model_turn, max_tool_steps_from_env,
    model_turn_to_outcome, run_web_search, MultiStepResult, ToolOutcome, TurnUsage,
    COMPLETION_AND_ASK_GUIDANCE, TOOLS_SYSTEM_WITH_SCRIPTING,
};
use std::path::Path;
use std::time::Instant;
use tokio::sync::broadcast;

const MAX_TOOL_RESULT_LEN: usize = 4000;

// ── Shared helpers ──────────────────────────────────────────────────

pub(crate) fn emit_activity(
    tx: &broadcast::Sender<String>,
    event_type: &str,
    payload: serde_json::Value,
) {
    let timestamp = chrono::Utc::now().to_rfc3339();
    let event = serde_json::json!({
        "type": event_type,
        "timestamp": timestamp,
        "payload": payload
    });
    let _ = serde_json::to_string(&event).map(|s| tx.send(s));
}

pub(crate) use crate::stdlib::fs::resolve_path_under_root;

fn truncate_result(s: &str) -> String {
    if s.len() <= MAX_TOOL_RESULT_LEN {
        s.to_string()
    } else {
        format!("{}\n... (truncated)", &s[..MAX_TOOL_RESULT_LEN])
    }
}

// ── Loop-local guard state ──────────────────────────────────────────
// The *limits* live on AgentConfig.resource_budget; this struct tracks
// per-invocation runtime counters.

#[derive(Debug, Clone, Default)]
struct ToolLoopState {
    tool_type_counts: std::collections::HashMap<String, u32>,
    last_tool_signature: Option<String>,
    repeated_identical_invocations: u32,
    last_result_fingerprint: Option<u64>,
    consecutive_no_progress: u32,
    total_tokens: u64,
    total_cost_microusd: u64,
}

fn env_u64(name: &str) -> Option<u64> {
    std::env::var(name)
        .ok()
        .and_then(|v| v.trim().parse::<u64>().ok())
}

fn env_u32(name: &str) -> Option<u32> {
    std::env::var(name)
        .ok()
        .and_then(|v| v.trim().parse::<u32>().ok())
}

fn env_bool(name: &str) -> Option<bool> {
    std::env::var(name).ok().map(|v| {
        let n = v.trim().to_ascii_lowercase();
        matches!(n.as_str(), "1" | "true" | "yes" | "on")
    })
}

/// Build a `ResourceBudget` from environment variables (same env vars as
/// the old `IdeGuardConfig`, now unified with the agent framework).
fn resource_budget_from_env() -> ResourceBudget {
    let strict_mode = env_bool("DAL_AGENT_GUARDS_STRICT_MODE").unwrap_or(false);
    ResourceBudget {
        max_wall_clock_ms: env_u64("DAL_AGENT_MAX_WALL_CLOCK_MS"),
        max_tool_calls_per_type: env_u32("DAL_AGENT_MAX_TOOL_CALLS_PER_TYPE")
            .or_else(|| strict_mode.then_some(8)),
        max_repeated_identical_invocations: env_u32("DAL_AGENT_MAX_REPEATED_IDENTICAL_INVOCATIONS")
            .or_else(|| strict_mode.then_some(2)),
        max_consecutive_no_progress: env_u32("DAL_AGENT_MAX_CONSECUTIVE_NO_PROGRESS")
            .or_else(|| strict_mode.then_some(1)),
        max_total_tokens: env_u64("DAL_AGENT_MAX_TOTAL_TOKENS"),
        max_cost_microusd: env_u64("DAL_AGENT_MAX_COST_MICROUSD"),
    }
}

fn fingerprint_str(s: &str) -> u64 {
    use std::hash::{Hash, Hasher};
    let mut h = std::collections::hash_map::DefaultHasher::new();
    s.hash(&mut h);
    h.finish()
}

fn apply_usage_budget(
    usage: &TurnUsage,
    budget: &ResourceBudget,
    state: &mut ToolLoopState,
) -> Option<String> {
    if let Some(tokens) = usage.total_tokens {
        state.total_tokens = state.total_tokens.saturating_add(tokens);
        if let Some(limit) = budget.max_total_tokens {
            if state.total_tokens > limit {
                return Some("max_total_tokens".to_string());
            }
        }
    }
    if let Some(cost) = usage.estimated_cost_microusd {
        state.total_cost_microusd = state.total_cost_microusd.saturating_add(cost);
        if let Some(limit) = budget.max_cost_microusd {
            if state.total_cost_microusd > limit {
                return Some("max_cost_microusd".to_string());
            }
        }
    }
    None
}

fn tool_signature(outcome: &ToolOutcome) -> Option<(String, String)> {
    match outcome {
        ToolOutcome::Run(cmd) => Some(("run".to_string(), format!("run:{}", cmd.trim()))),
        ToolOutcome::Search(query) => {
            Some(("search".to_string(), format!("search:{}", query.trim())))
        }
        ToolOutcome::FetchUrl(url) => {
            Some(("fetch_url".to_string(), format!("fetch_url:{}", url.trim())))
        }
        ToolOutcome::DalInit(template) => Some((
            "dal_init".to_string(),
            format!(
                "dal_init:{}",
                template.clone().unwrap_or_else(|| "general".to_string())
            ),
        )),
        ToolOutcome::ReadFile(path) => Some((
            "read_file".to_string(),
            format!("read_file:{}", path.trim()),
        )),
        ToolOutcome::WriteFile(path, contents) => Some((
            "write_file".to_string(),
            format!("write_file:{}:{}", path.trim(), fingerprint_str(contents)),
        )),
        ToolOutcome::ListDir(path) => {
            Some(("list_dir".to_string(), format!("list_dir:{}", path.trim())))
        }
        ToolOutcome::DalCheck(path) => Some((
            "dal_check".to_string(),
            format!("dal_check:{}", path.trim()),
        )),
        ToolOutcome::DalRun(path) => {
            Some(("dal_run".to_string(), format!("dal_run:{}", path.trim())))
        }
        ToolOutcome::ShowUrl(url) => {
            Some(("show_url".to_string(), format!("show_url:{}", url.trim())))
        }
        ToolOutcome::ShowContent(content, title) => Some((
            "show_content".to_string(),
            format!(
                "show_content:{}:{}",
                title.clone().unwrap_or_default(),
                fingerprint_str(content)
            ),
        )),
        _ => None,
    }
}

fn check_invocation_guard(
    state: &mut ToolLoopState,
    budget: &ResourceBudget,
    tool_name: &str,
    signature: &str,
) -> Option<String> {
    let count = state
        .tool_type_counts
        .entry(tool_name.to_string())
        .or_insert(0);
    *count = count.saturating_add(1);

    if let Some(limit) = budget.max_tool_calls_per_type {
        if *count > limit {
            return Some("max_tool_calls_per_type".to_string());
        }
    }

    if state.last_tool_signature.as_deref() == Some(signature) {
        state.repeated_identical_invocations =
            state.repeated_identical_invocations.saturating_add(1);
    } else {
        state.repeated_identical_invocations = 1;
    }

    if let Some(limit) = budget.max_repeated_identical_invocations {
        if state.repeated_identical_invocations > limit {
            return Some("max_repeated_identical_invocations".to_string());
        }
    }
    None
}

fn check_result_guard(
    state: &mut ToolLoopState,
    budget: &ResourceBudget,
    signature: &str,
    result: &str,
) -> Option<String> {
    let current_fingerprint = fingerprint_str(result);
    if state.last_tool_signature.as_deref() == Some(signature)
        && state.last_result_fingerprint == Some(current_fingerprint)
    {
        state.consecutive_no_progress = state.consecutive_no_progress.saturating_add(1);
    } else {
        state.consecutive_no_progress = 0;
    }
    state.last_tool_signature = Some(signature.to_string());
    state.last_result_fingerprint = Some(current_fingerprint);
    if let Some(limit) = budget.max_consecutive_no_progress {
        if state.consecutive_no_progress >= limit {
            return Some("max_consecutive_no_progress".to_string());
        }
    }
    None
}

// ── Tool execution ──────────────────────────────────────────────────
// Each function returns the tool result string (or error message).

fn exec_run(root: &Path, cmd: &str) -> String {
    let cmd = cmd.trim();
    let (cmd_str, args) = if cmd.is_empty() {
        ("true".to_string(), vec![])
    } else {
        let parts: Vec<&str> = cmd.split_whitespace().collect();
        (
            parts
                .first()
                .map(|s| (*s).to_string())
                .unwrap_or_else(|| "true".to_string()),
            parts
                .get(1..)
                .map(|s| s.iter().map(|x| (*x).to_string()).collect())
                .unwrap_or_default(),
        )
    };
    match run_backend::run_command_blocking(&cmd_str, &args, Some(root)) {
        Ok((stdout, stderr, code)) => {
            let mut out = format!("Exit code: {}\n", code);
            if !stdout.is_empty() {
                out.push_str("stdout:\n");
                out.push_str(&stdout);
            }
            if !stderr.is_empty() {
                out.push_str("\nstderr:\n");
                out.push_str(&stderr);
            }
            truncate_result(&out)
        }
        Err(e) => format!("Command failed: {}", e),
    }
}

fn exec_search(query: &str) -> String {
    let result = run_web_search(query.trim()).unwrap_or_else(|e| format!("Search failed: {}", e));
    truncate_result(&result)
}

fn exec_fetch_url(url: &str) -> String {
    truncate_result(&execute_fetch_url_result(url.trim()))
}

fn exec_read_file(root: &Path, path: &str) -> String {
    match resolve_path_under_root(root, path) {
        Err(e) => format!("read_file failed: {}", e),
        Ok(p) => {
            if !p.is_file() {
                "read_file failed: not a file".to_string()
            } else {
                let r = std::fs::read_to_string(&p)
                    .unwrap_or_else(|e| format!("read_file failed: {}", e));
                truncate_result(&r)
            }
        }
    }
}

fn exec_write_file(
    root: &Path,
    path: &str,
    contents: &str,
    files_changed: &mut Vec<String>,
    events_tx: &broadcast::Sender<String>,
) -> String {
    match resolve_path_under_root(root, path) {
        Err(e) => format!("write_file failed: {}", e),
        Ok(p) => {
            if let Some(parent) = p.parent() {
                let _ = std::fs::create_dir_all(parent);
            }
            match std::fs::write(&p, contents) {
                Ok(()) => {
                    let path_display = p.to_string_lossy().to_string();
                    if !files_changed.contains(&path_display) {
                        files_changed.push(path_display.clone());
                    }
                    emit_activity(
                        events_tx,
                        "file_written",
                        serde_json::json!({ "path": path_display }),
                    );
                    format!("Wrote {} ({} bytes).", p.display(), contents.len())
                }
                Err(e) => format!("write_file failed: {}", e),
            }
        }
    }
}

fn exec_list_dir(root: &Path, path: &str) -> String {
    match resolve_path_under_root(root, path) {
        Err(e) => format!("list_dir failed: {}", e),
        Ok(p) => {
            if !p.is_dir() {
                "list_dir failed: not a directory".to_string()
            } else {
                match std::fs::read_dir(&p) {
                    Ok(entries) => {
                        let mut names: Vec<String> = entries
                            .filter_map(|e| e.ok())
                            .map(|e| {
                                let name = e.file_name().to_string_lossy().into_owned();
                                if e.path().is_dir() {
                                    format!("{}/", name)
                                } else {
                                    name
                                }
                            })
                            .collect();
                        names.sort();
                        names.join("\n")
                    }
                    Err(e) => format!("list_dir failed: {}", e),
                }
            }
        }
    }
}

fn exec_dal_command(root: &Path, subcommand: &str, path: &str) -> String {
    match resolve_path_under_root(root, path) {
        Err(e) => format!("dal_{} failed: {}", subcommand, e),
        Ok(p) => {
            if !p.is_file() {
                return format!("dal_{} failed: path is not a file", subcommand);
            }
            let path_str = p.to_string_lossy().into_owned();
            let exe =
                run_backend::dal_binary_path().unwrap_or_else(|_| std::path::PathBuf::from("dal"));
            match run_backend::run_command_blocking(
                exe.to_string_lossy().as_ref(),
                &[subcommand.to_string(), path_str],
                Some(root),
            ) {
                Ok((stdout, stderr, code)) => {
                    let mut s = format!("Exit code: {}\n", code);
                    if !stdout.is_empty() {
                        s.push_str("stdout:\n");
                        s.push_str(&stdout);
                    }
                    if !stderr.is_empty() {
                        s.push_str("\nstderr:\n");
                        s.push_str(&stderr);
                    }
                    truncate_result(&s)
                }
                Err(e) => format!("dal {} failed: {}", subcommand, e),
            }
        }
    }
}

// ── Step recording ──────────────────────────────────────────────────
// The unified pattern: check result guard → emit agent_step → push
// conversation turns → increment step counter.

struct StepContext<'a> {
    events_tx: &'a broadcast::Sender<String>,
    job_id: &'a str,
    schema: &'a mut AgentContextSchema,
    steps_used: &'a mut u32,
    max_steps: u32,
    loop_state: &'a mut ToolLoopState,
    budget: &'a ResourceBudget,
}

/// Record a completed tool step. Returns `Some(reason)` if a guard or
/// step limit fires and the loop should break.
fn record_step(
    ctx: &mut StepContext<'_>,
    tool_name: &str,
    args_sanitized: &str,
    result: &str,
    assistant_event: &str,
    pending_signature: &Option<(String, String)>,
) -> Option<String> {
    if let Some((_, sig)) = pending_signature.as_ref() {
        if let Some(reason) = check_result_guard(ctx.loop_state, ctx.budget, sig, result) {
            return Some(reason);
        }
    }
    emit_activity(
        ctx.events_tx,
        "agent_step",
        serde_json::json!({
            "job_id": ctx.job_id,
            "step": *ctx.steps_used + 1,
            "tool": tool_name,
            "args_sanitized": args_sanitized,
            "result_summary": truncate_result(result)
        }),
    );
    ctx.schema.conversation.push(ConversationTurn {
        role: "assistant".to_string(),
        content: assistant_event.to_string(),
    });
    ctx.schema.conversation.push(ConversationTurn {
        role: "user".to_string(),
        content: format!("[Tool result]\n{}", result),
    });
    *ctx.steps_used += 1;
    if *ctx.steps_used >= ctx.max_steps {
        return Some("max_steps_reached".to_string());
    }
    None
}

fn guard_break(reason: &str) -> MultiStepResult {
    MultiStepResult {
        final_text: format!("Stopped by guard: {}.", reason),
        is_ask_user: false,
        steps_used: 0, // caller patches this
        max_steps_reached: reason == "max_steps_reached",
    }
}

// ── Main entry point ────────────────────────────────────────────────

/// Run the DAL agent loop as a first-class IDE agent.
///
/// 1. Builds an `AgentConfig` of type `IDE` with capabilities and resource
///    budget sourced from env.
/// 2. Calls `agent::spawn` to register in the global agent registry.
/// 3. Runs the model-turn loop with tool dispatch, emitting activity events.
/// 4. Terminates the agent on completion.
pub fn run_agent_prompt_sync(
    workspace_root: &Path,
    prompt: String,
    context: Option<String>,
    job_id: String,
    events_tx: broadcast::Sender<String>,
) -> Result<MultiStepResult, String> {
    // ── 1. Spawn as IDE agent ───────────────────────────────────────
    let budget = resource_budget_from_env();
    let config = AgentConfig::new(format!("ide-agent-{}", job_id), AgentType::IDE)
        .with_role("ide_tool_loop".to_string())
        .with_resource_budget(budget.clone());

    let agent_ctx =
        agent::spawn(config).map_err(|e| format!("Failed to spawn IDE agent: {}", e))?;
    let agent_id = agent_ctx.agent_id.clone();

    // ── 2. Build conversation schema ────────────────────────────────
    let mut schema = AgentContextSchema::minimal(prompt.trim(), TOOLS_SYSTEM_WITH_SCRIPTING);
    schema.completion_and_ask_guidance = Some(COMPLETION_AND_ASK_GUIDANCE.to_string());
    if let Some(ref ctx) = context {
        if !ctx.trim().is_empty() {
            schema.context_blocks.push(ContextBlock {
                source: "workspace".to_string(),
                content: ctx.clone(),
            });
        }
    }

    let root = workspace_root.to_path_buf();
    let max_steps = max_tool_steps_from_env();
    let mut steps_used: u32 = 0;
    let mut files_changed: Vec<String> = Vec::new();
    let mut loop_state = ToolLoopState::default();
    let loop_started_at = Instant::now();
    let mut termination_reason = "completed".to_string();
    let mut guard_stopped = false;

    emit_activity(
        &events_tx,
        "agent_started",
        serde_json::json!({
            "job_id": job_id,
            "agent_id": agent_id,
            "prompt": schema.objective
        }),
    );

    let include_scripting_tools = true;

    // ── 3. Model-turn loop ──────────────────────────────────────────
    let result = loop {
        // Wall-clock guard
        if let Some(limit_ms) = budget.max_wall_clock_ms {
            if loop_started_at.elapsed().as_millis() > u128::from(limit_ms) {
                termination_reason = "max_wall_clock_ms".to_string();
                guard_stopped = true;
                break Ok(MultiStepResult {
                    final_text: "Stopped: max wall-clock exceeded.".to_string(),
                    is_ask_user: false,
                    steps_used,
                    max_steps_reached: false,
                });
            }
        }

        let turn = generate_agent_model_turn(&schema, include_scripting_tools)?;

        // Token / cost guard
        if let Some(reason) = apply_usage_budget(&turn.usage, &budget, &mut loop_state) {
            termination_reason = reason.clone();
            guard_stopped = true;
            break Ok(MultiStepResult {
                final_text: format!("Stopped by guard: {}.", reason),
                is_ask_user: false,
                steps_used,
                max_steps_reached: false,
            });
        }

        let parsed = model_turn_to_outcome(&turn);
        let outcome = parsed.outcome;
        let assistant_event = parsed.assistant_event;
        let pending_signature = tool_signature(&outcome);

        // Pre-invocation guard (tool type counts, repeated calls)
        if let Some((ref tool_name, ref signature)) = pending_signature {
            if let Some(reason) =
                check_invocation_guard(&mut loop_state, &budget, tool_name, signature)
            {
                termination_reason = reason.clone();
                guard_stopped = true;
                break Ok(guard_break(&reason));
            }

            // Capability check: agent must have the tool in its capabilities
            if !agent_ctx.is_capable(tool_name) {
                let msg = format!(
                    "IDE agent lacks capability '{}'. Available: {:?}",
                    tool_name, agent_ctx.config.capabilities
                );
                log::warn!("{}", msg);
                // Feed error back to model rather than hard-stopping
                schema.conversation.push(ConversationTurn {
                    role: "assistant".to_string(),
                    content: assistant_event.clone(),
                });
                schema.conversation.push(ConversationTurn {
                    role: "user".to_string(),
                    content: format!("[Tool result]\nError: {}", msg),
                });
                steps_used += 1;
                if steps_used >= max_steps {
                    break Ok(MultiStepResult {
                        final_text: "Max tool steps reached.".to_string(),
                        is_ask_user: false,
                        steps_used,
                        max_steps_reached: true,
                    });
                }
                continue;
            }
        }

        // ── Execute tool ────────────────────────────────────────────
        let (tool_name, args_sanitized, result_str): (String, String, String) = match outcome {
            ToolOutcome::Reply(text) => {
                break Ok(MultiStepResult {
                    final_text: text,
                    is_ask_user: false,
                    steps_used,
                    max_steps_reached: false,
                });
            }
            ToolOutcome::AskUser(message) => {
                break Ok(MultiStepResult {
                    final_text: message,
                    is_ask_user: true,
                    steps_used,
                    max_steps_reached: false,
                });
            }
            ToolOutcome::ParseFail(raw) => {
                break Ok(MultiStepResult {
                    final_text: raw,
                    is_ask_user: false,
                    steps_used,
                    max_steps_reached: false,
                });
            }
            ToolOutcome::Run(cmd) => {
                let cmd_trimmed = cmd.trim().to_string();
                let run_job_id = format!("{}-run-{}", job_id, steps_used);
                emit_activity(
                    &events_tx,
                    "run_started",
                    serde_json::json!({ "job_id": run_job_id, "cmd": cmd_trimmed }),
                );
                let r = exec_run(&root, &cmd_trimmed);
                emit_activity(
                    &events_tx,
                    "run_stopped",
                    serde_json::json!({ "job_id": run_job_id }),
                );
                ("run".into(), cmd_trimmed, r)
            }
            ToolOutcome::Search(query) => {
                let q = query.trim().to_string();
                ("search".into(), q.clone(), exec_search(&q))
            }
            ToolOutcome::FetchUrl(url) => {
                let u = url.trim().to_string();
                ("fetch_url".into(), u.clone(), exec_fetch_url(&u))
            }
            ToolOutcome::ReadFile(path) => {
                let p = path.trim().to_string();
                ("read_file".into(), p.clone(), exec_read_file(&root, &p))
            }
            ToolOutcome::WriteFile(path, contents) => {
                let p = path.trim().to_string();
                let r = exec_write_file(&root, &p, &contents, &mut files_changed, &events_tx);
                ("write_file".into(), p, r)
            }
            ToolOutcome::ListDir(path) => {
                let p = path.trim().to_string();
                ("list_dir".into(), p.clone(), exec_list_dir(&root, &p))
            }
            ToolOutcome::DalCheck(path) => {
                let p = path.trim().to_string();
                (
                    "dal_check".into(),
                    p.clone(),
                    exec_dal_command(&root, "check", &p),
                )
            }
            ToolOutcome::DalRun(path) => {
                let p = path.trim().to_string();
                (
                    "dal_run".into(),
                    p.clone(),
                    exec_dal_command(&root, "run", &p),
                )
            }
            ToolOutcome::ShowUrl(url) => {
                let u = url.trim().to_string();
                emit_activity(&events_tx, "show_url", serde_json::json!({ "url": u }));
                (
                    "show_url".into(),
                    u,
                    "URL displayed in workspace.".to_string(),
                )
            }
            ToolOutcome::ShowContent(content, title) => {
                emit_activity(
                    &events_tx,
                    "show_content",
                    serde_json::json!({ "content": content, "title": title }),
                );
                let sanitized = title.as_deref().unwrap_or("(content)").to_string();
                (
                    "show_content".into(),
                    sanitized,
                    "Content displayed in workspace.".to_string(),
                )
            }
            ToolOutcome::DalInit(template) => {
                let t = template.as_deref().unwrap_or("general").to_string();
                let r = match crate::project_init::run_init(&t, &root) {
                    Ok(msg) => msg,
                    Err(e) => format!("dal_init failed: {}", e),
                };
                ("dal_init".into(), t, r)
            }
        };

        // ── Record step (guard + emit + conversation + counter) ─────
        let mut step_ctx = StepContext {
            events_tx: &events_tx,
            job_id: &job_id,
            schema: &mut schema,
            steps_used: &mut steps_used,
            max_steps,
            loop_state: &mut loop_state,
            budget: &budget,
        };
        if let Some(reason) = record_step(
            &mut step_ctx,
            &tool_name,
            &args_sanitized,
            &result_str,
            &assistant_event,
            &pending_signature,
        ) {
            termination_reason = reason.clone();
            guard_stopped = reason != "max_steps_reached";
            let mut res = guard_break(&reason);
            res.steps_used = steps_used;
            break Ok(res);
        }
    };

    // ── 4. Emit completion, terminate agent ──────────────────────────
    emit_activity(
        &events_tx,
        "agent_stopped",
        serde_json::json!({ "job_id": job_id, "agent_id": agent_id }),
    );

    if !guard_stopped {
        termination_reason = match &result {
            Ok(res) if res.max_steps_reached => "max_steps_reached".to_string(),
            Ok(res) if res.is_ask_user => "ask_user".to_string(),
            Ok(_) => "completed".to_string(),
            Err(_) => "error".to_string(),
        };
    }

    if let Ok(ref res) = result {
        emit_activity(
            &events_tx,
            "completion_summary",
            serde_json::json!({
                "job_id": job_id,
                "agent_id": agent_id,
                "summary": res.final_text,
                "steps_count": res.steps_used,
                "files_changed": files_changed,
                "termination_reason": termination_reason,
                "guard_stopped": guard_stopped,
                "usage_totals": {
                    "total_tokens": loop_state.total_tokens,
                    "estimated_cost_microusd": loop_state.total_cost_microusd
                }
            }),
        );
    }

    // Terminate the IDE agent in the registry
    if let Err(e) = agent::terminate(&agent_id) {
        log::warn!("Failed to terminate IDE agent {}: {}", agent_id, e);
    }

    result
}