dirge-agent 0.19.18

Minimalistic coding agent written in Rust, optimized for memory footprint and performance
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
//! Hardware-isolated microVM sandbox using libkrun.
//!
//! Provides a long-running VM per session that boots once and stays alive
//! for all tool calls. The VM runs a minimal Linux guest with SSH for
//! command execution and virtio-fs for workspace file access.
//!
//! # Architecture
//!
//! - **runner** — child process that calls `krun_start_enter` (blocking).
//!   The parent communicates via SSH over localhost.
//! - **rootfs** — OCI image pulled via the [`oci`] module, cached, and
//!   cloned per VM session.
//! - **oci** — pure Rust OCI puller (no buildah/skopeo needed).
//! - **ssh** — ephemeral key generation and SSH command execution.
//!
//! # Requirements
//!
//! - `/dev/kvm` accessible (user in `kvm` group)
//! - `libkrun.so` + `libkrunfw.so` installed
//! - `gzip` and `tar` on PATH (for layer extraction)

pub mod oci;
#[cfg(test)]
#[cfg(feature = "sandbox-microvm")]
mod pty_harness;
pub mod rootfs;
pub mod runner;
pub mod ssh;
#[cfg(test)]
mod tests;

use std::net::TcpListener;
use std::path::PathBuf;
use std::time::Duration;

use ssh::{EphemeralKeys, HostKeys, ssh_exec, wait_for_ssh};

/// Configuration for a microVM sandbox session.
#[derive(Debug, Clone)]
pub struct MicrovmConfig {
    /// OCI image reference (e.g. "docker.io/library/fedora:41").
    pub image: String,
    /// Host directory to mount as the VM's workspace (virtio-fs).
    pub workspace: PathBuf,
    /// Number of vCPUs.
    pub cpus: u8,
    /// RAM in MiB.
    pub memory_mib: u32,
    /// SSH port on localhost (0 = auto-pick ephemeral).
    pub ssh_port: u16,
    /// Directory to cache rootfs images.
    pub cache_dir: PathBuf,
}

impl Default for MicrovmConfig {
    fn default() -> Self {
        Self {
            image: if cfg!(target_os = "macos") {
                "local://dirge-microvm:alpine".to_string()
            } else {
                "local://dirge-microvm:debian".to_string()
            },
            workspace: std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),
            cpus: 1,
            memory_mib: 512,
            ssh_port: 0,
            cache_dir: dirs::cache_dir()
                .unwrap_or_else(|| PathBuf::from("/tmp"))
                .join("dirge")
                .join("microvm"),
        }
    }
}

impl MicrovmConfig {
    /// Directory where snapshots are stored.
    pub fn snapshots_dir(&self) -> PathBuf {
        self.cache_dir.join("snapshots")
    }

    /// Path to the cached base rootfs for the configured image.
    pub fn cached_base_path(&self) -> PathBuf {
        let image_safe = self.image.replace(['/', ':'], "_");
        self.cache_dir.join(&image_safe).join("base")
    }
}

/// A running microVM sandbox. Created by [`MicrovmSandbox::start`] and
/// cleaned up on drop.
pub struct MicrovmSandbox {
    pub(crate) config: MicrovmConfig,
    ssh_port: u16,
    child: Option<std::process::Child>,
    pub(crate) rootfs_path: Option<PathBuf>,
    pub(crate) keys: Option<EphemeralKeys>,
    pub(crate) host_keys: Option<HostKeys>,
}

impl std::fmt::Debug for MicrovmSandbox {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("MicrovmSandbox")
            .field("config", &self.config)
            .field("ssh_port", &self.ssh_port)
            .field("child_pid", &self.child.as_ref().map(|c| c.id()))
            .field("rootfs_path", &self.rootfs_path)
            .finish()
    }
}

impl MicrovmSandbox {
    /// Build a new sandbox (does NOT start the VM yet).
    pub fn new(config: MicrovmConfig) -> Self {
        Self {
            config,
            ssh_port: 0,
            child: None,
            rootfs_path: None,
            keys: None,
            host_keys: None,
        }
    }

    /// The SSH port (0 if the VM has not been started).
    pub fn ssh_port(&self) -> u16 {
        self.ssh_port
    }

    /// Start the VM: prepare rootfs, spawn runner, wait for SSH.
    pub async fn start(&mut self) -> anyhow::Result<()> {
        let rootfs = rootfs::prepare(&self.config.image, &self.config.cache_dir).await?;
        self.rootfs_path = Some(rootfs.path().to_path_buf());
        std::mem::forget(rootfs);

        let keys = EphemeralKeys::generate()?;

        // Generate host keys on the host and inject them into the rootfs.
        // Store them so ssh_exec can verify the guest's host key on every
        // connection, preventing MITM on the ephemeral localhost port.
        let host_keys = HostKeys::generate()?;

        // Inject the public key, ensure sandbox user + group exist,
        // and write .krun_config.json so libkrun's built-in init knows
        // what to execute.
        if let Some(ref rootfs_path) = self.rootfs_path {
            // Ensure sandbox user exists (OCI layer extraction order
            // can drop it if the base layer overwrites our overlay).
            let passwd_path = rootfs_path.join("etc").join("passwd");
            let passwd = std::fs::read_to_string(&passwd_path).unwrap_or_default();
            if !passwd.contains("sandbox:") {
                std::fs::write(
                    &passwd_path,
                    format!(
                        "{passwd}sandbox:x:1000:1000::/home/sandbox:/bin/sh
"
                    ),
                )?;
            }
            let group_path = rootfs_path.join("etc").join("group");
            let group = std::fs::read_to_string(&group_path).unwrap_or_default();
            if !group.contains("sandbox:") {
                std::fs::write(&group_path, format!("{group}sandbox:x:1000:\n"))?;
            }

            let ssh_dir = rootfs_path.join("home").join("sandbox").join(".ssh");
            std::fs::create_dir_all(&ssh_dir)?;
            #[cfg(unix)]
            {
                use std::os::unix::fs::PermissionsExt;
                std::fs::set_permissions(&ssh_dir, std::fs::Permissions::from_mode(0o700))?;
                // sshd requires the home directory to NOT be group-writable.
                std::fs::set_permissions(
                    rootfs_path.join("home").join("sandbox"),
                    std::fs::Permissions::from_mode(0o700),
                )?;
            }
            let auth_keys_path = ssh_dir.join("authorized_keys");
            std::fs::write(&auth_keys_path, format!("{}\n", keys.public_key))?;
            #[cfg(unix)]
            {
                use std::os::unix::fs::PermissionsExt;
                std::fs::set_permissions(&auth_keys_path, std::fs::Permissions::from_mode(0o600))?;
            }

            // Inject host keys into the rootfs. Removes stale keys from
            // the image build and writes fresh ed25519 keys generated on
            // the host.
            host_keys.inject(rootfs_path)?;
            self.host_keys = Some(host_keys);

            // libkrun reads this JSON to determine the init command.
            // The `mounts` field tells the init to mount tmpfs over
            // /var/empty before launching sshd — the rootfs is
            // host-user-owned and sshd requires root:root /var/empty.
            // Format matches libkrun init's config_parse_mounts.
            let krun_config = serde_json::json!({
                "Cmd": [
                    "/bin/sh", "-c",
                    "mount -t tmpfs tmpfs /run \
                     && mkdir -p /run/sshd \
                     && mkdir -p /workspace \
                     && mount -t virtiofs workspace /workspace \
                     && chmod 755 /var/empty \
                     && exec /usr/sbin/sshd -D -e -o StrictModes=no"
                ],
                "mounts": [
                    {"destination": "/var/empty", "type": "tmpfs", "source": "tmpfs"},
                    {"destination": "/workspace", "type": "virtiofs", "source": "workspace"}
                ],
                "Env": [],
                "WorkingDir": "/"
            });
            std::fs::write(
                rootfs_path.join(".krun_config.json"),
                serde_json::to_string_pretty(&krun_config)?,
            )?;
        }

        let port = if self.config.ssh_port == 0 {
            // Bind port 0 to let the kernel pick an ephemeral port.
            // We read the port, then drop the listener and pass the number
            // to the runner.  Another process could race and bind this port
            // between the drop and krun_set_port_map, but the window is
            // microseconds against ~28k ephemeral ports — risk is negligible.
            // If this ever matters, pass the listener fd to the runner instead.
            let listener = TcpListener::bind("127.0.0.1:0")?;
            let port = listener.local_addr()?.port();
            drop(listener);
            port
        } else {
            self.config.ssh_port
        };

        let binary = runner::find_runner_binary()?;
        #[cfg(target_os = "macos")]
        ensure_runner_signed(&binary)?;
        #[allow(unused_mut)]
        let mut config = serde_json::json!({
            "rootfs_path": self.rootfs_path.as_ref().unwrap(),
            "workspace_path": self.config.workspace,
            "ssh_port": port,
            "cpus": self.config.cpus,
            "memory_mib": self.config.memory_mib,
        });
        // On macOS, libkrun's built-in init does not parse
        // .krun_config.json, so we must pass the init command
        // directly via exec_cmd (krun_set_exec). On Linux this
        // is optional since libkrun's init handles it.
        #[cfg(target_os = "macos")]
        #[cfg(target_os = "macos")]
        {
            // Write authorized_keys inside the VM via the exec_cmd shell
            // so the file is created by root (avoids host-uid ownership issues).
            let pubkey_escaped = keys.public_key.replace("'", "'\\''");
            let cmd = format!(
                "mkdir -p /var/empty && mount -t tmpfs -o uid=0,gid=0,mode=0755 tmpfs /var/empty && mkdir -p /etc/ssh && echo '{0}' > /etc/ssh/authorized_keys && chown -R 1000:1000 /home/sandbox 2>/dev/null || true && exec /usr/sbin/sshd -D -e -o StrictModes=no -o AuthorizedKeysFile=/etc/ssh/authorized_keys",
                pubkey_escaped,
            );
            config["exec_cmd"] = serde_json::json!(["/bin/sh", "-c", cmd]);
        }
        let mut cmd = std::process::Command::new(&binary);
        cmd.arg(serde_json::to_string(&config)?);
        // On macOS, libkrun.dylib dlopens libkrunfw.5.dylib by bare
        // leaf name during krun_start_enter, but libkrun.dylib has no
        // LC_RPATH and /opt/homebrew/lib is not in dyld's default
        // search path.  Set DYLD_FALLBACK_LIBRARY_PATH so the runner
        // always finds it regardless of build-time rpath.
        // ponytail: DYLD env var (not rpath) because libkrun.dylib has
        // no LC_RPATH and dlopens libkrunfw by bare name; honored
        // only while the runner stays non-hardened (no --options
        // runtime in ensure_runner_signed).
        #[cfg(target_os = "macos")]
        {
            use std::ffi::OsStr;
            use std::path::Path;
            // Resolve brew prefix for libkrunfw (formula-specific),
            // fall back to generic brew --prefix.
            let brew_prefixes: Vec<String> = [
                std::process::Command::new("brew")
                    .args(["--prefix", "libkrunfw"])
                    .stderr(std::process::Stdio::null())
                    .output()
                    .ok()
                    .and_then(|o| {
                        if o.status.success() || !o.stdout.is_empty() {
                            Some(
                                std::str::from_utf8(&o.stdout)
                                    .unwrap_or("")
                                    .trim()
                                    .to_string(),
                            )
                        } else {
                            None
                        }
                    }),
                std::process::Command::new("brew")
                    .args(["--prefix"])
                    .output()
                    .ok()
                    .and_then(|o| {
                        let s = std::str::from_utf8(&o.stdout)
                            .unwrap_or("")
                            .trim()
                            .to_string();
                        if s.is_empty() { None } else { Some(s) }
                    }),
            ]
            .into_iter()
            .flatten()
            .filter(|p| !p.is_empty())
            .map(|p| format!("{p}/lib"))
            .collect::<Vec<_>>();

            // De-duplicate (brew --prefix and brew --prefix libkrunfw
            // may share the same prefix).
            let mut seen = std::collections::HashSet::new();
            let brew_lib_dirs: Vec<String> = brew_prefixes
                .into_iter()
                .filter(|d| seen.insert(d.clone()))
                .collect();

            // Derive the dlopen bare name libkrun uses.
            let krunfw_name = "libkrunfw.5.dylib";
            let krunfw_exists = brew_lib_dirs
                .iter()
                .any(|d| Path::new(d).join(krunfw_name).exists());
            if !krunfw_exists {
                anyhow::bail!(
                    "{krunfw_name} not found — install it: \
                     brew tap libkrun/krun && brew trust libkrun/krun && \
                     brew install libkrun libkrunfw"
                );
            }

            let dyld_val = brew_lib_dirs.join(":");
            // Preserve existing DYLD_FALLBACK_LIBRARY_PATH if set;
            // otherwise restore reasonable defaults so we don't
            // break other fallback lookups.
            let existing = std::env::var(OsStr::new("DYLD_FALLBACK_LIBRARY_PATH"))
                .ok()
                .filter(|v| !v.is_empty());
            let dyld_full = if let Some(ref existing) = existing {
                format!("{dyld_val}:{existing}")
            } else {
                format!("{dyld_val}:/usr/local/lib:/usr/lib")
            };
            cmd.env("DYLD_FALLBACK_LIBRARY_PATH", &dyld_full);
        }

        cmd.stdout(std::process::Stdio::null());
        cmd.stderr(std::process::Stdio::piped());
        let child = cmd
            .spawn()
            .map_err(|e| anyhow::anyhow!("failed to spawn dirge-microvm-runner: {e}"))?;

        // ── scheduler isolation: prevent KVM vCPU threads from ──────
        // starving dirge's input-reader thread.
        //
        // renice -n 19 — lowest CFS priority for the runner and all
        // its child threads (including KVM vCPUs). Combined with
        // setpriority(-20) in the input reader thread and
        // setpriority(-19) in the PTY relay, this gives the
        // input reader ~5900x scheduling weight over KVM threads,
        // eliminating typing stutter without root.
        // ──────────────────────────────────────────────────────────

        let _renice_status = std::process::Command::new("renice")
            .arg("-n")
            .arg("19")
            .arg("-p")
            .arg(child.id().to_string())
            .stdout(std::process::Stdio::null())
            .stderr(std::process::Stdio::null())
            .status();

        // Pin the runner to the last CPU so KVM vCPU threads
        // don't compete with dirge threads on other cores.
        let cpu_count = std::thread::available_parallelism()
            .map(|n| n.get())
            .unwrap_or(1);
        let runner_cpu = cpu_count.saturating_sub(1);
        let _taskset_status = std::process::Command::new("taskset")
            .arg("-cp")
            .arg(runner_cpu.to_string())
            .arg(child.id().to_string())
            .stdout(std::process::Stdio::null())
            .stderr(std::process::Stdio::null())
            .status();

        self.child = Some(child);
        self.ssh_port = port;
        self.keys = Some(keys);

        // spawn_blocking: wait_for_ssh is a sync loop with thread::sleep.
        // Running it directly would block the async reactor for up to 30s,
        // freezing the TUI during VM boot (first bash call).
        let wait_port = port;
        match tokio::task::spawn_blocking(move || {
            wait_for_ssh("127.0.0.1", wait_port, Duration::from_secs(30))
        })
        .await
        {
            Ok(Ok(())) => {
                // wait_for_ssh succeeded — but double-check the runner is
                // still alive before declaring the VM ready. A VM that
                // booted-then-exited can leave a port forwarder accepting
                // TCP long enough for wait_for_ssh to read an SSH banner
                // before the forwarder closes.
                if let Some(child) = self.child.as_mut() {
                    if let Ok(Some(status)) = child.try_wait() {
                        let mut stderr = String::new();
                        if let Some(ref mut pipe) = child.stderr {
                            use std::io::Read;
                            let _ = pipe.read_to_string(&mut stderr);
                        }
                        anyhow::bail!(
                            "VM exited immediately after boot: {status} — stderr: {}",
                            if stderr.is_empty() {
                                "(empty)"
                            } else {
                                &stderr
                            }
                        );
                    }
                }
            }
            Ok(Err(e)) => {
                // SSH never came up — check if the runner crashed.
                if let Some(mut child) = self.child.take() {
                    match child.try_wait() {
                        Ok(Some(status)) => {
                            let mut stderr = String::new();
                            if let Some(ref mut pipe) = child.stderr {
                                use std::io::Read;
                                let _ = pipe.read_to_string(&mut stderr);
                            }
                            let status_str = if let Some(code) = status.code() {
                                if code == 127 {
                                    format!(
                                        "{status} — the VM may be missing sshd. \
                                         Try re-running `dirge sandbox setup`"
                                    )
                                } else {
                                    status.to_string()
                                }
                            } else {
                                status.to_string()
                            };
                            anyhow::bail!(
                                "runner exited {status_str} — stderr: {}",
                                if stderr.is_empty() {
                                    "(empty)"
                                } else {
                                    &stderr
                                }
                            );
                        }
                        Ok(None) => {
                            // Still running but no SSH — kill it.
                            let _ = child.kill();
                            let _ = child.wait();
                        }
                        Err(_) => {}
                    }
                }
                return Err(e);
            }
            Err(join_err) => {
                anyhow::bail!("spawn_blocking panicked or failed: {join_err}");
            }
        }

        Ok(())
    }

    /// Execute a command inside the VM via SSH.
    #[allow(dead_code)] // used by tests; async path uses ssh_exec directly via spawn_blocking
    pub fn exec(
        &self,
        command: &str,
        _env: &[(&str, &str)],
        cwd: &str,
    ) -> anyhow::Result<(String, String, i32)> {
        let keys = self
            .keys
            .as_ref()
            .ok_or_else(|| anyhow::anyhow!("VM not started"))?;
        let host_key_bytes = self
            .host_keys
            .as_ref()
            .map(|hk| hk.public_key_bytes())
            .transpose()?;
        let command = format!("cd {} && {}", cwd, command);
        ssh_exec(
            "127.0.0.1",
            self.ssh_port,
            &keys.private_key_path,
            &command,
            host_key_bytes.as_deref(),
        )
    }

    /// Shut down the VM gracefully.
    ///
    /// Tries graceful shutdown via SSH first ("poweroff"), then escalates
    /// through SIGTERM → SIGKILL. Rootfs cleanup runs regardless.
    pub fn stop(&mut self) -> anyhow::Result<()> {
        // Compute host key bytes for verification before moving fields out.
        // If decoding fails, skip verification — shutdown is best-effort.
        let host_key_bytes = self
            .host_keys
            .as_ref()
            .and_then(|hk| hk.public_key_bytes().ok());
        if let Some(mut child) = self.child.take() {
            // 1. Fire-and-forget graceful SSH shutdown.
            if let (Some(keys), ssh_port) = (self.keys.as_ref(), self.ssh_port) {
                if ssh_port != 0 {
                    let private_key = keys.private_key_path.clone();
                    let hkb = host_key_bytes;
                    std::thread::spawn(move || {
                        let _ = ssh_exec(
                            "127.0.0.1",
                            ssh_port,
                            &private_key,
                            "poweroff",
                            hkb.as_deref(),
                        );
                    });
                    // Give the VM a moment to process the poweroff.
                    std::thread::sleep(std::time::Duration::from_secs(1));
                }
            }

            // 2. If still running, try SIGTERM via kill(1).
            if child.try_wait().ok().flatten().is_none() {
                let pid = child.id();
                let _ = std::process::Command::new("kill")
                    .arg("-TERM")
                    .arg(pid.to_string())
                    .stdout(std::process::Stdio::null())
                    .stderr(std::process::Stdio::null())
                    .status();
                // Wait up to 5 seconds.
                let start = std::time::Instant::now();
                while start.elapsed() < std::time::Duration::from_secs(5) {
                    if child.try_wait().ok().flatten().is_some() {
                        break;
                    }
                    std::thread::sleep(std::time::Duration::from_millis(100));
                }
            }

            // 3. SIGKILL as last resort.
            if child.try_wait().ok().flatten().is_none() {
                let _ = child.kill();
                let _ = child.wait();
            }
        }
        if let Some(ref path) = self.rootfs_path {
            rootfs::cleanup(path)?;
        }
        self.ssh_port = 0;
        self.keys = None;
        Ok(())
    }

    // ── snapshot management ──────────────────────────────────────

    /// Reject snapshot names that contain anything other than
    /// alphanumerics, dots, underscores, and hyphens.
    /// Also rejects "." and ".." which would resolve to directory traversal.
    pub(crate) fn validate_snapshot_name(name: &str) -> anyhow::Result<()> {
        if name.is_empty()
            || name == "."
            || name == ".."
            || !name
                .as_bytes()
                .iter()
                .all(|b| b.is_ascii_alphanumeric() || *b == b'.' || *b == b'_' || *b == b'-')
        {
            anyhow::bail!("invalid snapshot name '{name}'");
        }
        Ok(())
    }

    /// Save a copy of the VM's rootfs as a named snapshot.
    /// VM must have been started (rootfs must exist).
    pub fn save_snapshot(&self, name: &str) -> anyhow::Result<()> {
        Self::validate_snapshot_name(name)?;
        let rootfs = self
            .rootfs_path
            .as_ref()
            .ok_or_else(|| anyhow::anyhow!("VM not started — no rootfs to snapshot"))?;
        let snap_dir = self.config.snapshots_dir().join(name);
        if snap_dir.exists() {
            anyhow::bail!(
                "snapshot '{name}' already exists — delete it first or choose a different name"
            );
        }
        std::fs::create_dir_all(self.config.snapshots_dir())?;
        rootfs::cp_r(rootfs, &snap_dir)?;
        Ok(())
    }

    /// List all saved snapshot names (sorted).
    pub fn list_snapshots(&self) -> anyhow::Result<Vec<String>> {
        let snap_dir = self.config.snapshots_dir();
        if !snap_dir.exists() {
            return Ok(vec![]);
        }
        let mut names: Vec<String> = std::fs::read_dir(&snap_dir)?
            .filter_map(|e| e.ok())
            .filter(|e| e.file_type().map(|t| t.is_dir()).unwrap_or(false))
            .filter_map(|e| e.file_name().into_string().ok())
            .collect();
        names.sort();
        Ok(names)
    }

    /// Restore a snapshot to replace the cached base rootfs.
    /// The VM must be stopped; the restored rootfs takes effect on
    /// the next call to [`start`].
    pub fn restore_snapshot(&self, name: &str) -> anyhow::Result<()> {
        Self::validate_snapshot_name(name)?;
        if self.ssh_port != 0 {
            anyhow::bail!("VM is running — stop it before restoring a snapshot");
        }
        let snap_path = self.config.snapshots_dir().join(name);
        if !snap_path.exists() {
            anyhow::bail!("snapshot '{name}' does not exist");
        }
        let base = self.config.cached_base_path();
        // Remove stale cached base, then clone snapshot back.
        if base.exists() {
            std::fs::remove_dir_all(&base)?;
        }
        std::fs::create_dir_all(base.parent().unwrap())?;
        rootfs::cp_r(&snap_path, &base)?;
        Ok(())
    }

    /// Delete a saved snapshot.
    pub fn delete_snapshot(&self, name: &str) -> anyhow::Result<()> {
        Self::validate_snapshot_name(name)?;
        let snap_path = self.config.snapshots_dir().join(name);
        if !snap_path.exists() {
            anyhow::bail!("snapshot '{name}' does not exist");
        }
        std::fs::remove_dir_all(&snap_path)?;
        Ok(())
    }

    /// Stop the VM and start a fresh one.
    /// This re-clones the rootfs from the cached base so any
    /// in-VM changes are discarded.
    pub async fn reboot(&mut self) -> anyhow::Result<()> {
        self.stop()?;
        self.start().await
    }
}

impl Drop for MicrovmSandbox {
    fn drop(&mut self) {
        let _ = self.stop();
    }
}
#[cfg(target_os = "macos")]
/// Ensure the microVM runner binary is codesigned with the
/// `com.apple.security.hypervisor` entitlement.  The build script can't do
/// this reliably because it runs before the binary is compiled (cargo
/// ordering within the same package), so we sign at VM start instead.
///
/// Does NOT use `--options runtime` (hardened runtime) because that would
/// enable library validation and require `disable-library-validation` —
/// libkrun's dlopen of libkrunfw doesn't need either, and hardened runtime
/// only creates unnecessary restrictions.  Must NOT switch to hardened
/// runtime -- it would strip DYLD_FALLBACK_LIBRARY_PATH, breaking the
/// libkrunfw lookup that the runner relies on (see start()).
fn ensure_runner_signed(binary: &std::path::Path) -> anyhow::Result<()> {
    use std::process::Command;

    // Check whether the binary already has the hypervisor entitlement
    // (already signed by a previous run or the build script).
    let check = Command::new("codesign")
        .args(["-d", "--entitlements", "-"])
        .arg(binary)
        .output();
    if let Ok(ref out) = check {
        let out_str = String::from_utf8_lossy(&out.stdout);
        if out_str.contains("com.apple.security.hypervisor") {
            return Ok(());
        }
    }

    // Write entitlements to a temp file and sign.
    let tmp = std::env::temp_dir().join(format!(
        "dirge-runner-entitlements-{}.plist",
        uuid::Uuid::new_v4()
    ));
    std::fs::write(
        &tmp,
        r#"<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>com.apple.security.hypervisor</key>
    <true/>
</dict>
</plist>"#,
    )?;
    let status = Command::new("codesign")
        .args(["--force", "--sign", "-", "--entitlements"])
        .arg(&tmp)
        .arg(binary)
        .status()
        .map_err(|e| anyhow::anyhow!("failed to run codesign: {e}"))?;
    let _ = std::fs::remove_file(&tmp);
    if !status.success() {
        anyhow::bail!(
            "failed to codesign dirge-microvm-runner — Hypervisor.framework won't be available"
        );
    }
    Ok(())
}