diffguard-domain 0.2.0

Rule evaluation and preprocessing for diffguard
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
//! Property-based tests for diffguard-domain
//!
//! Feature: diffguard-completion

use proptest::prelude::*;
use std::path::Path;

use diffguard_domain::{Language, PreprocessOptions, Preprocessor, detect_language};

// Known extensions and their expected language mappings
// Based on Requirements 1.1-1.12 and actual detect_language implementation
const KNOWN_EXTENSIONS: &[(&str, &str)] = &[
    // Rust (not in task list but in implementation)
    ("rs", "rust"),
    // Python - Requirement 1.1
    ("py", "python"),
    ("pyw", "python"),
    // JavaScript - Requirements 1.2, 1.5
    ("js", "javascript"),
    ("jsx", "javascript"),
    ("mjs", "javascript"),
    ("cjs", "javascript"),
    // TypeScript - Requirements 1.3, 1.4
    ("ts", "typescript"),
    ("tsx", "typescript"),
    ("mts", "typescript"),
    ("cts", "typescript"),
    // Go - Requirement 1.6
    ("go", "go"),
    // Java - Requirement 1.7
    ("java", "java"),
    // Kotlin - Requirement 1.8
    ("kt", "kotlin"),
    ("kts", "kotlin"),
    // Ruby - Requirement 1.9
    ("rb", "ruby"),
    ("rake", "ruby"),
    // Shell - Requirement 1.13
    ("sh", "shell"),
    ("bash", "shell"),
    ("zsh", "shell"),
    ("ksh", "shell"),
    ("fish", "shell"),
    // Swift - Requirement 1.14
    ("swift", "swift"),
    // Scala - Requirement 1.15
    ("scala", "scala"),
    ("sc", "scala"),
    // SQL - Requirement 1.16
    ("sql", "sql"),
    // XML/HTML - Requirement 1.17
    ("xml", "xml"),
    ("xsl", "xml"),
    ("xslt", "xml"),
    ("xsd", "xml"),
    ("svg", "xml"),
    ("xhtml", "xml"),
    ("html", "xml"),
    ("htm", "xml"),
    // PHP - Requirement 1.18
    ("php", "php"),
    ("phtml", "php"),
    ("php3", "php"),
    ("php4", "php"),
    ("php5", "php"),
    ("php7", "php"),
    ("phps", "php"),
    // C - Requirement 1.10
    ("c", "c"),
    ("h", "c"),
    // C++ - Requirement 1.11
    ("cpp", "cpp"),
    ("cc", "cpp"),
    ("cxx", "cpp"),
    ("hpp", "cpp"),
    ("hxx", "cpp"),
    ("hh", "cpp"),
    // C# - Requirement 1.12
    ("cs", "csharp"),
];

/// Strategy to generate valid file names (alphanumeric with underscores)
fn filename_strategy() -> impl Strategy<Value = String> {
    // Generate a filename without extension (1-20 alphanumeric chars)
    prop::string::string_regex("[a-zA-Z][a-zA-Z0-9_]{0,19}").expect("valid regex")
}

/// Strategy to generate a known extension from the list
fn known_extension_strategy() -> impl Strategy<Value = (&'static str, &'static str)> {
    prop::sample::select(KNOWN_EXTENSIONS)
}

/// Strategy to generate unknown extensions
/// These are extensions NOT in the known set
fn unknown_extension_strategy() -> impl Strategy<Value = String> {
    // Generate extensions that are definitely not in our known set
    prop::string::string_regex("[a-z]{1,5}")
        .expect("valid regex")
        .prop_filter("must not be a known extension", |ext| {
            !KNOWN_EXTENSIONS.iter().any(|(known, _)| known == ext)
        })
}

/// Strategy to generate directory paths
fn directory_strategy() -> impl Strategy<Value = String> {
    prop::collection::vec(
        prop::string::string_regex("[a-zA-Z][a-zA-Z0-9_]{0,9}").expect("valid regex"),
        0..4,
    )
    .prop_map(|parts| {
        if parts.is_empty() {
            String::new()
        } else {
            parts.join("/") + "/"
        }
    })
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(100))]

    // Feature: diffguard-completion, Property 1: Language Detection Correctness
    // For any file path with a known extension (rs, py, js, ts, tsx, jsx, go, java, kt, rb, c, h, cpp, cc, cxx, hpp, cs),
    // the `detect_language` function SHALL return the correct language identifier string.
    // **Validates: Requirements 1.1-1.12**
    #[test]
    fn property_language_detection_correctness(
        dir in directory_strategy(),
        filename in filename_strategy(),
        (ext, expected_lang) in known_extension_strategy(),
    ) {
        let path_str = format!("{}{}.{}", dir, filename, ext);
        let path = Path::new(&path_str);

        let detected = detect_language(path);

        prop_assert_eq!(
            detected,
            Some(expected_lang),
            "Expected language '{}' for extension '{}' in path '{}'",
            expected_lang,
            ext,
            path_str
        );
    }

    // Feature: diffguard-completion, Property 1: Language Detection Correctness (case insensitive)
    // Extensions should be detected case-insensitively
    // **Validates: Requirements 1.1-1.12**
    #[test]
    fn property_language_detection_case_insensitive(
        dir in directory_strategy(),
        filename in filename_strategy(),
        (ext, expected_lang) in known_extension_strategy(),
        use_uppercase in prop::bool::ANY,
    ) {
        let ext_case = if use_uppercase {
            ext.to_uppercase()
        } else {
            ext.to_lowercase()
        };
        let path_str = format!("{}{}.{}", dir, filename, ext_case);
        let path = Path::new(&path_str);

        let detected = detect_language(path);

        prop_assert_eq!(
            detected,
            Some(expected_lang),
            "Expected language '{}' for extension '{}' (case: {}) in path '{}'",
            expected_lang,
            ext_case,
            if use_uppercase { "upper" } else { "lower" },
            path_str
        );
    }

    // Feature: diffguard-completion, Property 2: Unknown Extension Fallback
    // For any file path with an extension not in the known set,
    // the `detect_language` function SHALL return None.
    // **Validates: Requirements 1.13**
    #[test]
    fn property_unknown_extension_fallback(
        dir in directory_strategy(),
        filename in filename_strategy(),
        ext in unknown_extension_strategy(),
    ) {
        let path_str = format!("{}{}.{}", dir, filename, ext);
        let path = Path::new(&path_str);

        let detected = detect_language(path);

        prop_assert_eq!(
            detected,
            None,
            "Expected None for unknown extension '{}' in path '{}', but got {:?}",
            ext,
            path_str,
            detected
        );
    }

    // Feature: diffguard-completion, Property 2: Unknown Extension Fallback (no extension)
    // Files without extensions should return None
    // **Validates: Requirements 1.13**
    #[test]
    fn property_no_extension_returns_none(
        dir in directory_strategy(),
        filename in filename_strategy(),
    ) {
        let path_str = format!("{}{}", dir, filename);
        let path = Path::new(&path_str);

        let detected = detect_language(path);

        prop_assert_eq!(
            detected,
            None,
            "Expected None for file without extension '{}', but got {:?}",
            path_str,
            detected
        );
    }
}

// ==================== Property 3 & 4: Language-Aware Preprocessing ====================

/// Strategy to generate code content that doesn't contain comment starters
/// (excludes / and # to avoid accidentally creating comments in the prefix)
fn code_prefix_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_=+\\-*<>!&|()\\[\\]{},;:.@ ]{0,50}")
        .expect("valid regex")
        .prop_filter("must not end with / or contain #", |s| {
            !s.ends_with('/') && !s.contains('#') && !s.contains("/*")
        })
}

/// Strategy to generate code suffix that doesn't start with comment-related chars
fn code_suffix_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_=+\\-<>!&|()\\[\\]{},;:.@ ]{0,50}")
        .expect("valid regex")
        .prop_filter("must not start with / or *", |s| {
            !s.starts_with('/') && !s.starts_with('*')
        })
}

/// Strategy to generate hash comment content (for Python/Ruby)
fn hash_comment_content_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_ ]{0,30}").expect("valid regex")
}

/// Strategy to generate C-style line comment content
fn cstyle_comment_content_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_ ]{0,30}").expect("valid regex")
}

/// Strategy to generate string content (no quotes or backslashes to avoid escaping complexity)
fn string_content_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_ ]{0,20}").expect("valid regex")
}

/// Strategy to generate template literal content (no backticks)
fn template_literal_content_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-zA-Z0-9_ ]{0,20}").expect("valid regex")
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(100))]

    // ==================== Property 3: Comment Masking by Language ====================

    // Feature: diffguard-completion, Property 3: Comment Masking by Language
    // For any source code line containing comments in the language's comment syntax
    // (hash for Python/Ruby, C-style for others), when `ignore_comments` is enabled,
    // the preprocessor SHALL replace comment content with spaces while preserving line length.
    // **Validates: Requirements 2.1, 2.3, 2.5, 2.7, 2.8**

    #[test]
    fn property_hash_comment_masking_python(
        prefix in code_prefix_strategy(),
        comment in hash_comment_content_strategy(),
    ) {
        // Python uses hash comments
        let line = format!("{}# {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::Python,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: comment content is masked (replaced with spaces)
        // The prefix should remain, but the comment part should be spaces
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );

        // If there was comment content, it should be masked
        if !comment.is_empty() {
            let comment_part = &result[prefix.len()..];
            prop_assert!(
                comment_part.chars().all(|c| c == ' '),
                "Comment content should be masked with spaces. Got: '{}'",
                comment_part
            );
        }
    }

    #[test]
    fn property_hash_comment_masking_ruby(
        prefix in code_prefix_strategy(),
        comment in hash_comment_content_strategy(),
    ) {
        // Ruby uses hash comments
        let line = format!("{}# {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::Ruby,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
    }

    #[test]
    fn property_cstyle_line_comment_masking_javascript(
        prefix in code_prefix_strategy(),
        comment in cstyle_comment_content_strategy(),
    ) {
        // JavaScript uses C-style comments
        let line = format!("{}// {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::JavaScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );

        // Property: comment is masked
        if !comment.is_empty() {
            let comment_part = &result[prefix.len()..];
            prop_assert!(
                comment_part.chars().all(|c| c == ' '),
                "Comment content should be masked with spaces. Got: '{}'",
                comment_part
            );
        }
    }

    #[test]
    fn property_cstyle_line_comment_masking_typescript(
        prefix in code_prefix_strategy(),
        comment in cstyle_comment_content_strategy(),
    ) {
        // TypeScript uses C-style comments
        let line = format!("{}// {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::TypeScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
    }

    #[test]
    fn property_cstyle_line_comment_masking_go(
        prefix in code_prefix_strategy(),
        comment in cstyle_comment_content_strategy(),
    ) {
        // Go uses C-style comments
        let line = format!("{}// {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::Go,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
    }

    #[test]
    fn property_cstyle_block_comment_masking(
        prefix in code_prefix_strategy(),
        comment in cstyle_comment_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // Test block comments /* */ for C-style languages
        let line = format!("{}/* {} */{}", prefix, comment, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::JavaScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );

        // Property: suffix is preserved
        prop_assert!(
            result.ends_with(&suffix),
            "Suffix should be preserved. Expected suffix '{}' in '{}'",
            suffix,
            result
        );
    }

    #[test]
    fn property_unknown_language_uses_cstyle_comments(
        prefix in code_prefix_strategy(),
        comment in cstyle_comment_content_strategy(),
    ) {
        // Unknown language should fall back to C-style comments
        let line = format!("{}// {}", prefix, comment);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::Unknown,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix is preserved (C-style comment should be masked)
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
    }

    // ==================== Property 4: String Masking by Language ====================

    // Feature: diffguard-completion, Property 4: String Masking by Language
    // For any source code line containing string literals in the language's string syntax,
    // when `ignore_strings` is enabled, the preprocessor SHALL replace string content
    // with spaces while preserving line length.
    // **Validates: Requirements 2.2, 2.4, 2.6**

    #[test]
    fn property_double_quoted_string_masking(
        prefix in code_prefix_strategy(),
        content in string_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // Double-quoted strings are common across languages
        let line = format!("{}\"{}\"{}",  prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::Python,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: string content is masked but delimiters may or may not be preserved
        // The key property is that the content inside is masked
        if !content.is_empty() {
            // The string content should be replaced with spaces
            let string_start = prefix.len();
            let string_end = string_start + content.len() + 2; // +2 for quotes
            let masked_section = &result[string_start..string_end];
            prop_assert!(
                masked_section.chars().all(|c| c == ' '),
                "String content should be masked. Got: '{}'",
                masked_section
            );
        }
    }

    #[test]
    fn property_single_quoted_string_masking_python(
        prefix in code_prefix_strategy(),
        content in string_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // Python supports single-quoted strings
        let line = format!("{}'{}'{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::Python,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );
    }

    #[test]
    fn property_single_quoted_string_masking_javascript(
        prefix in code_prefix_strategy(),
        content in string_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // JavaScript supports single-quoted strings
        let line = format!("{}'{}'{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::JavaScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );
    }

    #[test]
    fn property_template_literal_masking_javascript(
        prefix in code_prefix_strategy(),
        content in template_literal_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // JavaScript template literals use backticks
        let line = format!("{}`{}`{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::JavaScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix and suffix are preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
        prop_assert!(
            result.ends_with(&suffix),
            "Suffix should be preserved. Expected suffix '{}' in '{}'",
            suffix,
            result
        );
    }

    #[test]
    fn property_template_literal_masking_typescript(
        prefix in code_prefix_strategy(),
        content in template_literal_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // TypeScript also supports template literals
        let line = format!("{}`{}`{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::TypeScript,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );
    }

    #[test]
    fn property_backtick_raw_string_masking_go(
        prefix in code_prefix_strategy(),
        content in template_literal_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // Go uses backticks for raw strings
        let line = format!("{}`{}`{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::Go,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix and suffix are preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
        prop_assert!(
            result.ends_with(&suffix),
            "Suffix should be preserved. Expected suffix '{}' in '{}'",
            suffix,
            result
        );
    }

    #[test]
    fn property_triple_quoted_string_masking_python(
        prefix in code_prefix_strategy(),
        content in string_content_strategy(), // Use simpler content without newlines for single-line test
        suffix in code_suffix_strategy(),
    ) {
        // Python triple-quoted strings (double quotes)
        let line = format!("{}\"\"\"{}\"\"\"{}",  prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::Python,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix and suffix are preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
        prop_assert!(
            result.ends_with(&suffix),
            "Suffix should be preserved. Expected suffix '{}' in '{}'",
            suffix,
            result
        );
    }

    #[test]
    fn property_triple_single_quoted_string_masking_python(
        prefix in code_prefix_strategy(),
        content in string_content_strategy(),
        suffix in code_suffix_strategy(),
    ) {
        // Python triple-quoted strings (single quotes)
        let line = format!("{}'''{}'''{}", prefix, content, suffix);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::strings_only(),
            Language::Python,
        );

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is preserved
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must be preserved. Input: '{}', Output: '{}'",
            line,
            result
        );

        // Property: prefix and suffix are preserved
        prop_assert!(
            result.starts_with(&prefix),
            "Prefix should be preserved. Expected prefix '{}' in '{}'",
            prefix,
            result
        );
        prop_assert!(
            result.ends_with(&suffix),
            "Suffix should be preserved. Expected suffix '{}' in '{}'",
            suffix,
            result
        );
    }

    // ==================== Combined Properties ====================

    #[test]
    fn property_line_length_always_preserved(
        line in prop::string::string_regex("[a-zA-Z0-9_\"'`#/ ]{0,100}").expect("valid regex"),
        mask_comments in prop::bool::ANY,
        mask_strings in prop::bool::ANY,
        lang in prop::sample::select(&[
            Language::Python,
            Language::JavaScript,
            Language::TypeScript,
            Language::Go,
            Language::Ruby,
            Language::Unknown,
        ]),
    ) {
        let opts = PreprocessOptions {
            mask_comments,
            mask_strings,
        };
        let mut preprocessor = Preprocessor::with_language(opts, lang);

        let result = preprocessor.sanitize_line(&line);

        // Property: line length is ALWAYS preserved regardless of options or language
        prop_assert_eq!(
            result.len(),
            line.len(),
            "Line length must always be preserved. Input len: {}, Output len: {}, Input: '{}', Output: '{}'",
            line.len(),
            result.len(),
            line,
            result
        );
    }

    #[test]
    fn property_no_masking_preserves_line(
        line in prop::string::string_regex("[a-zA-Z0-9_\"'`#/ ]{0,100}").expect("valid regex"),
        lang in prop::sample::select(&[
            Language::Python,
            Language::JavaScript,
            Language::TypeScript,
            Language::Go,
            Language::Ruby,
            Language::Unknown,
        ]),
    ) {
        // When no masking is enabled, the line should be unchanged
        let mut preprocessor = Preprocessor::with_language(PreprocessOptions::none(), lang);

        let result = preprocessor.sanitize_line(&line);

        // Property: with no masking, output equals input
        prop_assert_eq!(
            &result,
            &line,
            "With no masking enabled, line should be unchanged. Input: '{}', Output: '{}'",
            line,
            result
        );
    }
}

// ==================== Property 5: Built-in Rules Compile Successfully ====================

use diffguard_domain::compile_rules;
use diffguard_types::ConfigFile;

// Feature: diffguard-completion, Property 5: Built-in Rules Compile Successfully
// For all rules returned by `ConfigFile::built_in()`, the `compile_rules` function
// SHALL succeed without returning an error.
// **Validates: Requirements 3.6**
#[test]
fn property_builtin_rules_compile_successfully() {
    // Get all built-in rules
    let config = ConfigFile::built_in();

    // Verify that we have rules to test (sanity check)
    assert!(
        !config.rule.is_empty(),
        "ConfigFile::built_in() should return at least one rule"
    );

    // Attempt to compile all built-in rules
    let result = compile_rules(&config.rule);

    // Property: compile_rules SHALL succeed without returning an error
    assert!(
        result.is_ok(),
        "All built-in rules should compile successfully, but got error: {:?}",
        result.err()
    );

    // Additional verification: the number of compiled rules matches input
    let compiled_rules = result.unwrap();
    assert_eq!(
        compiled_rules.len(),
        config.rule.len(),
        "Number of compiled rules should match number of input rules"
    );

    // Verify each rule has at least one compiled pattern
    for (i, rule) in compiled_rules.iter().enumerate() {
        assert!(
            !rule.patterns.is_empty(),
            "Compiled rule {} ('{}') should have at least one pattern",
            i,
            rule.id
        );
    }
}

// Feature: diffguard-completion, Property 5: Built-in Rules Compile Successfully
// Additional test: verify each built-in rule individually to provide better error messages
// **Validates: Requirements 3.6**
#[test]
fn property_each_builtin_rule_compiles_individually() {
    let config = ConfigFile::built_in();

    for rule_config in &config.rule {
        // Compile each rule individually
        let result = compile_rules(std::slice::from_ref(rule_config));

        assert!(
            result.is_ok(),
            "Built-in rule '{}' should compile successfully, but got error: {:?}",
            rule_config.id,
            result.err()
        );

        let compiled = result.unwrap();
        assert_eq!(compiled.len(), 1, "Should compile exactly one rule");

        let compiled_rule = &compiled[0];

        // Verify the compiled rule has the expected properties
        assert_eq!(
            compiled_rule.id, rule_config.id,
            "Compiled rule ID should match config"
        );
        assert_eq!(
            compiled_rule.patterns.len(),
            rule_config.patterns.len(),
            "Rule '{}': number of compiled patterns should match config",
            rule_config.id
        );
    }
}

// ==================== Property 10: Error Messages Contain Context ====================

use diffguard_domain::RuleCompileError;
use diffguard_types::{RuleConfig, Severity};

/// Strategy to generate valid rule IDs (alphanumeric with dots and underscores)
fn rule_id_strategy() -> impl Strategy<Value = String> {
    prop::string::string_regex("[a-z][a-z0-9_.]{0,29}")
        .expect("valid regex")
        .prop_filter("must not be empty", |s| !s.is_empty())
}

/// Strategy to generate invalid regex patterns
/// These patterns will fail to compile due to regex syntax errors
fn invalid_regex_strategy() -> impl Strategy<Value = String> {
    prop::sample::select(&[
        // Unclosed groups
        "(unclosed",
        "[unclosed",
        // Invalid quantifiers
        "*invalid",
        "+invalid",
        "?invalid",
        // Invalid escape sequences
        "\\",
        // Unclosed repetition
        "a{",
        "a{1,",
        // Invalid character class
        "[z-a]",
        // Unmatched parentheses
        "(((",
        ")))",
        // Invalid backreference
        "\\99999",
    ])
    .prop_map(|s| s.to_string())
}

/// Strategy to generate invalid glob patterns
/// These patterns will fail to compile due to glob syntax errors
fn invalid_glob_strategy() -> impl Strategy<Value = String> {
    prop::sample::select(&[
        // Unclosed brackets - definitely invalid
        "[unclosed",
        // Unclosed braces - definitely invalid
        "{unclosed",
        // Nested unclosed brackets - definitely invalid
        "[[invalid",
        // Another unclosed bracket variant
        "test[abc",
        // Unclosed brace with content
        "{a,b,c",
    ])
    .prop_map(|s| s.to_string())
}

/// Strategy to generate valid regex patterns (for use in rules that test other errors)
fn valid_regex_strategy() -> impl Strategy<Value = String> {
    prop::sample::select(&[
        "simple",
        "word\\b",
        "[a-z]+",
        "\\d+",
        "foo|bar",
        "test.*pattern",
    ])
    .prop_map(|s| s.to_string())
}

/// Helper to create a basic rule config with given ID and patterns
fn make_rule_config(id: &str, patterns: Vec<String>) -> RuleConfig {
    RuleConfig {
        id: id.to_string(),
        severity: Severity::Warn,
        message: "Test message".to_string(),
        languages: vec![],
        patterns,
        paths: vec![],
        exclude_paths: vec![],
        ignore_comments: false,
        ignore_strings: false,
        match_mode: Default::default(),
        multiline: false,
        multiline_window: None,
        context_patterns: vec![],
        context_window: None,
        escalate_patterns: vec![],
        escalate_window: None,
        escalate_to: None,
        depends_on: vec![],
        help: None,
        url: None,
        tags: vec![],
        test_cases: vec![],
    }
}

/// Helper to create a rule config with paths
fn make_rule_config_with_paths(id: &str, patterns: Vec<String>, paths: Vec<String>) -> RuleConfig {
    RuleConfig {
        id: id.to_string(),
        severity: Severity::Warn,
        message: "Test message".to_string(),
        languages: vec![],
        patterns,
        paths,
        exclude_paths: vec![],
        ignore_comments: false,
        ignore_strings: false,
        match_mode: Default::default(),
        multiline: false,
        multiline_window: None,
        context_patterns: vec![],
        context_window: None,
        escalate_patterns: vec![],
        escalate_window: None,
        escalate_to: None,
        depends_on: vec![],
        help: None,
        url: None,
        tags: vec![],
        test_cases: vec![],
    }
}

/// Helper to create a rule config with exclude paths
fn make_rule_config_with_exclude_paths(
    id: &str,
    patterns: Vec<String>,
    exclude_paths: Vec<String>,
) -> RuleConfig {
    RuleConfig {
        id: id.to_string(),
        severity: Severity::Warn,
        message: "Test message".to_string(),
        languages: vec![],
        patterns,
        paths: vec![],
        exclude_paths,
        ignore_comments: false,
        ignore_strings: false,
        match_mode: Default::default(),
        multiline: false,
        multiline_window: None,
        context_patterns: vec![],
        context_window: None,
        escalate_patterns: vec![],
        escalate_window: None,
        escalate_to: None,
        depends_on: vec![],
        help: None,
        url: None,
        tags: vec![],
        test_cases: vec![],
    }
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(100))]

    // Feature: diffguard-completion, Property 10: Error Messages Contain Context
    // For any invalid rule configuration (invalid regex, invalid glob, or missing patterns),
    // the error returned by `compile_rules` SHALL contain the rule ID and the specific invalid element.
    // **Validates: Requirements 6.1, 6.2, 6.3**

    // Test: Invalid regex returns error with rule_id and pattern
    // **Validates: Requirement 6.1**
    #[test]
    fn property_invalid_regex_error_contains_rule_id_and_pattern(
        rule_id in rule_id_strategy(),
        invalid_pattern in invalid_regex_strategy(),
    ) {
        let config = make_rule_config(&rule_id, vec![invalid_pattern.clone()]);
        let result = compile_rules(&[config]);

        // Property: compile_rules SHALL return an error for invalid regex
        prop_assert!(
            result.is_err(),
            "compile_rules should fail for invalid regex pattern '{}' in rule '{}'",
            invalid_pattern,
            rule_id
        );

        let error = result.unwrap_err();

        // Property: error SHALL be InvalidRegex variant
        match &error {
            RuleCompileError::InvalidRegex {
                rule_id: err_rule_id,
                pattern: err_pattern,
                source: _,
            } => {
                // Property: error SHALL contain the rule ID
                prop_assert_eq!(
                    err_rule_id,
                    &rule_id,
                    "Error should contain the rule ID. Expected '{}', got '{}'",
                    rule_id,
                    err_rule_id
                );

                // Property: error SHALL contain the invalid pattern
                prop_assert_eq!(
                    err_pattern,
                    &invalid_pattern,
                    "Error should contain the invalid pattern. Expected '{}', got '{}'",
                    invalid_pattern,
                    err_pattern
                );

                // Property: error message (Display) SHALL contain rule_id and pattern
                let error_msg = error.to_string();
                prop_assert!(
                    error_msg.contains(&rule_id),
                    "Error message should contain rule ID '{}'. Got: '{}'",
                    rule_id,
                    error_msg
                );
                prop_assert!(
                    error_msg.contains(&invalid_pattern),
                    "Error message should contain invalid pattern '{}'. Got: '{}'",
                    invalid_pattern,
                    error_msg
                );
            }
            other => {
                prop_assert!(
                    false,
                    "Expected InvalidRegex error, got {:?}",
                    other
                );
            }
        }
    }

    // Test: Invalid glob in paths returns error with rule_id and glob
    // **Validates: Requirement 6.2**
    #[test]
    fn property_invalid_glob_in_paths_error_contains_rule_id_and_glob(
        rule_id in rule_id_strategy(),
        valid_pattern in valid_regex_strategy(),
        invalid_glob in invalid_glob_strategy(),
    ) {
        let config = make_rule_config_with_paths(
            &rule_id,
            vec![valid_pattern],
            vec![invalid_glob.clone()],
        );
        let result = compile_rules(&[config]);

        // Property: compile_rules SHALL return an error for invalid glob
        prop_assert!(
            result.is_err(),
            "compile_rules should fail for invalid glob '{}' in rule '{}'",
            invalid_glob,
            rule_id
        );

        let error = result.unwrap_err();

        // Property: error SHALL be InvalidGlob variant
        match &error {
            RuleCompileError::InvalidGlob {
                rule_id: err_rule_id,
                glob: err_glob,
                source: _,
            } => {
                // Property: error SHALL contain the rule ID
                prop_assert_eq!(
                    err_rule_id,
                    &rule_id,
                    "Error should contain the rule ID. Expected '{}', got '{}'",
                    rule_id,
                    err_rule_id
                );

                // Property: error SHALL contain the invalid glob
                prop_assert_eq!(
                    err_glob,
                    &invalid_glob,
                    "Error should contain the invalid glob. Expected '{}', got '{}'",
                    invalid_glob,
                    err_glob
                );

                // Property: error message (Display) SHALL contain rule_id and glob
                let error_msg = error.to_string();
                prop_assert!(
                    error_msg.contains(&rule_id),
                    "Error message should contain rule ID '{}'. Got: '{}'",
                    rule_id,
                    error_msg
                );
                prop_assert!(
                    error_msg.contains(&invalid_glob),
                    "Error message should contain invalid glob '{}'. Got: '{}'",
                    invalid_glob,
                    error_msg
                );
            }
            other => {
                prop_assert!(
                    false,
                    "Expected InvalidGlob error, got {:?}",
                    other
                );
            }
        }
    }

    // Test: Invalid glob in exclude_paths returns error with rule_id and glob
    // **Validates: Requirement 6.2**
    #[test]
    fn property_invalid_glob_in_exclude_paths_error_contains_rule_id_and_glob(
        rule_id in rule_id_strategy(),
        valid_pattern in valid_regex_strategy(),
        invalid_glob in invalid_glob_strategy(),
    ) {
        let config = make_rule_config_with_exclude_paths(
            &rule_id,
            vec![valid_pattern],
            vec![invalid_glob.clone()],
        );
        let result = compile_rules(&[config]);

        // Property: compile_rules SHALL return an error for invalid glob in exclude_paths
        prop_assert!(
            result.is_err(),
            "compile_rules should fail for invalid glob '{}' in exclude_paths of rule '{}'",
            invalid_glob,
            rule_id
        );

        let error = result.unwrap_err();

        // Property: error SHALL be InvalidGlob variant
        match &error {
            RuleCompileError::InvalidGlob {
                rule_id: err_rule_id,
                glob: err_glob,
                source: _,
            } => {
                // Property: error SHALL contain the rule ID
                prop_assert_eq!(
                    err_rule_id,
                    &rule_id,
                    "Error should contain the rule ID. Expected '{}', got '{}'",
                    rule_id,
                    err_rule_id
                );

                // Property: error SHALL contain the invalid glob
                prop_assert_eq!(
                    err_glob,
                    &invalid_glob,
                    "Error should contain the invalid glob. Expected '{}', got '{}'",
                    invalid_glob,
                    err_glob
                );

                // Property: error message (Display) SHALL contain rule_id and glob
                let error_msg = error.to_string();
                prop_assert!(
                    error_msg.contains(&rule_id),
                    "Error message should contain rule ID '{}'. Got: '{}'",
                    rule_id,
                    error_msg
                );
                prop_assert!(
                    error_msg.contains(&invalid_glob),
                    "Error message should contain invalid glob '{}'. Got: '{}'",
                    invalid_glob,
                    error_msg
                );
            }
            other => {
                prop_assert!(
                    false,
                    "Expected InvalidGlob error, got {:?}",
                    other
                );
            }
        }
    }

    // Test: Missing patterns returns error with rule_id
    // **Validates: Requirement 6.3**
    #[test]
    fn property_missing_patterns_error_contains_rule_id(
        rule_id in rule_id_strategy(),
    ) {
        // Create a rule with empty patterns
        let config = make_rule_config(&rule_id, vec![]);
        let result = compile_rules(&[config]);

        // Property: compile_rules SHALL return an error for missing patterns
        prop_assert!(
            result.is_err(),
            "compile_rules should fail for rule '{}' with no patterns",
            rule_id
        );

        let error = result.unwrap_err();

        // Property: error SHALL be MissingPatterns variant
        match &error {
            RuleCompileError::MissingPatterns {
                rule_id: err_rule_id,
            } => {
                // Property: error SHALL contain the rule ID
                prop_assert_eq!(
                    err_rule_id,
                    &rule_id,
                    "Error should contain the rule ID. Expected '{}', got '{}'",
                    rule_id,
                    err_rule_id
                );

                // Property: error message (Display) SHALL contain rule_id
                let error_msg = error.to_string();
                prop_assert!(
                    error_msg.contains(&rule_id),
                    "Error message should contain rule ID '{}'. Got: '{}'",
                    rule_id,
                    error_msg
                );
            }
            other => {
                prop_assert!(
                    false,
                    "Expected MissingPatterns error, got {:?}",
                    other
                );
            }
        }
    }
}

// Feature: diffguard-completion, Property 10: Error Messages Contain Context
// Additional unit tests for specific error message format verification
// **Validates: Requirements 6.1, 6.2, 6.3**

#[test]
fn test_invalid_regex_error_message_format() {
    // Test that the error message follows the expected format:
    // "rule '{rule_id}' has invalid regex '{pattern}': {source}"
    let rule_id = "test.rule";
    let invalid_pattern = "(unclosed";
    let config = make_rule_config(rule_id, vec![invalid_pattern.to_string()]);

    let result = compile_rules(&[config]);
    assert!(result.is_err());

    let error = result.unwrap_err();
    let error_msg = error.to_string();

    // Verify message format
    assert!(
        error_msg.starts_with(&format!(
            "rule '{}' has invalid regex '{}'",
            rule_id, invalid_pattern
        )),
        "Error message should follow format. Got: '{}'",
        error_msg
    );
}

#[test]
fn test_invalid_glob_error_message_format() {
    // Test that the error message follows the expected format:
    // "rule '{rule_id}' has invalid glob '{glob}': {source}"
    let rule_id = "test.rule";
    let invalid_glob = "[unclosed";
    let config = make_rule_config_with_paths(
        rule_id,
        vec!["valid".to_string()],
        vec![invalid_glob.to_string()],
    );

    let result = compile_rules(&[config]);
    assert!(result.is_err());

    let error = result.unwrap_err();
    let error_msg = error.to_string();

    // Verify message format
    assert!(
        error_msg.starts_with(&format!(
            "rule '{}' has invalid glob '{}'",
            rule_id, invalid_glob
        )),
        "Error message should follow format. Got: '{}'",
        error_msg
    );
}

#[test]
fn test_missing_patterns_error_message_format() {
    // Test that the error message follows the expected format:
    // "rule '{rule_id}' has no patterns"
    let rule_id = "test.rule";
    let config = make_rule_config(rule_id, vec![]);

    let result = compile_rules(&[config]);
    assert!(result.is_err());

    let error = result.unwrap_err();
    let error_msg = error.to_string();

    // Verify exact message format
    assert_eq!(
        error_msg,
        format!("rule '{}' has no patterns", rule_id),
        "Error message should match expected format"
    );
}

// ==================== Property: Evaluation Determinism ====================

use diffguard_domain::{InputLine, evaluate_lines};

/// Strategy to generate valid input lines for evaluation
fn input_line_strategy() -> impl Strategy<Value = InputLine> {
    (
        prop::string::string_regex("[a-zA-Z_][a-zA-Z0-9_/]{0,30}\\.[a-z]{1,4}")
            .expect("valid regex"),
        1u32..1000,
        prop::string::string_regex("[a-zA-Z0-9_ .(){}\\[\\];:,<>=+\\-*/&|!\"'#@$%^~`\\\\]{0,100}")
            .expect("valid regex"),
    )
        .prop_map(|(path, line, content)| InputLine {
            path,
            line,
            content,
        })
}

/// Strategy to generate valid rule configs that will compile successfully
fn valid_rule_config_strategy() -> impl Strategy<Value = RuleConfig> {
    (
        rule_id_strategy(),
        prop::sample::select(&[Severity::Info, Severity::Warn, Severity::Error]),
        prop::string::string_regex("[a-zA-Z ]{1,50}").expect("valid regex"),
        // Use simple, valid regex patterns
        prop::collection::vec(
            prop::sample::select(&["test", "foo", "bar", "\\w+", "[a-z]+", "hello"]),
            1..3,
        ),
    )
        .prop_map(|(id, severity, message, patterns)| RuleConfig {
            id,
            severity,
            message,
            languages: vec![],
            patterns: patterns.into_iter().map(|s| s.to_string()).collect(),
            paths: vec![],
            exclude_paths: vec![],
            ignore_comments: false,
            ignore_strings: false,
            match_mode: Default::default(),
            multiline: false,
            multiline_window: None,
            context_patterns: vec![],
            context_window: None,
            escalate_patterns: vec![],
            escalate_window: None,
            escalate_to: None,
            depends_on: vec![],
            help: None,
            url: None,
            tags: vec![],
            test_cases: vec![],
        })
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(50))]

    // Feature: comprehensive-test-coverage, Property: Evaluation Determinism
    // For any given input (lines + rules), calling evaluate_lines twice
    // SHALL produce identical results.
    // **Validates: Requirements 7.1**
    #[test]
    fn property_evaluation_determinism(
        lines in prop::collection::vec(input_line_strategy(), 1..10),
        rule_config in valid_rule_config_strategy(),
    ) {
        // Compile the rule
        let compiled = compile_rules(&[rule_config]);
        prop_assume!(compiled.is_ok());
        let rules = compiled.unwrap();

        // Evaluate twice with the same input
        let result1 = evaluate_lines(lines.clone(), &rules, 100);
        let result2 = evaluate_lines(lines, &rules, 100);

        // Property: Both evaluations should produce identical results
        prop_assert_eq!(
            result1.findings.len(),
            result2.findings.len(),
            "Findings count should be identical"
        );
        prop_assert_eq!(
            result1.counts,
            result2.counts,
            "Verdict counts should be identical"
        );
        prop_assert_eq!(
            result1.files_scanned,
            result2.files_scanned,
            "Files scanned should be identical"
        );
        prop_assert_eq!(
            result1.lines_scanned,
            result2.lines_scanned,
            "Lines scanned should be identical"
        );

        // Compare each finding
        for (f1, f2) in result1.findings.iter().zip(result2.findings.iter()) {
            prop_assert_eq!(&f1.rule_id, &f2.rule_id, "Rule IDs should match");
            prop_assert_eq!(f1.severity, f2.severity, "Severities should match");
            prop_assert_eq!(&f1.path, &f2.path, "Paths should match");
            prop_assert_eq!(f1.line, f2.line, "Line numbers should match");
        }
    }

    // Feature: comprehensive-test-coverage, Property: Valid Configs Always Compile
    // For any RuleConfig with valid regex patterns and globs,
    // compile_rules SHALL succeed.
    // **Validates: Requirements 7.2**
    #[test]
    fn property_valid_configs_compile(
        rule_config in valid_rule_config_strategy(),
    ) {
        let result = compile_rules(&[rule_config]);
        prop_assert!(
            result.is_ok(),
            "Valid rule configs should always compile, but got error: {:?}",
            result.err()
        );
    }

    // Feature: comprehensive-test-coverage, Property: Counts Match Findings
    // The verdict counts SHALL always match the actual severity distribution
    // of the findings.
    // **Validates: Requirements 7.3**
    #[test]
    fn property_counts_match_findings(
        lines in prop::collection::vec(input_line_strategy(), 1..20),
        rule_config in valid_rule_config_strategy(),
    ) {
        let compiled = compile_rules(&[rule_config]);
        prop_assume!(compiled.is_ok());
        let rules = compiled.unwrap();

        let result = evaluate_lines(lines, &rules, 1000);

        // Add truncated findings to the counts (they were counted but not stored)
        // Note: truncated_findings are not broken down by severity,
        // so we check that counts >= findings counts
        let total_counted = result.counts.info + result.counts.warn + result.counts.error;
        let total_findings = result.findings.len() as u32 + result.truncated_findings;

        prop_assert_eq!(
            total_counted,
            total_findings,
            "Total counts ({}) should equal findings ({}) + truncated ({})",
            total_counted,
            result.findings.len(),
            result.truncated_findings
        );
    }

    // Feature: comprehensive-test-coverage, Property: Max Findings Respected
    // The number of stored findings SHALL never exceed max_findings.
    // **Validates: Requirements 7.4**
    #[test]
    fn property_max_findings_respected(
        lines in prop::collection::vec(input_line_strategy(), 10..50),
        max_findings in 1usize..20,
    ) {
        // Create a rule that matches many things
        let rule = RuleConfig {
            id: "test.any".to_string(),
            severity: Severity::Warn,
            message: "matched".to_string(),
            languages: vec![],
            patterns: vec![".*".to_string()], // Match everything
            paths: vec![],
            exclude_paths: vec![],
            ignore_comments: false,
            ignore_strings: false,
            match_mode: Default::default(),
            multiline: false,
            multiline_window: None,
            context_patterns: vec![],
            context_window: None,
            escalate_patterns: vec![],
            escalate_window: None,
            escalate_to: None,
            depends_on: vec![],
            help: None,
            url: None,
            tags: vec![],
            test_cases: vec![],
        };

        let compiled = compile_rules(&[rule]).expect("rule should compile");
        let result = evaluate_lines(lines, &compiled, max_findings);

        // Property: findings.len() <= max_findings
        prop_assert!(
            result.findings.len() <= max_findings,
            "Findings count ({}) should not exceed max_findings ({})",
            result.findings.len(),
            max_findings
        );
    }

    // Feature: comprehensive-test-coverage, Property: Lines Scanned Equals Input
    // lines_scanned SHALL equal the number of input lines.
    // **Validates: Requirements 7.5**
    #[test]
    fn property_lines_scanned_equals_input(
        lines in prop::collection::vec(input_line_strategy(), 1..50),
    ) {
        let rules = vec![]; // No rules - just counting
        let result = evaluate_lines(lines.clone(), &rules, 100);

        prop_assert_eq!(
            result.lines_scanned as usize,
            lines.len(),
            "lines_scanned ({}) should equal input lines count ({})",
            result.lines_scanned,
            lines.len()
        );
    }
}

// ==================== Property: Preprocessing Length Preservation ====================

proptest! {
    #![proptest_config(ProptestConfig::with_cases(100))]

    // Feature: comprehensive-test-coverage, Property: Preprocessing Length Preservation
    // For any valid UTF-8 input, the preprocessor output length SHALL equal
    // the input length.
    // **Validates: Requirements 8.1**
    #[test]
    fn property_preprocessing_preserves_length_all_languages(
        line in prop::string::string_regex("[a-zA-Z0-9_\"'`#/ ]{0,100}").expect("valid regex"),
        lang in prop::sample::select(&[
            Language::Rust,
            Language::Python,
            Language::JavaScript,
            Language::TypeScript,
            Language::Go,
            Language::Ruby,
            Language::C,
            Language::Cpp,
            Language::CSharp,
            Language::Java,
            Language::Kotlin,
            Language::Unknown,
        ]),
        mask_comments in prop::bool::ANY,
        mask_strings in prop::bool::ANY,
    ) {
        let opts = PreprocessOptions {
            mask_comments,
            mask_strings,
        };
        let mut preprocessor = Preprocessor::with_language(opts, lang);
        let result = preprocessor.sanitize_line(&line);

        prop_assert_eq!(
            result.len(),
            line.len(),
            "Output length ({}) should equal input length ({}) for language {:?}",
            result.len(),
            line.len(),
            lang
        );
    }

    // Feature: comprehensive-test-coverage, Property: Preprocessing Stability
    // Preprocessing with no options enabled SHALL return the original line unchanged.
    // **Validates: Requirements 8.2**
    #[test]
    fn property_no_masking_returns_unchanged(
        line in prop::string::string_regex("[a-zA-Z0-9_\"'`#/ ]{0,100}").expect("valid regex"),
        lang in prop::sample::select(&[
            Language::Rust,
            Language::Python,
            Language::JavaScript,
            Language::TypeScript,
            Language::Go,
            Language::Ruby,
            Language::Unknown,
        ]),
    ) {
        let mut preprocessor = Preprocessor::with_language(PreprocessOptions::none(), lang);
        let result = preprocessor.sanitize_line(&line);

        prop_assert_eq!(
            &result,
            &line,
            "With no masking, output should equal input"
        );
    }

    // Feature: comprehensive-test-coverage, Property: Preprocessing Idempotence (Comments)
    // Applying comment masking twice to a line that contains only comments
    // SHALL produce the same result (all spaces).
    // **Validates: Requirements 8.3**
    #[test]
    fn property_comment_masking_idempotent(
        comment_content in prop::string::string_regex("[a-zA-Z0-9_ ]{0,50}").expect("valid regex"),
    ) {
        // Create a line that is entirely a comment
        let line = format!("// {}", comment_content);
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_only(),
            Language::Rust,
        );

        let result1 = preprocessor.sanitize_line(&line);
        preprocessor.reset();
        let result2 = preprocessor.sanitize_line(&result1);

        // After first pass, line should be all spaces (comment masked)
        // After second pass, result should be unchanged (already all spaces)
        prop_assert_eq!(
            &result1,
            &result2,
            "Comment masking should be idempotent"
        );
    }

    // Feature: comprehensive-test-coverage, Property: Preprocessing Consistency Across Resets
    // After reset(), preprocessing the same line should produce the same result.
    // **Validates: Requirements 8.4**
    #[test]
    fn property_reset_produces_consistent_results(
        line in prop::string::string_regex("[a-zA-Z0-9_\"'`#/ ]{0,100}").expect("valid regex"),
        lang in prop::sample::select(&[
            Language::Python,
            Language::JavaScript,
            Language::Go,
        ]),
    ) {
        let mut preprocessor = Preprocessor::with_language(
            PreprocessOptions::comments_and_strings(),
            lang,
        );

        let result1 = preprocessor.sanitize_line(&line);
        preprocessor.reset();
        let result2 = preprocessor.sanitize_line(&line);

        prop_assert_eq!(
            &result1,
            &result2,
            "After reset, same line should produce same result"
        );
    }
}

// ==================== Property: Rule Application Correctness ====================

/// Strategy for generating valid include/exclude glob patterns.
fn applicability_glob_strategy() -> impl Strategy<Value = String> {
    prop::sample::select(vec![
        "**/*.rs",
        "**/*.py",
        "**/*.js",
        "src/**/*.rs",
        "src/**",
        "tests/**/*.rs",
        "**/tests/**",
        "**/examples/**",
        "**/*.test.*",
        "**/*.spec.*",
    ])
    .prop_map(|s| s.to_string())
}

/// Strategy for generating language identifiers (mixed case).
fn applicability_language_strategy() -> impl Strategy<Value = String> {
    prop::sample::select(vec![
        "rust",
        "RUST",
        "python",
        "PYTHON",
        "javascript",
        "JavaScript",
        "typescript",
        "TypeScript",
        "go",
        "GO",
    ])
    .prop_map(|s| s.to_string())
}

/// Strategy for generating file paths that may match include/exclude globs.
fn applicability_path_strategy() -> impl Strategy<Value = String> {
    (
        prop::collection::vec(
            prop::sample::select(vec!["src", "tests", "examples", "lib", "app", "utils"]),
            1..4,
        ),
        prop::sample::select(vec!["rs", "py", "js", "ts", "txt"]),
    )
        .prop_map(|(dirs, ext)| format!("{}/file.{}", dirs.join("/"), ext))
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(100))]

    // Feature: comprehensive-test-coverage, Property: Rule Applicability Filtering
    // CompiledRule::applies_to should match include/exclude/language logic.
    // **Validates: Requirements 3.2, 3.3**
    #[test]
    fn property_rule_applicability_filters(
        paths in prop::collection::vec(applicability_glob_strategy(), 0..3),
        exclude_paths in prop::collection::vec(applicability_glob_strategy(), 0..3),
        languages in prop::collection::vec(applicability_language_strategy(), 0..3),
        file_path in applicability_path_strategy(),
        language in prop_oneof![Just(None), applicability_language_strategy().prop_map(Some)],
    ) {
        let config = RuleConfig {
            id: "test.rule".to_string(),
            severity: Severity::Warn,
            message: "test".to_string(),
            languages: languages.clone(),
            patterns: vec!["test".to_string()],
            paths: paths.clone(),
            exclude_paths: exclude_paths.clone(),
            ignore_comments: false,
            ignore_strings: false,
            match_mode: Default::default(),
            multiline: false,
            multiline_window: None,
            context_patterns: vec![],
            context_window: None,
            escalate_patterns: vec![],
            escalate_window: None,
            escalate_to: None,
            depends_on: vec![],
            help: None,
            url: None,
            tags: vec![],
            test_cases: vec![],
        };

        let compiled = compile_rules(&[config]).expect("rule should compile");
        let rule = &compiled[0];

        let path = Path::new(&file_path);

        let include_match = match &rule.include {
            Some(include) => include.is_match(path),
            None => true,
        };

        let exclude_match = match &rule.exclude {
            Some(exclude) => exclude.is_match(path),
            None => false,
        };

        let lang_match = if rule.languages.is_empty() {
            true
        } else {
            match &language {
                Some(lang) => rule.languages.contains(&lang.to_ascii_lowercase()),
                None => false,
            }
        };

        let expected = include_match && !exclude_match && lang_match;
        let actual = rule.applies_to(path, language.as_deref());

        prop_assert_eq!(
            actual,
            expected,
            "applies_to mismatch for path '{}' lang {:?} include {:?} exclude {:?} languages {:?}",
            file_path,
            language,
            paths,
            exclude_paths,
            languages
        );
    }
}

proptest! {
    #![proptest_config(ProptestConfig::with_cases(50))]

    // Feature: comprehensive-test-coverage, Property: Empty Rules Produce No Findings
    // With no rules, evaluate_lines SHALL produce no findings.
    // **Validates: Requirements 9.1**
    #[test]
    fn property_no_rules_no_findings(
        lines in prop::collection::vec(input_line_strategy(), 1..20),
    ) {
        let rules: Vec<diffguard_domain::CompiledRule> = vec![];
        let result = evaluate_lines(lines, &rules, 100);

        prop_assert!(
            result.findings.is_empty(),
            "With no rules, there should be no findings"
        );
        prop_assert_eq!(result.counts.info, 0);
        prop_assert_eq!(result.counts.warn, 0);
        prop_assert_eq!(result.counts.error, 0);
    }

    // Feature: comprehensive-test-coverage, Property: Empty Lines Produce No Findings
    // With no input lines, evaluate_lines SHALL produce no findings.
    // **Validates: Requirements 9.2**
    #[test]
    fn property_no_lines_no_findings(
        rule_config in valid_rule_config_strategy(),
    ) {
        let compiled = compile_rules(&[rule_config]);
        prop_assume!(compiled.is_ok());
        let rules = compiled.unwrap();

        let lines: Vec<InputLine> = vec![];
        let result = evaluate_lines(lines, &rules, 100);

        prop_assert!(
            result.findings.is_empty(),
            "With no input lines, there should be no findings"
        );
        prop_assert_eq!(result.lines_scanned, 0);
    }
}