diffctx 1.15.0

Selects the minimum code an LLM needs to review a git diff: walks the dependency graph outward from changed lines and stops when extra context stops paying for itself
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
pub mod base;
pub mod config_edges;
pub mod document;
pub mod history;
pub mod semantic;
pub mod similarity;
pub mod structural;

use std::cmp::Reverse;
use std::path::{Path, PathBuf};

use rayon::prelude::*;
use rustc_hash::{FxHashMap, FxHashSet};
use tracing::debug;

use crate::graph::{
    CappedEdges, CompactEdge, EdgeCapStats, EdgeCategory, RankedCandidate, SourceTopK,
    SuppressionFactors, cap_out_edges_per_source, dedup_compact_edges, intern_fragment_nodes,
    push_bounded_top_k, read_max_out_edges_per_node,
};
use crate::types::FragmentId;

pub type EdgeDict = FxHashMap<(FragmentId, FragmentId), f64>;
pub type EdgeCategories = FxHashMap<(FragmentId, FragmentId), EdgeCategory>;

use crate::types::Fragment;

use self::base::EdgeBuilder;

/// Raw-weight floor above which a Semantic edge counts as a naming channel
/// (imports/using, calls, type and member refs all sit at >=0.35; tags
/// fallback at 0.30 and same-package/namespace markers at 0.05 stay diffuse).
pub const NAMING_WEIGHT_FLOOR: f64 = 0.30;

const EXPENSIVE_CATEGORIES: &[&str] = &["similarity", "history"];

struct BuilderCategory {
    name: &'static str,
    builders: fn() -> Vec<Box<dyn EdgeBuilder>>,
}

fn builder_categories() -> Vec<BuilderCategory> {
    vec![
        BuilderCategory {
            name: "semantic",
            builders: || semantic::get_semantic_builders(),
        },
        BuilderCategory {
            name: "structural",
            builders: || structural::get_structural_builders(),
        },
        BuilderCategory {
            name: "config",
            builders: || config_edges::get_config_builders(),
        },
        BuilderCategory {
            name: "document",
            builders: || document::get_document_builders(),
        },
        BuilderCategory {
            name: "similarity",
            builders: || similarity::get_similarity_builders(),
        },
        BuilderCategory {
            name: "history",
            builders: || history::get_history_builders(),
        },
    ]
}

pub fn get_all_builders() -> Vec<Box<dyn EdgeBuilder>> {
    let mut all = Vec::new();
    for cat in builder_categories() {
        all.extend((cat.builders)());
    }
    all
}

fn pack_pair(src: u32, dst: u32) -> u64 {
    ((src as u64) << 32) | dst as u64
}

struct LoggedEmission {
    src: u32,
    dst: u32,
    weight: f64,
}

/// Two-pass edge construction that never retains the raw edge universe
/// as keyed dictionaries and runs every builder exactly once.
///
/// Pass 1 runs every builder and records its emissions into a compact
/// per-builder log of (src, dst, weight) triples (16 bytes/edge, builder
/// tag implicit in the outer index); a first-seen scan in builder
/// registration order reproduces `dedup_compact_edges` semantics exactly
/// (each pair counted once, category from the first builder that
/// produced it) and yields per-node in-degree, per-source out-degree,
/// the semantic distinct-file fan counts, and a sorted `(src, dst) ->
/// category` lookup used only internally by pass 2 (below) — it is
/// *not* returned to the caller; `assemble_graph` derives the exported
/// category table from the post-cap edges instead, which is what keeps
/// it aligned with the CSR (see `graph::assemble_graph`).
///
/// Pass 2 replays the log instead of rerunning the builders, damps each
/// emission on the fly with the pass-1 hub-suppression factors — always
/// under the pair's canonical first-builder category — and keeps at most
/// K candidates per source per builder in a bounded min-heap, freeing
/// each builder's log shard as it is consumed. Any edge evicted from a
/// per-builder heap is outranked by K surviving same-source edges, so
/// the final merge + dedup + cap over the survivors is bit-identical to
/// capping the full materialized universe.
pub fn collect_capped_edges(
    fragments: &[Fragment],
    repo_root: Option<&Path>,
    skip_expensive: bool,
    deadline: crate::deadline::Deadline,
) -> CappedEdges {
    let mut all_builders: Vec<(&str, Box<dyn EdgeBuilder>)> = Vec::new();
    for cat in builder_categories() {
        if skip_expensive && EXPENSIVE_CATEGORIES.contains(&cat.name) {
            debug!("skipping {} edge builders (skip_expensive=true)", cat.name);
            continue;
        }
        for builder in (cat.builders)() {
            all_builders.push((cat.name, builder));
        }
    }

    let (node_to_idx, idx_to_node) = intern_fragment_nodes(fragments);
    let category_weights = *crate::config::category_weights::CATEGORY_WEIGHTS;
    let builder_meta: Vec<(EdgeCategory, f64)> = all_builders
        .iter()
        .map(|(cat_name, builder)| {
            let category = EdgeCategory::from_str(builder.category_label().unwrap_or(cat_name));
            (category, category_weights.multiplier(category))
        })
        .collect();
    let fallback_flags: Vec<bool> = all_builders
        .iter()
        .map(|(_, builder)| builder.is_fallback())
        .collect();

    let per_builder_log: Vec<Vec<LoggedEmission>> = all_builders
        .par_iter()
        .enumerate()
        .map(|(builder_idx, (name, builder))| {
            deadline.check("edge construction");
            let _in_builder = deadline.enter();
            let t = std::time::Instant::now();
            let edges = builder.build(fragments, repo_root);
            if std::env::var_os("DIFFCTX_TRACE_BUILDERS").is_some() {
                // The index is the registration order within
                // builder_categories(); category names alone cannot tell two
                // semantic builders apart when one of them floods.
                eprintln!(
                    "builder {name}[{builder_idx}]: {:.1}s, {} edges",
                    t.elapsed().as_secs_f64(),
                    edges.len()
                );
            }
            let mut log = Vec::with_capacity(edges.len());
            for ((src, dst), weight) in edges {
                let (Some(&s), Some(&d)) = (node_to_idx.get(&src), node_to_idx.get(&dst)) else {
                    continue;
                };
                log.push(LoggedEmission {
                    src: s,
                    dst: d,
                    weight,
                });
            }
            log
        })
        .collect();
    drop(all_builders);

    // Fallback builders (tags) only count where the dedicated builders came
    // back empty: an emission survives only if at least one endpoint file has
    // no dedicated semantic edge. Dual coverage was measured as pure noise —
    // a tags edge duplicating a real import/call edge adds mass, not reach —
    // while a parser-degraded file genuinely has nothing else (#131).
    let mut per_builder_log = per_builder_log;
    if fallback_flags.iter().any(|&f| f) {
        let mut dedicated_files: FxHashSet<&str> = FxHashSet::default();
        for (builder_idx, log) in per_builder_log.iter().enumerate() {
            if fallback_flags[builder_idx] || builder_meta[builder_idx].0 != EdgeCategory::Semantic
            {
                continue;
            }
            for e in log {
                dedicated_files.insert(idx_to_node[e.src as usize].path.as_ref());
                dedicated_files.insert(idx_to_node[e.dst as usize].path.as_ref());
            }
        }
        for (builder_idx, log) in per_builder_log.iter_mut().enumerate() {
            if !fallback_flags[builder_idx] {
                continue;
            }
            log.retain(|e| {
                !dedicated_files.contains(idx_to_node[e.src as usize].path.as_ref())
                    || !dedicated_files.contains(idx_to_node[e.dst as usize].path.as_ref())
            });
        }
    }

    let n_nodes = idx_to_node.len();
    let mut in_degree = vec![0u32; n_nodes];
    let mut out_degree = vec![0u32; n_nodes];
    let mut category_entries: Vec<(u32, u32, EdgeCategory)> = Vec::new();
    let mut sem_out_files: FxHashMap<u32, FxHashSet<&str>> = FxHashMap::default();
    let mut raw_by_category: FxHashMap<EdgeCategory, u64> = FxHashMap::default();
    let mut deduped_by_category: FxHashMap<EdgeCategory, u64> = FxHashMap::default();
    let mut seen: FxHashSet<u64> = FxHashSet::default();
    for (builder_idx, log) in per_builder_log.iter().enumerate() {
        let (category, _) = builder_meta[builder_idx];
        *raw_by_category.entry(category).or_default() += log.len() as u64;
        for e in log {
            if !seen.insert(pack_pair(e.src, e.dst)) {
                continue;
            }
            *deduped_by_category.entry(category).or_default() += 1;
            in_degree[e.dst as usize] += 1;
            out_degree[e.src as usize] += 1;
            category_entries.push((e.src, e.dst, category));
            if category == EdgeCategory::Semantic {
                sem_out_files
                    .entry(e.src)
                    .or_default()
                    .insert(idx_to_node[e.dst as usize].path.as_ref());
            }
        }
    }
    drop(seen);
    let mut emissions_by_category: Vec<(EdgeCategory, u64, u64)> = raw_by_category
        .iter()
        .map(|(&category, &raw)| {
            let deduped = deduped_by_category.get(&category).copied().unwrap_or(0);
            (category, raw, deduped)
        })
        .collect();
    emissions_by_category.sort_unstable_by_key(|e| e.0.as_str());
    category_entries.sort_unstable_by_key(|e| (e.0, e.1));

    let mut sem_file_deg = vec![0u32; n_nodes];
    for (&src, files) in &sem_out_files {
        sem_file_deg[src as usize] = files.len() as u32;
    }
    drop(sem_out_files);

    let deduped_edge_count = category_entries.len();
    let factors = SuppressionFactors::from_counters(in_degree, sem_file_deg);
    let max_per_node = read_max_out_edges_per_node();

    let capped_per_builder: Vec<Vec<CompactEdge>> = per_builder_log
        .into_par_iter()
        .enumerate()
        .map(|(builder_idx, log)| {
            let (builder_category, multiplier) = builder_meta[builder_idx];
            let mut per_source: FxHashMap<u32, SourceTopK> = FxHashMap::default();
            for e in log {
                let category = category_entries
                    .binary_search_by_key(&(e.src, e.dst), |c| (c.0, c.1))
                    .map(|k| category_entries[k].2)
                    .unwrap_or(builder_category);
                let damped = factors.damp(e.weight * multiplier, category, e.src, e.dst);
                // Naming classification uses the RAW builder weight: the
                // channel constants are quantized (0.05 markers, 0.30 tags,
                // >=0.35 symbol/file-naming channels), so the floor selects a
                // fixed channel set rather than trading a scalar band; raw
                // rather than damped so a hub-suppressed import keeps its
                // naming status.
                let naming = (category == EdgeCategory::Semantic
                    || category == EdgeCategory::Config)
                    && e.weight > NAMING_WEIGHT_FLOOR;
                push_bounded_top_k(
                    per_source.entry(e.src).or_default(),
                    RankedCandidate {
                        weight: damped,
                        dst: e.dst,
                        category,
                        naming,
                    },
                    max_per_node,
                );
            }
            let mut survivors =
                Vec::with_capacity(per_source.values().map(|h| h.len()).sum::<usize>());
            for (src, heap) in per_source {
                for Reverse(c) in heap {
                    survivors.push(CompactEdge {
                        src,
                        dst: c.dst,
                        weight: c.weight,
                        category: c.category,
                        naming: c.naming,
                    });
                }
            }
            survivors
        })
        .collect();

    let total: usize = capped_per_builder.iter().map(|v| v.len()).sum();
    let mut edges: Vec<CompactEdge> = Vec::with_capacity(total);
    for v in capped_per_builder {
        edges.extend(v);
    }
    dedup_compact_edges(&mut edges);
    cap_out_edges_per_source(&mut edges, max_per_node);

    let nodes_capped = out_degree
        .iter()
        .filter(|&&d| d as usize > max_per_node)
        .count();
    let cap_stats = EdgeCapStats {
        edges_before_cap: deduped_edge_count,
        edges_after_cap: edges.len(),
        edges_dropped_by_cap: deduped_edge_count - edges.len(),
        nodes_capped,
        max_out_edges_per_node: max_per_node,
        emissions_by_category,
    };

    CappedEdges {
        node_to_idx,
        idx_to_node,
        edges,
        cap_stats,
    }
}

pub fn discover_all_related_files(
    changed_files: &[PathBuf],
    all_candidates: &[PathBuf],
    repo_root: Option<&Path>,
    file_cache: Option<&FxHashMap<PathBuf, String>>,
) -> Vec<PathBuf> {
    let mut discovered: FxHashMap<PathBuf, ()> = FxHashMap::default();
    for builder in get_all_builders() {
        for f in
            builder.discover_related_files(changed_files, all_candidates, repo_root, file_cache)
        {
            discovered.entry(f).or_insert(());
        }
    }
    let mut result: Vec<PathBuf> = discovered.into_keys().collect();
    result.sort();
    result
}

/// Files reachable from the core set through naming-class edges only, within
/// `max_depth` hops (#65 per-file admission). Diffuse channels (markers,
/// tags, similarity, structural stars) do not open a file; a file whose only
/// connection is proximity never enters the admissible set.
pub fn naming_reachable_files(
    capped: &CappedEdges,
    core_ids: &rustc_hash::FxHashSet<crate::types::FragmentId>,
    max_depth: usize,
) -> rustc_hash::FxHashSet<std::sync::Arc<str>> {
    let n = capped.idx_to_node.len();
    // Undirected on purpose: a naming edge relates the PAIR of files. For
    // several channels the reverse emission (weight*reverse_factor) lands
    // below the naming floor, so a directed walk would reach the changed
    // set's dependencies but not all of its consumers — measured as 24
    // broken consumer-pull corpus cases (php one-hop, terraform dependents,
    // DI).
    let mut adj: Vec<Vec<u32>> = vec![Vec::new(); n];
    for e in &capped.edges {
        if e.naming {
            adj[e.src as usize].push(e.dst);
            adj[e.dst as usize].push(e.src);
        }
    }
    let mut seen = vec![false; n];
    let mut frontier: Vec<u32> = Vec::new();
    for (i, id) in capped.idx_to_node.iter().enumerate() {
        if core_ids.contains(id) {
            seen[i] = true;
            frontier.push(i as u32);
        }
    }
    let mut files: rustc_hash::FxHashSet<std::sync::Arc<str>> = frontier
        .iter()
        .map(|&i| capped.idx_to_node[i as usize].path.clone())
        .collect();
    for _ in 0..max_depth {
        let mut next = Vec::new();
        for &u in &frontier {
            for &v in &adj[u as usize] {
                if !seen[v as usize] {
                    seen[v as usize] = true;
                    files.insert(capped.idx_to_node[v as usize].path.clone());
                    next.push(v);
                }
            }
        }
        if next.is_empty() {
            break;
        }
        frontier = next;
    }
    files
}

#[cfg(test)]
mod fallback_gate_tests {
    use super::*;
    use rustc_hash::FxHashSet as Set;
    use std::sync::Arc;

    fn frag(path: &str, content: &str, idents: &[&str]) -> Fragment {
        Fragment {
            id: crate::types::FragmentId::new(Arc::from(path), 1, 10),
            kind: crate::types::FragmentKind::Function,
            content: Arc::from(content),
            identifiers: idents.iter().map(|s| s.to_string()).collect::<Set<_>>(),
            token_count: 10,
            symbol_name: None,
        }
    }

    #[test]
    fn tags_edges_survive_only_where_dedicated_builders_came_back_empty() {
        // a.py <-> b.py carry a dedicated import edge; a.py and c.py share an
        // identifier but nothing imports between them. Two .xyz files have no
        // dedicated builder at all and share the same identifier.
        let fragments = vec![
            frag(
                "proj/a.c",
                "#include \"bdep.h\"\nint zzcommonzz;\n",
                &["zzcommonzz"],
            ),
            frag("proj/bdep.h", "int bdecl(void);\n", &["bdecl"]),
            frag(
                "proj/c.c",
                "#include \"ddep.h\"\nint zzcommonzz;\n",
                &["zzcommonzz"],
            ),
            frag("proj/ddep.h", "int ddecl(void);\n", &["ddecl"]),
            frag("proj/u1.xyz", "zzcommonzz here\n", &["zzcommonzz"]),
            frag("proj/u2.xyz", "zzcommonzz there\n", &["zzcommonzz"]),
        ];
        let capped =
            collect_capped_edges(&fragments, None, false, crate::deadline::Deadline::none());
        let node_path = |idx: u32| capped.idx_to_node[idx as usize].path.clone();
        // Category matters: a.py and c.py legitimately share a structural
        // sibling edge; the class under test is the SEMANTIC tags link.
        let has = |a: &str, b: &str| {
            capped.edges.iter().any(|e| {
                if e.category != EdgeCategory::Semantic {
                    return false;
                }
                let s = node_path(e.src);
                let d = node_path(e.dst);
                (s.ends_with(a) && d.ends_with(b)) || (s.ends_with(b) && d.ends_with(a))
            })
        };
        assert!(
            has("u1.xyz", "u2.xyz"),
            "fallback must still connect files no dedicated builder covers"
        );
        assert!(
            !has("a.c", "c.c"),
            "a tags-only link between two dedicated-covered files is the measured noise class (#131)"
        );
    }
}