dictator-rust 0.25.1

Rust language decree for Dictator structural linter
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72

use crate::lint_source;

#[test]
fn detects_pub_after_private_in_struct() {
    let src = r"
struct User {
    name: String,
    age: u32,
    pub email: String,
}
";
    let diags = lint_source(src);
    assert!(
        diags.iter().any(|d| d.rule == "rust/visibility-order"),
        "Should detect pub field after private fields in struct"
    );
}

#[test]
fn detects_pub_after_private_in_impl() {
    let src = r"
impl User {
    fn private_method(&self) {}
    pub fn public_method(&self) {}
}
";
    let diags = lint_source(src);
    assert!(
        diags.iter().any(|d| d.rule == "rust/visibility-order"),
        "Should detect pub method after private method in impl"
    );
}

#[test]
fn accepts_pub_before_private() {
    let src = r"
struct User {
    pub id: u32,
    pub name: String,
    email: String,
}
";
    let diags = lint_source(src);
    assert!(
        !diags.iter().any(|d| d.rule == "rust/visibility-order"),
        "Should accept public fields before private fields"
    );
}

#[test]
fn accepts_impl_with_correct_order() {
    let src = r"
impl User {
    pub fn new(name: String) -> Self {
        User { name }
    }

    pub fn get_name(&self) -> &str {
        &self.name
    }

    fn validate(&self) -> bool {
        true
    }
}
";
    let diags = lint_source(src);
    assert!(
        !diags.iter().any(|d| d.rule == "rust/visibility-order"),
        "Should accept impl with public methods before private"
    );
}