1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
use std::collections::HashSet;
use crate::mir::{Device, Enum, FieldConversion, Unique};
use super::recurse_objects_mut;
/// Checks if all names are unique to prevent later name collisions.
/// If there is a collision an error is returned.
pub fn run_pass(device: &mut Device) -> anyhow::Result<()> {
let mut seen_object_ids = HashSet::new();
let mut generated_type_ids = HashSet::new();
recurse_objects_mut(&mut device.objects, &mut |object| {
anyhow::ensure!(
seen_object_ids.insert(object.id()),
"Duplicate object name found: `{}`",
object.name()
);
for field_set in object.field_sets() {
let mut seen_field_names = HashSet::new();
for field in field_set {
anyhow::ensure!(
seen_field_names.insert(field.name.clone()),
"Duplicate field name found in object `{}`: `{}`",
object.name(),
field.name
);
if let Some(FieldConversion::Enum {
enum_value: enum_value @ Enum { name, variants, .. },
..
}) = field.field_conversion.as_ref()
{
let mut seen_variant_names = HashSet::new();
anyhow::ensure!(
generated_type_ids.insert(enum_value.id()),
"Duplicate generated enum name `{}` found in object `{}` on field `{}`",
name,
object.name(),
field.name,
);
for v in variants.iter() {
anyhow::ensure!(
seen_variant_names.insert(v.id()),
"Duplicate field `{}` found in generated enum `{}` in object `{}` on field `{}`",
v.name,
name,
object.name(),
field.name,
);
}
}
}
}
Ok(())
})
}
#[cfg(test)]
mod tests {
use convert_case::Boundary;
use crate::mir::{Buffer, Cfg, EnumVariant, Field, GlobalConfig, Object, Register};
use super::*;
#[test]
#[should_panic(expected = "Duplicate object name found: `MyBuffer`")]
fn object_names_not_unique() {
let global_config = GlobalConfig {
name_word_boundaries: Boundary::list_from("-"),
..Default::default()
};
let mut start_mir = Device {
name: None,
global_config,
objects: vec![
Object::Buffer(Buffer {
name: "MyBuffer".into(),
..Default::default()
}),
Object::Buffer(Buffer {
name: "MyBuffer".into(),
..Default::default()
}),
],
};
run_pass(&mut start_mir).unwrap();
}
#[test]
#[should_panic(expected = "Duplicate field name found in object `Reg`: `field`")]
fn field_names_not_unique() {
let global_config = GlobalConfig {
name_word_boundaries: Boundary::list_from("-"),
..Default::default()
};
let mut start_mir = Device {
name: None,
global_config,
objects: vec![Object::Register(Register {
name: "Reg".into(),
fields: vec![
Field {
name: "field".into(),
..Default::default()
},
Field {
name: "field".into(),
..Default::default()
},
],
..Default::default()
})],
};
run_pass(&mut start_mir).unwrap();
}
#[test]
#[should_panic(
expected = "Duplicate generated enum name `Enum` found in object `Reg` on field `field2`"
)]
fn duplicate_generated_enums() {
let global_config = GlobalConfig {
name_word_boundaries: Boundary::list_from("-"),
..Default::default()
};
let mut start_mir = Device {
name: None,
global_config,
objects: vec![Object::Register(Register {
name: "Reg".into(),
fields: vec![
Field {
name: "field".into(),
field_conversion: Some(FieldConversion::Enum {
enum_value: Enum {
name: "Enum".into(),
variants: Default::default(),
..Default::default()
},
use_try: false,
}),
..Default::default()
},
Field {
name: "field2".into(),
field_conversion: Some(FieldConversion::Enum {
enum_value: Enum {
name: "Enum".into(),
variants: Default::default(),
..Default::default()
},
use_try: false,
}),
..Default::default()
},
],
..Default::default()
})],
};
run_pass(&mut start_mir).unwrap();
}
#[test]
#[should_panic(
expected = "Duplicate field `Variant` found in generated enum `Enum` in object `Reg` on field `field`"
)]
fn duplicate_generated_enum_variants() {
let global_config = GlobalConfig {
name_word_boundaries: Boundary::list_from("-"),
..Default::default()
};
let mut start_mir = Device {
name: None,
global_config,
objects: vec![Object::Register(Register {
name: "Reg".into(),
fields: vec![Field {
name: "field".into(),
field_conversion: Some(FieldConversion::Enum {
enum_value: Enum {
name: "Enum".into(),
variants: vec![
EnumVariant {
name: "Variant".into(),
..Default::default()
},
EnumVariant {
name: "Variant".into(),
..Default::default()
},
],
..Default::default()
},
use_try: false,
}),
..Default::default()
}],
..Default::default()
})],
};
run_pass(&mut start_mir).unwrap();
}
#[test]
fn duplicate_cfg_generated_enum_variants() {
let global_config = GlobalConfig {
name_word_boundaries: Boundary::list_from("-"),
..Default::default()
};
let mut start_mir = Device {
name: None,
global_config,
objects: vec![Object::Register(Register {
name: "Reg".into(),
fields: vec![Field {
name: "field".into(),
field_conversion: Some(FieldConversion::Enum {
enum_value: Enum {
name: "Enum".into(),
variants: vec![
EnumVariant {
name: "Variant".into(),
cfg_attr: Cfg::new(Some("windows")),
..Default::default()
},
EnumVariant {
name: "Variant".into(),
cfg_attr: Cfg::new(Some("unix")),
..Default::default()
},
],
..Default::default()
},
use_try: false,
}),
..Default::default()
}],
..Default::default()
})],
};
run_pass(&mut start_mir).unwrap();
}
}