deslop 0.2.0

A static analyzer that spots low-context and AI-assisted code patterns across naming, concurrency, security, performance, and test quality.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170

use super::FixtureWorkspace;

fn scan_fixture(fixture_path: &str) -> deslop::ScanReport {
    let workspace = FixtureWorkspace::new();
    workspace.write_file("src/lib.rs", fixture_path);
    workspace.scan()
}

fn assert_rules_present(report: &deslop::ScanReport, rule_ids: &[&str]) {
    for rule_id in rule_ids {
        assert!(
            report
                .findings
                .iter()
                .any(|finding| finding.rule_id == *rule_id),
            "expected rule {rule_id} to fire"
        );
    }
}

fn assert_rules_absent(report: &deslop::ScanReport, rule_ids: &[&str]) {
    for rule_id in rule_ids {
        assert!(
            !report
                .findings
                .iter()
                .any(|finding| finding.rule_id == *rule_id),
            "did not expect rule {rule_id} to fire"
        );
    }
}

#[test]
fn test_rust_advanceplan2_api_rules() {
    let report = scan_fixture(rust_fixture!("api_design_ext/api_positive.txt"));

    assert_rules_present(
        &report,
        &[
            "rust_public_anyhow_result",
            "rust_public_box_dyn_error",
            "rust_borrowed_string_api",
            "rust_borrowed_vec_api",
            "rust_borrowed_pathbuf_api",
            "rust_public_bool_parameter_api",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_api_clean() {
    let report = scan_fixture(rust_fixture!("api_design_ext/api_clean.txt"));

    assert_rules_absent(
        &report,
        &[
            "rust_public_anyhow_result",
            "rust_public_box_dyn_error",
            "rust_borrowed_string_api",
            "rust_borrowed_vec_api",
            "rust_borrowed_pathbuf_api",
            "rust_public_bool_parameter_api",
        ],
    );
}

#[test]
fn test_rust_explicit_bool_mode_switches_are_not_flagged() {
    let report = scan_fixture(rust_fixture!(
        "api_design_ext/explicit_bool_switches_clean.txt"
    ));

    assert_rules_absent(&report, &["rust_public_bool_parameter_api"]);
}

#[test]
fn test_rust_advanceplan2_shared_state_rules() {
    let report = scan_fixture(rust_fixture!("api_design_ext/shared_state_positive.txt"));

    assert_rules_present(
        &report,
        &[
            "rust_pub_interior_mutability_field",
            "rust_global_lock_state",
            "rust_arc_mutex_option_state",
            "rust_mutex_wrapped_collection",
            "rust_rc_refcell_domain_model",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_shared_state_clean() {
    let report = scan_fixture(rust_fixture!("api_design_ext/shared_state_clean.txt"));

    assert_rules_absent(
        &report,
        &[
            "rust_pub_interior_mutability_field",
            "rust_global_lock_state",
            "rust_arc_mutex_option_state",
            "rust_mutex_wrapped_collection",
            "rust_rc_refcell_domain_model",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_serde_rules() {
    let report = scan_fixture(rust_fixture!("api_design_ext/serde_positive.txt"));

    assert_rules_present(
        &report,
        &[
            "rust_serde_untagged_enum_boundary",
            "rust_serde_default_on_required_field",
            "rust_serde_flatten_catchall",
            "rust_serde_unknown_fields_allowed",
            "rust_stringly_typed_enum_boundary",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_serde_clean() {
    let report = scan_fixture(rust_fixture!("api_design_ext/serde_clean.txt"));

    assert_rules_absent(
        &report,
        &[
            "rust_serde_untagged_enum_boundary",
            "rust_serde_default_on_required_field",
            "rust_serde_flatten_catchall",
            "rust_serde_unknown_fields_allowed",
            "rust_stringly_typed_enum_boundary",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_builder_rules() {
    let report = scan_fixture(rust_fixture!("api_design_ext/builder_positive.txt"));

    assert_rules_present(
        &report,
        &[
            "rust_option_bag_config",
            "rust_builder_without_validate",
            "rust_constructor_many_flags",
            "rust_partial_init_escape",
            "rust_boolean_state_machine",
        ],
    );
}

#[test]
fn test_rust_advanceplan2_builder_clean() {
    let report = scan_fixture(rust_fixture!("api_design_ext/builder_clean.txt"));

    assert_rules_absent(
        &report,
        &[
            "rust_option_bag_config",
            "rust_builder_without_validate",
            "rust_constructor_many_flags",
            "rust_partial_init_escape",
            "rust_boolean_state_machine",
        ],
    );
}