deslop 0.2.0

A static analyzer that spots low-context and AI-assisted code patterns across naming, concurrency, security, performance, and test quality.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150

use std::collections::BTreeSet;

use tree_sitter::Node;

pub(super) fn collect_concat_loops(body_node: Node<'_>, source: &str) -> Vec<usize> {
    let string_like_names = collect_string_like_names(body_node, source);
    let mut lines = Vec::new();
    visit_concat_loops(body_node, source, &string_like_names, false, &mut lines);
    lines.sort_unstable();
    lines.dedup();
    lines
}

fn collect_string_like_names(node: Node<'_>, source: &str) -> BTreeSet<String> {
    let mut names = BTreeSet::new();
    visit_string_like_names(node, source, &mut names);
    names
}

fn visit_string_like_names(node: Node<'_>, source: &str, names: &mut BTreeSet<String>) {
    if should_skip_nested_scope(node) {
        return;
    }

    if matches!(node.kind(), "assignment" | "annotated_assignment")
        && let Some(text) = source.get(node.byte_range())
    {
        let trimmed = text.trim();
        if let Some((left, right)) = trimmed.split_once('=')
            && (looks_like_string_literal(right.trim())
                || left.contains(": str")
                || left.contains(":str"))
        {
            for name in assignment_targets(left) {
                names.insert(name);
            }
        }
    }

    let mut cursor = node.walk();
    for child in node.named_children(&mut cursor) {
        visit_string_like_names(child, source, names);
    }
}

fn visit_concat_loops(
    node: Node<'_>,
    source: &str,
    string_like_names: &BTreeSet<String>,
    inside_loop: bool,
    lines: &mut Vec<usize>,
) {
    if should_skip_nested_scope(node) {
        return;
    }

    let next_inside_loop =
        inside_loop || matches!(node.kind(), "for_statement" | "while_statement");

    if next_inside_loop && is_concat_assignment(node, source, string_like_names) {
        lines.push(node.start_position().row + 1);
    }

    let mut cursor = node.walk();
    for child in node.named_children(&mut cursor) {
        visit_concat_loops(child, source, string_like_names, next_inside_loop, lines);
    }
}

fn is_concat_assignment(
    node: Node<'_>,
    source: &str,
    string_like_names: &BTreeSet<String>,
) -> bool {
    let Some(text) = source.get(node.byte_range()) else {
        return false;
    };
    let trimmed = text.trim();

    if node.kind() == "augmented_assignment"
        && trimmed.contains("+=")
        && let Some((left, _)) = trimmed.split_once("+=")
    {
        return assignment_targets(left)
            .into_iter()
            .any(|name| string_like_names.contains(&name));
    }

    if !matches!(node.kind(), "assignment" | "annotated_assignment") {
        return false;
    }

    let Some((left, right)) = trimmed.split_once('=') else {
        return false;
    };
    let names = assignment_targets(left);
    if names.len() != 1 {
        return false;
    }
    let Some(target_name) = names.first() else {
        return false;
    };
    if !string_like_names.contains(target_name) {
        return false;
    }

    let normalized_right = right.replace(' ', "");
    normalized_right.starts_with(&format!("{target_name}+"))
}

fn assignment_targets(text: &str) -> Vec<String> {
    text.trim()
        .split(':')
        .next()
        .unwrap_or(text)
        .split(',')
        .map(str::trim)
        .filter(|candidate| is_valid_identifier(candidate))
        .map(str::to_string)
        .collect()
}

fn looks_like_string_literal(text: &str) -> bool {
    let trimmed = text.trim();
    let quote_index = match trimmed.find(['\'', '"']) {
        Some(index) => index,
        None => return false,
    };
    trimmed
        .get(..quote_index)
        .unwrap_or("")
        .chars()
        .all(|character| matches!(character, 'r' | 'R' | 'u' | 'U' | 'b' | 'B' | 'f' | 'F'))
}

fn is_valid_identifier(candidate: &str) -> bool {
    let mut characters = candidate.chars();
    let Some(first) = characters.next() else {
        return false;
    };
    if !(first == '_' || first.is_ascii_alphabetic()) {
        return false;
    }

    characters.all(|character| character == '_' || character.is_ascii_alphanumeric())
}

fn should_skip_nested_scope(node: Node<'_>) -> bool {
    matches!(node.kind(), "function_definition" | "class_definition")
}